GitLab

effect-reference-tile.html flaky on Win
Passed: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7/builds/47565
Failed: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7/builds/47566

margin_left.html NeedsManualRebaseline (missed in the batch added in r430198)

BUG=662722
NOTRY=true
TBR=fmalita@chromium.org

Review-Url: https://codereview.chromium.org/2479053002
Cr-Commit-Position: refs/heads/master@{#430204}

These failed in
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty/builds/19591
but not in
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty/builds/19590
after being rebaselined in
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty/builds/19588

They seem to rely on hover effects and have a history of flakiness in TestExpectations.

BUG=662722
NOTRY=true
TBR=fmalita@chromium.org

Review-Url: https://codereview.chromium.org/2483743002
Cr-Commit-Position: refs/heads/master@{#430203}

Failing since
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10/builds/16850 (initial landing)
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10/builds/16855 (autorebaseline)

BUG=662722
NOTRY=true
TBR=fmalita@chromium.org

Review-Url: https://codereview.chromium.org/2481673002
Cr-Commit-Position: refs/heads/master@{#430202}

Crashes flakily. Couldn't find a culprit.

BUG=662688
TBR=tzik@chromium.org,boliu@chromium.org

Review-Url: https://codereview.chromium.org/2484543002
Cr-Commit-Position: refs/heads/master@{#430201}

- Add imported/wpt/dom/nodes/Document-createElement*.html which are currently
  failing on the bots.

- Merge tests with crbug.com/619746 into the section of crbug.com/508730.

- Triage some tests associated to crbug.com/508734

BUG=619746, 508730, 508734
TBR=qyearsley@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2476173003
Cr-Commit-Position: refs/heads/master@{#430200}

Blink has some loose heuristics to ignore images, even ones that are important for interaction.

Specifically, web authors do use horizontal images (i.e. 1d images) to convey information to screen readers that is not purely presentational.

At the very least, it should be up to each client to make an intelligent determination.

This cl also adds missing graphics predicates and key bindings to ChromeVox.

BUG=641848
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2479593007
Cr-Commit-Position: refs/heads/master@{#430199}

Since:
Win - https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7/builds/47558
Mac - https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.9/builds/39067
    - https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28dbg%29/builds/5749
HiDpi - https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Precise%20%28dbg%29/builds/914

BUG=662722
NOTRY=true
TBR=fmalita@chromium.org

Review-Url: https://codereview.chromium.org/2481063002
Cr-Commit-Position: refs/heads/master@{#430198}

http://crrev.com/2369673003 introduced code to close the chooser when the
window looses focus. This works great for when the user switches apps but
it sadly causes the chooser to get closed when the permission prompt opens
up. Then when the user accepts the permission request chrome crashes
because the chooser was closed.

Checks if the chooser is still opened before restarting the scan.

Changes the testing framework to simulate a focus change when requesting
permission and adds asserts to make sure native functions are not being
called after the native object has been destroyed.

BUG=661770

Review-Url: https://codereview.chromium.org/2476563002
Cr-Commit-Position: refs/heads/master@{#430197}

BUG=

Review-Url: https://codereview.chromium.org/2387943002
Cr-Commit-Position: refs/heads/master@{#430196}

BUG=662495

Review-Url: https://codereview.chromium.org/2477173002
Cr-Commit-Position: refs/heads/master@{#430195}

https://chromium.googlesource.com/chromium/src/+/96c45c379

BUG=662722
TBR=fmalita@chromium.org

Review URL: https://codereview.chromium.org/2483723002 .

Cr-Commit-Position: refs/heads/master@{#430194}

Fallout from https://codereview.chromium.org/2457393004/

BUG=662722
TBR=liyuqian@chormium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2479023002
Cr-Commit-Position: refs/heads/master@{#430193}

https://skia.googlesource.com/skia.git/+log/9c46b68d5340..f98b730af08d

$ git log 9c46b68d5..f98b730af --date=short --no-merges --format='%ad %ae %s'
2016-11-06 mtklein Call ~SkRasterPipelineBlitter() on early out.

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=scroggo@google.com

Review-Url: https://codereview.chromium.org/2484533002
Cr-Commit-Position: refs/heads/master@{#430192}

Fallout from https://codereview.chromium.org/2457393004/

BUG=662722
TBR=liyuqian@chromium.org,ajuma@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
NOTRY=true

Review-Url: https://codereview.chromium.org/2481663002
Cr-Commit-Position: refs/heads/master@{#430191}

https://skia.googlesource.com/skia.git/+log/301dfc0bba37..9c46b68d5340

$ git log 301dfc0bb..9c46b68d5 --date=short --no-merges --format='%ad %ae %s'
2016-11-06 benjaminwagner Revert "Further centralize computation of GrSurface VRAM consumption"
2016-11-06 benjaminwagner Revert "Limit GL_TEXTURE_RECTANGLE filtering to bilinear."

BUG=662630,662630

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=scroggo@google.com

Review-Url: https://codereview.chromium.org/2480113002
Cr-Commit-Position: refs/heads/master@{#430190}

(This is our third attempt, which has the same diff as our attemp 2 https://codereview.chromium.org/2459433003/)

Update cc_unittests png files to reflect our changes.

We also downgraded some ref tests to pixel tests because
there are some (dR <= 1, dG <= 1, dB <= 1) pixel difference on the
circle boundaries. This seems to be reasonable as the test html usually
has more layers than the ref html. In the future, we may set a
configurable threshold for ref tests so we don't have to downgrade ref
tests for this reason.

This is the clean version of the closed issue
https://codereview.chromium.org/2407393003/ (That issue has too many pngs
(7000+) that cause some troubles with the rietveld.)

We will review this CL, then manually patch all the remaining 7000+ pixel tests
locally, and land it manually.

BUG=

R=fmalita@chromium.org
TBR=ajuma

patch from issue 2407393003 at patchset 20001 (http://crrev.com/2407393003#ps20001)
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review URL: https://codereview.chromium.org/2457393004 .

Cr-Commit-Position: refs/heads/master@{#430189}

https://skia.googlesource.com/skia.git/+log/db64acacf9c4..301dfc0bba37

$ git log db64acacf..301dfc0bb --date=short --no-merges --format='%ad %ae %s'
2016-11-06 update-skps Update SKP version

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=scroggo@google.com

Review-Url: https://codereview.chromium.org/2481013002
Cr-Commit-Position: refs/heads/master@{#430188}

* wptserve:
  Map imported/wpt_automation/ to //web-platform.test:*/wpt_automation/

* testharnessreport.js:
  Use /wpt_automation/ instead of LayoutTests/imported/wpt_automation/ if we run
  tests on WPTServe.

* update-the-source-set-expected.txt
  Rebaseline because it contains line numbers of testharnessreport.js.

BUG=627008

Review-Url: https://codereview.chromium.org/2468283004
Cr-Commit-Position: refs/heads/master@{#430187}

1. Add vector icons ime_menu_on_screen_keyboard.*.icon for on-screen keyboard.
2. Add new class MaterialKeyboardStatusRowView in ImeListView to show the keyboard row: a on-screen keyboard, a label and a toggle button.
3. Makes s shown only for MD and sticky when scrolling.
4. Updates the ImeInfoView as simple Label+Label+Image with TriView. And updates the id size.

* Still needs follow-up CL to make MaterialKeyboardStatusRowView has shadow and shown in opt-in IME menu.

BUG=657146, 642385, 652677
TEST=Verified on local build.

Review-Url: https://codereview.chromium.org/2469663002
Cr-Commit-Position: refs/heads/master@{#430186}

BUG=654684

Review-Url: https://codereview.chromium.org/2469963003
Cr-Commit-Position: refs/heads/master@{#430185}

Use std::unique_ptr instead of deprecated linked_ptr.

BUG=556939

Review-Url: https://codereview.chromium.org/2466523002
Cr-Commit-Position: refs/heads/master@{#430184}

This change implements GetSourceList() and SelectSource() function in all
DesktopCapturer derived classes.

After this change, and https://codereview.chromium.org/2479553006/,
GetSourceList() and SelectSource() can be changed to pure virtual functions in
WebRTC.

BUG=webrtc:6513

Review-Url: https://codereview.chromium.org/2483483004
Cr-Commit-Position: refs/heads/master@{#430183}

Prerequisites for https://codereview.chromium.org/2462753002

Split the aura window icon property into window and app icons.
Add an aura window property of the string application id.
Use aura::client::kAppId for exo ShellSurface remove local copy.

Add WmWindow string properties; icon getters; attention bool.
(WmWindowMus not implemented, as per ongoing mus-aura work)
Add WmWindow::MoveToEventRoot helper. (like ash::wm helper)

BUG=557406
TEST=Existing unit tests; more tested usage forthcoming.
R=sky@chromium.org,reveman@chromium.org

Review-Url: https://codereview.chromium.org/2480713003
Cr-Commit-Position: refs/heads/master@{#430182}

https://skia.googlesource.com/skia.git/+log/525e13c1d318..db64acacf9c4

$ git log 525e13c1d..db64acacf --date=short --no-merges --format='%ad %ae %s'
2016-11-05 stephana Add indexfile to obsolute quickstart section

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=benjaminwagner@google.com

Review-Url: https://codereview.chromium.org/2480023003
Cr-Commit-Position: refs/heads/master@{#430181}

FPS will now be printed to stdout every 5 seconds and the
following flags have been added:

--size=NxM, specifies the client buffer size.

--scale=N, specifies the client scale factor (ie. number
of physical pixels per DIP).

--num-rects=N, specifies the number of rotating rects to draw.

--fullscreen, specifies if client should be fullscreen.

BUG=661010
TEST=wayland-motion-events

Review-Url: https://codereview.chromium.org/2484503002
Cr-Commit-Position: refs/heads/master@{#430180}

The display_services_unittest relies on some Chrome OS specific code.
Add appropriate checks so the FYI bot Ozone Linux doesn't fail on it.

BUG=none

Review-Url: https://codereview.chromium.org/2476663002
Cr-Commit-Position: refs/heads/master@{#430179}

Also apply this new superpower in two places.

BUG=none

Review-Url: https://codereview.chromium.org/2475033003
Cr-Commit-Position: refs/heads/master@{#430178}

This test created a UIWindow and set it as the key window, which seemed to
tickle an iOS9 bug that left the application without a key window at all once
the test finished.  This was causing subsequent tests to fail.

The test passes without this UIWindow, so this CL removes it.

BUG=None

Review-Url: https://codereview.chromium.org/2482713002
Cr-Commit-Position: refs/heads/master@{#430177}

This enum helps to keep track of whether a navigation observed by
ArcNavigationThrottle is continued in Chrome or redirected to a ARC.
Likewise it helps determinating if a navigation is continued in Chrome
or redirected to ARC via the external protocol dialog.

BUG=661672
TEST=try

Review-Url: https://codereview.chromium.org/2476783002
Cr-Commit-Position: refs/heads/master@{#430176}

Cr-Commit-Position: refs/heads/master@{#430175}

https://chromium.googlesource.com/angle/angle.git/+log/bbe9fb5..f097e23

BUG=angleproject:1579,angleproject:1543,angleproject:1609
TEST=bots
TBR=jmadill@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2472983005
Cr-Commit-Position: refs/heads/master@{#430174}

This test has the following leak log:

({"numberOfLiveActiveDOMObjects":[2,3]})

Example results:
https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux_Precise_Leak/1493/layout-test-results/results.html

BUG=662477

Review-Url: https://codereview.chromium.org/2480973002
Cr-Commit-Position: refs/heads/master@{#430173}

This revision contains fixes for the 'alias' feature.

* Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/six/
  New third-party code. WPTServe depends on it.

* Tools/Scripts/webkitpy/thirdparty/wpt/checkout.sh
  - Show the HEAD revision.  It is helpful if WPTHeads contains "master"s to
    check out.
  - Add a workaround of a bug of xargs on macOS.

This CL doesn't affect production, and doesn't affect main layout test bots.

BUG=627008

Committed: https://crrev.com/b4c1192626a5d180457403d2c97ebf5232ddfb81
Review-Url: https://codereview.chromium.org/2476653002
Cr-Original-Commit-Position: refs/heads/master@{#429733}
Cr-Commit-Position: refs/heads/master@{#430172}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/0dad921b..ae24592f

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2476043003
Cr-Commit-Position: refs/heads/master@{#430171}

https://skia.googlesource.com/skia.git/+log/544da7a7c399..525e13c1d318

$ git log 544da7a7c..525e13c1d --date=short --no-merges --format='%ad %ae %s'
2016-11-05 liyuqian Fix the sum of alpha = 254 instead of 255 by rounding
2016-11-04 skia.buildbots Make buildbotless trybots only support Gerrit
2016-11-04 benjaminwagner Attempt to fix PixelC GLSL compilation error.
2016-11-04 mtklein swap_src_dst -> move_src_dst
2016-11-04 mtklein Trim down quick start docs for a GN world.
2016-11-04 msarett Add F16, SkColorSpaceXform support to SkGifCodec
2016-11-04 mtklein Detect pipelines which can compile to memsets.
2016-11-04 caryclark Revert of use reversePathTo in place of addPathReverse (patchset #1 id:1 of https://codereview.chromium.org/2481463002/ )
2016-11-04 msarett Avoid pretending to support CMYK color xforms in SkJpegCodec
2016-11-04 mtklein skrpb: evaluate color filters for constant shaders once.
2016-11-04 caryclark use reversePathTo in place of addPathReverse
2016-11-04 fmalita Deferred image generator subsetting
2016-11-04 bsalomon Improvements to build_command_buffer.py
2016-11-04 benjaminwagner PixelC is also TegraX1, but doesn't have GL.
2016-11-04 halcanary tests: s/SkAutoTUnref/sk_sp/
2016-11-04 benjaminwagner Add note about CQ_INCLUDE_TRYBOTS and -Trybot suffix.
2016-11-04 msarett Fix color xforms for Index8 bmps
2016-11-04 bsalomon Limit GL_TEXTURE_RECTANGLE filtering to bilinear.
2016-11-04 borenet Add the new buildbotless infra-tests bot to the CQ as an experiment
2016-11-04 herb Use alignas to force alignment.
2016-11-04 bsalomon Add documentation for using testing using the command buffer GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2479833003 NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=2479833003
2016-11-04 stephana Re-enable iOS testing
2016-11-03 bungeman Clarify onCreateScalerContext failure modes.
2016-11-04 robertphillips Further centralize computation of GrSurface VRAM consumption

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=benjaminwagner@google.com

Review-Url: https://codereview.chromium.org/2481603002
Cr-Commit-Position: refs/heads/master@{#430170}

Skia CL: https://skia-review.googlesource.com/c/4441/

BUG=
NOTRY=True
TBR=fmalita

Review-Url: https://codereview.chromium.org/2475343003
Cr-Commit-Position: refs/heads/master@{#430169}

Using update-w3c-deps in Chromium 70867569.

TBR=qyearsley@chromium.org

Review-Url: https://codereview.chromium.org/2477133002
Cr-Commit-Position: refs/heads/master@{#430168}

And their respective test classes.

BUG=652719

Review-Url: https://codereview.chromium.org/2464943002
Cr-Commit-Position: refs/heads/master@{#430167}

KURL will re-hash the raw canonicalized output and check the
AtomicStringTable (addWithTranslator) for the string. This can be very
expensive for large URLs.

However, since many URLs are generated from existing AtomicStrings
(which already have their hashes computed), we can use a fast path
and just return the input if it was already canonicalized and hashed.

This optimization shaves 25% off the overhead of loading 1mb data
url images (if the data url is properly canonicalized). Data from
profiling results on Linux.

BUG=348655,657978

Review-Url: https://codereview.chromium.org/2428093002
Cr-Commit-Position: refs/heads/master@{#430166}

Or, if a LayoutObject-derived header is still required, pick the most generic
one possible.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2474603002
Cr-Commit-Position: refs/heads/master@{#430165}