- 07 Mar, 2018 40 commits
-
-
Yutaka Hirano authored
ResourceRequest::fetch_request_context was not set in NavigationURLLoaderNetworkService, which resulted in failure of wpt/fetch/api/request/destination/fetch-destination-iframe.https.html. Bug: 778721 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I595e1a877d3fc7c8dbbd720867fd344d3c88b2ac Reviewed-on: https://chromium-review.googlesource.com/951670Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#541427}
-
Balazs Engedy authored
In order to use MockU2fDiscovery, its consumer needed to have have a very detailed understanding of U2fDiscovery's internal behavior. E.g. needed to set up EXPECT_CALL expectations in way that correctly mimicked the production code's behavior. This is not good encapsulation. Instead, this CL introduces a fake that simulates the real implementation internally, so that consumers of U2fDiscovery need not duplicate that. This CL also adds a ScopedU2fFakeDiscoveryFactory that make it easier for consumers, possibly several layers away, to inject the fake discovery implementations for testing purposes (without real hardware). Bug: 785955 Change-Id: I45989dbc60ce48332590809dae07786deb6b312a Reviewed-on: https://chromium-review.googlesource.com/946469 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Cr-Commit-Position: refs/heads/master@{#541426}
-
Marc Treib authored
This contains two types of changes: - Removing unnecessary uses of unique_ptr. - Replacing many ASSERTs with EXPECTs. Both changes were suggested in https://crrev.com/c/943068. Bug: none Change-Id: Iec2339c00b0191a1ab72a30393b7990d62cb0418 Reviewed-on: https://chromium-review.googlesource.com/951485Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#541425}
-
Bence Béky authored
websocket_handshake_request_info.h, websocket_handshake_response_info.h, websocket_handshake_stream_base.h, and websocket_stream.h occurred twice in net/BUILD.gn. This led to me breaking Cronet build, see https://crrev.com/c/951342. This CL is reconciling the situation by removing the trivial WebSocketHandshakeStreamBase::CreateHelper::DataKey method, and removing one of the two occurrences of these four files in the build file. Change-Id: I5105ba7622a9184a30c66997ca2493bcb622c7e6 Reviewed-on: https://chromium-review.googlesource.com/951929Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#541424}
-
Peter K. Lee authored
Added overloaded PrepareMailtoHandling() with 2 parameters to MailtoHandlerProvider. PrepareMailtoHandling() with 3 parameters is considered deprecated and will be removed in a later CL. BUG=813821 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I4d510eb484b556d1462e9de594bff039aaa14168 Reviewed-on: https://chromium-review.googlesource.com/947097Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#541423}
-
Martin Sramek authored
This is an interim solution until UserEventService is changed to initialize synchronously when first instantiated. See the comment in the added code for more details. Bug: 781765, 819296 Change-Id: I860e7f1294b52a0f58f3281fcc8e76f4cdaf99d7 Reviewed-on: https://chromium-review.googlesource.com/951254Reviewed-by:
Markus Heintz <markusheintz@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#541422}
-
tzik authored
This migrates base::LaunchUnitTests and its relatives to OnceCallback. UnitTestLauncher is a blocker for a small number of components to migrate to OnceCallback, but it's the last blocker for some components. Bug: 714018 Change-Id: I0158f64201c7b4382726331df59fa4101fa1042b Reviewed-on: https://chromium-review.googlesource.com/951023Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#541421}
-
Mohamed Heikal authored
Upstreamed monochrome_apk_checker.py script and set it up so that it is now run by linux_android_rel_ng Bug: 794585 Change-Id: Ie8e4d7c60c4907122e3fa200e3765e7aa733a1ad Reviewed-on: https://chromium-review.googlesource.com/938282 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#541420}
-
https://webrtc.googlesource.com/src.git/+log/9a58cc00e0b2..7dbb701076f3 $ git log 9a58cc00e..7dbb70107 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=None,None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ic88b29befc6c3070a8d665152d5c5fd6d15ed461 Reviewed-on: https://chromium-review.googlesource.com/953024Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#541419}
-
Mostyn Bramley-Moore authored
This fixes the following jumbo build error: /../../third_party/WebKit/Source/modules/xr/XRInputPose.cpp:11:18: error: redefinition of 'transformationMatrixToFloat32Array' DOMFloat32Array* transformationMatrixToFloat32Array( ^ ./../../third_party/WebKit/Source/modules/xr/XRDevicePose.cpp:14:18: note: previous definition is here DOMFloat32Array* transformationMatrixToFloat32Array( ^ 1 error generated. Followup to https://chromium-review.googlesource.com/c/chromium/src/+/919150 Bug: 812287 Change-Id: Iedd5e1337fc14a1e974f6497974e283b03a48c80 Reviewed-on: https://chromium-review.googlesource.com/952444Reviewed-by:Kentaro Hara <haraken@chromium.org> Reviewed-by:
Daniel Bratell <bratell@opera.com> Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com> Cr-Commit-Position: refs/heads/master@{#541418}
-
Matthew Cary authored
gmail-background has begun failing on perf-go-phone. As per crbug.com/777355, this benchmark had already been disabled on Android_Svelte. That does not seem to be sufficient to disable it on Go, however, so this CL disables it for all of android. Bug: 777355 TBR: perezju@chromium.org Change-Id: Iebfac98ba4e773dcf4d4345d69fe1a43a4b66eb5 Reviewed-on: https://chromium-review.googlesource.com/952908Reviewed-by:
Matthew Cary <mattcary@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#541417}
-
Ken Rockot authored
For bug 819556 we now believe it is more likely an IPC::Channel or RenderProcessHost host leak in some fashion. This CHECK is being hit by renderers. Although that's potentially interesting, it does not help us address the original bug. TBR=jcivelli@chromium.org Bug: 819556,813045 Change-Id: I578d6b640815ec8d525df596a8b5d4843164d284 Reviewed-on: https://chromium-review.googlesource.com/953025Reviewed-by:
-
Matthew Cary authored
development/scripts/symbol.py pointed to //third_party/android_tools/ndk, which is now obsolete. Bug: 819568 TBR: agrieve@chromium.org, lizeb@chromium.org Change-Id: I78ae6bc513d6a90a937f2f759dcdab47b8e942c5 Reviewed-on: https://chromium-review.googlesource.com/952906Reviewed-by:
-
https://chromium.googlesource.com/catapult.git/+log/406b235a95c4..6fbfa7cb20f4 $ git log 406b235a9..6fbfa7cb2 --date=short --no-merges --format='%ad %ae %s' 2018-03-07 perezju Revert "[Telemetry] Move apk finding code to Android backend settings" 2018-03-06 perezju [Tracing] Fix merge_traces.py script 2018-03-07 perezju Revert "[Telemetry] Store Android backend settings as namedtuples" 2018-03-06 dtu [pinpoint] Remove login endpoint. 2018-03-06 dtu [pinpoint] Use oauth instead of App Engine users API in /api/new. 2018-03-06 simonhatch Pinpoint - Re-add api_auth.Authorize to new.py 2018-03-06 dtu [pinpoint] Fix blank Job page when Job is first created. 2018-03-06 dtu [pinpoint] Support Gerrit URLs with a revision specified. 2018-03-06 dtu [pinpoint] Fix arguments for patch job and rerun job FABs. 2018-03-06 estevenson [Dashboard] Add M66 to speed releasing dashboard. 2018-03-06 charliea Name Mac BattOr download directory 'Mac' instead of 'darwin' 2018-03-05 benjhayden [results.html] Show All by default. 2018-03-06 tiborg [vr] Add metrics for render step to frameCycleDurationMetric 2018-03-06 jbudorick [devil] Initialize WeakConstant values on their own thread. 2018-03-02 perezju [Telemetry] Store Android backend settings as namedtuples 2018-03-06 dproy More precise self time calculation 2018-03-05 etienneb Remove the 'deleted' suffix on path name 2018-03-06 perezju [soundwave] Add integration test for FetchAlertsData 2018-03-05 dtu [pinpoint] Use data binding for <change-details>. 2018-03-05 chiniforooshan Tracing: CPU time computation clean up 2018-03-05 dtu [pinpoint] Create a <job-charts> element to wrap the two Job page charts. 2018-03-04 dtu [dashboard] Skip memcache for responses that are over the size limit. 2018-02-27 dtu [pinpoint] Add "user" field to Job. 2018-03-05 azb.0x7dc [Telemetry] Replace TestOutputStream with StringIO 2018-03-04 dtu [pinpoint] Delete future tasks for failed jobs. 2018-03-02 tiborg [vr] Fix submit_frame of frameCycleDuration metric 2018-03-02 eakuefner [Telemetry] Filter histograms when importing with same logic as AddHistogram 2018-03-02 perezju [Telemetry] Move apk finding code to Android backend settings 2018-03-02 perezju [Soundwave] Separate bug id from alert status Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I86ac91ceeab383a1f763b87b78940631b004a887 Reviewed-on: https://chromium-review.googlesource.com/951671Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#541414}
-
jdoerrie authored
TBR=wangxianzhu Bug: 819591 Change-Id: I5580ac037f5d6634a5d76708a0ff8c7dbd73c53a Reviewed-on: https://chromium-review.googlesource.com/951788Reviewed-by:
-
Jani Hautakangas authored
static constexpr member data is incorrectly initialized as static const data. Bug: 819294 Change-Id: I96f06032e00b6bd4d2b5df0ed9b466028453912b Reviewed-on: https://chromium-review.googlesource.com/945997Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Commit-Queue: Jani Hautakangas <jani.hautakangas@lge.com> Cr-Commit-Position: refs/heads/master@{#541412}
-
Christopher Lam authored
This CL adds Closure Compilation via GN to the site engaement WebUI. To do this, the following was implemented: - a JS externs generator was written for mojo - a Mojo externs file was added the third_party/closure_compiler - type annotations were added/updated for site_engagement.js - the webui_closure_compile target was reinstated in BUILD.gn - an extra_deps arg was added to the js_binary template Bug: 632206 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Id770a8a351affd5226e46837998d021640f51a0c Reviewed-on: https://chromium-review.googlesource.com/936349 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#541411}
-
Hajime Hoshi authored
This is part of efforts to replace base::ThreadTaskRunnerHandle::Get() and SequencedTaskRunnerHandle::Get() with other appropriate task runners in the renderer. This avoids the SequencedTaskRunnerHandle::Get() call when the constructor's default parameter is used. We are trying to ban SequencedTaskRunnerHandle::Get() in content/renderer because it usually is not the right task runner to use, as a per-frame runner should be used instead. In this case, it doesn't really matter since frames are not involved, but we still want to remove the calls for the bigger benefit of banning it in content/renderer. Bug: 786332 Change-Id: Ie4774c11b5c8a69985a7fb5ba583429426069d48 Reviewed-on: https://chromium-review.googlesource.com/942702Reviewed-by:
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c2a9fb06..b2a75aa2 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I75050e8ecd6688effeaa88e7c7d37e8b221e4da8 Reviewed-on: https://chromium-review.googlesource.com/952982Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#541409}
-
Greg Kraynov authored
When scheduler/base will be moved to //base we can't use Blink types. Bug: 783309 Change-Id: I1d9bada5a08129a885e9fe6d2f75a02c80e03183 Reviewed-on: https://chromium-review.googlesource.com/943565Reviewed-by:
Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Greg Kraynov <kraynov@chromium.org> Cr-Commit-Position: refs/heads/master@{#541408}
-
François Beaufort authored
The "Picture-in-Picture" video context menu is now enabled only if Picture-in-Picture is enabled for this element. Bug: 726621 Change-Id: If36b5881fdd16c910d399f2dab3ca36b7914c90e Reviewed-on: https://chromium-review.googlesource.com/950945 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
apacible <apacible@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
-
Daniel Bratell authored
GetCommandLine is a win32 API macro defined to GetCommandLineW. Depending on whether <windows.h> is included of not, code using that name will either get the intended name or GetCommandLineW. In some build configuration this caused problems when a base class had GetCommandLine() but the sub class by accident defined GetCommandLineW. This patch renames it to GetBrowserCommandLine() which also matches its more exact documentation. Change-Id: I882b3f650c97802ec7618a797f93f22e9788078f Reviewed-on: https://chromium-review.googlesource.com/951584Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#541406}
-
Chromium WPT Sync authored
Using wpt-import in Chromium e9a30c16. With Chromium commits locally applied on WPT: 14350ac7 "[PE] Don't truncate table cell's padding" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/13438 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: alexander.shalamov@intel.com, mikhail.pozdnyakov@intel.com, rijubrata.bhaumik@intel.com, timvolodine@chromium.org: external/wpt/generic-sensor rouslan@chromium.org, mathp@chromium.org: external/wpt/payment-request TBR=robertma No-Export: true Change-Id: Id9370b73d353d090d83117bc4290650e4e2e0f88 Reviewed-on: https://chromium-review.googlesource.com/952325 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#541405}
-
Marton Hunyady authored
Also enable policy tests since M67 is in dev. Bug: 813036 Change-Id: Ice23465d1734fd010e01f734791f0ccf776bb663 Reviewed-on: https://chromium-review.googlesource.com/943062 Commit-Queue: Marton Hunyady <hunyadym@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#541404}
-
Ulan Degenbaev authored
This relands commit d690c638. Original change's description: > [heap-profiler] Merge DOM node and its JS wrapper node in heap snapshot. > > Each DOM node has a corresponding JS wrapper node. In heap snapshot > they appear as duplicates. > > Example retaining path with duplicates: > - [1] in InternalNode @2041178784 > - [1] in HTMLDivElement @2041079168 // DOM node > - [3] in HTMLDivElement @2231// JS wrapper > - retainer in Window / @2105 > > The heap snapshot generator now can merge an embedder node with a node > returned by EmbedderGraph::Node::WrapperNode() function. > > This patch implements the WrapperNode() function for each DOM node. > > Bug: chromium:811925 > Change-Id: I9ea6bc7e45f8ab3d54828b9ac61f7230d04d8019 > Reviewed-on: https://chromium-review.googlesource.com/928503 > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Commit-Queue: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#539132} Change-Id: I4223d1369874ad34dfff1a74d5725360c360300c Reviewed-on: https://chromium-review.googlesource.com/951252 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
Mark Cogan authored
When the tab grid appears as part of an animated transition, the toolbars should drop down to animate into position. This CL implements this by triggering that animation in -viewWillAppear: and using the view controller's transition coordinator's -animateAlongsideTransition: method. The timing/details of this animation aren't final, but can easily be tweaked. Bug: 804538 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I20f322684598e5dcfbace21d5f928b41414658f0 Reviewed-on: https://chromium-review.googlesource.com/950944 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#541402}
-
Yutaka Hirano authored
They are no longer failing / flaky. Bug: 778721 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I5f68782329feae627b07f08d1dbf9a64b0f47f3c Reviewed-on: https://chromium-review.googlesource.com/952121Reviewed-by:
-
Ramya Vadlamudi authored
Computed value on elements is by default 'normal' and on :before and :after computes to 'none' Spec: https://www.w3.org/TR/CSS2/generate.html#content BUG=788904 Change-Id: Iefd07961445b057d9f893e057f35b082c214454d Reviewed-on: https://chromium-review.googlesource.com/942126Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Ramya Vadlamudi <ramya.v@samsung.com> Cr-Commit-Position: refs/heads/master@{#541400}
-
Kent Tamura authored
We'll move third_party/WebKit/Source to third_party/blink soon. We don't need to update SPECIAL_CASES yet. Change-Id: I7ecae51fdd89c25e92873ed8894ab579d12f6692 Bug: 622551 Reviewed-on: https://chromium-review.googlesource.com/952376Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#541399}
-
Jan Krcal authored
This CL renames the class to ClientTagBasesModelTypeProcessor that a) does not make the impression that its instance is shared b) uses a specific trait that distinguish this from other ModelTypeProcessors. Bug: none Change-Id: Ib5b3d9bb746a5667345dca07fe2a2306d315fca8 Reviewed-on: https://chromium-review.googlesource.com/951245Reviewed-by: -
https://chromium.googlesource.com/angle/angle.git/+log/8f184ae9de06..065aa863f706 $ git log 8f184ae9d..065aa863f --date=short --no-merges --format='%ad %ae %s' 2018-02-22 oetuaho Generate code for unmangled name lookup Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I2ca86a2b0eeba7c59148fd0df9b9cf4619371aa7 Reviewed-on: https://chromium-review.googlesource.com/952945 Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#541397}
-
Marek Haranczyk authored
//content/browser/accessibility/accessibility_event_recorder_win.cc in this target is missing required lib on win in component builds. In non-component oleacc.lib is added indirectly through //content/browser:for_content_tests -> //content/browser dependency chain. The change fixes missing AccessibleObjectFromWindow symbol linking error for content_unittests and webkit_unit_tests in component build. BUG: 818856 Change-Id: I1253bbbff5ca346f2fe4f81d0fc71834bb158222 Reviewed-on: https://chromium-review.googlesource.com/951383 Commit-Queue: Marek Haranczyk <mharanczyk@opera.com> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#541396}
-
David 'Digit' Turner authored
This CL is an attempt to document the rather sophisticated use and content of .build_config files when building various Android-specific targets with GN for Chromium. - Add a new documentation build_config.md under android/build/docs/ - Add documentation for the .build_config file format itself as a Markdown document inside of write_build_config.py to make it easier to update the documentation along side the script in the future. See build_config.md for extraction + visualization instructions. + Add missing links to Android Build markdown files to docs/README.md + Reformat coverage.md a little to make it readable. R=agrieve@chromium.org,yfriedman@chromium.org,estevenson@chromium.org Bug: None Change-Id: Ic9bb61e50d578d69dea4ebc721d41feb9f68a5cb Reviewed-on: https://chromium-review.googlesource.com/949463 Commit-Queue: David Turner <digit@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#541395}
-
Yoshifumi Inoue authored
Rewrite editing/selection/extend-backward-by-word-over-non-editable.html to utilize selection_test() This patch changes "extend-backward-by-word-over-non-editable.html" to utilize |selection_Test()| for ease of maintenance. Bug: 679977 Change-Id: I5e034ff14e9e779255a2fcf67608a2db47913e29 Reviewed-on: https://chromium-review.googlesource.com/950703Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#541394}
-
Harald Alvestrand authored
Two FAIL -> PASS transitions. Bug: chromium:819118 Change-Id: Icbf845ac70ee1dbc4838e16a71ef1c2864c2c2ed Reviewed-on: https://chromium-review.googlesource.com/952902Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#541393}
-
Takashi Toyoshima authored
This is a preparation to merge the source origin and the fetcher origin in Resource. Now the source origin is set when the Resource is cacheable, or for preloads. With this logic, in most cases, SetSourceOrigin is called twice, or isn't called for some cases that do not need the origin for managing the memory cache. This patch makes the origin available on each Resource creation so that all Resource instances can have it to be used for another purpose, e.g. caching meta information for SW, and so on. Bug: 803766 Change-Id: Ib03fbe52f473d6cf70a5920c94f4bf421d851334 Reviewed-on: https://chromium-review.googlesource.com/940364Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#541392}
-
David Roger authored
EasyUnlockService was creating the CryptAuthDeviceManager during its Shutdown() method, which is not supported by the KeyedService infrastructure. Bug: 810092 Change-Id: I1261d459ba156d94caef9c54b714e26cc5d5b2f4 Reviewed-on: https://chromium-review.googlesource.com/950946Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#541391}
-
Marc Treib authored
These two test classes still used the TWO_CLIENT_LEGACY test type, but they actually both work fine with regular TWO_CLIENT. Bug: 565559 Change-Id: Icdc4fd374b298a9424b27974190108c429c925da Reviewed-on: https://chromium-review.googlesource.com/950942Reviewed-by:
-
Marc Treib authored
It's not used anywhere. Bug: none Change-Id: I343aa9b6280c312c76386488cb9499f6134a7c95 Reviewed-on: https://chromium-review.googlesource.com/946089Reviewed-by:
vitaliii <vitaliii@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#541389}
-
tzik authored
This updates //sql to use base::RepeatingCallback instead of legacy base::Callback. No intended functional change is included. This reduces the number of 'base::Bind' in //sql from 19 to 1 as tracked at http://goo.gl/LUVhDj Bug: 714018 Change-Id: I4b6b321e25f2b3db7ab7ac3e09d9ee74761db230 Reviewed-on: https://chromium-review.googlesource.com/952116 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#541388}
-
