GitLab

Today if --trace-startup is used and --trace-startup-duration has not
elapsed by the time the layout test harness completes, no trace will
be recorded. Similarly, if --trace-shutdown is specified no trace
will ever be recorded.

Both cases are due to the fact that the layout test runner kills the
content shell process instead of waiting for it to shutdown in an
orderly fashion.

This change modifies the layout test harness to wait for driver shutdown
when either --trace-startup or --trace-shutdown is specified; it uses
the default_driver_stop_timeout() (3s) to wait for shutdown.

BUG=none
TEST=none

Change-Id: Ifcdc600e519058a9c16839fa432a79aa76d7a34e
Reviewed-on: https://chromium-review.googlesource.com/915544
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537387}

BUG=808838
TEST=./browser_tests --gtest_filter=*/ServiceWorkerTest.MimeHandlerView*

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I82e75c200091babbab648a04232db47e2938d914
Reviewed-on: https://chromium-review.googlesource.com/914150
Commit-Queue: Rob Wu <rob@robwu.nl>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537386}

- Linux limits address space. On 64 bit systems, we may allocate
  multiple guarded memory regions which exceed this limit. Attempt to
  raise the limit when making large reservations.
- Lower the limit when releasing large guarded allocations.

Bug: chromium:799573
Change-Id: Ied5694b541780914fc05c5e4f0f9a1338a2901e4
Reviewed-on: https://chromium-review.googlesource.com/922913
Commit-Queue: Bill Budge <bbudge@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537385}

Tone was provided by UX team.

Bug: 812703
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I2f6010e381831ff622a2c23734c5363e00fe107d
Reviewed-on: https://chromium-review.googlesource.com/922393
Commit-Queue: Katie Dektar <katie@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537384}

https://pdfium.googlesource.com/pdfium.git/+log/067a44fcad91..53279b1dcaba

$ git log 067a44fca..53279b1dc --date=short --no-merges --format='%ad %ae %s'
2018-02-16 tsepez Avoid 100 blank FX_FONTDESCRIPTOR entries.
2018-02-16 npm Add ASSERT to check OOB m_CharCodes
2018-02-16 tsepez m_pEnumerator only ever has one value, indirection not needed.
2018-02-16 hnakashima Implement operator<< for CFX_Rect and CFX_RectF.

Created with:
  roll-dep src/third_party/pdfium


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I103ba69db7bad8165594bbaa21b84eaf642415cc
Reviewed-on: https://chromium-review.googlesource.com/923549
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#537383}

UIScrollView does not send a |-didEndDecelerating| to its delegate after
pixel alignments, so the MainContentUIState should not be considered
decelerating if the target contentOffset is less than a pixel away from
the current value.

This will correctly update the MainContentUIState's |scrolling|
property to NO, allowing the FullscreenScrollEndAnimator to start.

Bug: 800757
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I4407bf34c4a6c5cb485bba01528c34cf9e86c156
Reviewed-on: https://chromium-review.googlesource.com/922888Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537382}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/c0a22f5a..455a5336

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: I4cc871e062c7d75356b38db4eb225b6e245db628
Reviewed-on: https://chromium-review.googlesource.com/923526Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537381}

This reverts commit a20415fc.

Reason for revert: The WebKit Mac tests started timing out at build #12953:
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac10.11%20%28dbg%29

This is a speculative revert (it looks like it's one of four CLs).

Original change's description:
> Enable jumbo/unity build for //content test support targets
> 
> Change-Id: Ibc5e0d946c57a4a3be7fc24a9c0773ec830514f0
> Reviewed-on: https://chromium-review.googlesource.com/922822
> Reviewed-by: Scott Violet <sky@chromium.org>
> Commit-Queue: Jens Widell <jl@opera.com>
> Cr-Commit-Position: refs/heads/master@{#537257}

TBR=sky@chromium.org,jl@opera.com

Change-Id: I02a3fe896f7d88f98eb6b34e6cb3c59ae8747760
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/923578Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Commit-Queue: Dave Schuyler <dschuyler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537380}

Since non-lazy generated images in paint recordings bypass the image
cache in PlaybackImageProvider, we fail to serialize them in OOP raster.
This change adds support for maintaining the uploads for these images in
the GPU cache and serializing them for OOP.

R=ericrk@chromium.org

Bug: 806313
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I1a084b69957d6e3ab74a4e03627d9c5026df1e3e
Reviewed-on: https://chromium-review.googlesource.com/912692
Commit-Queue: Khushal <khushalsagar@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537379}

The correct "no process" id is not 0; use instead
content::ChildProcessHost::kInvalidUniqueID (-1).

The correct "no view/frame" id is not 0; use instead
MSG_ROUTING_NONE (-2).

In addition, guest_render_view_id is not actually used,
so remove it.

BUG=390749

Change-Id: Iaf0510b00e8646f71d23eee2c9309e64f59e0903
Reviewed-on: https://chromium-review.googlesource.com/922802Reviewed-by: Olga Sharonova <olka@chromium.org>
Reviewed-by: Justin Schuh <jschuh@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537378}

In patch https://chromium-review.googlesource.com/906830 we renamed cc
side animation related classes but it missed a test file listed in the
subject. It should be fixed prior to next renaming patch.

Bug: 807667
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: Ib8c86a9f28b12b6a298f5d284c7ceb7171db1958
Reviewed-on: https://chromium-review.googlesource.com/924172Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537377}

This change helps disambiguate between TaskTracker::RunTask and the
upcoming TaskTracker::DirectlyRunTask, which will run a task outside
the context of a sequence.

Bug=749312

Change-Id: I9996d8764c5e505325a64dd0a211e8c84393397b
Reviewed-on: https://chromium-review.googlesource.com/923163
Commit-Queue: François Doray <fdoray@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537376}

Tick fling animations at the beginning of the frame, on the renderer
side. This is done by calling OnComputeScroll directly from
SynchronousCompositorProxy::OnBeginFrame rather than sending the ipc
message from the browser side. However, we have to send the ipc once,
since we shouldn't tick fling animations if a view has overridden
OnComputeScroll.

Previously, draws after calls to OnComputeScroll were synchronous so
that child views would scroll with the webview. This change makes draws
after OnComputeScroll asynchronous and ticks fling animations during
BeginFrame.

Bug: 801759
Change-Id: Iaf95ecc44586ae212630602b38b3ab570b27132b
Reviewed-on: https://chromium-review.googlesource.com/894176
Commit-Queue: James Wallace-Lee <jamwalla@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537375}

This change eliminates memory copies when mojo determines that the
destination port is within the sender's process. With lazy
serialization in place, ArrayBuffers and ImageBitmaps are not actually
serialized if the ports are in the same process.

This is essentially Option #2 in https://docs.google.com/document/d/17o_cjtc3Gk5cDZhoUc37EyhhvBb4wMlCROJvoC2Aokg/edit#heading=h.cyzhzcigg93g

BUG=chromium:659037

Change-Id: Iab2b0d4708b3289e953fc84d2ddd01341bfc2d2e
Reviewed-on: https://chromium-review.googlesource.com/854240
Commit-Queue: Malcolm White <malcolmwhite@google.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537374}

Bug: 808113
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I2b475e6fd474c900ed1984010d15a3e1e31c2af0
Reviewed-on: https://chromium-review.googlesource.com/922930
Commit-Queue: Daniel Blakemore <danblakemore@google.com>
Reviewed-by: Peter Lee <pkl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537373}

Shadowed variables can make code harder to read. Don't support them
in the content layer.

BUG=794619

This CL was uploaded by git cl split.

R=kbr@chromium.org

Change-Id: I90d8149cf7352e70793b2d4b7e94ffe33f3f7b72
Reviewed-on: https://chromium-review.googlesource.com/924162Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537372}

This implements the hooks from the LayoutCustom object into a web
developer defined layout class.

See: https://drafts.css-houdini.org/css-layout-api/#invoke-a-layout-callback

Currently the only useful thing this does to allow the web developer to
return an "auto" block-size, e.g.

registerLayout('foo', class {
  *intrinsicSizes() {}
  *layout() {
    return { autoBlockSize: Math.random() * 100; } // FUN!
  }
});

The engine calculates the inline-size, and adjusts the block-size for the
web developer. This is a simplification on the current API as spec'd but
we'll see what the HoudiniTF thinks of this approach.

The other large behaviour change is appropriate "fallback" handling when
something goes wrong. See "fallback" tests.

Bug: 726125
Change-Id: I08cd2e439f4321bd534a4e3f7222fbdb898e1785
Reviewed-on: https://chromium-review.googlesource.com/917423Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537371}

Shadowed variables can make code harder to read. Don't support them
in the content layer.

BUG=794619

This CL was uploaded by git cl split.

R=haraken@chromium.org

Change-Id: I294dede7daefd705b508bb78c4bf0c2dedc8a2a9
Reviewed-on: https://chromium-review.googlesource.com/924170Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537370}

This removes the ExperienceSamplingPrivate extension API, which was used
only by the CUES extension (which is no longer in use). This also
removes all the instrumentation code that triggered the extension events
throughout the code base, and deprecates entries in enums.

Bug: 810420
Change-Id: Ia155ad3feada4bac147f0960e05065c44d6978a3
Reviewed-on: https://chromium-review.googlesource.com/915121
Commit-Queue: Christopher Thompson <cthomp@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Adrienne Porter Felt <felt@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537369}

Bug: 812710
Change-Id: I4344c258668c5017a0a145e487ca2eb526bd49bc
Reviewed-on: https://chromium-review.googlesource.com/923281Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#537368}

Shadowed variables can make code harder to read. Don't support them
in the content layer.

BUG=794619

This CL was uploaded by git cl split.

R=bauerb@chromium.org

Change-Id: I5743df2f237a1dd0f88e880b96abf6a0aea3b1d3
Reviewed-on: https://chromium-review.googlesource.com/924165Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537367}

https://skia.googlesource.com/skia.git/+log/f6f7b67ac230..50d4a6a66190

$ git log f6f7b67ac..50d4a6a66 --date=short --no-merges --format='%ad %ae %s'
2018-02-16 skcms-skia-autoroll Roll skia/third_party/externals/skcms/ c42baa572..0fb1530a0 (1 commit)
2018-02-16 bsalomon Fix nullptr access when ProcessorOptimizationValidationTest fails
2018-02-16 herb Add a generalized array of bytes with a given alignment
2018-02-16 jvanverth Add an actual config for GPU NativeFonts tests
2018-02-15 mtklein register SIGTERM handler in DM
2018-02-15 caryclark improve bookmaker defines and references
2018-02-15 brianosman Fix flicker when changing backend on iOS viewer
2018-02-15 fmalita Generic "directory" viewer slide
2018-02-15 brianosman Avoid creating MIPs until necessary when MIP bias is active

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=caryclark@chromium.org

Change-Id: Iae44bed11eac4789d4da0d99368ad2ffc808b56f
Reviewed-on: https://chromium-review.googlesource.com/924264
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#537366}

Bug: 780960
Change-Id: I14e6af96907933791e11690e4268af2fa00624c8
Reviewed-on: https://chromium-review.googlesource.com/920721
Commit-Queue: rajendrant <rajendrant@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537365}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=mmoss@chromium.org

Change-Id: I30f5818ba05186b917e88c64fe7f21ff7255a12a
Reviewed-on: https://chromium-review.googlesource.com/924088Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537364}

This removes the necessity of including content_verifier_delegate.h
where only ContentVerifierKey would be required.

Bug: 796395
Change-Id: Icf18f2957291c454c6e8a6971f98be7f9fd2fb78
Reviewed-on: https://chromium-review.googlesource.com/922925
Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537363}

This CL adds logic to cancel all scrubbing state in MediaControlsImpl
and MediaControlTimelineElement when the controls are hidden. This fixes
a bug where if the controls were hidden while scrubbing, the timeline
would continue to handle touchmove events and scrub.

Bug: 810313
Change-Id: Iaa14e559e2f0b077df0d50043bb148bfb195a7a1
Reviewed-on: https://chromium-review.googlesource.com/912113Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537362}

To correctly implement poisson process sampling, we occasionally have to take
multiple samples from a single allocation. Since the memlog stream format does
not support a "count" or "weight" parameter, use "sz" as a proxy.

Bug: 810748
Change-Id: Ie87be75b0915afd5d032943f8a42cb5a190ce6e5
Reviewed-on: https://chromium-review.googlesource.com/922982Reviewed-by: Primiano Tucci <primiano@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537361}

In some cases, and on user's machines per bug reports, writev() performs
a short write. The child process receives an invalid profile and tabs
fail to launch. This switches to using a sequence of write() calls to
send the buffer length, and then send the buffer in a loop.

Bug: 801889
Change-Id: Ib1f4c57c61d3ce68b875b347de480f514100d3c2
Reviewed-on: https://chromium-review.googlesource.com/920765Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Greg Kerr <kerrnel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537360}

Shadowed variables can make code harder to read. Don't support them
in the content layer.

BUG=794619

This CL was uploaded by git cl split.

R=paulmeyer@chromium.org

Change-Id: I0151100128e83c9746375ad898dac8bfc1a89e0e
Reviewed-on: https://chromium-review.googlesource.com/923345Reviewed-by: Paul Meyer <paulmeyer@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537359}

Parallel download system currently can't determine if the last slice is
finished, and always sends a new request after the last byte during
resumption, which may be out of range request if the last piece is
finished before other pieces. Servers must send HTTP 416 to make the
download complete or the download will fail.

This CL updates the database schema for parallel download slices table,
and uses the new column data to determine the actual file length
during resumption. So we don't need to send out of range request, which
is unneccessary and rely on server's good behavior.


Bug: 766737
Change-Id: I6e864dd3e01e511c0b770facc1c452a50e6c913c
Reviewed-on: https://chromium-review.googlesource.com/910688
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537358}

There is no unit test for tapping OK and Cancel buttons, because
it's something that is very hard to test in unit test (buttons are
not tappable unless the UI got synchronized).

UI mock: https://docs.google.com/presentation/d/1GzbAoJrpW9IAQF78afh5SZLWJWErNcC67t_ctujjEus/edit#slide=id.g2b7a689b42_0_196

Bug: 791806
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ic291ef5db83eaea4220ff1ed3f9501020de7389f
Reviewed-on: https://chromium-review.googlesource.com/919492Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537357}

This attempts to address crashes where the GPU process is hanging trying
to contact launchservicesd. It attempts to address these crashes by
allowing access to the lsdb.mapdb launchservices endpoint, which exposes
less attack surface than the full launchservicesd.

Bug: 812228
Change-Id: I1f44bad960d1d07fda622a4d5ad957b281c96792
Reviewed-on: https://chromium-review.googlesource.com/923126Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Greg Kerr <kerrnel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537356}

We don't need to do user-friendly stuff like:
* configure repositories or sources
* map NSS libraries for repo

This was copied from Chrome, but the .deb is just a packaging mechanism
for us.

Bug: 714465
Change-Id: I21cdaebbc5cf420427b4b912812f8197d18ff5a7
Reviewed-on: https://chromium-review.googlesource.com/923288Reviewed-by: Michael Moss <mmoss@chromium.org>
Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537355}

Shadowed variables can make code harder to read. Don't support them
in the content layer.

BUG=794619

This CL was uploaded by git cl split.

R=tdresser@chromium.org

Change-Id: Ic062c1ef20684790628223113ee62e577b374e9e
Reviewed-on: https://chromium-review.googlesource.com/924166Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537354}

These do not need base::ResetAndReturn, use std::move(callack).Run()
instead.

Change-Id: Ifa90ffffcae8e64fd8cced276e482b3ecf21d6a9
Bug: 812717
Reviewed-on: https://chromium-review.googlesource.com/920645Reviewed-by: Ben Wells <benwells@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537353}

Apparently a line like:

// foo

in the filter file results in all the other lines of the filter file
being ignored. This meant ash_unittests --mash on the bots wasn't
running any tests. Fixing the line shows a bunch of new tests are
failing. I've added them to the end and file a bug to recategorize
them.

I'll fix the bug in the filter file parsing separately.

BUG=813115
TEST=test only changes

Change-Id: If27f6e0738c4571c60e16bf87db6ba5cfac5cea3
Reviewed-on: https://chromium-review.googlesource.com/924270Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537352}

A main thread compositable animation means that this animation should
be composited such as an opacity or 2d transform, but it is not due to
certain check such as
RuntimeEnabledFeatures::TurnOff2DAndOpacityCompositorAnimationsEnabled
which is designed to be used for an experiment described in
crbug.com/754471.

Currently our logic is:
1. Check if the effect (such as opacity) can start on compositor or not
2. If 1 is true, and the target element is not paint into its own
   backing + the target element is not a SVG, then it is a main thread
   compositable animation.

This logic is over complicated. We should really just check whether the
run time flag is enabled or not. So this CL simplifies it. We already have
unit test in CompositorAnimationsTest to ensure that this change is
fine.

Bug: 781305
Change-Id: I8f9a1d82fa60eea79018c6cf777a1b45bd565022
Reviewed-on: https://chromium-review.googlesource.com/919316
Commit-Queue: Xida Chen <xidachen@chromium.org>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537351}

Exposes a getter and setter for focus_source_ on OmniboxEditModel and
uses them directly to track the focus source (omnibox or fakebox),
instead of relying on a workaround for Linux and using caret visibility
as a proxy.

Bug: 807600
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I6e23c77ca7c8cac39e07cc45c351b076a9183d1c
Reviewed-on: https://chromium-review.googlesource.com/894325
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537350}

It won't be necessary to call base::ResetAndReturn. Use std::move
to Run() those closures instead.

Bug: 812717
Change-Id: Ie8956bfcb23e3411025352d4714a9c928c0869fe
Reviewed-on: https://chromium-review.googlesource.com/920742
Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537349}

In pre-DICE, the sync confirmation dialog was always shown after the
accounts were added to the Gaia cookies. This took several seconds
allowing the sync engine to initialize and check whether sync was
allowed for the given account.

When DICE enabled, the sync confirmation dialog should only be shown
after sync has been initialized or failed to be initialized. This allows
us to make sure that the policy to enable or disable sync for the given
account is checked before displaying the sync confirmation dialog.

BUG = 812546

Change-Id: Ic414cd8eb5a810a1ff0827526361b10f8e76210b
Reviewed-on: https://chromium-review.googlesource.com/921741Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Nicolas Zea <zea@chromium.org>
Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537348}