- 10 Apr, 2018 40 commits
-
-
Kunihiko Sakamoto authored
In preparation to add support for the new cert format, this patch introduces SignedExchangeCertificateChain class that contains all information of a certificate chain. Certificate parsing code in SignedExchangeCertFetcher is moved to this new class. Pure refactoring, no behavior change. Bug: 815024,815025 Change-Id: Iacb592279c9fef7afb40cb303ef81eebb4be34a3 Reviewed-on: https://chromium-review.googlesource.com/1002339Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#549400}
-
Peter Kasting authored
This leaves InfoBarBackground drawing only the solid-color fill; a subsequent patch will remove InfoBarBackground entirely. This also changes how the separator size is computed. Previously, all infobars reported their preferred size including a separator, and InfoBarContainerView trimmed 1 DIP off the bottom infobar. However, this didn't actually prevent InfoBarBackground from drawing the separator on that infobar (I think). Now, separators are drawn at the top rather than the bottom, so it's the top infobar which may need to omit the separator. InfoBarView handles this omission directly when computing its desired height. InfoBarContainerView has to notify a newly-top infobar to get it to recompute the height after animation finishes. Additionally, since separators are 1 px, we only reserve 1 DIP when below DSF 2; otherwise we just use some of the space within the infobar, since the top and bottom are always padding anyway. I could have left separators drawn at the bottom of infobars rather than the top; at the time I thought through all this it seemed like doing things at the top made some parts easier, but in retrospect it'd probably be about the same either way. BUG=none TEST=none Change-Id: I682851f16cc4a6a764c13f3983f22c829e9b10bd Reviewed-on: https://chromium-review.googlesource.com/1000419Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#549399}
-
Gabriel Charette authored
This reverts commit 8e10a0af. Reason for revert: surfaces flakes in browser_tests, see crbug.com/829122 (only reverting base/ changes, test fixes can stay in) Original change's description: > Reduce leaks in PostTaskAndReplyImpl::PostTaskAndReply (reland). > > This CL first landed as https://chromium-review.googlesource.com/902191. > It was reverted because of a leak in PipeReaderTest.Cancel, which is > fixed by this CL by flushing the ScopedTaskEnvironment before the test > ends. > > Before, there was always a leak when the RunTaskAndPostReply callback > posted by PostTaskAndReplyImpl::PostTaskAndReply didn't run. > > With this CL, the "task" is never leaked and the "reply" is only > leaked if the execution environment is shutdown before the deletion > happens (e.g. MessageLoop deleted, TaskScheduler shutdown). > > TBR=gab@chromium.org,sky@chromium.org,kbr@chromium.org > > Bug: 807013 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > Change-Id: Ic28839da7aed25fc56a4abadc565b7f4a6e0b5c5 > Reviewed-on: https://chromium-review.googlesource.com/997892 > Reviewed-by: François Doray <fdoray@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Commit-Queue: François Doray <fdoray@chromium.org> > Cr-Commit-Position: refs/heads/master@{#548919} TBR=stevenjb@chromium.org,sky@chromium.org,gab@chromium.org,fdoray@chromium.org,kbr@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 807013, 829122 Change-Id: Iff4ca23f3cf011b0587478f479a1676e618b741b Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1003792 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#549398}
-
Eric Stevenson authored
Temporary fix while support is added to supersize. Bug: 830843 Change-Id: I677782d52c9927ed08d2a07c5272c18a0901e3d6 Reviewed-on: https://chromium-review.googlesource.com/1003999Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#549397}
-
David Benjamin authored
Not sure what happened there. I appear to just be really bad at hitting keys. Bug: none Change-Id: I634023d6007a4209c6b8ae6e46825e20a3c83b43 Reviewed-on: https://chromium-review.googlesource.com/1003119Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#549396}
-
Daniel Murphy authored
For the last 4 years we 'saved' the new schema version number, so any v2 databases are never marked as v3. The 'migration' always deleted all blob files. To correctly upgrade to v3, all v2 databases that have blob entries are considered corrupt and are wiped. This also fixes the enums.xml values for IDB setup errors, which have been missing 'DeleteIndex' and 'ClearObjectStore' (and subsequently have had incorrect reporting on values > 23) since 2014: https://crrev.com/b05831ee Bug: 756447, 829125, 829141 Change-Id: I1d711b5ed4bfb4e7240da56a2fc78e6ebe561ca1 Reviewed-on: https://chromium-review.googlesource.com/1000138Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#549395}
-
Yoichi Osato authored
This patch introduces the flag for the HTML Imports deprecation. Use with --disable-blink-features=HTMLImports flag on content_shell or chrome. Bug: 766694 Change-Id: I9c0836f3fc05429d34062dc0fcc2eda209cc1cf0 Reviewed-on: https://chromium-review.googlesource.com/998455Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Takayoshi Kochi <kochi@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#549394}
-
Brett Wilson authored
In order to roll GN ee966518..b709e226 (r544233:r549249) and pick up the following changes: 12bd7ed6 [gn] Updating args --list to make the comment padding optional 743a7a88 Fix grammar-o in gn's help. 28f3c498 Implement "friend" for GN header checking. f7ccdc76 GN: Use source root as base for gn gen filters 73b7854e GN: Improve bootstrap for Windows 8ca5c09b [gn] Updating args --list to emit json e65dd61a Fix gn bootstrap c89b8fab Fix gn bootstrap TBR=dpranke@chromium.org Change-Id: I8dd84acad1d55692938e4980c260145dd50c6e78 Reviewed-on: https://chromium-review.googlesource.com/1003524Reviewed-by:
Brett Wilson <brettw@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Brett Wilson <brettw@chromium.org> Cr-Commit-Position: refs/heads/master@{#549393}
-
proberge authored
This is a follow-up to https://chromium-review.googlesource.com/957645 in which the reviewer requested that we add some developer documentation suggesting to use ".js" and ".html" for background script/pages instead of weird filetypes. Bug: 809088 Change-Id: Ic1b319522b3fba37b42716d9f5c58bdaf84949f3 Reviewed-on: https://chromium-review.googlesource.com/984992Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Paul Irish <paulirish@chromium.org> Commit-Queue: Paul Irish <paulirish@chromium.org> Cr-Commit-Position: refs/heads/master@{#549392}
-
Sadrul Habib Chowdhury authored
Instead of having separate enums for the main-thread in various processes, just have a single MAIN_THREAD identifier for the main thread in all processes. The callstacks are associated with a Process enum anyway, so no information is lost from this. BUG=788808 Change-Id: I095339ce8f9c6db5f9946f93fb677a8fe298f66a Reviewed-on: https://chromium-review.googlesource.com/1000292Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#549391}
-
Adrienne Walker authored
This is not something that any of the other context providers do inside of ContextSupport(). This is to support this patch: https://chromium-review.googlesource.com/c/chromium/src/+/998682 ...which adds calls to IsResourceReadyToDraw which previously never happened in the browser (because TileManager only issued them when in smoothness mode, which is never true for the browser. Landing separately in case the other patch gets reverted. Change-Id: I939db78c76b0d613824c04f52d8098226cba59a2 Reviewed-on: https://chromium-review.googlesource.com/1003755Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#549390}
-
Khushal authored
This was originally added to understand whether an increase in pending tree duration for the CompositorImageAnimation experiment was resulting from time spent in these impl-side invalidations. Its clear that this is not the case. On Android stable, this value is ~0.45 ms at the 99th percentile. We don't need continuous monitoring of this metric, marking it obsolete. R=enne@chromium.org Bug: 826115 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I44b4346c1466d5d29fd534dfc2879ed14a740169 Reviewed-on: https://chromium-review.googlesource.com/985100Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
-
Patti authored
In touch mode, the LocationBarView is a pill-shape. The textfield inside it - OmniboxViewViews - is not. This can cause the sharp corners of OmniboxViewViews to overflow or poke out of the rounded corners of LocationBarView when there are no leading or trailing decorations to act as padding, which can happen in Guest mode (no bookmark star). Prevent this from happening by adding padding to the left and right of OmniboxViewViews when there are no decorations. Bug: 826798, 801583 Change-Id: Ibf75218b8c76809fca2811eb87bdaea243a71955 Reviewed-on: https://chromium-review.googlesource.com/994832 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#549388}
-
Patti authored
The BubbleIconView icons in touch mode should be 20x20. Currently, they look about 24x24, so downsize them here by using border insets for the icon padding instead of relying on the internal ImageView to center itself within the larger BubbleIconView. Bug: 829887, 830059, 801583 Change-Id: Ib98ef8dbb6279148375d431a1bb4224015fe02c7 Reviewed-on: https://chromium-review.googlesource.com/1002217 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by:
-
Malay Keshav authored
This patch uses the parent widget of the bookmark bar menu buttons to retrieve the correct color from the theme provider. Bug: 829891 Change-Id: I97cd270675b83770edc272c12fcd54905590a20e Component: Bookmarkbar, bookmarkbar menu Reviewed-on: https://chromium-review.googlesource.com/1002539 Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Reviewed-by:
-
Yuwei Huang authored
iOS is sending a "\n" unicode text event to the host when the user taps the `return` key. On Windows this doesn't always generate a newline. This CL fixes this issue by translating the "\n" text event into a ENTER keypress before sending it to the host. Bug: 830959 Change-Id: Ib94caf6ce2036cc5654f1b59f1e0136c81c9eec1 Reviewed-on: https://chromium-review.googlesource.com/1003598 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#549385}
-
David Bokan authored
Bug: 821237 Change-Id: I3ff0d35be3ad5c5d792cfc0851525f425d827221 Reviewed-on: https://chromium-review.googlesource.com/1003594Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
-
Elly Fong-Jones authored
A previous change added support for Mac modifier symbols; this change adds support for the base shortcut characters to use symbols. The list here is taken from Apple's list of keyboard shortcut symbols. Bug: 828117 Change-Id: I9d10e3462f757106442a03ae762fe0e954bb45eb Reviewed-on: https://chromium-review.googlesource.com/996036Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#549383}
-
Nico Weber authored
For example, angle_unittests wasn't running on the MSan bot, which wasn't intentional. If a test really doesn't work under e.g. TSan, it can be added to the exceptions file instead. For another example, https://chromium-review.googlesource.com/#/c/981787/ added cronet tests, but again not to msan. Disable a few tests that don't pass on tsan or msan. Bug: 830659,830648,830653,830819,830944,830945 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Icac81720f32c24497942b9c056c6d6999a866ec6 Reviewed-on: https://chromium-review.googlesource.com/987477Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#549382}
-
Dominic Mazzoni authored
Bug: 650275 Change-Id: I4d0120f649809f8b4d9a4b6447b7774a259ae584 Reviewed-on: https://chromium-review.googlesource.com/1000966Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#549381}
-
Victor Costan authored
https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/a325ad2db5de..7e5f90d3780d This is a less ambitious version of https://crrev.com/c/987696 which was reverted in https://crrev.com/c/1000414 because it broke the Linux CFI build bot https://crbug.com/830017 $ git log a325ad2db..7e5f90d37 --date=short --no-merges --format='%ad %ae %s' 2018-04-05 misterg formatting 2018-04-05 misterg And more MCVS warnings 2018-04-05 misterg fixing MCVS warn 2018-04-05 misterg Have to wait for this one 2018-04-05 misterg Have to wait for this one 2018-04-05 misterg Merging matchers test 2018-04-05 misterg Merging matchers test 2018-04-04 misterg bad cut/paste 2018-04-04 misterg More on MSVC warning C4503, decorated name length exceeded 2018-04-04 misterg More on MSVC warning C4503, decorated name length exceeded 2018-04-04 misterg Address MSVC warning C4503, decorated name length exceeded, name was truncated 2018-04-04 misterg Fixing build break on MSVC 2018-04-04 misterg merging gmock matchers 1 2018-04-04 fo40225 fix build break on locale windows 2018-04-04 misterg Tweaking https://github.com/google/googletest/pull/1523 to exclude nacl 2018-04-03 misterg Upstreaming, cl 191344765 2018-04-03 misterg merging port, cont. 191443078 2018-04-03 misterg merging, cont - 2 2018-04-03 misterg merging gtest-port.h , 191439094 2018-04-03 misterg merging, just comments format 2018-04-03 misterg testing, merge 2018-04-03 misterg Testing, gtest-port.h merge 2018-04-02 misterg merging gtest-port.h, again - 1 2018-03-29 gennadiycivil Include OSX builds back into PR builds 2018-03-29 gennadiycivil Revert "merging gtest-port 1 of N" 2018-03-29 gennadiycivil Revert "merging gtest-port, 2" 2018-03-29 leissa typo 2018-03-29 misterg merging gtest-port, 2 2018-03-28 leissa provide alternative for DebugBreak() 2018-03-27 misterg merging gtest-port 1 of N 2018-03-26 misterg merges 1 2018-03-26 misterg merges, gtest 2018-03-26 misterg merging gmock-matchers.h 3 2018-03-26 misterg merging gmock-matchers.h 2 2018-03-26 misterg Upstreaming FloatingEq2Matcher, 2018-03-23 misterg Merging gmock-matchers.h -2 2018-03-23 misterg gmock-matchers merging -2 2018-03-22 misterg merging, gmock -1 2018-03-22 misterg reverting gtest_list_tests_unittest.py 2018-03-22 gennadiycivil Update appveyor.yml 2018-03-22 misterg more merges 2018-03-22 misterg more merges 2018-03-21 misterg More merges 2018-03-16 misterg cl 189032107, again 2018-03-16 misterg cl 189032107 2018-03-15 misterg merge, again, IsRecursiveContainer Created with: roll-dep src/third_party/googletest/src Bug: 829773 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.win:win_chrome_official;master.tryserver.chromium.linux:linux_chromium_cfi_rel_ng Change-Id: Id5eec3d583a3b1fac953fba5bd702e9714099cf3 Reviewed-on: https://chromium-review.googlesource.com/1002612 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
-
Alex Newcomer authored
- Add MD shadows by... - Adding a member variable to BubbleBorder: std::Optional<int> md_shadow_elevation. - Modify static function GetBorderAndShadowFlags to support custom shadow elevation. - Adding a static function to cache ShadowValues. - I created a static function (GetShadowValues) here because other static functions assume that the default shadows are used. - Make GetBorderAndShadowInsets use gfx::ShadowValues::GetMargins when an elevation is set. Bug: 826912 Change-Id: I93837da730fd5344aa026f67f1bff5ce3c766a98 Reviewed-on: https://chromium-review.googlesource.com/993275 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#549379}
-
Thoren Paulson authored
Old one was sized for 720p screens so looked bad on bigger ones. New one is sized for 1080p, the max we use for UI on Cast devices. Bug: None Test: Manual test on build with volume UI at multiple scales. Change-Id: I4e07efb14401ea6981b0041c2eef46e0c1d05360 Reviewed-on: https://chromium-review.googlesource.com/1000842Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Thoren Paulson <thoren@chromium.org> Cr-Commit-Position: refs/heads/master@{#549378}
-
Yuwei Huang authored
Currently our keyboard type is default, which allows complex input methods like Chinese IME to be selected, but we haven't implemented support for it yet so they will never work. This CL simply limits the keyboard type to ASCII capable. Bug: 830959 Change-Id: I24b05975d2e242059d4fa94c7e42444ecf7e5bc4 Reviewed-on: https://chromium-review.googlesource.com/1003774Reviewed-by:
-
https://pdfium.googlesource.com/pdfium.git/+log/d45f9980995a..e372ad7333bd $ git log d45f99809..e372ad733 --date=short --no-merges --format='%ad %ae %s' 2018-04-09 tsepez Use ByteStringView / pdfium::span in CPDF font as appropriate. 2018-04-09 thestig Pass FX_RECT by const-ref in rendering code. 2018-04-09 thestig Remove RenderDeviceDriverIface::GetCTM(). 2018-04-09 thestig Cleanup CPDF_RenderStatus::GetObjectClippedRect(). 2018-04-09 dsinclair Merge CXFA_DocumentParser::{Start|Do}Parse methods 2018-04-09 dsinclair Merge CXFA_FFDoc::{Start|Do|Stop}Load methods 2018-04-09 tsepez Use pdfium::span<> in CFX_BitStream, CPDF_SimpleParser. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Id298c13a673048b25aaa03119527ea3e37a6c16e Reviewed-on: https://chromium-review.googlesource.com/1003291Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#549376}
-
James Hawkins authored
R=khorimoto@chromium.org Bug: none Test: none Change-Id: I2504fc6ad07fee7072ed135248bf793fc470a980 Reviewed-on: https://chromium-review.googlesource.com/1003521Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#549375}
-
Tommy Steimel authored
This CL adds more changes from the VR spec, mostly sizing, padding, and margin changes. What this CL does NOT cover: 1) Changes to the loading panel to match the different size/positioning of the overlay play button and timeline 2) Hover states on the buttons 3) Newly sized scrim Bug: 809021 Change-Id: Ibeb226e1801fbb695836038d779b30d359d24682 Reviewed-on: https://chromium-review.googlesource.com/1000403 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#549374}
-
Kyle Horimoto authored
Now that [1] has landed, RemoteDevice objects sent over a Mojo API undergo a translation from cryptauth::RemoteDevice to device_sync::mojom::RemoteDevice, then back to cryptauth::RemoteDevice on the other side of the pipe. This translation does not include the RemoteDevice's Bluetooth address, so if a RemoteDevice has an address defined before it is sent over the pipe, it will be lost in translation. Thus, the address should not be compared in RemoteDevice::operator==. This is part of an ongoing effort to remote the address field altogether, since it was only used in EasyUnlock v1 (now deprecated). [1] https://chromium-review.googlesource.com/c/chromium/src/+/996642 Bug: 829039, 824568, 752273 Change-Id: I122df1d3e93227136309d18964db1f8c88c4a449 Reviewed-on: https://chromium-review.googlesource.com/1003516Reviewed-by:
James Hawkins <jhawkins@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#549373}
-
Becca Hughes authored
The spec icons were 24px but they had an internal margin of 2px. The standard MD vector icons that we use are 24px but have an unaccounted margin of 5px. Increasing the size by 6px will compensate for 3px of that extra margin and now match the spec. BUG=827559 Change-Id: I3d57f5a8b06ae20cf8b34d57fbb63ca4067eb0f7 Reviewed-on: https://chromium-review.googlesource.com/1000528 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
-
https://chromium.googlesource.com/catapult.git/+log/1e3e74d24d37..b5c70ce2580e $ git log 1e3e74d24..b5c70ce25 --date=short --no-merges --format='%ad %ae %s' 2018-04-09 szager Add DeviceUtils.GetPackageArchitecture Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I815ef9a33909921132b78aaf02ddb29c3404f790 Reviewed-on: https://chromium-review.googlesource.com/1003388 Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#549371}
-
Dan Harrington authored
Bug: 794828 Change-Id: I6264f900967b9fc995b250c2968b299a31bb81db Reviewed-on: https://chromium-review.googlesource.com/988937 Commit-Queue: Dan H <harringtond@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#549370}
-
Theresa authored
* Replace check for whether search promo has shown with check for whether search promo still needs to be shown. * Disable when Google is not the default search engine. * Disable in accessibility mode. BUG=824188 Change-Id: I533dfb59fd5b5d5503a97493f08425dc6240a771 Reviewed-on: https://chromium-review.googlesource.com/998494Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#549369}
-
https://skia.googlesource.com/skia.git/+log/e697500577c5..1eeeae0491ba $ git log e69750057..1eeeae049 --date=short --no-merges --format='%ad %ae %s' 2018-04-09 mtklein use commonPaint for all raster pipeline 2018-04-06 benjaminwagner Upgrade Debian9 bots to 9.4. 2018-04-09 bsalomon Reland "Remove deprectated GrContext::MakeGL overloads that take raw ptr" 2018-04-09 skcms-skia-autoroll Roll third_party/externals/skcms/ 8a727815d..16a9cebff (1 commit) 2018-04-06 csmartdalton ccpr: Remove WindMethod from GrCCCoverageProcessor 2018-04-09 angle-skia-autoroll Roll third_party/externals/angle2/ 6c7ab7fe8..6c59e4a15 (3 commits) 2018-04-06 bsalomon Add canvas2D fast paths to new read/write pixels code paths. 2018-04-09 egdaniel Make sure GrBackendTextures are valid before starting to do things with them 2018-04-06 brianosman Remove code that was only used by the old debugger 2018-04-08 csmartdalton Implement Sk2f::Store2 Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=borenet@chromium.org Change-Id: I7fdd964004d2062a65336c5d59d967deef6eabad Reviewed-on: https://chromium-review.googlesource.com/1002867Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#549368}
-
Kent Tamura authored
Such CamelCase files were renamed to snake_case. This CL is a follow-up of crrev.com/cdb0a66c. Bug: 768828 Change-Id: I05293564390e3fcfb41fbbf9077c4a192596c3d5 Reviewed-on: https://chromium-review.googlesource.com/1001080Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#549367}
-
Matthew Wang authored
Support FTEnabled property in ONC. BUG=791202 TEST=chromeos_unittests TEST=chrome.networkingPrivate.createNetwork with "FTEnabled":true enables the device to connect to an FT network. Setting "FTEnabled":false disables the device from connecting to an FT network. Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I2470753fd139505704987e301b18983dc51c5c47 Reviewed-on: https://chromium-review.googlesource.com/982275Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Matthew Wang <matthewmwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#549366}
-
Kent Tamura authored
The Great Blink mv broke sorted include_rules. This CL fixes them manually. This CL has no behavior changes. Bug: 768828 Change-Id: I74c65e929acc9023e6601838a6c3488f3351d3d5 Reviewed-on: https://chromium-review.googlesource.com/1001158Reviewed-by:
-
David Reveman authored
Use a top priority pre-target handler in Seat class to track pressed keys. This is needed to ensure that we see all key events. Also cleanup some of the code in Keyboard class where we send modifiers. It doesn't make sense to send modifiers in cases where the key event is a reserved accelerator and won't be delivered to the client. Bug: 820641 Test: exo_unittests --gtest_filter=KeyboardTest.OnKeyboardEnter Change-Id: Ib1169a7c0ad70e8e7973c94edf4b9885fecc7819 Reviewed-on: https://chromium-review.googlesource.com/1001634Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#549364}
-
Makoto Shimazu authored
This reverts commit 2ca250d4. Reason for revert: A leak bot complains navigation-consumes-user-activation.tentative.sub.html is leaking. Sample build: https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty%20Leak/builds/17509 Original change's description: > Enable ConsumeGestureOnNavigation by default > > See blink-dev thread: > https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/kPli8ZCUeok > > A browser test is moved to be a tentative WPT due to this change. > > Bug: 772515 > Change-Id: Icf99c8c303c5055dcbcdace6ae94e3fcd1a01921 > Reviewed-on: https://chromium-review.googlesource.com/980599 > Reviewed-by: Nasko Oskov <nasko@chromium.org> > Reviewed-by: Mustaq Ahmed <mustaq@chromium.org> > Reviewed-by: Jonathon Kereliuk <kereliuk@chromium.org> > Commit-Queue: Charlie Harrison <csharrison@chromium.org> > Cr-Commit-Position: refs/heads/master@{#549293} TBR=nasko@chromium.org,mustaq@chromium.org,csharrison@chromium.org,kereliuk@chromium.org Change-Id: I0c998798d1367be61c633db76429c18ac554e4ff No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 772515 Reviewed-on: https://chromium-review.googlesource.com/1003437Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#549363}
-
Dmitry Gozman authored
Automation tools do not expect auto reloads happening without tools being in control. Bug: chromedriver:2350 Change-Id: I384fbdb2419e124cdd675cd4062b996fb8fcfb52 Reviewed-on: https://chromium-review.googlesource.com/1003042 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
-
Istiaque Ahmed authored
AsynExtensionFunction is deprecated and soon will be removed. This CL makes remaining wallpaper.* and wallpaperPrivate.* functions extend from UIThreadExtensionFunction. Bug: 829174, 829653 Change-Id: I132bcea28e3406feb4f09743eea466214cc27a8d Reviewed-on: https://chromium-review.googlesource.com/997096 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#549361}
-
