- 09 Aug, 2018 40 commits
-
-
vitaliii authored
virtual/webrtc-wpt-unified-plan/external/wpt/webrtc/RTCDTMFSender-ontonechange.https.html TBR=hta@chromium.org NOTRY=true Bug: 832842,872632 Change-Id: If9522e93d1851b762c67005aa8fdcd83a71631fd Reviewed-on: https://chromium-review.googlesource.com/1169016Reviewed-by:
vitaliii <vitaliii@chromium.org> Commit-Queue: vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#581839}
-
Alexander Alekseev authored
It turns out that video/webm mime type is not always available (depending on the python version?) So this Cl adds it statically. Bug: 852038 Change-Id: Ic8cb19a777131df96df6c5794598ea8c8d0d312a Reviewed-on: https://chromium-review.googlesource.com/1168655Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#581838}
-
vitaliii authored
media/controls/video-enter-exit-fullscreen-without-hovering-doesnt-show-controls.html TBR=mlamouri@chromium.org NOTRY=true Bug: 746128,872632 Change-Id: Ib6d822f0a6ddfed1604ca1358f141b3b38ca8d35 Reviewed-on: https://chromium-review.googlesource.com/1169013Reviewed-by:
vitaliii <vitaliii@chromium.org> Commit-Queue: vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#581837}
-
Momoko Sumida authored
Currently, empty CSSStyleSheets can be constructed either with a constructor or with Document.createEmptyCSSStyleSheet. This CL deletes the constructor so that they can only be produced by Document.createEmptyCSSStyleSheet. Document.createEmptyCSSStyleSheet is considered to be more desirable, as CSSStyleSheets produced by Document.createEmptyCSSStyleSheet can be tied to documents in the future. This means that their use can be limited in the documents where they were produced, resulting in higher security. Note: The constructed CSSStyleSheet is not currently tied to the Document yet Link to related comments in discussion: https://github.com/WICG/construct-stylesheets/issues/23#issuecomment-379180786 https://github.com/WICG/construct-stylesheets/issues/15#issuecomment-391216056 Bug: 807560 Change-Id: I767e15e83e1f31eb278bc81233c8b579d0f511c7 Reviewed-on: https://chromium-review.googlesource.com/1164876Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Momoko Sumida <momon@google.com> Cr-Commit-Position: refs/heads/master@{#581836}
-
Greg Kraynov authored
Now it registers thread as a sequence and accepts MessagePump as a constructor argument. Bug: 828835 Change-Id: Ibbfd674a5c7f739e30baaa8a026e30827d521a87 Reviewed-on: https://chromium-review.googlesource.com/1167482Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Commit-Queue: Greg Kraynov <kraynov@chromium.org> Cr-Commit-Position: refs/heads/master@{#581835}
-
Naoki Fukino authored
"Play files/Download" is an alias to Chrome OS's Downloads volume. It is convenient in Android file picker, but can be confusing in Chrome OS Files app. This CL hides the 'Play files/Download" only in Chrome OS Files app. Bug: 848661 Test: Manually tested on arc-enabled Kevin. Change-Id: I6c9bed8ff7f72b7c1fe6b2abe1c6194f8eeb3b6d Reviewed-on: https://chromium-review.googlesource.com/1166922 Commit-Queue: Naoki Fukino <fukino@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#581834}
-
Kyoko Muto authored
BUG=859429 Change-Id: Iaa998db509f9c9b4a38c2af1fa3c6be576e2d27f Reviewed-on: https://chromium-review.googlesource.com/1160068 Commit-Queue: Kyoko Muto <kymuto@google.com> Reviewed-by:
Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#581833}
-
vitaliii authored
TBR=sahel@chromium.org NOTRY=true Bug: 872635,872632 Change-Id: I59bb656ad0047c7391d96a6b59e1358af91a7b17 Reviewed-on: https://chromium-review.googlesource.com/1169002Reviewed-by:
vitaliii <vitaliii@chromium.org> Commit-Queue: vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#581832}
-
tzik authored
NULL blocks scoped_refptr to support nullptr, and eventually blocks it to remove its implicit raw-pointer conversion. This CL replaces all relevant NULL in //storage with nullptr. Change-Id: Ia3662d7bd022fa7ae3619de3f28cea968c0f858b Reviewed-on: https://chromium-review.googlesource.com/1168710Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#581831}
-
Kenichi Ishibashi authored
crrev.com/c/1160133 introduced MimeSniffingThrottle which may defer a request. Since URLLoaderClientImplTest has a (probably wrong) assumption that the request wouldn't be deferred, these tests were failing when S13nServiceWorker/Network is on. To work around the assumption this CL sets |fetch_request_context_type| to REQUEST_CONTEXT_TYPE_FETCH so that ResourceDispatcher won't install MimeSniffingThrottle. Bug: 860361 Change-Id: I6dab15515089a46f1b1c2a7501c826b9433e46b3 Reviewed-on: https://chromium-review.googlesource.com/1168705Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#581830}
-
Jérôme Lebel authored
Gives a better name to <GoogleServicesSettingsCommandHandler> and renames it to GoogleServicesSettings. The delegate is to handle changes for all services from the VC This is related to crrev.com/c/1163521 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ic952a98d659c92a355f0cb8eb4bc56e0c75af33e Reviewed-on: https://chromium-review.googlesource.com/1166964 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#581829}
-
Kenichi Ishibashi authored
blink::ServiceWorkerUtils::IsServicificationEnabled() checks whether NetworkService is enabled, so we don't need the check in ResourceDispatcher::StartAsync(). Bug: N/A Change-Id: I06bab175489f42dc0cefa2a257806db29192eba1 Reviewed-on: https://chromium-review.googlesource.com/1168707Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#581828}
-
Alexey Baskakov authored
Extract all the low-level skia/gfx/color_util stuff as ResizeIconsAndGenerateMissing function. This is a cut-and-paste CL, no behavior changes. Notes: - WebApplicationInfo::IconInfo becomes IconInfo. TODO for next CL: Merge IconInfo and BitmapAndSource - they are essentially the same. - BookmarkAppHelperExtensionServiceTest.LinkedAppIconsAreNotChanged test was always broken (a bug in ValidateAllIconsWithURLsArePresent helper) https://codereview.chromium.org/1066623008/patch/80001/90005 Bug: 860581 Change-Id: I0d866ac323f8dfdb409b69b22fac796155b1da23 Reviewed-on: https://chromium-review.googlesource.com/1166751 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#581827}
-
Tetsui Ohkubo authored
In UnifiedSystemTray, we only optimize expand/collapse transform when there is no notification. We should update the layer transform state when a notification is created during dragging system tray. TEST=manual BUG=863577 Change-Id: Iaff5438a9e8f50b621a48cff5c9f197f48d7617e Reviewed-on: https://chromium-review.googlesource.com/1168709Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#581826}
-
Yoichi Osato authored
We stopped traversal flat tree when Node didn't have a LayoutObject but Slot elements appear in the tree w/o LayoutObject. This patch enables LayoutSelection to visit children of such elements. Bug: 870734 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Id4f7c135fceead131f37485ecb8fa326834d72c3 Reviewed-on: https://chromium-review.googlesource.com/1164724Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#581825}
-
Sheng-Hao Tsao authored
This is a reland of 5e61a5b7 Original change's description: > Handle legacy camera app in consolidated icon > > This CL does 2 things: > 1. Hide legacy camera app icon > 2. Launch legacy camera app (com.android.camera2) when > com.google.android.GoogleCameraArc is not available. > > Sometimes when devices are upgraded from version with Camera2 installed, > GCA still has com.android.camera2 as the package name. That's why this > CL is needed. > > Bug: b:112121210 > Test: Tested on nautilus that after this CL, the legacy camera app icon > > Change-Id: I16e4d29d4cb538bd2ad6607456bcf4667be1f188 > Reviewed-on: https://chromium-review.googlesource.com/1127899 > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Commit-Queue: Sheng-hao Tsao <shenghao@google.com> > Cr-Commit-Position: refs/heads/master@{#581047} TBR=stevenjb@chromium.org Bug: b:112121210 Change-Id: I9acc0b7c59f4bd7d2c725e38e806d7e18748c0a4 Reviewed-on: https://chromium-review.googlesource.com/1167222Reviewed-by:
Ricky Liang <jcliang@chromium.org> Commit-Queue: Sheng-hao Tsao <shenghao@google.com> Cr-Commit-Position: refs/heads/master@{#581824}
-
Kent Tamura authored
This fixes a regression by crrev.com/578281. Bug: 871132 Change-Id: If2773697618fb2d1a33bb7f9b7b48847e6d11c8d Reviewed-on: https://chromium-review.googlesource.com/1166612 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#581823}
-
Makoto Shimazu authored
Changes in the preferences should be reflected immediately. This CL adds tests on dedicated workers, shared workers, and service workers. Bug: 853085 Change-Id: I8ea97eb45a02ecc81912c93a72127d4931148aa8 Reviewed-on: https://chromium-review.googlesource.com/1167062Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#581822}
-
Tove Petersson authored
Bug: 832054 Change-Id: I9f6c6131f4406348fe0cfbf40a876ae3724c3c6d Reviewed-on: https://chromium-review.googlesource.com/1166907Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Tove Petersson <tovep@chromium.org> Cr-Commit-Position: refs/heads/master@{#581821}
-
Olli Etuaho authored
NVML provides a more reliable way to query for the NVIDIA driver version. It also provides a query for NVIDIA CUDA compute capability which corresponds to the GPU generation. This is a good value to use for filtering GPUs based on hardware properties. We now query NVML for driver version and CUDA compute capability in case an NVIDIA GPU is encountered on Windows. NVML is loaded dynamically from %ProgramW6432%/NVIDIA Corporation/NVSMI/nvml.dll. In recent drivers the library is only shipped as a 64-bit binary, so it won't load in case the 32-bit build of Chromium is used. As a fallback, the actual NVIDIA driver version is parsed from the driver version in the Windows registry. This best-effort parsing should work for most versions, though every single version may not conform to the expected format. NVML has been present in NVIDIA drivers since version 270 published in 2011. Some functionality in NVML is exclusive to professional Quadro or Tesla GPUs, but basic functionality like the queries used here are available across NVIDIA GPU brands. BUG=693090 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I31b44021e00426fcfb2b850fea5d63c114c4569c Reviewed-on: https://chromium-review.googlesource.com/1108199Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Olli Etuaho <oetuaho@nvidia.com> Cr-Commit-Position: refs/heads/master@{#581820}
-
sangwoo.ko authored
Replace old API with new API. This CL is a refactor and has no intended behavior change. Bug: 842194 Change-Id: Ie1a6a3972d7df9bcaee4dbc68592997c5d65bd87 Reviewed-on: https://chromium-review.googlesource.com/1160837 Commit-Queue: Sang Woo Ko <sangwoo108@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#581819}
-
Kenichi Ishibashi authored
When S13nServiceWorker is on and NetworkService is off, we should use content::URLLoaderFactoryImpl as the default network factory of SharedWorkerScriptLoader because AppCacheRequestHandler wouldn't work when NetworkService is off. It needs to use non-network service path when a request is fallback to network to make sure that an appcache is associated, if any. SharedWorkerScriptLoader may ask the network factory to create loaders more than once with the same |request_id| when there are redirects. However, ResourceDispatcherHostImpl, which is used by URLLoaderFactoryImpl, doesn't allow using the same |request_id| multiple times. To work around this restriction we call ResourceDispatcherHostImpl::CancellRequest() when a redirect happens while loading a shared worker script. This CL fixes following test when S13nServiceWorker is enabled: - external/wpt/html/browsers/offline/appcache/workers/appcache-worker.https.html Bug: 869302 Change-Id: I5fae74439f82b3314f87a06bf9842db9df75a351 Reviewed-on: https://chromium-review.googlesource.com/1164741 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#581818}
-
Friedrich Horschig authored
When tapping an input field, the keyboard will always come up. Because this cannot be suppressed easily, the accessory sheet will close to not clutter the screen. Bug: 871244 Change-Id: I823225a05601ae4a1eb92a08767729fdfd94dac7 Reviewed-on: https://chromium-review.googlesource.com/1167512Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#581817}
-
Erik Luo authored
Fixes 2 recent regressions - Object popover properties had extra scrollbars; now they have standard line-height and show overflow - Dark theme forced SoftContextMenus, which appear behind the inspected page in DeviceMode; now they are not enforced by theme Screenshots: https://imgur.com/a/JOXwaGI https://imgur.com/a/NmXVtyx Bug: none Change-Id: Ia79e2a23ea987f4ed9e2cd29ba02537bdd4db076 Reviewed-on: https://chromium-review.googlesource.com/1167887Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#581816}
-
Nicholas Verne authored
Previously, we would lose any CrostiniManager state set in UserSessionManager because it quits and restarts the browser, killing the old CrostiniManager with it. Also fixed a bug where newly installing Termina didn't set the CrostiniManager state variable correctly. Bug: 871651 Change-Id: I2cfa3288069fccd86280e4301cd4757eb656e02d Reviewed-on: https://chromium-review.googlesource.com/1166271Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#581815}
-
Eriko Kurimoto authored
Bug: 816369 Test: None Change-Id: Ide3fe8d28b0e2bc9ada51f78595e0c9271ab260b Reviewed-on: https://chromium-review.googlesource.com/1160838Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Yuki Awano <yawano@chromium.org> Commit-Queue: Eriko Kurimoto <elkurin@google.com> Cr-Commit-Position: refs/heads/master@{#581814}
-
Anders Hartvoll Ruud authored
The code for first-letter was recently reworked, but this was overlooked. Fixes DCHECK failures for LayoutNG. R=futhark@chromium.org, yosin@chromium.org Bug: 872207 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I03e7aa3216c3e6c9e8576ff2d76cdb20730a9aae Reviewed-on: https://chromium-review.googlesource.com/1166921Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Anders Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#581813}
-
Tetsui Ohkubo authored
This reverts commit 76c395e0. Reason for revert: Initial position of sliders are broken Original change's description: > Fix UnifiedVolumeView asan failure during closing. > > This CL fixes UnifiedVolumeView asan failure when > 1. the slider is in unified system tray main bubble > 2. volume key is pressed during bubble fade out animation > > This is because controllers are deleted before views are deleted. This > is intented because usually controllers are called only when a user > makes mouse event in the bubble. Slider is an exception because > it also notifies controller that value is changed by API although > it's ignored on controller side. Other possible fixes are: > > * Make controller ptr in the view WeakPtr. > * UnifiedSliderView implement Slider listener and not forward changes > caused by API. > > The CL is the least verbose fix. > > TEST=manual > BUG=871005 > > Change-Id: Ifb40b4107e1a04936bf6cd6e0649139498e15746 > Reviewed-on: https://chromium-review.googlesource.com/1164962 > Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org> > Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> > Cr-Commit-Position: refs/heads/master@{#581759} TBR=yoshiki@chromium.org,tetsui@chromium.org Change-Id: Ib02ac9cc17a77bc7c7fafe437f3d289e2033ce2b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 871005 Reviewed-on: https://chromium-review.googlesource.com/1168862Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#581812}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/4b17aea63fed..f765805983d1 git log 4b17aea63fed..f765805983d1 --date=short --no-merges --format='%ad %ae %s' 2018-08-08 tsepez@chromium.org Remove unused codepage from WideString::GetWideString(). Created with: gclient setdep -r src/third_party/pdfium@f765805983d1 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I1f28c231fc8e23dc9c3a92bc622b6be2c56ccf5f Reviewed-on: https://chromium-review.googlesource.com/1168542Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#581811}
-
Achuith Bhandarkar authored
BUG=chromium:871600 TEST=bots TBR=nednguyen@google.com Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi Change-Id: I5746a02cea032ce44f77dae6b47958f31d8c16f0 Reviewed-on: https://chromium-review.googlesource.com/1168477Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#581810}
-
Siddhartha authored
This CL adds a flag to control if the renderer with media streams should have strong or moderate binding. BUG=868611 Change-Id: I3263ffcca6076f9d38452c3e60df8fdd90634ea8 Reviewed-on: https://chromium-review.googlesource.com/1162927Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Siddhartha S <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#581809}
-
Tetsui Ohkubo authored
As UX spec is now ready, this CL updates the style of slider bubbles e.g. volume slider and brightness slider. TEST=manual BUG=870473 Change-Id: I8c3ca92e6fd2f8d834c494144578bf06d78276b2 Reviewed-on: https://chromium-review.googlesource.com/1166779 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#581808}
-
Lei Zhang authored
- Make OnCompositeToPdfCallback() a static method. - Do not use std::move(map) when methods take the map by const-ref. - Use C++11 map initialization syntax. Change-Id: Ia6e9e1c5dd1074e8dd37a7d8c096a51aedf84161 Reviewed-on: https://chromium-review.googlesource.com/1167786Reviewed-by:
Wei Li <weili@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#581807}
-
Orin Jaworski authored
The opacities based on colors and contrast ratios need to be recalculated when window active state or colors change, and doing this for all tabs is not efficient, so the stored opacities are moved to TabStrip for use by all its tabs. The motivation for this CL was to fix a bug where some tabs had different hover opacities than others because they were not updating with change in window active state. Bug: 872310 Change-Id: Ia7367227df005470364da10b43df429f9e4e8e47 Reviewed-on: https://chromium-review.googlesource.com/1168140 Commit-Queue: Orin Jaworski <orinj@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#581806}
-
Derek Cheng authored
The same change was made to the MR extension to hide audio-only devices for desktop mirroring proper support is implemented. (bug 849335) Bug: 849335 Change-Id: I969000c50ba6c07068298e2149f393e8737461f7 Reviewed-on: https://chromium-review.googlesource.com/1167657 Commit-Queue: Derek Cheng <imcheng@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#581805}
-
Eric Willigers authored
The Budget API began shipping in M60. It can be used to retrieve the amount of budget an origin has available for resource consuming background operations, as well as the cost associated with doing such an operation. https://codereview.chromium.org/2891953002 https://www.chromestatus.com/feature/5691190548627456 BUG=704725 Change-Id: Ieae4c7a1f1883e974ea9c9902d71acf528200d5f Reviewed-on: https://chromium-review.googlesource.com/1166267Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#581804}
-
Noel Gordon authored
This reverts commit d8fb3e8f. Reason for revert: No evidence of flake on flakiness dashboard for these tests in DEBUG, yet find.it said there was. Who's right? Well, reverting this CL to find.it out (the cause was a bad v8 roll by the looks). Original change's description: > Disabled tests in chromeos dbg due to flakiness. > > Only one of the subtests reported flaky, but didn't know how to disable > them separately. > > TBR=noel@chromium.org > > Bug: 871684 > Change-Id: Ie4f27cc5681ba3c6174853dbbfd16d1ba665c451 > Reviewed-on: https://chromium-review.googlesource.com/1164958 > Reviewed-by: Rune Lillesveen <futhark@chromium.org> > Commit-Queue: Rune Lillesveen <futhark@chromium.org> > Cr-Commit-Position: refs/heads/master@{#581194} TBR=futhark@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 871684 No-try: true No-presubmit: true Change-Id: Ibf9f9ee10ac3e1d37fb13c6b69ddac56071747a9 Reviewed-on: https://chromium-review.googlesource.com/1168842 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#581803}
-
Jia authored
Previously it was checking active user profile to be in line with other power-related prefs. Now that other power-related prefs are changing to primary user profile, this cl changes to check primary user profile too. Bug: 862461 Change-Id: Iad053ba29c3295828bf8ab83ad522c41f24d1f42 Reviewed-on: https://chromium-review.googlesource.com/1168265Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#581802}
-
Mohamed Amir Yosef authored
Bug: 516866 Change-Id: Ib91eb840c937e0aa6a7056a1d68555a02bbdac4c Reviewed-on: https://chromium-review.googlesource.com/1167509 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#581801}
-
Yuwei Huang authored
This is part of the work of refactoring the iOS audio playback logic. This CL implements the AudioPlaybackSink for iOS using the AudioQueue API. The implementation is following Apple's guide for the playback process: https://developer.apple.com/library/archive/documentation/MusicAudio/Conceptual/AudioQueueProgrammingGuide/AboutAudioQueues/AboutAudioQueues.html#//apple_ref/doc/uid/TP40005343-CH5-SW22 In the next CL there will be an AudioPlaybackStream class that connects the AudioJitterBuffer with AudioPlaybackSinkIos. Bug: 868088 Change-Id: Ifbaa08bfcf5f983587bfb71418c681001ab7cdca Reviewed-on: https://chromium-review.googlesource.com/1166246 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#581800}
-