GitLab

Change-Id: I9f35828ea104b0c0901a65845796a96bc28cbbe3
Reviewed-on: https://chromium-review.googlesource.com/1017766
Commit-Queue: Erik Chen <erikchen@chromium.org>
Reviewed-by: Albert J. Wong <ajwong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551833}

This new class computes information about a table in an AXTree,
including its dimensions, headers, and a mapping from row/column
index to a cell's node ID. It's computed from an AXTree on-demand
and cached until the tree changes.

Subsequent changes will switch browser-side code to use this
interface instead of the equivalent information provided by Blink,
and then remove some of the table-handling code from Blink.

See bug 832289 for more details on the planned refactoring.

Bug: 832289, 651614, 789748, 753125,
Change-Id: I29b31833426b69cb73266829e8f577785aa6fce6
Reviewed-on: https://chromium-review.googlesource.com/1011229
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551832}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/30a2b933e3a0..3e6ddaf232b2

$ git log 30a2b933e..3e6ddaf23 --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src-internal
BUG=chromium:722573


The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I1a65aef301abc143862ff57282e50409dfc80b8e
Reviewed-on: https://chromium-review.googlesource.com/1017586
Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#551831}

Don't send packets containing only Brain messages.

Adds a BundleWrites() method to QuartcSession.  When called, this method
installs a ScopedPacketFlusher on the connection.  The flusher attaches to the
connection and delays writing packets that are not full until it is deleted.
QuartcSession stores the packet flusher on the heap and keeps it alive until a
subsequent call to FlushWrites() or OnTransportReceived(), either of which
dispatch pending writes immediately.

Quartc bundles writes of Brain messages.  These tend to be very small and not
very latency sensitive.  Sending a whole packet with only a Brain message wastes
bandwidth and throws off congestion control.  It's better to wait and send the
Brain message with a subsequent frame (if possible).

Currently, any other Quartc frame will trigger a flush, sending pending Brain
messages along with it.
Merge internal change: 192995820

https://chromium-review.googlesource.com/c/1016663/
Bug: 77323330
https://codereview.chromium.org/1016663

--------------------------------------------------

Support multiple QuartcSessionVisitors on a single QuartcSession.

In order to implement go/quartc-packet-notifications, one visitor will always be
in use (collecting stats from QUIC and reporting them to the Quartc Brain).  In
order to support tracegraf and other debug utilities, QuartcSession needs to
delegate connection debug events to multiple visitors.

QuartcSessionVisitor no longer exposes a QuicConnectionDebugVisitor.  Instead,
it implements a number of methods that match QuicConnectionDebugVisitor's
callbacks.  It could simply extend QuartcConnectionDebugVisitor, but exposing a
separate interface is how the rest of //gfe/quic/quartc works.

For now, this is limited to functionality needed by tracegraf and
go/quartc-packet-notifications.

There's still a leaky abstraction in the form of OnQuicConnection(), which is
necessary due to a circular dependency between QuicConnection and
QuicTracegrafVisitor.

The QuartcSessionTracegrafVisitor now implements this interface.

Merge internal change: 192844927

https://chromium-review.googlesource.com/c/1016662/
Bug: none
https://codereview.chromium.org/1016662

--------------------------------------------------

In QUIC, explicitly feed application limited signal to pacing sender
instead of trying to figure out itself. Protected by
FLAGS_quic_reloadable_flag_quic_simplify_pacing_sender.
Merge internal change: 192819301

https://chromium-review.googlesource.com/c/1015559/
Bug: 77723739
https://codereview.chromium.org/1015559

--------------------------------------------------

In QUIC, set sending packets's long header type in session and
dispatcher. Not used yet. Not protected.
Merge internal change: 192614208

https://chromium-review.googlesource.com/c/1015556/
Bug: 35377641
https://codereview.chromium.org/1015556

--------------------------------------------------

Remove references to jri@
Merge internal change: 192493283

https://chromium-review.googlesource.com/c/1015702/
Bugs: 77906482, 77907041
https://codereview.chromium.org/1015702

--------------------------------------------------

Do not use QUIC's MSPC tag and instead require MIDS. protected by
FLAGS_quic_reloadable_flag_quic_no_mspcxc

The QUIC handshake tag MSPC (max streams per connection) was replaced
by MIDS (max incoming dynamic streams) in QUIC v35 and should have
been removed when we removed v34, but we forgot to do this.
Merge internal change: 192474785

https://chromium-review.googlesource.com/c/1015552/
Bug: None
https://codereview.chromium.org/1015552

--------------------------------------------------

Remove the unused CTIM, SWIN, and SRBF QUIC handshake parameters.
Merge internal change: 192275571

https://chromium-review.googlesource.com/c/1015508/
Bug: none
https://codereview.chromium.org/1015508

--------------------------------------------------

Add flag count for
FLAGS_quic_reloadable_flag_quic_register_static_streams.
Merge internal change: 192233397

https://chromium-review.googlesource.com/c/1015548/
Bug: none
https://codereview.chromium.org/1015548

--------------------------------------------------

Pad probing retransmissions in QUIC.  Not flag-protected, since the
probing is not enabled in GFE.
Merge internal change: 192197258

https://chromium-review.googlesource.com/c/1015504/
Bug: none
https://codereview.chromium.org/1015504

--------------------------------------------------

Use the send alarm instead of the resume_writes alarm in
QuicConnection.  Protected by
FLAGS_quic_reloadable_flag_quic_unified_send_alarm.
Merge internal change: 192169762

https://chromium-review.googlesource.com/c/1015545/
Bug: none
https://codereview.chromium.org/1015545

--------------------------------------------------

Fix linking error for templated method
gfe_quic::CryptoUtils::SetKeyAndIV

Merge internal change: 192161750

https://chromium-review.googlesource.com/c/1015543/
Bug: 77753328
https://codereview.chromium.org/1015543

--------------------------------------------------

Let framer be able to build IETF stateless reset packet and version
negotiation packet. Not used yet.

Merge internal change: 192123603

https://chromium-review.googlesource.com/c/1015262/
Bug: 35377641
https://codereview.chromium.org/1015262

--------------------------------------------------

Change quic_client_bin to return code 20 when failed to connect to
server due to QUIC_INVALID_VERSION and FLAGS_version_mismatch_ok is
false.

Merge internal change: 192120462

https://chromium-review.googlesource.com/c/1012953/

R=rch@chromium.org

Bug: 77515653
Change-Id: I885b8911668be34372c1b4233f64e8b15e8221e1
https: //codereview.chromium.org/1012953/
Reviewed-on: https://chromium-review.googlesource.com/1016668Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Frank Kastenholz <fkastenholz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551830}

Bug: 796315
Change-Id: I976eca626746f01f70ec374ab47c66f82efd25a0
Reviewed-on: https://chromium-review.googlesource.com/1015962Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Qiang Xu <warx@google.com>
Reviewed-by: Dan Erat <derat@chromium.org>
Commit-Queue: Min Chen <minch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551829}

This reverts commit 1aa4ba15.

Reason for revert: Broke compile https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/5269

Original change's description:
> cros: Add Settings shortcuts search to launcher
> 
> This cl adds the framework to search Settings shortcuts in launcher.
> Changes:
> 1. Add feature flag to enable Settings shortcut search in launcher.
> 2. New class SettingsShortProvider.
> 3. New class SettingsShortResult.
> 4. New struct SettingsShortcutMetadata.
> 
> Bug: 834049
> Test: SettingsShortcutProviderTest.Basic and SettingsShortcutResultTest.Basic
> Change-Id: Ib25f2d18487b77c138b7d550ad06b6f2ac73f6c2
> Reviewed-on: https://chromium-review.googlesource.com/1016128
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Commit-Queue: Tao Wu <wutao@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#551783}

TBR=xiyuan@chromium.org,wutao@chromium.org

Change-Id: I1051c175b6dcd3652e2fd3eb43979837f3e25bea
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 834049
Reviewed-on: https://chromium-review.googlesource.com/1017667Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551828}

Move BatchModeScoper into Scoper.

Bug: 781703
Change-Id: If10a87bbbfd04aadc54a24390ce747f0318b1519
Reviewed-on: https://chromium-review.googlesource.com/1011172
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551827}

Using wpt-import in Chromium 3cf4a083.
With Chromium commits locally applied on WPT:
303956b6 "Enable WPT tests for the Generic Sensor classes"
afb472c0 "Try to fix crash when terminating a worker while it is XHR-ing to a blob."


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/15774

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

TBR=robertma

No-Export: true
Change-Id: I103a135f5e2c9c5c7c20875e2b5cb7f1e960f219
Reviewed-on: https://chromium-review.googlesource.com/1017561
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551826}

When I adjusted the separator height and thickness for material menus, I forgot
to also adjust these constants. Set them to 9 - 1pt of line and 8pt of padding,
since the full separators have 8pt on either side. The "spacing" separator is
also 9 despite having no line, for visual consistency with the ones that do
have lines.

Bug: 831201
Change-Id: I14ed22823d7af9f6194281ef914ca64395feca31
Reviewed-on: https://chromium-review.googlesource.com/1017063Reviewed-by: Leonard Grey <lgrey@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551825}

TBR=sky@chromium.org
NOTRY=true

Bug: none
Change-Id: I1854df6f8447a86cc7773438cc40f6e92de45881
Reviewed-on: https://chromium-review.googlesource.com/1017565Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551824}

BUG=762641
TBR=jdufault@google.com

Change-Id: I907c35be791949270846a2dfbeb388812299b8f7
Reviewed-on: https://chromium-review.googlesource.com/1017564Reviewed-by: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org>
Commit-Queue: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551823}

This argument enables excluding certain files and folders from code
coverage report using regular expression.

Bug: 813123
Change-Id: I13343645ba1e3e67dfc17932bc97113600a69095
Reviewed-on: https://chromium-review.googlesource.com/1017382Reviewed-by: Max Moroz <mmoroz@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551822}

Recently layout tests have been fairly flaky; this is causing extra load
on the CQ. Every time layout tests fails, they are retried without patch
to determine if the failure is a flake or a failure at tip of tree. This
means that layout tests are running more than other test suites, and
since layout tests take a long time to run, we end up consuming more
capacity from our swarming pool than we should.

Isolated script tests don't have the ability to retry only the tests
that failed, which is what other test suites do. This CL changes that so
that layout tests, when re-run without the patch, retry on the tests that
fail, which should significantly reduce swarming load and cycle time for
running layout tests without patch.

Bug: 533481
Change-Id: I1f23f6e57bcfbc44f80f11a0a96ca74d84ae8423
Reviewed-on: https://chromium-review.googlesource.com/1015843
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551821}

Originally, if you:
1) enable unified-consent
2) goes to sync subpage and signs in with avatar row on top
3) click "go to settings" in the sync confirmation dialog
4) clicks "cancel sync" in the toast notification

You'll get taken back to the basic page with a sync error.

This is because the code was erroneously not identifying the
subpage as the current login-UI. This CL fixes that by
replicating https://chromium-review.googlesource.com/c/chromium/src/+/1015234/1/chrome/browser/ui/webui/settings/people_handler.cc#666

Bug: 800972
Change-Id: Ie0f5e447523f73f605bec47f48936b63c3c6ee5a
Reviewed-on: https://chromium-review.googlesource.com/1015234
Commit-Queue: Scott Chen <scottchen@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551820}

https://chromium-review.googlesource.com/c/chromium/src/+/1014352

TBR=kbr@chromium.org
Bug: 833463

Change-Id: I1780be2e8bcf3b32600d8a96594fef67c2c579f3
Reviewed-on: https://chromium-review.googlesource.com/1013153Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Commit-Queue: Kai Ninomiya <kainino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551819}

Bug: 678687
Change-Id: If1bc9f87184627130879775865b5e8696faf82c2
Reviewed-on: https://chromium-review.googlesource.com/1008278Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551818}

This CL just moves some Cross-Origin Read-Blocking (CORB) code into
//service/network.  No intended behavior change.

Bug: 792546
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I8d6ccc6a2bd6c673edf6b127868b2d0868bed4c4
Reviewed-on: https://chromium-review.googlesource.com/1012746Reviewed-by: Nick Carter <nick@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551817}

BUG=760416

Change-Id: Id94e43e1540f78de7f57b126a242c5197dbfc8a2
Reviewed-on: https://chromium-review.googlesource.com/650535Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Tyler Breisacher <tbreisacher@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551816}

These functions makes it possible for other code to iterate
over all of the features known to the system. CQ code will
ensure that chromecast code calls chromecast::IsFeatureEnabled
rather than base::FeatureList::IsEnabled which will enforce
that new Features are properly registered

Minor header fixes included for free.

Bug: 73173111
Test: None
Change-Id: Ic2dd2aa789a88fea62f724b683ce1e7c81fa3035
Reviewed-on: https://chromium-review.googlesource.com/1014523
Commit-Queue: Eli Ribble <eliribble@google.com>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Reviewed-by: Stephen Lanham <slan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551815}

Upgrades the VrCore and Daydream Home APKs used for testing. The
keyboard APK upgrade will come at a later time to help differentiate
any perf regressions caused by the upgrade.

Change-Id: I349beff4b5e97ea3edd1bdd3ef1fe5be3821d388
Reviewed-on: https://chromium-review.googlesource.com/1014505Reviewed-by: Brandon Jones <bajones@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551814}

Update ExtensionWebstorePrivateApiTest to manifest v2 and remove the
allowance for manifest v1 extensions.

Repackage two crx's used in the webstorePrivate API tests to be
updated to manifest v2.

Bug: 816679

Change-Id: I8ba99179c99b62c6ef49cf3aa8e7afab7dfacdf5
Reviewed-on: https://chromium-review.googlesource.com/1015081Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551813}

Bug: 761009
Change-Id: I07844c77a73b0be1605b9970af1249ea7f189fe3
Reviewed-on: https://chromium-review.googlesource.com/949050Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Luna Lu <loonybear@chromium.org>
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551812}

This change implements Windows::Foundation::IAsyncOperation. It provides
a simple interface and allows clients to specify desired results via a
callback.

This is mostly useful for tests, when custom fake implementations of
UWP interfaces are required. Some of these implementations must provide
Async methods, that return an instantiation of IAsyncOperation.

Bug: 821766
Change-Id: I728c0bb5311898fac4ee5f5e54d8a64b2aa61d94
Reviewed-on: https://chromium-review.googlesource.com/984194Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551811}

https://pdfium.googlesource.com/pdfium.git/+log/51a41ea222ee..7439517516a0

$ git log 51a41ea22..743951751 --date=short --no-merges --format='%ad %ae %s'
2018-04-18 tsepez Add AsRawSpan() to ByteString.

Created with:
  roll-dep src/third_party/pdfium


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I89cfce7acf9bd124f51c05e7816133bf8541ecfe
Reviewed-on: https://chromium-review.googlesource.com/1017585
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#551810}

Link to coverage.py to code_coverage.md

Bug: 833912
Change-Id: I089bbef64424004f543823d663dad00b3a275fbe
Reviewed-on: https://chromium-review.googlesource.com/1017239Reviewed-by: Max Moroz <mmoroz@chromium.org>
Commit-Queue: Max Moroz <mmoroz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551809}

The test is flaky, likely due to recent refactors to the heap profiling code to
support Android Webview. I'm disabling it temporarily while I investigate.

Bug: 833590
Change-Id: Idd7dd982d9e5586f76f991455d1ae717323c519d
TBR: thakis@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1017598Reviewed-by: Erik Chen <erikchen@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551808}

When Desktop Identity Consistency is enabled, this CL records the user actions
Signin_SigninNewAccount_From*, Signin_SigninWithDefault_From* and
Signin_SigninNotDefault_From* for the following access points:
* bookmark bubble
* extension installed bubble
* user menu (a.k.a. avatar bubble)
* password saved bubble
* settings

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I09656690891ce66def3cf30faa3fa99b612cc266
Reviewed-on: https://chromium-review.googlesource.com/1013919Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551807}

When GPU access is blocked (i.e., hardware acceleration and SwiftShader
are both disabled), chrome://gpu reports incorrect values for Surface
Synchronization and Viz Service Display Compositor features.

BUG=829426
TEST=manual

Change-Id: I977a3902d71d53d77be2473ecd4b755b895f6a79
Reviewed-on: https://chromium-review.googlesource.com/1017227Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Mohsen Izadi <mohsen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551806}

At present, the code in RenderWidgetHostViewAndroid will send events to
the InputEventRouter even if using_browser_compositor_ is false. This
CL fixes that.

Change-Id: I1ff9a1e70b9fc2ef44a357b520df269ce29e69af
Reviewed-on: https://chromium-review.googlesource.com/1017228
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551805}

Update IdentityTestWithSignin to manifest v2 and remove the allowance
for manifest v1 extensions.

Bug: 816679

Change-Id: I0312986394cf10c58f31884284f7830df947feea
Reviewed-on: https://chromium-review.googlesource.com/1014600Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551804}

Currently we create FullscreenControlHost when the view hierarchy is
changed, which adds ~27ms to the app startup time. This CL delays the
creation of FullscreenControlHost until the browser enters fullscreen.

Bug: 833594
Change-Id: I291aa8e84eb154bbda52434d17e430d54c0507c6
Reviewed-on: https://chromium-review.googlesource.com/1014658Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Yuwei Huang <yuweih@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551803}

When a permanent auth error state is triggered, re-masks all the
server cards.

Don't suggest server cards while in a permanent auth error state.

Bug: 825319
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I99906a59922845a099431ebbed06eac5adf0b5f1
Reviewed-on: https://chromium-review.googlesource.com/979137
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551802}

Remove #ifdef USE_X11 && !USE_GLIB check. That would have been for the
X11 CrOS build which no longer exists.

Bug: none
Change-Id: Iccea3d36ef92ed1dde44773ce4a74184a7a2c37b
Reviewed-on: https://chromium-review.googlesource.com/1014281Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551801}

GetPhotoState was disabled on Windows because of issue 722038. The issue
only impacts the Video Capture DirectShow implementation.

This prevents video stream from being stopped when
InitializeVideoAndCameraControls fails on DirectShow and let
GetPhotoState calls reach the MediaFoundation implementation.

Bug: 833449, 722038
Change-Id: Ifad3fa1ee86938ee62a306bbf5900bf645a5eb9f
Reviewed-on: https://chromium-review.googlesource.com/1013697
Commit-Queue: Christian Fremerey <chfremer@chromium.org>
Reviewed-by: Christian Fremerey <chfremer@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551800}

The FlingingRenderer adapts from the media::Renderer interface to the
MediaController interface. It is used in the context of RemotePlayback,
and is created from an already existing presentation ID

Bug: 790766
Change-Id: I2284468f3342ad4123e5318c3f2c930a171fea06
Reviewed-on: https://chromium-review.googlesource.com/1003229Reviewed-by: Nick Carter <nick@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551799}

This CL modifies CryptAuthEnrollerImpl and CryptAuthDeviceManagerImpl
to take a CryptAuthClientFactory* instead of a
std::unique_ptr<CryptAuthClientFactory> in their constructors. It was
unnecessary to have each class own its own instance of the factory, and
this refactor will help as I add an instance of the factory to the
DeviceSync service.

Bug: 824568, 752273
Change-Id: Ie3818cb7d81439689e4edb60f6c024f0e5069435
Reviewed-on: https://chromium-review.googlesource.com/1017307
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551798}

This CL makes --enable-oop-rasterization --enable-raster-decoder work on
desktop linux builds of chromium.

Changes:

- Update raster_cmd_buffer_functions.txt with changes in
  gles2_cmd_buffer_functions.txt and regenerate autogen files.

- Copy code from RasterImplementationGLES into RasterImplementation.

- Copy code from GLES2DecoderImpl into RasterDecoderImpl

Bug: 789238
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ia7b50acc843ecd641a8a74927d94303138849e86
Reviewed-on: https://chromium-review.googlesource.com/1011203Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: Jonathan Backer <backer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551797}

Using only AF_INET to probe a Wifi interface that IPv6-only will fail,
even though the interface is functional.  This change adds an AF_INET6
check if AF_INET fails.

Bug: None
Change-Id: I81f9c2a2a51041597ee384804018b4de7dccc88d
Reviewed-on: https://chromium-review.googlesource.com/1017344
Commit-Queue: Brandon Tolsch <btolsch@chromium.org>
Reviewed-by: Adam Parker <amp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551796}

Context.getDir() creates Chrome's data directory, app_chrome/, with
rwxrwx--x. ChromeMainDelegateAndroid::RunProcess() then limits this to
rwx------. RunProcess() goes out of its way to avoid granting any user
permissions that weren't already present, but this seems like a mistake;
it shouldn't be possible for app_chrome/ to have fewer permissions than
rwx------. So RunProcess is simplified to set the permissions to exactly
rwx------. Also don't print data_path in the error message because if
PathService::Get() failed, data_path is empty.

Also restrict WebView's directory, app_webview/, using Os.chown(). Doing
this in PathUtils covers both Chrome and WebView. However, Os.chown()
requires API >= 21, which is the case for WebView but not Chrome, so
Chrome's RunProcess() code must stay for now.

Rehabilitate //chrome/test:chrome_app_unittests to run on Android (crbug
609855 says it was broken but it seems to work now) and add a unit test
for the simplified native code.

BUG=832388,609855
internal bug b/19993402

Change-Id: I1bcfe72940ddc1fb23f2b0bef50775853843ea76
Reviewed-on: https://chromium-review.googlesource.com/984773
Commit-Queue: Paul Miller <paulmiller@chromium.org>
Reviewed-by: Tao Bai <michaelbai@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551795}

This avoids creating a new entry in the map for each process on each
cycle on Windows, which was happening as of my last change.
Add a state variable to keep track of when a measurement cycle is
underway in preparation for allowing measurement requests at arbitrary
times. Replace the delegate class with a simple virtual function, and
use protected access control in combination with a Testing* subclass
to expose class' internal state for testing. This allows removing all
test-specific code from the class declaration.

Bug: 755840
Change-Id: I7658a355525fffe92327bb85151ba124cc81d371
Reviewed-on: https://chromium-review.googlesource.com/1015299
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#551794}