- 05 Jun, 2018 40 commits
-
-
Scott Violet authored
There are a couple of issues addressed here: . kFocusable_InitProperty was not wired up correctly. . Ash created top-levels were not picking up the value set by clients To fix these I'm adding kCanFocus. ws2 sets this from calls by clients to WindowTree::SetCanFocus(). Ash uses this property as well if the client supplies kFocusable_InitProperty. I think kFocusable_InitProperty should go away. That'll be easier once we get rid of --mash. I'm also forking the TopLevelWindowFactory tests. I moved the existing ones into TopLevelWindowFactoryMash (these only run with --mash). I also made the tests work in classic mode with ws2. I added a new file for this that is built in ash_unittests. BUG=842301 TEST=covered by tests Change-Id: I016ed612e7ab1d7bc1cdc4840c3aa9271078ab9e Reviewed-on: https://chromium-review.googlesource.com/1086151 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#564646}
-
Ryan Sturm authored
This test suite now handles requests instead of looking at connections and tracks the count of requests based on a specific URL pattern. The first test will pass when no image requests have been loaded, so if for some reason 20 round trips to the renderer do not gaurantee the request is seen on the net/ stack, the test will still pass. The second test creates an image request while the page is paused, and upon unpausing the page, waits for the image request to be seen in the embedded test server. The third test loads the image in the same pattern as the second without ever pausing the page. Bug: 848675 Change-Id: I5a72cf1765b583bdb83ade2046366c12d6d70613 Reviewed-on: https://chromium-review.googlesource.com/1086125 Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#564645}
-
Sean Topping authored
By default, this should just propagate visibility information to the delegate. In the future, NotifyVisibilityChange should only be called by the window manager. Documentation for CastContentWindow was improved as a minor clean up. Bug: internal b/79874784 Test: CQ Change-Id: I3eab9b60b74037cd1f122e03460d0b8fe6db00c0 Reviewed-on: https://chromium-review.googlesource.com/1086042 Commit-Queue: Sean Topping <seantopping@chromium.org> Reviewed-by:
Stephen Lanham <slan@chromium.org> Cr-Commit-Position: refs/heads/master@{#564644}
-
Lakshmi Kumar Dabbiru authored
Enable Upstream GPay branding Config file change at https://critique.corp.google.com/#review/198897909 Change-Id: I44bb9d7ef8e7bdc590dddd5b902bb0b970ada5da Reviewed-on: https://chromium-review.googlesource.com/1087542Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Lakshmi Kumar Dabbiru <dlkumar@google.com> Cr-Commit-Position: refs/heads/master@{#564643}
-
Sadrul Habib Chowdhury authored
The four terminal components are set in various places, but they are are never actually consumed or processed for anything. These components are removed, and replaced instead with a LatencyInfo::Terminate() method to mark the termination. Removed components: INPUT_EVENT_LATENCY_TERMINATED_COMMIT_FAILED_COMPONENT INPUT_EVENT_LATENCY_TERMINATED_COMMIT_NO_UPDATE_COMPONENT INPUT_EVENT_LATENCY_TERMINATED_NO_SWAP_COMPONENT INPUT_EVENT_LATENCY_TERMINATED_SWAP_FAILED_COMPONENT This also renames INPUT_EVENT_LATENCY_TERMINATED_FRAME_SWAP_COMPONENT to just INPUT_EVENT_LATENCY_FRAME_SWAP_COMPONENT. BUG=849686 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: If2fb7941c299393e77d8909e3681c6292e5c0e74 Reviewed-on: https://chromium-review.googlesource.com/1087292 Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#564642}
-
rbpotter authored
- Set pixels and points to different values, to improve existing test. - Test setting the margins via both dragging and textbox. - Test that setting the settings (e.g. from sticky settings) updates the controls. Bug: 773928 Change-Id: I17daf6705b6dd66cbec68577c979fa5182176288 Reviewed-on: https://chromium-review.googlesource.com/1083888Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#564641}
-
Justin Novosad authored
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I773e98e6906c6c1f5a9add6274e3891510d8b9a5 Reviewed-on: https://chromium-review.googlesource.com/1087353 Commit-Queue: Justin Novosad <junov@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#564640}
-
Xianzhu Wang authored
Now use "const LayoutTableSection* repeating_table_section" instead of "bool is_repeating_table_section" so that we can know which table section is actually repeating and avoid an inner thead not in repeating context (while can repeat) is treated as the repeating section. We still don't support nested repeating table sections (that is, repeating table section under another repeating table section, not the cases in fragmentation/nested*.html which are about repeating table sections in nested tables under non-repeating table section of another table). Filed crbug.com/849459 for it. Bug: 849029 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ib0b921a95dc0257cbe11577edef8d1d77071db16 Reviewed-on: https://chromium-review.googlesource.com/1086285 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#564639}
-
Jian Li authored
This is to avoid potential data race issues in tests. Bug: 836442,837104 Change-Id: Ic46e2834e1a50fa3644e6fe5ec0d4ef874e0b0a0 Reviewed-on: https://chromium-review.googlesource.com/1086156Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/master@{#564638}
-
Mark Pearson authored
Change-Id: I7e6e474a0962b56fe044691b5de2869ab334b766 Reviewed-on: https://chromium-review.googlesource.com/1065070 Commit-Queue: Mark Pearson <mpearson@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#564637}
-
Morten Stenshorne authored
The legacy layout engine has a bug that's not present in LayoutNG, making it impossible for LayoutNG to pass fast/text-autosizing/clusters-insufficient-text.html . The bug: If a new formatting context in-flow block-level object gets pushed down by a float, strange things happen in legacy layout if this object is a writing mode root. Rather than using the initial containing block as guidance for its inline size, it behaves as if inline-size were set to min-content. So just specify height (inline-size) as min-content in the test, to get identical behavior in the legacy engine and LayoutNG. Bug: 848874 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I5928318f17ad3105350bd38d3b81cbe5c35819d0 Reviewed-on: https://chromium-review.googlesource.com/1086996Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#564636}
-
Ryan Landay authored
The new Android horizontal tab switcher currently focuses on the previous tab when it's opened. We implemented this behavior because we thought the most common action in the tab switcher is to switch to an earlier tab. However, user metrics suggest that it's actually more common to switch to a later tab, the most common action is actually to close the current tab. Additionally, we received qualitative user feedback that this behavior feels annoying. This CL removes this behavior so the horizontal tab switcher will now focus on the current tab. Bug: 831359,849480 Change-Id: Id77c422f51005b39a135a6682c75b3a7ab3dce24 Reviewed-on: https://chromium-review.googlesource.com/1085632 Commit-Queue: Ryan Landay <rlanday@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#564635}
-
Francois Doray authored
With this CL, TabLifecycleUnit::CanFreeze() returns false if the tab is already frozen. This is important because calling Freeze() on a TabLifeycleUnit that is already FROZEN causes a transition to PENDING_FREEZE, and because the page is already frozen from the renderer point of view, there is no transition back to FROZEN. Bug: 775644 Change-Id: I216310e83605374f6708ef182dd2b9bf4f531494 Reviewed-on: https://chromium-review.googlesource.com/1085995 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#564634}
-
Mohamed Amir Yosef authored
Instead of using a custom BookmarkModelTypeController, use the generic ModelTypeController. This work has been unblocked by fixing the bug crbug.com/819993 Bug: 516866 Change-Id: I57eab3fba8a40cd7158de7fedb4326ef32f44db7 Reviewed-on: https://chromium-review.googlesource.com/1087450 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#564633}
-
src-internal-chromium-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d47dffd..d566165 Created with: gclient setdep -r src-internal@d566165 The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:784511 TBR=mmoss@chromium.org Change-Id: If656010c171244e05236e5f9f0082f4dbcc22533 Reviewed-on: https://chromium-review.googlesource.com/1087609Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#564632}
-
Manuel Rego Casasnovas authored
Text from the spec (https://drafts.csswg.org/css-contain/#containment-layout): "... if the element is an internal table element other than display: table-cell, or if the element is an internal ruby element, or if the element’s principal box is a non-atomic inline-level box, layout containment has no effect." The patch disables "contain: layout" for internal table elements but table cells, internal ruby elements and non-atomic inline-level boxes. Some of the new tests pass or fail incidentally due to crbug.com/785212, once that's fixed all the tests should be working as expected. BUG=843329 TEST=external/wpt/css/css-contain/contain-layout-008.html TEST=external/wpt/css/css-contain/contain-layout-009.html TEST=external/wpt/css/css-contain/contain-layout-010.html TEST=external/wpt/css/css-contain/contain-layout-011.html TEST=external/wpt/css/css-contain/contain-layout-012.html TEST=external/wpt/css/css-contain/contain-layout-013.html TEST=external/wpt/css/css-contain/contain-layout-014.html Change-Id: I5f0893a9ce69dc8e76cf16acb1b8556bf0e02adf Reviewed-on: https://chromium-review.googlesource.com/1087268Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#564631}
-
Raymond Toy authored
This is a reland of 325b492f Initialize tail_time_ in constructor so we don't have uninitialized variable. Original change's description: > WaveShaper must output non-zero values even if input is silent > > If the curve for the WaveShaperNode is such that a zero input produces > a non-zero output, the WaveShaperNode needs to output that value even > if the input is silent (or disconnected). > > Do this by setting the tail time of the processor to 0 or infinity > depending on whether the curve specifies an output value of zero or > not, respectively. > > Bug: 807301 > Test: WaveShaper/silent-inputs.html > Change-Id: I6539d2e00f5d3e624ffaf2810944eb6d53d6f84b > Reviewed-on: https://chromium-review.googlesource.com/896266 > Commit-Queue: Raymond Toy <rtoy@chromium.org> > Reviewed-by: Hongchan Choi <hongchan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#564186} Bug: 807301 Change-Id: I866c5b303b40c1245d86daf43c592eed39d6a9c9 Reviewed-on: https://chromium-review.googlesource.com/1087427Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#564630}
-
Aleks Totic authored
We were not updating margins correctly inside NGBlockNode::RunOldLayout. Symptom was that BODY(flex) block size was too big when HTML had margins inside quirks mode. Another side effect of this fix is two crashes have gone away. Added explicit test case for BODY(flex) in quirks mode. Bug: 849490 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Id0ce0910144c81fc254646110424f36c898f9ebd Reviewed-on: https://chromium-review.googlesource.com/1086381 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#564629}
-
Jonathan Backer authored
Fixes an issue that the fuzzer found. Bug: 849664 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I1180b9d0eced6709b1a3245c2f96deca123a71b3 Reviewed-on: https://chromium-review.googlesource.com/1087530 Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#564628}
-
Michael Warres authored
Modify framer to build frames with IETF frame type values in version 99. Merge internal change: 198057262 https://chromium-review.googlesource.com/c/chromium/src/+/1086588 Expose PCC's DebugState in TransportState trace Merge internal change: 198054448 https://chromium-review.googlesource.com/c/chromium/src/+/1086587 Make toy client to log socket recv buffer overflow whenever more packets are lost. Merge internal change: 198050613 https://chromium-review.googlesource.com/c/chromium/src/+/1086452 Remove QuicStreamSequencerBuffer::Gap Merge internal change: 198028095 https://chromium-review.googlesource.com/c/chromium/src/+/1086451 Remove PCC special case in send_algorithm_test.cc. Merge internal change: 197613391 https://chromium-review.googlesource.com/c/chromium/src/+/1086136 Add IETF Ack Framer/deframer to QUIC Version 99 Merge internal change: 197586715 https://chromium-review.googlesource.com/c/chromium/src/+/1086133 More Transport Parameters in QUIC; protected by --quic_supports_tls_handshake Merge internal change: 197484241 https://chromium-review.googlesource.com/c/chromium/src/+/1086130 Deprecate FLAGS_quic_reloadable_flag_quic_fast_path_on_stream_data. Merge internal change: 197422127 https://chromium-review.googlesource.com/c/chromium/src/+/1085861 Deprecate FLAGS_quic_reloadable_flag_quic_fast_is_disjoint. Merge internal change: 197422019 https://chromium-review.googlesource.com/c/chromium/src/+/1085858 Add QUIC v44 which will use IETF header format. Protected by normal flag --quic_enable_version_44. Merge internal change: 197199677 https://chromium-review.googlesource.com/c/chromium/src/+/1085856 Add EpollCallbackInterface::Name() method, to aid debugging. Merge internal change: 196864754 https://chromium-review.googlesource.com/c/chromium/src/+/1083718 Add source_connection_id and source_connection_id_length to QuicPacketHeader, and default them to 0 and 0-byte, respectively. Also add them to all related functions. Merge internal change: 196734148 https://chromium-review.googlesource.com/c/chromium/src/+/1083631 Send and receive Transport Parameters extension in TLS for QUIC Merge internal change: 196720679 https://chromium-review.googlesource.com/c/chromium/src/+/1083431 Deprecate FLAGS_quic_reloadable_flag_quic_enable_version_42_2. Merge internal change: 196716890 https://chromium-review.googlesource.com/c/chromium/src/+/1082822 Deprecate FLAGS_quic_reloadable_flag_quic_register_static_streams. Merge internal change: 196711027 https://chromium-review.googlesource.com/c/chromium/src/+/1083231 In GFE, make QUIC be able to offload pacing to USPS when possible. Protected by quic_restart_flag_quic_offload_pacing_to_usps. Merge internal change: 196706015 https://chromium-review.googlesource.com/c/chromium/src/+/1083092 Send an ACK in 1ms if no packets have been received in an SRTT. Enabled when the connection option ACKQ is supplied and protected by FLAGS_quic_reloadable_flag_quic_fast_ack_after_quiescence. Merge internal change: 196698436 https://chromium-review.googlesource.com/c/chromium/src/+/1082716 PSK integration for Quartc. Merge internal change: 196680315 https://chromium-review.googlesource.com/c/chromium/src/+/1082815 Use IETF QUIC STREAM frame format for Version 99. Merge internal change: 196653181 https://chromium-review.googlesource.com/c/chromium/src/+/1082814 Deprecate FLAGS_quic_reloadable_flag_quic_is_write_blocked. Merge internal change: 196600942 https://chromium-review.googlesource.com/c/chromium/src/+/1077448 Modify PacketDroppingTestWriter not to drop more than 3 packets in a row. Merge internal change: 196569604 https://chromium-review.googlesource.com/c/chromium/src/+/1076449 Deflake EndToEndTestWithTls.ServerSendPublicReset. Merge internal change: 196562935 https://chromium-review.googlesource.com/c/chromium/src/+/1077227 Rename connection_id and connection_id_length in QuicPacketHeader to destination connection_id and destination_connection_id_length, respectively. Merge internal change: 196548721 https://chromium-review.googlesource.com/c/chromium/src/+/1077055 R=zhongyi@chromium.org Change-Id: I09c984a5089bdda8a4c101863f5ac7e30dd33b04 Reviewed-on: https://chromium-review.googlesource.com/1086597Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Michael Warres <mpw@chromium.org> Cr-Commit-Position: refs/heads/master@{#564627}
-
Siddhartha authored
Bug: 845717 Change-Id: I744a2376340082abf10db5d208397b3a0a2657d8 Reviewed-on: https://chromium-review.googlesource.com/1086293Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Siddhartha S <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#564626}
-
Jonathan Backer authored
We don't support it on all code paths and it's not used by CC for raster. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Iad7cf9d3bdb7131065a11bc2f6314165a45cab25 Reviewed-on: https://chromium-review.googlesource.com/1087041 Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by:
-
Michael Spang authored
This reverts commit 32d01db2. Reason for revert: shifts UI 1 px to the right Original change's description: > [chromecast] Update Display Rotation Transform > > The primary display rotation transforms for 90, 180, and 270 degree > rotations have been updated so that located events are properly > transformed to the new correct location after being subjected to the > inverse root transform. The inverse root transform is used to take the > (x, y) reported for a given located event and transform it to a new (x', > y') to align properly with the transformation applied to the display > graphics. > > Take the case of a display with the following characteristics: > Height = 720 > Width = 1280 > > Under the current case, the inverse root transforms are as follows: > 90deg = [0, 1, 0, 0; -1, 0, 0, 720; 0, 0, 1, 0; 0, 0, 0, 1] > 180deg = [-1, 0, 0, 720; 0, -1, 0, 1280; 0, 0, 1, 0; 0, 0, 0, 1] > 270deg = [0, -1, 0, 1280; 1, 0, 0, 0; 0, 0, 1, 0; 0, 0, 0, 1] > > With the applied change, the inverse root transforms become: > 90deg = [0, 1, 0, 0; -1, 0, 0, 719; 0, 0, 1, 0; 0, 0, 0, 1] > 180deg = [-1, 0, 0, 719; 0, -1, 0, 1279; 0, 0, 1, 0; 0, 0, 0, 1] > 270deg = [0, -1, 0, 1279; 1, 0, 0, 0; 0, 0, 1, 0; 0, 0, 0, 1] > > To see that these new transformations are correct, take the 270 degree > rotation case and consider the corner points of the display. The corner > point transformations under the old and updated transforms are: > > Old > (0,0)-->(1280,0) > (719,0)-->(1280,719) > (0,1279)-->(1,0) > (719,1279)-->(1,719) > > New > (0,0)-->(1279,0) > (719,0)-->(1279,719) > (0,1279)-->(0,0) > (719,1279)-->(0,719) > > The old transformations take the corner points and incorrectly update > them, even outside of bounds for events at (0,0) and (719,0). The new > transformations properly map all corner points. > > The same behavior can be observed for 90 and 180 degree rotations as > well. > > > BUG=None > TEST=Check on devices with 90, 180, and 270 degree rotations > > Change-Id: I2d56cf1a4e871d3a08a886bc218fff7262157b73 > Reviewed-on: https://chromium-review.googlesource.com/982373 > Reviewed-by: Sergey Volk <servolk@chromium.org> > Reviewed-by: Michael Spang <spang@chromium.org> > Commit-Queue: Cody Peterson <crpeterson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#551372} TBR=spang@chromium.org,alexst@chromium.org,servolk@chromium.org,crpeterson@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 78781894 Change-Id: I8d11152e15e4f80384538366373087504f87256b Reviewed-on: https://chromium-review.googlesource.com/1087647Reviewed-by:
Michael Spang <spang@chromium.org> Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#564624}
-
Mark Pearson authored
Change-Id: I754afcb3aa8a737ad5e5ab5f64b60f237f03267e Reviewed-on: https://chromium-review.googlesource.com/1076827 Commit-Queue: Mark Pearson <mpearson@chromium.org> Reviewed-by:
-
Ian Vollick authored
Previously, I'd assumed that if ShouldUpdateWorldSpaceTransform was true that we would update the world space transform. It may be the case, however, that the update results in no meaningful change (the reticle may not have moved, for example). With this change, we only mark the scene as dirty if the new transforms are not approximately equal to the old transforms. Bug: 848074 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Change-Id: I9f3225b852755d8296deec58f78215838dc7b334 Reviewed-on: https://chromium-review.googlesource.com/1087170Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#564622}
-
yucliu authored
Lots of base::Value APIs are deprecated. Update the callsite in MediaDrmStorageImpl to use new APIs: 1. Replace DictionaryValue with Value. 2. Use Value directly, instead of wrapping in std::unique_ptr. 3. Update value get function with FindKeyOfType. BUG=846168 TEST=Shaka demo, clear media licenses. Change-Id: I4137060753280e605dc34e37a6f0df9da148f6b5 Reviewed-on: https://chromium-review.googlesource.com/1080224Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#564621}
-
Wez authored
Replaces the Channel::RemoteProcessLaunched API, which callers had to invoke only if they successfully launched a process with the Channel handle, with RemoteProcessLaunchAttempted, which must always be called regardless of whether process-launch was successful, so long as it was attempted with base::LaunchProcess. This is required under Fuchsia, where the remote endpoint handle is transferred, rather than cloned, and the LaunchProcess API consumes the handle even on failure, for consistency. On POSIX and Windows the effect is just to close the remote endpoint handle earlier in the case of failure to launch. Bug: 848028, 754449 Change-Id: Ia79efebdc8b629f3d579a76c941283d461980e4c Reviewed-on: https://chromium-review.googlesource.com/1086385Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#564620}
-
Eric Karl authored
Change 1042531 handled sending background/foreground events to the GPU process, allowing it to disable the watchdog thread while backgrounded. This change extends this to add a |watchdog_starts_backgrounded| field to GpuPreferences, allowing us to immediately disable the watchdog thread (even before channel connection) when creating a new GPU process in the background. Bug: 836986 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I11e9b9989f437881ba7a14b4d4644ff75d6e6987 Reviewed-on: https://chromium-review.googlesource.com/1055682Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
-
Mark Pearson authored
If this description is good, I'll make the analogous change to the user actions doc. Also added a link to histogram_macros.h at the top of the "Coding" section in the histogram docs, and a link to the user actions recording code at the top of "Coding" section in the user actions doc. Change-Id: I05b546fd1ff7e00046b9324c9d02ac5f85a7f0ab Reviewed-on: https://chromium-review.googlesource.com/1079794 Commit-Queue: Mark Pearson <mpearson@chromium.org> Reviewed-by:
-
Robbie McElrath authored
This removes the RenderThread parameter from DeviceMotionEventPump, DeviceOrientationEventPump, and GamepadSharedMemoryReader, since it's no longer used by anything. Bug: 612330 Change-Id: I70ce28a0ce519ee3b7e030abbdf1411b32cf30c9 Reviewed-on: https://chromium-review.googlesource.com/1081935 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#564617}
-
Xi Cheng authored
This metric gives more details about case SHORTCUT_MISCONFIGURATION of Notifications.Windows.SetReadyCallbackStatus. Bug: 847989, 734095 Change-Id: I5be3de19807a18b4b5eb4520cabaf464ac4668d1 Reviewed-on: https://chromium-review.googlesource.com/1086187 Commit-Queue: Xi Cheng <chengx@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#564616}
-
Mathieu Perreault authored
Bug: 849658 Test: FormCacheTest Change-Id: I5b32002958179b18491269aea874ec462266c0d9 Reviewed-on: https://chromium-review.googlesource.com/1086984 Commit-Queue: Mathieu Perreault <mathp@chromium.org> Reviewed-by:
-
Anthony Vallee-Dubois authored
Bug: 840367 Change-Id: I9168229517c07e55a3b2ebb7adc756482c405d8f Reviewed-on: https://chromium-review.googlesource.com/1079382Reviewed-by:
Michael Martis <martis@chromium.org> Reviewed-by:
-
Koji Ishii authored
This patch adds NGLineBoxStrut, a NGBoxStrut for line-relative coordinate system. It has `line_over` and `line_under` instead of `block_start` and `block_end`. Following up the baseline fix in CL:1074989, using this struct enforces compiler type safety for line-relative coordinate system. Bug: 636993 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I894f6c47d15d24ceed783684173405006f12cd83 Reviewed-on: https://chromium-review.googlesource.com/1086686 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Niels Möller authored
See webrtc cl https://webrtc-review.googlesource.com/78403 Bug: None Change-Id: I842a0cad7c929074f565d72d68664554d15eb5ac Reviewed-on: https://chromium-review.googlesource.com/1080647 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#564612}
-
Mikel Astiz authored
When a conflict is encountered (on Android), its best to amend the ones in non-placeholder tabs (if possible), because that is a lot more likely to get persisted by Android session/tab restore. Otherwise, the sync ID collision will remain there. TBR=treib@chromium.org Bug: 843554 Change-Id: I7ded45ee01abbbfb5a013743ac775e75032ce403 Reviewed-on: https://chromium-review.googlesource.com/1087453Reviewed-by:
-
Abhishek Bhardwaj authored
Chrome doesn't have CAP_WAKE_ALARM. This means it can't set alarms that wake up the system. This change makes Chrome a conduit between the instance and powerd. It relays the arguments to Chrome OS' powerd which manages the wake up alarms for the instance. BUG=b:64581307 TEST=Test end-to-end wake up alarms from the instance. Change-Id: I5647b915a1318df991d89396d9b1d10c3336cb5d Reviewed-on: https://chromium-review.googlesource.com/999006Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Abhishek Bhardwaj <abhishekbh@chromium.org> Cr-Commit-Position: refs/heads/master@{#564610}
-
Martin Kreichgauer authored
This adds a CredentialMetadata class to encrypt any account metadata associated with a WebAuthn credential (user ID, user name, user display name, and RP ID) before writing it to the macOS keychain. The key will be generated and stored in the Chrome profile under which the credential was created. (It is currently hardcoded but I'm changing that in a follow-up CL.) Deletion of the profile or key will therefore render the data unreadable. Bug: 678128 Change-Id: I536d537e9220cc5f89d487c7f94e169d06d62e7a Reviewed-on: https://chromium-review.googlesource.com/1073708Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#564609}
-
Ted Choc authored
It hits I/O deep in the Android stack: at android.util.BoostFramework.<init> (BoostFramework.java: 99) at android.widget.OverScroller$SplineOverScroller.<init> (OverScroller.java: 661) at android.widget.OverScroller.<init> (OverScroller.java: 79) at android.widget.OverScroller.<init> (OverScroller.java: 61) at android.widget.OverScroller.<init> (OverScroller.java: 51) at android.widget.AbsListView$FlingRunnable.<init> (AbsListView.java: 4807) at android.widget.AbsListView.setFriction (AbsListView.java: 5044) at android.widget.AbsListView.setScrollFriction (AbsListView.java: 915) at android.widget.AbsListView.initAbsListView (AbsListView.java: 955) at android.widget.AbsListView.<init> (AbsListView.java: 861) at android.widget.ListView.<init> (ListView.java: 227) at android.widget.ListView.<init> (ListView.java: 223) Added a TODO to investigate making list creation async, but that requires a lot of fundamental changes in the lifecycle of the location bar. BUG=848529 Change-Id: Icef168579dd5c2daa98378c14fa01a57db43e09d Reviewed-on: https://chromium-review.googlesource.com/1087490Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#564608}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/a9d8c29..4c1bea2 git log a9d8c29..4c1bea2 --date=short --no-merges --format='%ad %ae %s' 2018-06-05 dsodman@google.com [ftrace importer] Add fence parser Created with: gclient setdep -r src/third_party/catapult@4c1bea2 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I187eb278ec07ec14ab823cde5208898c25d9ce7b Reviewed-on: https://chromium-review.googlesource.com/1087299Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#564607}
-
