- 10 Sep, 2018 40 commits
-
-
Boris Sazonov authored
This CL disables "Activity and interactions" entry in "Sync and Google services" preference screen when custom passphrase is set. Bug: 882463 Change-Id: I1c882e6d6ecafc2f17d8e43801851002155974df Reviewed-on: https://chromium-review.googlesource.com/1216822Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#589955}
-
Christopher Cameron authored
Update NativeWidgetMacNSWindow to use the mojo BridgeNativeWidgetHost interface instead of directly dereferencing views structures. Make similar changes to ViewsNSWindowDelegate. Update the mojo interfaces to include these functions. Remove the nativeWidgetMac property from ViewsNSWindowDelegate. Replace it with an "id" uint64_t on NativeWidgetMacNSWindow, which can be used to look up a corresponding - BridgedNativeWidgetImpl (in the app/viewer process) - BridgedNativeWidgetHostImpl (in the browser process) - a follow-on patch will add a "shadow" NativeWidgetMacNSWindow in the browser process which will use this id - that window will not be visible, but will be used for state tracking and bounds computations This is a re-land of crrev.com/589415, reverted at crrev.com/589415 because it introduced static initializers. TBR=ellyjones,rsesek (reviewers of crrev.com/589415) Bug: 859152 Change-Id: I00d4c91d09a9d281f372a2a452837e4537c30b35 Reviewed-on: https://chromium-review.googlesource.com/1214604Reviewed-by:ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#589954}
-
John Abd-El-Malek authored
Bug: 845559 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Ibcaa434f5ffb1c43363190d4030ddb70f9449bf9 Reviewed-on: https://chromium-review.googlesource.com/1213275 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#589953}
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5313adfefcab..580b5f861834 git log 5313adfefcab..580b5f861834 --date=short --no-merges --format='%ad %ae %s' 2018-09-10 dproy@google.com Merge "Disable autodraw and implement our own router" Created with: gclient setdep -r src/third_party/perfetto@580b5f861834 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I93011dbcdcb22728eda71ca153a29b972addf747 Reviewed-on: https://chromium-review.googlesource.com/1216106Reviewed-by:
perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589952}
-
Joanmarie Diggs authored
* Add an event notifier in AXPlatformNodeAuraLinux for browser chrome. * Check to see if focus should follow selection. If it should, also emit state-changed:focused events. * Ensure that the correct states (focusable and selectable) wind up in the state set of elements where focus should follow selection. * Forward events from Blink content to AXPlatformNodeAuraLinux. * Create an event listener so that DumpAccessibilityEventsTest tests can be run. Add expectations for tests for which events are now emitted. At the present time, that is only focus and selected. R=dmazzoni@google.com Bug: 866340 Change-Id: I0d3334c39b064afc75ac5e051969fb43a79a0d8a Reviewed-on: https://chromium-review.googlesource.com/1163724Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Joanmarie Diggs <joanmarie.diggs@gmail.com> Cr-Commit-Position: refs/heads/master@{#589951}
-
Eric Roman authored
Previously methods on ProxyResolutionService took an optional ProxyDelegate pointer. This was problematic as not all callers were providing the correct value, and plumbing it down was inconvenient. Now the ProxyDelegate is instead an internal detail of the ProxyResolutionService. Bug: 793071 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I2eed185bc42cdc0bfcb945ad037fe2df52416198 Reviewed-on: https://chromium-review.googlesource.com/1208465Reviewed-by:
Matt Mueller <mattm@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#589950}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/a735ee2f6df8..480edb8c1d7d git log a735ee2f6df8..480edb8c1d7d --date=short --no-merges --format='%ad %ae %s' 2018-09-10 oetuaho@nvidia.com Clean up TextureStorage11_2DMultisample Created with: gclient setdep -r src/third_party/angle@480edb8c1d7d The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: Id29d74fb20de86bb2e5b1bddd892bc415b153fdc Reviewed-on: https://chromium-review.googlesource.com/1216543Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589949}
-
Mason Freed authored
With this change, there are now two color-profile related switches: --force-color-profile - forces the DISPLAY color profile to the desired setting. Note that the name of the flag didn't change, for backwards-compatibility. But it now refers to the display surface only. --force-raster-color-profile - forces the rasterization to happen in the provided color space. The exotic-color-space virtual test suite now sets the raster color profile to the ColorSpin profile, and the display color profile to sRGB. All other tests (by default) set both color profiles to sRGB. Bug: 875942, 667551 Change-Id: I66445cea5ed8dcc259a8f0bda2141350bcf66458 Reviewed-on: https://chromium-review.googlesource.com/1205713 Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by:Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#589948}
-
Greg Thompson authored
This removes the last use of BrowserDistribution in ShellUtil. BUG=879568 Change-Id: Ib6ec1ab03913f16f17495ce67f603c7f1eb7ba1a Reviewed-on: https://chromium-review.googlesource.com/1215282Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#589947}
-
Vadym Doroshenko authored
It's basically the same as in PasswordFormManager. Bug: 831123 Change-Id: Iee8fda80eb46e3be1245e2f28d5a9b08980f527e Reviewed-on: https://chromium-review.googlesource.com/1213156 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#589946}
-
Xida Chen authored
In the TouchActionFilter, we maintain a num_of_active_touches_ and increment it at TouchSequenceStart and decrement it at TouchSequenceEnd. From the collected data, we have seen num_of_active_touches_ goes larger than 1, while it never goes smaller than 0. This CL removes the DumpWithoutCrash so that it won't generate a crash report as we have enough data. TBR=dtapuska@chromium.org Bug: 880021 Change-Id: I0d097a4721f3f613f2d373eca408636f761ced17 Reviewed-on: https://chromium-review.googlesource.com/1216027Reviewed-by:
Xida Chen <xidachen@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#589945}
-
Erik Luo authored
- Adds ShouldServeMimeTypeAsContentTypeHeader() on URLRequestFileJob - With debug_devtools, our interceptor now serves files with ContentType header, allowing DevTools to importScripts() on locally-served bundled files. - Without this CL, strict MIME-type checks prevent importScripts() in FormatterWorker, required for pretty-print and autocomplete. Bug: 882013 Change-Id: Ib61284cfccd430dd9a4ddae769a416147c504e05 Reviewed-on: https://chromium-review.googlesource.com/1214365Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#589944}
-
Javier Ernesto Flores Robles authored
Creates a password coordinator to manage the mediator and view controller of passwords manual fallback. Bug: 878388 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I7be155f687707cf6cc5ff6082ce6548c1d1fa74e Reviewed-on: https://chromium-review.googlesource.com/1202145 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#589943}
-
Marc Treib authored
While we're here, also get rid of some "default:" cases in switches. Bug: 468320 Change-Id: I8695af13f946c1f374bdf0402f93ec9dd491977f Reviewed-on: https://chromium-review.googlesource.com/1215762Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#589942}
-
Paul Meyer authored
This patch implements crash reporting, as detailed in the reporting spec: https://w3c.github.io/reporting/#crash-report Change-Id: I209880150193910a0947608e6b08a6eeea29206c Reviewed-on: https://chromium-review.googlesource.com/1174965 Commit-Queue: Paul Meyer <paulmeyer@chromium.org> Reviewed-by:
Nick Carter <nick@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#589941}
-
Ivan Sandrk authored
Continuation of work from crrev.com/c/1202147, fixing up how delegates are set and persisted (using the base::NoDestructor pattern). Bug: 865947 Change-Id: Ib8768fe71e91c5f1bad400ec047b2c941a939608 Reviewed-on: https://chromium-review.googlesource.com/1210502Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Ivan Šandrk <isandrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#589940}
-
David Tseng authored
This reverts commit b9c37a4d. Reason for revert: <INSERT REASONING HERE> Likey change that causes many tests to flake (in chromevox_tests target). Bug: 881845 Original change's description: > Defer AX events to avoid problems with transient focus events. > > Some dialog boxes, like the accelerator confirmation dialog that appears > when you press Search+Control+M, focus the dialog and then immediately > after focus one of the buttons. This was causing ChromeVox to suppress > information about the context of the dialog. > > Fix this by using PostTask to defer all events from Views. This doesn't > even add any delay, it just pushes the event firing to after the current > call stack so that transient changes get suppressed. > > Manually confirmed that the experience with this particular dialog is > improved, other dialogs and views seem to continue to work fine. > > Bug: 729449 > Change-Id: I278c0c0b1dbdd26a654799fb5b314341942c1373 > Reviewed-on: https://chromium-review.googlesource.com/1176207 > Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: David Tseng <dtseng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#589201} TBR=jamescook@chromium.org,dmazzoni@chromium.org,sky@chromium.org,dtseng@chromium.org,yawano@chromium.org,sarakato@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 729449 Change-Id: I3275d959e96d05fdcfeac3c6b7839f7f36f75735 Reviewed-on: https://chromium-review.googlesource.com/1216664Reviewed-by:
-
Etienne Pierre-doray authored
Fix compile error with -Wshorten-64-to-32. Image size is new stored as an offset_t to avoid implicit conversion. Bug: 881008 Change-Id: I82b12ce17d8368f05d6a5537fd1734ee32b37dbe Reviewed-on: https://chromium-review.googlesource.com/1213549Reviewed-by:
Samuel Huang <huangs@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#589938}
-
Christian Dullweber authored
MediaLicenses are deleted together with Cookies in Clear Browsing Data (basic tab) now. We should also delete them from SiteDetails. Bug: 877999 Change-Id: Id4c751ca797ef6b3d123870cceb9eb1eef62e5f8 Reviewed-on: https://chromium-review.googlesource.com/1213242Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#589937}
-
Bailey Berro authored
This change updates the remount flow so that hosts on the network are rediscovered, so if the hostname is the same but the ip has changed since the share was originally mounted, the share will be able to be mounted. Bug: chromium:757625 Change-Id: I5038882fa44be15b725e1ccc0b377b244b62f787 Reviewed-on: https://chromium-review.googlesource.com/1199939 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#589936}
-
Kevin Bailey authored
The suggestion providers HistoryQuick, Search and Shortcuts call AutocompleteMatch::EnsureUWYTIsAllowedToBeDefault() to promote suggestions to have |allowed_to_be_default_match| set if the stripped URL matches the input. This was done to promote some higher scoring suggestions to become the default match. This is now done during sort-and-dedup by having an |allowed| suggestion inherit the best score that it matches. This CL removes the calls and therefore doesn't set |allowed| in these matches. Bug: 879796 Change-Id: I9529e3bea015e6e04f44ed5b401344d73556665b Reviewed-on: https://chromium-review.googlesource.com/1213281 Commit-Queue: Kevin Bailey <krb@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#589935}
-
Maks Orlovich authored
Hoping to fix 881941 Bug: 881941 Change-Id: I7ba5b34b3e3f0c6eec8747a0079a95a1f44aa732 Reviewed-on: https://chromium-review.googlesource.com/1214302Reviewed-by:
Bence Béky <bnc@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#589934}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/76dac9ac2f26..abd4273e43da git log 76dac9ac2f26..abd4273e43da --date=short --no-merges --format='%ad %ae %s' 2018-09-10 danilchap@webrtc.org Cleanup test::FrameGeneratorCapturer::InsertFrameTask 2018-09-10 ilnik@webrtc.org Revert "Reenable simulcast video full stack test on MAC" 2018-09-10 danilchap@webrtc.org Move RtcpTransceiver deletion of copy and assign methods to public section 2018-09-10 danilchap@webrtc.org Disallow assign by deleting correct assign signature 2018-09-10 yuriy@appear.in Use default RTCConfiguration on iOS 2018-09-10 ssilkin@webrtc.org Revert "Enable VP9 KSVC perf tests." 2018-09-10 phoglund@webrtc.org Bump iOS bots to iOS 11. 2018-09-10 aleloi@webrtc.org Store RuntimeSetting in Aec Dumps. 2018-09-10 ssilkin@webrtc.org Revert "Frame rate controller per spatial layer." 2018-09-10 sprang@webrtc.org libvpx vp8 encoder: get frame drop setting from temporal layer 2018-09-10 philipel@webrtc.org Removed unused member |last_unwrap_| from RtpFrameReferenceFinder. 2018-09-10 ivoc@webrtc.org Add more useful information to NetEqState and implement action_times_ms 2018-09-10 sprang@webrtc.org For simulcast screenshare, make 2 tl default for high stream. Created with: gclient setdep -r src/third_party/webrtc@abd4273e43da The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:881453,chromium:881453,chromium:882358,chromium:none TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ic79aad33d5a5265556677e68241874e128335f8e Reviewed-on: https://chromium-review.googlesource.com/1216107Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589933}
-
W. James MacLean authored
Temporarily disable this test while we resolve the flakiness issue. Bug: 882458 Change-Id: I03dcfd61ec172fc8206414428427d8439f503bff TBR: kenrb@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1216704Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#589932}
-
Rayan Kanso authored
TBR=peter@chromium.org Change-Id: I57ea9fbf394491f31a5c319b82d6eccf7f0cf4e2 Reviewed-on: https://chromium-review.googlesource.com/1216344Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#589931}
-
Aldo Culquicondor authored
Bug: 881970 Change-Id: I23d7c563929d0c95459050669b3303eba3785128 Reviewed-on: https://chromium-review.googlesource.com/1216464Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Aldo Culquicondor <acondor@chromium.org> Cr-Commit-Position: refs/heads/master@{#589930}
-
Peter K. Lee authored
This CL is intended to be cherrypicked to M70 branch, so changes is kept to be a minimum. Bug: 882424 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ibad7c24e5d080471f16ece252648cadd8e3346f8 Reviewed-on: https://chromium-review.googlesource.com/1216026Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#589929}
-
Peng Huang authored
Chrome will use Skia instead of using Vulkan API directly. So some code will not be used anymore, so remove them. Bug: 876825 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ia572cfa0937a3d09e139f88df22cff85cfb67abb Reviewed-on: https://chromium-review.googlesource.com/1204921 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#589928}
-
Boris Sazonov authored
This CL moves the sync error card shown in "Sync and Google services" out of "Sync and personalization" section. It also removes a redundant key attribute from a divider in sync_and_services_preferences.xml. Bug: 882455 Change-Id: I2721bf8964fbb78f1e103df5e249e540113fe200 Reviewed-on: https://chromium-review.googlesource.com/1216070Reviewed-by:
-
Sam Maier authored
We aren't removing the third_party/ copy yet to avoid a breakage downstream. Once downstream is updated, we will move all usages over and remove the third_party/ folder. Bug: 825947 Change-Id: I392779043cc3f3d971df86ebeef4144a0c9cc5dc Reviewed-on: https://chromium-review.googlesource.com/1213534Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#589926}
-
Matthew Jones authored
Instead of adjusting the padding for the whole NTP view, this patch only changes the margin on the logo (if it exists). This causes the most visited icons to be in the correct position when the omnibox is focused (with and without logo) and fixes an accessibility focus highlight bug. Bug: 879485, 876542, 881993 Change-Id: If8df92af096a44a18dea83fdaa49a0776f5296c5 Reviewed-on: https://chromium-review.googlesource.com/1214219Reviewed-by:
-
David Davidović authored
When deriving keys using PBKDF2 in Nigori, previously, a |hostname| and |username| parameter were accepted via the KeyDerivationParams struct. They were used to derive the per-user key derivation salt. However, at all call sites, hardcoded strings "localhost" and "dummy" were always passed, resulting in a constant salt for all users. Furthermore, we were computing a value that never changes, which was not needed. Remove |hostname| and |username| as configurable parameters, and instead hardcode the constant salt derived from them directly in Nigori. Add a test to Nigori to ensure that the derived keys stay the same. Remove |hostname| and |username| from KeyDerivationParams altogether and update all call sites to not pass the hardcoded "localhost" and "dummy" strings. In Nigori unit tests, update hardcoded test vectors because they all used different hostname and username parameters than "localhost" and "dummy", and so were no longer correct. (Note that the salt cannot be changed due to backwards-compatibility reasons. To remedy the weakness of this encryption, a new key derivation method (scrypt) which uses a random salt has been recently introduced.) TBR=sdefresne@chromium.org Bug: 880535 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I93e9a0f69684f2e29ba48321efb01016761f424d Reviewed-on: https://chromium-review.googlesource.com/1205031 Commit-Queue: David Davidović <davidovic@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#589924}
-
Stephane Zermatten authored
This is a reland of 5bf6f1b1 Original change's description: > [Autofill Assistant] Bind the script tracker with the controller. > > With this change, the controller tells the script tracker to run checks > when necessary, calls the UI controller to choose a script to run and > run the script that was chosen. The implementation of the UI controller > for choosing the script is not included into this change. > > Integration is preliminary, just to get something to get started until > we have a usable UI to try it out. The UI part, implementing script > selection, is missing from this change. > > Change-Id: I867bec0e554dfdd87fc2f95e7c9088391621c5c9 > Bug: 806868 > Reviewed-on: https://chromium-review.googlesource.com/1194034 > Commit-Queue: Stephane Zermatten <szermatt@chromium.org> > Reviewed-by: Ganggui Tang <gogerald@chromium.org> > Cr-Commit-Position: refs/heads/master@{#589135} Bug: 806868 Change-Id: I40b66adca74162a1a41a47f1e065d2bf3aa225ed Reviewed-on: https://chromium-review.googlesource.com/1209709 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#589923}
-
Nicolas Ouellet-Payeur authored
BrowserSwitcherService is a per-BrowserContext class that manages resources that should be shared between tabs in the same BrowserContext: for now, the sitelist and browser launcher objects. The BrowserSwitcherServiceFactory lets us easily create only one BrowserSwitcherService per BrowserContext. Bug: 876803 Change-Id: I6eb4c235143cfe38a077141b62e9332ed0f30a05 Reviewed-on: https://chromium-review.googlesource.com/1206698Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#589922}
-
Yao Xiao authored
Indicating whether the page called window.open() from an ad subframe and/or with an ad script in the stack. Bug: 880923 Change-Id: Ia64fea4f32bc62c3ee5aceb3731a236b88b1c807 Reviewed-on: https://chromium-review.googlesource.com/1206676 Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#589921}
-
Egor Pasko authored
This should help triage cases when library prefetching takes too long or too little. Bug: 881384 Change-Id: I315020758bb702578237fae6de5c776e27c367d4 Reviewed-on: https://chromium-review.googlesource.com/1215802Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
-
kylechar authored
Remove the ability to access RenderingWindowManager on any thread and remove locks. Make RegisterChild() PostTask back to the UI thread if necessary so it can still be called anywhere. There is already a PostTask before ::SetParent() gets called, so this shouldn't add much extra latency before things show up on screen. Also move the checks that parent HWND was registered and child HWND was created by expected process id to happen immediately before calling ::SetParent(). This ensures that child HWND belongs to the right process. We don't need to check the parent HWND process because we check it registered by the browser process. This also fixes a race with OOP-D where RegisterChild() can get called more than once due to races between different message pipes. Bug: 791660 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: If8e98bd974dbc77e1be21252d3aa1682f3e6e016 Reviewed-on: https://chromium-review.googlesource.com/1194580 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#589919}
-
Eric Seckler authored
Add the dependencies of the invoker target to the generated nocompile targets. This should address the flakiness issues of building content_nocompile_tests. Bug: 882234 Change-Id: Ic7f7a07d3a6567202b3a0da8800228c7329f119d Reviewed-on: https://chromium-review.googlesource.com/1215964Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#589918}
-
spirv-chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/40a68547dcda..f62d7978fc50 git log 40a68547dcda..f62d7978fc50 --date=short --no-merges --format='%ad %ae %s' 2018-09-10 31666470+s-perron@users.noreply.github.com Add validation check for arrays of void type. (#1880) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@f62d7978fc50 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I929e9b642f90e6e540e83c2ad3dea737493bf571 Reviewed-on: https://chromium-review.googlesource.com/1216105Reviewed-by:
spirv-chromium-autoroll <spirv-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: spirv-chromium-autoroll <spirv-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589917}
-
Peng Huang authored
This change also fixes the synchronization problem. Bug: 878011 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I15f73c32b76fdf9456e26e811d36b9d8dcfe35d6 Reviewed-on: https://chromium-review.googlesource.com/1195661 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
-
