GitLab

This CL may cause a small binary size increase, roughly proportional
to how long it's been since our last AFDO profile roll. For larger
increases (around or exceeding 100KB), please file a bug against
gbiv@chromium.org. Additional context: https://crbug.com/805539

The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=gbiv@chromium.org

Change-Id: Id3135e96fd138ff4806d57d194688ab26c651cc2
Reviewed-on: https://chromium-review.googlesource.com/1235893Reviewed-by: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#592733}

This CL merges the AdaptiveToolbar test suite in the more general
ui_egtest test suite as it was used a separated test suite to make
sure the flag was enabled.
As it is now enabled by default, it can be merged and the hooks can be
removed.

Bug: 800266
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Ide6f2d8e0f5385602794e0036c1af3fc7bfb86e6
Reviewed-on: https://chromium-review.googlesource.com/1230734Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592732}

In this CL, we add hashset that control all the assigned slots
in the shadowroot for each node.
Thanks to this hashset we can find the assigned slot for each
node in O(1) order, instead of searching all the slot for each
shadow root.
Other changes about slot change event will be added in separate
CL.

Bug: 869308

See design doc at https://docs.google.com/document/d/1n2iDNkI5bF4B5eefxa0SRSyS_RVchvTNSqezvA4PyF4/edit#heading=h.dkp0e2job8nf

Change-Id: I60284316902417efd692988b449fe660af8349c5
Reviewed-on: https://chromium-review.googlesource.com/1195298
Commit-Queue: Kyoko Muto <kymuto@google.com>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592731}

This Cl forces GetTabSwitcherMode to always return GRID, and cleans up
MainController to no longer have non-GRID code paths.

The tab strip was using tabs switcher images implicitly via the chrome/app inclusion; this CL also fixes that.

Bug: 884724
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I5e2655a86094f417d0987bcf532d4cac86b9e5fd
Reviewed-on: https://chromium-review.googlesource.com/1230058
Commit-Queue: Mark Cogan <marq@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592730}

Bug: 875525, 884963
Change-Id: I3b3d290e2f7cc9781b7af3d3caea4508330e21ff
Reviewed-on: https://chromium-review.googlesource.com/1234118
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592729}

This makes callsites slightly slower (requiring calls to strlen()), but
the result is cached for the primary user of this, so the difference
from that is likely negligible. Each indiviual method however no longer
need to instantiate a WTF::String, yielding a perhaps modest, but not
insignificant, reduction in binary size (-1568 bytes according to
the android-binary-size bot.)

Change-Id: Ib9ecc17cbe3e745bc2c33e1b4d9dcbd40190e026
Reviewed-on: https://chromium-review.googlesource.com/1233710Reviewed-by: Anders Ruud <andruud@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#592728}

Changes in this CL:
- added a drop shadow
- added a divider at the top of the accessory sheet
- centered text for accessory options (e.g. Manage passwords...)

Bug: 856180, 887258
Change-Id: I7b71670ef551d8d5f86501ba47011ae590323676
Reviewed-on: https://chromium-review.googlesource.com/1225803
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Reviewed-by: Friedrich Horschig [CEST] <fhorschig@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592727}

We will shortly be changing IdentityManager to fire
IdentityManager::Observer::OnRefreshTokenRemovedForAccount() as a
straight passthrough from
ProfileOAuth2TokenService::Observer::OnRefreshTokenRevoked() as part of
crbug.com/883722. However, this raises a challenge in that the
AccountInfo isn't guaranteed to be in AccountTrackerService when this
callback is received by IdentityManager.

To prepare for this change, this CL changes
IdentityManager::Observer::OnRefreshTokenRemovedForAccount() to pass
the account ID. No observer requires anything else from the AccountInfo
that is currently being passed.

Bug: 883722
Change-Id: Iccd921a11ab229b897028987e538cc799ed35026
Reviewed-on: https://chromium-review.googlesource.com/1225980Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592726}

This CL cleans the toolbar buttons up. It flags the code that cannot be
removed yet. This code is usually still used by classes that will be
removed in the future.

Bug: 800266
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I975e2f7e46e7dfee512f43be8429916c780e5cab
Reviewed-on: https://chromium-review.googlesource.com/1232959
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592725}

Read list of persisted shared paths from prefs, and re-share
with seneschal/9p when container starts.

Bug: 878324
Change-Id: Iea0ff71b79e5787d06b9d1b42a985cea2fb2631b
Reviewed-on: https://chromium-review.googlesource.com/1232793
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Reviewed-by: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592724}

This CL removes the legacy implementation of the toolbar.

Bug: 800266
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Ic0bcca519ad1340cd537fda7f015b7021a1ea594
Reviewed-on: https://chromium-review.googlesource.com/1230718
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592723}

Bug: 887017
Change-Id: Ic9ed47bc1bec79e598b0fe5cccc2aa83cc6d8b6f
Reviewed-on: https://chromium-review.googlesource.com/1235363Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592722}

This CL modifies BVC so the legacy toolbar is no longer initialized.

Bug: 800266
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I2cf98fbfd55b550cedecd329eccb1ee36565e98a
Reviewed-on: https://chromium-review.googlesource.com/1230735
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592721}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1c2f24da7847..422774f688e4


Created with:
  gclient setdep -r src-internal@422774f688e4

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I1d5f998ece5ec1668792304ded7b15b62b4f9963
Reviewed-on: https://chromium-review.googlesource.com/1235332Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#592720}

Neither PasswordManager.TotalAccounts and
PasswordManager.TotalAccountsHiRes.WithScheme is logged directly into,
but they serve as a base for suffixes.

In particular, PasswordManager.TotalAccounts used to be logged into,
but is no more (since [1]), so the UMA data shows a steady decline in
its numbers (while the suffixes show growth).

Therefore, this CL marks those histograms as base.

The CL also completes the description and updates the owners of the
former histogram (gcasto@ left the project some years ago).

[1] https://chromium.googlesource.com/chromium/src/+/e015fd92a519f7c9cbc12ae341e18b650eaab1d3

Bug: 884219
Change-Id: I98f94df53ef3280297c3e6ce3de81dfe2ef442f0
Reviewed-on: https://chromium-review.googlesource.com/1225768Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592719}

Introduce FileChooserFileInfo mojo struct, and replace
blink::FileChooserFileInfo usage with it.

FileChooserFileInfo mojo struct is not sent via mojo IPC yet. We
still have conversion like content::FileChooserFileInfo ->
blink::WebFileChooserCompletion::SelectedFileInfo ->
blink::mojom::blink::FileChooserFileInfo.

* File path is represented as WTF::String in blink::FileChooserFileInfo,
and now as base::FilePath.  This CL changes |WebFileChooserCompletion::
SelectedFileInfo::path| from WebString to base::FilePath in order to
avoid unnecessary FilePath-string conversions.

* File timestamp is represented as double in blink::FileChooserFileInfo,
and now as base::Time.  This CL changes |WebFileChooserCompletion::
SelectedFileInfo::modification_time| from double to base::Time in order
to avoid unnecessary conversions.

* PepperFileChooserHost::ChooserFileInfo::path is changed from UTF-8
std::string to base::FilePath in order to avoid unnecessary
FilePath-string conversions.

* Add helper functions:
  - CreateFileChooserFileInfoNative()
  - CreateFileChooserFileInfoFileSystem()
  - WebStringToFilePath()
  - FilePathToString()

* blink::DirectoryName() is removed. Now we use FilePath::DirName().


FYI: All-in-one CL: https://chromium-review.googlesource.com/1170454

Bug: 869257
Change-Id: I8bd578085519953d3470e0e6e07dffc5fd154958
Reviewed-on: https://chromium-review.googlesource.com/1226537Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592718}

"using namespace" is not allowed per the Code Style Guide, but
worse, much much much worse, it won't work in jumbo builds because
they will be in a different context where a compiler error
will be triggered.

Bug: 886902
Change-Id: I635ceb8ec5d65a9d599ecd38bf0c150c90edf056
Reviewed-on: https://chromium-review.googlesource.com/1233837Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#592717}

This CL removes the code used by FindInPage pre-UI Refresh.

Bug: 800266, 879136
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I1b3ee786c19cebd54dc641fb7a7d71f5d4b1b8b6
Reviewed-on: https://chromium-review.googlesource.com/1233836
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592716}

The following preferences are removed from the persistent storage list
for incognito mode:
 - kClearedBlockedSiteNotificationChannels
 - kDRMSalt
 - kEnableDoNotTrack
 - kEnableDRM
 - kEnableHyperlinkAuditing
 - kEnableEncryptedMedia
 - kMediaStorageIdSalt
 - kPushMessagingAppIdentifierMap

These preferences are either never changed from incognito mode, or if
changed, they do not need to be written to user profile.

Bug: 861722
Change-Id: I52437e7ef3a141babb1a797092d3ae316a059761
Reviewed-on: https://chromium-review.googlesource.com/1233354
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Raymes Khoury <raymes@chromium.org>
Reviewed-by: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592715}

DriveFS system service now supports search. Plumb IPCs to invoke it from
chrome and implement drive search when DriveFS flag is on.

BUG=chromium:854481

Change-Id: If62c1dc1e7da504e348e1056b983e5febc45f855
Reviewed-on: https://chromium-review.googlesource.com/1229715
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Sergei Datsenko <dats@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592714}

This CL removes the code used only by the old UI in the Toolbar
Button Factory.
In order to keep compilation intact, the methods are emptied, they are
not removed.

Bug: 800266
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Id74766e69c9f06a7e44fa2c669789a4bc9822675
Reviewed-on: https://chromium-review.googlesource.com/1230677Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592713}

This CL removes the pre-UIRefresh code in BubblePresenter.

Bug: 884724
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Ia894f9c97f2d5b2d0b5aa26356aba3c471a05522
Reviewed-on: https://chromium-review.googlesource.com/1233703Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592712}

This removes some unnecessary abstractions and helps
with mojoification of Blink accessibility, and eventually
will help us to remove all of the code in
content/renderer/accessibility.

Bug: 882660
Change-Id: I504876e4ec5d7a50c439031b66c3d8d2525109e9
Reviewed-on: https://chromium-review.googlesource.com/1226200
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592711}

Invisible-static custom elements are still upgraded when they are
constructed through HTML parser. To make it clear, we are adding test
to confirm this behavior. This CL also make the previous test's
custom element constructor to not append a child to verify upgrades.

Previous change that defer upgrades of invisible="static" elements:
https://chromium-review.googlesource.com/c/chromium/src/+/1204373

Bug: 873057
Change-Id: If25afa4c1c77ecd70988d3d29cc5ab020247b8ea
Reviewed-on: https://chromium-review.googlesource.com/1235265
Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592710}

Audio Player was using Shadow DOM's polyfil, aka Shady DOM which is
included in Polymer1. Chrome has had a fully working native Shadow DOM
for quite a while. The remaining Polymer WebUI has already been using
native Shadow DOM.

This fix is to make Audio Player elements and tests compatible with
Polymer2, tests still require further work to pass in Polymer2.

Replace all occurrences of:
"chrome://resources/polymer/v1_0/polymer/polymer.html"
with:
"chrome://resources/html/polymer.html"

The new polymer.html configures Polymer 1.0 to run with ShadowRoot
making these polymer elements be compatible with Polymer 2.0.

Fix Audio Player tests:

1. Audio Player is compound of 3 main Polymer elements:
* "audio-player": main component which use the other 2 below.
* "control-panel": buttons to control, like play, pause, next, etc.
* "track-list": List of all tracks to be played.

2. Files app and Audio player test utils, has the ability to query
elements deep in the ShadowRoot, however it requires an Array of
selectors instead of a simple string selector. For every element that
has a ShadowRoot, we need to provide an element on the selector array.
E.g.:
['audio-player', 'control-panel', '.some-class']: Gets "audio-player"
then selects in its shadowRoot for "control-panel", then selects
".some-class" in "control-panel" shadowRoot.

3. Define "trackListQuery" and "controlPanelQuery" to make simpler to
traverse these 2 Polymer sub-components.

4. Fix all selectors to make explicit the component traversal.

Test: browser_tests --gtest_filter="AudioPlayer*:OpenAudioFiles*"
Bug: 875525
Change-Id: I64e94452ff4cc8eb51137620013ad0cf00101f67
Reviewed-on: https://chromium-review.googlesource.com/1226478Reviewed-by: Noel Gordon <noel@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592709}

For the same reason as the existing code to strip '/showIncludes'.

Change-Id: I8b9180434d7ebee41b67117ce27ae054ddc948a9
Reviewed-on: https://chromium-review.googlesource.com/1235259Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Owen Rodley <orodley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592708}

https://skia.googlesource.com/skia.git/+log/4054351369df..52c63fdabb72


git log 4054351369df..52c63fdabb72 --date=short --no-merges --format='%ad %ae %s'
2018-09-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 25c541e51cbd..2ecc8b712b08 (1 commits)


Created with:
  gclient setdep -r src/third_party/skia@52c63fdabb72

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=reed@chromium.org

Change-Id: If06af720e61d40da10c993a5c50ead203c6d27b8
Reviewed-on: https://chromium-review.googlesource.com/1235415Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#592707}

Support multiple bindings in DeviceManagerImpl so that the Device
Service can own a unique DeviceManagerImpl instance easily and
the unique UsbService instance will be owned by DeviceManagerImpl,
then we can git rid of DeviceClient after all users being converted
to mojom interface.

Bug: 699790
Change-Id: I8a62739796f99a98bf87a1ed71562c09cba9e050
Reviewed-on: https://chromium-review.googlesource.com/1221475
Commit-Queue: Donna Wu <donna.wu@intel.com>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592706}

https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/48093e2673c6..137cb973fb0e

$ git log 48093e267..137cb973f --date=short --no-merges --format='%ad %ae %s'
2018-09-18 nverne Add VmStatus to StartVmResponse.

Created with:
  roll-dep src/third_party/cros_system_api

Bug: 884576
Change-Id: I14a5648257e09d87f35b5de0a735c614568cad22
Reviewed-on: https://chromium-review.googlesource.com/1235514Reviewed-by: Timothy Loh <timloh@chromium.org>
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592705}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/98555ca139f9..1c2f24da7847


Created with:
  gclient setdep -r src-internal@1c2f24da7847

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: Ieaae67a196b88a9417de0a5eeb11d00b9d05f257
Reviewed-on: https://chromium-review.googlesource.com/1235416Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#592704}

This CL is a refactoring to remove PersistentHeapVector and its usage with Persistent<HeapVector>

design doc: https://docs.google.com/document/d/1yaPgNqed81gHm4nBQVJow6iiNaea5hDJSobNG_jkWg8/edit?usp=sharing

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I36b11b86ccfd0e0920d2ecf3a5575258a6d89c0a
Reviewed-on: https://chromium-review.googlesource.com/1218643
Commit-Queue: Keishi Hattori <keishi@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592703}

This CL refines a previous test and the FakeServer so that it actually
tests what it is supposed to test.

The CL also does minor polish in the FakeServer code (so that I can
understand what is going on).

Double-checked by breaking the code.

Bug: 876308
Change-Id: I0885647c42ec029db0b76f998840c7378d3496c1
Reviewed-on: https://chromium-review.googlesource.com/1221311Reviewed-by: Tim Schumann <tschumann@chromium.org>
Commit-Queue: Jan Krcal <jkrcal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592702}

Use memory_instrumentation::OSMetrics::FillOSMemoryDump(), which
reads /proc/<pid>/statm, to get private bytes of a process, to avoid
contention with kswapd under heavy memory pressure.

BUG=chromium:872253
TEST=manual
R=cylee@chromium.org, sonnyrao@chromium.org, fdoray@chromium.org

Change-Id: I4d43933a39c3c89d8ebb81e3ccef20277cedb258
Reviewed-on: https://chromium-review.googlesource.com/1212246
Commit-Queue: Chinglin Yu <chinglinyu@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Cheng-Yu Lee <cylee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592701}

Supervised users have been gone for a long time.

Bug: 828890
Change-Id: I18b12e49ac10c445eabc7151e7f3b7995b5fa24d
Reviewed-on: https://chromium-review.googlesource.com/1231314
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592700}

It doesn't really do anything useful: It provides an observer mechanism
which only passes through SyncServiceObserver::OnStateChanged (so anyone
interested might just use that directly), and it has single, misnamed
method HasError() which is replaced by a global ShouldShowPassphraseError
helper.

Bug: none
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I0116b6cf5d3a814bc2b3fa51e79da7a3c2eebc63
Reviewed-on: https://chromium-review.googlesource.com/1230056Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Jan Krcal <jkrcal@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592699}

This is almost the same cl as
https://chromium-review.googlesource.com/c/chromium/src/+/1226715

The previous cl was reverted because it broke linux-chromeos-dbg due to missing
"=0" for a virtual method of an abstract class (incorrect gn config meant the
compiler didn't pick it up). It's added in this cl. This is
the only change from the previous cl.

Bug: 881215
Change-Id: Iaf5ab6e3ee98c11b593dcc9d759527c4fb3b2168
Reviewed-on: https://chromium-review.googlesource.com/1235262Reviewed-by: Michael Martis <martis@chromium.org>
Commit-Queue: Jia Meng <jiameng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592698}

This is a follow-up CL for https://chromium-review.googlesource.com/c/chromium/src/+/1229739

Bug: 870606
Change-Id: I0b877b3b611e9696e9d8fe38c8091ec8fbe5b304
Reviewed-on: https://chromium-review.googlesource.com/1233102Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592697}

Adds ART build tools used for android builds, in particular
dexlayout and associated profile management.

Bug: 875276
Change-Id: I323e460dfca032a5b28a634d149d1f50c8563f3b
Reviewed-on: https://chromium-review.googlesource.com/1218584Reviewed-by: Grace Kloba <klobag@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Matthew Cary <mattcary@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592696}

MediaRouterDialogControllerViewsTest.OpenCloseMediaRouterDialog is failing
on the mac bot. The error logs are:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/mac-cocoa-rel/1321
https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8935002203177419984/+/steps/browser_tests_on__none__GPU_on_Mac/0/logs/MediaRouterDialogControllerViewsTest.OpenCloseMediaRouterDialog/0

Tbr: mfoltz@chromium.org
Bug: 883976
Change-Id: I9b7e42b65ec44a97a74d236c179e1698ef0c895e
Reviewed-on: https://chromium-review.googlesource.com/1235264Reviewed-by: Taiju Tsuiki <tzik@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592695}

ui::MenuModel (which ui::SimpleMenuModel inherits from) declares a
virtual method, `void MenuWillShow()`. SimpleMenuModel::Delegate
declares a similar method, `void MenuWillShow(SimpleMenuModel*)`. This
results in a conflict for any class that inherits from both
SimpleMenuModel and SimpleMenuModel::Delegate (which is not uncommon).

Resolve this by renaming the SimpleMenuModel::Delegate version to
`void SimpleMenuWillShow(SimpleMenuModel*)`.

Bug: 885198
Change-Id: I0581991fa7a12368007f6c082c461acb4833750c
Reviewed-on: https://chromium-review.googlesource.com/1230581Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#592694}