- 10 Sep, 2018 40 commits
-
-
Luke Sorenson authored
This reflects non-forwards / non-backwards compatible changes to the Video Capture Service mojom APIs, which ship with Chrome. Bug: 881398 Change-Id: Ia5833b63097035346bc388564b9bb6545ffa0c84 Reviewed-on: https://chromium-review.googlesource.com/1211082Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Luke Sorenson <lasoren@chromium.org> Cr-Commit-Position: refs/heads/master@{#589902}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/234d4e4d5de2..0c8cc6141c62 git log 234d4e4d5de2..0c8cc6141c62 --date=short --no-merges --format='%ad %ae %s' 2018-09-10 ulan@chromium.org Fix a bug in console error metric. Created with: gclient setdep -r src/third_party/catapult@0c8cc6141c62 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:880432 TBR=sullivan@chromium.org Change-Id: Ifab689590bc91edb6e04ce0517fbb8df7769da53 Reviewed-on: https://chromium-review.googlesource.com/1216103Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589901}
-
Aiden Benner authored
In preparation for enabling an ErrorProne check to ban them Bug: 878853 Change-Id: I267c5260c03e768ebcb732fed1a8966c4f598857 Reviewed-on: https://chromium-review.googlesource.com/1214086Reviewed-by:
Simeon Anfinrud <sanfin@chromium.org> Commit-Queue: Aiden Benner <abenner@google.com> Cr-Commit-Position: refs/heads/master@{#589900}
-
Vasilii Sukhanov authored
Chrome internal pages. Basically it should not appear if password filling is disabled. In addition the guest mode should also suppress the item as it leads to nowhere. Bug: 865917 Change-Id: Id260341e381ab99d364daf8819f7f07cd350b141 Reviewed-on: https://chromium-review.googlesource.com/1205030 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#589899}
-
Tonko Sabolčec authored
This Cl includes: - Add a feature flag which is disabled by default. - Include key creation utility to prevent key overwrites in KeychainPassword::GetPassword(). - Add tests for the above changes. - Register the local state early from the main thread in os_crypt. Bug: 791541 Change-Id: I2a664cd285fe73b32a15b2949977b940d95e7bbe Reviewed-on: https://chromium-review.googlesource.com/1188318 Commit-Queue: Tonko Sabolčec <tsabolcec@google.com> Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#589898}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/c869f29dcef0..234d4e4d5de2 git log c869f29dcef0..234d4e4d5de2 --date=short --no-merges --format='%ad %ae %s' 2018-09-10 mythria@chromium.org v8_experimental_tool : Ignore samples without a diagnostic Created with: gclient setdep -r src/third_party/catapult@234d4e4d5de2 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:866423 TBR=sullivan@chromium.org Change-Id: Icbdc87f235d7ebe678da01e6bfd65aa2b213ed5c Reviewed-on: https://chromium-review.googlesource.com/1214725Reviewed-by:
-
Manuel Rego Casasnovas authored
Change-Id: I65fcd250c120d5b54f361a8eec620c18eda549e7 Reviewed-on: https://chromium-review.googlesource.com/1215705Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#589896}
-
Kyoko Muto authored
To check the performance in manual-slotting mode, this CL introduces micro benchmark test. Bug: 869308 Change-Id: I4232588640a38e90e10e30a8e48e6b2b7923bc80 Reviewed-on: https://chromium-review.googlesource.com/1184738 Commit-Queue: Kyoko Muto <kymuto@google.com> Reviewed-by:
Hayato Ito <hayato@chromium.org> Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#589895}
-
Thomas Tangl authored
When the sync error state changes from one error to another, the AvatarToolbarButton was not updated. This CL fixes this. Bug: 881874 Change-Id: I247cf12a18f8122a22b2d51dd5e6f1febdd6f432 Reviewed-on: https://chromium-review.googlesource.com/1215864Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#589894}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/b33290d08211..76dac9ac2f26 git log b33290d08211..76dac9ac2f26 --date=short --no-merges --format='%ad %ae %s' 2018-09-10 mbonadei@webrtc.org Fix no_global_constructors in modules/video_capture. 2018-09-10 kron@webrtc.org Make HasAttribute handle partial matching of attribute names. 2018-09-10 danilchap@webrtc.org Verify posting task and reply just before task queue destruction 2018-09-10 ssilkin@webrtc.org Enable VP9 KSVC perf tests. Created with: gclient setdep -r src/third_party/webrtc@76dac9ac2f26 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ie58ffb89a7529c9d1f418276e8db36cf512341d0 Reviewed-on: https://chromium-review.googlesource.com/1214724Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589893}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/abc91d41..33b726db Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id14707d6ac2e265b7535bf3f0e0fbdb21de6b9b0 Reviewed-on: https://chromium-review.googlesource.com/1215247Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#589892}
-
Olivier Robin authored
Bug: 851636 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs Change-Id: I7d59a9dc36f084936744ebf1069085b7d8906fec Reviewed-on: https://chromium-review.googlesource.com/1148051 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#589891}
-
Dominic Battré authored
This reverts commit 1dba3ee8. Reason for revert: Speculative revert due to Failures on ios_chrome_bookmarks_egtests (iPhone X iOS 12.0) Original change's description: > [ios] Added bookmark search > > When opening: > https://drive.google.com/file/d/1z4iyQgQOL9jUFNfIf9Qg1SmFz9INxN88/view?usp=sharing > When searching: > https://drive.google.com/file/d/1wdMrOC9GDzh7e97HY-1ObHergJH0rnoC/view?usp=sharing > > In action: > https://drive.google.com/file/d/14NMZ4mkCUZM8QNyopWHQ6MyDX939bcni/view?usp=sharing > > Bug: 879570 > Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs > Change-Id: I51f88361a79703c55f03e2befb745ca3701ce577 > Reviewed-on: https://chromium-review.googlesource.com/1193932 > Commit-Queue: David Jean <djean@chromium.org> > Reviewed-by: Sergio Collazos <sczs@chromium.org> > Reviewed-by: Gauthier Ambard <gambard@chromium.org> > Cr-Commit-Position: refs/heads/master@{#589861} TBR=sczs@chromium.org,gambard@chromium.org,djean@chromium.org Change-Id: Ia9b723b9a69cb7aa4cf00f339f380a15a7e64109 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 879570 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/1215866Reviewed-by:
-
Dominic Battre authored
Several tests crash flakily (see crbug.com/881476) on Windows. This CL disables those CLs. TBR=jialiul@chromium.org,fdoray@chromium.org,asvitkine@chromium.org Bug: 881476,872820 Change-Id: I73104af5fc5a9215c313e06c3ecc77dcf426100c Reviewed-on: https://chromium-review.googlesource.com/1215862Reviewed-by:
-
Benoit Lize authored
Currently, we have: ParkableString -> ParkableStringImpl -> Null String This removes the indirections, saving memory and making code simpler. Bug: 877044 Change-Id: Ib6d22cad836c1eca9918e0198f5e6a1af8fccbe2 Reviewed-on: https://chromium-review.googlesource.com/1213262Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#589888}
-
Nico Weber authored
Depends on https://chromium-review.googlesource.com/c/chromium/tools/build/+/1214630 Bug: 882231 Change-Id: I3276fb8b2a6742e0c24c38b64b6593f139c940d6 Reviewed-on: https://chromium-review.googlesource.com/1214929Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#589887}
-
Sergey Poromov authored
Previously, when ARC failed to start to do provisioning failure, especially no network connect, Public Session was exited too. Now, the error is not ignored only for Kiosk mode, while in PS only ARC container will be shut down, but user will be able to use PS without Android apps. Later we should consider starting ARC fully offline with installing apps from the cache. Bug: 871381 Test: Manual, new unit test Change-Id: If3c7f03c12587930211ba6bf5f3b7177a4634fdc Reviewed-on: https://chromium-review.googlesource.com/1213245Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#589886}
-
Dominic Battre authored
Disabled test due to flaky timeouts that are observed on all platforms. TBR=jkarlin@chromium.org Bug: 882077 Change-Id: Icdc062abcfff372060ce8cb173adbf4aba542b40 Reviewed-on: https://chromium-review.googlesource.com/1215327Reviewed-by:
-
Vladislav Kuzkokov authored
The previous version just checked whether long edge duplex mode is available. Bug: 842063 Change-Id: Ia36246bdb1bedad04a03c592dd4622264413c7d8 Reviewed-on: https://chromium-review.googlesource.com/1113189 Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#589884}
-
tzik authored
v8::PersistentValueMapBase<> is an old style non-copyable type. It has private declaration-only copy ctor and assignment. That is inherited to v8::GlobalValueMap<>, and brought to DOMWrapperMap<>. That implies, DOMWrapperMap is a non-copyable type, but detected as copyable type by a defaulted copy constructor. That confuses std::optional and causes a build error on C++17 mode of Chromium. This mark DOMWrapperMap as non-copyable explicitly to fix the build error. Bug: 752720 Change-Id: Iff22df3cd108475ece9ba0c7cc4878a30d3bcb43 Reviewed-on: https://chromium-review.googlesource.com/1214908Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/d7027dc081cb..b33290d08211 git log d7027dc081cb..b33290d08211 --date=short --no-merges --format='%ad %ae %s' 2018-09-10 sakal@webrtc.org Return null from PCFactory#createPeerConnection on failure. 2018-09-07 steveanton@webrtc.org Use C++11 style for loop in webrtcsdp.cc 2018-09-07 danilchap@webrtc.org Cleanup RtpPacketizerVp9 2018-09-07 mbonadei@webrtc.org Fix no_exit_time_destructors in ortc. 2018-09-07 hta@webrtc.org Add "tones remaining" argument to DTMF ontonechange callback 2018-09-07 danilchap@webrtc.org Make RtcpTransceiver destructor non-blocking Created with: gclient setdep -r src/third_party/webrtc@b33290d08211 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I529a29d35257c955f4fe00fce7d48f522dfa1b75 Reviewed-on: https://chromium-review.googlesource.com/1214723Reviewed-by:
-
Bernhard Bauer authored
Read-only properties can be initialized with a Builder. Migrate KeyboardAccessoryModel and AccessorySheetModel to be based on PropertyModel. Change-Id: I22f461f904ccefe1ecdde12d7ead62bacb0acf29 Reviewed-on: https://chromium-review.googlesource.com/1179885 Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Friedrich Horschig [CEST] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#589881}
-
Florent Castelli authored
Intent thread: https://groups.google.com/a/chromium.org/d/msg/blink-dev/tWzutytXsqc/lGaWCFdHAgAJ Bug: 800767 Change-Id: Ibb8339e65abdb4cbb91549ffc4e64e18b36a0efd Reviewed-on: https://chromium-review.googlesource.com/1097413Reviewed-by:
Henrik Boström <hbos@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Florent Castelli <orphis@chromium.org> Cr-Commit-Position: refs/heads/master@{#589880}
-
Marina Ciocea authored
This reverts commit 1055dd5b. Reason for revert: Fixed failing audio browser tests. Original change's description: > Revert "Temporary check global histogram allocator in audio service output controller." > > This reverts commit 9624dedb. > > Reason for revert: breaking webrtc tests: https://ci.chromium.org/buildbot/chromium.webrtc/Linux%20Tester/42679 > > Original change's description: > > Temporary check global histogram allocator in audio service output controller. > > > > Add a temporary check to investigate audio service experiment output controller > > histograms count mismatch. If histogram persistent memory is not setup before > > output controller metrics are reported, the check will fail > > (see https://crbug.com/867827#c40). This CL will be reverted in a couple of days > > after gathering data from canary. > > > > Bug: 867827 > > Change-Id: I1f18c12c2aa2741a27c0bf82f383de70e273fd24 > > Reviewed-on: https://chromium-review.googlesource.com/1205606 > > Reviewed-by: Olga Sharonova <olka@chromium.org> > > Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#589117} > > TBR=olka@chromium.org,marinaciocea@chromium.org > > Change-Id: I238d02410407268ca30f06666d346181158624a3 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 867827 > Reviewed-on: https://chromium-review.googlesource.com/1209542 > Reviewed-by: Marina Ciocea <marinaciocea@chromium.org> > Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> > Cr-Commit-Position: refs/heads/master@{#589132} TBR=olka@chromium.org,marinaciocea@chromium.org Bug: 867827 Change-Id: I08cce13476f851d9ab24434add30f65abbf1e600 Reviewed-on: https://chromium-review.googlesource.com/1215246Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Marina Ciocea <marinaciocea@chromium.org> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#589879}
-
Yuki Yamada authored
This CL moves the methods that is for storing/loading exceptions into blink::ErrorEvent. These methods were in blink::V8ErrorHandler, but they are not related to it directly. Bug: 872138 Change-Id: I9e60a9b58e786309d9410d47849b53233a47bd27 Reviewed-on: https://chromium-review.googlesource.com/1212248Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Yamada <yukiy@google.com> Cr-Commit-Position: refs/heads/master@{#589878}
-
Alexandr Ilin authored
This CL adds an asynchronous proxy lookup request to the PreconnectManager after the synchronous request was removed in https://crrev.com/c/1165550. The idea is that we don't need to wait for a host to be resolved before a preconnect if a proxy is enabled. Since we don't have a synchronous API for proxy lookup anymore, we issue both host and proxy requests in parallel. Then we wait until either one of the requests completes with success or both requests fail. Bug: 838763 Change-Id: Ib3fa47884ba82d1fc12c62f7fd24dd21c279e9c5 Reviewed-on: https://chromium-review.googlesource.com/1202222 Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#589877}
-
Yuki Shiino authored
Change-Id: Ia39fa0a613024591ddc4917100546f0aa9c0eb0b Reviewed-on: https://chromium-review.googlesource.com/1215534Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#589876}
-
Dominic Battre authored
TBR=rdevlin.cronin@chromium.org Bug: 882213 Change-Id: If68c1be2e7ca400a86f18fe984ec8ee3525dceb7 Reviewed-on: https://chromium-review.googlesource.com/1215325Reviewed-by:
-
Erik Språng authored
Bug: chromium:853185, b:111781384 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I7bc0dc619503bbb5d0b1ed5420187f0338e160a4 Reviewed-on: https://chromium-review.googlesource.com/1201859 Commit-Queue: Erik Språng <sprang@chromium.org> Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Reviewed-by:
Pawel Osciak <posciak@chromium.org> Cr-Commit-Position: refs/heads/master@{#589874}
-
Mythri Alle authored
For Incognito mode (and other cases where code caches are disabled) we do not create the GeneratedCodeCacheContext or the GeneratedCodeCache. It is required to verify they are non-null before using them. Bug: chromium:881792, chromium:881881 Change-Id: I9cf47ed45e88c2e4df1f4d0a499149893332c98a Reviewed-on: https://chromium-review.googlesource.com/1215682Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#589873}
-
tzik authored
This CL adds missing #include for "base/macros.h", "base/logging.h", "base/callback.h", and <vector>. They used to be included indirectly through "base/optional.h", but they should be explicit. Tbr: sky@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I17da47493055828db25326b7e6dcc07f828b78ef Reviewed-on: https://chromium-review.googlesource.com/1214904Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#589872}
-
Dominic Battre authored
TBR=verwaest@chromium.org NOTRY=true Bug: 881207 Change-Id: I94bf1aba386877948036d28cefe08629a817531c Reviewed-on: https://chromium-review.googlesource.com/1215287Reviewed-by:
-
Dominic Battre authored
This test crashes with a check on Linux. On Linux CFI it crashes very frequently. FATAL:render_frame_metadata_provider_impl.cc(41)] Check failed: render_frame_metadata_observer_ptr_. TBR=khushalsagar@chromium.org Bug: 880948 Change-Id: Ie2a536e1a72f9fb00f5f1515b1683b87e87d807e Reviewed-on: https://chromium-review.googlesource.com/1215286Reviewed-by:
-
Marc Treib authored
On a configuration failure, PSS is temporarily in an inconsistent state until the error is processed (by calling OnUnrecoverableErrorImpl). If we call an observer during that time, and the observer calls PSS::GetTransportState, then that could trigger a DCHECK. It's arguable whether calling OnSyncConfigurationCompleted on an error even makes sense. It looks like none of the clients can do anything useful in that case anyway. So let's just not call them. If they're interested in the error, then they should listen for OnStateChanged instead. Bug: 880080 Change-Id: If4179cd530f3e625bd53de466c059e051b36f42d Reviewed-on: https://chromium-review.googlesource.com/1210083Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#589869}
-
Daniel Bratell authored
There are more than one namespace named features, and specifically there are both ::printing::features and ::features. When the compiler knows about both and is inside namespace printing, referring to "features" will resolve to ::printing::features even if ::features was intended. This happens in jumbo builds in some configurations. The fix is to clarify what features namespace is intended by using a :: prefix. An alternative fix would be to remove ::printing::features to ::printing::printing_features. Change-Id: I0499ed98c3ad699e89dce8f1141c327937ba0a87 Reviewed-on: https://chromium-review.googlesource.com/1213167Reviewed-by:
-
Yutaka Hirano authored
It is flaky. Bug: 869758 Change-Id: Ic9c29ced0103a11ae284b10d49466fa317c605b2 Tbr: kenrb@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1215508 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#589867}
-
Yannic Bonenberger authored
Bug: 755477 Change-Id: I59ca20a9d958a2bcad929b9a83b1ab9053ee8d42 Reviewed-on: https://chromium-review.googlesource.com/1212062Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Yannic Bonenberger <contact@yannic-bonenberger.com> Cr-Commit-Position: refs/heads/master@{#589866}
-
Mohamed Amir Yosef authored
The directory implementation is different because directory keeps a copy of the server data and then compares it to the newly version. For USS, no copy is maintained and hence we have to create specifics and push to the server when there is a local update. Bug: 516866 Change-Id: Ic0a43b210866120c8ec209681e719d634fa10255 Reviewed-on: https://chromium-review.googlesource.com/1206410Reviewed-by:
-
Dominic Battre authored
It may make sense to increase the number of shards instead but I am not sufficiently knowledgable of capacity planning to do this change. The reason for increasing the timeout is that this bot times out consistently. TBR=rcui@chromium.org,sky@chromium.org Bug: 874090 BUG: 847585 Change-Id: I14f9d2eccbead7ef403e346deda5442a82d5ea27 Reviewed-on: https://chromium-review.googlesource.com/1215283Reviewed-by:
-
Daniel Bratell authored
Some test code was compiled into chrome which in jumbo builds broke the linking. In non-jumbo builds the code was probably eliminated by the implicit dead-code-removal in the linker (an .o file that is completely unused is ignored). Also changing an #include "foo.cpp" to #include "foo.h" since that caused similar linking errors related to duplicate code. Change-Id: I6c39314fadc3a82f48135755cc7de1a540006ae5 Reviewed-on: https://chromium-review.googlesource.com/1213166Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#589863}
-
