GitLab

src//c/b/wc/web_contents_view_aura.cc has its own function
to map ui::EventFlags to blink::WebInputEvent::Modifiers. It duplicates
the existing ui/events/blink/blink_event_util.h|cc.

Driven by CL that removes this duplication.

BUG=none

Change-Id: I8f5ed74bbfa93fab5cd9192cbaf720977eb731ba
Reviewed-on: https://chromium-review.googlesource.com/904402Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#534740}

TBR=mbarbella@chromium.org

Bug: 769578
Change-Id: I2be935a18118c8e1880f3881d1f62e8978bf532b
Reviewed-on: https://chromium-review.googlesource.com/905090Reviewed-by: Jonathan Metzman <metzman@chromium.org>
Reviewed-by: Martin Barbella <mbarbella@chromium.org>
Commit-Queue: Jonathan Metzman <metzman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534739}

When user downloads a file in Chrome and remove the file in other
application, we check if the file is externally removed and call
Android API DownloadManager.remove(id) to avoid a crash on Android.

However, if the user rename the file, currently Chrome still deletes it
via the id provided by Android DownloadManager.

In this CL, we only let Android remove the file if it's deleted in
Chrome.


Bug: 774870
Change-Id: I5448a155c1e05e44ec3a812e93d3035d7061ecf7
Reviewed-on: https://chromium-review.googlesource.com/899770Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534738}

When using the AudioParam value setter, the setter must behave as if
setValueAtTime were called with the given value at the current audio
context time.  This includes throwing an error if the time is in the
middle of a setValueCurveAtTime automation.

This is a change in the old behavior where errors weren't thrown.
This also clarifies the behavior of the value setter when automations
are running.  Previously, the interaction between the setter and
automations were not very well specified.

Bug: 764396
Test: AudioParam/audioparam-value-setter-error.html
Change-Id: Ic1da32c27f9e4f29e2df3bcbb6dd0bd485409e0e
Reviewed-on: https://chromium-review.googlesource.com/665318
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534737}

It is not necessary to hold a lock while looking for a sample in
the samples_ std::unordered_map container unless container is modified.

BUG=803276

Change-Id: I1305e848f01860f89d6c631b7af44ffa3a900f0b
Reviewed-on: https://chromium-review.googlesource.com/891651
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Primiano Tucci <primiano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534736}

fast/events/scale-and-scroll-iframe-window.html was fixed in r533170 but
the TestExpectation line wasn't removed to avoid interfering with
landing r533694. Dashboard says it's been passing reliably.

Bug: 781431
Change-Id: I92ff5c63246fd68556598a42b09e86477e983cdd
Reviewed-on: https://chromium-review.googlesource.com/899644
Commit-Queue: David Bokan <bokan@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534735}

Small code cleanup to make it easier to land other changes related to this
bug.

|return_promise| was being passed around through different functions but not
used anywhere since fbfdd53f ("IDL: Drop value conversion (V8 -> C++)
macros from generated code").

|method| has not been used since 652e2642 ("binding: Retires
ExceptionState::throwIfNeeded()").

Bug: 808995
Change-Id: I19567d796d5c706fd03acc960caca9a25b07d050
Reviewed-on: https://chromium-review.googlesource.com/904602Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Cr-Commit-Position: refs/heads/master@{#534734}

The histograms downsides (memory, binary size, server resources) probably
outweigh their value.

Bug: 809334
Change-Id: I8965007e67275d615abd3dba3a1505d99024a44f
Reviewed-on: https://chromium-review.googlesource.com/904263Reviewed-by: Yoav Weiss <yoav@yoav.ws>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534733}

TBR=bsep@chromium.org

Bug: none
Change-Id: I476b92e6ffe329632b6d9551b28bfea0ba1fb067
Reviewed-on: https://chromium-review.googlesource.com/902729Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534732}

Previous code both would perform very badly --- as it's scanning over 4K
increments, which is iffy if there is a big hole in the middle --- and
could also suffer from wrap around in index computations (an alternative
may be to fix just that...)

This change replace hash table keeping track of ranges with the ordered
std::map, which makes finding adjacent kids easy.

Bug: 808561
Change-Id: I3442bbbf6c0e4bc6089ba89265ebb27d739d7edc
Reviewed-on: https://chromium-review.googlesource.com/901862
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534731}

Bug: 745778
Change-Id: I3b7a5bf5928a412d64cd10eaff729de9dc5a1151
Reviewed-on: https://chromium-review.googlesource.com/903054Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534730}

Create an NDS for a generic/"system" profile on demand and
asynchronously to service notification requests that aren't tied to
a particular user. Apply this to WebUsbDetector, and also update
some Chrome OS specific notifications which had been doing pretty
much the same thing, but had assumed/forced synchronicity.

Bug: 783018, 793877
Change-Id: I95f4434bd6557bf846f5ed89052d4cff7f6bcf21
Reviewed-on: https://chromium-review.googlesource.com/891488
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Jun Cai <juncai@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534729}

Exporting an empty password list has no value for the user. Additionally,
exporting while the password list is still loading is undefined behaviour.

For these reasons, we only show the Export Passwords menu item only once
the password list has been read and is non-empty.

Bug: 789561,805534,807975
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ief82b4b46a231402dbaa7251e514c4078f7be31a
Reviewed-on: https://chromium-review.googlesource.com/897486
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534728}

https://webrtc.googlesource.com/src.git/+log/7092368982d3..5c8622fa2570

$ git log 709236898..5c8622fa2 --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc
BUG=None,None


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I72f6556dd4667fa2d7d0c873a72a62bfa350d36c
Reviewed-on: https://chromium-review.googlesource.com/904849
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#534727}

This adds a GpuBacking object to PoolResource, which holds ownership
of all the GpuMemoryBuffer-based backing objects. The
ZeroCopyRasterBufferImpl has a subclass with its own specific types
in it, and populates them:
a) When AcquireBufferForRaster is called it creates the GpuBacking
and ensures the sync token is waited on if present.
b) When the RasterBuffer is destroyed, back on the compositor thread,
it binds the GpuMemoryBuffer to a mailbox, and stores those onto the
GpuBacking.

Then ResourcePool can export the GpuBacking by reading the mailbox
of it. And when the resource is destroyed, the GpuBacking cleans
up the ownership of the mailboxed texture and GpuMemoryBuffer.

R=vmpstr@chromium.org

Bug: 730660, 738190
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: Iac964108e2ab767239e9968e03f82bc80d6a6e3b
Reviewed-on: https://chromium-review.googlesource.com/888844
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534726}

This reverts commit 31c3e864.

Reason for revert: looks like there are bugs in the serialization code. Reverting while I investigate.

Original change's description:
> [vr] Add not-web-exposed media feature for immersive mode.
> 
> With this change, I've added a media feature that returns true when
> in immersive mode (eg, in VR). I've added extra plumbing to ensure that
> this new feature is not web exposed.
> 
> More info on media features here:
> https://www.w3.org/TR/css3-mediaqueries/#media1
> 
> The plumbing for this particular feature is very close to the plumbing
> for -webkit-transform-3d.
> 
> I've also changed the "page popups suppressed" setting (which was only
> ever true in immersive mode) to be named immersive, accordingly.
> However, the uses of the immersive mode setting for suppressing page
> popups are meant to be temporary, so I've added comments referencing
> the bug that explains the removals.
> 
> Bug: 809021
> Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> Change-Id: Ib46237b7c7f518830d0134c51baefeb3a1d89c11
> Reviewed-on: https://chromium-review.googlesource.com/901484
> Reviewed-by: Rick Byers <rbyers@chromium.org>
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Reviewed-by: Ken Buchanan <kenrb@chromium.org>
> Commit-Queue: Ian Vollick <vollick@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#534497}

TBR=avi@chromium.org,rbyers@chromium.org,vollick@chromium.org,kenrb@chromium.org

Change-Id: Ieab8e1124aa92e98aeceb68504a16695024b08f8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 809021
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/905062Reviewed-by: Ian Vollick <vollick@chromium.org>
Commit-Queue: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534725}

This patch adds a new flag for Chrome Duplex since there is too much
overhead in reusing the original Chrome Home flag. isChromeHomeEnabled
now always returns false. Tests that depend on the bottom sheet have
been removed with the exception of those related to suggestions,
observers, and swipe logic (which are temporarily disabled).

BUG=805070

Change-Id: I1ec39da11e1e7e0f14cbbe9e77a24f3cd16edd10
Reviewed-on: https://chromium-review.googlesource.com/876529
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534724}

This CL fixes an issue where new navigations are wrongly considered a reload.
Prior to this CL, a browser-initiated navigation would be converted to a reload
if it matches the URL of the last attempted navigation. However, we should only
compare to the URL of the last committed navigation, otherwise we will not
create a new NavigationEntry when the navigation commits but will instead
modify the last committed NavigationEntry. This is an issue since we did the
comparison with the last pending NavigationEntry, not the last committed one,
so it is quite likely that their URLs don't match.

BUG=809040

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I86a3c2f9b933bc6eadd89a3e694e01b985ac4e91
Reviewed-on: https://chromium-review.googlesource.com/824663
Commit-Queue: Camille Lamy <clamy@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534723}

UIStackView automatically positions views in a vertical column, which allows us
to remove a number of positioning constraints.  This also makes it possible to
change individual pieces of the incognito ui without needing to modify any
constraints.

BUG=805521

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ib746a91202946235e6de3c20f88947d8e85ee49b
Reviewed-on: https://chromium-review.googlesource.com/900182
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534722}

Various changes:
- Start adding DEPS exceptions in preparation for banning
ui/message_center dependencies more broadly.
- Remove a file full of constants in ui/message_center
- delete some unnecessary message_center.h includes
- remove some message center color constants in favor of direct
  use of Label::SetAutoColorReadabilityEnabled.

BUG=783018,723882
TBR=rogerta@chromium.org

Change-Id: Ia7b9332d575a77581691f65f98c945754820c212
Reviewed-on: https://chromium-review.googlesource.com/879501Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534721}

https://chromium.googlesource.com/catapult.git/+log/a1303e46889b..4c7a9a8e39f1

$ git log a1303e468..4c7a9a8e3 --date=short --no-merges --format='%ad %ae %s'
2018-02-05 estevenson [Dashboard] Add M64-M65 milestones to speed releasing dashboard.

Created with:
  roll-dep src/third_party/catapult


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I1d55b4af1eeaa37a6b5931d07407ee44e3ffe876
Reviewed-on: https://chromium-review.googlesource.com/904805
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#534720}

Move parsing of the 'Certificates' section of ONC to the new class
OncParsedCertificates. CertificateImporter uses this as its input.
This is a preparation for not importing policy-provided server and
authority certificates into the NSS database anymore, but only making
them available as temporary NSS certificates.

      chromeos_unittests --gtest_filter=*CertificateImporter* &&
      chromeos_unittests --gtest_filter=OncParsedCertificatesTest*

Bug: 787602
Test: unit_tests --gtest_filter=*NetworkConfigurationUpdater* &&
Change-Id: Id42f512c9b2287eb582ef3f6ade6b31f32eaf024
Reviewed-on: https://chromium-review.googlesource.com/898963Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Pavol Marko <pmarko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534719}

BUG=739622
TEST=Ran on bots.

Change-Id: I6e968439859b4409a14621a03bd3a20f8ebe36f2
Reviewed-on: https://chromium-review.googlesource.com/901682
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534718}

Import wpt/css/css-pseudo. 3 tests were added to NeverFixTests as
::marker has not been implemented. first-letter-001.html passes only on
Mac and first-letter-002/003.html only fail on Linux.

Bug: 808834, 808837
No-Export: true
Change-Id: I3a248cb0d927de755313b05fb885b0348885886d
Reviewed-on: https://chromium-review.googlesource.com/900686Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Chris Nardi <cnardi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534717}

R=peter@chromium.org

Change-Id: I7f66591e63807506f50614c7d19d0dbaf77d681d
Reviewed-on: https://chromium-review.googlesource.com/904702
Commit-Queue: Anita Woodruff <awdf@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534716}

The discussion in 784493 shows that performing ink skipping for the
SOLIDUS or slash character results in URLs looking jagged / appearing as
multiple URLs. This depends on the font and device pixel ratio. In some
fonts, the slash extends below the baseline, in some it does
not. Depending on device pixel ratio the underline is rendered one or
two device pixels below the baseline. Similarly, ink-skipping for
underscores breaks up in the text in an unexpected way.

As a compromise, exempt SOLIDUS, REVERSE SOLIDUS, LOW LINE from ink
skipping, as we already do for CJK characters.

Bug: 784493
Change-Id: I1d26cf1229b7f16e4a161b34758302a7e33230eb
Reviewed-on: https://chromium-review.googlesource.com/897663
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534715}

Allow the rate limiter to start with and accrue up to 10 access
allowances. This allows an extension to read multiple times from
the API in a short burst, while still being throttled if it goes
on for too long.

BUG=808598

Change-Id: I03746f2ee3ade64c87e2b2184467a8e66206a6b8
Reviewed-on: https://chromium-review.googlesource.com/900183
Commit-Queue: Simon Que <sque@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534714}

Also cleans up Amp Redirection from the internals page Interventions tab.

Bug: 803221
Change-Id: I130dd7430236e87406696ff685d0a341dd87e641
Reviewed-on: https://chromium-review.googlesource.com/902383Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Doug Arnett <dougarnett@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534713}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/ebe77c45..a24f6910

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: If26d46438cc2c27725be561dad8997261541e316
Reviewed-on: https://chromium-review.googlesource.com/903822Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534712}

BUG=739622
TEST=Ran chromeos_unittests.

Change-Id: Ic79e5491ccf36e2cb83642545dd5b29763c0eedc
Reviewed-on: https://chromium-review.googlesource.com/903607Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534711}

Increase font and change icon and paddings. Also change dimmed overview windows
opacity.

Test: manual
Bug: 782320
Change-Id: I1cbb78e06389a7f7335bf9cff86fde0b7b7eacc8
Reviewed-on: https://chromium-review.googlesource.com/892087
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534710}

SpeechRecognizerState is an enum in the Windows platform
API for speech so using that name for a Chrome internal
type means that you get compilation errors if the platform
headers and the internal headers end up in the same
translation unit.

In jumbo builds that could happen (and in general it can also
happen) so this renames
SpeechRecognizerState -> SpeechRecognizerStatus
to avoid that.

An alternative would be to move the enum to a different, more
limited, scope.

Bug: 746957
Change-Id: I479470340ea2c582480b2692424a15bc6fb4581a
Reviewed-on: https://chromium-review.googlesource.com/901247Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#534709}

Having multiple directories for screenshots complicates adding
the UI capture tests to the bots, and is no longer needed to
identify the screenshots or to make the file names unique. Put
all the screenshots in a single directory.

Bug: None
Change-Id: Ie25b9a1f9bacd5ada27e57fdbd742b1a9d893fa6
Reviewed-on: https://chromium-review.googlesource.com/902102
Commit-Queue: Anthony Berent <aberent@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534708}

These strings were missed as they were not in generated_resources.grd.

Bug: chromium:807886
Change-Id: I3c0c812f751487fffa6dc167cff21e0af269bf73
Reviewed-on: https://chromium-review.googlesource.com/902187
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534707}

All of this happens when S13nServiceWorker is enabled.

The removed DCHECK was here to enforce that the ControllerServiceWorker
is not updated after container host connection has been closed.

A race condition can happen and triggers this DCHECK. After
CommitNavigation(), if the browser process is slow enough, a javascript
call can delete the iframe before the OnProviderCreated/SetController
round trip between the browser and the renderer has been made.

Deleting the iframe cause OnContainerHostConnectionClose() to be called. It
happens before receiving the SetController call.

┌───────┐           ┌────────┐
│Browser│           │Renderer│
└───┬───┘           └───┬────┘
    │CommitNavigation() │
    │──────────────────>│ (ResetController())
    │                   │
    │OnProviderCreated()│
    │<──────────────────│
    │─┐                 │─┐
    │ │                 │ │ Remove the iframe.
    │ │                 │ │ (OnContainerHostConnectionClose())
    │ │ Sleep...        │<┘
    │ │                 │
    │<┘                 │
    │                   │
    │  SetController()  │
    │──────────────────>│ (ResetController())
┌───┴───┐           ┌───┴────┐
│Browser│           │Renderer│
└───────┘           └────────┘

Note: The CL...
https://chromium-review.googlesource.com/897629
...shows adding a delay in the browser process causes several service
worker tests to fail.

Note: Doing SetController() on response to OnProviderCreated() is no really
necessary since thttps://goo.gl/UztxVi was implemented by
https://chromium-review.googlesource.com/742961.
This was kept to update UseCounter.

Bug: 808071
Change-Id: I46c4fd8e4db7eb4ed5e304bb1989d36d552567ad
Reviewed-on: https://chromium-review.googlesource.com/899143
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534706}

To limit mischief, replace the target of JavaScript-scheme links in
HTMLViewSourceDocument with about:blank.

Bug: 705206, 808407
Change-Id: I185006d0cb29caabcd08dd9d5b9324357c79efaa
Reviewed-on: https://chromium-review.googlesource.com/900099Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Eric Lawrence <elawrence@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534705}

Intuit the button type from the presence or absence of the placeholder
text.

Bug: 797128
Change-Id: I6fe658f644e42b0556ffcaac9bc7322f44f88fea
Reviewed-on: https://chromium-review.googlesource.com/900184Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534704}

This CL implements the skeleton of the Docked Magnifier code, including
watching and updating user prefs, and the mojo APIs for communication
between ash and Chrome so that Chrome can notify ash of focus change
events in webpages.

BUG=709824
TEST=ash_unittests --gtest_filter=DockedMagnifierTest.*

Change-Id: I4a03103a36f4b99c2eeba86feabf304962800098
Reviewed-on: https://chromium-review.googlesource.com/898030Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534703}

Reason for original revert: Causes the following browser_tests to
segfault on Chromium OS ASAN/LSAN builders:

    WebviewLoginTest.AllowNewUser
    WebviewLoginTest.EmailPrefill
    WizardControllerCellularFirstTest.CellularFirstFlow
    WizardControllerFlowTest.ControlFlowMain

- https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20(1)/25959

Bug: 784495
Change-Id: If19459259e6927e8e05127ebfb77472d1b1d7ddd
Reviewed-on: https://chromium-review.googlesource.com/898385Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Jacob Dufault <jdufault@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534702}

Setting app launcher icon is multi-step process. At first step we set
default (or pre-loaded icon) and then try to fetch, decode and load
actual icon. For some app fetch/decode step may be skipped. At this case
icon is left what was set at first step. With recent refactoring, app
launcher icon and chrome app icon were split and synced via updater.
App launcher item is created after Chrome app item. Some attributes from
Chrome app are passed via metadata but not the icon.
This CL sets the icon from Chrome app item to app laucnher item at the
moment of creation app launcher item.

Bug: 809269
Test: Manually
Change-Id: Iee8f5701d41f2ea19533d7df3edcc3898d606044
Reviewed-on: https://chromium-review.googlesource.com/902610Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Yury Khmel <khmel@google.com>
Cr-Commit-Position: refs/heads/master@{#534701}