- 24 Oct, 2020 19 commits
-
-
Yuta Hijikata authored
The change is mostly mechanical replacing defined(OS_CHROMEOS) with BUILDFLAG(IS_ASH) and GN variable is_chromeos with is_ash. Only the insertion of "//build:chromeos_buildflags" into appropriate deps in BUILD.gn is done semi-manualy. The change should not change the behaviour of any build. This is in preparation to switching lacros build from target_os=linux to target_os=chromeos so that lacros does not include any additional code due the switch. Please note that any new defined(OS_CHROMEOS) and is_chromeos introduced to should be consistent with the new meaning. Please refer to this short document http://go/lacros-replace-chromeos-macro-with-ash for full context. Bug: 1052397 Change-Id: Idc47df64e7f13e6b56d01628e21bd1a907ec7174 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494443Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Cr-Commit-Position: refs/heads/master@{#820513}
-
Liquan (Max) Gu authored
Context: Currently, some payment UI's colors, dimens, styles live in //chrome/android/java/res/values, and they are depended by //components. In order for //weblayer to depend on //components, these resources need to be moved into //components. Change: * Moved the payment's (and some autofill's - as they are used by payment UIs) colors, dimens, styles from //chrome to //components * Replaced color #B2B2B2 with @color/black_alpha_30 in the color files because they are equivalent according to go/clankcolors. Bug: 1141076 Change-Id: I2b40ed364e70f2e5cb243ad158b7af647c855de1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490269Reviewed-by:
Sahel Sharify <sahel@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#820512}
-
Khushal authored
A platform bug can result in transaction acks getting dropped which stalls all rendering. A fix for this will be released in an R update soon so this changes disables using this API in Q. This also reverts an earlier workaround which was added for samsung dex mode since its not necessary after this change. TBR=skyostil@chromium.org Bug: 1131081 Change-Id: I8d053f160fd8ad5bf6ce47d5e6e295c322bace69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491401 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#820511}
-
Lei Zhang authored
Convert remaining callers. Bug: 646113 Change-Id: I66cf237f210ffb70bb03adfcb13c6de604f28525 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482247Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#820510}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f28949d69964..6f9b1bfd4849 2020-10-23 jessemckenna@google.com setup_color: Disable colorama on pre-Windows-10 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1114548 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Id1d16eb7187d62364e6f03c2c81621ad4bc436ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2496140Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820509}
-
John Lee authored
Bug: 1141573 Change-Id: I2ac4c7156e7b7e997bcadb0e187a53d8adfd3a4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2496024Reviewed-by:
Collin Baker <collinbaker@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#820508}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3691164b7e2c..0b7cead9f979 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC sky@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1134167 Tbr: sky@google.com Change-Id: Ic8d20b510c8b4565668c787157ba4fe2f5e42909 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495547Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820507}
-
David Grogan authored
Some hand calculations in the reference didn't age well. I replaced the -ref.html with checkLayout. The test failed in Firefox in an identical fashion. New test passes in both browsers. Just a test, no behavior change. Fixed: 1111708 Change-Id: I7fc82e5d990c57db6c0d205e30aacaed88990418 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490251 Commit-Queue: David Grogan <dgrogan@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#820506}
-
Phillis Tang authored
Pass OsIntegrationManager to AppRegistrar, AppRegistryController and InstallFinalizer during |SetSubsystems| to avoid accessing it from WebAppProvider. Also update TestWebAppRegistryController to create a TestOsIntegrationManager during |SetUp|. Bug: None Change-Id: Icb8a73aed0fcd4cf127eabd4af4251cbf462864d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495821 Commit-Queue: Phillis Tang <phillis@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#820505}
-
Weiliang Chen authored
Adding more data structures into the class that is shared between output surface and overlay processor. Following this CL, each viz::Display would have a DisplayCompositorMemoryAndTaskController, which is on the viz compositor thread. It will own a DisplayCompositorMemoryAndTaskControllerOnGpu, which is on the gpu thread. In this CL, we would have singular place for memory tracking and command buffer id. This is CL 2/? of sharing gpu data structure between output surface and overlay processor. R=rjkroege Bug: 1093440 Change-Id: I3f22a4fd56b082dd24115dd6e3e973bb188bed4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373395 Commit-Queue: weiliangc <weiliangc@chromium.org> Reviewed-by:
weiliangc <weiliangc@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#820504}
-
Muyao Xu authored
This CL adds logs every time |has_local_display_route_|'s value changes. When its value is true, the cast toolbar icon should be blue, unless there are FATL or WARNING issues. Bug: b/165366974, 1117673 Change-Id: I082fadb913cdad4527020f2f10f06051d610deee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2472531 Commit-Queue: Muyao Xu <muyaoxu@google.com> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#820503}
-
wutao authored
Bug: b/170903277 Test: New test Change-Id: I76e8ad06a2307c1bb1bae1441b75f20efee189f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487884 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#820502}
-
Piotr Bialecki authored
Yet another CL to unblock WebXR in WebView / WebLayer work. Changes: - ArCoreJavaUtils, ArImmersiveOverlay & ArDelegatenow no longer need to live in //chrome - moved them to //components/webxr - native ArCoreJavaUtils are also moved to //components/webxr - ArDelegate needs to be consumable by ChromeActivity - added required DEPS entries and created a target that is present independently of enable_arcore build flag - adjusted the location of linter suppression entries - converted them from entries in lint-baseline.xml into @SuppressLint attributes Bug: 843374 Change-Id: I8fa8a7594f69fd4bb6cb65326ef626300b5ab55d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490235Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#820501}
-
Anders Hartvoll Ruud authored
Bug: 568705 Change-Id: I60d908398869162c664760da5d638d7bac2dae2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489891Reviewed-by:
Emilio Cobos Álvarez <emilio@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#820500}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I01fd3e306d81c281f847496fb8795f38ce58b32b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495693Reviewed-by:
-
Roman Arora authored
Leverage content-visibility property to optimize render time. https://web.dev/content-visibility/ Screenshots from Dev Tools: Performance: original: https://drive.google.com/file/d/1bb_KeUWn1C0TDmUuhZO2zE0qcqqDlq3O/view?usp=sharing optimized: https://drive.google.com/file/d/1yHm19aq3ri7YnI9xUpPbfmVQCycuESXF/view?usp=sharing 6x-slow screenshots: original: https://drive.google.com/file/d/13ymyxUmpPWHNh0z-I_s_wUN2osGFwJW_/view?usp=sharing optimized: https://drive.google.com/file/d/1y7MPjiU9px2S0BlfRlCizKG9b9kj9tHi/view?usp=sharing Bug: 1099917 Change-Id: I2206817422cbaeb4a59ed1707a2e39dd354cc7ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493092Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: Roman Arora <romanarora@chromium.org> Cr-Commit-Position: refs/heads/master@{#820498}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/42a741a2145c..58a26a83628c 2020-10-23 csmartdalton@google.com Fix the formula for fNumRadialSegmentsPerRadian in GrStrokePatchBuilder 2020-10-23 johnstiles@google.com Add unit test for nested function calls in FP files. 2020-10-23 reed@google.com Show cubic made up of 2 quads 2020-10-23 johnstiles@google.com Revive SkSLFPTestbed for basic verification of CPP/H codegen. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC egdaniel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: egdaniel@google.com Change-Id: Id7e6b89b0915cb939688a4b63c53bddd6c3a7bec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495692Reviewed-by:
-
Darin Fisher authored
Bug: 1141261 Change-Id: I9f877ac89f9435193f04c87a6a3f3d51593f202d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495516Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Darin Fisher <darin@chromium.org> Cr-Commit-Position: refs/heads/master@{#820496}
-
Thomas Lukaszewicz authored
This CL adds a CloseTabSearch browser command. The primary use case for this will be enabling better control of the feature for use with the Devtools protocol. See below for context: https://crrev.com/c/2488764 Bug: 1099917 Change-Id: I7744187da08a51dfb9ff1fe31f4c17a4891e6122 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495863Reviewed-by:
Yuheng Huang <yuhengh@chromium.org> Reviewed-by:
-
- 23 Oct, 2020 21 commits
-
-
Jesse Schettler authored
Add a new Polymer element, page-size-select, to display the page sizes in a dropdown. Bug: 1059779 Change-Id: Ia546795ab44e350adbf8256867e7e5fccb42dc02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492944Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#820494}
-
David Van Cleve authored
Android unit tests don't work on Android R+, but this isn't mentioned in the docs, and the error message is pretty arcane and hard to understand. This change updates the docs to mention this problem. Bug: 1094062 Change-Id: I77b196febde1009eb13b195be937243e96ace1a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495968 Commit-Queue: David Van Cleve <davidvc@chromium.org> Auto-Submit: David Van Cleve <davidvc@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#820493}
-
Scott Violet authored
This reverts commit 715577e4. Reason for revert: This caused compile failure: https://ci.chromium.org/p/chromium/builders/ci/fuchsia-arm64-cast/97365? [8734/14809] CXX obj/content/test/content_unittests__exec/indexed_db_backing_store_unittest.o FAILED: obj/content/test/content_unittests__exec/indexed_db_backing_store_unittest.o /b/s/w/ir/cache/goma/client/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF...(too long) ../../content/browser/indexed_db/indexed_db_backing_store_unittest.cc:924:20: error: no member named 'SetExecuteJournalCleaningOnNoTransactionsForTesting' in 'content::indexed_db_backing_store_unittest::TestableIndexedDBBackingStore' backing_store()->SetExecuteJournalCleaningOnNoTransactionsForTesting(); ~~~~~~~~~~~~~~~ ^ 1 error generated. Original change's description: > indexeddb: defer journal cleanup in CommitPhaseTwo > > Currently, IndexedDBBackingStore::Transaction::CommitPhaseTwo > calls IndexedDBBackingStore::DidCommitTransaction which cleans up blobs > in the recovery journal (under some conditions). Unfortunately, it > doesn't remove the blobs that were just written in that transaction from > the recovery journal prior to calling DidCommitTransaction. > > This patch rearranges the calls so that DidCommitTransaction is always > called in CommitPhaseTwo, but only after the journal has been updated. > > Bug: 1131151 > Change-Id: I703d250f42b3de77a41b7ebc151ae71db5dbda6c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495872 > Commit-Queue: enne <enne@chromium.org> > Auto-Submit: enne <enne@chromium.org> > Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#820486} TBR=mek@chromium.org,enne@chromium.org Change-Id: Id3876068e31e91817ff7c396f024cf159b3c1dfe No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1131151 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2496035Reviewed-by:
-
Tomasz Wiszkowski authored
This change splits the ZeroSuggestProvider into - ZeroSuggestProvider serving the Search suggestions and - ZeroSuggestMostVisitedSitesProvider, serving the MostVisited suggestions. The Most Visited Sites are served specifically on mobile devices and are therefore wired specifically for iOS and Android. This change enables MostVisited suggestions to be served alongside the zero-prefix REMOTE_SEND_URL suggestions. Bug: 1106109 Change-Id: I1053f5dfcd539e056d8443e31294c00bb0145588 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488982 Commit-Queue: Tomasz Wiszkowski <ender@google.com> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#820491}
-
Michael Irani authored
If you navigate to "Apps" page and then to an application, and then hit the back button the focus does not highlight the application that was chosen when in ChromeVox mode. Steps (in ChromeVox mode): 1. Apps 2. Chrome 3. Back button Bug: 1029954 Test: Manual Change-Id: I8c54f7fb88379392ebfc373f209b9386a84a345e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493826 Commit-Queue: Michael Irani <michaelirani@chromium.org> Auto-Submit: Michael Irani <michaelirani@chromium.org> Reviewed-by:
-
Scott Violet authored
This reverts commit 27e795c1. Reason for revert: Sorry for another revert, but this is still causing flake. See https://ci.chromium.org/p/chrome/builders/ci/linux-chromeos-chrome/9353 . Specifically: ../../content/public/test/browser_test_base.cc:702: Failure Failed RunLoop::Run() timed out. Stack trace: #0 0x56324b6c5e50 base::internal::Invoker<>::Run() #1 0x56324b623b4f base::(anonymous namespace)::OnRunLoopTimeout() #2 0x56324b6249e3 base::internal::Invoker<>::RunOnce() #3 0x5632492266ab base::internal::CancelableCallbackImpl<>::ForwardOnce<>() #4 0x56324b63bc46 base::TaskAnnotator::RunTask() #5 0x56324b64c845 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl() #6 0x56324b64c588 base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() #7 0x56324b69fb29 base::MessagePumpLibevent::Run() #8 0x56324b64cf9a base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::Run() #9 0x56324b62363e base::RunLoop::Run() #10 0x5632483f1f23 chromeos::EduCoexistenceLoginBrowserTest::WaitForScreenExit() #11 0x563248402206 chromeos::ParentalHandoffScreenBrowserTest_RegularUserLogin_Test::RunTestOnMainThread() #12 0x56324bae8dd1 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #13 0x56324b6fff04 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #14 0x56324b6ff3b9 ChromeBrowserMainParts::PreMainMessageLoopRun() #15 0x563248bf574e chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() #16 0x563249bdf3b0 content::BrowserMainLoop::PreMainMessageLoopRun() #17 0x563249f3668a content::StartupTaskRunner::RunAllTasksNow() #18 0x563249bde45b content::BrowserMainLoop::CreateStartupTasks() #19 0x563249be0bba content::BrowserMainRunnerImpl::Initialize() #20 0x563249bdcbd2 content::BrowserMain() #21 0x56324b198740 content::RunBrowserProcessMain() #22 0x56324b1995d1 content::ContentMainRunnerImpl::RunServiceManager() #23 0x56324b199234 content::ContentMainRunnerImpl::Run() #24 0x56324a5c8687 content::RunContentProcess() #25 0x56324a5c8c16 content::ContentMain() #26 0x56324bae8a00 content::BrowserTestBase::SetUp() #27 0x56324b5d8620 InProcessBrowserTest::SetUp() Original change's description: > Reland "Adds parental handoff login screen in oobe." > > This is a reland of dca1afe8 > > This is an interesting failure point due to the difference between > official builds and non official builds. In official builds, the > Sync Consent screen is shown and it will not exit until we interact > with it. The waiters timeout waiting for the Parental Handoff Screen > to be shown. > > Original change's description: > > > Adds parental handoff login screen in oobe. > > > > The description and mock can be seen in the comments in the bug report. > > > > Bug: 1134567 > > Change-Id: I2ecd7c72629dc96dfbc054f747c6cb2508210709 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466618 > > Commit-Queue: Yilkal Abe <yilkal@chromium.org> > > Reviewed-by: Aga Wronska <agawronska@chromium.org> > > Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org> > > Reviewed-by: Jesse Doherty <jwd@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#819158} > > Bug: 1134567 > Change-Id: Id4d8c15363579799da14a3f3ed0a285e61dde5d6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489756 > Commit-Queue: Yilkal Abe <yilkal@chromium.org> > Reviewed-by: Aga Wronska <agawronska@chromium.org> > Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org> > Reviewed-by: Jesse Doherty <jwd@chromium.org> > Cr-Commit-Position: refs/heads/master@{#820388} TBR=jwd@chromium.org,rsorokin@chromium.org,agawronska@chromium.org,yilkal@chromium.org Change-Id: I6febf7f06a0d5d7a072be1e50aaa9cc2a4d3c217 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1134567 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495423Reviewed-by:
-
Sharon Yang authored
A WebContentsObserver may receive updates from multiple AXTrees. Currently, that isn't supported, so add a fix that ignores updates that aren't from the first tree that the WebContentsObserver receives. Test: AccessibilityBridgeTest.MultipleAXTrees Bug: 1136541 Change-Id: If1fb3de647c150c58bc07b55477452f91abfcef7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469470 Commit-Queue: Sharon Yang <yangsharon@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#820488}
-
Zentaro Kavanagh authored
- Does not run tests yet Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: Idbe2de1c4f4f3100b36a49947a3e6ded79ba2eec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2469448 Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#820487}
-
Adrienne Walker authored
Currently, IndexedDBBackingStore::Transaction::CommitPhaseTwo calls IndexedDBBackingStore::DidCommitTransaction which cleans up blobs in the recovery journal (under some conditions). Unfortunately, it doesn't remove the blobs that were just written in that transaction from the recovery journal prior to calling DidCommitTransaction. This patch rearranges the calls so that DidCommitTransaction is always called in CommitPhaseTwo, but only after the journal has been updated. Bug: 1131151 Change-Id: I703d250f42b3de77a41b7ebc151ae71db5dbda6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495872 Commit-Queue: enne <enne@chromium.org> Auto-Submit: enne <enne@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#820486}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/751a6ed6316a..f28949d69964 2020-10-23 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Ib97faabc4a435b01c0266c08842b60905b3c8581 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495904Reviewed-by:
-
Collin Baker authored
Bug: 1133016 Change-Id: I4c33d871f13d888392c293a9d4197378d2b82698 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473537 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#820484}
-
Darin Fisher authored
This CL changes NativeDesktopMediaList to no longer assume that CaptureFrame completes synchronously. This means changing the code to wait for OnCaptureResult before calling CaptureFrame again. DCHECKs are added to DesktopCapturerLacros to guard against such misuse in the future. Bug: 1141483 Change-Id: I579dd0f5ea8bef9a02c7be6d3dead23805601038 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492940 Commit-Queue: Darin Fisher <darin@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#820483}
-
Jeffrey Kardatzke authored
The USE flag for CHROMEOS_PROTECTED_MEDIA will be turned on before we have encrypted content handling done here, so reject that config in all cases until that is done. BUG=b:153111783 TEST=Builds Change-Id: Ibcd83a91ab83ef30afd01bbe7db6b5c792f474a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495801 Auto-Submit: Jeffrey Kardatzke <jkardatzke@google.com> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#820482}
-
Eugene But authored
Also updated callsites to use -[EarlGrey rotateDeviceToOrientation:error:]. Old method was needed to support EG1 tests, because EG1 did not have rotateDeviceToOrientation:error: method. R: zhaoyangli@chromium.org Bug: 1017281 Change-Id: Ia7a016f3c78e3ee550dda4a5d4cf00e3a15ac312 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495602 Auto-Submit: Eugene But <eugenebut@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#820481}
-
adoneria authored
script_test template. It will be used to pass arguments to the test target for test run via typ. Bug: 1141577 Change-Id: I11582b6e97d0dd088ededf5bd61247ee6ecfa3cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493368Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Anjali Doneria <adoneria@google.com> Cr-Commit-Position: refs/heads/master@{#820480}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 82982a2b. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: I9bbd812f848d0b653e1f53aee6734674558642a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495643Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820479}
-
Eugene But authored
Also updated callsites to use -[EarlGrey isKeyboardShownWithError:]. Old method was needed to support EG1 tests, because EG1 did not have isKeyboardShownWithError method. Bug: 1017281 Change-Id: I78f69b868b45ed34e4fd35b031ca7a1897fffdd3 R: zhaoyangli@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495330 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: I728bd3a60556d43f65fde9763dcf21b7947626ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495349Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820477}
-
Shrek Shao authored
New UKM metrics Request doc: go/client-rendering-api-ukm-review Add collections for Canvas/OffscreenCanvas context type: 2d, bitmap, webgl, webgl2. Tested locally with canvas.getContext and chrome://ukm WebGPU context is not added yet in this patch as it's not associated with canvas. Bug: 1135706 Change-Id: Ib6c15629e5f69f3be554e1614351b815e15a6c69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473043 Commit-Queue: Shrek Shao <shrekshao@google.com> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#820476}
-
Bence Béky authored
https://quiche.googlesource.com/quiche.git/+log/867ef5f63787..d84ef00c9666 $ git log 867ef5f63..d84ef00c9 --date=short --no-merges --format='%ad %ae %s' 2020-10-23 haoyuewang Reduce QuicConfig size from 1432 bytes to 1160 bytes by better padding. 2020-10-22 mattm Add QuicConnection::HaveSentPacketsInCurrentKeyPhaseButNoneAcked method. 2020-10-22 quiche-dev Rename SpdyHeaderBlock to Http2HeaderBlock. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Change-Id: Ibfad65022d1065dab86862d12aff144d3478c422 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495263 Commit-Queue: Bence Béky <bnc@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#820475}
-
Vidhan authored
Bug: 904390 Change-Id: If057d964a0e4224233aa074b6172b98793cae98e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494812Reviewed-by:
Christoph Schwering <schwering@google.com> Commit-Queue: Vidhan Jain <vidhanj@google.com> Cr-Commit-Position: refs/heads/master@{#820474}
-
