- 23 Aug, 2018 40 commits
-
-
Ramin Halavati authored
Reading List preference is moved to the persistent storage list for incognito mode. This CL does NOT make any change of behavior. Bug: 861722 Change-Id: Ie29e7c86cedc19842f64939a1acf60e7835bffc1 Reviewed-on: https://chromium-review.googlesource.com/1172132Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#585465}
-
Pavol Marko authored
Instead of reverting the original CL. See CL:1186501 for details. TBR=mattm@chromium.org Bug: 787602 Change-Id: I71e48d675268c64fe989e3fea60c999ec74b37c3 Reviewed-on: https://chromium-review.googlesource.com/1186581Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#585464}
-
Juan Antonio Navarro Pérez authored
This reverts commit 076b591c. Reason for revert: Root cause has been fixed. Original change's description: > [tools/perf] Disable youtube_pinch_2018 in smoothness benchmarks > > Stories have been consinstently failing on N5X and Pixel 2 bots. > > TBR=nednguyen@google.com > NOTRY=true > > Bug: 875859 > Change-Id: I9d41fa293a90e6961eabc6b29711d8b824d469ce > Reviewed-on: https://chromium-review.googlesource.com/1181140 > Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org> > Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> > Cr-Commit-Position: refs/heads/master@{#584440} TBR=perezju@chromium.org,nednguyen@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 875859 Change-Id: Id8caf496237be5e80d9d0d6dbe36554e722f6689 Reviewed-on: https://chromium-review.googlesource.com/1186481Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#585463}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f23e8ba4..132145aa Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If28b44c49821e7aa66b03e5914af56690635d47e Reviewed-on: https://chromium-review.googlesource.com/1186276Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#585462}
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/46ef92275f43..de2476bcaacf git log 46ef92275f43..de2476bcaacf --date=short --no-merges --format='%ad %ae %s' 2018-08-23 primiano@google.com TraceProcessor: improve parsing performances to ~420 MB/s Created with: gclient setdep -r src/third_party/perfetto@de2476bcaacf The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: If51d6952452a82e0ec8feab31eaa4a343992790a Reviewed-on: https://chromium-review.googlesource.com/1185698Reviewed-by:
perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#585461}
-
Kushagra Sinha authored
A design doc and sequence diagram are linked in the bug id. Bug: 871690 Test: browser_tests --gtest_filter="*ArcAuthServiceTest*" Change-Id: If62c7c06d107ac0b6ea73ffa8da9b7ca42365937 Reviewed-on: https://chromium-review.googlesource.com/1172123 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Cr-Commit-Position: refs/heads/master@{#585460}
-
Olivier Robin authored
Bug: 851636 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I21750fb7373063c60db26d8ba742e09d201dfe6e Reviewed-on: https://chromium-review.googlesource.com/1184704 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#585459}
-
Finnur Thorarinsson authored
TBR: asanka Bug: 877026 Change-Id: I4ebda150350f73839e357497a66d3f4a8a252f71 Reviewed-on: https://chromium-review.googlesource.com/1186418Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#585458}
-
Kushagra Sinha authored
|ArcBackgroundAuthCodeFetcher| assumes that an auth code can only be fetched for the Device Account. This assumption is no longer true. Make |ArcBackgroundAuthCodeFetcher| accept |account_id| as a parameter so that it can be used for Secondary Accounts too. Bug: 871690 Test: browser_tests --gtest_filter="*ArcAuthServiceTest*" Change-Id: I6deb6cff545a516e1842c6cba3fb0cd68defd653 Reviewed-on: https://chromium-review.googlesource.com/1172122 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
-
Kushagra Sinha authored
Move ownership of |ArcAuthContext| from |ArcSessionManager| to |ArcBackgroundAuthCodeFetcher|. ARC++ assumed that only one account will be synced between Chrome OS and ARC++, i.e. the Device Account. This assumption is no longer true because of the introduction of Chrome OS Account Manager (Design Doc is linked in the bug id). Syncing multiple accounts requires the ability to create multiple auth code fetchers which in turn require multiple |ArcAuthContext|s. This was not possible currently because of the ownership of a single |ArcAuthContext| by |ArcSessionManager|. |ArcSessionManager| does not really need an |ArcAuthContext|. It was needed only for: - Passing the context to |ArcBackgroundAuthCodeFetcher|: Not required if |ArcBackgroundAuthCodeFetcher| creates and owns the context. - Getting an instance of Token Service: Can be retrieved directly via |ProfileOAuth2TokenServiceFactory|. - |account_id| and |full_account_id|: Can be retrieved directly via |SigninManagerBase|. Bug: 871690 Test: browser_tests --gtest_filter="*ArcAuthServiceTest*" Change-Id: I78a6d2aa6693529f67f480967258c9fb00469e02 Reviewed-on: https://chromium-review.googlesource.com/1171237 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by:
-
Giovanni Ortuño Urquidi authored
AppInfo holds information about how the app should be installed e.g. window vs. tab, is default app, is policy-installed, should create shortcuts, etc. The installation task needs this information, so we could either pass it as arguments, i.e. one argument per property in AppInfo, or we could pass the AppInfo object directly. PendingAppManager has little use for AppInfo, so this CL implements the latter and passes the whole AppInfo object to BookmarkAppInstallationTask. Bug: 876173 Change-Id: I3d3c2e28ca2740b4149bae13263e798eaafa7eea Reviewed-on: https://chromium-review.googlesource.com/1184649Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#585455}
-
Friedrich Horschig authored
This CL prevents the keyboard accessory from triggering a keyboard that hasn't been requested. Example: Open youtube or chrome://flags Before this patch: The keyboard accessory controller detects that there are passwords for this site. Because the search field is focused by default, it will request openening the keyboard. Why this is wrong: The controller wrongfully assumed that a focused input field always triggers the keyboard. This is wrong, esp. for pageloads. After this patch: The controller requests to open the keyboard iff the accessory sheet is opened. Why has this become a problem now? Before https://crrev.com/c/1177361, the controller would just request the accessory to be closed. This caused nasty artifacts and bugs. Therefore, it requested to open keyboard to dismiss the sheet gently. This resulted in opening the keyboard too often. What is potentially impacted by this: - Performance tests with search bars: Confirmed --> smoothness.*/youtube_pinch_2018 not failing consistently - Health tests: Likely confirmed system_health.memory_mobile/browse.tools.maps debug run changed memory:chrome:all_processes:reported_by_chrome:effective_size by 7.7% - Startup with previously opened sites: Confirmed Following instructions in issue 876228 don't reproduce error. Bug: 875859, 876025, 876228 Change-Id: Ic5873c07cb8652bc0da5edcca8324f2680baac11 Reviewed-on: https://chromium-review.googlesource.com/1184847Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Friedrich Horschig [CEST] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#585454}
-
Kushagra Sinha authored
- Add Mojo APIs for account upsert and removal notifications. - Add implementation in ArcAuthService. Design doc is linked in the bug id. Bug: 871690 Test: browser_tests --gtest_filter="*ArcAuthServiceTest*" Change-Id: I83dea09c5d28da5c1cb9f9715eead17003ffcf2b Reviewed-on: https://chromium-review.googlesource.com/1169206 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by:
-
Findit authored
This reverts commit e00fddec. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 585387 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2UwMGZkZGVjOTJlNDliMWI1N2Y1ZGUyZjExMzQ2OTdmZDZiMWM3MDMM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20ChromiumOS%20MSan%20Tests/8297 Sample Failed Step: browser_tests Original change's description: > Reland "Migrate ResourceRequestAllowedNotifier to NetworkConnectionTracker" > > This is a reland of a9ed46b7 > > ChromeBrowserMainBrowserTest.VariationsServiceStartsRequestOnNetworkChange > was flaky in the original change. Added logic in the test to wait for the > connection type change. > > Only diffs from original are in chrome/browser/chrome_browser_main_browsertest.cc > > Original change's description: > > Migrate ResourceRequestAllowedNotifier to NetworkConnectionTracker > > > > A getter is used for NetworkConnectionTracker because some services that > > use ResourceRequestAllowedNotifier are initialized early in browser > > startup (e.g. VariationsService), and only perform the initialization > > of ResourceRequestAllowedNotifier later on the UI thread. The getter > > allows us to run get the connection tracker at that point so we don't get > > DCHECKs about being on the UI thread when running > > content::GetNetworkConnectionTracker(). > > > > This also moves the NetworkConnectionTracker in ios/ from BrowserState to > > ApplicationContext, which is available everywhere. It also matches non-IOS > > usage more closely, since we have it as a global there. > > > > Bug: 868021 > > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet > > Change-Id: I130c6b47feb90f0f7f0776ccc65666414a1ae802 > > Reviewed-on: https://chromium-review.googlesource.com/1180360 > > Reviewed-by: Eugene But <eugenebut@chromium.org> > > Reviewed-by: Robert Sesek <rsesek@chromium.org> > > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > > Reviewed-by: Robbie McElrath <rmcelrath@chromium.org> > > Commit-Queue: Clark DuVall <cduvall@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#584849} > > TBR=eugenebut@chromium.org,rsesek@chromium.org,rmcelrath@chromium.org,jam@chromium.org > > Bug: 868021 > Change-Id: I5941b72474657159f0d4a1e6667fd77a3c475887 > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet > Reviewed-on: https://chromium-review.googlesource.com/1185602 > Reviewed-by: Clark DuVall <cduvall@chromium.org> > Reviewed-by: Robbie McElrath <rmcelrath@chromium.org> > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#585387} Change-Id: Ie348785d70d6c9b7242a51f0370ee471f37c036d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 868021 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/1185922 Cr-Commit-Position: refs/heads/master@{#585452}
-
Alexander Hendrich authored
This CL makes sure all JSON device policies use DecodeJsonStringAndDropUnknownBySchema to decode the proto and adhere to the associated schema. Unknown properties are dropped. If the json string can't be decoded or does not comply with the associated schema in policy_templates.json, the policy value will be set to the original json string. This way, the faulty value can still be seen in chrome://policy along with any errors/warnings. Bug: 855054 Change-Id: I73a2bc7cc88a293b06339482437f88ac48932b83 Reviewed-on: https://chromium-review.googlesource.com/1163507Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
-
Sam McNally authored
When offline, Drive files should only be selectable in open dialogs if they are available offline. However, this is calculated after the ok button enabled state is updated, resulting in Drive files always being unselectable while offline. Wait until the available offline property of the selected files has been retrieved and used to set the allFilesPresent field on the selection before dispatching the CHANGED_THROTTLED event. Also update the ok button on drive-connection-change events so the button is updated when the network connectivity changes and a file in Drive, not available offline, is selected. Bug: 876973 Change-Id: I15fe35e18a15f3211f395c63b8c01b5a7c7846d7 Reviewed-on: https://chromium-review.googlesource.com/1186210Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#585450}
-
Yuki Yamada authored
We should not forbid script execution in isolated worlds when dispatching events (it should be operated by disabling Chrome extension), so checking execution setting is necessary only in main world. V8EventListenerOrEventHandler::CallListenerFunction() already implements this, so this CL make GeneratedCodeHelper::IsCallbackRunnable() to do the same conditional check for other callbacks generated by IDL files. Test for this is already exists: https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/fast/events/events-in-isolated-world.html Bug: 872138, 608286, 608641 Change-Id: Ibc38e6033d6d0462362012f1c49271548c26a8ec Reviewed-on: https://chromium-review.googlesource.com/1186212Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Yuki Yamada <yukiy@google.com> Cr-Commit-Position: refs/heads/master@{#585449}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0c05bf73..f23e8ba4 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I465cce34e6dfb69521b66dd59eae7f5594d993e4 Reviewed-on: https://chromium-review.googlesource.com/1186261Reviewed-by:
-
Kári Tristan Helgason authored
It's being removed from WebRTC in favour of kVideoCodecGeneric. Bug: webrtc:8136 Change-Id: I74cb60cbfee56320bd40bf0bfc31887fe0dac05d Reviewed-on: https://chromium-review.googlesource.com/1186337 Commit-Queue: Olga Sharonova <olka@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#585447}
-
Hitoshi Yoshida authored
Dictionary is not a speced type, and these values are actually unused in implementation. This CL changes Dictionary arguments to 'object' types. Bug: 816352 Change-Id: I73c31204e0f63d8cb51a425f7de10daf97f9d620 Reviewed-on: https://chromium-review.googlesource.com/1143666Reviewed-by:
-
Boris Sazonov authored
This CL changes the appearance of AccountManagementFragment if UNIFIED_CONSENT feature is enabled. Some preference rows are hidden in this case and a different title is used for the sign-out button. It also changes TextView in the modified XML file to use textAppearance (to fix presubmit error). Bug: 814728 Change-Id: Id0bdb938e31acc3bbcd7eb7ddf6747fe0d748cb8 Reviewed-on: https://chromium-review.googlesource.com/1185591Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#585445}
-
Olivier Robin authored
Bug: 851636 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I73bedc40b204b00c09233efc38ba80805b5c04d0 Reviewed-on: https://chromium-review.googlesource.com/1184702 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
-
Jérôme Lebel authored
This feature should be disabled when the autofill is disabled. Bug: 827072 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Idec93340ec0be232d7ad53f4525eee5742f5632a Reviewed-on: https://chromium-review.googlesource.com/1184715 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#585443}
-
Kunihiko Sakamoto authored
This patch adds "Accept: application/signed-exchange;v=b1;q=0.9, */*;q=0.8" request header to prefetch requests when the SignedHTTPExchange feature is enabled. The header is added in Blink side, so this patch wires up the SignedHTTPExchange feature to a blink runtime flag. Bug: 874752 Change-Id: I25c15e3ebaf64455638f93e353fd9e91086ac223 Reviewed-on: https://chromium-review.googlesource.com/1184722 Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#585442}
-
Yuki Yamada authored
Undefined internals.gc() is called in onEventInFrame() and a TypeError is thrown in current test, but the error is not visible because the error is dispatched in another frame as mentioned in https://crbug.com/606900 . The test will call gc() instead of internals.gc() after and work as intended after this patch. Bug: 872138, 606900 Change-Id: I5d059e5ff7bea56b382f0e973282788427f5a306 Reviewed-on: https://chromium-review.googlesource.com/1186287 Commit-Queue: Yuki Yamada <yukiy@google.com> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#585441}
-
Stephan Herhut authored
The DataHandle abstraction already provides support for specifying a custom deleter. The idea is that when the ownership of a backing store of an array buffer is transferred to blink, the deleter that corresponds to how the backing store was allocated is passed along. However, the deleter needs to be able to delete the backing store based only on the pointer passed. With this change, some auxiliary data can be stored along with the deleter to allow for some more book-keeping in the allocator. This is intended to be used for properly freeing backing stores that were allocated by v8 for use as wasm-memory and hence do not use the existing array buffer allocation path. Bug: v8:8073 Change-Id: I966b0747a4cecb610fedc17e74aeac56a27821ed Reviewed-on: https://chromium-review.googlesource.com/1183182Reviewed-by:
-
Martin Kreichgauer authored
Bug: 678128,847985,876806 Change-Id: I27acd32a7796edff6aabce304b698365063a4f7e Reviewed-on: https://chromium-review.googlesource.com/1185237Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#585439}
-
Alexandr Ilin authored
The CCTResourcePrefetch feature was approved for M70+ full stable roll-out (https://crbug.com/856077). We keep the flag to be able to disable the feature in case of emergency. Bug: 866460 Change-Id: Ie010d5dc6062e30dbfe2c6b559ea01b52330ff36 Reviewed-on: https://chromium-review.googlesource.com/1186335Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#585438}
-
Takashi Toyoshima authored
This patch implements NetworkService version of OriginAccessEntry in services/network/public/cpp/cors/ and makes existing blink::OriginAccessEntry just use the NetworkService version instead of having its own implementation. Motivation of this change is to use OriginAccessEntry::MatchesOrigin() in the NetworkService to provide origin access whitelisting. Bug: 870172 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I35d41addbab91813e11bdc4d8cfd74c644fb39d2 Reviewed-on: https://chromium-review.googlesource.com/1181142Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
-
sangwoo.ko authored
Replace old API with new API. This CL is a refactor ans has no intended behavior change. Bug: 842194 Change-Id: Ic1527d6bff78bc71b46df9d684b9b6b223c9cdea Reviewed-on: https://chromium-review.googlesource.com/1179428Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Sang Woo Ko <sangwoo108@chromium.org> Cr-Commit-Position: refs/heads/master@{#585436}
-
Martin Robinson authored
Originally landed: crrev.com/c/1179752 Reverted: crrev.com/c/1184924 AtkText is the proper way to expose static text to accessibility agents. This change adds initial support for the interface, but there is quite a bit of work left to properly expose hypertext as well as implement the rest of the required interface functionality. Bug: 866337 Change-Id: I8fa54ac382d82168f3b32a4430dcce5223ea4a76 Reviewed-on: https://chromium-review.googlesource.com/1185190 Commit-Queue: Martin Robinson <mrobinson@igalia.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#585435}
-
Balazs Engedy authored
The screens are never shown for now outside of tests. Also rename the `error_timeout` illustration to just `error`, as it is now used for all kinds of errors, not just timeouts. Bug: 847985, 849323 Change-Id: Ieb73254c20948c5cdffb7513249cbae61980e1a2 TBR: dschuyler@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1185008Reviewed-by:
Jun Choi <hongjunchoi@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#585434}
-
Friedrich Horschig authored
Cleaning the cached password accessory right when the tab is closed was too early: undo closing the tab would cause the cache to be unable to restore the tab properly. Most visible impact: the key icon would be gone temporarily. This CL waits for committed tab closure (i.e. past the point of undoing) to clear the cache. Bug: 874798 Change-Id: I2dee7559e8c036f04dff2f2b0daf6c49c73ec8e5 Reviewed-on: https://chromium-review.googlesource.com/1185017Reviewed-by:
-
Noel Gordon authored
Most tests in the itegration system use |appId| to refer to the Files app window and it hellps little to be different on that point. Bug: 876267 Change-Id: Ifc9f5065f2526dd0c7a14eee12a96ba304ec984a Reviewed-on: https://chromium-review.googlesource.com/1186285Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#585432}
-
Benoit Lize authored
This is hit in perf benchmarks, namely v8.browsing_desktop/browse:news:flipboard (see attached bug). Also fix trivial "git cl lint" warnings. Bug: 864718 Change-Id: If00839d578e04845f768d8480dc084f22980ed62 Reviewed-on: https://chromium-review.googlesource.com/1184843Reviewed-by:
-
Javier Ernesto Flores Robles authored
Enable bouncing in autofill suggestions scrollview. Bug: 876657 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I8bbb27c6c2d567bc41e4931a85cefb97453030c3 Reviewed-on: https://chromium-review.googlesource.com/1184716Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#585430}
-
Sylvain Defresne authored
AccountTrackerService only uses the PrefService from SigninClient. Remove the dependency on SigninClient by passing the PrefService to the service instead. The dependency on SigninClient was introduced to allow access to a URLRequestContext to download some images, but since they are downloaded by the AccountFetcherService, it is no longer necessary to depend on SigninClient. TBR=rkc Bug: none Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Icd4c0fabe37431fec97c275d6529b30d8da9f2f9 Reviewed-on: https://chromium-review.googlesource.com/1161908 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#585429}
-
Pavol Marko authored
Mark policy-provided certificates using a policy indicator on the certificates UI (chrome://settings/certificates). UI Preview: https://screenshot.googleplex.com/fnM5QZLjBe5 Bug: 859950, 787602 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Iad7bf5e5862bb2a5965db65302e10fe8bb14735f Reviewed-on: https://chromium-review.googlesource.com/1124853 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#585428}
-
Stephane Zermatten authored
Extend the AssistantScriptExecutor to store the result of processing action, successful or not, and report it to the server, which then decides what new actions to execute. A notable change is the switch from passing to the actions exactly the data they need from passing the original action proto, as the original action proto is necessary anyways to generate a proper result proto. This also adds a unit test for the script executor and fix some, but not all, incompatibilities between the protos defined in assistant.proto and those on the server. Change-Id: I190768fb97399daaf347acac762c6ecbb5fe7cad Bug: 806868 Reviewed-on: https://chromium-review.googlesource.com/1179894 Commit-Queue: Stephane Zermatten <szermatt@google.com> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#585427}
-
Sylvain Defresne authored
ProfileDownloader::GetProfilePictureURL returns a std::string corresponding to the representation of a GURL then immediately converts it back to a GURL. This is wasteful, so convert this method to return a GURL instead and convert GetCachedPictureURL to also cache the GURL instead of the string representation. Convert static std::string to static char[] and use EXPECT_ instead of ASSERT_ macros when possible in unit tests (since the EXPECT_ macro do not stop the test in case of failure). Bug: none Change-Id: Ibe73f28b38b2061b37cbdb0b9b0696b25ca8c41c Reviewed-on: https://chromium-review.googlesource.com/1160645 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Reviewed-by:
-
