- 08 May, 2018 40 commits
-
-
Scott Chen authored
Bug: 836391 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I9a62435e04983cbd28df474c20162423ac75df54 Reviewed-on: https://chromium-review.googlesource.com/1036785 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#556948}
-
Fabrice de Gans-Riberi authored
This cleans up multi-platform code paths selection and prepares for the removal of OS_POSIX for the Fuchsia build. Bug: 836416 Change-Id: Iaedf38b0b5d82121b28b1603233f43553bc5fdf0 Reviewed-on: https://chromium-review.googlesource.com/1033578Reviewed-by:
Matt Mueller <mattm@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#556947}
-
Xiaohan Wang authored
This CL provides a way for a MediaService client to create a decryptor which is backed by a CDM or a CdmProxy, also running in the MediaService. Detailed changes: - Add CreateDecryptor() in media::mojom::InterfaceFactory - Plumb CreateDecryptor() through multiple layers to reach InterfaceFactoryImpl in MediaService - In InterfaceFactoryImpl, use the |cdm_id| to find the CdmContextRef, and then if a Decryptor is supported, create a MojoDecryptorService. - Add a dummy D3D11Decryptor implementation. - Update ClearKeyCdmProxy to support Decryptor. - Add MediaServiceTest to test this path. Bug: 806018 Test: media_service_unittests updated. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I0eba8aef333cb55ad5180ce1a401f3384c95c9c8 Reviewed-on: https://chromium-review.googlesource.com/1041660Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#556946}
-
Elly Fong-Jones authored
Popup bounds computations are a bit broken in MacViews. Bug: 834908 Change-Id: Iab8f7a39a88d1d85b6a0d700c44eee9de8308e33 Reviewed-on: https://chromium-review.googlesource.com/1050191Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#556945}
-
Pedro Amaral authored
Bug: 814528 Change-Id: I7fa5b0cd8dc9df2071d54cf51e5c88356096f49b Reviewed-on: https://chromium-review.googlesource.com/1043164 Commit-Queue: Pedro Amaral <amaralp@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#556944}
-
David Bokan authored
These will be helpful in diagnosing causes of scroll issues reported in the field. Bug: Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ia37793e4ae43fa8d81b9f793a30609873e2f68ca Reviewed-on: https://chromium-review.googlesource.com/1044358Reviewed-by:
Sahel Sharifymoghaddam <sahel@chromium.org> Reviewed-by:
weiliangc <weiliangc@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#556943}
-
Siddhartha authored
Change-Id: I3b964533485b61c598c8ae8e515a0dc18ecd9399 Reviewed-on: https://chromium-review.googlesource.com/1049267Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: Siddhartha S <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#556942}
-
Charlie Andrews authored
NOTRY=true TBR=nednguyen@chromium.org Bug: 840964 Change-Id: I6e06540a2e893878a66c06690b2a007aaeee1831 Reviewed-on: https://chromium-review.googlesource.com/1050395Reviewed-by:
Charlie Andrews <charliea@chromium.org> Commit-Queue: Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#556941}
-
Sigurdur Asgeirsson authored
Bug: 755840 Change-Id: I657dbb2c13fc8a4172dc6381220af55cba266920 Reviewed-on: https://chromium-review.googlesource.com/1042819Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#556940}
-
Sergey Ulanov authored
fidl_deps parameter in fidl_library() was broken by https://crrev.com/555215 . Bug: 831384 Change-Id: Iecda3f545f6818561422b556315175d1f4df1ec4 Reviewed-on: https://chromium-review.googlesource.com/1045405 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#556939}
-
mrefaat authored
Bug: 840903 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ic40fdc4ad194301c51d1c9b4d06720cf63a9aac1 Reviewed-on: https://chromium-review.googlesource.com/1050569Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#556938}
-
Changwan Ryu authored
Android's WebView constructor calls ensureProviderCreated() and then mProvider.init(). In Chromium WebView, this corresponds to WebViewChromiumFactoryProvider constructor and startChromiumLocked(), so we capture the time taken there. And, as noted in WebViewChromium#init(), the real initialization (startYourEngines and thus startChromiumLocked) may be delayed until the first View method is called and View thread can be determined, so skip it when it hasn't started yet. The sum of the two creation times is roughly the creation time contributed by Chromium WebView, but with the following caveats: 1) ensureProviderCreated() may be called earlier in the constructor as View methods can be called in the constructor. 2) This does not capture the time taken in View constructor and View inflation, so this is only a portion of webview creation time. Also, the factory initialization (the first portion) occurs only once, while the provider initialization (the second portion) occurs every time the app creates a webview instance. Since the second portion takes much longer only for the first time, I'm splitting it into 'First' and 'NonFirst'. BUG=736545 Change-Id: I16ece2c4a1277a2489f5e8f44d157fd5cc35124d Reviewed-on: https://chromium-review.googlesource.com/1041152 Commit-Queue: Changwan Ryu <changwan@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Paul Miller <paulmiller@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#556937}
-
Alex Newcomer authored
For touchable app context menus we use a large MD shadow which, when applied to a child submenu, may obscure the parent submenu. When the child submenu's shadow is clicked, this would activate the adjacent child menu item instead of allowing the event to fall to the parent. This caused clicking a small region of the submenu arrow on the ACTIONABLE_SUBMENU when the child submenu was already showing to execute the adjacent menu item. Bug: 838669 Change-Id: Ibb716dd75f42925b3abc25b5fc3cf9abc7089d93 Reviewed-on: https://chromium-review.googlesource.com/1050380 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#556936}
-
Findit authored
This reverts commit c88820a8. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 556820 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2M4ODgyMGE4YWVkMzgzY2NiNDIxNzQ0M2I5YTQ3ZGQ1NmFlOTJkMDEM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20MSan%20Tests/9672 Sample Failed Step: components_unittests Original change's description: > Relax URL matching in TemplateUrl by adding wildcards. > > Adds the ability to use {google:wildCard} in the path portion of the > template URLs in prepopulated_engines.json. If used, the path is > separated into a prefix/suffix for comparison instead of using a direct > string comparison. > > Bug: 834876 > Change-Id: I7425ffbdd88d6ad0a958d9b32a4eb30ffc235dfe > Reviewed-on: https://chromium-review.googlesource.com/1029200 > Commit-Queue: Troy Hildebrandt <thildebr@chromium.org> > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#556820} Change-Id: Idf00ed1729a913ce1bcde54670ddcb7e64405e27 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 834876 Reviewed-on: https://chromium-review.googlesource.com/1050583 Cr-Commit-Position: refs/heads/master@{#556935}
-
Nick Harper authored
Domain was requested for removal via email; request validated via DNS. Change-Id: Ife70984f302de0e8a136e2f82c45691ea5579d8a Reviewed-on: https://chromium-review.googlesource.com/1048627Reviewed-by:
Eric Lawrence <elawrence@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#556934}
-
Eugene But authored
Without this change the navigation is processed as renderer-initiated and NavigationContext may have incorrect attributes. Bug: None Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ia7514028019f020d1ea101e7a796700a7f710d3b Reviewed-on: https://chromium-review.googlesource.com/1049056 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#556933}
-
Denis Tosic authored
The following APIs are included: * bluetooth manifest feature on linux (on other platforms whitelist is not needed) * bluetoothPrivate * cecPrivate * feedbackPrivate * mediaPerceptionPrivate * networkingPrivate * networking.onc * virtualKeyboardPrivate * accessibilityPrivate.onTwoFingerTouchStart * accessibilityPrivate.onTwoFingerTouchStop * chromeosInfoPrivate * settingsPrivate BUG=839189 Change-Id: If5f3ec5735f12a60724f59c019d667f710c8c515 Reviewed-on: https://chromium-review.googlesource.com/1049978Reviewed-by:Toni Barzic <tbarzic@chromium.org> Commit-Queue: Denis Tosic <dtosic@chromium.org> Cr-Commit-Position: refs/heads/master@{#556932}
-
Rob Buis authored
Reuse Signed Exchange header constants better since naming can change. Bug: 803774 Change-Id: I7e203cf42bc53df6639db08e11bf64d59d137f42 Reviewed-on: https://chromium-review.googlesource.com/1049068Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Rob Buis <rbuis@igalia.com> Cr-Commit-Position: refs/heads/master@{#556931}
-
Lei Tian authored
This CL refactors TemplateUrlService code includes: Java side: 1. Remove all functions access TemplateUrl with index 2. TemplateUrl only caches native pointer to access the related information. 3. Move sorting and filtering TemplateUrl list from native to Java side into SearchEngineAdapter Native side: 1. Adapt to Java side changes include removing all index based query functions int template_url_service_android and add corresponding native code for template_url_android 2. Do not cache TemplateUrl list in the native side. Bug: 835504 Change-Id: I2ecfa57931f453e6ebd216249cbeb519c6f07974 Reviewed-on: https://chromium-review.googlesource.com/1023123 Commit-Queue: Lei Tian <ltian@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#556930}
-
Sigurdur Asgeirsson authored
This is a re-land of https://chromium-review.googlesource.com/1037631 with a fix to make the test robust against occasional failure to measure render process' memory. There's an inherent race in the memory measurement that may occur on spurious renderer creation and death. Bug: 755840 Change-Id: Ia5108d844fb41d41e8690868558af99fcb598a89 Reviewed-on: https://chromium-review.googlesource.com/1050508Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#556929}
-
Sergey Volk authored
Turns out ARM64 platforms have hashes that are slightly different from regular ARM and x86 hashes. So let's add ARM64-specific hashes. Bug: b/78913742 Change-Id: I5fbae8246faeaac2e3462d0d26ecc83d7e1ef40d Reviewed-on: https://chromium-review.googlesource.com/1045844Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Sergey Volk <servolk@chromium.org> Cr-Commit-Position: refs/heads/master@{#556928}
-
Will Harris authored
BUG=840335 Change-Id: I1c82bc73808a16e633fe27b2d5a6894de7e9b490 Reviewed-on: https://chromium-review.googlesource.com/1047857Reviewed-by:
Penny MacNeil <pennymac@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#556927}
-
rbpotter authored
Bug: 814860 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I355e20c884a47e6d95f08f13a2ec47bc0c77c9da Reviewed-on: https://chromium-review.googlesource.com/1042824Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#556926}
-
Matt Reynolds authored
Gamepad button presses do not generate input events, which means APIs like the Fullscreen API which require a user activation may not function correctly when the user is interacting primarily through gamepad inputs. This CL checks the gamepad button state each time gamepads are polled and signals that the frame has received an activation if at least one button is pressed. To reduce the likelihood that inadvertent inputs may generate a user activation, a button press is only counted if the button value is at least 75% of the maximum value. This prevents triggers and other analog inputs from causing user activation from a light touch. Analog axes are not considered for user activation. This change requires the UserActivationV2 flag to be enabled to have any effect. BUG=381596 Change-Id: I506ee70f39b876c81b43cb51699cba1c48a896bb Reviewed-on: https://chromium-review.googlesource.com/1029117Reviewed-by:
Brandon Jones <bajones@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#556925}
-
Charlie Andrews authored
NOTRY=true TBR=nednguyen@chromium.org CC=bradnelson@chromium.org Bug: 840935 Change-Id: I99ec329b99822a800d70da48dcea4a085fe71e56 Reviewed-on: https://chromium-review.googlesource.com/1050577Reviewed-by:
Charlie Andrews <charliea@chromium.org> Commit-Queue: Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#556924}
-
Andrey Lushnikov authored
Currently, browser contexts created with `Target.createBrowserContext()` method will die once the protocol session is closed. This is inconvenient and inconsistent with headless behavior. This patch introduces a new DevToolsBrowserContextManager class to take care of browser context management. The instance of this class is shared between all protocol sessions. R=dgozman BUG=836272 Change-Id: If8b4b542d1a861298ef417a40b44c218d04d2f22 Reviewed-on: https://chromium-review.googlesource.com/1049110 Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#556923}
-
kristipark authored
The params class sets default parameters for specific platforms, particularly desktop (which should not need to specify min size and desired size, and should store icons as IconType::kFavicon). Also added a separate Google Favicon Service client to be used on desktop. These will be used in the upcoming NTP redesign. Bug: 837798 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ib1a78c49a2518acffdc8f1f7c746a751377cfb45 Reviewed-on: https://chromium-review.googlesource.com/1031562Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#556922}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/75ce242a4662..60c67490a1f2 $ git log 75ce242a4..60c67490a --date=short --no-merges --format='%ad %ae %s' 2018-05-08 angle-skia-autoroll Roll third_party/externals/angle2/ 3b9b027c5..c009255c7 (1 commit) 2018-05-08 fmalita Add a single-file viewer option 2018-05-07 csmartdalton Add a drawPaths method to GrCCPathProcessor Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=egdaniel@chromium.org Change-Id: I4cbcb2c8d88e52e4372ac98aafe80721af61e53a Reviewed-on: https://chromium-review.googlesource.com/1050565Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#556921}
-
Tommy C. Li authored
This CL updates the comment to be in line with acutal behavior as of: https://codereview.chromium.org/2942013002 Bug: 729415 Change-Id: Iab429d507a3ff6e700d0230d9fd03c6054326df2 Reviewed-on: https://chromium-review.googlesource.com/1048176Reviewed-by:
Kevin Bailey <krb@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#556920}
-
Christian Biesinger authored
If we are a containing block for an abspos descendent, we can't reuse the fragment because we don't know if the list of abspos items has changed -- we need to let them bubble up during layout. This is an unsatisfying solution in the long-term but should work for now, and does fix some crashes/bugs when fragment caching is on. Bug: 635619 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I5ea5a742ed87a8f6546a1405c5935d4d8a7686b0 Reviewed-on: https://chromium-review.googlesource.com/1015327 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#556919}
-
Fabrice de Gans-Riberi authored
This cleans up multi-platform code paths selection and prepares for the removal of OS_POSIX for the Fuchsia build. Bug: 836416 Change-Id: Ia326c5b5f0f05d347ee52abc89ad69386761792f Reviewed-on: https://chromium-review.googlesource.com/1033994 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#556918}
-
Devlin Cronin authored
Add utility methods to ExtensionBuilder to allow for setting a manifest key or path without needing to go through MergeManifest(). This saves the hassle of needing to construct a dictionary with a key in order to set a manifest value. Use it in a smattering of places. Bug: 832958 Change-Id: If885273205572ba72787e21acc1a75da4f861751 Reviewed-on: https://chromium-review.googlesource.com/1048848Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#556917}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/08f785343ab3..a6dce8334230 $ git log 08f785343..a6dce8334 --date=short --no-merges --format='%ad %ae %s' 2018-05-08 achuith Disable cache_temperature tests on chromeos. Created with: roll-dep src/third_party/catapult BUG=chromium:840033 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I8f31b645893821634c756a7f65e29415e7a39048 Reviewed-on: https://chromium-review.googlesource.com/1050430Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#556916}
-
Eugene But authored
This CL adds ErrorPageTest ios_web_inttest for error pages. These tests are faster than EG tests and can test is_post and is_off_the_record arguments passed to TestWebClient. ErrorPageTestCase exists, because it's not possible to test old implementation with ios_web_inttest infrastructure. ErrorPageTestCase will be removed when old error pages code is no longer supported. Tests for is_post and is_off_the_record arguments will be added in a separate CL. Bug: 725241 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ic06e9613c6e69a488ac734922ffc691f124bd24b Reviewed-on: https://chromium-review.googlesource.com/1047951 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#556915}
-
Tommy Martino authored
This change implements most of the font, color, and spacing changes requested in the mocks. Specifically: * Introduces a new subclass hierarchy, where AutofillPopupRowView is abstract and its children are divided based on whether they display an option (AutofillPopupItemView) or a separator (AutofillPopupSeparatorView). * Introduces style divergence between suggestion rows and footer rows through further subclassing. * Updates colors and most padding values to be in line with the new spec. Bug: 768881 Change-Id: I45825ffd7ad8d832cf08114116ef9b0efb834e12 Reviewed-on: https://chromium-review.googlesource.com/1026204 Commit-Queue: Tommy Martino <tmartino@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#556914}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 89b341c5. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/17160 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=danyao No-Export: true Change-Id: Ib59c3d472c2da8d88f1b7f37edc81e3c109e6c10 Reviewed-on: https://chromium-review.googlesource.com/1050467 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#556913}
-
Robert Ogden authored
Change-Id: I06cde9dc0e217751680ed7827dd246dcfcbf70e3 Reviewed-on: https://chromium-review.googlesource.com/1050432Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#556912}
-
Miguel Casas authored
A few methods and members of CanvasResourceProvider deal with CanvasResource recycling; these only apply to a derived class (CanvasResourceProviderTextureGpuMemoryBuffer); this CL moves them there, deeper in the class hierarchy. Asides from that, this CL addresses a few more nits: - Changes the protected methods of a final class to private. - |msaa_sample_count_| can be const. - CanvasResourceProviderBitmap doesn't need a |surface_| member because it inherits it from CanvasResource. - Removes a few {} from one-line if()s. Bug: 839970 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I7d2e2e82fa500b1b1c9c667a4f36c48d5a57bada Reviewed-on: https://chromium-review.googlesource.com/1047807Reviewed-by:Justin Novosad <junov@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#556911}
-
Alex Newcomer authored
Fix a simple error that I made in the context menu positioning logic. Bug: 838389 Change-Id: I2ee54d111a47bfa101af7db2fa8593ca26275a73 Reviewed-on: https://chromium-review.googlesource.com/1050509 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#556910}
-
Pedro Amaral authored
Bug: 814528 Change-Id: Ib98362502ec42cfa19de522ee40493d949295bc5 Reviewed-on: https://chromium-review.googlesource.com/1045486 Commit-Queue: Pedro Amaral <amaralp@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#556909}
-