- 27 Jun, 2018 40 commits
-
-
stkhapugin@chromium.org authored
Uses new icons, adds a background for the icons, changes the icon offset to match the new omnibox layout. Bug: 821817 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ibdd074891eb1f4b0853c28b9117d1e84f05e070c Reviewed-on: https://chromium-review.googlesource.com/1114744Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#570743}
-
Alexander Timin authored
Support temporarily increased priority for compositor tasks for input: - Explicit OnMainFrameRequestedForInput signal (new) - Implicit presence of input tasks. This patch does not change default behaviour, but add Finch hooks for enabling these options and controlling the number of tasks N. R=skyostil@chromium.org,alexclarke@chromium.org BUG=853771 Change-Id: Id82b712e46108c51a948a66cfd31556e04eb457a Reviewed-on: https://chromium-review.googlesource.com/1104677Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#570742}
-
Kent Tamura authored
local_frame.h is used in 1,900+ compilation units, and this CL reduces its pre-processed size from 7.53MB to 4.48MB. Bug: 242216 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I4f833b9994c8a5f4e950f446665135e23c92dc92 Reviewed-on: https://chromium-review.googlesource.com/1116408 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#570741}
-
Marc Treib authored
The hope is that https://crrev.com/c/1116549 has resolved the flakiness. Let's see if it worked :) Bug: 850980 Change-Id: I12c8832aba6b735179abdeaa220c4634625be326 Reviewed-on: https://chromium-review.googlesource.com/1116780Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#570740}
-
Greg Thompson authored
BUG=855800 TBR=lazyboy@chromium.org NOTRY=true Change-Id: I5eb0663724303fd7f7f2eb4b0feac36c82cc4421 Reviewed-on: https://chromium-review.googlesource.com/1116796Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#570739}
-
Justin Cohen authored
Bug: 828002 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Id9f533ff3ec912a20535cdda17de9eb61d28b946 Reviewed-on: https://chromium-review.googlesource.com/1114746 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#570738}
-
Paul Jensen authored
Attempt to ping device via host network interfaces and see if device's RNDIS network interface's MAC address appears in host's ARP cache. This gets this script working on my laptop. Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester Change-Id: Ieace3bbd424804824ca5ce5f36e8137598d922b4 Reviewed-on: https://chromium-review.googlesource.com/1112460Reviewed-by:
Misha Efimov <mef@chromium.org> Commit-Queue: Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#570737}
-
Yuichiro Hanada authored
This layout manager makes kArcVirtualKeyboardContainer follow size changes of kArcImeWindowParentContainer. This CL puts the new class into ash/keyboard/arc and adds new separate build target for this directory. It's needed because I'm going to add more classes used from ash/wayland in this directory soon. Bug: 845079 Change-Id: I521369a99bf0f4ce7d85db18df8f2ce78c2509fe Reviewed-on: https://chromium-review.googlesource.com/1109451Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#570736}
-
Greg Thompson authored
BUG=855874 TBR=fdoray@chromium.org NOTRY=true Change-Id: I882e8d1a848e0f7d86ddbac4bc47b92715d94da0 Reviewed-on: https://chromium-review.googlesource.com/1116791 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#570735}
-
Antonio Gomes authored
CL makes use of the sub-surface functionality to implement support for tooltips in Ozone/Wayland. A sub-surface has one parent surface, but its size and position are not limited to that of the parent. This means that, the content of a sub-surface is not automatically clipped to its parent's area. Additionally, by default, the input region of a sub-surface is empty. This causes all input events to be reported on the main surface, instead. TEST=Very basic UI feature: simply hover over any item that shows a tooltip. TBR=sadrul@chromium.org BUG=578890 Change-Id: I09a0eb7c79516a995cc3a4994f4959cf15b37736 Reviewed-on: https://chromium-review.googlesource.com/1110098 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#570734}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/b3f5aed4332b..2c74d85c16af git log b3f5aed4332b..2c74d85c16af --date=short --no-merges --format='%ad %ae %s' 2018-06-27 srte@webrtc.org Adds enum field trial parser. Created with: gclient setdep -r src/third_party/webrtc@2c74d85c16af The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Icebb7075253d5daf3dbab063fca78e7d87e9b7d9 Reviewed-on: https://chromium-review.googlesource.com/1116679Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#570733}
-
Nico Weber authored
Ran `tools/clang/scripts/upload_revision.py 335608`. Bug: 855772 Change-Id: Idb1947be31a99371cbddaa7f214d64858ef15d9c Reviewed-on: https://chromium-review.googlesource.com/1114922Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#570732}
-
Greg Thompson authored
BUG=856720 TBR=skyostil@chromium.org Change-Id: If7de573f6c64d4f04ff08e1a82793fc3fc021ed7 Reviewed-on: https://chromium-review.googlesource.com/1116786Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#570731}
-
Maksim Sisov authored
This is a reland of 8f2591ae Original change's description: > [ozone/wayland] Manually handle fullscreen states. > > In order to ensure media files can enter fullscreen mode, manually > handle fullscreen states. Basically, a compositor sends configuration > events on each request for state changes from clients asynchronously, > which is unefficient for media files when they enter a fullscreen mode. > > For example, when a youtube video file is being set to fullscreen, a > WaylandWindow is also set to a fullscreen mode, but the return value from > the WaylandWindow::GetPlatformWindowState still contains an old value until > the compositor calls with a configuration event. This short race is > enough for a media content to be placed in a forever "entering fullscreen" > state, which never results in a fullscreen state for media files. > > Bug: 843018 > TEST: XdgVersionV5Test/WaylandWindowTest.SetFullscreenAndRestore/0 > XdgVersionV6Test/WaylandWindowTest.SetFullscreenAndRestore/0 > > Change-Id: Ib9bc8c0ce09412c36437d165efc6a0cad60c4d17 > Reviewed-on: https://chromium-review.googlesource.com/1107636 > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > Commit-Queue: Maksim Sisov <msisov@igalia.com> > Cr-Commit-Position: refs/heads/master@{#569172} Bug: 843018 Change-Id: I63866a785f5dca088aba70e500d85748b86e8a8c Reviewed-on: https://chromium-review.googlesource.com/1113238 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Maksim Sisov <msisov@igalia.com> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#570730}
-
Alexander Timin authored
Do not save base::Thread reference in the CompositorThreadScheduler and post tasks to the scheduler default queue instead of using Thread::task_runner. R=alexclarke@chromium.org Change-Id: Idc05e3547316a5aaf6de487ec62e1be430b2499b Reviewed-on: https://chromium-review.googlesource.com/1115120Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#570729}
-
Denis Kuznetsov authored
Load OOBE configuration from file specified in command line. Bug: 854101 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ia25e36f71a3a1d14cffeb6138876aab464d7c477 Reviewed-on: https://chromium-review.googlesource.com/1069274 Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#570728}
-
Philipp Hancke authored
stops tracks acquired from getUserMedia BUG=836871 Change-Id: I828189da35b0c842078cdd4c1b4b38f7e7fbf355 Reviewed-on: https://chromium-review.googlesource.com/1113450Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#570727}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/82af620e0559..09303e448d17 git log 82af620e0559..09303e448d17 --date=short --no-merges --format='%ad %ae %s' 2018-06-27 jdarpinian@chromium.org Treat transform feedback generic binding point specially Created with: gclient setdep -r src/third_party/angle@09303e448d17 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:853978 TBR=ynovikov@chromium.org Change-Id: I56f408668abcca4b6ef3c1a407ae912f8013178d Reviewed-on: https://chromium-review.googlesource.com/1116558Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#570726}
-
Kinuko Yasuda authored
MojoBlob is default and most other code has been already removed. Bug: 776642 Change-Id: Ibf11da14a3dd46c7f4613d0617e0ee0c3b87b999 Reviewed-on: https://chromium-review.googlesource.com/1114564Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#570725}
-
Greg Thompson authored
BUG=856969 TBR=grt@chromium.org NOTRY=true Change-Id: I1864afbdfa1a71f4d6acdcba9ca9873659cc5ddb Reviewed-on: https://chromium-review.googlesource.com/1116779Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#570724}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/8b52973effb8..f989b62823cb git log 8b52973effb8..f989b62823cb --date=short --no-merges --format='%ad %ae %s' 2018-06-27 mikie@google.com tracing: Add binder transaction size to events Created with: gclient setdep -r src/third_party/catapult@f989b62823cb The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I27338b2c1f87c3e8b08d7d7c499b357f5f693a4d Reviewed-on: https://chromium-review.googlesource.com/1116678Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#570723}
-
Greg Thompson authored
BUG=856393 TBR=xiyuan@chromium.org NOTRY=true Change-Id: Icd9e1d02102ea6abab544141eb307f1e39342802 Reviewed-on: https://chromium-review.googlesource.com/1116707 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#570722}
-
stkhapugin@chromium.org authored
Currently the NTP steady location bar constraints can be broken because the location image view is set to nil, making the intrinsic size of the image view zero. Use a distinct set of constraints in this case. Bug: 854057 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I67c21c9482e7def487308470e494539a24dfe9f1 Reviewed-on: https://chromium-review.googlesource.com/1115126Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#570721}
-
Hirokazu Honda authored
This reverts commit 398ca322. Reason for revert: Breaks protected content playback in ARM platform. Original change's description: > Ozone DRM: use GBM_BO_USE_HW_VIDEO_DECODER > > This CL adds the GBM_BO_USE_HW_VIDEO_DECODER flag to > gfx::BufferUsage::SCANOUT_VDA_WRITE buffers. It's a spinoff of a > comment [1] in crrev.com/c/1021675. > > [1] https://chromium-review.googlesource.com/c/chromium/src/+/1021675/18/ui/ozone/platform/drm/gpu/drm_thread.cc#147 > > Bug: 822346 > Test: simplechrome video playback on nautilus, vaapi engaged. > Change-Id: I795c6c3f74574ffab60c24d1ef746b22d214120a > Reviewed-on: https://chromium-review.googlesource.com/1104394 > Reviewed-by: Daniele Castagna <dcastagna@chromium.org> > Commit-Queue: Miguel Casas <mcasas@chromium.org> > Cr-Commit-Position: refs/heads/master@{#568027} TBR=mcasas@chromium.org,dcastagna@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 822346 Change-Id: I8b9af48859886f0ef9c203a06079dadd53f0e477 Reviewed-on: https://chromium-review.googlesource.com/1116738Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#570720}
-
Harald Alvestrand authored
At this time, it is treated the same as "detailed". Bug: chromium:852701 Change-Id: I145c0ac9f93d2152aa5ac4a84a4a7f858c4f3fc3 Reviewed-on: https://chromium-review.googlesource.com/1111957Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#570719}
-
Michael van Ouwerkerk authored
* Some reordering. * Move view getters to host and make them setters. * Add IModuleEntryPoint.onDestroy (not called yet) This is a backwards incompatible change in the AIDL but that's ok as we have not released yet. Bug: 843161 Change-Id: I2a705f5b51c9c3ffdf36dec6746578f2dd3e42a0 Reviewed-on: https://chromium-review.googlesource.com/1112008Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#570718}
-
Greg Thompson authored
BUG=856955 TBR=grt@chromium.org Change-Id: I3dc85cc564100b27fc4c3cd2a584952c48dfb981 Reviewed-on: https://chromium-review.googlesource.com/1116550Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#570717}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/e58bd8a02b9c..b3f5aed4332b git log e58bd8a02b9c..b3f5aed4332b --date=short --no-merges --format='%ad %ae %s' 2018-06-27 qingsi@google.com Remove the flag PORTALLOCATOR_ENABLE_ANY_ADDRESS_PORTS. 2018-06-27 qingsi@google.com Use the sparse histogram in RTC_HISTOGRAM_ENUMERATION_SPARSE. 2018-06-26 emircan@webrtc.org Add bit depth information to PlanarYuvBuffer 2018-06-26 steveanton@webrtc.org [Unified Plan] Avoid offering two senders with the same ID 2018-06-26 steveanton@webrtc.org [Unified Plan] Do not initialize recvonly transceivers with any send streams Created with: gclient setdep -r src/third_party/webrtc@b3f5aed4332b The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I9f8c16944e0cd335ff5fee17bed1585c40897869 Reviewed-on: https://chromium-review.googlesource.com/1116259Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#570716}
-
Olivier Robin authored
EGtests bundle don't have access to application groups. Create a test hook to prevent app group access. Bug: 855625 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I3c773f92edfdaafb9207d69a51ba6fdee823868b Reviewed-on: https://chromium-review.googlesource.com/1113540Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#570715}
-
Friedrich Horschig authored
If the provider registered itself but never provided items, the caching adapter would notify all observers that the last provided actions were null and force them into an undefined state which caused a crash. The proper way to handle this case, is to send an empty set to all observers (see tests for an intuitive use case). Bug: 855036 Change-Id: If3a0e9ee14ac3e24e163ebba092ab47f226e43b7 Reviewed-on: https://chromium-review.googlesource.com/1115220Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#570714}
-
Moe Ahmadi authored
This CL fixes a regression caused by crrev.com/c/1012979. Previously, AutofillAgent would scan the whole page on form activities due to the possiblity of Autofill having been enabled after page load. crrev.com/c/1012979 replaced that logic in favor of observing the Pref directly. This has a side effect where previously hidden fields can go unnoticed by AutofillManager. This CL fixes that regression by scanning the page when a field is focused. All fields receive focuse before their value is set by Autofill, therefore, AutofillManager can get notified of previously hidden fields. Bug: 855696 Change-Id: I175bf90e12d1ca356b746e6347943a295063c288 Reviewed-on: https://chromium-review.googlesource.com/1112493Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#570713}
-
chromeos-commit-bot@chromium.org authored
BUG=762641 TBR=xdai@google.com Change-Id: I2b3523eed96718ac318f72aaa086b9af6f51fc12 Reviewed-on: https://chromium-review.googlesource.com/1116599Reviewed-by:
ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Commit-Queue: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#570712}
-
Kent Tamura authored
Add a mock implementation of RunFileChooser(), with a testRunner function setFileChooserPaths(). Bug: 637639 Change-Id: Ic5536524b2a5381556605b79e1907429d985e245 Reviewed-on: https://chromium-review.googlesource.com/1114573Reviewed-by:
Keishi Hattori <keishi@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#570711}
-
Marc Treib authored
This is an attempt to deflake the currently disabled SingleClientDirectorySyncTest.SingleClientDirectorySyncTest. The test was failing due to running into the 45s timeout in WaitForExistingTasksOnLoop. The theory is that that's because that function is based on WaitableEvent, and thus doesn't allow processing of events on the main thread while waiting. This CL changes it to spin a nested RunLoop instead. I could never reproduce the flakes locally, so I don't know if this helps at all. As such, this CL leaves the test disabled for now; I'll send a separate one to try re-enabling. Bug: 850980 Change-Id: I16823fe01574662586e578d5f601299c58004286 Reviewed-on: https://chromium-review.googlesource.com/1116549Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#570710}
-
Hajime Hoshi authored
EventQueue is necessary when queued events might be cancelled. This CL replaces unnecessary usages of EventQueue wherever possible for code simplicity. This CL also adds comments about task sources that should have been added at https://chromium-review.googlesource.com/c/chromium/src/+/1114672 Bug: 846618 Change-Id: I610e7163c36faea11f9abd9a7c4550acb5b6188c Reviewed-on: https://chromium-review.googlesource.com/1116516Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#570709}
-
Denis Kuznetsov authored
TBR=alemate@chromium.org Bug: 854101 Change-Id: I4792b0bef59a71d6628da8337043f00ca4b0e5b2 Reviewed-on: https://chromium-review.googlesource.com/1069268Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#570708}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4ab7198c3a75..37b7e4714558 git log 4ab7198c3a75..37b7e4714558 --date=short --no-merges --format='%ad %ae %s' 2018-06-27 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 0265e1ec1eb7..82af620e0559 (6 commits) Created with: gclient setdep -r src/third_party/skia@37b7e4714558 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jcgregorio@chromium.org Change-Id: Ice55488c5f690833b8c1745060f136b6a7c0abd9 Reviewed-on: https://chromium-review.googlesource.com/1116559Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#570707}
-
Ulan Degenbaev authored
This adds V8.GCFinalizeMC.Evacuate histogram that was not included in the previous CL by mistake: https://chromium-review.googlesource.com/c/chromium/src/+/1095156 Bug: chromium:850508 Change-Id: I309e6de32ae64cdd727480b014ad533920709512 Reviewed-on: https://chromium-review.googlesource.com/1105817Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#570706}
-
Daniel Bratell authored
There were three identical SharedBitmapIdToGpuMailboxPtr functions which converted from viz::SharedBitmapId to gpu::mojom::blink::MailboxPtr and those clashed in jumbo builds, This patch makes all code use the same shared copy in canvas_resource.cc Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ic7980af0aa30d7cc90acac1d0846f626ad58671d Reviewed-on: https://chromium-review.googlesource.com/1104461Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#570705}
-
Mikel Astiz authored
These new owners are active members of the client-side team for sync. We exclude sync/protocol to be more cautious with changes that are visible over the wire, for backward-compatibility reasons. Bug: None Change-Id: Icd5ba4a300701bf993de238b04b3d14f00821bc0 Reviewed-on: https://chromium-review.googlesource.com/1116538Reviewed-by:
Tim Schumann <tschumann@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#570704}
-