GitLab

This CL overhauls the way memory pressure is sensed and reported for
the browser process. Main changes are:

* ActivityManager.getMyMemoryStat() is used to poll pressure.

* Pressure signals are throttled.

* CRITICAL->MODERATE pressure changes are always reported.

See MemoryPressureMonitor.java comments for details.

Bug: 813909
Change-Id: I6fb5395b175cf8ca4ac40fac021125dd9d7fbc9f
Reviewed-on: https://chromium-review.googlesource.com/953166
Commit-Queue: Dmitry Skiba <dskiba@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549818}

https://pdfium.googlesource.com/pdfium.git/+log/4027887ee29a..6bebd2e3cfb7

$ git log 4027887ee..6bebd2e3c --date=short --no-merges --format='%ad %ae %s'
2018-04-11 hnakashima Avoid stack overflow when loading CPDF_Function.
2018-04-10 thestig Add static_asserts for FX_RECT and FX_COLORREF.
2018-04-10 thestig Load CIDToGIDMap stream for CID fonts if it exists.
2018-04-10 rharrison Roll DEPS for Clang and build
2018-04-10 rharrison Add an assert to make sure all code is included in static lib
2018-04-10 thestig Remove CFX_Rect.
2018-04-10 thestig Change CFX_RenderDevice::FillRect() to take FX_RECT by const-ref.
2018-04-10 thestig Change FillRectWithBlend methods to take FX_RECT by const-ref.
2018-04-10 hnakashima Implement CPDFSDK_XFAWidgetHandler::OnKillFocus.
2018-04-10 hnakashima Break down CXFA_FFWidget::On{L|R}ButtonDown() into two steps.

Created with:
  roll-dep src/third_party/pdfium
BUG=chromium:830221,chromium:813705,chromium:820256,chromium:820256


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Iae9f069e452471eac037e59354fa106060058af5
Reviewed-on: https://chromium-review.googlesource.com/1005962Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#549817}

This cl makes the internal app configurable in the launcher search
result.
1. For each app, we can provide additional searchable text for search query.
2. The app can be configured to be shown as a suggested app (Settings) or
   not (KSH).

Bug: 824437
Test: manual
Change-Id: Ib6db4eff415ac6be1ee319b9bcf545bb84eff39b
Reviewed-on: https://chromium-review.googlesource.com/1000839
Commit-Queue: Tao Wu <wutao@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549816}

Before this CL:
Data are loaded in ClientTagBasedModelTypeProcessor on startup.
Data are kept in memory until they are committed which can
never happen (if the client is offline for example).

After this CL:
Only metadata are loaded at startup, and only after the Sync engine
asks for local changes, data are loaded in memory. As a result,
GetLocalChanges method in the processor is called asynchronously
because the required data are not necessarily available in memory.

Bug: 740757
Change-Id: I8a11ddc0c8136775f0075697ba6b8ee3975685fa
Reviewed-on: https://chromium-review.googlesource.com/825562
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549815}

This CL:
1) Introduces 2 Mojo interfaces: device::mojom::MtpManager and
   device::mojom::MtpManagerClient. The current implementation just
   forwards MTP device access requests to the existing
   MediaTransferProtocolManager..
2) Makes Device Service expose the above 2 Mojo interfaces.
3) Create stubs to connect these 2 interfaces with the main user,
   storage_monitor::StorageMonitor.

More Mojo methods will be added to MtpManager and all users will be
converted to use Mojo interfaces in subsequent CLs.

BUG=769630

Change-Id: Ibfffb2a45d13014ec3984ae9e242f49492e8b16a
Reviewed-on: https://chromium-review.googlesource.com/972668
Commit-Queue: Donna Wu <donna.wu@intel.com>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549814}

Initializing the media library entails getting information about the CPU
for the libyuv and ffmep libraries. Retrieving that information might
access the file system (/cpu/procinfo). The extension handler code would
initialize the media library before the sandbox is turned on.
As part of the effort to move process launching to the service manager
where the service process is always sandboxed, this CL  adds a new
InitializeMediaLibraryInSandbox method that lets callers specify the CPU
info so the initialization can be done inside the sandbox.

The client library of the media gallery util service which was the
reason why extension handlers would need to initialize the media
library, now do it explicitly and provide the CPU info. As a result,
extension handlers related files can be removed.

Bug: 823931

Change-Id: Ie1630f3ff04c94901224750ffdea4423bd1b3186
Reviewed-on: https://chromium-review.googlesource.com/966925Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549813}

This CL makes all buttons in the title bar separated by 8px. It also
hides the BrowserActionsContainer when no actions are showing, and
forces the AppMenuButton to be 24x24.

Bug: 814535
Change-Id: Ibfa3a87d8889f36b9e4c969f6b263d1cd48e05e5
Reviewed-on: https://chromium-review.googlesource.com/994933
Commit-Queue: calamity <calamity@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549812}

Create mojo API and move the tests in 'wallpaper_private_api_unittest.cc'
to //ash, because:

1) They're only testing wallpaper_window_state_manager.

2) We want to remove //ash dependency in chrome wallpaper code.

(IIUC)|MultiUserWindowManagerChromeOS| under //chrome is responsible
for tracking the window ownership under multi-profile session. The
wallpaper_window_state_manager is only checking if the window is
visible. So if we move the tests to //ash, they only need to test that
the minimize/restore functions are no-op for invisible windows. Why
the windows are visible/invisible is beyond its scope.

Bug: 827062
Test: --enable-features=Mash
Change-Id: Ib7573e8911a6979f598f85cbb0b059be1c77b389
Reviewed-on: https://chromium-review.googlesource.com/967885
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Reviewed-by: Oliver Chang <ochang@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549811}

This helps diagnose playback problems, like jittering, stalls, which
are often caused by dropped frames.

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I6c835a6e40b94d1a36824e182bcb9aff71d9502b
Reviewed-on: https://chromium-review.googlesource.com/994283
Commit-Queue: Kongqun Yang <kqyang@chromium.org>
Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Reviewed-by: Matthew Wolenetz <wolenetz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549810}

This change removes a GCC 4.8 work around the lack of
std::vector::erase(const_iterator) from base::flat_tree.

Bug: 682254, 677044
Change-Id: I8bd13851baa58c8cecd64c02c50bd999357afac4
Reviewed-on: https://chromium-review.googlesource.com/1005074Reviewed-by: vmpstr <vmpstr@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549809}

This change implements base::as_bytes(base::span),
base::as_writable_bytes(base::span) and base::span::size_bytes() as
specified in the C++20 draft [1, 2]. As opposed to the standard
as_bytes() and as_writable_bytes() return spans of uint8_t due to the
lack of std::byte in C++14.

[1] http://eel.is/c++draft/views.span#span.obs-itemdecl:2
[2] http://eel.is/c++draft/views.span#span.objectrep

Bug: 828324
Change-Id: Ie7c4e759e81caa6dfb2b3583b36dc8923a430b55
Reviewed-on: https://chromium-review.googlesource.com/1004956Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549808}

Add methods on RWHNSViewClient to call into the static speech methods
of TextServicesContextMenu.

Add a call to RWHNSViewClient to query if there exists a RenderViewHost
for the current view's RenderWidgetHost, since that query is the only
piece left missing to allow -[RWHVCocoa validateUserInterfaceItem] to
not depend on RWHVMac.

Make RWHVCocoa query the BrowserAccessibilityManager via the
RHWNSViewClient interface, to eliminate another source of direct
calls into RWHVMac. This is explicitly temporary, as we will need to
come up with an accessibility solution for the AppShim process.

Bug: 821651
Change-Id: I568ed06a0bcbc0384702f494e06238fa635139e4
Reviewed-on: https://chromium-review.googlesource.com/1004444Reviewed-by: ccameron <ccameron@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549807}

The initial path is set for SelectFileDialogImpl::RunOpenMultiFileDialog.

Bug: 831097
Change-Id: I0de503f148efc8cda2677c907e78b8da6ce09101
Reviewed-on: https://chromium-review.googlesource.com/1005079
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549806}

Currently, entities are tracked in a map inside the ModelTypeWorker.
This is a left over from the old arch. before introducing the poll model
between the worker and the processor.

The main motivation for this refactoring is the map is currently keyed
by the client tag hash which bookmarks lack. After this CL, the map
will be keyed on server ids to support all types of entities.
And since the map is now used only when receiving remote updates,
all entities should have sever ids.

This is also in prepartion for migrating bookmarks.

Bug: 516866
Change-Id: I1e8c8c7073a53e0c67b0da2551a20e2d4db93cb1
Reviewed-on: https://chromium-review.googlesource.com/982620
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549805}

Call the adaptive screen brightness manager from
chrome_browser_main_chromeos.cc.

Bug: 820883
Change-Id: I687bcba364a3f6a6fe3e5685288052e815e8c489
Reviewed-on: https://chromium-review.googlesource.com/967965
Commit-Queue: Paul Dyson <pdyson@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Michael Martis <martis@chromium.org>
Reviewed-by: Jia Meng <jiameng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549804}

https://chromium.googlesource.com/angle/angle.git/+log/4416247c9d91..568fc39ba45a

$ git log 4416247c9..568fc39ba --date=short --no-merges --format='%ad %ae %s'
2018-04-09 lfy GLES1: glMultMatrix(f|x)
2018-04-09 lfy GLES1: glLoadIdentity / glLoadMatrix(f|x)
2018-04-10 jmadill D3D11: Add more debug names.
2018-04-10 ynovikov Skip RobustResourceInitTestES3.MaskedStencilClearBuffer on Mac NVIDIA.
2018-04-05 lucferron Vulkan: 3 Final bugfixes to enable all dEQP depth_stencil tests
2018-04-10 lucferron Vulkan: PointSprite suppress 3 tests that are failing the android tests

Created with:
  roll-dep src/third_party/angle
BUG=chromium:None


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=ynovikov@chromium.org

Change-Id: I471db60f449d20cb42af870d525aa2295538c080
Reviewed-on: https://chromium-review.googlesource.com/1006514Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#549803}

There are two paths which lead to dragging a Mac app's window around:

- The slow path is initiated by the app: some hit testing happens on mouse
  down, and something (most often the frame view) calls `[self.window
  performWindowDragWithEvent:theEvent]` to start server-side dragging.

- The fast path involves the window submitting a map of draggable regions to
  the window server. A `mouseDown:` in those regions starts a drag without
  waiting for the app.

AppKit uses both: it traverses the view hierarchy and reads the
`mouseDownCanMoveWindow` property of each view (which defaults to NO if the
view `isOpaque` and YES otherwise), and submits a map based on the views'
frames. However, a view may still override `-hitTest:` to punt some events
(say, if it's not rectangular, like a Chrome tab). If the title bar gets the
event, it starts a drag on the slow path. This means that, if an app is hung,
dragging still works, you just can't start drags from the transparent parts of
non-rectangular views.

One more complication: views that underlap the title bar in a window with a
full size content view, even if the title bar is hidden, only cut a hole in the
drag map if they override `-mouseDown:` *and* return YES for
`acceptsFirstResponder`. That was an issue because `BridgedContentView` returns
YES only if it's already first responder, so dragging was unpredictable.

This change:

- …makes BridgedContentView return nil when `-hitTest:` is passed a spot that
  should be draggable. The event ends up at the frame view, which could result
  in a drag or in a double-click miniaturizing or zooming the window.

- …deals with the "one more complication" by overriding `-_copyDragRegion` in
  BrowserWindowFrame to return nil, which effectively opts the window out of
  the fast path.

- …adds a custom frame view class for frameless app windows which uses
  `-[NSWindow performWindowDragWithEvent:]` (and an old undocumented version on
  10.10) to start a drag on `mouseDown:`, because the
  `movableByWindowBackground` property on windows seems to only affect "fast
  path" dragging.

Bug: 823770, 826477
Change-Id: I9b7d727776d45853d1160b4cec53baf678e70d93
Reviewed-on: https://chromium-review.googlesource.com/1000212Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Leonard Grey <lgrey@chromium.org>
Commit-Queue: Sidney San Martín <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549802}

Following bot results are included.
4700 4703 4704 4710 4715 4717 4724 4726 4730

4 lines were removed and 2 lines were deflaked by consecutive
results since 4653.

TBR=eae@chromium.org, mstensho@chromium.org
NOTRY=true

Bug: 591099
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I76fe9fd649b346f61a05e5d76c3913096d03cffd
Reviewed-on: https://chromium-review.googlesource.com/1004878
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549801}

The Shortcuts window is not centered in screen when there is no context.
This cl fix this bug.

Bug: 831323
Test: KeyboardShortcutViewTest.CenterWindowInScreen
Change-Id: I968450240ce2f69edc607a16aad1f48760138559
Reviewed-on: https://chromium-review.googlesource.com/1006066Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549800}

This change also converts the minimum necessary amount of C++ code to pass
objects of base::Value by value instead of std::unique_ptr.

Bug: 646113,799482
Change-Id: Ia431fce89593a544ec10ea20f56cbce16915b22e
Reviewed-on: https://chromium-review.googlesource.com/1005452
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549799}

Motivation / context
====================

RenderProcessHosts can be destroyed in various ways.  One of the ways it
via BrowserContext::NotifyWillBeDestroyed which calls
DisableKeepAliveRefCount on all RenderProcessHost objects associated
with the given BrowserContext.  This CL ensures that the spare
RenderProcessHost is properly destroyed in this scenario.


Zero ref-count
==============

Before this CL DisableKeepAliveRefCount would have no effect on the
RenderProcessHost maintained by SpareRenderProcessHostManager.
This is because the spare RenderProcessHost has a zero ref-count
and before this CL DisableKeepAliveRefCount would return early
for a zero-refcount host.

The CL allows DisableKeepAliveRefCount to proceed for RenderProcessHosts
that have a zero ref-count.

Note that this CL doesn't change the number of calls made by
DisableKeepAliveRefCount to RecordKeepAliveDuration - such calls won't
be made for zero-refcount RenderProcessHosts (for such hosts all
keep_alive_client_count_[i] will be equal to 0).

Note that the spare RenderProcessHost cannot have a ref-count owned by
the SpareRenderProcessHostManager, because SpareRenderProcessHostManager
would have to give up this ref-count when handing out the spare to the
rest of the system (and giving up the ref-count before the new owner
claims its own ref-count [or route] would destroy the object).


Double-free
===========

This CL needs to ensure that RenderProcessHost::Cleanup is not called
twice (once by RenderProcessHostImpl::DisableKeepAliveRefCount and once
by SpareRenderProcessHostManager::CleanupSpareRenderProcessHost).  This
is done by avoiding the cleanup if
|spare_render_process_host_->IsKeepAliveRefCountDisabled()|.


Bug: 808114
Change-Id: Ie5d80916712408763a542364888e8c3d5fe4e2ea
Reviewed-on: https://chromium-review.googlesource.com/999816
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549798}

(1) Normalizer rescale a int32 or float feature by diving the
    normalizer.

(2) Convert_to_string preprocessor sets a feature from int32 or bool
    to string_value.

BUG=786472

Change-Id: Ia93bbb7a28be4fdd22a6d72e83c86852878bc0a6
Reviewed-on: https://chromium-review.googlesource.com/1001085
Commit-Queue: Charles . <charleszhao@chromium.org>
Reviewed-by: Andrew Moylan <amoylan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549797}

Creating histograms for session lengths for FT and non-FT networks and
for SPK and 802.1X authentication. This is a success metric to quantify
connection reliability improvements from FT. Histograms are implemented
in CL:957442

Bug: 791202
Change-Id: I34a6d4962abb70a36e44e77fe0db6a6f1e411b37
Reviewed-on: https://chromium-review.googlesource.com/989027Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Matthew Wang <matthewmwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549796}

This reverts commit a5439425.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 549774 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2E1NDM5NDI1ZGQxMjcyMDdjMmZlYzNmMzU4ZDFmMzI5NDI4ZDBiNzEM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.win/Win%207%20Tests%20x64%20%281%29/36918

Sample Failed Step: webkit_unit_tests

Original change's description:
> Media Controls: allow navigation with accessibility tools.
> 
> The media controls auto-hide mechanism breaks accessibility tools. This
> prevents the controls from fully hiding when navigated with
> accessibility tools. Instead of marking themselves as `display:none;`,
> this only mark the controls as hidden and will show them again if the
> user navigates trough them again. Similar to using a mouse.
> 
> Bug: 667833
> Change-Id: I7c2dbfd4b047e2955f6ffa9fb1a5f3bbe37878fd
> Reviewed-on: https://chromium-review.googlesource.com/999637
> Reviewed-by: Tommy Steimel <steimel@chromium.org>
> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#549774}

Change-Id: I24ff5ad8f2320562ad566b944d0126b8d2cf0c21
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 667833
Reviewed-on: https://chromium-review.googlesource.com/1006535
Cr-Commit-Position: refs/heads/master@{#549795}

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I6dbaea927d88345e1ae5c99d1b4376a41729c190
Reviewed-on: https://chromium-review.googlesource.com/1006517Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549794}

This reverts commit 25dfe9c1.

Reason for revert: Reverted too much. Will follow up with a less-aggressive revert.

Original change's description:
> Remove omnibox separator from rounded omnibar
> 
> Essentially reverts crrev.com/c/942562 as Material refresh doesn't call
> for one. This unifies touchable with refresh in this area.
> 
> Bug: chromium:828365
> Change-Id: I2536bd61c5fc6ded1bcf71f720aef558367e012a
> Reviewed-on: https://chromium-review.googlesource.com/1000422
> Commit-Queue: Peter Kasting <pkasting@chromium.org>
> Reviewed-by: Peter Kasting <pkasting@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#549355}

TBR=pkasting@chromium.org,pbos@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:828365
Change-Id: I2001fb86174679cc5dad2d6f58832a3b412de3bf
Reviewed-on: https://chromium-review.googlesource.com/1006534Reviewed-by: Peter Boström <pbos@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549793}

TBR=tandrii@chromium.org

Bug: 776496
Change-Id: I824a46b8346737fd1702ce73ecd1a1029742d645
Reviewed-on: https://chromium-review.googlesource.com/1006519Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549792}

Known failures:
- flood & stop opacity: we should be clamping between 0 and 1 like
  'opacity'.
- paint-order: we seem to always compute to a list, but we should be
  computing to as specified (Firefox has correct behaviour).

Bug: 820299
Change-Id: I0bcf29e07cb63516072bc3d0c307d0eadf2de6a3
Reviewed-on: https://chromium-review.googlesource.com/1002433Reviewed-by: nainar <nainar@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549791}

Log IOS.StoreKitLoadedSuccessfully with the loading result when
loadProductWithParameters finish loading StoreKit.

Bug: 623016
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I6ac1fb583a85f40cbcf5f3c86816c0e1405061a2
Reviewed-on: https://chromium-review.googlesource.com/1005979
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549790}

This reverts commit 53553a99.

Reason for revert: This makes unit_tests failed on many bots.

Original change's description:
> Add a net::TransportClientSocket class
> 
> This CL adds a net::TransportClientSocket so that we can have an interface
> to expose socket Bind() method.
> 
> This CL changes the following:
> - socket_test_util.cc
>   Changes MockClientSocket to subclass this new net::TransportClientSocket
>   class instead of net::SSLClientSocket. This new class hierarchy is more
>   intuitive because not all client sockets are ssl socket.
> - client_socket_factory.cc
>   Makes CreateTransportClientSocket() returns a net::TransportClientSocket
>   instead of a StreamSocket.
> - services/network/*
>   Makes network::SocketFactory take in a net::ClientSocketFactory.
> - cast_socket.cc/h and cast_socket_unittest.cc.
> 
> 
> Bug: 721401
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
> Change-Id: Ie258114565e76529555e244364be421e66637960
> Reviewed-on: https://chromium-review.googlesource.com/995554
> Commit-Queue: Helen Li <xunjieli@chromium.org>
> Reviewed-by: Derek Cheng <imcheng@chromium.org>
> Reviewed-by: Matt Menke <mmenke@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#549731}

TBR=mmenke@chromium.org,xunjieli@chromium.org,imcheng@chromium.org

Change-Id: If5aea44dc8671f126baf23fab2d4768cc2458fd9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 831477
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Reviewed-on: https://chromium-review.googlesource.com/1006298Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549789}

Known failures:
- clip-path: doesn't support <geometry-box>

Bug: 820299
Change-Id: I28e00e59cfa7f7c3d2bd7db307fb6d0f528d395d
Reviewed-on: https://chromium-review.googlesource.com/1002342Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549788}

This CL is a pure rename and has no behavioural changes.
This renames BrowserViewButtonProvider to ToolbarButtonProvider.
This is intended to be an interface that HostedAppButtonContainer
and ToolbarView implement to expose access to their common buttons.

Bug: 828278
Change-Id: I1ad846e260abd3bd9de4de48cce26a0845f93bca
Reviewed-on: https://chromium-review.googlesource.com/991534
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549787}

This patch changes "move-{3875618,3875641}-fix.html" to utilize
|selection_test()| for ease of maintenance.

Because of "move-{3875618,3875641}-fix.html" does similar steps this patch
integrates them into "move-3875618-fix.html".

This patch also removes entries from test expectations for LayoutNG since
failures are pixel differences and this test doesn't require to compare pixel.

Following patch will move "move-3875618-fix.html" to
"forward_line_from_start_of_line.html" to make file name to provide a hint what
this test file does.

Bug: 679977
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: If20ada175312d22d5b58bf8997f7ba3c5c866ca5
Reviewed-on: https://chromium-review.googlesource.com/1004558
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549786}

This is part of efforts to replace base::ThreadTaskRunnerHandle::Get()
and SequencedTaskRunnerHandle::Get() with other appropriate task runners
in the renderer.

Bug: 827065
Change-Id: Ibe964c87e8e0244621610e2eacd0842111e351e8
Reviewed-on: https://chromium-review.googlesource.com/1002797
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549785}

Bug: 820883
Change-Id: I52518e53a6ad8eaf12daa84f11fa582fd4471e67
Reviewed-on: https://chromium-review.googlesource.com/994494
Commit-Queue: Paul Dyson <pdyson@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Jia Meng <jiameng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549784}

Known failures:
- letter-spacing: a <length> of 0 resolves to "normal", but should
  compute to "0".
- line-break: "anywhere" not supported.
- overflow-wrap & word-wrap: "break-spaces" not supported
- word-spacing: "normal" should compute to "normal" and should be able
  to set word-spacing to a <percentage>.

Bug: 820299
Change-Id: If5bac479521de6f1658a38a295df01de98f433f2
Reviewed-on: https://chromium-review.googlesource.com/1002340Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549783}

Change-Id: Ib60f94fbb3ecf4988810046c250c4588c1d31289
Reviewed-on: https://chromium-review.googlesource.com/1004374
Commit-Queue: Matt Giuca <mgiuca@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549782}

r549293 was reverted because we converted a browser test into a
tentative WPT, which ended up being both leaky AND flaky.

This CL just keeps the browser test, and we'll do the WPT conversion
asynchronously.

Bug: 772515
Change-Id: I1db454c741fe26981c3cd3156901b68ce29338ad
Reviewed-on: https://chromium-review.googlesource.com/1005318Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549781}

See bug(s) for spec. This CL adds an animated blur on wallpaper when entering/existing
overview when no maximized/fullscreen windows.

Bug: 823533, 812004
Change-Id: Icf8bdababedaaefe869f62768aacf7abcb3643d2
Reviewed-on: https://chromium-review.googlesource.com/979167Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549780}

Change-Id: Iac72b51ffb422744ea463ff3f2e718d9f6b06832
TBR: sky@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1005215Reviewed-by: Sidney San Martín <sdy@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Sidney San Martín <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#549779}