GitLab

Use appropriate types for handling ArrayBuffer

BUG=879657

Change-Id: I0a46fcd98837a041c76d7b68defc06fc786b024b
Reviewed-on: https://chromium-review.googlesource.com/c/1281689Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600013}

This CL adds a new PaintWorkletInput structure which includes some
necessary information that is needed for PaintWorklet to paint.

Bug: 884698
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ic6f4960c383191c33e1bbfbc18a1d3f7826b3ef2
Reviewed-on: https://chromium-review.googlesource.com/c/1256371Reviewed-by: David Bokan <bokan@chromium.org>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Commit-Queue: Xida Chen <xidachen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600012}

Bug: 878082
Change-Id: Iaa92ae14c3d64b8cfee0628080c7a4377397741e
Reviewed-on: https://chromium-review.googlesource.com/c/1282217Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600011}

In network quality estimator (NQE), replace all
occurences of thread checker by sequence checker.

This CL does not introduce any functionality changes.

This CL has been factored out of a larger CL that
hooks up NQE with the SPDY session class, and is
needed to prevent crashes in some of the tests.

Change-Id: I95eef8a8cc593812889ece20b5fb346df94c1608
Bug: 823322
Reviewed-on: https://chromium-review.googlesource.com/c/1282722Reviewed-by: Doug Arnett <dougarnett@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600010}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2129101d5e9b..55fbadac66fe


Created with:
  gclient setdep -r src-internal@55fbadac66fe

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I13f1995574e35b129f3e7aa91c1a31f2a5abd443
Reviewed-on: https://chromium-review.googlesource.com/c/1283509Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#600009}

Bug: 850098, 893598
Change-Id: I0ec85e12ae0714974e4d8122914afe330ac0fe93
Reviewed-on: https://chromium-review.googlesource.com/c/1240172Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600008}

Fix up the tests so that they run correctly with base::LaunchUnitTests().
Add the unit test exe to the buildbot configs.

The original CL was reverted by:
https://chromium-review.googlesource.com/c/chromium/src/+/1281880

patchset 1 of this CL contains the unmodified change that originally broken
the build.  Further patchset contain the corrections.

Bug: 895819
Change-Id: Idad19d89192df4fdf11dc8def75709322bfd9c31
Reviewed-on: https://chromium-review.googlesource.com/c/1283255Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Roger Tawa <rogerta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600007}

Bug: 805600
Change-Id: I6fb4f40c4095030edca03d6389164edaf16573d8
Reviewed-on: https://chromium-review.googlesource.com/c/1279065
Commit-Queue: David Bertoni <dbertoni@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600006}

PointerEvents are never generated by the system, so this code is never reached.
PointerEvent is going to be removed shortly.

BUG=895619
TEST=covered by tests

Change-Id: Ie8f65ed28d1f00a2f27093acab242a5d679944a1
Reviewed-on: https://chromium-review.googlesource.com/c/1282206Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600005}

Report all feature policy violations to the inspector console. This
log message is generated at the same time that a report would be sent
to the ReportingAPI.

By default, a generic message is logged, but the methods will accept a
ConsoleMessage object which will be used in its place if the FP check
determines that use of the feature is not allowed.

Bug: 661280
Change-Id: Icf2e89e3e6e582480b809b64edfa5832a836ebac
Reviewed-on: https://chromium-review.googlesource.com/c/1257545
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600004}

This patch means cleaning up old pref that have passed over year+.
A follow up to that CL.
(https://chromium-review.googlesource.com/c/chromium/src/+/1264343)

Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Ib1949419b5b2df9b6906d5f5b7d100f5d5a7046c
Reviewed-on: https://chromium-review.googlesource.com/c/1278455Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Jaeyong Bae <jdragon.bae@gmail.com>
Cr-Commit-Position: refs/heads/master@{#600003}

No longer needed after https://chromium-review.googlesource.com/c/chromium/src/+/1267596/

Bug: none
Change-Id: I2caabdde712595b68dc70b6d20c101295dd81c42
Reviewed-on: https://chromium-review.googlesource.com/c/1282383Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600002}

- The infobarContainerView is now being added in the Coordinator start method.
- The infobarCoordinator now starts right after its initialized.

Bug: 892376
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Ifd5e99e165280df73849f5590e2ccbe9d32945c8
Reviewed-on: https://chromium-review.googlesource.com/c/1282035Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600001}

The crash is in the NotificationManagerService, only on Lenovo Marshmallow devices,
and from error message it's clear that the Icon class is used incorrectly:
type of Icon is not checked before calling getResId(). We can't do much except
blacklisting lenovo along with samsung and yulong.

Bug: 894361
Change-Id: Iee094561227ab83cffb6cf913a4eb31961bf35b5
Reviewed-on: https://chromium-review.googlesource.com/c/1278847
Commit-Queue: Pavel Shmakov <pshmakov@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600000}

Bug: 827415
Change-Id: Ia2b38a57a7232dffaaa5f815b486baccbca92d4b
Reviewed-on: https://chromium-review.googlesource.com/c/1274904
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599999}

The flag tracks a feature that is enabled by default,
which allows us to disable double-tap-to-zoom in the
future if we need to.

BUG=895574
TEST=Disable the feature and expect double-tap-to-zoom
     to stop working in tablet mode.

Change-Id: Ia3bafbb96ecd2fb55186b1fae388d955e34efb2f
Reviewed-on: https://chromium-review.googlesource.com/c/1281884Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599998}

Since Android O, CurrentProcessInfo::CreationTime() returns a zero
base::Time() because access to /proc/stat is forbidden (see
https://issuetracker.google.com/issues/37140047). To prevent
developers from doing the wrong thing, we will stop supporting
CurrentProcessInfo::CreationTime() on Android in a upcoming CL.
As a prerequisite, this CL removes the only caller on Android.

Infinite values currently recorded to
Gaia.AuthFetcher.ListAccounts.ProcessUptime.* on Android O show
that CurrentProcessInfo::CreationTime() is broken on Android O.

Change-Id: Ib01ef51e7ce4b9855043a5dfa667e8f6c70cdcd1
Reviewed-on: https://chromium-review.googlesource.com/c/1280609Reviewed-by: Roger Tawa <rogerta@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599997}

These have been in stable since M-69.

Change-Id: Iedd7df0ef4941ba85423c79610ec22c10d567357
Bug: 826950
Reviewed-on: https://chromium-review.googlesource.com/c/1203316Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599996}

https://android.googlesource.com/platform/external/perfetto.git/+log/5f1cbf4f7262..c0c9df23b38c


git log 5f1cbf4f7262..c0c9df23b38c --date=short --no-merges --format='%ad %ae %s'
2018-10-16 taylori@google.com Merge "trace_to_text: Output process names and fix json."
2018-10-16 fmayer@google.com Merge "profiling: Allow to generate heap dumps."
2018-10-16 treehugger-gerrit@google.com Merge "Change usage message for trace_processor_shell."


Created with:
  gclient setdep -r src/third_party/perfetto@c0c9df23b38c

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: Ib146e8c600bb22a4dddbc92455d9eb8e8ea7e671
Reviewed-on: https://chromium-review.googlesource.com/c/1283241Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#599995}

Offline pages uses some non-exact url matching, such as removing
fragments and matching redirects. The host communicates with the Feed
only through exact matches. The change switches the get status path to
full use exact requested URL matches.

Unfortunately observations from OfflinePagesModel still must trust the
offline pages URL, but this is not easily fixable.

Bug: 888770
Change-Id: I9b6d7734547af149d2e0e5af28aea071b4f18a36
Reviewed-on: https://chromium-review.googlesource.com/c/1278933Reviewed-by: Filip Gorski <fgorski@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599994}

OmniboxElement, OmniboxInputs, and OmniboxOutput

Bug: 891303
Change-Id: I9de04903beddab6638e379227ae714801ad65991
Reviewed-on: https://chromium-review.googlesource.com/c/1281164
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599993}

BUG=891699

Change-Id: Ib0d473673ba6f06e9d46096380df517ebeb3ae4f
Reviewed-on: https://chromium-review.googlesource.com/c/1282363Reviewed-by: Leonard Grey <lgrey@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599992}

Fixes some ArcVoiceInteractionFrameworkServiceTest expectations. These
expectations are not guaranteed by the test setup or execution, and only
pass today coincidentally due to timing of Mojo interface message
dispatch. Fortunately there is no reason why the expectations need to be
met under the given conditions, so they are simply removed here.

See linked bug for additional details regarding why timing may change
soon.

Bug: 872069
Change-Id: If6d15c1db8224555f0476910d10e17afe2f3cbe1
Reviewed-on: https://chromium-review.googlesource.com/c/1281742
Commit-Queue: Ken Rockot <rockot@chromium.org>
Reviewed-by: Yue Li <updowndota@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599991}

According to the specification, we should not paint backgrounds for
html or body on the viewport if they are display:none [1].

[1] https://drafts.csswg.org/css-backgrounds/#special-backgrounds

Bug: 895757
Change-Id: Ia975022e3bfa849298667f72908a64c0d5331872
Reviewed-on: https://chromium-review.googlesource.com/c/1283134
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599990}

This the Chromium side of adding usage counter for Intl
objects functions.
It depends on https://chromium-review.googlesource.com/c/v8/v8/+/1255628

Bug: v8:8250
Change-Id: I3a56c6948bbe6059b5b997a4199c4ea612c9ee3d
Reviewed-on: https://chromium-review.googlesource.com/c/1255629Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599989}

The tests incorrectly assumed that block-size:-webkit-fill-available on
absolutely positioned children were resolved against the available *content* box
size. But for absolutely positioned descendants, the containing block size is
based on the *padding* box.

(Fun fact: -webkit-fill-available, when used on *inline* sizes, is handled
correctly in legacy, i.e. we use the padding box, then)

NG does it correctly in both dimensions. So mark the test as failing in legacy
and passing in NG.

Updated the tests to look prettier when rendered correctly.

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I3f987660920ee0e03974dabb6928c0591717766a
Reviewed-on: https://chromium-review.googlesource.com/c/1281967Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599988}

Replace passing around an array+size with passing a vector to cleanup
code.

Bug: none
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I04eb35d9af0c96db0cddaa2a6b5f526517d7ec3e
Reviewed-on: https://chromium-review.googlesource.com/c/1280858Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599987}

The API for attaching inner and outer WebContentses only supports a
RenderFrameHost which is same-process and origin with its parent. This
is due to the fact that all GuestViews start off with a blank <iframe>
which is later swapped out with a proxy during attaching process.

For MimeHandlerViewGuest it is not guaranteed that the starting frame
in an <embed> or <object> is in 'about:blank'. This CL circumvents the
problem by first navigating a plugin frame (on the browser side) to
'about:blank' and then proceeding with the attaching process.

 Bug: 659750

Change-Id: I57d41a38e957b22c4ba3c29cb11122115373946f
Reviewed-on: https://chromium-review.googlesource.com/c/1240635
Commit-Queue: Ehsan Karamad <ekaramad@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599986}

After successfully migrating the ProcessDiceHeaderDelegateImpl we can
complete the job by also migrating the unit test. Several fake objects
were removed in favour of IdentityTestEnvironment which also provides
an IdentityManager.

Bug: 890791
Change-Id: Ie689268b0b9e2569a4cce5c4abe645d3daa82c7e
Reviewed-on: https://chromium-review.googlesource.com/c/1282743Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Sergio Villar <svillar@igalia.com>
Cr-Commit-Position: refs/heads/master@{#599985}

The profile name already has a data binding. When the /manageProfile page
loads first, the profile name has not yet been retrieved when setting the
input resulting in setting the input value to undefined which leads to a
momentary invalid input. Once the profile name is set, the data binding
to the input value will do the necessary update.

Bug: 895205
Change-Id: Ibf3ef6c81e0e7fa73b52944ee4cdf8c72f1748d6
Reviewed-on: https://chromium-review.googlesource.com/c/1281222Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599984}

Prior to this CL, if a child initiates a synchronization event and submits a
CompositorFrame with a deadline in the past then the CompositorFrame will
immediately activate, but the surface will not be marked and so future
CompositorFrames to the same surface will result in blocking until embedding
or deadline again and again.

This could slow down activation and skew deadline duration reporting. This CL
marks a surface such that additional CompositorFrames submitted to the surface
will not block on embedding.

Bug: 672962, 890767
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: Ia942e39266ac11dd20cea3f3ae4a087511a98c1d
Reviewed-on: https://chromium-review.googlesource.com/c/1281885
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599983}

Currently, the icon persists across navigations, which is wrong.

Bug: 894955
Change-Id: I5e2028668a249c0baeb3976297c499df3e61b3b3
Reviewed-on: https://chromium-review.googlesource.com/c/1279208
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599982}

Before this change, small timing issues in scripts could result in
actions failing to find the element they need.

The java implementation includes a short wait before most actions, so
there's no need to add a WaitForDom for short delays. This patch
reproduces that behavior.

After this change, scripts requiring a selector wait for up to 2s for
the element they need to appear.

Bug: 806868
Change-Id: I4518d1d4260e32dc59b7f9455cda00f86ac24543
Reviewed-on: https://chromium-review.googlesource.com/c/1280283
Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org>
Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599981}

Bug: 806868
Change-Id: I22b21ccbb386e89d5ac2b0cd8d80e53cc14b447a
Reviewed-on: https://chromium-review.googlesource.com/c/1282362
Commit-Queue: Ganggui Tang <gogerald@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599980}

Change-Id: Ia77210022ac412d00be1fc2f8831eb973e07de62
Reviewed-on: https://chromium-review.googlesource.com/c/1280786Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Brian Osman <brianosman@google.com>
Cr-Commit-Position: refs/heads/master@{#599979}

The test is 50% flaky.

TBR=rbpotter@chromium.org

Bug: 895832
Change-Id: Ic97a551542ae757c10e81a2440454b213aa05f05
Reviewed-on: https://chromium-review.googlesource.com/c/1282959Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599978}

This introduces an --enable-raster-to-sk-image flag that can be used
to OOP raster to an SkImage directly. This can be combined with other
flags for Vulkan prototyping with OOP-D, OOP-R, SkiaRenderer and SkDDL.

Notable changes:

- adds a temporary SHARED_IMAGE_USAGE_OOP_RASTERIZATION SharedImage
  usage flag for OOP-R

- adds a --enable-raster-to-sk-image flag to create a WrappedSkImage for
  OOP-R. This to prevent malicious renderer from turning on this untested
  (temporary) code path.

- Added GetType to TextureBase so that we can safely downcast.

- Added GetTracingId TextureBase so that we can memory dump with Vulkan.

Currently does not support passthrough. This is not a regression, but
remains future work.

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ia273d3055b01239f66f33f77296575ee58f09c50
Reviewed-on: https://chromium-review.googlesource.com/c/1127445Reviewed-by: Eric Karl <ericrk@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Jonathan Backer <backer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599977}

In order to report Largest/LastImagePaint to UKM, this CL is to plumb
Largest/LastImagePaint to WebPerformance, but a follow-up CL has to be
done to pick up the metric results from the browser side.

Before this CL, the metrics report the result by dumping a trace event.
This CL adds a new way of reporting. When the metrics fire new results.
The results will be stored in the detector class. At the same time,
the detector will notify web performance of the new result so that
the web performance will pick up the metric results.

This CL also refactors the OnLargest/LastImagePaintDetected function in
ImagePaintTimingDetector for better readability.

Bug: 869924
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I9b198b8bacac52e5dae66ea3ab9c2bedc56cfb8f
Reviewed-on: https://chromium-review.googlesource.com/c/1280844Reviewed-by: Steve Kobes <skobes@chromium.org>
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Commit-Queue: Liquan (Max) Gǔ <maxlg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599976}

This effectively reverts
https://chromium-review.googlesource.com/c/chromium/src/+/614084
which added this hack.

This is no longer necessary as wheel listeners can now prevent the
double-tap to zoom gesture (see issue 802369) and the PDF viewer has
the necessary behaviour already (see testPreventNativeZoomFromWheel in
gesture_detector_test.js).

Bug: 676668, 802369
Change-Id: I4cb840d9f383c0f8aa4a47851d749de41004816b
Reviewed-on: https://chromium-review.googlesource.com/c/1281172Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: dsinclair <dsinclair@chromium.org>
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599975}

A new version of Clang made the -Wshadow warning also apply to
enumerators, warning that the blink::WebSettings::V8CacheOptions
enumerators shadow the enumerators from blink::V8CacheOptions, e.g.

49344/58815] CXX obj/third_party/blink/renderer/core/core_generated/v8_code_cache.o
In file included from
../../third_party/blink/renderer/bindings/core/v8/v8_code_cache.cc:9:
../../third_party/blink/public/web/web_settings.h:66:5: warning: declaration
shadows a variable in namespace 'blink' [-Wshadow]
    kV8CacheOptionsDefault,
    ^
../../third_party/blink/renderer/bindings/core/v8/v8_cache_options.h:37:3:
note: previous declaration is here
  kV8CacheOptionsDefault,  // Use whatever the current default is.
  ^

Bug: 895475
Change-Id: I6de82855f3db4655c1bfaa4bb8d77fab1466188e
Reviewed-on: https://chromium-review.googlesource.com/c/1282445Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599974}