GitLab

In theory this will reduce memory wasted by std::deque. It may also help diagnose
some puzzling crashes we've seen related to the immediate incomming and work queues.

BUG=674625, 674895
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2579773002
Cr-Commit-Position: refs/heads/master@{#443450}

BUG=680797
TEST=Win Intel HD 530 bot on GPU FYI waterfall
TBR=kbr@chromium.org,yunchao.he@intel.com
NOTRY=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2628883007
Cr-Commit-Position: refs/heads/master@{#443449}

The new search geolocation system slightly changes the way geolocation
permission work. This change updates the search engines UI to work with
the new system.

BUG=674398

Review-Url: https://codereview.chromium.org/2629523003
Cr-Commit-Position: refs/heads/master@{#443448}

BUG=661011

Review-Url: https://codereview.chromium.org/2626073006
Cr-Commit-Position: refs/heads/master@{#443447}

Objects implementing the DOMQuad interface represents a quadrilateral.
first, constructor was added in this CL.
and i will add other functions in follow up CL.

spec list:
https://drafts.fxtf.org/geometry/#domquad
https://drafts.fxtf.org/geometry/#dictdef-domquadinit

BUG=678237

Review-Url: https://codereview.chromium.org/2615653003
Cr-Commit-Position: refs/heads/master@{#443446}

fixed encodedBodySize/decodedBodySize/initiatorType for nav timing 2. Report initiatorType as "navigation" instead of an empty string.

BUG=675044,675042

Review-Url: https://codereview.chromium.org/2582863002
Cr-Commit-Position: refs/heads/master@{#443445}

Move the marking mode to VisitorHelper<>, so that
both Visitor and InlinedGlobalMarkingVisitor can access
and reuse it.

In order to do so, hoist out Visitor::MarkingMode as an
enum class.

R=
BUG=

Review-Url: https://codereview.chromium.org/2625363002
Cr-Commit-Position: refs/heads/master@{#443444}

The aim is to delete this code path entirely and the test hasn't been
run for years. Fixing it is not a priority.

BUG=324555
TBR=zmo@chromium.org

Review-Url: https://codereview.chromium.org/2633473003
Cr-Commit-Position: refs/heads/master@{#443443}

It seems Linux and Windows don't have correct expectation files now.

BUG=654999
TBR=keishi@chromiuj.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2630663002
Cr-Commit-Position: refs/heads/master@{#443442}

BUG=678077

Review-Url: https://codereview.chromium.org/2624333004
Cr-Commit-Position: refs/heads/master@{#443441}

The crash key was accidentally left unset when bad message dumps
were moved to the IO thread. This fixes that.

BUG=680542
R=creis@chromium.org

Review-Url: https://codereview.chromium.org/2629773002
Cr-Commit-Position: refs/heads/master@{#443440}

We currently prompt the user to re-enable a disabled hosted app if they
visit the corresponding site. However, this can be really annoying, and
confusing, since we don't offer much context on the choice, and don't
persist the preference.

This is offering relatively little value, and the site (if it wanted)
could detect and inform the user that the app wasn't enabled, and give
them sufficiently more context.

However, we should keep this when the user visits a chrome-extension
url - this is a much stronger signal, and we can't display anything else
anyway (whereas visiting a hosted app's site still shows the site).

This was never tested, so add some tests.

BUG=678631

Review-Url: https://codereview.chromium.org/2621953003
Cr-Commit-Position: refs/heads/master@{#443439}

This was timing out with the Mac renderer backgrounding experiment on
since it was taking too long for the backgrounded tab to wake up and
execute the necessary commands.

BUG=460102

Review-Url: https://codereview.chromium.org/2626293002
Cr-Commit-Position: refs/heads/master@{#443438}

BUG=668389

Review-Url: https://codereview.chromium.org/2628043003
Cr-Commit-Position: refs/heads/master@{#443437}

Rename
mapRectToDestinationSpace to sourceToDestinationRect
mapToVisualRectInDestinationSpace to sourceToDestinationVisualRect
localToVisualRectInAncestorSpace to localToAncestorVisualRect
so that all mapping methods are in the form
  (local|source|ancestor)To(local|source|ancestor)(Rect|VisualRect|Matrix|ClipRect)

Changed parameters to localToAncestorMatrix and getPrecomputedDataForAncestor()
from const PropertyTreeState& to const TransformPaintPropertyNode*
because some later changes will require the new form (
TransformationPaintPropertyNode without a state).

Simplified localToAncestorMatrix and localToAncestorClipRect because
we have early returns when the local node is the same as the ancestor
node and we no longer need to handle that condition in the loop.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2623823002
Cr-Commit-Position: refs/heads/master@{#443436}

This CL ensures chunk size is aligned with the FencedAllocator allocation size.

BUG=680150
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2623223002
Cr-Commit-Position: refs/heads/master@{#443435}

We fixed a bug that after changing the primary display, the desktop share
picker will mismatch the screen preview with screen name.

In this CL we fixed the bug.

BUG=680335

Review-Url: https://codereview.chromium.org/2627933003
Cr-Commit-Position: refs/heads/master@{#443434}

The purpose of this CL is to make it easier to edit results.html by
making it clearer which unit tests are failing.

This may make it slightly easier to work on http://crbug.com/664274.

Review-Url: https://codereview.chromium.org/2605103004
Cr-Commit-Position: refs/heads/master@{#443433}

BUG=680343

Review-Url: https://codereview.chromium.org/2625903006
Cr-Commit-Position: refs/heads/master@{#443432}

BUG=670422

Review-Url: https://codereview.chromium.org/2619653002
Cr-Commit-Position: refs/heads/master@{#443431}

R=tommycli@chromium.org
BUG=673953
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2629743002
Cr-Commit-Position: refs/heads/master@{#443430}

Showing the menu, resizing the browser window horizontally and then
showing the menu a second time could result in incorrectly positioning
the window, as position values from the first instance would affect
layout of the second instance. This fixes the issue by clearing position
alues before reshowing the menu.

BUG=667198
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2614663011
Cr-Commit-Position: refs/heads/master@{#443429}

Tests Logging In with correct/incorrect credentials and cancelling
authentication.

Also added cancelButton to chrome_matchers.

BUG=577395

Review-Url: https://codereview.chromium.org/2617393003
Cr-Commit-Position: refs/heads/master@{#443428}

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyScrollSnapCoordinate from the switch statement in
parseSingleValue, and calls the API instead.

A function pointer to the parseSingleValue function from the API for the
page property is stored in a CSSPropertyDescriptor, and is called from
CSSPropertyParser.

This patch:
- Adds CSSPropertyAPIScrollSnapCoordinate.cpp to the BUILD.gn file.
- Adds api_class flag to CSSProperties.in, which indicates that
  CSSPropertyAPIScrollSnapCoordinate.h is generated.
- Moves the parsing logic for page from CSSPropertyParser.cpp to
  CSSPropertyAPIScrollSnapCoordinate.cpp, which implements
  CSSPropertyAPI.h.

BUG=668012

Review-Url: https://codereview.chromium.org/2616833002
Cr-Commit-Position: refs/heads/master@{#443427}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/4bd0c43eba04..fe8a3c8a5cdb

$ git log 4bd0c43eb..fe8a3c8a5 --date=short --no-merges --format='%ad %ae %s'
2017-01-12 aiolos Unit refactor cl 3: Use UnitScales in Unit.html instead of UnitPrefixScales.
2017-01-12 simonhatch Make this a more generic step and remove any stale files.

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2627033004
Cr-Commit-Position: refs/heads/master@{#443426}

Currently, we use DictionaryValues in the Physical Web data source.
The problem with this is that we cannot store store longs (timestamps).
This change introduces a metadata struct that can be requested from the
data source, deprecating the DictionaryValue option.

BUG=667722

Review-Url: https://codereview.chromium.org/2561493002
Cr-Commit-Position: refs/heads/master@{#443425}

Just picked 10s arbitratily before we have a way to set this value via
Finch. Sending this out to see if collecting the average keyframe
distance and passing it via PipelineStatistics sounds reasonable.

BUG=663999
TEST=manual

Review-Url: https://codereview.chromium.org/2611333003
Cr-Commit-Position: refs/heads/master@{#443424}

The Download Home frontend shouldn't be directly talking
to the Downloads backend because it's missing information
about the downloads that are stored only on the Java side.
Instead, consult the Java sort-of-backend-but-not-really
shared preferences to know whether or not a download is
actually paused or not.

BUG=678099,651408

Review-Url: https://codereview.chromium.org/2623373002
Cr-Commit-Position: refs/heads/master@{#443423}

https://chromium.googlesource.com/angle/angle.git/+log/417df92..b4533de

BUG=680631

TBR=geofflang@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2629213002 .
Cr-Commit-Position: refs/heads/master@{#443422}

BUG=

Review-Url: https://codereview.chromium.org/2615753002
Cr-Commit-Position: refs/heads/master@{#443421}

BUG=680076

Review-Url: https://codereview.chromium.org/2623253002
Cr-Commit-Position: refs/heads/master@{#443420}

The Optional<> rewrite reversed the sign on extra margin space.

Also updated test expectations. Down to 165 failed from 207

BUG=635619

Review-Url: https://codereview.chromium.org/2623103002
Cr-Commit-Position: refs/heads/master@{#443419}

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyRotate from the switch statement in parseSingleValue,
and calls the API instead.

A function pointer to the parseSingleValue function from the API for the
page property is stored in a CSSPropertyDescriptor, and is called from
CSSPropertyParser.

This patch:
- Adds CSSPropertyAPIRotate.cpp to the BUILD.gn file.
- Adds api_class flag to CSSProperties.in, which indicates that
  CSSPropertyAPIRotate.h is generated.
- Moves the parsing logic for page from CSSPropertyParser.cpp to
  CSSPropertyAPIRotate.cpp, which implements CSSPropertyAPI.h.

BUG=668012

Review-Url: https://codereview.chromium.org/2614833003
Cr-Commit-Position: refs/heads/master@{#443418}

BUG=676196

Review-Url: https://codereview.chromium.org/2604213002
Cr-Commit-Position: refs/heads/master@{#443417}

Part of the removal of PassRefPtr.

Replaces many of the calls to RefPtr::release with a std::move wrap,
which returns a RefPtr instead of a PassRefPtr. As the code currently
stands, most methods still expect a PassRefPtr and so the PassRefPtr
initialising constructor will be called passing in the RefPtr rvalue,
which calls RefPtr::release anyway.

Future patches will see these variables changed from PassRefPtr to
RefPtr type then RefPtr::release will not be used at all.

Does not handle RefPtr::release of non member variables in return
statements as these cases sometimes default to move (in the case of
returning a local variable). These will be handled in future patches.

BUG=494719

Review-Url: https://codereview.chromium.org/2628773002
Cr-Commit-Position: refs/heads/master@{#443416}

TEST=no functionality change

Review-Url: https://codereview.chromium.org/2623273008
Cr-Commit-Position: refs/heads/master@{#443415}

This is a skeleton of a Chrome Windows Debugger extension that will
provide convenience commands for developers using ntsd, cdb, or windbg.

BUG=

Review-Url: https://codereview.chromium.org/2612193002
Cr-Commit-Position: refs/heads/master@{#443414}

Merge internal change 143128776

BUG=

Review-Url: https://codereview.chromium.org/2611613003
Cr-Commit-Position: refs/heads/master@{#443413}

Add the support for the updateArgumentsPostValidate custom hook, and
add tests for the same.

BUG=653596

Review-Url: https://codereview.chromium.org/2617423003
Cr-Commit-Position: refs/heads/master@{#443412}

BUG=505177

Review-Url: https://codereview.chromium.org/2571713005
Cr-Commit-Position: refs/heads/master@{#443411}