- 05 Sep, 2018 40 commits
-
-
Sam McNally authored
Bug: 877043 Change-Id: Iab18132a8c4750de0f7f96601f6232c41e3aaf54 Reviewed-on: https://chromium-review.googlesource.com/1194544Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Stuart Langley <slangley@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#588771}
-
Sam McNally authored
- Use DriveIntegrationService::GetMountPointPath() in GetDownloadLocationText() to get the Drive mount path. - Update the test to explicitly cover DriveFS-enabled and DriveFS-disabled cases. - Change DriveFsHost to return the expected mount path when unmounted. - Make test-only ProfileHelper methods public, making the list of friends mostly unnecessary. Bug: 879422 Change-Id: I162ef7e74d58b400d9242be599700c4491fba6c7 Reviewed-on: https://chromium-review.googlesource.com/1201632Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
-
Eriko Kurimoto authored
ChromeVox+O>E to enable logging. ChromeVox+O>D to disable logging. Bug: 880004 Change-Id: I25e618e1bb986432722b59cb7669808006bea354 Reviewed-on: https://chromium-review.googlesource.com/1201515Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Eriko Kurimoto <elkurin@google.com> Cr-Commit-Position: refs/heads/master@{#588769}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/85f4e40c5481..72a02112a99f git log 85f4e40c5481..72a02112a99f --date=short --no-merges --format='%ad %ae %s' 2018-09-05 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@72a02112a99f The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jvanverth@chromium.org Change-Id: Idec39d365bed5736c161d045f9a5e2ae7ac83e3c Reviewed-on: https://chromium-review.googlesource.com/1205618Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#588768}
-
Lei Zhang authored
Merge the two into content::GetAndroidOSInfo(), and update the that it is not actually available on Chrome OS. base: :SysInfo::HardwareModelName() header comment to reflect the fact Change-Id: I68573105d1025d701ea6c4b457d9ee5e0c033e38 Reviewed-on: https://chromium-review.googlesource.com/1198568Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#588767}
-
Raymes Khoury authored
Some content settings types don't support embedded patterns, however it's currently possible to set embedded patterns for these types. https://chromium-review.googlesource.com/c/chromium/src/+/1173192 stops this from being possible, however if these patterns were already written to a pref then they will still be there. This CL deletes those patterns. Bug: 802945 Change-Id: Ia7fd878ba3d1a635bb92215f0b6dbba04519a07c Reviewed-on: https://chromium-review.googlesource.com/1175518Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Raymes Khoury <raymes@chromium.org> Cr-Commit-Position: refs/heads/master@{#588766}
-
David Tseng authored
The braille cursor (when content is wrapped) persists even after the content to which is pertains changes. Prevent this from happening by explicitly omitting the cursor when the start/end index of the cursor is -1. Change-Id: I5a0dbeea9e73e3d60bef25e7fe68be2cc6d97f0d Reviewed-on: https://chromium-review.googlesource.com/1200362Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#588765}
-
Takuto Ikuta authored
Currently browser_tests on win7_chromium_rel_ng sometimes took more than 10 mins. Let me increase the number of shards for such tests. e.g 753s https://ci.chromium.org/b/8936390613165886176 732s https://ci.chromium.org/b/8936406831776876544 706s https://ci.chromium.org/b/8936396862731996176 704s https://ci.chromium.org/b/8936363432077079248 Bug: 868114 Change-Id: I9a7eb07ce2c58f5b03e5f39152dba7ac6101f11b Reviewed-on: https://chromium-review.googlesource.com/1203519 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#588764}
-
Tom Anderson authored
These macros don't add much besides saving a single GtkWidget* parameter to the corresponding CHROMEG_CALLBACK macros. R=sky Change-Id: Ia64bb5b6f96df3f33d7adc61a50781f73bf0ae1c Reviewed-on: https://chromium-review.googlesource.com/1205597Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#588763}
-
Chris Hall authored
Bug: 879943 Change-Id: I005e99857d2609ffed42bba5d5968c84a23ad7d5 Reviewed-on: https://chromium-review.googlesource.com/1201642Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Chris Hall <chrishall@chromium.org> Cr-Commit-Position: refs/heads/master@{#588762}
-
Chromium WPT Sync authored
Using wpt-import in Chromium f90f8c14. With Chromium commits locally applied on WPT: b691cab2 "Implement script and style attr/elem CSP directives" bde179ef "Revert "Implement script and style attr/elem CSP directives"" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/24076 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: hongchan@chromium.org, rtoy@chromium.org: external/wpt/webaudio NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: If993c8d3e6dac20ea831a5d1704a6097ab0d239a Reviewed-on: https://chromium-review.googlesource.com/1205473 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#588761}
-
Max Moroz authored
Calling os.path.realpath seems to be an overkill, as it is used either: - for various local paths like LLVM binaries dir, output dir, etc which are fine to be symlinks; - for report files produced by llvm-cov tool, which do not seem to ever have symlinks. Leaving os.path.realpath() in there might seem harmless, but apparently there are cases when it causes troubles, e.g.: https://github.com/google/oss-fuzz/pull/1777#issuecomment-417805976 Tested locally with https://crrev.com/c/1184048. Bug: 866943 Change-Id: I4224664ef3bf5b7eb3f1fd3605e9db0fff11833c Reviewed-on: https://chromium-review.googlesource.com/1205594Reviewed-by:
Abhishek Arya <inferno@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#588760}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/3d61ac27ae8f..cc0466301999 git log 3d61ac27ae8f..cc0466301999 --date=short --no-merges --format='%ad %ae %s' 2018-09-05 tobine@google.com Use chromium mirror for jsoncpp Created with: gclient setdep -r src/third_party/angle@cc0466301999 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fjhenigman@chromium.org Change-Id: I9cf9dbc945986c127dfd9b1428aad65a82d4cab7 Reviewed-on: https://chromium-review.googlesource.com/1205615Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#588759}
-
Luciano Pacheco authored
Add property names set to update event so event listeners can check if the metadata that they want has been updated in constant time. Add entriesMap to update event so event listeners can check if the relevant entry has been updated in constant time. These will be used in the directory_tree.js to update the 'shared' icon for sub-directories. Bug: 880187, 880189 Change-Id: I5bb21e8b82b208c8d971e3193840f8b6afb8546e Reviewed-on: https://chromium-review.googlesource.com/1203352Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
Fabio Tirelo authored
Currently, the refresh on Android is controlled by the same flag as on Desktop, which prevents us from enabling it by default. Bug: 874077 Change-Id: Ifd13ae50e243e605ecdcb2742fefa555b9be2a35 Reviewed-on: https://chromium-review.googlesource.com/1204834 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#588757}
-
Eriko Kurimoto authored
Bug: 816369 Test: None Change-Id: I9159fdfbe8fe9c156306e5e5783384f386d13654 Reviewed-on: https://chromium-review.googlesource.com/1195301Reviewed-by:
Yuki Awano <yawano@chromium.org> Commit-Queue: Eriko Kurimoto <elkurin@google.com> Cr-Commit-Position: refs/heads/master@{#588756}
-
Kent Tamura authored
- fast/forms/suggestion-picker/date-suggestion-picker-appearance-zoom125.html - fast/forms/suggestion-picker/date-suggestion-picker-appearance-zoom200.html - virtual/scalefactor150/fast/hidpi/static/data-suggestion-picker-appearance.html - virtual/scalefactor200withzoom/fast/hidpi/static/data-suggestion-picker-appearance.html - virtual/scalefactor200/fast/hidpi/static/data-suggestion-picker-appearance.html They are marked as flaky, but they fail consistently. We'd like to check if they are still flaky after this rebaseline. TBR=yosin@chromium.org Bug: 681468 Change-Id: I1cccc27a70b7585ca0221bcf17ea1b24dbf1980f Reviewed-on: https://chromium-review.googlesource.com/1205911Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#588755}
-
Scott Chen authored
Bug: 832933 Change-Id: I86a97c2fcca2d00064a5ac72304c7a1e8591c703 Reviewed-on: https://chromium-review.googlesource.com/1187725 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#588754}
-
Paul Irish authored
Many tracing consumers collect the toplevel category only for this event, however the toplevel category is very chatty (~25-50% of a trace's bytes). This will allow downstream tools to collect much smaller traces. Bug: 874982 Change-Id: Ib41ded90f120ba9a703a10f83320d0d10233ed13 Reviewed-on: https://chromium-review.googlesource.com/791314 Commit-Queue: Paul Irish <paulirish@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#588753}
-
Paul Irish authored
Bug: 880555 Change-Id: I997fc1e8665c1cdee38c626bf6652fb5e792651c Reviewed-on: https://chromium-review.googlesource.com/1205374 Commit-Queue: Paul Irish <paulirish@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#588752}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=amineer@chromium.org Change-Id: I1699a38fd1c9b8f00c3e3e300551b97c52d06923 Reviewed-on: https://chromium-review.googlesource.com/1205721Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#588751}
-
yoshiki iguchi authored
This CL fixes the issue by calling SetFillsBoundsOpaquely(false). Bug: 876455 Test: manual (observe no issue) Change-Id: I2f139657de8ca0a34022f3085b9a544941385b0d Reviewed-on: https://chromium-review.googlesource.com/1203790Reviewed-by:
Eliot Courtney <edcourtney@chromium.org> Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#588750}
-
Scott Chen authored
Change-Id: I03fef99aaf7b23d9a05a96a46113a913ba7e575a Reviewed-on: https://chromium-review.googlesource.com/1188760Reviewed-by:
-
Yuki Yamada authored
This CL add new class blink::V8EventListenerImpl which implements ONLY EventListener (not EventHandler). It has a blink::V8EventListener which inherits blink::CallbackInterfaceBase. As a result, EventListener will start to handle incumbent realm. EventHandler will still be offered by blink::V8AbstractEventListener (this class is renamed to blink::V8AbstractEventHandler in this CL) after this CL submitted. Also, entry realm was set to wrong one (event target's one) with blink::V8AbstractEventLisntener so this CL set it to listener's one as defined in standard. Regarding crbug.com/872138 : Current blink::V8AbstractEventListener implements both of EventListener and EventHandler, so I am trying to implement new class for EventListener first to separate these. EventHandler will be modified in following CLs. Regarding crbug.com/878658 : This CL modifies expectation file for layout test: fast/events/touch/gesture/gesture-tap-frame-removed.html This is because event listener starts to remember incumbent realm after this CL and it results in incorrect behavior as explained in the BUG. This is not a regression, but have to be resolved in following CLs. Bug: 872138, 878658, 606900, 849236 Change-Id: I4bf7fe2f4fd51287f873c2377edfd57e4bb2a54a Reviewed-on: https://chromium-review.googlesource.com/1172234 Commit-Queue: Yuki Yamada <yukiy@google.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#588748}
-
Hidy Han authored
Previously we reported absolute bounding boxes relative to the frame origin, which takes into account current scroll position. This is inconvenient for clients who prefer the document coordinate space. This patch starts reporting layout nodes' bounding boxes relative to the document origin, along with scroll offsets on the Document itself. Change-Id: Iced39f9ee32ee06387372069d66bd427101033af Reviewed-on: https://chromium-review.googlesource.com/1173717 Commit-Queue: Hidy Han <hidyhan@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#588747}
-
rbpotter authored
Add automated test to verify that there are 2 buttons in the print header and they are in the correct order for all platforms. Split off parent CL, which contains a fix for the bug linked. Bug: 880562 Change-Id: I3472561dd1af7e75a86bf4821fb4ae42e82a0d5f Reviewed-on: https://chromium-review.googlesource.com/1205717Reviewed-by:
Scott Chen <scottchen@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#588746}
-
rbpotter authored
Print button should be on the left on Windows and Chrome OS. Bug: 880562 Change-Id: If4a0cec12e506846444f753361653b7407db99e7 Reviewed-on: https://chromium-review.googlesource.com/1205201Reviewed-by:
-
Tarun Bansal authored
Show a console warning message when the page load is expected to be slow, and when loading of a non-critical resource is requested and the loading is blocked. This resource blocking experience is offered only to data saver users. Bug: 864253 Change-Id: Ie77466dfac9c64e5e2ae6504732c099e4f8726ce Reviewed-on: https://chromium-review.googlesource.com/1199613Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Scott Little <sclittle@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#588744}
-
Han Leon authored
Currently blink.mojom.NotificationResources is typemapped with content::NotificationResources, and its struct traits impl depends on content/public/common/content_features.h to do some custom validation against the notification image, which makes it hard to move these struct traits into Blink. This CL moves such validation out of struct traits to the receiver of messages : content::BlinkNotificationServiceImpl. BUG=595685 Change-Id: I5b2990da087d7e2e3ba30e80973d396632b5d15b Reviewed-on: https://chromium-review.googlesource.com/1201903Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Han Leon <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#588743}
-
Krishna Govind authored
R=abdulsyed@chromium.org Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ib226ee4390eecb7978650bae611338d016787b97 Reviewed-on: https://chromium-review.googlesource.com/1206000Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#588742}
-
Weilun Shi authored
When the custom link tile gets modified(add/edit/delete), focusing on the undo button on the notification bar. Using tab on undo button can navigate to restore button as well. Bug: 873978, 865840 Change-Id: Idf8420d3622e645e8980fc40be5682028daf8638 Reviewed-on: https://chromium-review.googlesource.com/1188492Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Weilun Shi <sweilun@chromium.org> Cr-Commit-Position: refs/heads/master@{#588741}
-
Zhenyao Mo authored
BUG=838970 TEST=waterfall R=kbr@chromium.org Change-Id: Ic4f9fba1b7b858ee17b8898a4457810c7a167f90 Reviewed-on: https://chromium-review.googlesource.com/1200464Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#588740}
-
Takashi Sakamoto authored
This reverts commit d560cc69. Reason for revert: Suspect the following failures: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64%20%28dbg%29/2918 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20CFI/9944 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20CFI/2770 failures: SeededInMemoryDBTest.ReadExpectingSeedData SeededInMemoryDBTest.SeedReadFailureOnAppendingingStats SeededInMemoryDBTest.ReadExpectingEmpty SeededInMemoryDBTest.AppendReadAndDestroy SeededInMemoryDBTest.SeedReadFailureOnGettingStats E.g. (Windows Debug's stacktrace) [ RUN ] SeededInMemoryDBTest.ReadExpectingSeedData [11444:9464:0904/170819.496:19096421:FATAL:video_decode_stats_db_impl.h(73)] Check failed: !dependent_db_ || !dependent. Backtrace: base::debug::StackTrace::StackTrace [0x00007FFB88491915+101] base::debug::StackTrace::StackTrace [0x00007FFB8849094F+31] logging::LogMessage::~LogMessage [0x00007FFB884F91C6+134] media::VideoDecodeStatsDBImpl::set_dependent_db [0x00007FFB84861AF6+182] media::InMemoryVideoDecodeStatsDBImpl::OnGotSeedDB [0x00007FFB84862A9F+623] base::internal::FunctorTraits<void (__cdecl media::InMemoryVideoDecodeStatsDBImpl::*)(base::OnceCallback<void __cdecl(bool)>,media::VideoDecodeStatsDB * __ptr64) __ptr64,void>::Invoke<void (__cdecl media::InMemoryVideoDecodeStatsDBImpl::*)(base::OnceCallb [0x00007FFB84867808+136] base::internal::InvokeHelper<1,void>::MakeItSo<void (__cdecl media::InMemoryVideoDecodeStatsDBImpl::*)(base::OnceCallback<void __cdecl(bool)>,media::VideoDecodeStatsDB * __ptr64) __ptr64,base::WeakPtr<media::InMemoryVideoDecodeStatsDBImpl>,base::OnceCallb [0x00007FFB848676BD+125] base::internal::Invoker<base::internal::BindState<void (__cdecl media::InMemoryVideoDecodeStatsDBImpl::*)(base::OnceCallback<void __cdecl(bool)>,media::VideoDecodeStatsDB * __ptr64) __ptr64,base::WeakPtr<media::InMemoryVideoDecodeStatsDBImpl>,base::OnceCa [0x00007FFB84867606+134] base::internal::Invoker<base::internal::BindState<void (__cdecl media::InMemoryVideoDecodeStatsDBImpl::*)(base::OnceCallback<void __cdecl(bool)>,media::VideoDecodeStatsDB * __ptr64) __ptr64,base::WeakPtr<media::InMemoryVideoDecodeStatsDBImpl>,base::OnceCa [0x00007FFB8486745E+110] base::OnceCallback<void __cdecl(media::VideoDecodeStatsDB * __ptr64)>::Run [0x00007FF7E2DDF071+129] `media::InMemoryDBTestBase<1>::InMemoryDBTestBase<1>'::`1'::<lambda_1>::operator() [0x00007FF7E2DF2FB6+70] std::_Invoker_functor::_Call<`media::InMemoryDBTestBase<1>::InMemoryDBTestBase<1>'::`1'::<lambda_1> & __ptr64,base::OnceCallback<void __cdecl(media::VideoDecodeStatsDB * __ptr64)> > [0x00007FF7E2DF2F57+87] std::invoke<`media::InMemoryDBTestBase<1>::InMemoryDBTestBase<1>'::`1'::<lambda_1> & __ptr64,base::OnceCallback<void __cdecl(media::VideoDecodeStatsDB * __ptr64)> > [0x00007FF7E2DF2EE4+52] std::_Invoker_ret<void,1>::_Call<`media::InMemoryDBTestBase<1>::InMemoryDBTestBase<1>'::`1'::<lambda_1> & __ptr64,base::OnceCallback<void __cdecl(media::VideoDecodeStatsDB * __ptr64)> > [0x00007FF7E2DF2EA4+52] std::_Func_impl_no_alloc<`media::InMemoryDBTestBase<1>::InMemoryDBTestBase<1>'::`1'::<lambda_1>,void,base::OnceCallback<void __cdecl(media::VideoDecodeStatsDB * __ptr64)> >::_Do_call [0x00007FF7E2DF2D36+54] std::_Func_class<void,base::OnceCallback<void __cdecl(media::VideoDecodeStatsDB * __ptr64)> >::operator() [0x00007FF7E2DF122C+108] testing::internal::ApplyImpl<std::function<void __cdecl(base::OnceCallback<void __cdecl(media::VideoDecodeStatsDB * __ptr64)>)> const & __ptr64,std::tuple<base::OnceCallback<void __cdecl(media::VideoDecodeStatsDB * __ptr64)> >,0> [0x00007FF7E2DF1184+100] testing::internal::Apply<std::function<void __cdecl(base::OnceCallback<void __cdecl(media::VideoDecodeStatsDB * __ptr64)>)> const & __ptr64,std::tuple<base::OnceCallback<void __cdecl(media::VideoDecodeStatsDB * __ptr64)> > > [0x00007FF7E2DF10E9+57] testing::Action<void __cdecl(base::OnceCallback<void __cdecl(media::VideoDecodeStatsDB * __ptr64)>)>::Perform [0x00007FF7E2DF0C9D+109] testing::internal::FunctionMockerBase<void __cdecl(base::OnceCallback<void __cdecl(media::VideoDecodeStatsDB * __ptr64)>)>::PerformDefaultAction [0x00007FF7E2DF09A2+130] testing::internal::ActionResultHolder<void>::PerformDefaultAction<void __cdecl(base::OnceCallback<void __cdecl(media::VideoDecodeStatsDB * __ptr64)>)> [0x00007FF7E2DF08D6+70] testing::internal::FunctionMockerBase<void __cdecl(base::OnceCallback<void __cdecl(media::VideoDecodeStatsDB * __ptr64)>)>::UntypedPerformDefaultAction [0x00007FF7E2DF03C0+80] testing::internal::UntypedFunctionMockerBase::UntypedInvokeWith [0x00007FF7E38D811E+1390] testing::internal::FunctionMockerBase<void __cdecl(base::OnceCallback<void __cdecl(media::VideoDecodeStatsDB * __ptr64)>)>::InvokeWith [0x00007FF7E2DF28C9+57] testing::internal::FunctionMocker<void __cdecl(base::OnceCallback<void __cdecl(media::VideoDecodeStatsDB * __ptr64)>)>::Invoke [0x00007FF7E2DF2860+80] media::MockDBProvider::GetVideoDecodeStatsDB [0x00007FF7E2DF00D9+121] media::InMemoryVideoDecodeStatsDBImpl::Initialize [0x00007FFB848625BA+650] media::InMemoryDBTestBase<1>::InitializeEmptyDB [0x00007FF7E2DD357E+510] media::SeededInMemoryDBTest_ReadExpectingSeedData_Test::TestBody [0x00007FF7E2DD3EE9+57] testing::internal::HandleExceptionsInMethodIfSupported<testing::Test,void> [0x00007FF7E3910FAF+79] testing::Test::Run [0x00007FF7E3910F1C+172] testing::TestInfo::Run [0x00007FF7E3911BDA+218] testing::TestCase::Run [0x00007FF7E3912793+243] testing::internal::UnitTestImpl::RunAllTests [0x00007FF7E391C44D+765] testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl,bool> [0x00007FF7E391C135+85] testing::UnitTest::Run [0x00007FF7E391BF73+307] RUN_ALL_TESTS [0x00007FF7E492D2A1+17] base::TestSuite::Run [0x00007FF7E492C883+163] ??$Invoke@P8TestSuite@base@@EAAHXZPEAVTestSuiteNoAtExit@@$$V@?$FunctorTraits@P8TestSuite@base@@EAAHXZX@internal@base@@SAHP8TestSuite@2@EAAHXZ$$QEAPEAVTestSuiteNoAtExit@@@Z [0x00007FF7E38366AA+26] base::internal::InvokeHelper<0,int>::MakeItSo<int (__cdecl base::TestSuite::*const & __ptr64)(void) __ptr64,TestSuiteNoAtExit * __ptr64> [0x00007FF7E3836624+52] base::internal::Invoker<base::internal::BindState<int (__cdecl base::TestSuite::*)(void) __ptr64,base::internal::UnretainedWrapper<TestSuiteNoAtExit> >,int __cdecl(void)>::RunImpl<int (__cdecl base::TestSuite::*const & __ptr64)(void) __ptr64,std::tuple<ba [0x00007FF7E38365C8+88] base::internal::Invoker<base::internal::BindState<int (__cdecl base::TestSuite::*)(void) __ptr64,base::internal::UnretainedWrapper<TestSuiteNoAtExit> >,int __cdecl(void)>::Run [0x00007FF7E383649C+60] base::OnceCallback<int __cdecl(void)>::Run [0x00007FF7E49355C2+98] base::LaunchUnitTests [0x00007FF7E4933500+752] base::LaunchUnitTests [0x00007FF7E493330D+253] main [0x00007FF7E38360CE+158] invoke_main [0x00007FF7E4FA3DC4+52] (f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:79) __scrt_common_main_seh [0x00007FF7E4FA3EF4+292] (f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:283) __scrt_common_main [0x00007FF7E4FA3F7E+14] (f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:326) mainCRTStartup [0x00007FF7E4FA3F99+9] (f:\dd\vctools\crt\vcstartup\src\startup\exe_main.cpp:17) BaseThreadInitThunk [0x00007FFBA6BB2774+20] RtlUserThreadStart [0x00007FFBA77E0D51+33] Original change's description: > Add destruction observer to catch VideoDecodeStatsDB UAF > > This re-instates the behavior where Incognito profiles have their > in-memory DB seeded by the on-disk DB of the original profile. This > was temporarily disabled to fix the UAF for M69 release. > > This CL adds a CHECK in the destructor of seed DB which will fire > whenever it it is destroyed while a dependent in-memory DB is still > alive. > > Bug: 865321 > Test: new unit test, manual testing. > Change-Id: I5b3864347f51a0ecfc3e479b1bd84bd7160ef817 > Reviewed-on: https://chromium-review.googlesource.com/1169171 > Reviewed-by: David Roger <droger@chromium.org> > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> > Cr-Commit-Position: refs/heads/master@{#588599} TBR=droger@chromium.org,mlamouri@chromium.org,chcunningham@chromium.org Change-Id: Ia03835fe66559d0429b1969748ec8465482de570 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 865321 Reviewed-on: https://chromium-review.googlesource.com/1205913Reviewed-by:
Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#588739}
-
Katie D authored
This helps users who cannot see small or low contrast input controls know what state they are in. The change also cleans up how a node is translated into text so that in the future we can more easily add special casing for other node roles. Bug: 826954 Change-Id: I551fcf3b8cf427a78de0c1fb3f3727cd0186a2c2 Reviewed-on: https://chromium-review.googlesource.com/1197909 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
-
Kevin Marshall authored
Fixes SDK breakage by moving from using ComponentController:Wait() to the OnTerminated event instead. Roll SDK to 019ae3dbfc4384f2e656f41490d7a735fc117ab4. Bug: 707030 Change-Id: I2d29299e7454087e388e4f6b499b4803fde8c625 Reviewed-on: https://chromium-review.googlesource.com/1205570 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#588737}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/fddc6fa394cb..85f4e40c5481 git log fddc6fa394cb..85f4e40c5481 --date=short --no-merges --format='%ad %ae %s' 2018-09-04 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 913ff54db050..3d61ac27ae8f (2 commits) Created with: gclient setdep -r src/third_party/skia@85f4e40c5481 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jvanverth@chromium.org Change-Id: I7db76ed032e98663ce77949cb9cf2e61e7c9e394 Reviewed-on: https://chromium-review.googlesource.com/1205595Reviewed-by:
-
Pavel Feldman authored
Change-Id: I8b324ad45e38a3941ae2148e573390f7cc13270f Reviewed-on: https://chromium-review.googlesource.com/1205804 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
-
Andrew Grieve authored
Also: * Default the arg to true for all release builds that contain debug info. (most bots set strip_debug_info=true though) * Add better failure messages for when no debug info is present. Bug: 864878 Change-Id: Ied849d6e24a672b896c802be6df6c0958ecabfe0 Reviewed-on: https://chromium-review.googlesource.com/1142193 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#588734}
-
David Bertoni authored
ManfestHandlerRegistry::SortManifestHandlers() uses std::set to hold pointers to the unsorted handlers while it's building the priority map of handlers. This about 6x slower than just putting the pointers into a vector and there is no need for any of the properties of std::set (fast key lookup, uniqueness). Bug: 847237 Change-Id: Ia55b53de929fb7ee782e36be5b4002bc988da4c9 Reviewed-on: https://chromium-review.googlesource.com/1204604 Commit-Queue: David Bertoni <dbertoni@chromium.org> Reviewed-by:
-
Giovanni Ortuño Urquidi authored
Sets Manifest::EXTERNAL_PREF_DOWNLOAD as the Manifest::Location for default apps. This way, when a user uninstall a default app, we'll save this user decision in a pref and avoid installing the app in the future. Also changes the location for policy apps to MANIFEST::EXTERNAL_POLICY_DOWNLOAD, to be consistent with default apps' location. Bug: 878663 Change-Id: I3930feb146f2b7e7c92052d983f23d18b3f5ab95 Reviewed-on: https://chromium-review.googlesource.com/1198715 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
-
