- 13 Jan, 2018 40 commits
-
-
Nicolas Pena authored
Bug: 799929 Change-Id: Ibbd51642556f25aa8d0c1772923dc32d9de62d2c Reviewed-on: https://chromium-review.googlesource.com/865097 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#529166}
-
Paul Irish authored
Also improve dark mode styles Bug: 772558 Change-Id: Ifb61b0039f96d290c6151302a982c333b49549ea Reviewed-on: https://chromium-review.googlesource.com/865817Reviewed-by:
Will Chen <chenwilliam@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Paul Irish <paulirish@chromium.org> Cr-Commit-Position: refs/heads/master@{#529165}
-
Wei Li authored
Custom data op allows users to draw placeholders into paint op buffer. These placeholders can later be replaced with user supplied contents through calling user provided callback function. This is useful for printing out of process iframes, whose content is painted from another process. BUG=455764 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I79a113ea10e9d2072676030342332b773877fa14 Reviewed-on: https://chromium-review.googlesource.com/862897 Commit-Queue: Wei Li <weili@chromium.org> Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#529164}
-
Chris Harrelson authored
Bug: 400589 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I7044e42875cd75b28c20fa1509eca0df2c45e195 Reviewed-on: https://chromium-review.googlesource.com/864560Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#529163}
-
Ilya Sherman authored
In a follow-up CL, the safe seed will be used as a fallback in case a newer seed results in breakage that prevents us from successfully fetching updated seeds. Bug: 727984 Change-Id: I3a273fa79595e63f88955081df661b209b13aa35 Reviewed-on: https://chromium-review.googlesource.com/830661 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#529162}
-
Kenneth Russell authored
external/wpt/resource-timing/test_resource_timing.html external/wpt/service-workers/service-worker/navigation-preload/ resource-timing.https.html TBR=skyostil@chromium.org Bug: 799127 Change-Id: Ic33582def383537ee74cea4953de3053c110b2c0 Reviewed-on: https://chromium-review.googlesource.com/865573Reviewed-by:Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#529161}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/27b07316..85e8a6fc Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Iebb988ec4323ed51cb42f56693cfb8a5d6d3baa1 Reviewed-on: https://chromium-review.googlesource.com/866056Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#529160}
-
Vladimir Levin authored
This patch serializes PaintShaders of kImage type (backed by PaintImages). R=enne@chromium.org, ericrk@chromium.org Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I46384a879aac0b4bff7321b3ad20aac97dd8e069 Reviewed-on: https://chromium-review.googlesource.com/865879 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#529159}
-
Peter Collingbourne authored
Fixes crashes on older devices in component builds of chrome_sync_shell_test_apk when linked with lld. Bug: 742655 Change-Id: Iafcb6fe797f9aa382a6115dad0b3fd43acbbef19 Reviewed-on: https://chromium-review.googlesource.com/866112Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#529158}
-
chrome-release-bot authored
TBR=govind@chromium.org Change-Id: I120536f3b249860518d15c32ce8cda4511fbb3c5 Reviewed-on: https://chromium-review.googlesource.com/865976Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#529157}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 3f265ba8. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/9963 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: drott@chromium.org, kojii@chromium.org: external/wpt/css/css-fonts TBR=robertma No-Export: true Change-Id: I88ccaafdddc8e0e3845b722c5de01ed6a6c0e285 Reviewed-on: https://chromium-review.googlesource.com/865659 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#529156}
-
Lukasz Anforowicz authored
DEBUG_ALIAS_FOR_CSTR was introduced in r527458 as a helper macro for implementing DEBUG_ALIAS_FOR_ORIGIN. This CL moves the DEBUG_ALIAS_FOR_CSTR macrodefinition into //base/debug/alias.h. Additionally, the CL: - Uses the DEBUG_ALIAS_FOR_CSTR macro to replace some existing uses of base::debug::Alias + strlcpu - Introduces DEBUG_ALIAS_FOR_GURL macro (and unittests) and uses it in 5 places (where base::debug::Alias + strlcpy was used before) Bug: 797968 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I986ea90243f58768177a9ea68a7e2440eaa317c4 Reviewed-on: https://chromium-review.googlesource.com/857815 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Brett Wilson <brettw@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#529155}
-
Zhenyao Mo authored
BUG=801331 TEST=GPU bots R=kbr@chromium.org Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I1eb337e5b41aa7b74d0aaa27c0d064f1fed7ba78 Reviewed-on: https://chromium-review.googlesource.com/865814Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#529154}
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/57f4b73ebe08..dda048cdc9a6 $ git log 57f4b73eb..dda048cdc --date=short --no-merges --format='%ad %ae %s' 2018-01-11 fjhenigman Make scripts executable by python2. Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: Ic22da4f3d2c60bb7ec6b3d7843b96750993d23ef Reviewed-on: https://chromium-review.googlesource.com/865477 Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Reviewed-by:
angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#529153}
-
Zhuoyu Qian authored
This patch makes CSSBoxType to be an enum class for better type safety. Bug: 684966 Signed-off-by:
Zhuoyu Qian <zhuoyu.qian@samsung.com> Change-Id: I5d356eeff2794ab6fe75781d37490fd7df54657b Reviewed-on: https://chromium-review.googlesource.com/861591Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#529152}
-
Ilya Sherman authored
BUG=861345 R=miu@chromium.org Change-Id: Id85916ac1b72341f8016a80b4e2499752c21da36 Reviewed-on: https://chromium-review.googlesource.com/865437Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#529151}
-
Weidong Guo authored
Changes: 1. Add an API to turn on/off mixed mirror mode. In mixed mode, specified source display is mirrored to specified destination displays while other displays are extended. 2. Merge the mixed mirror mode with regular mirror mode API. 2. Store mixed mirror mode parameters in local state, so that the mixed mirror mode can be restored. Bug: 789746 Change-Id: I0ec28f7c114864589277a89a398009a636d53bd9 Reviewed-on: https://chromium-review.googlesource.com/844058Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#529150}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/7b8b8f53..27b07316 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I66500863b094b093606af9833bab7f3bc7abff92 Reviewed-on: https://chromium-review.googlesource.com/865660Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#529149}
-
Khushal authored
Follow up patch for remaining comments on [1]. [1]: https://chromium-review.googlesource.com/c/chromium/src/+/863105 R=vmpstr@chromium.org Bug: 777636 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I9b118e8fb097d6594879b334921299d340f4cc0a Reviewed-on: https://chromium-review.googlesource.com/865464Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#529148}
-
Joel Einbinder authored
Bug: 760316 Change-Id: I101c3e375c1a85c8ed5139a357b0068e7f7eb122 Reviewed-on: https://chromium-review.googlesource.com/861252Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#529147}
-
Pavel Feldman authored
This change generalizes devtools_frame_token to be available on Frame rather than LocalFrame. This is essential for traceability from the remote frame owners to the actual targets containing the local frames. Bug: 800613, 800112 Change-Id: Ic615515f64d140b8868c7a007c2954786f751a73 Reviewed-on: https://chromium-review.googlesource.com/864631 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#529146}
-
Randy Smith authored
Bug: 785420 Change-Id: Icc6bf5a17290e714d6f3ed49f3bda0dd4cf22efb Reviewed-on: https://chromium-review.googlesource.com/852385 Commit-Queue: Randy Smith <rdsmith@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#529145}
-
Daniel Murphy authored
Bug: 781955 Change-Id: I69fbecf1d23a78068351291a7ef0c345d4f2028f Reviewed-on: https://chromium-review.googlesource.com/818886Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#529144}
-
Wenzhao Zang authored
Bug: 800548 Change-Id: I14e79f4ba46a0d007c9cc29f695586e553fe1b8b Reviewed-on: https://chromium-review.googlesource.com/858175Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#529143}
-
Alexey Kozyatinskiy authored
We need async stacks instrumentation for MessageChannel.postMessage. To achieve this goal we capture stack trace at postMessage call and send stack trace id to another iframe where is stack trace id is used as async tail of current stack trace inside onmessage handler. With instrumentation DevTools can trace onmessage handler to the corresponded postMessage call inside another frame and it is possible to make step-into action to go directly into onmessage handler from postMessage call. R=alph@chromium.org Bug: chromium:661705 Change-Id: If4a8cd3a94f914a091b351c1607e5fd16b739b23 Reviewed-on: https://chromium-review.googlesource.com/792499 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#529142}
-
Dale Curtis authored
http://crrev.com/528719 forgot to include the CDM wrapper decoders: DecryptingAudioDecoder and DecryptingVideoDecoder. These will now have enum values of 3 and 6 respectively. BUG=793151 TEST=no more unknown decoder warning for Netflix. Change-Id: I8d8ff1bf11dfe1ddb5fc0b58f60fba1a6cee0c28 Reviewed-on: https://chromium-review.googlesource.com/865823Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#529141}
-
Peter Kasting authored
This will probably be rarely used, but seems harmless, and could result in slightly clearer code sometimes. An example change is included. BUG=none TEST=none Change-Id: Id11fb1e0d41ffd93fa12d770e44a3c165ea30735 Reviewed-on: https://chromium-review.googlesource.com/855639Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#529140}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/14e77443e92c..e11ef0ce9f3b $ git log 14e77443e..e11ef0ce9 --date=short --no-merges --format='%ad %ae %s' 2018-01-12 thestig Fix some nits in fxbarcode. 2018-01-12 thestig Add jumbo build support for fxbarcode. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ice42fc8a1033d3cb12f5c08da05ea3fb512e14bb Reviewed-on: https://chromium-review.googlesource.com/865853 Commit-Queue: <pdfium-deps-roller@chromium.org> Reviewed-by: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#529139}
-
Fady Samuel authored
With this CL, SurfaceManager::GetLatestInFlightSurface supports child sequence numbers when determining what surface to return as a valid (ordering- wise) in-flight surface. Bug: 672962 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I0de241435ba57b9d4420b2629e32a21af9898643 Reviewed-on: https://chromium-review.googlesource.com/862637 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#529138}
-
Takuto Ikuta authored
Creating and deleting rsp files is time consuming part when building on windows with warmed goma backend cache. To reduce such bottleneck, we can use all compiler flags directory in command line instead of using rsp file. This CL keeps using rsp file for linking because linking flags can be longer than compiles and the number of linking is relatively small compared to compile. I took 3 time build stats for 'chrome' on 48 thread Z840 windows 10 with following args.gn and -j 500. ``` goma_dir = "C:\\src\\goma_client\\client\\out\\Release" is_component_build = true is_debug = false strip_absolute_paths_from_debug_symbols = true symbol_level = 0 target_cpu = "x86" use_goma = true is_clang = false enable_nacl = false use_lld = true ``` * With this CL TotalSeconds: 279.9604737 TotalSeconds: 279.4099064 TotalSeconds: 273.8253059 Avg: 277.731895333333 * Without this CL TotalSeconds: 325.0155664 TotalSeconds: 319.4094433 TotalSeconds: 299.9709 Avg: 314.798636566667 Bug: 796021 Change-Id: Ice959c196b6879b39962a3b628cdcf531884ec36 Reviewed-on: https://chromium-review.googlesource.com/832593Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#529137}
-
Benjamin Pastene authored
Bug: 787056 Change-Id: I72a6963340f56b2483a05167ccdcc078420479f4 Reviewed-on: https://chromium-review.googlesource.com/865434Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Benjamin Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#529136}
-
Elad Alon authored
This reverts commit ce383b56. Reason for revert: Fix the build-break introduced by the original CL and reland. Original change's description: > Revert "Move ownership of WebRTCInternals to BrowserMainLoop" > > This reverts commit 0823211e. > > Reason for revert: Compile on Cast Audio Linux broke > https://ci.chromium.org/buildbot/chromium.linux/Cast%20Audio%20Linux/7958 > > Log message: > error: undefined symbol: content::WebRTCInternals::CreateSingletonInstance() > >>> referenced by browser_main_loop.cc:1572 (../../content/browser/browser_main_loop.cc:1572) > > Original change's description: > > Move ownership of WebRTCInternals to BrowserMainLoop > > > > WebRTCInternals was a lazily-constructed singleton. This CL changes > > this, to allow a similar change in WebRtcEventLogManager, where this > > lazy construction (and subsequent leaking) created problems for > > unit tests due to WebRtcEventLogManager's task runner. (The change > > to WebRtcEventLogManager will be done in a separate, subsequent CL.) > > > > Piggy-backed on this - plug the leak in DownloadProtectionServiceTest.VerifyReferrerChainWithEmptyNavigationHistory > > > > Bug: 775415, 800404, 792847 > > Change-Id: Iddc2569933b83bbe3a4e16c161ac531748448477 > > Reviewed-on: https://chromium-review.googlesource.com/857470 > > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > > Commit-Queue: Elad Alon <eladalon@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#528597} > > TBR=jam@chromium.org,terelius@chromium.org,eladalon@chromium.org > > Change-Id: Ifdeac7829d2d0e940ed938555793f38410d30272 > Bug: 775415, 800404, 792847 > Reviewed-on: https://chromium-review.googlesource.com/860062 > Reviewed-by: Friedrich Horschig <fhorschig@chromium.org> > Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> > Cr-Commit-Position: refs/heads/master@{#528608} TBR=jam@chromium.org,terelius@chromium.org,fhorschig@chromium.org,eladalon@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:cast_shell_audio_linux,fuchsia_arm64_cast_audio,fuchsia_x64_cast_audio No-Try: true Bug: 775415, 800404, 792847 Change-Id: I28f34f417cfde490710a82a3e29711a0f1e9b15c Reviewed-on: https://chromium-review.googlesource.com/860404 Commit-Queue: Elad Alon <eladalon@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Friedrich Horschig <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#529135}
-
Matt Wolenetz authored
Now that known range adjacency issues have been fixed (previous fixes in bug 791095), this change increases the strength of IsRangeListSorted() to ensure that the ranges' presentation intervals (in DTS if buffering ByDTS, in PTS if buffering ByPTS) are sorted and disjoint. This strengthened logic caught the known errors fixed by prereq CL https://chromium-review.googlesource.com/c/chromium/src/+/865849. Also, the check for sorted ranges is moved from ::RemoveInternal to ::Remove, because it is possible that interim |ranges_| state may have abutting, non-overlapping, ranges during the scope of ::Append processing. BUG=791095 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Iccd018f88ba773a8e8ec21b97f975c2f872024b9 Reviewed-on: https://chromium-review.googlesource.com/865826 Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#529134}
-
Shimi Zhang authored
For easier control on the feature. Enabled by default. Bug: 798017 Change-Id: Ia87870c822c9086e92083a0f9deb23a7bfe2a7c0 Reviewed-on: https://chromium-review.googlesource.com/865560Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#529133}
-
Dave Schuyler authored
This CL adds descriptive text (error messages) when an entered URL is invalid or too long. Too long is currently defined as 100KB, which was chosen empirically based on how long a URL can be before the UI lags (appears to freeze). Bug: 575606 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I51e473de88d3370e3eba8d5eb0cf8fe27759eb9e Reviewed-on: https://chromium-review.googlesource.com/854713Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#529132}
-
depot-tools-roller@chromium.org authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2377b01e6cd3..5d6b00fac64a $ git log 2377b01e6..5d6b00fac --date=short --no-merges --format='%ad %ae %s' 2018-01-12 iannucci [cit] Use subprocess2 to properly sink stdout. Created with: roll-dep src/third_party/depot_tools The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=phajdan.jr@chromium.org Change-Id: Ic75289442744c597d60b88386e4a6f4a01a36857 Reviewed-on: https://chromium-review.googlesource.com/865804Reviewed-by:
depot-tools-roller . <depot-tools-roller@chromium.org> Commit-Queue: depot-tools-roller . <depot-tools-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#529131}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/befff6580e9d..ff25cdf898e6 $ git log befff6580..ff25cdf89 --date=short --no-merges --format='%ad %ae %s' 2018-01-12 reed Revert "relax path bounds check so we can draw larger paths" Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=ethannicholas@chromium.org Change-Id: Icde3a5df8380dceaf73ca54d7dcafc5b877a5c8f Reviewed-on: https://chromium-review.googlesource.com/865830Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#529130}
-
Jungshik Shin authored
When comparing domain names with top 10k domain names for confusability, characters with diacritics are decomposed into base + diacritic marks (Unicode Normalization Form D) and diacritics are dropped before calculating the confusability skeleton because two characters with and without a diacritics is NOT regarded as confusable. However, there are a dozen of characters (most of them are Cyrillic) with a diacritic-like mark attached but they are not decomposed into base + diacritics by NFD (e.g. U+049B, қ; Cyrillic Small Letter Ka with Descender). This CL treats them the same way as their "base" characters. For instance, қ (U+049B) is treated as confusable with Latin k because к (U+043A; Cyrillic Small Letter Ka) is. They're curated from the following sets: [:IdentifierStatus=Allowed:] & [:Ll:] & [[:sc=Cyrillic:] - [[\u01cd-\u01dc][\u1c80-\u1c8f][\u1e00-\u1e9b][\u1f00-\u1fff] [\ua640-\ua69f][\ua720-\ua7ff]]] & [:NFD_Inert=Yes:] [:IdentifierStatus=Allowed:] & [:Ll:] & [[:sc=Latin:] - [[\u01cd-\u01dc][\u1e00-\u1e9b][\ua720-\ua7ff]]] & [:NFD_Inert=Yes:] [:IdentifierStatus=Allowed:] & [:Ll:] & [[:sc=Greek:]] & [:NFD_Inert=Yes:] Bug: 793628,798892 Test: components_unittests --gtest_filter=*IDN* Change-Id: I20c6af13defa295f6952f33d75987e87ce1853d0 Reviewed-on: https://chromium-review.googlesource.com/860567 Commit-Queue: Jungshik Shin <jshin@chromium.org> Reviewed-by:
Eric Lawrence <elawrence@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#529129}
-
David Jacobo authored
There were a couple of error scenarios that were not captured by RecordUma, this will be helpful to get a more accurate idea of the amount of errors ArcNavigationThrottle runs into while trying to communicate with ARC. Bug: None Test: Build Change-Id: I501e7bf9def282cc9f390f9b5afc962a65ecef44 Reviewed-on: https://chromium-review.googlesource.com/865288Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: David Jacobo <djacobo@chromium.org> Cr-Commit-Position: refs/heads/master@{#529128}
-
Becky Zhou authored
Record user actions on "remove" and "select" from the "more" menu on Download and Bookmark page to make analysis on redundant list item actions possible. Bug: 784016 Change-Id: I0b776cdf1709b94337e673b5dbd1666a165abcc7 Reviewed-on: https://chromium-review.googlesource.com/852976Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#529127}
-