- 31 Aug, 2018 40 commits
-
-
Stuart Langley authored
Update DriveNotificationManager so that it can register for, and process, XMPP push notifications for team drives. We can register for changes in COSMO by prefixing "TD:" to the team drive ID when we register for the invalidation. To support this change we: - Add OnTeamDrivesUpdated to FileSystemObserver to flow changes in the team drives that the user can access to observers. - Allow DriveNotificationManager to keep track of the users team drive ID's and register for notifications from them. - Change DriveNotificationManager to generate a different event if the update is triggered by the polling timer or a push notification. - Change CheckForUpdates to accept a set of id's which will be the team drive id's that were recieved from the invalidation service. - Provide a glue class in DriveIntegrationService to pass team drive updates to DriveNotificationManager. - Addes file system test cases. Follow ups: - Fix DriveNotificationManager so we can write unit tests against it. Write the tests for registering for and processing invalidations. - Look at batching in DriveNotifcationManager, as invalidation service can send many rapid invalidations for the same object. - Fix up the polling timer logic in DriveNotificationManager, and adjust the timeouts so we do not spam the drive backends with needless update checks if the user has many team drives. Bug: 837456, 783184, 867166 Change-Id: I3fd80d41902bdd7f6c8f090346acbbf64f9dafdb Reviewed-on: https://chromium-review.googlesource.com/1195256Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#587945}
-
Tarun Bansal authored
Add more UMA to track the performance and correctness of the resource loading hints experiment. Specifically, this CL records UMA on how many page hints are received via component updater, and how frequently were the resource hints available at the time of page commit. Bug: 878129 Change-Id: I8bc3dd1e6d7c80e4cefc34ebb6119665d5fbee5e Reviewed-on: https://chromium-review.googlesource.com/1197108 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#587944}
-
Peter Kotwicz authored
As part of fixing BUG 817263, I am going to add more methods to WebApkUtils. This CL splits out the host browser selection logic into its own class. Bug=817263 Change-Id: I60a2246959ecb008d69937fbe62b37b2769b99ce Reviewed-on: https://chromium-review.googlesource.com/1184980 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#587943}
-
Wenzhao Zang authored
The space info button in the Files app redirects to the “Storage management” section in Settings, which has already been hidden in Demo Mode. So it makes sense to hide this button as well. In Demo Mode (a public session), the cryptohome runs in RAM. As a result, the Files app only considers available RAM when showing free disk space. Therefore, customers in stores might think the device only has 4 GB of disk space. We should hide the disk space stat until there's a better solution, e.g. show an explanatory message ("disk space is limited in Demo Mode" or something). Bug: 868747 Change-Id: I8b138bbf0b864acaf38a51659cccf7ad3d198c16 Reviewed-on: https://chromium-review.googlesource.com/1198882Reviewed-by:Naoki Fukino <fukino@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#587942}
-
Michael Giuffrida authored
Remove --enable-demo-mode flag and always enable Demo Mode when ARC++ is supported. The --enable-offline-demo-mode flag will be removed separately for ease of reverting in case that feature ends up being delayed. Bug: 812037 Change-Id: Ie3ac7a98af21d3fab3e3c7f2aaff0c71a2bcaf08 Reviewed-on: https://chromium-review.googlesource.com/1195116 Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#587941}
-
jonross authored
LayerWithRealCompositorTest.ReportMetrics was racy due to the fact that LayerAnimationElement and SchedulerStateMachine's timing and task queues cannot be mocked out. This left the test vulnerable to differences in timing on bots. The test had a certain expectation of the order of events, which is not actually a guarantee. An animation's frame could be generated before it entered its wait loop. Similarly a animation could be delayed in executing for so long that not enough frames were generated to actually create a report. This updates the test to mock out time, so that it can reliably control the order of events. The test has also been moved to LayerAnimatorTest.ReportMetrics. LayerWithRealCompositorTest utilizes a TestCompositorHost in order to control the Compositor throughout the tests. This was done by having CompositorTestSuite always create a ScopedTaskEnvironment. Unfortunately this causes a thread race with base::TimeTicks::Now, as this thread starts enqueuing work before an individual test can mock out time. This change also updates CompositorTestSuite to not create the ScopedTaskEnvironment. Instead each test suite which desires to mock out the time of task runners, must explicitly create one. Thus allowing tests which need not a full Compositor thread, can instead be able to mock time separately. TBR=sadrul@chromium.org TEST=LayerWithRealCompositorTest.ReportMetrics LayerAnimatorTest.ReportMetrics Bug: 709080 Change-Id: Ia12cdcdf2b6c67c8abc21399eae66cdb1d0d1eb1 Reviewed-on: https://chromium-review.googlesource.com/1157234 Commit-Queue: Jonathan Ross <jonross@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#587940}
-
Lei Zhang authored
Change-Id: Ib785f3bab568f15a4d970e185cd6c6eedd6e806d Reviewed-on: https://chromium-review.googlesource.com/1196236 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#587939}
-
Charlie Harrison authored
Bug: None Change-Id: I41c66bdab7c27bc3b1df30576b8116143383eb14 Reviewed-on: https://chromium-review.googlesource.com/1195832Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#587938}
-
Yutaka Hirano authored
CORSURLLoaderFactory rejects a request whose credentials mode and load flags contradict each other. The load flags rely on blink::ResourceRequest::allow_stored_credentials_, so let's configure the member when out-of-blink CORS is enabled. Now we have response tainting, so use it to configure load_flags. This changes the existing behavior (even when out-of-blink CORS is disabled), which leads to test changes. See https://github.com/whatwg/fetch/issues/169 for the corresponding spec change. Bug: 870173 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I8163ce45780b0b6bf9e8ee61e8bee0c433ea0967 Reviewed-on: https://chromium-review.googlesource.com/1174080 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#587937}
-
Dongheun Kang authored
Bug: n/a Change-Id: Iffd7f0bece86b9438b285da3a53ceea00104b77d Reviewed-on: https://chromium-review.googlesource.com/1195383 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#587936}
-
Yutaka Hirano authored
blink::Resource has a field cors_status_ to store the result of CORS check. This CL replaces the concept with "response type", a concept defined in the fetch spec as https://fetch.spec.whatwg.org/#concept-response-type. Actually, that field has existed for long for service worker, but this CL starts using it for network fetch. Using response type enables us to have the consistent logic among several implementations, namely, CORSURLLoader, ResourceLoader and ThreadableLoader. https://html.spec.whatwg.org/#cors-same-origin and https://html.spec.whatwg.org/#cors-cross-origin are now implemented so various resource clients should use them. Side effects: - blink::ResourceLoader now dispatches a ResourceError with a CORS error for CORS violations instead of an abort error. - Now CORS erros from CORSURLLoader are printed on the devtools console. Bug: 736308, 878339 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I8777904654c0478d092ad90a2a919d5eb5dcc2bd Reviewed-on: https://chromium-review.googlesource.com/1154246 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Fredrik Hubinette <hubbe@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#587935}
-
Wenzhao Zang authored
Bug: 879310 Change-Id: I65ac6b822e1fadd9440189a3e11c6d4fa118ec8f Reviewed-on: https://chromium-review.googlesource.com/1198762 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#587934}
-
Timothy Gu authored
FrameLoader::StopAllLoaders() has this explicit note: Warning: stopAllLoaders can and will detach the LocalFrame out from under you. All callers need to either protect the LocalFrame or guarantee they won't in any way access the LocalFrame after stopAllLoaders returns. Check frame_'s existence after the call to prevent a NULL dereference. Bug: 879366 Change-Id: I1e537374f59fbad7b069f9de63cfa3b6b2b2b00c Reviewed-on: https://chromium-review.googlesource.com/1198022Reviewed-by:Nate Chapin <japhet@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Timothy Gu <timothygu@chromium.org> Cr-Commit-Position: refs/heads/master@{#587933}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/d4e7ca034cbb..b2d25960b756 git log d4e7ca034cbb..b2d25960b756 --date=short --no-merges --format='%ad %ae %s' 2018-08-31 thestig@chromium.org Stop checking out GYP. Created with: gclient setdep -r src/third_party/pdfium@b2d25960b756 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I406bc25fb39940707da7f450ccac926b64613413 Reviewed-on: https://chromium-review.googlesource.com/1198386Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#587932}
-
Sujie Zhu authored
Add billing customer number in the migration request. TBR=mathp@chromium.org Bug: 852904 Change-Id: Ia474eda34bc62982e724318f4048ecee6571cc14 Reviewed-on: https://chromium-review.googlesource.com/1198763Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Sujie Zhu <sujiezhu@google.com> Cr-Commit-Position: refs/heads/master@{#587931}
-
Miguel Casas authored
ToT looks at RuntimeEnabledFeatures::Canvas2dImageChromiumEnabled() (enabled by default for Mac, disabled by default elsewhere) to use ImageCHROMIUM for Canvas 2D contexts or not. This is fine, but in the LowLatency it doesn't make sense not use that features, we always want to use ImageCHROMIUM (if we |want_acceleration| at all). Hence this CL: - ignores the RuntimeEnabledFeature if LowLatency (so all platforms will use ImageCHROMIUM for LowLatency -- if |want_acceleration|). - removes the associated code in runtime_features.cc and about_flags.cc, essentially undoing my previous crrev.com/c/1056168. (So that Mac can still control the use of ImageCHROMIUM for non-low-latency cases). Bonus cleanup: simplify |enable_web_gl_image_chromium| initialization. Bug: 878405 Change-Id: I91c5422fad82b1146af02c193546f924bbe5448b Reviewed-on: https://chromium-review.googlesource.com/1194473 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#587930}
-
Alex Deymo authored
The compression density of small thumbnails and large "photos" is expected to be different. This patch splits the recently added metric reporting the compressed density for JPEG images measured as "bits per pixel" into three groups according to the smallest dimension (width or height): * 100 to 399 pixels, * 400 to 999 pixels, and * 1000 or more pixels Test: Updated unittests Bug: None Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I1c3ccd6a404896e02c9d6a6cd978af8f213ec921 Reviewed-on: https://chromium-review.googlesource.com/1186886Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Alex Deymo <deymo@google.com> Cr-Commit-Position: refs/heads/master@{#587929}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: I1a44dfd5f1535fa36388030b6291aac4f87667a0 Reviewed-on: https://chromium-review.googlesource.com/1198311Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#587928}
-
Clark DuVall authored
This is a reland of a475e1ab Test needed to call Shutdown() so WebRequestAPI is cleaned up properly. Original change's description: > Fix crash in web request proxies connection error handler > > When WebRequestAPI is destroyed, it posts a task to the IO thread to > shutdown the proxies. This crash can happen when the WebRequestAPI is > destroyed, and a connection error happens on one of the proxies (which > accesses data destroyed by the profile) before the ProxySet can be fully > shutdown on the IO thread. This change adds an atomic flag to check to > make sure the WebRequestAPI has not been destroyed before running error > handlers. > > Bug: 878366 > Change-Id: I2f7b98c1d6df7c53a5917444ac996e9b5ef4e794 > Reviewed-on: https://chromium-review.googlesource.com/1196031 > Reviewed-by: Ken Rockot <rockot@chromium.org> > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#587749} TBR=rockot@chromium.org Bug: 878366 Change-Id: I97ab12e12fe4955af94138ec5bb64c1391d27598 Reviewed-on: https://chromium-review.googlesource.com/1198567Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#587927}
-
Bailey Berro authored
- Network File Shares for ChromeOS will be availible by default starting in M70 Bug: chromium:757625 Change-Id: I0d4a6051cee3ac1893f34b78dc39f7b9c9378291 Reviewed-on: https://chromium-review.googlesource.com/1194790 Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#587926}
-
iOS Autoroller authored
TBR=smut Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I01920669da7811c46bb71c3e18da9eab7d888db3 Reviewed-on: https://chromium-review.googlesource.com/1198308 Commit-Queue: iOS Autoroller <ios-autoroller@chromium.org> Reviewed-by:
iOS Autoroller <ios-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#587925}
-
Hwanseung Lee authored
call to ConnectToWorkerInterfaceProvider is ambiguous. because there are same function name. - workers/dedicated_worker.cc - workers/experimental/thread_pool.cc thread_pool.cc was added latest. so rename to ConnectToWorkerInterfaceProviderForThreadPool. TBR=japhet@chromium.org Bug: 746956 Change-Id: I3ad3d51351428c8fc3cbc4b617c41a40b8f7a1b4 Reviewed-on: https://chromium-review.googlesource.com/1198664Reviewed-by:
Hwanseung Lee <hs1217.lee@samsung.com> Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Cr-Commit-Position: refs/heads/master@{#587924}
-
Jialiu Lin authored
Record service error code of refreshing OAuth2 access token. These refreshes are triggered by AdvancedProtectionStatusManager to fetch users' advanced protection status. Bug: 866620 Change-Id: I182878944077a74d802478309bf4594f65d65fe4 Reviewed-on: https://chromium-review.googlesource.com/1197106 Commit-Queue: Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#587923}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/5053a10675a7..108fea28a159 git log 5053a10675a7..108fea28a159 --date=short --no-merges --format='%ad %ae %s' 2018-08-31 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@108fea28a159 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I6984a04aa2a2d551799341efb11422000658d326 Reviewed-on: https://chromium-review.googlesource.com/1198462Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#587922}
-
Lei Zhang authored
The code, used for the Cloud Print Proxy, is useless without CUPS. BUG=793801 Change-Id: Icb4605ae15d758366c5c0b1e52a56afcfe5334a1 Reviewed-on: https://chromium-review.googlesource.com/961862 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#587921}
-
chrome://appsBen Wells authored
When bookmark apps aren't locally installed, they should be dimmed out and they should have the launch type, app info and create shortcuts menus removed. This change also cleans up the logic that shows these menus and moved it to C++ where it is easier to reason about. Bug: 874841 Change-Id: Ia6af16a383c6f4434ac9da9e49882186c2c20015 Reviewed-on: https://chromium-review.googlesource.com/1195124Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#587920}
-
Vikas Soni authored
Add gpu driver workaround to disable AImageReader on devices which have ARM GPU. Bug: 838725 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ia60d5ee9e16a4f309a99d04212af245411319040 Reviewed-on: https://chromium-review.googlesource.com/1194680 Commit-Queue: vikas soni <vikassoni@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#587919}
-
Lei Zhang authored
- Make spellcheck rules inclusive instead of exclusive. - Push some PPAPI rules down into the pepper/ sub-directory. - Remove a rendundant rule. Change-Id: I8dfee499566bb37b11912b063d16fa788127bdc4 Reviewed-on: https://chromium-review.googlesource.com/1197353Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#587918}
-
Xinghua Cao authored
Remove conformance/textures/misc/texture-size-limit.html suppression for Linux Intel HD630 bot. BUG=745888 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I53c48b9fdacdcb94555ea586d7673d5dc30f4ac3 Reviewed-on: https://chromium-review.googlesource.com/1195113Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#587917}
-
Jinsuk Kim authored
https://crrev.com/c/1180637 introduced a regression on the simplified NTP. TextView in native page has a sizing issue when View#layout() is invoked in unattached state. This CL makes layout not performed in the corresponding state. Bug: 876686 Change-Id: I81eff601781ec85e398ccc4d1ce555c441e20ddb Reviewed-on: https://chromium-review.googlesource.com/1189682Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#587916}
-
wutao authored
This patch implements the decoding client side for streaming data. Bug: b/113131759, b/80315134 Test: manual. Change-Id: I2ae58ef3d3c368ba02891db14b0a39f62155f8a9 Reviewed-on: https://chromium-review.googlesource.com/1195145Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#587915}
-
Zhiqiang Zhang authored
This CL includes the following changes: * Register SessionManagerListener properly so CafMRP and the page can get the correct state. * Store the pending request only in CafBaseMRP and CastSessionController will get it from the provider. * When starting a session, only re-select a route after the route has been unselected. This is to avoid rapid selection/unselection to cause Android MediaRouter to work improperly. * Several minor fixes to avoid crashing in the code flow. Bug: 711860 Change-Id: I8e4e46abe9421908a5d6c7e221a68feb891bbfa3 Reviewed-on: https://chromium-review.googlesource.com/1196166 Commit-Queue: Zhiqiang Zhang <zqzhang@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#587914}
-
Lei Zhang authored
The classes are not refcounted. They should have public destructors, like most normal classes, so they can be used with std::make_unique. Change-Id: I7b9b3f833c4535fe3fd0a32f94ee1b03e4d76463 Reviewed-on: https://chromium-review.googlesource.com/1197882Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#587913}
-
Fabio Tirelo authored
The functions are still used by Clank downstream and will be removed once only the new preferences are used by it. TBR=mathp@chromium.org Bug: 879384 Change-Id: Ibee61db92a2bd3cd8b4124b79fc1c0d747d401d1 Reviewed-on: https://chromium-review.googlesource.com/1198453Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#587912}
-
David Black authored
Per the spec, the first card element should have a top margin of 40dip. See bug for spec/screenshots. Bug: b:113611382 Change-Id: I323bc7283db600e1f1e319652715b572583a6fbe Reviewed-on: https://chromium-review.googlesource.com/1185878Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#587911}
-
Michael Giuffrida authored
Logs how much active time is spent in pre-installed apps or the browser window when the device is enrolled into Demo Mode by sampling the active window while the user has been recently active. The DemoModeApp enum covers browser windows, several preinstalled Chrome and ARC++ apps, and catch-all categories for unknown apps and non-app UI. These metrics require UMA opt-in and are only collected in demo sessions. Bug: 827380 Change-Id: Icbbb94186b2bff4767c0ee193aa27126eb0a00c2 Reviewed-on: https://chromium-review.googlesource.com/1189711 Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#587910}
-
Becca Hughes authored
Add the audio context and media element playbacks fields to the Media Engagement WebUI. BUG=878460 Change-Id: I25a2bdc28a9b98355269e56072c6dc98a019456a Reviewed-on: https://chromium-review.googlesource.com/1195101 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#587909}
-
Dan Sanders authored
This CL changes DecoderStream to maintain an instance of DecoderSelector continually. This enabled DecoderSelector to maintain DecryptingDemuxerStream state and the blacklist internally. An immediate consequence is that DecoderSelector can now always try the full list of potential decoders each time that selection is triggered. This fixes the GPU->GPU changeType() transition, and provides a foundation to build GPU fallforward on top of. Another consequence is that fallback can occur more than once for a stream. It is no longer possible to loop forever doing fallbacks, so this is a robustness improvement in addition to being a requirement for changeType(). Bug: 877673 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I76d1bed1c914e1ec58a6653d7200fbb67f70971a Reviewed-on: https://chromium-review.googlesource.com/1188978 Commit-Queue: Dan Sanders <sandersd@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#587908}
-
Istiaque Ahmed authored
This is a reland of 15b15db4 https://chromium-review.googlesource.com/1187856 was in conflict with the CL. Fixed in patchset #5. Original change's description: > [Extensions] Remove an unused param from StartTestFromBackgroundPage. > > The param was always passed with nullptr value, so remove it entirely. > > Bug: None > Test: None, test cleanup. > Change-Id: If8cd3c4c7e0bd77fabbc545dcbd5fda69a9c0703 > Reviewed-on: https://chromium-review.googlesource.com/1196143 > Reviewed-by: Karan Bhatia <karandeepb@chromium.org> > Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#587871} Bug: None Change-Id: Ie25c1f8d87e555ad813c3f044a10b1ce7fad3b00 Reviewed-on: https://chromium-review.googlesource.com/1198483Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#587907}
-
Reid Kleckner authored
This passes the /time option to LLD, which prints out some statistics about how long various linking phases took. I plan to add more timers around the major LTO phases so we have more visibility into how ThinLTO performs on buildbots. Also remove two CFI bots that moved from chromium.fyi to chromium.clang. R=dpranke@chromium.org Bug: 877722 Change-Id: I63181af92503ac6877db3cec7b3296d3e229e5a0 Reviewed-on: https://chromium-review.googlesource.com/1197792Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#587906}
-