- 12 Sep, 2017 40 commits
-
-
Dave Schuyler authored
This CL expands the usage of cr-link-row into settings. This doesn't replace all instances of link rows. It's a sampling of a few different cases. Changes UI for: device display overscan, customize fonts, passwords and forms links. Bug: 757663, 763177 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Id63d8b8c5a6c3c36e6804018ea66d8d03679f1ad Reviewed-on: https://chromium-review.googlesource.com/656527Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#501394}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/79a1256c2233..a640c49b7ecf $ git log 79a1256c2..a640c49b7 --date=short --no-merges --format='%ad %ae %s' 2017-09-11 csmartdalton Minor cleanups for CCPR 2017-09-12 rmistry Fix behavior of automatically adding 'Cq-Include-Trybots' in presubmit 2017-09-12 rmistry Add checks for 'DO NOT''SUBMIT' in description and file content 2017-08-25 wangxianzhu Optimize filterBounds() of SkArithmeticImageFilter/SkXfermodeImageFilter Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=stephana@chromium.org Change-Id: I7ccba3de4e805caa2fe6bf54d44bd807bafe2b1a Reviewed-on: https://chromium-review.googlesource.com/664060Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#501393}
-
Bin Zhao authored
Usage: "--enable-features=EnableCastDiscovery,EnableCastChannelRetry<MyStudyName --force-fieldtrials=MyStudyName/Group1 --force-fieldtrial-params= MyStudyName.Group1:initial_delay_ms/20000/max_retry_attempts/20/exponential/3.0" - Added a finch feature "EnableCastChannelRetry" and made retry strategy parameters configurable - Added CastMediaSinkServiceImpl::InitRetryParameters to parse feature parameters Bug: 752310 Change-Id: I13d4c3eb8d27de32bbe08fe62a8d4f3cd096776d Reviewed-on: https://chromium-review.googlesource.com/639671 Commit-Queue: Bin Zhao <zhaobin@chromium.org> Reviewed-by:Derek Cheng <imcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#501392}
-
Sidney San Martín authored
A few times, I've seen the a download complete exceptionally quickly and leave the filename positioned as if there's status text, but there isn't. I can't reproduce it consistently, but one possibility is that `statusTextView_.hidden` is a bad signal for whether the layout needs to change (it can be hidden for other reasons, like a dangerous download). This change stops using `hidden` to decide whether to change states, which is an improvement either way. Bug: 589943 Change-Id: I491c06f57860315068fa719f046032353cb2db1e Reviewed-on: https://chromium-review.googlesource.com/664137Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#501391}
-
Yuke Liao authored
This CL adds an assertion to make sure that the user specified profile data file exists. Bug: 763962 Change-Id: I2a8830ad8fc7ca1a5f91e739ba3107ac70e3a2eb Reviewed-on: https://chromium-review.googlesource.com/662237 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Mike Baxley <baxley@chromium.org> Cr-Commit-Position: refs/heads/master@{#501390}
-
Matthew Jones authored
This change introduces the concept of 'state change reason' to the bottom sheet. Once setSheetState is called with a reason, that reason persists through all the events until the sheet reaches its final state or setSheetState is called again. This change allows users of the API to make more nuanced decisions based on what caused the bottom sheet to, for example, open. The first change to use this API is the placeholder content in the content controller. If the sheet is opened because of the omnibox focusing, the placeholder will be shown instead of suggestions. Previously this was done by immediately replacing the suggestions content when the omnibox gained focus. BUG=764391 Change-Id: I4fb129037b9fc8981ad5793fff5589524300b5a2 Reviewed-on: https://chromium-review.googlesource.com/656078 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#501389}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/4588792ebfcf..8ac74971a335 $ git log 4588792eb..8ac74971a --date=short --no-merges --format='%ad %ae %s' 2017-09-12 rharrison Remove ASSERT that was added to understand what was occuring Created with: roll-dep src/third_party/pdfium BUG=763369 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: Ia6cc6d39429b22eebd3b830226173c444609deef Reviewed-on: https://chromium-review.googlesource.com/663604 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#501388}
-
Mathieu Perreault authored
Bug: 764382 Change-Id: Ife477677e89c55257ba0cf537dedb0000e8c7d54 Reviewed-on: https://chromium-review.googlesource.com/663559 Commit-Queue: Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#501387}
-
Peter Kotwicz authored
BUG=None Change-Id: If8af3d78990904f6b934f54bc853ed690e0a1eeb Reviewed-on: https://chromium-review.googlesource.com/660718Reviewed-by:
-
Charles Harrison authored
This CL should not change behavior. We could probably remove the param from WebContentsDelegate::AddWebContents but some delegates actually set it, so the change would be more complicated and could change behavior. Bug: None Change-Id: I2b25c7ae4fb86c2aad386697832bb5017ea7744f Reviewed-on: https://chromium-review.googlesource.com/655126Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#501385}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/000134387797..7370e9da6e0c $ git log 000134387..7370e9da6 --date=short --no-merges --format='%ad %ae %s' 2017-09-12 benjhayden Document diagnostics required by dashboard. 2017-09-12 hjd tracing: Add private footprint 2017-09-12 loloangela Fix errors related to invalid-name pt. 6 2017-09-12 stephen.kyle tracing: include start,end events in loading_metric's other timeTo metrics Created with: roll-dep src/third_party/catapult BUG=737325 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ie0aed1db0d86824075dafd9cf7958f68be979999 Reviewed-on: https://chromium-review.googlesource.com/663613 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#501384}
-
Pavel Feldman authored
Bug: 753159 Change-Id: I2415b1def48ab5ba7fbbd29e586304ce5655ad1e Reviewed-on: https://chromium-review.googlesource.com/646732 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#501383}
-
Nate Chapin authored
Cancelling a font load can start a new fallback load inside ResourceFetcher::StopFetching. This is a problem if StopFetching() is called due to the ResourceFetcher detaching, and leaves a semi-detached resource load in progress. Bug: 763040, 763387 Test: http/tests/webfont/multiple-font-src-detach.html Change-Id: If366431abc4752b61d760d10687fd4a81d78ebc1 Reviewed-on: https://chromium-review.googlesource.com/663880Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#501382}
-
Matt Wolenetz authored
Parameterizes all SourceBufferStreamTests by which version of the buffering API is being tested; the test ctor forces on/off the media::kMseBufferByPts feature accordingly. Immediate follow-on work will be to enable the kNewByPts versions of these SBS tests (possibly in incremental CLs) along with corresponding production impl, while still also testing the 'legacy' buffering-by-DTS implementation. BUG=718641 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I40e29ac5775301ad69e305e9f0a521a5d5b3711a Reviewed-on: https://chromium-review.googlesource.com/663879Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#501381}
-
mark a. foltz authored
The limit was in place for Cast applications as 64k message size is a limitation of the browser => Cast channel. However, this does not apply to generic presentations. Verified that the Cast SDK enforces its own limits. Bug: 524128 Change-Id: I16f5664329b9d5504154c6e0f79be666d4ab61b9 Reviewed-on: https://chromium-review.googlesource.com/634523 Commit-Queue: mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#501380}
-
Sebastien Seguin-Gagnon authored
This reverts commit 3fc7721d. Reason for revert: Suspecting this CL for the 3 consecutive failures of the TextSuggestionMenuTest#menuDismissesWhenTappingOutside test. see builds: https://uberchromegw.corp.google.com/i/chromium.android/builders/Android%20N5X%20Swarm%20Builder/builds/15165 https://uberchromegw.corp.google.com/i/chromium.android/builders/Android%20N5X%20Swarm%20Builder/builds/15166 https://uberchromegw.corp.google.com/i/chromium.android/builders/Android%20N5X%20Swarm%20Builder/builds/15167 Log: junit.framework.AssertionFailedError: Criteria not met in allotted time. at junit.framework.Assert.fail(Assert.java:50) at junit.framework.Assert.assertTrue(Assert.java:20) at org.chromium.content.browser.test.util.CriteriaHelper.pollInstrumentationThread(CriteriaHelper.java:79) at org.chromium.content.browser.test.util.CriteriaHelper.pollUiThread(CriteriaHelper.java:117) at org.chromium.content.browser.test.util.CriteriaHelper.pollUiThread(CriteriaHelper.java:138) at org.chromium.content.browser.input.TextSuggestionMenuTest.waitForMenuToHide(TextSuggestionMenuTest.java:195) at org.chromium.content.browser.input.TextSuggestionMenuTest.menuDismissesWhenTappingOutside(TextSuggestionMenuTest.java:170) at java.lang.reflect.Method.invoke(Native Method) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:52) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) at org.chromium.base.test.ScreenshotOnFailureStatement.evaluate(ScreenshotOnFailureStatement.java:37) at android.support.test.internal.statement.UiThreadStatement.evaluate(UiThreadStatement.java:55) at android.support.test.rule.ActivityTestRule$ActivityStatement.evaluate(ActivityTestRule.java:270) at org.junit.rules.RunRules.evaluate(RunRules.java:20) at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78) at org.chromium.base.test.BaseJUnit4ClassRunner.runChild(BaseJUnit4ClassRunner.java:175) at org.chromium.base.test.BaseJUnit4ClassRunner.runChild(BaseJUnit4ClassRunner.java:40) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268) at org.junit.runners.ParentRunner.run(ParentRunner.java:363) at org.chromium.base.test.BaseJUnit4ClassRunner.run(BaseJUnit4ClassRunner.java:164) at org.junit.runners.Suite.runChild(Suite.java:128) at org.junit.runners.Suite.runChild(Suite.java:27) at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288) at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268) at org.junit.runners.ParentRunner.run(ParentRunner.java:363) at org.junit.runner.JUnitCore.run(JUnitCore.java:137) at org.junit.runner.JUnitCore.run(JUnitCore.java:115) at android.support.test.internal.runner.TestExecutor.execute(TestExecutor.java:59) at android.support.test.runner.AndroidJUnitRunner.onStart(AndroidJUnitRunner.java:262) at org.chromium.base.test.BaseChromiumAndroidJUnitRunner.onStart(BaseChromiumAndroidJUnitRunner.java:98) at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1879) Original change's description: > Add support for Android SuggestionSpans > > This is the final CL to add support for Android SuggestionSpans (at least ones > not marked with FLAG_MISSPELLING; there will be one or more additional CLs to > add support for those). This CL includes: > > - Changes to ImeAdapter to make it pass SuggestionSpans into > InputMethodController > > - Changes to InputMethodController to make it create suggestion markers from the > passed-in SuggestionSpans > > - Additional methods in TextSuggestionController for getting the list of text > suggestions under the cursor, and applying a suggestion > > - More Mojo code to pass information about text suggestions back-and-forth > between browser and renderer code > > - Changes to SuggestionsPopupWindow and TextSuggestionHost so we can show either > a spell check or a text suggestion menu > > Bug: 672259 > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > Change-Id: I3f30543586901baec4648d265874a303efafbd44 > Reviewed-on: https://chromium-review.googlesource.com/627172 > Commit-Queue: Ryan Landay <rlanday@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> > Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Reviewed-by: Alexandre Elias <aelias@chromium.org> > Cr-Commit-Position: refs/heads/master@{#501335} TBR=yosin@chromium.org,dtrainor@chromium.org,torne@chromium.org,aelias@chromium.org,tedchoc@chromium.org,changwan@chromium.org,xiaochengh@chromium.org,rsesek@chromium.org,rlanday@chromium.org Change-Id: I24641a2a43dffe8056a231a676033bcff39bcae7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 672259 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Reviewed-on: https://chromium-review.googlesource.com/663760Reviewed-by:
-
Wenzhao Zang authored
The interface is used to close the note taking app from the views-based login shelf. Also added TestTrayActionClient which are shared by various unit tests. Bug: 701157 Change-Id: I88c871f1597369f11b5b2c9d1c3548c790c0b088 Reviewed-on: https://chromium-review.googlesource.com/656059Reviewed-by:
Oliver Chang <ochang@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#501378}
-
sebsg authored
Bug: 764464 Tbr: miu@chromium.org Change-Id: Ibe3cc60266d1c20c79fe6f4b742f882426796ced Reviewed-on: https://chromium-review.googlesource.com/664065Reviewed-by:
-
Brett Wilson authored
Part 3/4 to replace these namespace qualifications. TBR=dcheng@chromium.org Bug: 763556 Change-Id: I052b146dd2ce9f5e3997ab5ae1e362b2422fb03e Reviewed-on: https://chromium-review.googlesource.com/662140Reviewed-by:
Brett Wilson <brettw@chromium.org> Reviewed-by:
-
Xianzhu Wang authored
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I64abe06057f9978289ec183a28a6c756fdf40aa1 Reviewed-on: https://chromium-review.googlesource.com/661784 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#501375}
-
Matt Mueller authored
Windows has been on use_byte_certs since M61. Bug: 671420 Change-Id: I78c7f7f2a2e94ebd18d4d0c76909a9549231ec85 Reviewed-on: https://chromium-review.googlesource.com/661885Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#501374}
-
John Rummell authored
Add versioning to functions that query the storage ID. This will enable changes in the future if Chrome ever needs to use a different method of determining the ID. Pepper will only support a single version (version 1). BUG=478960 TEST=EME browser_tests pass Change-Id: Iea2d3ef00f3e8a3316952e0061dbbf666a2798bb Reviewed-on: https://chromium-review.googlesource.com/661117Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Nick Carter <nick@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#501373}
-
Helen Li authored
This CL removes SDCH code from net/filter/. This CL is one of the CLs to remove SDCH from Chromium. SDCH has been disabled in Chrome since M59. For more details please see Issue 690070 and blink-dev@ thread linked below. Bug: 762686 Change-Id: I5d98c0171a4fbceb1348ccc2a67fa2a51bd4df8a Reviewed-on: https://chromium-review.googlesource.com/663239Reviewed-by:
Randy Smith <rdsmith@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#501372}
-
Ira Burak authored
Windows doesn't allow defining empty arrays, so for the case when there are no expired histograms, the dummy value is added. Bug: 753485 Change-Id: I69efcaa7ea63939d1e1b75497f6a1a252de010f2 Reviewed-on: https://chromium-review.googlesource.com/650468Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Ira Burak <iburak@google.com> Cr-Commit-Position: refs/heads/master@{#501371}
-
Carlos IL authored
URLs for manually opening chrome interstitials (chrome://interstitials/...) now use exact path matching instead of only checking that the first characters match (e.g. chrome://interstitials/ssl--invalid-- will not open chrome://interstitials/ssl). Added a test that verifies this change. R=estark@chromium.org Bug: 759915 Change-Id: I0d83709e54b83784c3f26a8d0511a77511d5fb63 Reviewed-on: https://chromium-review.googlesource.com/663204Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Carlos Joan Rafael Ibarra Lopez <carlosil@google.com> Cr-Commit-Position: refs/heads/master@{#501370}
-
Christopher Grant authored
This is a reland of 3e3149a8 Original change's description: > ElideUrl: Refactor tests to use a progressive elision approach. > > Several elision test cases specify multiple progressively shorter > versions of the same original URL. With this change, we'll test that > progression more thoroughly by specifying the expected sequence of > consecutive results that should be generated as available space > decreases. > > This helps eliminate the risk of a broken corner case. > > BUG=753789 > > Change-Id: Ib727295522f588f5e8b658661d2314587aa61844 > Reviewed-on: https://chromium-review.googlesource.com/643153 > Reviewed-by: Tommy Li <tommycli@chromium.org> > Reviewed-by: Matt Giuca <mgiuca@chromium.org> > Commit-Queue: Christopher Grant <cjgrant@chromium.org> > Cr-Commit-Position: refs/heads/master@{#499962} TBR=tommycli@chromium.org Bug: 753789 Change-Id: Ief5f6c029f93282de64d3946266b8608620aff80 Reviewed-on: https://chromium-review.googlesource.com/663677Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#501369}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/00f454c9..a3ef78d9 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: I7b9ea0307d465ec4cccca9225545d296470fe7c9 Reviewed-on: https://chromium-review.googlesource.com/663409Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#501368}
-
Sean Topping authored
This is needed to enable remote browser traces on Chromecast. Bug: internal b/65209777 Change-Id: I0ea49227ac484f7a278328eeff6eedfdac7bf946 Reviewed-on: https://chromium-review.googlesource.com/662362Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Sean Topping <seantopping@chromium.org> Cr-Commit-Position: refs/heads/master@{#501367}
-
Eric Holk authored
This test make sure that breakpad generates a crash dump when the renderer crashes. We also need to ensure crash reports are generated when WebAssembly is using trap-based bounds checks, as WebAssembly's attempts to recover from SEGV signals could prevent crash reports from being generated. Bug: chromium:722585 Change-Id: I152a6a1d6d0f91590c4e0fb0acfcce866064399d Reviewed-on: https://chromium-review.googlesource.com/661785Reviewed-by:
-
Conley Owens authored
This change adds a CCCD (Client Characteristic Configuration Descriptor, as defined in Vol 3, Part G, 3.3.3.3) to the measurement interval of the fake health thermometer. This will allow us to call startNotifications() on the measurement interval. BUG=719816 Change-Id: Ia7b515378be0c66e58c68d10451fbbd600e1c9c5 Reviewed-on: https://chromium-review.googlesource.com/663938 Commit-Queue: Conley Owens <cco3@chromium.org> Reviewed-by:
Vincent Scheib <scheib@chromium.org> Cr-Commit-Position: refs/heads/master@{#501365}
-
Greg Kerr authored
The bootstrap sandbox was replaced by the V2 sandbox. Bug: 762077 Change-Id: I2c9aeab22d29a42a2c800a53e0c8a5484e00c043 Reviewed-on: https://chromium-review.googlesource.com/647686Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Greg Kerr <kerrnel@chromium.org> Cr-Commit-Position: refs/heads/master@{#501364}
-
Mohamad Ahmadi authored
- Sets PaymentRequestManager's active WebState to nullptr in BVC's shutdown method to make sure the active WebState is clean when BVC shuts down. - Adds a call to update PaymentRequestManager's active WebState in -tabModel:didReplaceTab:withTab:atIndex: in order to clean the the previously active WebState and enable PaymentRequest on the new one. This call happens when a recent tab is opened. - This CL adds a unit test to verify that the BVC shuts down cleanly with Payment Request enabled. - This CL removes the calls to enable/disable the active WebState in the [PaymentRequestManager enablePaymentRequest:] and instead changes the behavior so that the script commands are ignored when the Payment Request is disabled. The reason for this change is that this method is called when the BVC is disabled before it shuts down. This could result in a second attempt to disable the active WebState when the BVC actually shuts down which is wrong. TBR=rouslan@ Bug: 761358, 755799, 602666 Change-Id: Id984aec77194993b23085448cb802ba9fe120379 Reviewed-on: https://chromium-review.googlesource.com/660480 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#501363}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 4ba1c8da. Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/1660 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: rouslan@chromium.org, mathp@chromium.org: external/wpt/payment-request TBR=qyearsley@chromium.org No-Export: true Change-Id: I24cd14a12b95c0165056623ccf52afc02497d5f4 Reviewed-on: https://chromium-review.googlesource.com/663622 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#501362}
-
Dmitry Gozman authored
Bug: 590878 Change-Id: I5606ba2082e7ea81b95547b8b28f476ce3f59b43 Reviewed-on: https://chromium-review.googlesource.com/630564Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#501361}
-
Derek Cheng authored
Add option to pass in NetLog to socket used for mDNS. Pass in ChromeNetLog from Chrome code service_discovery_client_mdns. This will hopefully help us diagnose long standing Cast / mDNS reliability issues. The NetLog entries can be easily filtered by searching the IP endpoint used for mDNS (defined in net/dns/mdns_client.cc?). BUG=751207 Change-Id: Id649a03d498e077738c5e071214f31f6577401e6 Reviewed-on: https://chromium-review.googlesource.com/647490Reviewed-by:
Gene Gutnik <gene@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: Derek Cheng <imcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#501360}
-
Sebastien Seguin-Gagnon authored
This reverts commit 5605a3d7. Reason for revert: Causing failures on all platform webkit layout test external/wpt/innerText/getter.html. see bug: crbug.com/764417 Original change's description: > Stop TextIterator from emit double newlines after H4~6 elements > > TextIterator currently may add two consecutive newlines after an > H4, H5 or H6 element, while the spec of innerText doesn't have > this case at all. > > This patch removes the extra newline to make TextIterator more > spec-complicant. > > Note: TextIterator should eventually remove double newline emission > also for H1~3. This patch removes it only for H4~6 to keep the > amount of rebaselined tests small. > > Bug: 752672,758816 > Change-Id: I32583c194a829f52411555125e77590e36ccf838 > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng > Reviewed-on: https://chromium-review.googlesource.com/661937 > Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> > Reviewed-by: Koji Ishii <kojii@chromium.org> > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#501297} TBR=yosin@chromium.org,kojii@chromium.org,xiaochengh@chromium.org,simonp@opera.com Change-Id: I16487602d07a29ac95d79867ae0522dbfbe130d5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 752672, 758816 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Reviewed-on: https://chromium-review.googlesource.com/663941Reviewed-by:
-
Tommy C. Li authored
This CL adds a unified match_in_foo implementation for use between HistoryURLProvider, Bookmarks, and Navsuggest. It deliberately leaves off HQP, as that has does tricky operations using adjusted match offsets rather than unadjusted (like the other providers). It should be very posible to refactor HQP to use this unified code as well, but that should be saved for a separate CL. Bug: 761505 Change-Id: I8107915cae0ef6477e18de32fd924c2a9506e2ad Reviewed-on: https://chromium-review.googlesource.com/661884 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#501358}
-
Aidan Wolter authored
This will allow apps to be conditionally started as services. The enable_headless_music_mode flag is also added. Bug: internal b/64904346 Test: Set the enable_headless_music_mode flag and test that GPM and YTM start as services. Change-Id: Ibbdf4f1874438288659bd4988567a5826986a538 Reviewed-on: https://chromium-review.googlesource.com/654298 Commit-Queue: Aidan Wolter <awolter@chromium.org> Reviewed-by:
-
Shivani Sharma authored
The special handling for 416 is not needed and added comment for auth response since in URLRequest::CancelAuth scenario HC::T::Read() can be invoked even though the transaction is still entry->headers_transaction. Bug: None Change-Id: I9b031e8025b721a45f16957868d540b13c09fb09 Reviewed-on: https://chromium-review.googlesource.com/612400 Commit-Queue: Shivani Sharma <shivanisha@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#501356}
-
Jacob Dufault authored
Also remove a LOG(ERROR) that was accidentally committed. Bug: 719015 Change-Id: Ib4564903b358cdba5c1189a5b9fac484e7c8ad16 Reviewed-on: https://chromium-review.googlesource.com/663667 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#501355}
-
