Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 06 Jun, 2018 39 commits
  3. 05 Jun, 2018 1 commit
    • Ted Choc's avatar
      Revert "Make generate_breakpad_symbols.py not silently ignore subprocess errors." · 5a797379
      Ted Choc authored 
      This reverts commit 924c8465.

Reason for revert: This appears to break the Android WebView bots.

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20WebView%20N%20%28dbg%29
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Android%20WebView%20O%20(dbg)

Traceback (most recent call last):
  File "/b/s/w/ir/cache/builder/src/components/crash/content/tools/generate_breakpad_symbols.py", line 327, in <module>
    sys.exit(main())
  File "/b/s/w/ir/cache/builder/src/components/crash/content/tools/generate_breakpad_symbols.py", line 316, in main
    deps = GetSharedLibraryDependencies(options, queue.pop(0), loader_path)
  File "/b/s/w/ir/cache/builder/src/components/crash/content/tools/generate_breakpad_symbols.py", line 151, in GetSharedLibraryDependencies
    deps = GetSharedLibraryDependenciesLinux(binary)
  File "/b/s/w/ir/cache/builder/src/components/crash/content/tools/generate_breakpad_symbols.py", line 67, in GetSharedLibraryDependenciesLinux
    ldd = subprocess.check_output(['ldd', binary])
  File "/b/s/w/ir/cipd_bin_packages/lib/python2.7/subprocess.py", line 219, in check_output
    raise CalledProcessError(retcode, cmd, output=output)

Original change's description:
> Make generate_breakpad_symbols.py not silently ignore subprocess errors.
> 
> GetCommandOuput() used to pipe stderr to /dev/null, and it ignored
> the command's return code. Use check_output() to check the return
> code, and keep stderr attached to parent's stderr.
> 
> Also make breakpad_integration_test.py a bit simpler (this part is
> supposed to be behavior-preserving.)
> 
> Bug: 813163
> Change-Id: I8c55d3da9fff3b944111c3e868121ac34bf65c17
> Reviewed-on: https://chromium-review.googlesource.com/1086981
> Reviewed-by: Jochen Eisinger <jochen@chromium.org>
> Commit-Queue: Nico Weber <thakis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#564531}

TBR=thakis@chromium.org,jochen@chromium.org

Change-Id: Iee5a81e9b7e9db21f1dda9bdc272d3392438f481
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 813163
Reviewed-on: https://chromium-review.googlesource.com/1087871Reviewed-by: default avatarTed Choc <tedchoc@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564707}
      5a797379