- 27 Sep, 2014 23 commits
-
-
kuan authored
BUG=418190 Review URL: https://codereview.chromium.org/607013003 Cr-Commit-Position: refs/heads/master@{#297100}
-
oshima authored
This wasn't enough and was causing compilation error in clean build. This reverts commit 2a244c81. BUG=414340 TBR=yoz@chromium.org, sky@chromium.org Review URL: https://codereview.chromium.org/610093002 Cr-Commit-Position: refs/heads/master@{#297099}
-
chrome-tpm authored
Cr-Commit-Position: refs/heads/master@{#297098}
-
rogerta authored
BUG=416612 TBR=nyquist@chromium.org, pkasting@chromium.org, courage@chromium.org Tommy: TBR for signin_manager_android.cc Michael: TBR for gaia_web_auth_flow.cc Peter: TBR for auto_login_infobar_delegate.cc Review URL: https://codereview.chromium.org/601643002 Cr-Commit-Position: refs/heads/master@{#297097}
-
danakj authored
Say you have class A and subclass B. Previously it was required to PassAs() a scoped_ptr<B> into a scoped_ptr<A>. This is no longer needed, so just use Pass(). For newly created scoped_ptrs, you can just use make_scoped_ptr always now. And when you want to return or assign an empty scoped_ptr(), you can now use nullptr directly. Also adds PRESUBMIT checks for: - return scoped<T>(foo). This should be return make_scoped_ptr(foo). - bar = scoped<T>(foo). This should be return bar = make_scoped_ptr(foo). - return scoped<T>(). This should be return nullptr. - bar = scoped<T>(). This should be return bar = nullptr. This also replaces p.reset() with p = nullptr; But it does not add a PRESUBMIT check for that because there are things other than scoped_ptr with a reset() function. R=enne@chromium.org Review URL: https://codereview.chromium.org/609663003 Cr-Commit-Position: refs/heads/master@{#297096}
-
viettrungluu authored
R=jamesr@chromium.org Review URL: https://codereview.chromium.org/610083002 Cr-Commit-Position: refs/heads/master@{#297095}
-
xiyuan authored
BUG=418214 Review URL: https://codereview.chromium.org/609983002 Cr-Commit-Position: refs/heads/master@{#297094}
-
viettrungluu authored
R=jamesr@chromium.org Review URL: https://codereview.chromium.org/606143003 Cr-Commit-Position: refs/heads/master@{#297093}
-
rdevlin.cronin authored
Since extension errors are designed to take up the full amount of space, there was no room left for the borders to indicate tab highlighting, and they were slightly cut off. Fix this by adding a tiny bit of room above and below each error, and to the end of the view details link. Screenshots (after and before): http://imgur.com/acdRaXH,XDDIdZ8 BUG=380637 Review URL: https://codereview.chromium.org/599103004 Cr-Commit-Position: refs/heads/master@{#297092}
-
jbauman authored
It's not being used anymore TBR=piman@chromium.org Review URL: https://codereview.chromium.org/606503005 Cr-Commit-Position: refs/heads/master@{#297091}
-
meacer authored
We'll be adding a new type of interstitial for captive portals. This patch is to accomodate that change. BUG=384667 Review URL: https://codereview.chromium.org/600153004 Cr-Commit-Position: refs/heads/master@{#297090}
-
isherman authored
The script currently just verifies that all changes are "git cl format" clean. BUG=none TEST=none R=tengs@chromium.org Review URL: https://codereview.chromium.org/611673002 Cr-Commit-Position: refs/heads/master@{#297089}
-
lambroslambrou authored
Currently, the host list is fetched from the main activity's onStart() handler. If onStart() is triggered again during the process of authentication, this could cause an infinite loop of pending requests. Review URL: https://codereview.chromium.org/607453004 Cr-Commit-Position: refs/heads/master@{#297088}
-
hendrikw authored
The theory is that some of the tests that check mean_pixels_approximated could become worse after my change because PLI's drawn as solid color were not adding its drawn pixels into the calculation. I can't replicate the test, possibly due to lack of throttling on my phone, so the plan is to commit this change and see if the tests go back to normal. Even if it doesn't improve the test, the change is correct and should be committed regardless. BUG=416446 Review URL: https://codereview.chromium.org/607063003 Cr-Commit-Position: refs/heads/master@{#297087}
-
alemate authored
GetUILanguageList didn't check for locale aliases when resolving input method languages. This patch fixes it. BUG=418220 TEST=manual Review URL: https://codereview.chromium.org/608903003 Cr-Commit-Position: refs/heads/master@{#297086}
-
tfarina authored
Nobody knows yet what the right fix should be. So this is just a band-aid, until we figure it out. It isn't bad as it may look like, but certainly far from the ideal as nothing from ui/ should be depending on things declared in chrome/. BUG=374490 TEST=git cl try -c -r HEAD passes on Android. R=sky@chromium.org,primiano@chromium.org Review URL: https://codereview.chromium.org/609963003 Cr-Commit-Position: refs/heads/master@{#297085}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/889f35a..c91b5c8 TBR=ager@chromium.org,zmo@chromium.org Review URL: https://codereview.chromium.org/611643002 Cr-Commit-Position: refs/heads/master@{#297084}
-
brettw authored
We added some #ifdefs in https://codereview.chromium.org/501153003 to support compiling these components with no libvpx to get the GN build linking. Now that chrome links in GN with libvpx, we can remove these since this isn't a configuration we want to support. Review URL: https://codereview.chromium.org/608013004 Cr-Commit-Position: refs/heads/master@{#297083}
-
hendrikw authored
When we apply a perspective to a div, we could end up with a situation where the mapped points end up behind the view. When this happened we would DCHECK, but since this a valid scenario and the rendered results look correct (as far as I can tell), I'm removing the DCHECK. Please see http://jsfiddle.net/kkryf2v4/ for an example where we animate from non-clipped to clipped div. BUG=416367 Review URL: https://codereview.chromium.org/610603003 Cr-Commit-Position: refs/heads/master@{#297082}
-
sky authored
BUG=408650 TEST=none R=ben@chromium.org Review URL: https://codereview.chromium.org/567743005 Cr-Commit-Position: refs/heads/master@{#297081}
-
jbauman authored
Mostly change things to check for existence of surface id as well as a frame provider. Also fix compositor lock handling and OnDelegatedFrameDamage handling. Review URL: https://codereview.chromium.org/606033003 Cr-Commit-Position: refs/heads/master@{#297080}
-
gunsch authored
This provides an interface for special handling of "whitelisted" URLs in internal code. It also denies local file access for Chromecast, except on Android (with a flag). R=lcwu@chromium.org,byungchul@chromium.org BUG=336640 Review URL: https://codereview.chromium.org/598303002 Cr-Commit-Position: refs/heads/master@{#297079}
-
estade authored
BUG=122753 TEST=navigate to madeupsite.com , error message should display normally Review URL: https://codereview.chromium.org/599653003 Cr-Commit-Position: refs/heads/master@{#297078}
-
- 26 Sep, 2014 17 commits
-
-
jamesr authored
This will pretty much always result in a bad build but is only a warning in ninja. Review URL: https://codereview.chromium.org/455193003 Cr-Commit-Position: refs/heads/master@{#297077}
-
rpaquay authored
can take some time to complete, the re-use of a raw pointer stored as member variable (Socket*) is likely to be the root cause of this crash. This can happen is a socket is destroyed in between a call to "connect" (or "send") and the DNS resolution callback is invoked. Both the SocketConnectFunction and SocketSendFunction used to keep a raw pointer to the Socket instance. A call to "destroy" at the "right" time would free the socket instance, leaving both function to access a released object. The fix in this CL is to re-aquire the Socket instance using a socket_id instead of re-using the Socket* instance. If the socket has been destroyed, the socket_id is invalid, and the function fails gracefully. BUG=416741 Review URL: https://codereview.chromium.org/608083002 Cr-Commit-Position: refs/heads/master@{#297076}
-
ananta authored
BUG=413101 Review URL: https://codereview.chromium.org/601663003 Cr-Commit-Position: refs/heads/master@{#297075}
-
hans authored
Revert of Suppress Uninitialized access in ExtensionManagement::Refresh (patchset #2 id:20001 of https://codereview.chromium.org/608063002/) Reason for revert: The Clang roll that caused the Valgrind error was reverted in https://chromium.googlesource.com/chromium/src/+/3c80ac9fd48da3d11852eecd6999053d6d84c56c Original issue's description: > Suppress Uninitialized access in ExtensionManagement::Refresh > > BUG=418234 > TBR=miu@chromium.org > > Committed: https://crrev.com/459b9796ff2ba105e8a6bae4c7e63508ea83bb67 > Cr-Commit-Position: refs/heads/master@{#297028} TBR=miu@chromium.org,oshima@chromium.org NOTREECHECKS=true NOTRY=true BUG=418234 Review URL: https://codereview.chromium.org/610753002 Cr-Commit-Position: refs/heads/master@{#297074}
-
hans authored
Revert of Roll Clang 216630:217949 (patchset #5 id:80001 of https://codereview.chromium.org/587433002/) Reason for revert: Reverting due to http://crbug.com/418234. Clang was branching on undefined values. Original issue's description: > Roll Clang 216630:217949 > > Also make the script revert local changes before 'svn co' > rather than afterwards to avoid merge conflicts if a previously > patched file changes upstream. > > BUG=410810 > > Committed: https://crrev.com/ba4cf8bb6dc77ea033fe13989eb604d6069daa97 > Cr-Commit-Position: refs/heads/master@{#296870} TBR=thakis@chromium.org,brettw@chromium.org NOTREECHECKS=true NOTRY=true BUG=410810 Review URL: https://codereview.chromium.org/614453002 Cr-Commit-Position: refs/heads/master@{#297073}
-
danakj authored
This adds support to use nullptr to construct, assign, or return a scoped_ptr<T> and scoped_ptr<T[]>. Support for this requires the use of a move-only constructor. The changes are: - Add a constructor that takes decltype(nullptr) as a parameter. This allows behaviour such as scoped_ptr<T>(nullptr), but also allows a function with return type scoped_ptr<T> to "return nullptr;" instead of "return scoped_ptr<T>();". - Add an operator=(decltype(nullptr)) that resets the scoped_ptr to empty and deletes anything it held. - Add/Modify a constructor to take a scoped_ptr<U,E>&& parameter for constructing a scoped_ptr from another using move-only semantics. This piece is critical for allowing the function returning nullptr to be assigned to some other scoped_ptr at the callsite. In particular, take the following code: scoped_ptr<T> Function() { return nullptr; } scoped_ptr<T> var = Function(); In this case the constructor which takes a nullptr allows Function() to be written, but not to be used. The move-only constructor allows the assignment from Function() to var. See "C++11 feature proposal: Move-only constructors" on chromium-dev for more explanation why. The scoped_ptr<T> class already had a constructor which took scoped_ptr<U,E> as an argument, so this was changed to be scoped_ptr<U,E>&& instead. The scoped_ptr<T[]> class had no such constructor, so a scoped_ptr&& constructor was added. These match the constructors found on the unique_ptr class. - Remove the RValue type and the contructor that constructs a scoped_ptr from an RValue. Change Pass() to return a scoped_ptr&& instead of a scoped_ptr::RValue, to avoid the type conversion and remove some complexity. This is done with a new emulation macro that still provides Pass() and makes the type go down the MoveOnlyType path in base::Callback code. This adds base_unittests to demonstrate and use these changes. The use of Pass() remains unchanged until std::move() is written or allowed. At that time std::move() could be used instead of Pass. R=brettw@chromium.org, jamesr@chromium.org Review URL: https://codereview.chromium.org/599313003 Cr-Commit-Position: refs/heads/master@{#297072}
-
sky authored
There is nothing worse than stepping through the debugger and suddenly hitting the watchdog timer DCHECK. If you're running under a debugger seems like you don't care about the watchdog thread. So, make it so we don't start watchdog in this case. BUG=none TEST=none R=rtenneti@chromium.org Review URL: https://codereview.chromium.org/573683003 Cr-Commit-Position: refs/heads/master@{#297071}
-
posciak authored
H264 is useful for some users that cannot use VP8. BUG=chromium:414567 TEST=run apprtc and ensure it still uses VP8 where available Review URL: https://codereview.chromium.org/603263004 Cr-Commit-Position: refs/heads/master@{#297070}
-
rdevlin.cronin authored
A BrowserActionView can set its image view for the first time in UpdateState(), but UpdateState() only called SchedulePaint(), and not Layout() (which is necessary for the image). Coincidentally, with all the Layout()s called on BrowserActionsContainer, this only manifested itself in Windows 8 Metro Mode (likely because race conditions caused the image to be updated after all calls to Layout()). BUG=409782 Review URL: https://codereview.chromium.org/608013002 Cr-Commit-Position: refs/heads/master@{#297069}
-
rfevang authored
BUG=418226 Review URL: https://codereview.chromium.org/606923002 Cr-Commit-Position: refs/heads/master@{#297068}
-
thestig authored
Revert of PDF: Add some CHECKS to help debug a crash. (patchset #2 id:20001 of https://codereview.chromium.org/457873003/) Reason for revert: No longer needed. Original issue's description: > PDF: Add some CHECKS to help debug a crash. > > BUG=402035 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289822 TBR=gene@chromium.org NOTREECHECKS=true NOTRY=true BUG=402035 Review URL: https://codereview.chromium.org/607743005 Cr-Commit-Position: refs/heads/master@{#297067}
-
dcheng authored
Unfortunately, they are broken as implemented in MSVS 2013. Review URL: https://codereview.chromium.org/609963004 Cr-Commit-Position: refs/heads/master@{#297066}
-
feng authored
When building the native libraries, insert the version string into native libraries as a section .chromium.verson. BUG=417510 Review URL: https://codereview.chromium.org/599093005 Cr-Commit-Position: refs/heads/master@{#297065}
-
mallinath authored
owners file. Ronghua, let me know if you want to be in OWNERS file. R=ronghuawu@chromium.org,lally@chromium.org,ldixon@chromium.org Review URL: https://codereview.chromium.org/607973003 Cr-Commit-Position: refs/heads/master@{#297064}
-
isherman authored
BUG=409443 TEST=Set up Easy Unlock. Once finished, there shouldn't be an "All set!" notification shown. R=tengs@chromium.org Review URL: https://codereview.chromium.org/537823002 Cr-Commit-Position: refs/heads/master@{#297063}
-
Dominic Mazzoni authored
The key to the fix is adding a category of 'nav' to the entering/exiting dialog notifications. BUG=408821 R=dtseng@chromium.org Review URL: https://codereview.chromium.org/596033002 Cr-Commit-Position: refs/heads/master@{#297062}
-
rsleevi authored
BUG=401365 Review URL: https://codereview.chromium.org/515813002 Cr-Commit-Position: refs/heads/master@{#297061}
-