- 14 May, 2018 40 commits
-
-
Tsuyoshi Horo authored
Bug: 680046 Change-Id: Idbd670dea3fb228e1ce8ed7a53001f7d0d422de4 Reviewed-on: https://chromium-review.googlesource.com/1046485Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#558265}
-
Harald Alvestrand authored
This enables the "sdpSemantic" element of RTCConfiguration, which allows to create an RTCPeerConnection that uses the Unified Plan SDP format. Intent to Ship thread: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/B1Yr62txfwQ Bug: 799030 Change-Id: Ifef01e4d3b65f013a49b17693da0ed6f8364e16d Reviewed-on: https://chromium-review.googlesource.com/1056528Reviewed-by:
-
Simon Zünd authored
This CL adds a counter for sorting non-packed JSArrays where Object.prototype was modified, or the prototype of the instance differs from Array.prototype. This is the Chromium side of the change. The V8-side CL: https://crrev.com/c/1051650 R=jgruber@chromium.org Bug: v8:7382 Change-Id: I46f0963b8b79380fe5c5defa50dba517df77b72c Reviewed-on: https://chromium-review.googlesource.com/1051651Reviewed-by:
-
arthursonzogni authored
This test is a bit flaky: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=headless_browsertests&tests=FocusOfHeadlessWebContents_IsIndependent Furthermore, I am working on https://crbug.com/831155. It causes the frame to commit a navigation more quickly. As a result the frame may stop loading sooner. It causes this test to become even flakier. Why this test is flaky? It waits for the main frame to stop loading by calling WaitForLoad(). Then it waits for the main frame to gain focus by calling WaitForFocus(). In reality, it may gain focus before it stops loading. Since WaitForFocus() doesn't check whether or not the main frame is already focused before waiting, it may wait forever. The CL makes the tests wait for both event to happen, no matter the order. Related CL: https://chromium-review.googlesource.com/c/chromium/src/+/1026993 Bug: 831155 Change-Id: Id9002b3ee2a06ef17d670858688d28959f334e03 Reviewed-on: https://chromium-review.googlesource.com/1053777 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#558262}
-
Bence Béky authored
Bug: 831536 Change-Id: I4d0d859eafdcc89457e5d2224ddc42908e5b41d8 Reviewed-on: https://chromium-review.googlesource.com/1055949 Commit-Queue: Bence Béky <bnc@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#558261}
-
Adam Rice authored
The Great Blink Move resulted in a header file named "web_socket_handshake_throttle.h". Since "WebSocket" is one word, it should be "websocket_handshake_throttle.h". Rename it. BUG=834596 TBR=boliu@chromium.org TBR=kinuko@chromium.org TBR=jialiul@chromium.org TBR=thestig@chromium.org Change-Id: Ifc154d6942b691b70b4d5e7366bebc1bfa3c4218 Reviewed-on: https://chromium-review.googlesource.com/1056892 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#558260}
-
Olivier Robin authored
On iOS10, when dismissing the keyboard, there is a short time when the scroll view containing the suggestion is offset. This cause the omnibox to not be unfocused automatically because of the test in https://cs.chromium.org/chromium/src/ios/chrome/browser/ui/content_suggestions/content_suggestions_header_view_controller.mm?l=516 Fix the issue by always unfocus the omnibox when displaying QR scanner. Bug: 842072 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ie94884a18335753e919c0cd974c26e4a53abac8b Reviewed-on: https://chromium-review.googlesource.com/1055394Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#558259}
-
Marc Treib authored
https://crrev.com/c/996072 removed the files from the build, but failed to actually delete them. Bug: 828890 Change-Id: Ic3adda0fcf5bf051bf7e427018d4732ea2c98c07 Reviewed-on: https://chromium-review.googlesource.com/1057108Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#558258}
-
Rune Lillesveen authored
Clone and reset ComputedStyle When modifying the style of anonymous layout objects inside list items. Bug: 813068 Change-Id: Icd0d9d93d0e64fd130cfb5ba151bce7c34bfb234 Reviewed-on: https://chromium-review.googlesource.com/1053727Reviewed-by:
cathie chen <cathiechen@tencent.com> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#558257}
-
Antonio Gomes authored
CL replaces the uses of URLFetcher and URLFetcherDelegate by SimpleURLLoader in ExtensionWebRequestApiTest::WebRequestURLFetcherInterception. Test is also renamed to WebRequestURLLoaderInterception Note that, it moves some local const char[] declarations up in the current method body (WebRequestURLFetcherInterception), so that they can be used within the Lambda functor. BUG=773295 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I552ee85f72be373a08aa7f36afe3ee83996cef6e Reviewed-on: https://chromium-review.googlesource.com/1053889Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#558256}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/b424d15a6070..8f2f785df9c9 $ git log b424d15a6..8f2f785df --date=short --no-merges --format='%ad %ae %s' 2018-05-10 perezju [soundwave] Create alerts table if needed Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: I327ebb86e592af0ae0dc21225c3805c2b7015bd7 Reviewed-on: https://chromium-review.googlesource.com/1056797Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#558255}
-
Yuta Kitamura authored
This is a purely cosmetic change -- the behavior remains the same. Currently, WebThreadScheduler::*TaskRunner() returns a scoped_refptr, while ThreadScheduler::*TaskRunner() returns a raw pointer. This incon- sistency causes a small trouble in a later patch, so this patch lets those functions always return scoped_refptr. Bug: 826203 Change-Id: Ie448c8bc39d395c27a2565a762222bb38e63c7e2 Reviewed-on: https://chromium-review.googlesource.com/1056894Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
-
yiyix authored
In the current chrome, SetBackgroundColor is called to set |background_color_| of a RenderWidgetHost, and it called by over 14 callers that can change |background_color_| simultaneously. Any changes in the background color can easily cause races and bugs like: crbug.com/830540 and crbug.com/719230. This cl is aimed to create a more systematical way to update root background color, so that it's easier to update the root background color in the future. A design doc on all SetBackgroundColor analysis: https://docs.google.com/document/d/1GLJzDVYuOsnTjysYAnCDWxUFofvxDBHtqTgYE60sEC8 Bug:830540 Change-Id: I16472d11c53b707536c9aa65c6a660188d1f4d22 Reviewed-on: https://chromium-review.googlesource.com/1029733 Commit-Queue: Yi Xu <yiyix@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#558253}
-
Marc Treib authored
Making (Un)RegisterAuthNotifications private, and merging QuerySyncStatusSummary into *String and removing the enum. Bug: 839834 Change-Id: Id27dd36468b7893817569982c48653e2a817c5e6 Reviewed-on: https://chromium-review.googlesource.com/1055570Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#558252}
-
Hajime Hoshi authored
Change-Id: I14cf01e80dfccd9fa7d9a98346b21c2045d15c12 Reviewed-on: https://chromium-review.googlesource.com/1056911Reviewed-by:
-
Christian Dullweber authored
Change HistoryServiceObservers to use the new OnUrlsDeleted method. Bug: 839798 Change-Id: I01d159fdac5f0cf6463a62de76923c0658325da7 Reviewed-on: https://chromium-review.googlesource.com/1051907 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#558250}
-
chromeos-commit-bot@chromium.org authored
BUG=762641 TBR=alemate@chromium.org Change-Id: I20a841e7a2e46597ce1519c2e19a75247d6c7a57 Reviewed-on: https://chromium-review.googlesource.com/1056809Reviewed-by:
ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Commit-Queue: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#558249}
-
Michael Lippautz authored
This reverts commit fd28a8d4. Reason for revert: See crbug.com/840696 Original change's description: > [oilpan] Bailout on unused HeapVectorBacking<Member<T>> slots > > Bail out on zeroed memory for HeapVectorBacking<Member<T>> instead > of further dispatching through TraceTraits to Visitor. > > Bug: chromium:840696 > Change-Id: I071858b597d3de82710b89990bd2fa942acb964e > Reviewed-on: https://chromium-review.googlesource.com/1051988 > Commit-Queue: Michael Lippautz <mlippautz@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#557276} TBR=haraken@chromium.org,keishi@chromium.org,hpayer@chromium.org,mlippautz@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:840696 Change-Id: If2c7b918ba80b5d31c9240e6c4af44978079ae9a Reviewed-on: https://chromium-review.googlesource.com/1057107Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#558248}
-
Noel Gordon authored
QuickView/FileManagerBrowserTest/Test0,1,2 (3 tests). The tests do the following: Test/0 open QuickView Test/1 open then close QuickView Test/2 open then close then open QuickView again The first two tests have run-time that is already near bot time limits so Test/2 trying to open QuickView again will likely exceed bot limits regularly and FAIL even in RELEASE. Remove this test. Bug: 836254,808745 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Icb91410cd095a305e1d9b189e5139c49c22cd39c Reviewed-on: https://chromium-review.googlesource.com/1055911Reviewed-by:
Naoki Fukino <fukino@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#558247}
-
Anders Hartvoll Ruud authored
This fixes a bug where the application of 'zoom' would be ignored, because: the effective zoom was reset in preparation of applying the zoom, yet we did not apply the zoom if the incoming value was equal the current value. This means if you apply the same zoom value twice to the same element, the effective zoom of that element becomes the parent's effective zoom. This patch fixes this by setting the effective zoom from the style resolver directly, instead of doing it inside ComputedStyle::SetZoom and _hoping_ that ComputedStyle::EffectiveZoom() currently returns the right value. Note: The 'state.SetZoom(1.0f)'-ery is there to maintain the behavior in which the effective zoom becomes the parent's zoom whenever zoom:0[%] is used. Note2: The return value of ComputedStyle::SetZoom is probably not interesting anymore. In fact, 'zoom' could probably be de-specialized. (Separate patch). R=dominicc@chromium.org, futhark@chromium.org Bug: 807503 Change-Id: I50cb7c1116da463fa59b745d2d31ef942be9085b Reviewed-on: https://chromium-review.googlesource.com/1054075Reviewed-by:Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#558246}
-
Greg Kraynov authored
Moving scheduler/base to //base incurs enormous diff and git doesn't detect file moves well enough as a result. This CL mitigates that by dropping base:: prefixes before the move, which will happen soon, so that temporary inconsistency won't stay long. Bug: 783309 Change-Id: Iad4b2823e3304c0cb5c6a2745adf1f5f4255d4ee Reviewed-on: https://chromium-review.googlesource.com/1035269 Commit-Queue: Greg Kraynov <kraynov@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
-
Bence Béky authored
Clean up some corner cases concerning HTTP/2 pushed streams. I plan to add a histogram that records every possible outcome of receiving a pushed stream, and it is cleaner if impossible cases are not handled with an early return, but they are simply documented by a DCHECK. Note that GetPromisedUrlFromHeaders() guarantees a lot of things about the pushed request: if the scheme is not http or https, or if the method is not GET or HEAD, then it returns an invalid URL. Therefore there is no need to handle these cases explicitly in SpdySession. There is test coverage in SpdyNetworkTransactionTest that enforces this. Bug: 831536 Change-Id: Ic3dae56b026598fa2965c8eee0db02cfbc95eb06 Reviewed-on: https://chromium-review.googlesource.com/1055760 Commit-Queue: Bence Béky <bnc@chromium.org> Reviewed-by:
-
Hayato Ito authored
https://crrev.com/517033 still misses a case where shadow trees are nested, which was the cause of DCHECK [1] failure of the test [2]. This CL fixes that. [1] https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/dom/node.cc?q=MayContainLe&sq=package:chromium&l=773 [2] virtual/incremental-shadow-dom/media/controls/overlay-play-button-document-move.html. Bug: 776656,783055 Change-Id: I22005d1518768c1750be33a818d25230efa26b76 Reviewed-on: https://chromium-review.googlesource.com/1056927 Commit-Queue: Hayato Ito <hayato@chromium.org> Reviewed-by:
Takayoshi Kochi <kochi@chromium.org> Cr-Commit-Position: refs/heads/master@{#558243}
-
Darren Shen authored
Just replacing NULLs with nullptrs. TBR as it is trivial. TBR=yhanada@chromium.org Change-Id: I498b81a926ec8cbd342735223f2c5e47624cb725 Reviewed-on: https://chromium-review.googlesource.com/1056453Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#558242}
-
Han Leon authored
We reverted the original CL https://chromium-review.googlesource.com/c/chromium/src/+/981898 by https://chromium-review.googlesource.com/c/chromium/src/+/1041050 because we wanted to solve the crash in bug 838397 immediately at the time, but after that we have landed its real fix https://chromium-review.googlesource.com/c/chromium/src/+/1036498, so now we can reland this one. The only change from the original CL is that we do not re-enable the test ServiceWorkerLazyBackgroundTest#EventsAfterRestart in this CL, because it proved that this CL cannot really solve it, we need further investigation on it (tracker issue: 834200). BUG=745327,834183 TBR=shimazu,falken,kinuko Change-Id: Id5dedfc914b1526af2ea510ef890b768456982cf Reviewed-on: https://chromium-review.googlesource.com/1056796Reviewed-by:
Han Leon <leon.han@intel.com> Commit-Queue: Han Leon <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#558241}
-
Matt Falkenhagen authored
I suspect the linked crash bug is due to ServiceWorkerProviderHost or ServiceWorkerHandle being deleted twice. Bug: 838410 Change-Id: I695978c0d7fdbe96ac0eb411bc6cac80854c2079 Reviewed-on: https://chromium-review.googlesource.com/1056782Reviewed-by:
-
Hajime Hoshi authored
The task runner is used at HandlePendingEventsAndPromises, and I think an unthorttled task runner is not necessary here. Note that the original task runner before kUnthrottled was the default timer task runner, which has gone. Related CLs: - https://chromium-review.googlesource.com/c/chromium/src/+/822931 Use the content's kUnthrottled task runner instead of the default timer task runner for FontFaceSet. - https://chromium-review.googlesource.com/c/chromium/src/+/928186 Remove the defualt timer task runner. We plan to eliminate kUnthrottled, kUnspecedTimer and kUnspecedLoading and replace them with appropriate kInternal* task types. Task type guideline: https://bit.ly/2vMAsQ4 Bug: 836410 Change-Id: I40fb6bd63ee657b68d86f952d6517254ffbf4b51 Reviewed-on: https://chromium-review.googlesource.com/1055031Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium e9455026. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/17600 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/resources TBR=markdittmer No-Export: true Change-Id: I8cdc2a65d0e01d3ab179b6ba154c0c286938ecc7 Reviewed-on: https://chromium-review.googlesource.com/1056331 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#558238}
-
Yuki Shiino authored
Change-Id: I00c7a48e7b978bf2a7d34d0deeb0c345b6e7f651 Reviewed-on: https://chromium-review.googlesource.com/1056899Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#558237}
-
Mirko Bonadei authored
Reason for revert: Breaks a WebRTC video test (speculative revert). Bug: libyuv:798, webrtc:9263 Change-Id: I1edcc8cde1f1ccf74b1b780faac9aace53750099 Reviewed-on: https://chromium-review.googlesource.com/1057087 Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#558236}
-
Colin Blundell authored
The GCMAccountTracker and AccountTracker classes listen for the GoogleSigninSucceeded/GoogleSignedOut callbacks indirectly via ProfileIdentityProvider. Their unittests cause these callbacks to fire via calls to FakeIdentityProvider::{LogIn, LogOut}. These classes are also used on ChromeOS, where the callbacks will never fire (ChromeOS does not use SigninManager, which fires the callbacks). The structure of these unittests presents a challenge to refactoring the production code to depend on SigninManager directly: the SigninManagerBase test infrastructure, which is all that can be used on ChromeOS, rightfully has no mechanism for firing the callbacks. This CL rationalizes these tests for ChromeOS via: - Commenting out the tests that actually exercise the callbacks firing - Changing the rest of the tests to simply set the primary account info *without* causing the callbacks to fire - Renaming utility functions as relevant to make the structure clear Making this change paves the way for a followup change that ports these classes (and their tests) to depend directly on SigninManager. Bug: 809923 Change-Id: Ia6c067d845f7bbb7bd78928ac163bda2fdd77a20 Reviewed-on: https://chromium-review.googlesource.com/1042391Reviewed-by:Peter Beverloo <peter@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#558235}
-
Esmael El-Moslimany authored
Bug: 841509 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Idf57751875b2ffe762476b33f9b0af66f3ea76c8 Reviewed-on: https://chromium-review.googlesource.com/1054609Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#558234}
-
Christian Dullweber authored
Change HistoryServiceObservers to use the new OnUrlsDeleted method for predictors and favicon_cache. Bug: 839798 Change-Id: Ibcf4d48eabe3649282c2246be73e8a8d263dc98d Reviewed-on: https://chromium-review.googlesource.com/1051888Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Alexandr Ilin <alexilin@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#558233}
-
Christian Dullweber authored
Change HistoryServiceObservers to use the new OnUrlsDeleted method. Bug: 839798 Change-Id: Ia5e01bcf60a43d7b1112f69f816a06e9ae1e51ab Reviewed-on: https://chromium-review.googlesource.com/1051767Reviewed-by:
-
Kent Tamura authored
Mark virtual/video-surface-layer/media/controls/modern/doubletap-to-jump-forwards-too-short.html flaky. TBR=steimel@chromium.org NOTRY=true Bug: 831720 Change-Id: I4c57a348bc782c74a26b1fd3a8f224b1a29004f0 Reviewed-on: https://chromium-review.googlesource.com/1056909Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#558231}
-
Mirko Bonadei authored
Abseil requires some warning suppressions that should not be propagated to other projects. Starting from this CL Abseil headers will be included using -isystem instead of -I. Bug: webrtc:8821 Change-Id: I54e0a9d4d9d7122e8fca91d61227f87160f0b373 Reviewed-on: https://chromium-review.googlesource.com/1026650 Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#558230}
-
arthursonzogni authored
This is similar to a previous CL: https://chromium-review.googlesource.com/c/chromium/src/+/1051908 All of these tests are using: window.onload = setTimeout([...], 0); The issue is that setTimeout is executed immediately instead of on load. Bug: 831155 Change-Id: I913b8c04de5d583ef87c91dfc23d4ba8be8ba642 Reviewed-on: https://chromium-review.googlesource.com/1055391Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#558229}
-
Kent Tamura authored
* normaliza_and_sort_includes(): - Fix the normalization. The output directory is now "gen/third_party/blink/", not "gen/blink/". - produce repo-root-relative paths instead of blink-relative paths. Bug: 830255, 842413 Change-Id: Ia99af5830f3cc67cb25e3e26ff24d0941f38effa Reviewed-on: https://chromium-review.googlesource.com/1056967 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#558228}
-
Mirko Bonadei authored
Chromium already has dynamic_annotations in //base/third_party and the Abseil version causes ODR violations and macros conflicts. On top of that, the Abseil version wants to include a NaCL header but the build environment does not configure the correct include path. Since NaCL doesn't need dynamic_annotations (see [1]) and they are also deprecated from Chromium (see [2]), this CL renames all the functions and the macros defined by the Abseil copy and confines the usage of Abseil's dynamic_annotations to Abseil itself (using GN visibility). When Abseil will be rolled into Chromium's third_party, a script will take care of renaming everything. [1] - https://cs.chromium.org/chromium/src/base/third_party/dynamic_annotations/BUILD.gn?l=6&rcl=b3c2f366fdcdbe3388b3fda45ae475d4e66dfa88 [2] - https://cs.chromium.org/chromium/src/base/third_party/dynamic_annotations/README.chromium?l=6&rcl=6ef06b461ccae125f8c8d6e33dde10c550ff3780 Bug: webrtc:8821 Change-Id: I83a4b6caafc30e457cf67fa21eaea9d071a9eecf Reviewed-on: https://chromium-review.googlesource.com/1049628Reviewed-by:
-
Yuta Kitamura authored
All overridden implementations of ThreadScheduler's interfaces are no-op, so they can be removed without breaking any functionalities. WebMainThreadScheduler's interfaces actually have some implementation. However, they are not used by any production code, and only a few tests depend on them. There functions are perhaps the remnants of past refactoring. Since nobody seems to rely on them currently, they can be removed entirely. Bug: 826203 Change-Id: Ic8efe0afe09270c080bc7706287937a6da354ae1 Reviewed-on: https://chromium-review.googlesource.com/1055142Reviewed-by:
-
