- 19 Oct, 2018 40 commits
-
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/80c79964c796..7a5d83bcb62f git log 80c79964c796..7a5d83bcb62f --date=short --no-merges --format='%ad %ae %s' 2018-10-18 fmayer@google.com profiling: Add heapprofd.rc. 2018-10-18 fmayer@google.com profiling: Add malloc hooks. Created with: gclient setdep -r src/third_party/perfetto@7a5d83bcb62f The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I1d8618dccb54f33d72d0439b60d28e278d5f58a1 Reviewed-on: https://chromium-review.googlesource.com/c/1290780Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601110}
-
Gauthier Ambard authored
This CL converts the DataplanUsageCollectionViewController to UITableViewController. It also adds the cellBackgroundColor property to the styler so the cells can have a background color different from the table view's background. It also adds an accessoryType for the DetailTextItem. Bug: 894791 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ie1332811d3df6d8ef7650fb34fa3a17a515da3d9 Reviewed-on: https://chromium-review.googlesource.com/c/1286142 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#601109}
-
Mohamed Amir Yosef authored
This CL adds the support to convert GCMMessages to/from JSONObject In preparation for later patches that would actually persist GCMMessages in SharedPreferences as JSONObjects. GCMMessages are persisted for lazy FCM subscription that don't require immediate delivery if Chrome is not in the foreground. Bug: 882887 Change-Id: I674eae93262ee339c574b2f18da206785ebbadfb Reviewed-on: https://chromium-review.googlesource.com/c/1283609 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#601108}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/67ed0448..ea377862 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id35ec14911b0a29fa93f9ceb17245618542aa257 Reviewed-on: https://chromium-review.googlesource.com/c/1290779Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601107}
-
Christian Dullweber authored
This reverts commit 7a77c4e0. Reason for revert: Findit identified that this introduced flakiness and it looks reasonable. Please take a look Original change's description: > [Task Scheduler]: Merge blocking and non-blocking pools. > > This CL creates a feature experiment that removes blocking worker pools > from the task scheduler. Tasks with MayBlock trait are instead posted to > the usual foreground/background pool, giving us better control over scheduling. > > Note: ScopedBlockingCall is used to add extra workers to the pool when a task is > blocking. In this CL, we take advantage of this behavior to make sure enough > workers are running on the CPU. > > Bug: 874080 > Change-Id: I7889a941f82203388c259b0d96073eb5ddf3de69 > Reviewed-on: https://chromium-review.googlesource.com/c/1249836 > Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Reviewed-by: Robert Kaplow (sloooow) <rkaplow@chromium.org> > Cr-Commit-Position: refs/heads/master@{#600401} TBR=gab@chromium.org,fdoray@chromium.org,rkaplow@chromium.org,etiennep@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 874080, 897014 Change-Id: I5d125aba916dfb0dfce791b4d0a5b1ca5e6035d9 Reviewed-on: https://chromium-review.googlesource.com/c/1290152Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#601106}
-
Daniel Bratell authored
The target :make_core_generated_css_value_id_mappings was listed twice which made its output be twice in some sources lists. This confused some tools. Seems better to only have it there once. R=fs@opera.com Change-Id: I1da2cfbda7021fa5262d0c0a74b894989fc200de Reviewed-on: https://chromium-review.googlesource.com/c/1290929Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#601105}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/237fb2a03b4b..2f3bd7e85ec6 git log 237fb2a03b4b..2f3bd7e85ec6 --date=short --no-merges --format='%ad %ae %s' 2018-10-19 perezju@chromium.org [soundwave] Refactor database connection management Created with: gclient setdep -r src/third_party/catapult@2f3bd7e85ec6 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:879526 TBR=sullivan@chromium.org Change-Id: I466a38fe2444294772f1634b0a50d45de102fdde Reviewed-on: https://chromium-review.googlesource.com/c/1290777Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601104}
-
Gauthier Ambard authored
This CL creates a DetailTextItem for the TableView. This is a replacement for the SettingTextItem used in CollectionView. Here is a screenshot on the Table Cell Catalog, the cell with "Item with two labels" and "The second label..." https://drive.google.com/file/d/1cgTIs8h7mR8Ae8rnYSjvYZu9sMeqwxmX/view Bug: 894791 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Iab73928fca89131f326c7bbfc3c2bbb16fff5442 Reviewed-on: https://chromium-review.googlesource.com/c/1286141 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#601103}
-
Etienne Pierre-doray authored
This CL uses ScopedBlockingCall to mark blocking calls in /content/browser/tracing. This CL was created by replacing calls to AssertBlockingAllowed() with instantiations of ScopedBlockingCall(MAY_BLOCK). I kindly ask the reviewer to make sure of the following: - ScopedBlockingCall is instantiated in a scope with minimal CPU usage. If this is not the case, ScopedBlockingCall should be instantiated closer to the blocking call. See scoped_blocking_call.h for more info. Please let me know when/where the blocking call happens if this needs to be changed. - Parameter |blocking_type| matches expectation: MAY_BLOCK: The call might block (e.g. file I/O that might hit in memory cache). WILL_BLOCK: The call will definitely block (e.g. cache already checked and now pinging server synchronously). See BlockingType for more info. While I assumed MAY_BLOCK by default, that might not be the best fit if we know that this callsite is guaranteed to block. - The ScopedBlockingCall's scope covers the entirety of the blocking operation previously asserted against by the AssertBlockingAllowed(). This CL was uploaded by git cl split. R=simonhatch@chromium.org Bug: 874080 Change-Id: I947898f0650e7a14a3133a4114c7fc30f326dedc Reviewed-on: https://chromium-review.googlesource.com/c/1191806 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#601102}
-
Jérôme Lebel authored
When the user refuse to sign-in with a managed account the current UnifiedConsentCoordinator should be reused instead of creating a new UnifiedConsentCoordinator instance. Bug: 872288 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ib851ba3337fa95a39608397f82e336b65000f579 Reviewed-on: https://chromium-review.googlesource.com/c/1288435Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#601101}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I890421bde5ace59508d35b9435fe5699d4690fa0 Reviewed-on: https://chromium-review.googlesource.com/c/1290782Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601100}
-
Fredrik Söderquist authored
This moves code for transforming a HitTestLocation using with an AffineTransform from the helper function SVGLayoutSupport::TransformToUserSpaceAndCheckClipping into a helper class TransformedHitTestLocation. Calls to SVGLayoutSupport::IntersectsClipPath are hoisted into callers and SVGLayoutSupport::TransformToUserSpaceAndCheckClipping is removed. Change-Id: I52f95ba2480df86a509285c2ec2edea776517bc6 Reviewed-on: https://chromium-review.googlesource.com/c/1282930Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#601099}
-
Christian Dullweber authored
This reverts commit 8bd7e583. Reason for revert: Still flaky :( https://ci.chromium.org/p/chromium/builders/luci.chromium.try/mac_chromium_rel_ng/166516 Original change's description: > Reenable GPUProcessCrashesExactlyOncePerVisitToAboutGpuCrash > > This was flaky, but should be fixed. > > Bug: 878258 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Change-Id: I3e037e41339ddff9d46ec0a7ca7679064a3322e0 > Reviewed-on: https://chromium-review.googlesource.com/c/1285526 > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Commit-Queue: enne <enne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#600813} TBR=kbr@chromium.org,enne@chromium.org Change-Id: I0dd172bd7db86982f9b1bf49e2a57c059958d348 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 878258 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/c/1290950Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#601098}
-
Jérôme Lebel authored
Adding -UnifiedConsentCoordinator.identitySelectedByUser to track when the user selects an identity. This is to make sure the identity chooser dialog is opened automatically only when the user didn't select an identity yet. Bug: 896709 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ib849ac7d385910398f62bf7e7e933f79983e3691 Reviewed-on: https://chromium-review.googlesource.com/c/1288790Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#601097}
-
Yoshifumi Inoue authored
This patch renames |ContainsOnlyASCII()| to |ContainsOnlyASCIIOrEmpty()| as consistency with the patch[1] for improving readability. Note: All renaming is done by global replace tool. This patch similar to the patch[2] which renames |ContainsOnlyLatin1()|. [1] http://crrev.com/c/1288157 Rename ContainsOnlyWhitespace() to ContainsOnlyWhitespaceOrEmpty() [2] http://crrev.com/c/1288501 Rename ContainsOnlyLatin1() to ContainsOnlyLatin1OrEmpty() Change-Id: I666c4e3a6c74d59ab8cd6b74bdf011c0e06d0b0c Reviewed-on: https://chromium-review.googlesource.com/c/1288502 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#601096}
-
Amos Lim authored
Generated header files need to follow chromium style on header guards. Update bindings/tests/results files with run_bindings_tests. third_party/blink/tools/run_bindings_tests.py --reset-results This CL has no behavior changes. Bug: 896720 Change-Id: I76a467e088a9ac004a0b33a9661e25158cb670ac Reviewed-on: https://chromium-review.googlesource.com/c/1288167Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Amos Lim <eui-sang.lim@samsung.com> Cr-Commit-Position: refs/heads/master@{#601095}
-
David 'Digit' Turner authored
This CL slightly reduces the size of libchrome.so by removing the SysV symbol hash tables from them (only the GNU ones, which are now supported by the crazy linker [1], will be included). Note that this is not needed for libmonochrome.so which already does that. + Only use one SysV format table for libchromium_android_linker.so since it is always loaded by the system linker, on platforms that do not support the GNU format. This saves 445 bytes in ChromePublic.apk (woohoo!). [1] https://chromium-review.googlesource.com/c/chromium/src/+/1216122 BUG=851391 R=agrieve@chromium.org, pasko@chromium.org, rmcilroy@chromium.org, cjgrant@chromium.org Change-Id: I9ed7901312a25cda3b77440c32a1a2645e14beca Reviewed-on: https://chromium-review.googlesource.com/c/1254441 Commit-Queue: David Turner <digit@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#601094}
-
Mario Sanchez Prada authored
This includes migrating away of SigninManagerBase::Observer as well as from OAuth2TokenService::Observer, as all APIs in use are now available via IdentityManager::Observer. Bug: 887455 Change-Id: Ia21ae43e5c6a2554e837760485688f917dea1ad8 Reviewed-on: https://chromium-review.googlesource.com/c/1288277Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#601093}
-
Mirko Bonadei authored
First step in a series of small CLs to try to remove old dependencies and build targets that are not used anymore. Bug: 896154 Change-Id: Id3343e73b182c7468e9da2f68bdd7986b29e3987 Reviewed-on: https://chromium-review.googlesource.com/c/1286859Reviewed-by:
Henrik Grunell <grunell@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#601092}
-
Daniel Bratell authored
Not all sources lists have been kept up to date with code movement/removal and it seems to make some isolate steps in cq sad for some CLs (mine). Change-Id: I5db5e075cf4d01783fb44660ee008ea0fa9a26c6 Reviewed-on: https://chromium-review.googlesource.com/c/1288871Reviewed-by:
Yuki Awano <yawano@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#601091}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ebc5860af783..0a5c62aa1bec Created with: gclient setdep -r src-internal@0a5c62aa1bec The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I820fb4eff8e8378ccd4aec29d48e1c1de9fab9ee Reviewed-on: https://chromium-review.googlesource.com/c/1290769Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601090}
-
Daniel Bratell authored
Not all sources lists have been kept up to date with code movement/removal and it seems to make some isolate steps in cq sad for some CLs (mine). This is mostly that harfbuzz-ng has stopped using the suffix "-private" on headers. Change-Id: I6f3bd45378b011c8ea33fa98053c507fbdc68ed2 Reviewed-on: https://chromium-review.googlesource.com/c/1288791Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#601089}
-
Yoshifumi Inoue authored
This patch gets rid of redundant call of |EmitEndBlock()| after calling ProcessChildrenWithRequiredLineBreaks() which calls |EmitEndBlock()| at end of function in |Element#innerText| for improving code health. Since EmitEndBlock() turns |has_collapsible_space_| to false, second call has no effect. Change-Id: I44012380d7335b33f901954ac24a85e9cd4e98b4 Reviewed-on: https://chromium-review.googlesource.com/c/1290058Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#601088}
-
Arthur Sonzogni authored
In bug 882661: one mojo::URLLoader is sending OnStartLoadingResponseBody without sending OnReceiveResponse before. Add instrumentation to check this never happen with this class. Bug: 882661 Change-Id: I8a157949feacfe65f0ea1aa8c32b28352d6d6f57 Reviewed-on: https://chromium-review.googlesource.com/c/1288595 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#601087}
-
Mario Sanchez Prada authored
Neither SigninManager nor ProfileOAuth2TokenService are in use anymore, we can safely remove them. Bug: 885174 Change-Id: I9ea858295b2bb868b7a8bdbb73ec34927041fbac Reviewed-on: https://chromium-review.googlesource.com/c/1288438 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#601086}
-
Yoshifumi Inoue authored
This patch gets rid of unused function |HasCollapsibleSpace()| from |ElementInnerTextCollector::Result| for improving code health. Change-Id: I2bd15fe2f8837f098d42dded7202e14ecf42eac9 Reviewed-on: https://chromium-review.googlesource.com/c/1290432Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#601085}
-
Jérôme Lebel authored
Replacing bzanotti by jlebel ios/chrome/browser/ui/first_run/OWNER, since bzanotti doesn't work on Chrome anymore. Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I5defa6613f4e49dfd5a94a06539f44bf8a4ad379 Reviewed-on: https://chromium-review.googlesource.com/c/1288541Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#601084}
-
Takuto Ikuta authored
This CL is part of https://chromium-review.googlesource.com/c/chromium/src/+/1286016 This CL was uploaded by git cl split. R=jkrcal@chromium.org Bug: 753973 Change-Id: Id1503ebb271fd19492e49d98e821412d67cbc5aa Reviewed-on: https://chromium-review.googlesource.com/c/1288171Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#601083}
-
Jérôme Lebel authored
The sign-in/firstrun buttons is moved inside the safe area (related to the iPhone X like). The patch has been tested with rotation. ** Before ** - First run: https://drive.google.com/open?id=1Ig3SCaKTeCZkf3KfCnRHfPpAA9mZdLSB - Sign-in with first run: https://drive.google.com/open?id=1arrBQ44c9kj7_R8xIykEfxLcJZjfTlZT - Sign-in portrait: https://drive.google.com/open?id=17UlTFkc416iU72LeMFgg9PoEG-gRVXCc - Sign-in landscape: https://drive.google.com/open?id=1pqC00vqx6AtHDJHXSxc_0yZ2Qr_1O66l ** After ** - First run: https://drive.google.com/open?id=1c6rJtftJInGlNgLTj19jmsbzgRf3hQZv - Sign-in with first run: https://drive.google.com/open?id=19GRHlX6HdyO5HnPkVDzKCbxfcwSsyFyn - Sign-in portrait: https://drive.google.com/open?id=187VDZsNLMzI50q4RLi2eAaLsXs7aZ6Zm - Sign-in landscape: https://drive.google.com/open?id=1Q_WCYA8-JMI5cRtshLKAjFIXk9vLaNEn Bug: 864225 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I33478974bbb0de2180ab842eb07321dcf5140ed0 Reviewed-on: https://chromium-review.googlesource.com/c/1286659Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#601082}
-
Fredrik Söderquist authored
Store the (stroke) geometry class in the LayoutSVGShape. This allows us to compute stroke bounds in a slightly less "context-aware" way. This is a step on the way to break up UpdateShapeFromElement into several steps. We can also get rid of LayoutSVGPath::HitTestStrokeBoundingBox since we now carry the information it provided in the geometry class. The geometry class also replaces the LayoutSVGShape::affected_by_miter_ so it is removed, and replaced with a new kNoMiters class type. Bug: 435097, 493888 Change-Id: I422b72451c6cea8045dea547a500984863e83a8d Reviewed-on: https://chromium-review.googlesource.com/c/1288359 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#601081}
-
Erik Luo authored
Password manager may analyze a page and report errors to DevTools: "[DOM] Found N elements with non-unique id#id: (More info:...)" This CL changes the level to warning, since duplicates do not break execution flow. Bug: 825184 Change-Id: Ia7bb544f712e14bc99a7fdf7d912fa70c2a4d5c7 Reviewed-on: https://chromium-review.googlesource.com/c/1064978Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#601080}
-
Takashi Sakamoto authored
Bug: 888904 Change-Id: I1d11d01e7adb51ec15d921c359d0e5171d00cb87 Reviewed-on: https://chromium-review.googlesource.com/c/1286241Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#601079}
-
Noel Gordon authored
FilesApp provides the innards of the extension file dialog. For tablet mode tests, always enable the Ash virtual keyboard and add a test that clicks dialog filename <input> element and checks that the Ash virtual keyboard appears. The virtual keyboard test and enable-features=SingleProcessMash do not play nice at this time: exclude this test from single process mash. Bug: 879434, 897012 Change-Id: Ia5a72abd3fcdbd12282c36b27cc1213fd7e6672b Reviewed-on: https://chromium-review.googlesource.com/c/1290571 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#601078}
-
Koji Ishii authored
Following bot results are included. 10805 10807 10816 10819 10820 10830 10836 10848 10851 10854 75 lines were removed and 2 lines were deflaked by consecutive results since 10792. New failures are from 'text-indent' changes in r600989 (CL:1285109). TBR=eae@chromium.org, mstensho@chromium.org, szager@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I13d5c2d6033ac237cc7d867490c4896702c0c2f6 Reviewed-on: https://chromium-review.googlesource.com/c/1288151 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#601077}
-
Christian Dullweber authored
This reverts commit dcf5246f. Reason for revert: It looks like this broke web_tests on linux-xenial-rel Original change's description: > [run_web_tests] Initialize printer earlier > > This allows logging before creating the port. > > Bug: 896799 > Change-Id: I3198fcaeb8d64d748a12d9882cddc273a9e3efe6 > Reviewed-on: https://chromium-review.googlesource.com/c/1289305 > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Reviewed-by: Ned Nguyen <nednguyen@google.com> > Cr-Commit-Position: refs/heads/master@{#601049} TBR=wangxianzhu@chromium.org,dpranke@chromium.org,nednguyen@google.com,robertma@chromium.org Change-Id: I71ae432b2db53611d6cd44d788d8f450e714ba78 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 896799, 897019 Reviewed-on: https://chromium-review.googlesource.com/c/1290151Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#601076}
-
Marina Ciocea authored
Stat reporting was incorrect, and it's no longer needed because it's covered by the more generic stats ChildProcess.Crashed.UtilityProcessHash and ChildProcess.Launched.UtilityProcessHash. Bug: 866909 Change-Id: I89622417e3923f9a95d4553f95a369341499bbcf Reviewed-on: https://chromium-review.googlesource.com/c/1286856 Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#601075}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/95c5c15bdec9..b4d999866772 git log 95c5c15bdec9..b4d999866772 --date=short --no-merges --format='%ad %ae %s' 2018-10-19 briannorris@chromium.org cros flash: produce valid alternate GPT Created with: gclient setdep -r src/third_party/chromite@b4d999866772 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I2f93bfa22f8f1076267877032f99d3ce05778e44 Reviewed-on: https://chromium-review.googlesource.com/c/1290107Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601074}
-
Daniel Bratell authored
An android specific block in BUILD.gn kept some references to files that no longer existed after a cleanup in https://chromium-review.googlesource.com/896839 This caused some local issues with trybots so it was time to clean up the build files. Bye unnecessary code block. Bug: 808221 Change-Id: I29ff4fc149fe408bd2a97517fbc338b408d13e7d Reviewed-on: https://chromium-review.googlesource.com/c/1290272Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#601073}
-
Javier Ernesto Flores Robles authored
Adds a flag wich resets after a delay when the device rotates. This allows to know if certain notification are caused due a recent rotation. Bug: 845472 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I7b36544a451c677ff0ff842876f80841847a2833 Reviewed-on: https://chromium-review.googlesource.com/c/1273145 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#601072}
-
David Jean authored
Bug: 894031 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ib7d7e07e198043f8aacbbf78eef30a496be6550d Reviewed-on: https://chromium-review.googlesource.com/c/1288530Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#601071}
-