Commits · 6bac980bdd30b808740a740d4022f95fc9fc10d8 · eriksson monteiro / tangled

13 Mar, 2011 26 commits

Sort some test expectations into a better place. Move a linux debug · 6bac980b

levin@chromium.org authored Mar 13, 2011

crash to be near the other instances of it.

Remove fast/text/font-size-zero.html as it appears to be passing consistently.

Add the expectation for bug1318.html due to r80806 changing its output in a way
that looks less optimal than it did before.

* platform/chromium/test_expectations.txt:

git-svn-id: svn://svn.chromium.org/blink/trunk@80973 bbb929c8-8fbe-4397-9dbb-9b2b20218538

6bac980b

Bug 56273 - Add three operand forms to MacroAssember operations. · d8b90842

barraclough@apple.com authored Mar 13, 2011

Reviewed by Sam Weinig.

Adding for X86(_64) for now, should be rolled out to other backends as necessary.
These may allow more efficient code generation in some cases, avoiding the need
for unnecessary register-register move instructions.

* assembler/AbstractMacroAssembler.h:
(JSC::AbstractMacroAssembler::Jump::link):
(JSC::AbstractMacroAssembler::Jump::linkTo):
    - marked these methods const.
(JSC::AbstractMacroAssembler::Jump::isSet):
    - add a method to check whether a Jump object has been set to
      reference an instruction, or is in a null, unset state. 
* assembler/MacroAssemblerCodeRef.h:
(JSC::FunctionPtr::FunctionPtr):
    - add non-explicit constructor, for FunctionPtr's to C/C++ functions.
* assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::and32):
(JSC::MacroAssemblerX86Common::lshift32):
(JSC::MacroAssemblerX86Common::or32):
(JSC::MacroAssemblerX86Common::rshift32):
(JSC::MacroAssemblerX86Common::urshift32):
(JSC::MacroAssemblerX86Common::xor32):
(JSC::MacroAssemblerX86Common::moveDouble):
(JSC::MacroAssemblerX86Common::addDouble):
(JSC::MacroAssemblerX86Common::divDouble):
(JSC::MacroAssemblerX86Common::subDouble):
(JSC::MacroAssemblerX86Common::mulDouble):
(JSC::MacroAssemblerX86Common::branchTruncateDoubleToInt32):
(JSC::MacroAssemblerX86Common::branchTest32):
(JSC::MacroAssemblerX86Common::branchTest8):
(JSC::MacroAssemblerX86Common::branchAdd32):
(JSC::MacroAssemblerX86Common::branchMul32):
(JSC::MacroAssemblerX86Common::branchSub32):
    - add three operand forms of these instructions.
* assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::addDouble):
(JSC::MacroAssemblerX86_64::convertInt32ToDouble):
(JSC::MacroAssemblerX86_64::loadPtr):
(JSC::MacroAssemblerX86_64::branchTestPtr):
* assembler/X86Assembler.h:
(JSC::X86Assembler::JmpSrc::isSet):
    - add a method to check whether a JmpSrc object has been set to
      reference an instruction, or is in a null, unset state. 
(JSC::X86Assembler::movsd_rr):
    - added FP register-register move.
(JSC::X86Assembler::linkJump):
    - Add an assert to check jumps aren't linked more than once.
* jit/JITInlineMethods.h:
(JSC::JIT::emitLoadInt32ToDouble):
    - load integers to the FPU via regsiters on x86-64.



git-svn-id: svn://svn.chromium.org/blink/trunk@80972 bbb929c8-8fbe-4397-9dbb-9b2b20218538

d8b90842

Add some more crashing tests to an existing bug about the same issue · cdf56833

levin@chromium.org authored Mar 13, 2011

for Chromium Linux Debug.

* platform/chromium/test_expectations.txt:

git-svn-id: svn://svn.chromium.org/blink/trunk@80971 bbb929c8-8fbe-4397-9dbb-9b2b20218538

cdf56833

ARM build fix. · 6d3d7353

barraclough@apple.com authored Mar 13, 2011

* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::load32):



git-svn-id: svn://svn.chromium.org/blink/trunk@80970 bbb929c8-8fbe-4397-9dbb-9b2b20218538

6d3d7353

Bug 56270 - The JIT 'friend's many classes in JSC; start unwinding this. · 3c93ef1e

barraclough@apple.com authored Mar 13, 2011

Reviewed by Sam Weinig.

The JIT need to 'friend' other classes in order to be able to calculate offsets
of various properties, or the absolute addresses of members within specific objects,
in order to JIT generate code that will access members within the class when run.

Instead of using friends in these cases, switch to providing specific accessor
methods to provide this information.  In the case of offsets, these can be static
functions, and in the case of pointers to members within a specific object these can
be const methods returning pointers to const values, to prevent clients from
modifying values otherwise encapsulated within classes.

* bytecode/SamplingTool.h:
* interpreter/Register.h:
* interpreter/RegisterFile.h:
* runtime/JSArray.h:
* runtime/JSCell.h:
* runtime/JSTypeInfo.h:
* runtime/JSVariableObject.h:
* runtime/Structure.h:
* wtf/RefCounted.h:
    - Change these classes to no longer friend the JIT, add accessors for member offsets.
* jit/JIT.cpp:
* jit/JITCall32_64.cpp:
* jit/JITInlineMethods.h:
* jit/JITOpcodes.cpp:
* jit/JITOpcodes32_64.cpp:
* jit/JITPropertyAccess.cpp:
* jit/JITPropertyAccess32_64.cpp:
    - Change the JIT to use class accessors, rather than taking object ofsets directly.
* assembler/AbstractMacroAssembler.h:
* assembler/MacroAssemblerX86_64.h:
* assembler/X86Assembler.h:
    - Since the accessors for objects members return const pointers to retain encapsulation,
      methods generating code with absolute addresses must be able to handle const pointers
      (the JIT doesn't write to these values, do dies treat the pointer to value as const
      from within the C++ code of the JIT, if not at runtime!).



git-svn-id: svn://svn.chromium.org/blink/trunk@80969 bbb929c8-8fbe-4397-9dbb-9b2b20218538

3c93ef1e

WebPageProxy cleanup · fca4d878

mitz@apple.com authored Mar 13, 2011

https://bugs.webkit.org/show_bug.cgi?id=56267

Reviewed by Darin Adler.

* UIProcess/WebPageProxy.cpp: Moved all Mac-only function implementations from
here to WebPageProxyMac.mm.
* UIProcess/WebPageProxy.h: Cleaned up #includes.
* UIProcess/mac/WebPageProxyMac.mm: Moved all Mac-only function implementations
here.
(WebKit::WebPageProxy::updateWindowIsVisible):
(WebKit::WebPageProxy::windowAndViewFramesChanged):
(WebKit::WebPageProxy::getMarkedRange):
(WebKit::WebPageProxy::characterIndexForPoint):
(WebKit::WebPageProxy::firstRectForCharacterRange):
(WebKit::WebPageProxy::writeSelectionToPasteboard):
(WebKit::WebPageProxy::setDragImage):
(WebKit::WebPageProxy::performDictionaryLookupAtLocation):
(WebKit::WebPageProxy::interpretKeyEvent):
(WebKit::WebPageProxy::sendComplexTextInputToPlugin):
(WebKit::WebPageProxy::uppercaseWord):
(WebKit::WebPageProxy::lowercaseWord):
(WebKit::WebPageProxy::capitalizeWord):
(WebKit::WebPageProxy::setSmartInsertDeleteEnabled):
(WebKit::WebPageProxy::didPerformDictionaryLookup):
(WebKit::WebPageProxy::registerWebProcessAccessibilityToken):
(WebKit::WebPageProxy::registerUIProcessAccessibilityTokens):
(WebKit::WebPageProxy::setComplexTextInputEnabled):



git-svn-id: svn://svn.chromium.org/blink/trunk@80968 bbb929c8-8fbe-4397-9dbb-9b2b20218538

fca4d878

<rdar://problem/8949683 > WebKit2: Drag image is offset when the page is scrolled down · a5a525d9

mitz@apple.com authored Mar 13, 2011

https://bugs.webkit.org/show_bug.cgi?id=56265

Reviewed by Darin Adler.

* WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
(WebKit::WebDragClient::startDrag): Send the location in view coordinates rather than
document coordinates.



git-svn-id: svn://svn.chromium.org/blink/trunk@80967 bbb929c8-8fbe-4397-9dbb-9b2b20218538

a5a525d9

Fix a crash when dragging. · 7ca0f7c5

mitz@apple.com authored Mar 13, 2011

Reviewed by Mark Rowe.

* WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
(WebKit::convertImageToBitmap): Retain the saved context.



git-svn-id: svn://svn.chromium.org/blink/trunk@80966 bbb929c8-8fbe-4397-9dbb-9b2b20218538

7ca0f7c5

2011-03-13 Jeremy Moskovich <jeremy@chromium.org> · cbb29537

jeremy@chromium.org authored Mar 13, 2011

        Reviewed by Dimitri Glazkov.

        Update comment in CSSValueKeywords.in
        https://bugs.webkit.org/show_bug.cgi?id=56266

        The enums the comment refers to were moved from RenderStyle.h to RenderStyleConstants.h
        in r36579 but it appears that the comment in CSSValueKeywords.in wasn't updated.

        No tests - just updating a comment.

        * css/CSSValueKeywords.in:

git-svn-id: svn://svn.chromium.org/blink/trunk@80965 bbb929c8-8fbe-4397-9dbb-9b2b20218538

cbb29537

2011-03-13 Anton D'Auria <adauria@apple.com> · a1db5f10

commit-queue@webkit.org authored Mar 13, 2011

        Reviewed by Alice Liu.

        StorageTracker constructor shouldn't have initialization code and isMainThread() assertion
        https://bugs.webkit.org/show_bug.cgi?id=56259

        Move all StorageTracker initialization to
        StorageTracker::initializeTracker. This also removes the
        requirement that the StorageTracker constructor isn't run
        on the main thread.

        * storage/StorageTracker.cpp:
        (WebCore::StorageTracker::initializeTracker):
        (WebCore::StorageTracker::tracker):
        (WebCore::StorageTracker::StorageTracker):

git-svn-id: svn://svn.chromium.org/blink/trunk@80964 bbb929c8-8fbe-4397-9dbb-9b2b20218538

a1db5f10

2011-03-13 Rob Buis <rwlbuis@gmail.com> · 5a706f3b

rwlbuis@webkit.org authored Mar 13, 2011

        Reviewed by Dave Hyatt.

        REGRESSION (r61383): Navigation menu laid out incorrectly on aboardtheworld.com
        https://bugs.webkit.org/show_bug.cgi?id=53470

        Prefer !important over normal properties when dealing with duplicate properties in style rules.

        Test: fast/css/duplicate-property-in-rule-important.html

        * css/CSSMutableStyleDeclaration.cpp:
        (WebCore::CSSMutableStyleDeclaration::CSSMutableStyleDeclaration):

git-svn-id: svn://svn.chromium.org/blink/trunk@80963 bbb929c8-8fbe-4397-9dbb-9b2b20218538

5a706f3b

Add expectation (and bug) for test that has failed with an image · bfebc573

levin@chromium.org authored Mar 13, 2011

mismatch ever since it was added in r80867.

* platform/chromium/test_expectations.txt:

git-svn-id: svn://svn.chromium.org/blink/trunk@80962 bbb929c8-8fbe-4397-9dbb-9b2b20218538

bfebc573

Update test expections due to the OSX specific ex size change done in r80755. · 906f4e99

levin@chromium.org authored Mar 13, 2011

* platform/chromium-mac/fast/lists/008-expected.checksum: Added.
* platform/chromium-mac/fast/lists/008-expected.png: Added.
* platform/chromium-mac/fast/media/mq-relative-constraints-08-expected.checksum: Added.
* platform/chromium-mac/fast/media/mq-relative-constraints-08-expected.png: Added.
* platform/chromium-mac/fast/replaced/width100percent-checkbox-expected.checksum: Added.
* platform/chromium-mac/fast/replaced/width100percent-checkbox-expected.png: Added.
* platform/chromium-mac/fast/replaced/width100percent-radio-expected.checksum: Added.
* platform/chromium-mac/fast/replaced/width100percent-radio-expected.png: Added.
* platform/chromium-mac/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.checksum: Added.
* platform/chromium-mac/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.png: Added.
* platform/chromium-mac/tables/mozilla/bugs/bug1318-expected.checksum:
* platform/chromium-mac/tables/mozilla/bugs/bug1318-expected.png:
* platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.checksum:
* platform/chromium-mac/tables/mozilla/bugs/bug4527-expected.png:

git-svn-id: svn://svn.chromium.org/blink/trunk@80961 bbb929c8-8fbe-4397-9dbb-9b2b20218538

906f4e99

Fix test expectations due to bad update: · 3f207187

levin@chromium.org authored Mar 13, 2011

  r80820 which limited to win/mac when it still regularly fails on Linux
  and it made the test fail with the expectation IMAGE instead of IMAGE+TEXT
  as well as occaisionally pass.

* platform/chromium/test_expectations.txt:

git-svn-id: svn://svn.chromium.org/blink/trunk@80960 bbb929c8-8fbe-4397-9dbb-9b2b20218538

3f207187

Added the following expectations: · 1793bfd1

levin@chromium.org authored Mar 13, 2011

  fast/backgrounds/background-position-parsing.html new test in r80868
  fast/css-generated-content/table-row-before-after.html new test in r80871
  fast/table/dynamic-descendant-percentage-height.html new test in r80878

Updated test_expectation to cover a failure due to a missing layout test feature
and added an appropriate bug.

* platform/chromium-linux/fast/backgrounds/background-position-parsing-expected.checksum: Added.
* platform/chromium-linux/fast/backgrounds/background-position-parsing-expected.png: Added.
* platform/chromium-linux/fast/css-generated-content/table-row-before-after-expected.checksum: Added.
* platform/chromium-linux/fast/css-generated-content/table-row-before-after-expected.png: Added.
* platform/chromium-linux/fast/table/dynamic-descendant-percentage-height-expected.checksum: Added.
* platform/chromium-linux/fast/table/dynamic-descendant-percentage-height-expected.png: Added.
* platform/chromium-mac/fast/backgrounds/background-position-parsing-expected.checksum: Added.
* platform/chromium-mac/fast/backgrounds/background-position-parsing-expected.png: Added.
* platform/chromium-mac/fast/css-generated-content/table-row-before-after-expected.checksum: Added.
* platform/chromium-mac/fast/css-generated-content/table-row-before-after-expected.png: Added.
* platform/chromium-mac/fast/table/dynamic-descendant-percentage-height-expected.checksum: Added.
* platform/chromium-mac/fast/table/dynamic-descendant-percentage-height-expected.png: Added.
* platform/chromium-win/fast/backgrounds/background-position-parsing-expected.checksum: Added.
* platform/chromium-win/fast/backgrounds/background-position-parsing-expected.png: Added.
* platform/chromium-win/fast/backgrounds/background-position-parsing-expected.txt: Added.
* platform/chromium-win/fast/css-generated-content/table-row-before-after-expected.checksum: Added.
* platform/chromium-win/fast/css-generated-content/table-row-before-after-expected.png: Added.
* platform/chromium-win/fast/css-generated-content/table-row-before-after-expected.txt: Added.
* platform/chromium-win/fast/table/dynamic-descendant-percentage-height-expected.checksum: Added.
* platform/chromium-win/fast/table/dynamic-descendant-percentage-height-expected.png: Added.
* platform/chromium-win/fast/table/dynamic-descendant-percentage-height-expected.txt: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: svn://svn.chromium.org/blink/trunk@80959 bbb929c8-8fbe-4397-9dbb-9b2b20218538

1793bfd1

Update test results due to r80755. All of these tests started failing · 8dd75503

levin@chromium.org authored Mar 13, 2011

on that check in and were given new baselines in that check in.

* platform/chromium-mac/css1/text_properties/text_indent-expected.checksum: Added.
* platform/chromium-mac/css1/text_properties/text_indent-expected.png: Added.
* platform/chromium-mac/css1/units/length_units-expected.checksum: Added.
* platform/chromium-mac/css1/units/length_units-expected.png: Added.
* platform/chromium-mac/css2.1/t040302-c61-ex-len-00-b-a-expected.checksum: Added.
* platform/chromium-mac/css2.1/t040302-c61-ex-len-00-b-a-expected.png: Added.
* platform/chromium-mac/css2.1/t040302-c61-rel-len-00-b-ag-expected.checksum: Added.
* platform/chromium-mac/css2.1/t040302-c61-rel-len-00-b-ag-expected.png: Added.
* platform/chromium-mac/css2.1/t1008-c44-ln-box-02-d-ag-expected.checksum: Added.
* platform/chromium-mac/css2.1/t1008-c44-ln-box-02-d-ag-expected.png: Added.
* platform/chromium-mac/css2.1/t100801-c544-valgn-01-d-ag-expected.checksum: Added.
* platform/chromium-mac/css2.1/t100801-c544-valgn-01-d-ag-expected.png: Added.
* platform/chromium-mac/css2.1/t100801-c544-valgn-03-d-agi-expected.checksum:
* platform/chromium-mac/css2.1/t100801-c544-valgn-03-d-agi-expected.png: Added.
* platform/chromium-mac/css2.1/t100801-c548-ln-ht-02-b-ag-expected.checksum: Added.
* platform/chromium-mac/css2.1/t100801-c548-ln-ht-02-b-ag-expected.png: Added.
* platform/chromium-mac/css2.1/t1507-c526-font-sz-02-b-a-expected.checksum: Added.
* platform/chromium-mac/css2.1/t1507-c526-font-sz-02-b-a-expected.png: Added.
* platform/chromium-mac/css2.1/t1601-c547-indent-00-b-a-expected.checksum: Added.
* platform/chromium-mac/css2.1/t1601-c547-indent-00-b-a-expected.png: Added.
* platform/chromium-mac/css2.1/t1604-c541-word-sp-00-b-a-expected.checksum: Added.
* platform/chromium-mac/css2.1/t1604-c541-word-sp-00-b-a-expected.png: Added.
* platform/chromium-mac/css2.1/t1604-c542-letter-sp-00-b-a-expected.checksum: Added.
* platform/chromium-mac/css2.1/t1604-c542-letter-sp-00-b-a-expected.png: Added.
* platform/chromium-mac/editing/selection/caret-ltr-2-expected.checksum:
* platform/chromium-mac/editing/selection/caret-ltr-2-expected.png:
* platform/chromium-mac/editing/selection/caret-ltr-2-left-expected.checksum:
* platform/chromium-mac/editing/selection/caret-ltr-2-left-expected.png:
* platform/chromium-mac/editing/selection/caret-ltr-expected.checksum:
* platform/chromium-mac/editing/selection/caret-ltr-expected.png:
* platform/chromium-mac/editing/selection/caret-ltr-right-expected.checksum:
* platform/chromium-mac/editing/selection/caret-ltr-right-expected.png:
* platform/chromium-mac/editing/selection/caret-rtl-2-expected.checksum: Added.
* platform/chromium-mac/editing/selection/caret-rtl-2-expected.png: Added.
* platform/chromium-mac/editing/selection/caret-rtl-2-left-expected.checksum: Added.
* platform/chromium-mac/editing/selection/caret-rtl-2-left-expected.png: Added.
* platform/chromium-mac/editing/selection/caret-rtl-expected.checksum: Added.
* platform/chromium-mac/editing/selection/caret-rtl-expected.png: Added.
* platform/chromium-mac/editing/selection/caret-rtl-right-expected.checksum: Added.
* platform/chromium-mac/editing/selection/caret-rtl-right-expected.png: Added.
* platform/chromium-mac/fast/block/margin-collapse/103-expected.checksum:
* platform/chromium-mac/fast/block/margin-collapse/103-expected.png:
* platform/chromium-mac/fast/css/ex-after-font-variant-expected.checksum: Added.
* platform/chromium-mac/fast/css/ex-after-font-variant-expected.png: Added.
* platform/chromium-mac/fast/css/non-standard-checkbox-size-expected.checksum: Added.
* platform/chromium-mac/fast/css/non-standard-checkbox-size-expected.png: Added.
* platform/chromium-mac/fast/forms/minWidthPercent-expected.checksum: Added.
* platform/chromium-mac/fast/forms/minWidthPercent-expected.png: Added.
* platform/chromium-mac/fast/overflow/overflow-rtl-expected.checksum: Added.
* platform/chromium-mac/fast/overflow/overflow-rtl-expected.png: Added.

git-svn-id: svn://svn.chromium.org/blink/trunk@80958 bbb929c8-8fbe-4397-9dbb-9b2b20218538

8dd75503

2011-03-12 Sheriff Bot <webkit.review.bot@gmail.com> · 57c27877

commit-queue@webkit.org authored Mar 13, 2011

        Unreviewed, rolling out r80895.
        http://trac.webkit.org/changeset/80895
        https://bugs.webkit.org/show_bug.cgi?id=56261

        Causing crashes in several tests including
        t1202-counters-16-c.html (see
        http://build.webkit.org/results/SnowLeopard%20Intel%20Leaks/r80956%20(15528)/results.html)
        (Requested by dave_levin on #webkit).

        * rendering/CounterNode.cpp:
        (WebCore::CounterNode::CounterNode):
        (WebCore::CounterNode::create):
        (WebCore::CounterNode::resetRenderer):
        (WebCore::CounterNode::resetRenderers):
        (WebCore::CounterNode::recount):
        (WebCore::CounterNode::insertAfter):
        (WebCore::CounterNode::removeChild):
        (WebCore::showTreeAndMark):
        * rendering/CounterNode.h:
        (WebCore::CounterNode::renderer):
        * rendering/RenderCounter.cpp:
        (WebCore::findPlaceForCounter):
        (WebCore::RenderCounter::~RenderCounter):
        (WebCore::RenderCounter::originalText):
        (WebCore::RenderCounter::invalidate):
        (WebCore::destroyCounterNodeWithoutMapRemoval):
        (WebCore::RenderCounter::destroyCounterNodes):
        (WebCore::RenderCounter::destroyCounterNode):
        (WebCore::updateCounters):
        (showCounterRendererTree):
        * rendering/RenderCounter.h:
        * rendering/RenderObjectChildList.cpp:
        (WebCore::invalidateCountersInContainer):
        (WebCore::RenderObjectChildList::invalidateCounters):
        * rendering/RenderObjectChildList.h:

git-svn-id: svn://svn.chromium.org/blink/trunk@80957 bbb929c8-8fbe-4397-9dbb-9b2b20218538

57c27877

Add results for newly added test in r80883. · 70efca6a

levin@chromium.org authored Mar 13, 2011

The differences appear to be very small in keep with the typical
font drawing differences.

* platform/chromium-linux/fast/multicol/scrolling-overflow-expected.checksum: Added.
* platform/chromium-linux/fast/multicol/scrolling-overflow-expected.png: Added.
* platform/chromium-mac/fast/multicol/scrolling-overflow-expected.checksum: Added.
* platform/chromium-mac/fast/multicol/scrolling-overflow-expected.png: Added.
* platform/chromium-win/fast/multicol/scrolling-overflow-expected.checksum: Added.
* platform/chromium-win/fast/multicol/scrolling-overflow-expected.png: Added.
* platform/chromium-win/fast/multicol/scrolling-overflow-expected.txt: Added.

git-svn-id: svn://svn.chromium.org/blink/trunk@80956 bbb929c8-8fbe-4397-9dbb-9b2b20218538

70efca6a

* WebProcess/WebCoreSupport/mac/WebDragClientMac.mm: · 548fb14f

darin@apple.com authored Mar 13, 2011

(WebKit::WebDragClient::startDrag): Fixed typo in a comment.



git-svn-id: svn://svn.chromium.org/blink/trunk@80955 bbb929c8-8fbe-4397-9dbb-9b2b20218538

548fb14f

r80743 updated the main baseline due to a jsc change. · 4a4769a7

levin@chromium.org authored Mar 13, 2011

chromium isn't affected by the change.

* platform/chromium/fast/js/regexp-caching-expected.txt: Added.
chromium already had a specific baseline for this but it was in chromium-win,
so I moved this result to the more general chromium direction.
* platform/chromium-win/fast/js/regexp-caching-expected.txt: Removed.

git-svn-id: svn://svn.chromium.org/blink/trunk@80954 bbb929c8-8fbe-4397-9dbb-9b2b20218538

4a4769a7

Remove bad test_expectation updates. · 88391066

levin@chromium.org authored Mar 13, 2011

I fixed both of these already:
  http://trac.webkit.org/changeset/80911
  http://trac.webkit.org/changeset/80904
so it is unclear why they were added.

* platform/chromium/test_expectations.txt:

git-svn-id: svn://svn.chromium.org/blink/trunk@80953 bbb929c8-8fbe-4397-9dbb-9b2b20218538

88391066

2011-03-12 Darin Adler <darin@apple.com> · 8f12c58f

darin@apple.com authored Mar 13, 2011

        Reviewed by Dan Bernstein.

        REGRESSION (r76474): IntegerArray hash hashes only 1/4 of the array
        https://bugs.webkit.org/show_bug.cgi?id=56258

        No tests because the wrong hashing is mostly harmless. The only symptom
        we have seen is an occasional assertion in debug builds about the size
        not being a multiple of two. But a worse hash is worse for performance too.

        * platform/cf/BinaryPropertyList.cpp:
        (WebCore::IntegerArrayHash::hash): Pass in the size in bytes rather
        than the number of array entries.


git-svn-id: svn://svn.chromium.org/blink/trunk@80952 bbb929c8-8fbe-4397-9dbb-9b2b20218538

8f12c58f

Not reviewed. · 7d7a56dc

cwzwarich@webkit.org authored Mar 13, 2011

Fix the build with newer GCCs and remove some extra whitespae.

* bindings/js/SerializedScriptValue.cpp:
(WebCore::uint8_t):


git-svn-id: svn://svn.chromium.org/blink/trunk@80951 bbb929c8-8fbe-4397-9dbb-9b2b20218538

7d7a56dc

Rubber-stamped by Oliver Hunt. · c234e475

cwzwarich@webkit.org authored Mar 13, 2011

Removed unused ARMv5 code. The ARMv5 case now falls under the general
unaligned accessed case.

* bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneDeserializer::readLittleEndian):
(WebCore::CloneDeserializer::readString):


git-svn-id: svn://svn.chromium.org/blink/trunk@80950 bbb929c8-8fbe-4397-9dbb-9b2b20218538

c234e475

Reviewed by Oliver Hunt. · 5bf63c34

cwzwarich@webkit.org authored Mar 13, 2011

WebCore fails to build with Clang on ARM
https://bugs.webkit.org/show_bug.cgi?id=56257

Add an explicit instantiation of writeLittleEndian for uint8_t and move it to
namespace scope, since explicit specializations are not allowed at class scope.

* bindings/js/SerializedScriptValue.cpp:
(WebCore::writeLittleEndian):


git-svn-id: svn://svn.chromium.org/blink/trunk@80949 bbb929c8-8fbe-4397-9dbb-9b2b20218538

5bf63c34

2011-03-11 Darin Adler <darin@apple.com> · caf9248c

darin@apple.com authored Mar 13, 2011

        Reviewed by Sam Weinig.

        Dragging image to desktop gives webloc instead of image file in WebKit2
        https://bugs.webkit.org/show_bug.cgi?id=56193

        * WebCore.exp.in: Added some additional exports. Re-sorted.
2011-03-11  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        Dragging image to desktop gives webloc instead of image file in WebKit2
        https://bugs.webkit.org/show_bug.cgi?id=56193

        * WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
        (WebKit::convertImageToBitmap): Added. Factored out from startDrag to
        make the startDrag code clearer.
        (WebKit::WebDragClient::startDrag): Streamlined code a bit.
        (WebKit::cachedImage): Added. Helper for function below.
        (WebKit::arrayForURLsWithTitles): Added. Helper for function below.
        (WebKit::WebDragClient::declareAndWriteDragImage): Added code to handle file
        promises and removed a log of uneeded code.
        (-[WKPasteboardFilePromiseOwner copyDropDirectory]): Added.
        (promisedDataClient): Added.
        (-[WKPasteboardOwner clearImage]): Added.
        (-[WKPasteboardOwner initWithImage:]): Added.
        (-[WKPasteboardOwner dealloc]): Added.
        (-[WKPasteboardOwner finalize]): Added.
        (-[WKPasteboardOwner pasteboard:provideDataForType:]): Added.
        (-[WKPasteboardOwner pasteboardChangedOwner:]): Added.
        (matchesExtensionOrEquivalent): Added.
        (-[WKPasteboardOwner namesOfPromisedFilesDroppedAtDestination:]): Added.
        Much of the new code above came from the WebKit1 drag code.

        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::dragEnded): Added call to Mac-only platformDragEnded.
        * WebProcess/WebPage/WebPage.h: Added Mac-only platformDragEnded and m_dragSource.
        * WebProcess/WebPage/mac/WebPageMac.mm:
        (WebKit::WebPage::setDragSource): Added.
        (WebKit::WebPage::platformDragEnded): Added.


git-svn-id: svn://svn.chromium.org/blink/trunk@80948 bbb929c8-8fbe-4397-9dbb-9b2b20218538

caf9248c

12 Mar, 2011 14 commits

<rdar://problem/8995822 > Build DumpRenderTree perl support only for the architectures · 37fa9f1e

mitz@apple.com authored Mar 12, 2011

DumpRenderTree is being built for.

Reviewed by Mark Rowe.

* DumpRenderTree/mac/PerlSupport/Makefile:



git-svn-id: svn://svn.chromium.org/blink/trunk@80947 bbb929c8-8fbe-4397-9dbb-9b2b20218538

37fa9f1e

Fix the 32-bit build. · 9eea7d4b

mrowe@apple.com authored Mar 12, 2011

Source/WebKit/mac:

* Carbon/CarbonWindowAdapter.mm:
(-[CarbonWindowAdapter initWithCarbonWindowRef:takingOwnership:disableOrdering:carbon:]): Use a more appropriate format specifier.
(-[CarbonWindowAdapter _carbonWindowClass]): Ditto.

Source/WebKit2:

This involves hacking around some HIToolbox headers that do things of dubious correctness,
and fixing the usual CGRect vs NSRect issues.

* UIProcess/mac/WKFullScreenWindowController.mm:
(-[WKFullScreenWindowController enterFullScreen:]): NSRect is not CGRect.
* WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm:
(WebKit::WebFullScreenManagerMac::beginExitFullScreenAnimation): Ditto.

git-svn-id: svn://svn.chromium.org/blink/trunk@80946 bbb929c8-8fbe-4397-9dbb-9b2b20218538

9eea7d4b

* WebProcess/WebPage/WebFrame.cpp: · eccbfd32

andersca@apple.com authored Mar 12, 2011

(WebKit::WebFrame::url):
Get the URL from the loader, not from the document.

Reviewed by Sam Weinig.

(WebKit::WebFrame::suggestedFilenameForResourceWithURL):
Return the correct suggested filename for the main resource.

(WebKit::WebFrame::mimeTypeForResourceWithURL):
Return the correct mime type for the main resource.



git-svn-id: svn://svn.chromium.org/blink/trunk@80945 bbb929c8-8fbe-4397-9dbb-9b2b20218538

eccbfd32

Suggested by Mark Rowe. · 433cdb1a

mitz@apple.com authored Mar 12, 2011

* DumpRenderTree/mac/Configurations/Base.xcconfig: Leave C++ exceptions enabled
as they were before r80915.



git-svn-id: svn://svn.chromium.org/blink/trunk@80944 bbb929c8-8fbe-4397-9dbb-9b2b20218538

433cdb1a

2011-03-12 Anders Carlsson <andersca@apple.com> · 11947c47

andersca@apple.com authored Mar 12, 2011

        Reviewed by Sam Weinig.

        Should be able to download a PDF to the Downloads folder
        https://bugs.webkit.org/show_bug.cgi?id=56256

        * UIProcess/API/C/WKPage.h:
        Add WKPageSaveDataToFileInDownloadsFolderCallback to the UI client.

        * UIProcess/API/mac/PDFViewController.h:
        * UIProcess/API/mac/PDFViewController.mm:
        (-[WKPDFView _applyPDFPreferences]):
        (-[WKPDFView _updatePreferences:]):
        Use new PDFViewController::page getter.

        (-[WKPDFView PDFViewSavePDFToDownloadFolder:]):
        Call PDFViewController::savePDFToDownloadsFolder.

        (WebKit::releaseCFData):
        (WebKit::PDFViewController::savePDFToDownloadsFolder):
        Create a WebData that wraps the CFData, then pass it along to
        WebPageProxy::saveDataToFileInDownloadsFolder.

        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::saveDataToFileInDownloadsFolder):
        Call WebUIClient::saveDataToFileInDownloadsFolder.

        (WebKit::WebUIClient::saveDataToFileInDownloadsFolder):
        * UIProcess/WebUIClient.h:
        Call the UI client callback function.
2011-03-12  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Should be able to download a PDF to the Downloads folder
        https://bugs.webkit.org/show_bug.cgi?id=56256

        * MiniBrowser/mac/BrowserWindowController.m:
        (-[BrowserWindowController awakeFromNib]):
        * WebKitTestRunner/TestController.cpp:
        (WTR::TestController::createOtherPage):
        (WTR::TestController::initialize):
        Update for API changes.


git-svn-id: svn://svn.chromium.org/blink/trunk@80943 bbb929c8-8fbe-4397-9dbb-9b2b20218538

11947c47

2011-03-12 Anders Carlsson <andersca@apple.com> · ac117046

andersca@apple.com authored Mar 12, 2011

        Reviewed by Sam Weinig.

        WebData should be able to wrap already existing data
        https://bugs.webkit.org/show_bug.cgi?id=56254

        * Shared/WebData.h:
        (WebKit::WebData::createWithoutCopying):
        (WebKit::WebData::create):
        (WebKit::WebData::~WebData):
        (WebKit::WebData::bytes):
        (WebKit::WebData::size):
        (WebKit::WebData::WebData):
        (WebKit::WebData::fastFreeBytes):


git-svn-id: svn://svn.chromium.org/blink/trunk@80942 bbb929c8-8fbe-4397-9dbb-9b2b20218538

ac117046

2011-03-12 Jer Noble <jer.noble@apple.com> · 96b54de2

jer.noble@apple.com authored Mar 12, 2011

        Reviewed by Eric Carlson.

        WebKit2: Initialize the WebFullScreenManagerProxy with a WKView
        https://bugs.webkit.org/show_bug.cgi?id=56250

        * UIProcess/API/mac/WKView.mm:
        (-[WKView initWithFrame:contextRef:pageGroupRef:]): Call fullScreenManager()->setView(self).

git-svn-id: svn://svn.chromium.org/blink/trunk@80941 bbb929c8-8fbe-4397-9dbb-9b2b20218538

96b54de2

2011-03-12 Ilya Tikhonovsky <loislo@chromium.org> · bc7f1a56

loislo@chromium.org authored Mar 12, 2011

        Unreviewed. Update chromium expectations.

        * platform/chromium/test_expectations.txt:



git-svn-id: svn://svn.chromium.org/blink/trunk@80940 bbb929c8-8fbe-4397-9dbb-9b2b20218538

bc7f1a56

2011-03-12 Ilya Tikhonovsky <loislo@chromium.org> · 7df08ce4

loislo@chromium.org authored Mar 12, 2011

        Unreviewed. Update chromium test expectations.

        * platform/chromium/test_expectations.txt:




git-svn-id: svn://svn.chromium.org/blink/trunk@80939 bbb929c8-8fbe-4397-9dbb-9b2b20218538

7df08ce4

2011-03-12 Sheriff Bot <webkit.review.bot@gmail.com> · 8d4e1e89

loislo@chromium.org authored Mar 12, 2011

        Unreviewed, rolling out r80919.
        http://trac.webkit.org/changeset/80919
        https://bugs.webkit.org/show_bug.cgi?id=56251

        all windows bots failed to compile this change (Requested by
        loislo on #webkit).

        * JavaScriptCore.xcodeproj/project.pbxproj:
        * bytecode/StructureStubInfo.cpp:
        * interpreter/Register.h:
        (JSC::Register::withInt):
        (JSC::Register::withCallee):
        (JSC::Register::operator=):
        (JSC::Register::i):
        (JSC::Register::activation):
        (JSC::Register::function):
        (JSC::Register::propertyNameIterator):
        (JSC::Register::scopeChain):
        * jit/JIT.h:
        * jit/JITCall.cpp:
        (JSC::JIT::compileOpCallInitializeCallFrame):
        (JSC::JIT::compileOpCallVarargs):
        (JSC::JIT::compileOpCall):
        * jit/JITCall32_64.cpp:
        (JSC::JIT::compileOpCallInitializeCallFrame):
        (JSC::JIT::compileOpCallVarargs):
        (JSC::JIT::compileOpCall):
        (JSC::JIT::compileOpCallSlowCase):
        * jit/JITInlineMethods.h:
        (JSC::JIT::emitPutToCallFrameHeader):
        * jit/JITOpcodes.cpp:
        (JSC::JIT::privateCompileCTINativeCall):
        (JSC::JIT::emit_op_get_pnames):
        (JSC::JIT::emit_op_next_pname):
        (JSC::JIT::emit_op_load_varargs):
        (JSC::JIT::emitSlow_op_load_varargs):
        * jit/JITOpcodes32_64.cpp:
        (JSC::JIT::privateCompileCTINativeCall):
        (JSC::JIT::emit_op_get_pnames):
        (JSC::JIT::emit_op_next_pname):
        * jit/JSInterfaceJIT.h:
        (JSC::JSInterfaceJIT::payloadFor):
        * jit/SpecializedThunkJIT.h:
        (JSC::SpecializedThunkJIT::returnJSValue):
        (JSC::SpecializedThunkJIT::returnDouble):
        (JSC::SpecializedThunkJIT::returnInt32):
        (JSC::SpecializedThunkJIT::returnJSCell):
        * runtime/ArgList.cpp:
        * runtime/DateConversion.cpp:
        * runtime/GCActivityCallbackCF.cpp:
        * runtime/Identifier.cpp:
        * runtime/JSActivation.h:
        (JSC::asActivation):
        * runtime/JSLock.cpp:
        * runtime/JSNumberCell.cpp:
        * runtime/JSObject.h:
        * runtime/JSPropertyNameIterator.h:
        * runtime/JSValue.h:
        * runtime/JSZombie.cpp:
        * runtime/MarkedBlock.cpp:
        * runtime/MarkedSpace.cpp:
        * runtime/PropertyNameArray.cpp:
        * runtime/ScopeChain.h:
        (JSC::ExecState::globalThisValue):
        * wtf/DateMath.cpp:
2011-03-12  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r80919.
        http://trac.webkit.org/changeset/80919
        https://bugs.webkit.org/show_bug.cgi?id=56251

        all windows bots failed to compile this change (Requested by
        loislo on #webkit).

        * bridge/c/c_class.cpp:
        * bridge/c/c_runtime.cpp:
        * bridge/jni/JavaMethod.cpp:
        * plugins/PluginViewNone.cpp:

git-svn-id: svn://svn.chromium.org/blink/trunk@80938 bbb929c8-8fbe-4397-9dbb-9b2b20218538

8d4e1e89

2011-03-12 Patrick Gansterer <paroga@webkit.org> · a280c104

paroga@webkit.org authored Mar 12, 2011

        Unreviewed WinCE build fix for r80900.

        * CMakeListsWinCE.txt: Removed IconDatabaseNone.cpp.

git-svn-id: svn://svn.chromium.org/blink/trunk@80937 bbb929c8-8fbe-4397-9dbb-9b2b20218538

a280c104

2011-03-12 Andras Becsi <abecsi@webkit.org> · cda0e1cc

abecsi@webkit.org authored Mar 12, 2011

        Unreviewed typo fix.

        No new tests needed.

        * WebCore.pro: Fix typo in header name.

git-svn-id: svn://svn.chromium.org/blink/trunk@80936 bbb929c8-8fbe-4397-9dbb-9b2b20218538

cda0e1cc

2011-03-12 Ilya Tikhonovsky <loislo@chromium.org> · 56edeb96

loislo@chromium.org authored Mar 12, 2011

        Unreviewed. Update chromium test expectations.

        * platform/chromium/test_expectations.txt:




git-svn-id: svn://svn.chromium.org/blink/trunk@80935 bbb929c8-8fbe-4397-9dbb-9b2b20218538

56edeb96

2011-03-12 Pavel Feldman <pfeldman@chromium.org> · d2a997b6

pfeldman@chromium.org authored Mar 12, 2011

        Not reviewed: Inspect Element action regression fix.

        * inspector/front-end/inspector.js:
        (WebInspector.inspect):


git-svn-id: svn://svn.chromium.org/blink/trunk@80934 bbb929c8-8fbe-4397-9dbb-9b2b20218538

d2a997b6