GitLab

The change added a static initializer, breaking the build:
  ppb_nacl_private_impl.cc nacl::(anonymous namespace)::kPNaClManifestId

> Pepper: Move manifest logic to components/nacl.
>
> The goal of the trusted plugin refactor is to move as much code as possible out of ppapi/native_client/src/trusted/plugin. This change moves all the manifest parsing and lookup logic out of the trusted plugin at once; it's hard to move piecemeal.
>
> BUG=353592
> R=bbudge@chromium.org, mallinath@chromium.org
>
> Review URL: https://codereview.chromium.org/264943003

R=teravest@chromium.org
TBR=teravest@chromium.org

Review URL: https://codereview.chromium.org/264143002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268267 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268266 0039d316-1c4b-4281-b951-d872f2087c98

All hail GN. oRZ

BUG=none

Review URL: https://codereview.chromium.org/263503003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268265 0039d316-1c4b-4281-b951-d872f2087c98

r268232 was erroneously blamed, so re-applying it.

> Revert 268232 "Refactor MetricsStateManager class out of Metrics..."
> 
> Failed 'sizes' check: chrome-si (static initializers) incremented.
> 
> > Refactor MetricsStateManager class out of MetricsService.
> > 
> > The new class is responsible for managing various MetricsService state prefs,
> > such as client id, low entropy source and the UMA opt-in state, as well as the
> > cloned install detector.
> > 
> > Also, moves IsMetricsReportingEnabled() from chrome_browser_main.cc to
> > the new class as well as changing a couple MetricsService browser tests
> > to instead be unit tests of the new class.
> > 
> > BUG=368413
> > 
> > Review URL: https://codereview.chromium.org/256143006
> 
> TBR=asvitkine@chromium.org
> 
> Review URL: https://codereview.chromium.org/268223002

TBR=miu@chromium.org

Review URL: https://codereview.chromium.org/270013002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268264 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268263 0039d316-1c4b-4281-b951-d872f2087c98

This added static initializers, breaking the build.  In src/angle/common/shadervars.cpp:

  const BlockMemberInfo BlockMemberInfo::defaultBlockInfo(-1, -1, -1, false);

> Roll ANGLE.
> 
> Contains latest es3proto changes.
> 
> Review URL: https://codereview.chromium.org/260893008

TBR=geofflang@chromium.org

Review URL: https://codereview.chromium.org/265373002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268262 0039d316-1c4b-4281-b951-d872f2087c98

It still doesn't run though.

R=ben@chromium.org

Review URL: https://codereview.chromium.org/265053005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268261 0039d316-1c4b-4281-b951-d872f2087c98

This function returns the outputs for a target that appeared previously in the same file. This is frequently needed for getting the files resulting from an action.

The main operational change is that targets that are generated are stashed in a vector as we process a file and then dispatched once that file is finished, rather than being dispatched as-we-go. This way we can ask questions about the targets that appeared previously in the file.

R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/269723006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268260 0039d316-1c4b-4281-b951-d872f2087c98

BUG=364781
R=jochen@chromium.org

Review URL: https://codereview.chromium.org/252743007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268259 0039d316-1c4b-4281-b951-d872f2087c98

An invalidate could be lost in this case:
* SetNeedsContinuousInvalidate starts out as true
* Functor happens on render thread, and SetNeedsContinuousInvalidate
goes false, but because we are on render thread, this is posted back
to UI thread
* Before the task runs on UI, compositor SetNeedsContinuousInvalidate
to true again, since the value is already true, this is a no-op, but
we should really be invalidating now
* The posted task runs and SetNeedsContinuousInvalidate to false,
and we just lost an invalidate

Fix by updating the value with a lock and only post for the invalidate.
This avoids the race causing early out in SetNeedsContinuousInvalidate.

For internal b/13979752
BUG=

Review URL: https://codereview.chromium.org/269913002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268258 0039d316-1c4b-4281-b951-d872f2087c98

Use Xrender to do the color conversion to 8bpp.

BUG=368425
TBR=piman@chromium.org

Review URL: https://codereview.chromium.org/269073003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268257 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268256 0039d316-1c4b-4281-b951-d872f2087c98

> NaCl: Update revision in DEPS, r13115 -> r13137
> 
> This pulls in the following Native Client changes:
> 
> r13117: (mseaborn) Add a Scons-to-Ninja converter for getting faster incremental rebuilds
> r13118: (mseaborn) Scons: Remove unnecessary use of addRepository() for gtest
> r13119: (sbc) Add latest filename interface to IRT and sel_ldr.
> r13120: (jvoung) Remove some leftover bits of CloseManifestEntry and Log.
> r13121: (jfb) PNaCl SIMD: add test for vector cast and conversion
> r13122: (bradnelson) Reduce perf dashboard noise by excluding -dbg builders.
> r13123: (dyen) Added arguments to NaCl scons to allow custom toolchain directories.
> r13124: (mseaborn) scons_to_ninja: Fix Install() step to coexist with NaCl/SCons's version
> r13125: (dschuff) Test pinned PNaCl toolchain and gold plugin on mac and win toolchain bots
> r13126: (jfb) LLVM biased sandbox build: fix PNaCl driver script so it knows about more architectures
> r13127: (dyen) Fix bionic package_version archives.
> r13128: (dyen) Updated nacl_arm_bionic revision to r13127
> r13129: (dschuff) Switch PNaCl toolchain package info upload back to toolchain_build_pnacl
> r13130: (dyen) Added a way to specify packages with missing archives in package_version.
> r13131: (mseaborn) PNaCl: Remove some more references to PNaCl+glibc in naclsdk.py
> r13132: (mseaborn) Non-SFI Mode: Add nonsfi_loader and plumbing to test it
> r13133: (mseaborn) Fix checkdeps.py failure on src/nonsfi/ produced by r13132
> r13134: (noelallen) Fix double crtbegin.o, extra gcc build steps on skip
> r13135: (dschuff) Update PNaCl pinned revision to 13129 and switch to toolchain_build_pnacl
> r13136: (bradnelson) Add NACL_GOMA_THREADS in build_nexe.py to limit number of threads (for sergeyu)
> r13137: (noelallen) Add scons to gn script
> 
> BUG=none
> TEST=browser_tests and nacl_integration
> R=bradnelson@google.com
> 
> Review URL: https://codereview.chromium.org/266163002

TBR=mseaborn@chromium.org

Review URL: https://codereview.chromium.org/265163011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268255 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
R=jam@chromium.org

Review URL: https://codereview.chromium.org/266723015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268253 0039d316-1c4b-4281-b951-d872f2087c98

R=sky@chromium.org
http://crbug.com/365012

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268218

Review URL: https://codereview.chromium.org/260863008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268252 0039d316-1c4b-4281-b951-d872f2087c98

Refactors the EventListener struct with implied semantics based on the
value of member variable |process| to a class with an explicit accessor for
IsLazy. Also simplifies future abstraction for when ServiceWorkerHost
may be an alternative to a RenderProcessHost.

BUG=369841

Review URL: https://codereview.chromium.org/261223002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268251 0039d316-1c4b-4281-b951-d872f2087c98

The goal of the trusted plugin refactor is to move as much code as possible out of ppapi/native_client/src/trusted/plugin. This change moves all the manifest parsing and lookup logic out of the trusted plugin at once; it's hard to move piecemeal.

BUG=353592
R=bbudge@chromium.org, mallinath@chromium.org

Review URL: https://codereview.chromium.org/264943003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268250 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268249 0039d316-1c4b-4281-b951-d872f2087c98

This pulls in the following Native Client changes:

r13117: (mseaborn) Add a Scons-to-Ninja converter for getting faster incremental rebuilds
r13118: (mseaborn) Scons: Remove unnecessary use of addRepository() for gtest
r13119: (sbc) Add latest filename interface to IRT and sel_ldr.
r13120: (jvoung) Remove some leftover bits of CloseManifestEntry and Log.
r13121: (jfb) PNaCl SIMD: add test for vector cast and conversion
r13122: (bradnelson) Reduce perf dashboard noise by excluding -dbg builders.
r13123: (dyen) Added arguments to NaCl scons to allow custom toolchain directories.
r13124: (mseaborn) scons_to_ninja: Fix Install() step to coexist with NaCl/SCons's version
r13125: (dschuff) Test pinned PNaCl toolchain and gold plugin on mac and win toolchain bots
r13126: (jfb) LLVM biased sandbox build: fix PNaCl driver script so it knows about more architectures
r13127: (dyen) Fix bionic package_version archives.
r13128: (dyen) Updated nacl_arm_bionic revision to r13127
r13129: (dschuff) Switch PNaCl toolchain package info upload back to toolchain_build_pnacl
r13130: (dyen) Added a way to specify packages with missing archives in package_version.
r13131: (mseaborn) PNaCl: Remove some more references to PNaCl+glibc in naclsdk.py
r13132: (mseaborn) Non-SFI Mode: Add nonsfi_loader and plumbing to test it
r13133: (mseaborn) Fix checkdeps.py failure on src/nonsfi/ produced by r13132
r13134: (noelallen) Fix double crtbegin.o, extra gcc build steps on skip
r13135: (dschuff) Update PNaCl pinned revision to 13129 and switch to toolchain_build_pnacl
r13136: (bradnelson) Add NACL_GOMA_THREADS in build_nexe.py to limit number of threads (for sergeyu)
r13137: (noelallen) Add scons to gn script

BUG=none
TEST=browser_tests and nacl_integration
R=bradnelson@google.com

Review URL: https://codereview.chromium.org/266163002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268248 0039d316-1c4b-4281-b951-d872f2087c98

Remove the now-unused log() function from DOMActivityLogger.

BUG=356890

Review URL: https://codereview.chromium.org/266013004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268247 0039d316-1c4b-4281-b951-d872f2087c98

Failed 'sizes' check: chrome-si (static initializers) incremented.

> Refactor MetricsStateManager class out of MetricsService.
> 
> The new class is responsible for managing various MetricsService state prefs,
> such as client id, low entropy source and the UMA opt-in state, as well as the
> cloned install detector.
> 
> Also, moves IsMetricsReportingEnabled() from chrome_browser_main.cc to
> the new class as well as changing a couple MetricsService browser tests
> to instead be unit tests of the new class.
> 
> BUG=368413
> 
> Review URL: https://codereview.chromium.org/256143006

TBR=asvitkine@chromium.org

Review URL: https://codereview.chromium.org/268223002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268246 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/263903004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268245 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268244 0039d316-1c4b-4281-b951-d872f2087c98

BUG=369160
R=sbc@chromium.org

Review URL: https://codereview.chromium.org/269053002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268242 0039d316-1c4b-4281-b951-d872f2087c98

Android already has the fix to remove min-width from body.  This gives iOS
the same change.

BUG=None
TEST=None

Review URL: https://codereview.chromium.org/264853003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268241 0039d316-1c4b-4281-b951-d872f2087c98

For PNaCl, "fdio" should only be exposed via the "dev" query string,
indicating a non-stable interface.

But, outside of PNaCl, since we will be providing open_resource() as a
stable interface in Non-SFI NaCl, we need to provide "fdio" as a
stable ABI, via its non-dev query string.  Since open_resource()
returns an FD, it's only useful with the FD operations that "fdio"
provides.

BUG=358431
TEST=none

Review URL: https://codereview.chromium.org/266703003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268240 0039d316-1c4b-4281-b951-d872f2087c98

BUG=363147

Review URL: https://codereview.chromium.org/260903009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268239 0039d316-1c4b-4281-b951-d872f2087c98

wifi_component target is production code target and thus should not
include code that is intended for tests.

This changes makes it stop building test code in wifi_component, by
extracting and exposing the FakeWiFiService interface in the header
file and instantiating it directly where we used to call
WiFiService::CreateForTest().

This is the second part of what was discussed in
https://codereview.chromium.org/243343002 and started here
https://codereview.chromium.org/259543002/ - r266025

BUG=None
TEST=build and works as before, no regressions
R=mef@chromium.org,thestig@chromium.org

Review URL: https://codereview.chromium.org/264773017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268237 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268235 0039d316-1c4b-4281-b951-d872f2087c98

Contains latest es3proto changes.

Review URL: https://codereview.chromium.org/260893008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268234 0039d316-1c4b-4281-b951-d872f2087c98

The new class is responsible for managing various MetricsService state prefs,
such as client id, low entropy source and the UMA opt-in state, as well as the
cloned install detector.

Also, moves IsMetricsReportingEnabled() from chrome_browser_main.cc to
the new class as well as changing a couple MetricsService browser tests
to instead be unit tests of the new class.

BUG=368413

Review URL: https://codereview.chromium.org/256143006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268232 0039d316-1c4b-4281-b951-d872f2087c98

This moves the chrome.usb API implementation into the
core set of extensions APIs.

BUG=369391
R=rpaquay
TBR=yoz for extensions
TBR=sky for +chrome/browser/ui in test DEPS

Review URL: https://codereview.chromium.org/268713013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268231 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268230 0039d316-1c4b-4281-b951-d872f2087c98

See https://codereview.chromium.org/261253002/
for the actual changes.

BUG=366025

Review URL: https://codereview.chromium.org/268953002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268229 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268228 0039d316-1c4b-4281-b951-d872f2087c98

https://code.google.com/p/skia/source/list?num=1&start=14566
TBR=
BUG=

Review URL: https://codereview.chromium.org/265153003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268227 0039d316-1c4b-4281-b951-d872f2087c98

According to the issue 265021, ContentClient::CanHandleWhileSwappedOut() was
introduced to support synchronous browser->renderer messages for WebView.
But this is now obsolete, so we can remove it.

BUG=265021

Review URL: https://codereview.chromium.org/248703002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268226 0039d316-1c4b-4281-b951-d872f2087c98

> Add support for mapping node tree on the client.
> 
> R=sky@chromium.org
> http://crbug.com/365012
> 
> Review URL: https://codereview.chromium.org/260863008

TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/269973002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268225 0039d316-1c4b-4281-b951-d872f2087c98

Unofficial design doc: https://docs.google.com/a/google.com/document/d/1uOphhlascPTfNjsI2QTdeVTp-ANEz-g2rqGli5yVv34/edit#heading=h.a67n1i6wy36k

Reviews of the previous uncommitted implementation iterations:
https://codereview.chromium.org/240333007
https://codereview.chromium.org/225143007

BUG=368828

Review URL: https://codereview.chromium.org/262483003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268224 0039d316-1c4b-4281-b951-d872f2087c98

These are non problematic tests that do not require any extra setup and
do not depend on any global state, so it is safe to move straightforward
to gfx_unittests.

BUG=331829
TEST=ui_unittests, gfx_unittests
TBR=danakj@chromium.org,ben@chromium.org

Review URL: https://codereview.chromium.org/268043002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268223 0039d316-1c4b-4281-b951-d872f2087c98