GitLab

This adds HandleReturnData to DecoderClient to allow the
WebGPUDecoder to send binary blobs of return commands back
to the WebGPUImplementation. Its implementation in the
InProcessCommandBuffer and the ProxyCommandBufferImpl
forward the data to the GpuControlClient interface. The
WebGPUImplementation will receive the return command stream
via GpuControlClient::GpuControlOnReturnData.

Bug: 877147
Change-Id: Ic7983b9d7b6dd15680427162762bc3bc39bd52fd
Reviewed-on: https://chromium-review.googlesource.com/c/1481615
Commit-Queue: Austin Eng <enga@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636500}

Bug: 907601
Change-Id: I88d5682df5488f2030a1f5ef18118d3b3ba18008
Reviewed-on: https://chromium-review.googlesource.com/c/1486154Reviewed-by: Sahel Sharify <sahel@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636499}

user-activation-delegation API allows to transfer user activation state
to any target window in the frame tree through postMessages with
"transferUserActivation" set to be true.

Bug: 931885
Change-Id: I224f5fb04b2e08f751c33f5cba867562664fbe0b
Reviewed-on: https://chromium-review.googlesource.com/c/1477911
Commit-Queue: Lan Wei <lanwei@chromium.org>
Reviewed-by: Mustaq Ahmed <mustaq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636498}

In focusless spatial navigation, when the interested element is removed
from the document, but remains alive, the search algorithm begins from
it. This results in the algorithm not moving to a new element because
it doesn't find a parent container (the document) for the Element.

This CL fixes the issue by checking if the interested_node is
disconnected when we decide on a starting node for the search. If it is,
we use the default document node like we would when there is no
interested element.

Bug: 929526
Change-Id: Ic5ebe85e563e6c240d301f4fd0c92be8087dd43b
Reviewed-on: https://chromium-review.googlesource.com/c/1493397Reviewed-by: Jianpeng Chao <chaopeng@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636497}

- Add / simplify constructors/destructors.
- Add a buffer size DCHECK() to avoid going out of bounds.
- Replace new keyword usage with the appropriate "make" function.
- Fix bad indentation from r636359.

Change-Id: Iab5cb939b36abb4ccebcced2b44aa432c55b4f39
Reviewed-on: https://chromium-review.googlesource.com/c/1495366Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636496}

This reverts commit 53410c06.

Reason for revert: merger script was updated.

> Original change's description:
> > android: Launch Crashpad with /system/bin/linker on Q
> >
> > This adds a small executable, libcrashpad_handler_trampoline.so, to
> > Monochrome, Trichrome, and SystemWebView. The trampoline loads the
> > remaining Crashpad handler code from the main native library, which
> > must export `CrashpadHandlerMain()`.
> >
> > All three packages will continue to use /system/bin/app_process to
> > launch Crashpad on P-.
> >
> > Note on static_initializers.gni:
> >
> > There aren't any real, new static initializers. The increased count is
> > due to the addition of the new object. Static initializers are counted
> > by measuring the size of each object's .init_array and dividing by the
> > object's pointer size. libcrashpad_handler_trampoline.so has two
> > invalid slots which are ignored by the loader:
> >
> > readelf -x .init_array libcrashpad_handler_trampoline.so
> >
> > Hex dump of section '.init_array':
> >   0x00001008 ffffffff 00000000

TBR=pasko@chromium.org,torne@chromium.org,agrieve@chromium.org,jperaza@chromium.org,mark@chromium.org

Change-Id: Ifdeb10d70977208eb01761b4588d8bfbaecfa20d
Bug: 928422, 935973
Reviewed-on: https://chromium-review.googlesource.com/c/1488574Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Ben Mason <benmason@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636495}

Intent to Ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/6rZ7kBLwmhg/lqEpsHLiDgAJ

Bug: 915907
Change-Id: I08825b981d93016b1d8d3647ee76cb4ccea4173a
Reviewed-on: https://chromium-review.googlesource.com/c/1492488
Commit-Queue: Danyao Wang <danyao@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636494}

This commit modifies the MediaControls to show the controls and update
the current time indicators (current time text + timeline thumb)
immediately during seek requests so the element behavior during rapid
seek requests (e.g. user is holding down the FF button on their BT
keyboard) look similar to when a user is scrubbing the timeline with
their mouse.

Bug: 748749

TEST=MediaControlsImplTest, manual testing
     out/Debug/bin/run_webkit_unit_tests -f *MediaControlsImplTest*

Change-Id: I6588aded2a93e081a6ca638ee1da534ea00abf4d
Reviewed-on: https://chromium-review.googlesource.com/c/1274945
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636493}

Also fixes an issue where the Chromium string and the Google Chrome
string didn't match.

Change-Id: I92726d0e4bfbaf4872ea5d0a4389b0225ae7dba9
Reviewed-on: https://chromium-review.googlesource.com/c/1484078
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636492}

This reverts commit 186521f9.

Reason for revert: causing multiple issues (crbug.com/936640 and crbug.com/936686)

Original change's description:
> Emit window bounds when the window is transformed.
> 
> The transform can be applied on overview mode and can affect
> the bounds in screen.
> 
> Bug: 931161
> Test: services_unittests
> Change-Id: I5ef15745d73f7ffcd74e5844ffeef18b0d544d66
> Reviewed-on: https://chromium-review.googlesource.com/c/1480206
> Commit-Queue: Jun Mukai <mukai@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#634009}

TBR=mukai@chromium.org,sky@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 931161
Change-Id: I091bb8af891b75f3cc1153c026990bbf6b12c7d6
Reviewed-on: https://chromium-review.googlesource.com/c/1495202Reviewed-by: Jun Mukai <mukai@chromium.org>
Commit-Queue: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636491}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/ad9e9432731b..a0a1dcc95853


git log ad9e9432731b..a0a1dcc95853 --date=short --no-merges --format='%ad %ae %s'
2019-02-28 dgarrett@google.com workspace_stages: Use temp git-cache for branched gclient.
2019-02-28 dgarrett@google.com workspace_stages: SyncChrome using branched gclient.


Created with:
  gclient setdep -r src/third_party/chromite@a0a1dcc95853

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@chromium.org

Change-Id: I9b26c820fce6cd185ff2d5083ea5477755b54fb1
Reviewed-on: https://chromium-review.googlesource.com/c/1495362Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#636490}

The event handler is triggered when the user changes payer information
such as payer name, payer email, or payer phone in the user interface.
Unlike other PaymentRequestUpdateEvent(e.g. shippingaddresschange), this
event can fire only after the website calls retry() with validation
errors in the payer contact information.

This feature is still behind runtime flag(PaymentRetry).
FYI, we've already had a desktop implementation in crrev.com/c/1206750.

Intent to implement:
  https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/wayZGnuBkrI

Related spec change:
  https://github.com/w3c/payment-request/pull/724

Test:
  chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestRetryTest.java
  payment-request/payment-response/onpayerdetailchange-attribute.https.html
  payment-request/payment-response/onpayerdetailchange-attribute.manual.https.html

Bug: 861704
Change-Id: If9d01e4696b0ed8e415a76313c70da4d6ec230f6
Reviewed-on: https://chromium-review.googlesource.com/c/1477610
Commit-Queue: Jinho Bang <jinho.bang@samsung.com>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636489}

Before this patch, Chrome would not show the merchant's shipping address
validation error message if the merchant also provided some shipping
options.

This patch shows the error message if the merchant sets it or if the
merchant clears the shipping options in an update.

After this patch, Chrome shows the merchant's shipping address
validation error message even if the merchant provided some shipping
options.

As before, if the merchant clears shipping options in an update without
providing an error message, Chrome displays a default error message.
This behavior has not changed.

Bug: 934902
Change-Id: Idfeef5963fd1c9e12d7cdfe1ec9afedd51563a8d
Reviewed-on: https://chromium-review.googlesource.com/c/1482720
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Danyao Wang <danyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636488}

https://codereview.chromium.org/2250133004 introduced a regression that
editing boundary adjustment may move the result position out of the
editing host. This patch fixes it.

Bug: 936613
Change-Id: If07d33df991635291672370fe8a89fc3a35520da
Reviewed-on: https://chromium-review.googlesource.com/c/1493391Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636487}

This CL changes "Did you mean to go to example.com" to "Did you mean
example.com".

Bug: 927924
Change-Id: I3f75715475315be052a193e9bf7001a7b0b78e77
Reviewed-on: https://chromium-review.googlesource.com/c/1494976
Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org>
Commit-Queue: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636486}

This reverts commit b37e23cb.

Reason for revert: 
Suspect this causes failure on WebKit Linux Trusty Leak:
https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Trusty%20Leak/30727


Original change's description:
> [Reland] Synthetic input waits on compositor display
> 
> Reland Note:
> {
>   Previously landed:
>   https://crrev.com/258ed8d55e4f8b4d99fcde72c3569b9450198092
>   Reverted:
>   https://crrev.com/716496fe0909bc918c410a56f6566390b12adedc
> 
>   Revert was due to failing Leak Detector bot. Issue was that the
>   browser still held a reference to the V8 function for the gesture
>   completion callback which was never resolved. This CL resolves
>   callback when the BlinkTestRunner is reset. Original CL uploaded in
>   PS1.
> }
> 
> This CL makes synthetic input - the kind used in web tests and
> telemetry (e.g. gpuBenchmarking.scrollBy) - wait until a CompositorFrame
> has been submitted by the renderer and displayed by the display
> compositor before resolving the completion callback. This means client
> code that wants to wait until any observable side-effects of this input
> is visible to further input need only wait on the gesture's completion
> callback.
> 
> To give a motivating example: suppose we wish to write a test that
> scrolls an out-of-process iframe into view and clicks on a button in the
> frame. The code might look something like this:
> 
> gpuBenchmarking.smoothScroll(1000, () => {
>   gpuBenchmarking.tap(0, 0);
> });
> 
> This code contains a race today. The callback for smoothScroll is
> invoked as soon as the ScrollEnd is received in the renderer. However,
> until a new compositor frame is submitted from the renderer, the tap
> may occur against stale hit testing geometry. This is a major source of
> flakiness in our tests.
> 
> This CL fixes the problem by forcing the renderer to perform a full
> redraw at the end of each gesture. The redraw produces a compositor
> frame and we invoke the callback once the compositor frame is displayed.
> We do this by reusing the RequestPresentation mechanism in RenderWidget.
> RequestPresentation required two modifications to work in web tests
> which use a single thread proxy with no scheduler:
> 
>  - LayerTreeHost::Composite needs to check the forced redraw flag to
>    determine whether we need to raster, otherwise it won't produce a
>    frame
>  - RequestPresentation must request a main frame since there's no
>    scheduler to perform the commit, which is what SetNeedsForcedRedraw
>    requests.
> 
> The timing change exposed an issue in the
> overlay-play-button-tap-to-hide.html test so this CL also cleans that
> test up to listen to the animation changes in media controls properly.
> 
> Finally, it's possible we may get input in a RenderWidget that's not
> currently displayed. e.g. A click event sent via ChromeDriver causes a
> TouchStart followed by a TouchEnd. The TouchStart causes a window.open
> which opens and focuses a new tab. The TouchEnd then happens on the
> background tab. In this case, we should resolve the callback rather than
> waiting on a CompositorFrame that'll never come. See ChromeDriver test
> testNetworkConnectionTypeIsAppliedToAllTabs for an example of this.
> 
> 
> TBR=dtapuska@chromium.org,nzolghadr@chromium.org,samans@chromium.org
> 
> Bug: 902446
> Change-Id: Ia2f0a5a6ae51216582bf4cc1d03cb5ba724ddffd
> Reviewed-on: https://chromium-review.googlesource.com/c/1490757
> Reviewed-by: David Bokan <bokan@chromium.org>
> Reviewed-by: Peter Beverloo <peter@chromium.org>
> Commit-Queue: David Bokan <bokan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#636440}

TBR=peter@chromium.org,bokan@chromium.org,dtapuska@chromium.org,nzolghadr@chromium.org,samans@chromium.org

Change-Id: I9200ea622887575de2d582f1d6e9030dd425aac9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 902446
Reviewed-on: https://chromium-review.googlesource.com/c/1495442Reviewed-by: Ella Ge <eirage@chromium.org>
Commit-Queue: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636485}

Bug: 936828
Change-Id: I9ed609c5ca0bf8d9c7e38d25393af8ebbbbc2060
Reviewed-on: https://chromium-review.googlesource.com/c/1494895
Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636484}

This CL re-adds logic to log MediaLauncherActivity in the
WebappCustomTabTimeSpentLogger. This was accidentally removed in a
rebase.

Bug: 935777
Change-Id: Ifa553184ab3e598cd3c0787eead8845a3b4c0695
Reviewed-on: https://chromium-review.googlesource.com/c/1493441Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636483}

As a drive-by return a tuple of string and flag for an object's name to
easily figure out wheter the object should be considered internal or
not.

Bug: 936797
Change-Id: Icd6efc709b46b48ac6944d3b814ffa72906b55e0
Reviewed-on: https://chromium-review.googlesource.com/c/1493911
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636482}

This patch copies the logic to check ShouldPaintDescendantOutlines
from BlockPainter::PaintBlockFlowContents().

Before this change, PaintPhase::kOutline and kDescendantOutlinesOnly
painted all descendants. With this change, they paint LayoutInline
descendants only, matching to the legacy behavior.

The difference was observed in
fast/block/float/float-in-float-painting.html.

Bug: 936024
Change-Id: I8f0d985b7ced9f8e1295bdb4e4a0f3763551b2c6
Reviewed-on: https://chromium-review.googlesource.com/c/1495134Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636481}

Bug: 936275
Change-Id: Icb58cda11379b0bc5f149aafbd84bacbc8a015c2
Reviewed-on: https://chromium-review.googlesource.com/c/1493071Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636480}

Bug: 936587
Change-Id: I9cdf7d8eca4862aeaa6aebb6266b51aa0dfc6777
Reviewed-on: https://chromium-review.googlesource.com/c/1492045Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Roger Tawa <rogerta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636479}

ipp_converter::ConvertIppToMojo does not take ownership of the passed in
ipp_t*; this change reflects that.

Bug: None
Test: unitests still pass
Change-Id: I19cbdb084175a57ab533cd63099d54acae624c2b
Reviewed-on: https://chromium-review.googlesource.com/c/1493206Reviewed-by: Sean Kau <skau@chromium.org>
Commit-Queue: Luum Habtemariam <luum@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636478}

Now correctly failing on unrecognized tag_types.

Keeping ipp_t objs wrapped in printing::ScopedIppPtr objs throughout
fuzzing.

Bug: chromium:936435
Test: Reproducible test case no longer fails.
Change-Id: I13fd72834fb971e5fc9fc28541c28b7a293a41d0
Reviewed-on: https://chromium-review.googlesource.com/c/1492572
Auto-Submit: Luum Habtemariam <luum@chromium.org>
Reviewed-by: Sean Kau <skau@chromium.org>
Commit-Queue: Luum Habtemariam <luum@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636477}

This reverts commit e7db3d02.

Reason for revert: caused several regressions.

Bug:936798,936652,936763

Original change's description:
> Re-land: [BGPT] Support kDstIn blend-mode for non-render surface quads
> 
> This reverts commit 0d564c1d.
> 
> It is a re-land of the original patch, with a fix to support the
> AA quad rendering path in GLRenderer.
> 
> Bug: 936087
> 
> Change-Id: I1e7d19051d891a20f902704bebf78ca45145751f
> Reviewed-on: https://chromium-review.googlesource.com/c/1489899
> Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
> Reviewed-by: enne <enne@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#636148}

TBR=chrishtr@chromium.org,enne@chromium.org

Change-Id: I8d85d23362a7c2f69e03c8b7a031aa436b33b40d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 936087
Reviewed-on: https://chromium-review.googlesource.com/c/1495039Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636476}

The README is outdated. Changes in this patch:
1. Updating some "Animation" to "KeyframeModel" for correctness
2. Adding newly implemented classes to README

Bug: 930130
Change-Id: Ie209090ed375a0547de2dddd376063090b7a37bf
Reviewed-on: https://chromium-review.googlesource.com/c/1460861
Commit-Queue: Yi Gu <yigu@chromium.org>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636475}

This reverts commit d8a530f9.

Reason for reland: initial CL had a bug when a native nested loop
goes idle multiple times in a row. It needs to be able to reuse the
existing native timer instead of assuming there isn't one (there won't
be one the first time the native loop goes idle but there'll be one
one all other idle phases unless we're out of delayed tasks).

Original change's description:
> Revert "[base] Migrate the Win MessagePump to DoSomeWork"
>
> This reverts commit 8c5fb8cb.
>
> Reason for revert: DCHECK(!installed_native_timer_); in dev builds
> when moving and resizing windows. Seems interactive_ui_tests might
> not cover those cases..?
>
> Original change's description:
> > [base] Migrate the Win MessagePump to DoSomeWork
> >
> > This CL migrates both MessagePumpForUI and ForIO as they use the same
> > base class and it's easier to do both at once.
> >
> > Tweaks to MessagePumpBase and/or both pumps:
> >  * Use DoSomeWork() instead of DoWork()/DoDelatedWork()
> >  * Replace |delayed_work_time_| by a timeout value computed on the stack
> >    from the result of DoSomeWork(). Conversely making
> >    ScheduleDelayedWork() a no-op as desired.
> >  * Refactor GetCurrentDelay() into GetSleepTimeoutMs() and use modern
> >    safe_conversions.h to perform the math.
> >
> > MessagePumpForUI specific tweaks:
> >  * Fixed crbug.com/929263: ::SetTimer() used 0 as an nIDEvent but
> >    ::KillTimer() used |this| so they weren't even interacting...
> >  * Fixed bug: even with the previous bug fixed. HandleTimerMessage()
> >    could be invoked while in a non-native DoRunLoop() (e.g. since
> >    KillTimer doesn't remove WM_TIMER messages already enqueued) and as
> >    such result in redundant sources of scheduling since it would then
> >    continue to RescheduleTimer() and confusing state for DoRunLoop()).
> >  * Ignore WM_TIMER messages which weren't scheduled by our ::SetTimer().
> >  * Simplified usage of native ::SetTimer(). We now *only* rely on it
> >    when in a native nested loop and kill it immediately after to avoid
> >    double-scheduling.
> >
> > Note: MessageLoopTest.PostDelayedTask_SharedTimer_SubPump tests the
> > necessity for a native timer when entering a native nested loop and
> > confirms that the new behavior is WAI.
> >
> > Also adding regression tests for a tricky use case (and finding that
> > it's already broken on ToT..!). Filed crbug.com/930940 to follow-up.

(regression tests relanded separately in crrev.com/631918)

> >
> > Bug: 885371, 929263, 930940
> > Change-Id: I7f2d18a1a5a494c6a4f31fcc0fad9b4de25d70a7
> > Reviewed-on: https://chromium-review.googlesource.com/c/1455266
> > Reviewed-by: Alex Clarke <alexclarke@chromium.org>
> > Reviewed-by: François Doray <fdoray@chromium.org>
> > Commit-Queue: Gabriel Charette <gab@chromium.org>
> > Auto-Submit: Gabriel Charette <gab@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#631231}
>
> TBR=gab@chromium.org,fdoray@chromium.org,alexclarke@chromium.org
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: 885371, 929263, 930940
> Change-Id: Ic179d0493d01d4f44330927d9ccdb0f1454d2e78
> Reviewed-on: https://chromium-review.googlesource.com/c/1471254
> Reviewed-by: Gabriel Charette <gab@chromium.org>
> Commit-Queue: Gabriel Charette <gab@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#631885}

R=fdoray@chromium.org,alexclarke@chromium.org

Bug: 885371, 929263, 931871
Change-Id: I10277d92cb780ba17dc5b9a359dc26b381e85ef4
Reviewed-on: https://chromium-review.googlesource.com/c/1471257
Commit-Queue: Gabriel Charette <gab@chromium.org>
Auto-Submit: Gabriel Charette <gab@chromium.org>
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636474}

Add expectation for flaky external/wpt/fullscreen/api/element-request-fullscreen-and-remove-manual.html

This test seems to be flaky on multiple bots.

TBR=foolip@chromium.org

Bug: 936827
Change-Id: Id91065f4df77d03721eed2e6f1ca17d2a5f17ac4
Reviewed-on: https://chromium-review.googlesource.com/c/1494875Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636473}

We need to port matchers to ObjC in order to be accessible in EG2 to
the Test and the App processes. Also created
shell_matchers_shorthand.h/mm to minimize the changes to call sites.

Bug: 930859
Change-Id: Ibff34f59962bac87fa50d48c1393451b63955271
Reviewed-on: https://chromium-review.googlesource.com/c/1494896
Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636472}

TBR: lukasza@chromium.org
No-Try: true
Bug: 835573
Change-Id: Idb6f7588e0953d838f15d2fb3395d7580ac3d0be
Reviewed-on: https://chromium-review.googlesource.com/c/1495435Reviewed-by: Ella Ge <eirage@chromium.org>
Commit-Queue: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636471}

A source node does not have pending activity if the context state is "closed".
Previously we were checking that the context was basically being destructed,
but since source nodes have a reference to the context, the context is still
alive and can't yet be destroyed.

Bug: 894322
Change-Id: I5b001e07069deab7ccf818b21b37f1652be53035
Reviewed-on: https://chromium-review.googlesource.com/c/1478074Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636470}

In order to do this move, change callers to SetBackgroundColor() to
check if there is a local main frame, instead of checking for a null
LayerTreeView.

This means that when the main frame is remote, the compositor will
(rightfully) stop being updated. But when a local main frame is
attached the compositor must be updated. In the future this will be
a new compositor attached to the LocalFrame. So we add a method to
LocalFrameClient that is called for a local frame being
attached to the Page, and have it inform the WebViewImpl.

R=dcheng@chromium.org

Bug: 912193
Change-Id: I9ff250d46d3a7e352f9a11ab8b892e2f464a99cb
Reviewed-on: https://chromium-review.googlesource.com/c/1478258
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636469}

This patch gets rid of redundant parameter |storage| from |NGInlineNode::
GetOffsetMapping()| as follow-up of CL[1] for improving code health.


[1] http://crrev.com/c/1488479 Make LayoutBlockFlowRareData to hold
NGOffsetMapping for legacy layout

Change-Id: I265c7287f625a74bbf52be040e962c752a572fed
Reviewed-on: https://chromium-review.googlesource.com/c/1488400
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Auto-Submit: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636468}

 * caps-lock-indicator
 * -internal-media-cast-off-button
 * -internal-media-closed-captions-icon
 * -internal-media-download-button
 * -internal-media-overflow-button
 * -internal-media-overlay-cast-off-button
 * -internal-media-remoting-cast-icon
 * -internal-media-subtitles-icon
 * -internal-media-track-selection-checkmark

They don't have style adjustment code, don't have painting code,
and are not used in the UA stylesheets.


Change-Id: I38adc95be356618e76374b68135bb7e03deb398f
Bug: 936301
Reviewed-on: https://chromium-review.googlesource.com/c/1491233
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Auto-Submit: Kent Tamura <tkent@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636467}

We divert touchscreen pinch events performed over an OOPIF to the root
view, as only the root view can change page scale. It is also necessary
for touchscreen gesture pinch events to occur within a gesture scroll
sequence. This requires the diverted pinch events to be wrapped in a
scroll sequence if the root does not otherwise have an ongoing scroll
sequence.

Currently, the pinch events are wrapped without considering scroll
bubbling. If a scroll begin is bubbled to the root, but the
corresponding pinch begin was diverted to the root and therefore another
scroll begin was created to wrap it, then the root already has an
ongoing scroll gesture and should not receive another GSB. Furthermore,
once we have established that scroll is bubbling to the root, there is
no longer any need to wrap the pinch in a scroll end, as the root will
eventually receive a scroll end through bubbling.

Bug: 897216, 923226
Change-Id: I4bb61c2d58ce9168a4c224f0e088d17b68d4a198
Reviewed-on: https://chromium-review.googlesource.com/c/1467242Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: James MacLean <wjmaclean@chromium.org>
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636466}

All source files referenced in jni_headers is under chrome/android, so
moving the target here to make it easier to edit when working under
chrome/android.

Bug: 935583
Change-Id: I2dd55db8df80c4e068c065076488938bec612084
Reviewed-on: https://chromium-review.googlesource.com/c/1492931
Commit-Queue: Peter Wen <wnwen@chromium.org>
Auto-Submit: Peter Wen <wnwen@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636465}

This patch extends ScrimView.ScrimParams to allow:

- specifying a Drawable instead of just a color, to allow greater
  customization of the apparence

- specifying an EventFilter, to allow some touch events to go through
  the scrim

The goal is to refactor Autofill Assistant to use this view instead of a
custom view, TouchEventFilterView.

For background, see go/aa-bottomsheet

Change-Id: I6bdaf0f6959e8bac03ba3a04ecfb1ce7f718b7e8
Bug: 933070
Reviewed-on: https://chromium-review.googlesource.com/c/1473230
Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636464}

A single place to include all the base module/apk java deps.

Bug: 846440
Change-Id: Ie1381cdb6ce5c413d6a6ee380ba6301b3f367245
Reviewed-on: https://chromium-review.googlesource.com/c/1494824
Auto-Submit: Peter Wen <wnwen@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636463}

Speculative fix for UBSAN vptr build breakage.

Bug: 936859
Change-Id: I8db59ddf0cc6bfc9b1bb6d15287cb6bd2eaafa42
Reviewed-on: https://chromium-review.googlesource.com/c/1494977Reviewed-by: Max Moroz <mmoroz@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636462}

Bug: 863341
Change-Id: Id62135ec73a545c21a6c4ec7d173e540f6cc031f
Reviewed-on: https://chromium-review.googlesource.com/c/1494657
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Auto-Submit: Karolina Soltys <ksolt@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#636461}