- 23 May, 2018 40 commits
-
-
Erik Luo authored
Screenshot: https://imgur.com/a/lhjvp3U Bug: 827860 Change-Id: Ib42840136d4705bf90433e4ee308cf40417a610f Reviewed-on: https://chromium-review.googlesource.com/1068245Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#560896}
-
John Z Wu authored
This will allow us to be more DRY when creating and using test data. Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I63841779af2b88e09a7e589faa13edc688b04835 Reviewed-on: https://chromium-review.googlesource.com/1067981 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#560895}
-
Devlin Cronin authored
The listeners that the extensions page adds for the developerPrivate API have expensive events associated with them. When the page isn't open, we should ensure that we are not listening for them. This CL adds a test to verify that. Bug: None Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ibba3692e2ccda2af2e29efab66873a2722d5a61b Reviewed-on: https://chromium-review.googlesource.com/1069311Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#560894}
-
danakj authored
As stated on the tin. R=piman@chromium.org Bug: 722935 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ia5f9da37b4f9bec72c49900019de3bbdd11e04f0 Reviewed-on: https://chromium-review.googlesource.com/1066510Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#560893}
-
Christopher Cameron authored
This was caused by a cast to RenderWidgetHostViewMac, which is inappropriate in some tests. Cast only to RenderWidgetHostViewBase instead. TBR=sdy Bug: 845688 Change-Id: Id08887aeba5f18209a9b570d7a36548bdf59faa7 Reviewed-on: https://chromium-review.googlesource.com/1069750Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Sidney San Martín <sdy@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#560892}
-
chromeos-commit-bot@chromium.org authored
BUG=762641 TBR=xiaoyinh@google.com Change-Id: I06761b98f30403cee94c0b77cf610db02600174e Reviewed-on: https://chromium-review.googlesource.com/1069849Reviewed-by:
ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Commit-Queue: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#560891}
-
Kent Tamura authored
* name_style_converter.py: to_upper_camel_case() supports cases where the first token is a lowercased-acronym. Add 'DNS', 'XSS', and 'FE' to SPECIAL_TOKENS. * json5_generator.py, and make_runtime_features.py: Move 'tokenized_name' initialization from make_runtime_features.py to json5_generator.py because it is used in many places. * make_element_factory.py, make_element_type_helpers.py, make_internal_settings.py, make_settings.py, internal_settings_generated.cc.tmpl, internal_settings_generated.h.tmpl, internal_settings_generated.idl.tmpl, settings_macros.h.tmpl: Use 'tokenized_name.to_upper_camel_case()' instead of upper_first filter. * name_utilities.py: Remove upper_first() and ACRONYMS. Bug: 843927 Change-Id: Icb297c5cb820a7e98e09a69f63a27a8b89f7c836 Reviewed-on: https://chromium-review.googlesource.com/1068772Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#560890}
-
Siddhartha S authored
This reverts commit 9191004f. Reason for revert: The failure after the revert was a different failure. Sorry for the reland. Original change's description: > Reland "Use thresholds based on RAM size for OOM intervention" > > This reverts commit 50257b9e. > > Reason for revert: This was not the cause of failure, see > https://crbug.com/845763 > > Original change's description: > > Revert "Use thresholds based on RAM size for OOM intervention" > > > > This reverts commit 0c2124b3. > > > > Reason for revert: Speculatively reverting to see if it fixes webgl conformance test timeouts > > Bug: 845411 > > > > Original change's description: > > > Use thresholds based on RAM size for OOM intervention > > > > > > This CL does not change behavior of existing experiment on 512 devices. > > > 1. Remove low-end device checks while enabling intervention. This can be > > > filtered in Finch config. > > > 2. Set threshold based on percentage of RAM instead of absolute number. > > > 3. Disable intervention if device has more than 512MB RAM and threshold > > > was set to absolute number. > > > > > > BUG=843419 > > > > > > > > > Change-Id: Ib40a038d9d2f111a514b3f41ce7f32a3ea3a156d > > > Reviewed-on: https://chromium-review.googlesource.com/1066804 > > > Commit-Queue: Siddhartha S <ssid@chromium.org> > > > Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#560430} > > > > TBR=bashi@chromium.org,ssid@chromium.org > > > > Change-Id: I4b50e522dcc6c91542927a9e769e5eee24f486a5 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 843419 > > Reviewed-on: https://chromium-review.googlesource.com/1069567 > > Reviewed-by: enne <enne@chromium.org> > > Commit-Queue: enne <enne@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#560761} > > TBR=bashi@chromium.org,enne@chromium.org,ssid@chromium.org > > Change-Id: I4d0a08cd44772dc690ac1d93b1d92b4934ed0373 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 845411, 843419 > Reviewed-on: https://chromium-review.googlesource.com/1069888 > Reviewed-by: Siddhartha S <ssid@chromium.org> > Commit-Queue: Siddhartha S <ssid@chromium.org> > Cr-Commit-Position: refs/heads/master@{#560882} TBR=bashi@chromium.org,enne@chromium.org,ssid@chromium.org Change-Id: Ib8841dddaa2a167e674c997ec1577036df26e8cb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 845411, 843419 Reviewed-on: https://chromium-review.googlesource.com/1069876Reviewed-by:
Siddhartha S <ssid@chromium.org> Commit-Queue: Siddhartha S <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#560889}
-
Yutaka Hirano authored
net::WebSocketChannel and various related classes use std::string to represent request headers. This CL changes them to HttpRequestHeaders. Bug: 721400 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Id730779b36f3a319a61b44516bd3e8389ebdfc23 Reviewed-on: https://chromium-review.googlesource.com/1065713Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#560888}
-
Xiyuan Xia authored
- Add IMERegistrarImpl and IMEDriverBridge to WindowService to provide IMERegistrar and IMEDriver mojo interface there; - Chrome always call IMEDriver::Register to register its IME with WindowService; Bug: 837710 Change-Id: I39e91dda3643707346f58914022ed8beab75c636 Reviewed-on: https://chromium-review.googlesource.com/1069672Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#560887}
-
John Z Wu authored
This improves the API to be more natural to use. Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ia6d4feabaf72a23b4550f9b7f7008314955a4d7f Reviewed-on: https://chromium-review.googlesource.com/1068117 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#560886}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/7f472cd8abe4..86688dea3b0d $ git log 7f472cd8a..86688dea3 --date=short --no-merges --format='%ad %ae %s' 2018-05-22 thestig Make friend RetainPtr<T> statements consistently public. 2018-05-22 thestig Fix nits in fxjs. 2018-05-22 thestig Simplify CPDF_ShadingPattern::Validate(). Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I448003d54d9cdf3c6861696a1ff2796b6adfb76d Reviewed-on: https://chromium-review.googlesource.com/1069785 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#560885}
-
Erik Luo authored
When the console level dropdown has custom levels, it will have a background similar to the context selector. Screenshot: https://imgur.com/a/sKhzAzh Bug: 801986 Change-Id: Id015fe40ae46986bbf07455b0b5e1f0acd622afa Reviewed-on: https://chromium-review.googlesource.com/1067854 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by:
-
John Budorick authored
Bug: 845637 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I2d35c7297c742c36248bd020fc7a7a7d81459a90 Reviewed-on: https://chromium-review.googlesource.com/1069867Reviewed-by:
Menglu Huang <huangml@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#560883}
-
Siddhartha S authored
This reverts commit 50257b9e. Reason for revert: This was not the cause of failure, see https://crbug.com/845763 Original change's description: > Revert "Use thresholds based on RAM size for OOM intervention" > > This reverts commit 0c2124b3. > > Reason for revert: Speculatively reverting to see if it fixes webgl conformance test timeouts > Bug: 845411 > > Original change's description: > > Use thresholds based on RAM size for OOM intervention > > > > This CL does not change behavior of existing experiment on 512 devices. > > 1. Remove low-end device checks while enabling intervention. This can be > > filtered in Finch config. > > 2. Set threshold based on percentage of RAM instead of absolute number. > > 3. Disable intervention if device has more than 512MB RAM and threshold > > was set to absolute number. > > > > BUG=843419 > > > > > > Change-Id: Ib40a038d9d2f111a514b3f41ce7f32a3ea3a156d > > Reviewed-on: https://chromium-review.googlesource.com/1066804 > > Commit-Queue: Siddhartha S <ssid@chromium.org> > > Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#560430} > > TBR=bashi@chromium.org,ssid@chromium.org > > Change-Id: I4b50e522dcc6c91542927a9e769e5eee24f486a5 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 843419 > Reviewed-on: https://chromium-review.googlesource.com/1069567 > Reviewed-by: enne <enne@chromium.org> > Commit-Queue: enne <enne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#560761} TBR=bashi@chromium.org,enne@chromium.org,ssid@chromium.org Change-Id: I4d0a08cd44772dc690ac1d93b1d92b4934ed0373 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 845411, 843419 Reviewed-on: https://chromium-review.googlesource.com/1069888Reviewed-by:
-
John Budorick authored
Bug: 731985 Change-Id: I63a1602ce7ab7aea00683df8afdd41d1df4a9e59 Reviewed-on: https://chromium-review.googlesource.com/1069870Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#560881}
-
rbpotter authored
Ensure focus remains in the textfield after the user enters a new value, even if this changes the validity of the input. Bug: 843952 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I0fec55a89c10d4b4dcbaff219927ca26fd650594 Reviewed-on: https://chromium-review.googlesource.com/1069254Reviewed-by:
-
rbpotter authored
PDF scaling was implemented by scaling the page size, which no longer works when sending the PDF from print preview. Instead, perform the scaling in Pdfium engine, like we do for fit to page. Bug: 835654 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I0f2c6cef995b85090a6ea0b540b5c940d7513495 Reviewed-on: https://chromium-review.googlesource.com/1036083 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#560879}
-
John Budorick authored
TBR=bpastene@chromium.org Bug: 731985 Change-Id: I701c5a9d2a842bcd128c45f504636fc61a9b3a54 Reviewed-on: https://chromium-review.googlesource.com/1069910Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#560878}
-
David Valleau authored
BUG=chromium:845532 R=skau@chromium.org Change-Id: I320f992f3f427d2a2675954eb59fc05e2a5c6a90 Reviewed-on: https://chromium-review.googlesource.com/1069837Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: David Valleau <valleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#560877}
-
Ken Rockot authored
This reverts commit 1bdfba58. Reason for revert: broke fuchsia Original change's description: > Introduce public PlatformHandle type > > Adds mojo/public/cpp/platform to the public library. This includes > a new PlatformHandle type, a thin C++ abstraction for platform-specific > scoped handle values. > > This is a precursor to moving platform channel C++ types out of the EDK > and into the public library, and ultimately introducing a public C++ > invitation API to replace the EDK invitation API. > > Bug: 844764 > Change-Id: I317decc1deb8cc47eb1000a6a19022465c392d7b > Reviewed-on: https://chromium-review.googlesource.com/1068688 > Reviewed-by: Jay Civelli <jcivelli@chromium.org> > Commit-Queue: Ken Rockot <rockot@chromium.org> > Cr-Commit-Position: refs/heads/master@{#560866} TBR=jcivelli@chromium.org,rockot@chromium.org Change-Id: If401afe09a2e91d5e2a0035a75db5490a41259ad No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 844764 Reviewed-on: https://chromium-review.googlesource.com/1068219Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#560876}
-
Darren Shen authored
Currently, we have two container behaviors: full width and floating. In the full width VK, the occluded bounds is the same as the bounds of the keyboard window. In the floating VK, nothing is occluded. Thus, with only these two container behaviors, we could get away with having a single boolean function (BoundsObscureUsableRegion) that indicates whether the occluded bounds is the bounds of the keyboard window or the empty rectangle. However, the new fullscreen VK has an occluded region, but it is not the same as the keyboard window. Therefore, we need to change the boolean function into a function that actually returns the occluded bounds. We also make some changes to clarify which bounds are being referred to. Bug: 826617 Change-Id: I928294d81808cb11090f96b6fc81c6a123a2595e Reviewed-on: https://chromium-review.googlesource.com/1067218 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#560875}
-
Hiroshige Hayashizaki authored
This CL replaces the most of ScriptLoader references in ScriptRunner with PendingScript. ScriptLoader is still used - When the script is evaluated, because ScriptLoader::Execute() is still in ScriptLoader. ScriptLoader is obtained by PendingScript::GetElement()->Loader() here, but this will be removed by [1] once ScriptLoader::Execute() is removed. - When the script element is moved between documents, because we have to get PendingScript via the Element->ScriptLoader->PendingScript path. This is done by GetPendingScriptIfControlledByScriptRunnerForCrossDocMove() in MovePendingScript(), which will be the last use of GetPendingScriptIfControlledByScriptRunner() that will remain until [2] that is not planned to land soon. No behavior changes. [1] https://chromium-review.googlesource.com/1054553 [2] https://chromium-review.googlesource.com/1041143 Bug: 842349 Change-Id: Idc36b00c8c25fe8e24ff60e980608d8b324fec5e Reviewed-on: https://chromium-review.googlesource.com/1053354 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#560874}
-
Michael Lippautz authored
- Add Round{Up,Down}ToPageAllocationGranularity. - Add unittests for rounding. Change-Id: I131a0b493867fbe54ca2a6d1382fa6176e984162 Reviewed-on: https://chromium-review.googlesource.com/1067524Reviewed-by:Albert J. Wong <ajwong@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#560873}
-
Josh Horwich authored
Ensure ARC-related consents are recorded as NOT_GIVEN if the user cancels during initial setup or during in-session setup of ARC. Bug: b:79583966 Test: Cancel ARC opt-in in OOBE and from launcher, unit_tests Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I840f90af86c01f1961918b99fd10acf7ef63a354 Reviewed-on: https://chromium-review.googlesource.com/1062971Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Josh Horwich <jhorwich@chromium.org> Cr-Commit-Position: refs/heads/master@{#560872}
-
Anna Offenwanger authored
Added a value to allow a resetpose event to be propogated from GVR out to the javascript. Bug: 843184 Change-Id: I5433be4f26af21fa09a35b7485d8c7911a5e89c2 Reviewed-on: https://chromium-review.googlesource.com/1063027Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Anna Offenwanger <offenwanger@chromium.org> Cr-Commit-Position: refs/heads/master@{#560871}
-
Tetsui Ohkubo authored
This CL renames TrayDetailsView to TrayDetailedView, as in other places it's always called "detailed view" e.g. CreateDetailedView(), NetworkStateListDetailedView, CastDetailedView, AccessibilityDetailedView, etc. TEST=ash_unittests BUG=none Change-Id: I84bc2fc7ade4bc71d9907427c35501f21f9da3a6 Reviewed-on: https://chromium-review.googlesource.com/1068888Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#560870}
-
Sean Kau authored
Parse uri verifies that if a port is provided, it has a valid value. We accept empty paths. We also validate that there is a valid scheme value is provided if it is found. These requirements are now validated via unit test. Bug: 844521 Change-Id: I4fb28a5bba8e6bea9ac9a0bb2e6b4de21351d892 Reviewed-on: https://chromium-review.googlesource.com/1066949 Commit-Queue: Sean Kau <skau@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#560869}
-
Min Qin authored
This CL adds a new UMA to track dropped download Change-Id: I55120c5227552ac280a768e3bf2d82dd247a5329 Reviewed-on: https://chromium-review.googlesource.com/1066739Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#560868}
-
Alan Cutter authored
PageActionIconViews in chrome/browser/ui/views/location_bar will get migrated to chrome/browser/ui/views/page_action as part of crbug.com/788051. This CL adds estade, an OWNER of location_bar, to the OWNERS of page_action. pkasting is not being added because they have higher level OWNERS and requested not to be added to the new directory. Change-Id: Ia400f3b74e0cadcb719990a22a542a848d07c999 Reviewed-on: https://chromium-review.googlesource.com/1065410Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#560867}
-
Ken Rockot authored
Adds mojo/public/cpp/platform to the public library. This includes a new PlatformHandle type, a thin C++ abstraction for platform-specific scoped handle values. This is a precursor to moving platform channel C++ types out of the EDK and into the public library, and ultimately introducing a public C++ invitation API to replace the EDK invitation API. Bug: 844764 Change-Id: I317decc1deb8cc47eb1000a6a19022465c392d7b Reviewed-on: https://chromium-review.googlesource.com/1068688Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#560866}
-
Hector Carmona authored
Bug: 814117 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Iac4324eb5c8790edf9affec485f5a3a91c985908 Reviewed-on: https://chromium-review.googlesource.com/1068113 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by:
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/398fb44e2866..ebdd0db493b2 $ git log 398fb44e2..ebdd0db49 --date=short --no-merges --format='%ad %ae %s' 2018-05-21 ehmaldonado gclient: Remove URLs from hierarchy. 2018-05-21 ehmaldonado gclient: Refactor PrintRevInfo Created with: roll-dep src/third_party/depot_tools BUG=chromium:839925,chromium:839925 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I116c57cdcbf6d9c09c93663777cfd970a1fa9ae6 Reviewed-on: https://chromium-review.googlesource.com/1069596 Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#560864}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/6cc8fb177b33..12f7d6baa725 $ git log 6cc8fb177..12f7d6baa --date=short --no-merges --format='%ad %ae %s' 2018-05-22 dtu [pinpoint] Use _comparison_mode to determine values type. Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I02e98b61229bd50fd7b75b7772c0691cc74ae995 Reviewed-on: https://chromium-review.googlesource.com/1069723Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#560863}
-
Sahel Sharify authored
This reverts commit a8a4a6f6. Reason for revert: This change is not needed anymore. Original change's description: > Long press shouldn't get suppressed after tap down suppression. > > Bug: 838971 > Change-Id: Ic296d7e5792ed38cc636b1f84d7d3d2e1ac229cb > Reviewed-on: https://chromium-review.googlesource.com/1037424 > Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> > Reviewed-by: Dave Tapuska <dtapuska@chromium.org> > Cr-Commit-Position: refs/heads/master@{#555536} TBR=dtapuska@chromium.org,sahel@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 838971 Change-Id: I09106b10fcfd2f2568c9716a28f3c620794e2482 Reviewed-on: https://chromium-review.googlesource.com/1062341 Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> Reviewed-by:
Sahel Sharifymoghaddam <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#560862}
-
Kinuko Yasuda authored
In order to avoid potential dead-locks with synchronous fetches. The same can be done for fetches from main threads too, but it's not really necessary as currently synchronous loads from the main thread (i.e. sync XHR) don't go through service workers (and also is deprecated). On workers on the other hand sync XHR is not deprecated (and existing service worker code supports interception), and importScripts() also need to go through service workers. Bug: 843860 Change-Id: I068be4b4bfb7e37cd2b2aabb0be848931ee107c7 Reviewed-on: https://chromium-review.googlesource.com/1065402 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#560861}
-
Zach Helfinstein authored
Also modify it to look like buttons for ChromeVox / Select to Speak Bug: 842242 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I1dfa42917ac35d13f300090e92672f8f62e3d798 Reviewed-on: https://chromium-review.googlesource.com/1055770 Commit-Queue: Zach Helfinstein <zhelfins@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
-
Sidney San Martín authored
This was causing window resize jank. This hack was added in r364897, and it's unclear to me if it's needed on Mac. Removing it seems to work, but I wish I had more context. Bug: 682825 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I1d9e1224297d78f3c5a08a6774acbe816a6e1c81 Reviewed-on: https://chromium-review.googlesource.com/1069037Reviewed-by:
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/64ac5d9eb62e..31d3deb41a44 $ git log 64ac5d9eb..31d3deb41 --date=short --no-merges --format='%ad %ae %s' 2018-05-18 jgilbert Add `formatType` arg to computeSkipBytes. Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=lucferron@chromium.org Change-Id: I52f544636cabd066a2ffd42ebe26aff008e14843 Reviewed-on: https://chromium-review.googlesource.com/1069700Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#560858}
-
Luis Hector Chavez authored
This change avoids a crash when NodeController::pending_broker_clients_ and NodeController::pending_invitations_ diverge. This might happen with complex enough node topologies, where there is a node that proxies invitations to a set of other nodes. BUG=845709 Change-Id: Ia678f464fafb69628600ec00dac19da3b6868fe0 Reviewed-on: https://chromium-review.googlesource.com/1069728Reviewed-by:
-
