- 03 Oct, 2018 40 commits
-
-
Kenichi Ishibashi authored
In production, the loader factory runs on a background thread. Change-Id: If5261b012d96b714135118a2157092cb7fa983f2 Bug: N/A Reviewed-on: https://chromium-review.googlesource.com/c/1256396 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#596132}
-
Robert Ogden authored
This infobar notifies existing DataSaver users that this new feature will impact their secure page browsing as well. This is done on the first eligible pageload after the feature is released and enabled. A simple boolean pref keeps track of this state persistently. The user does not need to interact with the infobar. Once it has been shown one time it should not be shown again and this preview can be triggered. Prior to being shown, the preview should not be triggered on otherwise eligible page loads. Users who do not have DataSaver enabled should not see the infobar. Bug: 889124 Change-Id: I6eb52f516555980a0af90505637201669451c03f Reviewed-on: https://chromium-review.googlesource.com/c/1244903 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#596131}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/deb512045e6a..be8193c9313a git log deb512045e6a..be8193c9313a --date=short --no-merges --format='%ad %ae %s' 2018-10-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 df836ff8f17d..607f907d47b0 (2 commits) Created with: gclient setdep -r src/third_party/skia@be8193c9313a The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=mtklein@chromium.org Change-Id: Ib5d3b17cff2cd936e95c118cc737ce95f1b1c363 Reviewed-on: https://chromium-review.googlesource.com/c/1258414Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#596130}
-
Tarun Bansal authored
Enable the experiment to delay low priority requests on multiplexed connections. net-dev thread: https://groups.google.com/a/chromium.org/forum/#!topic/net-dev/abRbGlGlNd0 loading-dev thread: https://groups.google.com/a/chromium.org/forum/#!topic/loading-dev/s22tVFiDru0 predictability-advice: http://shortn/_WJaP3jsRbk Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I6141733ec7bfbd45c6b3c3d8ed98857104dee442 Bug: 836552 Reviewed-on: https://chromium-review.googlesource.com/c/1257677Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
-
François Beaufort authored
This CL makes sure DetectedBarcode, DetectedFace, and DetectedText results can be passed as a message in postMessage(). Change-Id: If8e50d359a321816222a3fabfa9bb02c4106154a Reviewed-on: https://chromium-review.googlesource.com/c/1251549Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#596128}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/78bda58bfcba..fe82844a1a45 Created with: gclient setdep -r src-internal@fe82844a1a45 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ia83cfed80a0f7c1d41f39542c0b1db3c1dd3b656 Reviewed-on: https://chromium-review.googlesource.com/c/1258415Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#596127}
-
Hwanseung Lee authored
https://google.github.io/styleguide/cppguide.html#Namespace_Names > Namespace names are all lower-case. This CL has no behavior changes. Bug: 889726 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I361dbb5b1bf477623a772f1b0e6d074283bf6c5d Reviewed-on: https://chromium-review.googlesource.com/c/1258642Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com> Cr-Commit-Position: refs/heads/master@{#596126}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/e6ded16045a9..086cac5c439c git log e6ded16045a9..086cac5c439c --date=short --no-merges --format='%ad %ae %s' 2018-10-03 buildbot@webrtc.org Roll chromium_revision b06fe539..601c715f (595926:596047) Created with: gclient setdep -r src/third_party/webrtc@086cac5c439c The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I84e748da83bbd53a5df6afee6f0eb26a6d9743b2 Reviewed-on: https://chromium-review.googlesource.com/c/1258413Reviewed-by:
-
Yutaka Hirano authored
The test has used synchronous XHR, but blink::ThreadableLoader ignores a network error for the synchronous case. Currently CORS is implemented in ThreadableLoader and thus the error is notified, but that will not be true with out-of-blink CORS. This CL fixes the test so that it uses asynchronous XHR to make it pass even with out-of-blink CORS. Bug: 870173 Change-Id: I1c315ddf7f2a25d54f6de7f297d16677da8ba862 Reviewed-on: https://chromium-review.googlesource.com/c/1245057Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#596124}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9bebca3c7eec..78bda58bfcba Created with: gclient setdep -r src-internal@78bda58bfcba The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I92e681dd678e574a629f5473740a1ae5b047c1ff Reviewed-on: https://chromium-review.googlesource.com/c/1258411Reviewed-by:
-
Hiroki Nakagawa authored
This CL makes SharedWorkerScriptFetcher ask network interceptors if they want to handle a response served by the default network loader. This is necessary for supporting AppCache's fallback. A possible confusing point of this CL is SharedWorkerScriptFetcher::OnReceiveResponse() can be called twice. First, it's called when the interceptor or the default network loader serves the shared worker's main script. Then, it's called again when the interceptor wants to serve an alternative response for the response served by the default network loader. Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I93b45fa1f2e42422c0e85d3a67471c891dc5992a Bug: 715632 Reviewed-on: https://chromium-review.googlesource.com/c/1224611Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#596122}
-
Joe Downing authored
We've received reports that the disconnect window is appearing at odd times after the auto-hide timeout has taken effect. I suspect there could be hardware which is emitting spurious HID events which is triggering the reshow logic. My assumption is that this behavior is't egregious, otherwise the user would notice the mouse cursor moving or errant keypresses. Thus I want to prevent triggering the reshow logic if we receive a RAWINPUT event where the cursor has not moved and no button states have changed. Bug: 891584 Change-Id: Id9efd72f24f8caf0e67b1a717fee2bbafaab55af Reviewed-on: https://chromium-review.googlesource.com/c/1258316 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#596121}
-
Andrey Kosyakov authored
... just use the command line switch instead. This is one of a steps to prepare for the network service migration -- network service does not expose an interface other than command line flag to configure resolver, so we could as well let it interpret the flag directly. Bug: 838291 Change-Id: I249beb1b64a0b5f332a1f2fa43325af2c4c0a6b6 Reviewed-on: https://chromium-review.googlesource.com/c/1258326Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#596120}
-
Hiroki Nakagawa authored
Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I6933b37bf1e876f5c622876dd1c84ff830436c6a Bug: n/a Reviewed-on: https://chromium-review.googlesource.com/c/1245341Reviewed-by:
-
Malay Keshav authored
This patch implements a thread safe wrapper for the core skottie animation object. We want to share the same animation resource file for multiple SkiaVectorAnimation objects. This would allow us to do that. This is also needed to implement the Phase 2 and Phase 3 of rasterization where the rasterization would be handled by different threads. go/cros-skottie Bug: 890512, 890224 Change-Id: I40371e58985ea4db5661f28a2ee8b31aab354a03 Component: Skia vector animation, skottie Reviewed-on: https://chromium-review.googlesource.com/c/1253071Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#596118}
-
Victor Miura authored
Adds stories for root scroller cases, with a "position:fixed" element on top. BUG=880195 Change-Id: I3b293a1818225aca5807adc60f5db3954d61eb95 Reviewed-on: https://chromium-review.googlesource.com/c/1252634Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Commit-Queue: Victor Miura <vmiura@chromium.org> Cr-Commit-Position: refs/heads/master@{#596117}
-
Bo Liu authored
Obtained desired data. Bug: 841572, 891053 Change-Id: Ib81d8fb1ad0dc6df8437fe16264c249b60a5ae30 Reviewed-on: https://chromium-review.googlesource.com/c/1257856Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#596116}
-
Tetsui Ohkubo authored
This CL adds NewUnifiedMessageCenterView and UnifiedMessageListView that replace UnifiedMessageCenterView, and MessageListView. The new implementation is behind a flag (--enable-features=NewMessageListView). Eventually old implementation will be removed and NewUnifiedMessageCenterView will be renamed to UnifiedMessageCenterView. Design doc: go/chrome-popup-refactoring TEST=UnifiedMessageListViewTest BUG=769219 Change-Id: I1db9d73acfed918bc73b828ef3b406ef5da97a0c Reviewed-on: https://chromium-review.googlesource.com/c/1244182 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#596115}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/779366899ae8..e6ded16045a9 git log 779366899ae8..e6ded16045a9 --date=short --no-merges --format='%ad %ae %s' 2018-10-02 qingsi@google.com DCHECK that PortAllocator::SetConfiguration does not create a pooled 2018-10-02 steveanton@webrtc.org Check all BasicPortAllocatorSession methods are called on the network thread 2018-10-02 peah@webrtc.org AEC3: Correct the check for not reacting on initial pre-amp gain changes Created with: gclient setdep -r src/third_party/webrtc@e6ded16045a9 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I9ba1d5747615e0324eaafcfb04efad2ca76e5ea7 Reviewed-on: https://chromium-review.googlesource.com/c/1258255Reviewed-by:
-
yoshiki iguchi authored
Previously it was rarely visible but now it's visible on closing. So this CL improves the quality of shapshot by enabling shrink filter. Bug: none Change-Id: Ic509de0d83d5641f9a18acdb73e759639cb38507 Reviewed-on: https://chromium-review.googlesource.com/c/1255749Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#596113}
-
Koji Ishii authored
Following bot results are included. 10213 10215 10219 10221 10225 10229 10232 10234 10241 10246 2 lines were removed and 3 lines were deflaked by consecutive results since 10201. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ic45d48d8852938576bbb01d1758853875795cda4 Reviewed-on: https://chromium-review.googlesource.com/c/1255742 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#596112}
-
Alexey Baskakov authored
TBR=poromov@chromium.org TEST=none Bug: 891573 Change-Id: I3837b32e995ac6d7dd757ca70a0a8d16e6c7e2a6 Reviewed-on: https://chromium-review.googlesource.com/c/1257485 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#596111}
-
Morten Stenshorne authored
This changes how we calculate the reference box when the layout box is a non-atomic inline. It was very broken for LayoutNG; we just set the height to 0. For legacy layout we used the width of the bounding box for all lines and the height of the first fragment. Instead, consistently use the size of the first fragment, in both NG and legacy. Also get it right if writing-mode is vertical-rl. Bug: 641907 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I652f197bc3d950fad1bf6067dc5f38c2df72a0a3 Reviewed-on: https://chromium-review.googlesource.com/c/1256808Reviewed-by:
Fredrik Söderquist <fs@opera.com> Reviewed-by:
-
Joel Hockey authored
This is a reland of dec38a71 Failure was flaking in test FileManagerUITest.Crostini which was caused by dialogs not being fully cleared before a new dialog was being shown. This is fixed by changing the test code to wait for the dialog elements to be fully removed from the dom: assertTrue(test.fakeMouseClick('button.cr-dialog-ok')); test.waitForElementLost('.cr-dialog-container'); rather than just waiting for the .shown class to be removed: assertTrue(test.fakeMouseClick('button.cr-dialog-ok')); test.waitForElementLost('.cr-dialog-container.shown') The behaviour that we were getting was: 1/ show dialog1: adds div.cr-dialog-container.shown to body 2/ test clicks on OK button to close dialog1. 3a/ dialog1 div.cr-dialog-container removes .shown attr The removal of the dialog div is delayed by design. 4/ next test show dialog2: 2nd div.cr-dialog-container added to body 5/ test clicks on OK button to close dialog2, but actually ends up clicking on dialog1 6/ Error at https://cs.chromium.org/chromium/src/ui/webui/resources/js/cr/ui/dialogs.js?l=262&rcl=e20c6e8387cdccf61eef8615ac2b3b0a582b156b 3b/ dialog1 div finally removed from dom. Original change's description: > CrOS FilesApp: Share crostini entries before opening > > When a user opens files within Downloads using a crostini app, > show a dialog for the user to give permission to share the > directory that the files are in with crostini. > > * Move handling of 'crostin-files' flag checking into > foreground/js/crostini.js > * Change FileTasks.executeInternal to detect files that > can be shared with crostini and do sharing before execute. > * UI Test verifies share dialog is shown before execute. > * ConvertFileSystemURLToPathInsideCrostini maps > path from within Downloads to '/ChromeOS/Downloads/...' > > Bug: 878324 > Change-Id: Ie88090ff958dd201aeacb23fdfcc84a4f3d20210 > Reviewed-on: https://chromium-review.googlesource.com/c/1243871 > Reviewed-by: Nicholas Verne <nverne@chromium.org> > Reviewed-by: Luciano Pacheco <lucmult@chromium.org> > Commit-Queue: Joel Hockey <joelhockey@chromium.org> > Cr-Commit-Position: refs/heads/master@{#596003} Bug: 878324 Change-Id: Ied6225dca13a244ebbdbfa291fdd789d762ee140 Tbr: nverne@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1258683 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#596109}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0daedf7758e1..22300e1fb562 git log 0daedf7758e1..22300e1fb562 --date=short --no-merges --format='%ad %ae %s' 2018-10-03 iannucci@chromium.org [led] Roll led to add gerritcodereview scope to edit-cr-cl Created with: gclient setdep -r src/third_party/depot_tools@22300e1fb562 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I3c670d7937c72b4f755b8a12723d94c3006a7bb5 Reviewed-on: https://chromium-review.googlesource.com/c/1258254Reviewed-by:
-
Jordy Greenblatt authored
Settings has strongly urged us to move away from dynamically attaching and detaching the MultiDevice page from Settings UI. After this push, I looked into the costs of that and with khorimoto@ decided they were small enough to warrant the refactor given the rarity of this functionality in practice. Note that MultiDevice settings flag already controls whether to allow the page at a higher level so that does not rely on the dynamic attachment ability provided by the multidevice-page-container. An additional incentive is to prevent a few display bugs (see the bugs merged into 887784 for details) that are very likely to be irrelevant once this infrastructure is removed. Screenshots from the cases that cause the MultiDevice page to detach in the HEAD version: http://screen/BW2npVh2Ocw http://screen/pKLechGvcCp Bug: 887784 Change-Id: Iaefb8bff4ae300c483645e2558b8a95083e2bc47 Reviewed-on: https://chromium-review.googlesource.com/c/1258211 Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#596107}
-
Joe Downing authored
We've seen a few bugs filed recently for problems related to capturing key events via the low-level hook on Windows. These have all turned out to be related to the fact that the low-level hook intercepts the key events before the OS can update its internal state. An example problem is that WM_CHAR messages are not generated if the hook captures the alpha keys. Since the goal of the hook is to intercept/prevent system key combos, I have decided to invert the logic for the Windows version of the KeyboardHook. Now the hook will only handle Alt, Ctrl, and Win keys. Shift is not intercepted as I want the OS to process it so the correct chars are produced for WM_CHAR messages. The result is that the hook is a bit less powerful / flexible with respect to what it can be asked to capture, however when lock() is called w/o parameters the API will block system combos and the key events the webpage will receive will be the same whether the hook is active or not. This is not a problem on other platforms as ChromeOS/Linux have a 'passive' hook where the key state is calculated before the events are passed to us. MacOS would use an active hook however it hasn't been implemented yet. BUG=872396 Change-Id: I8dc2416f4ad026a66e766aa3610835612e5bdccc Reviewed-on: https://chromium-review.googlesource.com/c/1162700Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#596106}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=abdulsyed@chromiue.org Change-Id: Ib32f16feb0b8cabb2fd38fd841b67eac72555c6e Reviewed-on: https://chromium-review.googlesource.com/c/1258288Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#596105}
-
Chris Blume authored
Building Chromium for Android currently does not support Vulkan. However, Vulkan headers were accidentally being included anyway. This was causing a redefinition error when Skia opted to always include Vulkan but only use it when requested. This patch puts the Vulkan includes behind a flag to match existing gating. BUG=891525 Change-Id: I88b759451a6353a762ea65cdbe34a4c467799ff2 Reviewed-on: https://chromium-review.googlesource.com/c/1257651Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#596104}
-
Tetsui Ohkubo authored
In order to prevent mistouch, we should hide some Shelf icons while ARC++ keyboard is open. It's not limited to ARC++ virtual keyboard, and also affects Chrome OS virtual keyboards. However, they are shown above Shelf, so visually they won't change. This CL hides: * App icons on the shelf * Tray buttons e.g. System Tray, overview mode, etc. This CL does not hide: * Back & Launcher buttons * Keyboard tray button See the mock on the design doc for detail: go/androidime-on-cros TEST=manual BUG=882373 Change-Id: I75c07e25dcf16a1b987047093d172f68295ae480 Reviewed-on: https://chromium-review.googlesource.com/c/1250761 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#596103}
-
Sunny Sachanandani authored
Record the overlay format chosen at startup, and format used at runtime for every swap chain. Replace existing histograms which don't work correctly, or work well with multiple swap chain formats. Add a histogram for CreateSwapChain... result for each format to see if using NV12 causes more failures than YUY2. Bug: 869677 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ie11dcaee6c9be6c6985a98dc01d7d0219b611988 Reviewed-on: https://chromium-review.googlesource.com/c/1258003Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
-
Gang Wu authored
got a bug about encoding and decoding, basically it is because covert between string and bytes in JAVA will be wrong if there are negative numbers, so covert them in C++ to avoid it. Bug: 889623 Change-Id: If6916ef30860bc1c3017c95447da6d95669fe793 Reviewed-on: https://chromium-review.googlesource.com/c/1253078Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#596101}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/0c56d6362b95..a1c846c4cf3f git log 0c56d6362b95..a1c846c4cf3f --date=short --no-merges --format='%ad %ae %s' 2018-10-02 thestig@chromium.org Clean up some XFA forward declarations. 2018-10-02 thestig@chromium.org Avoid overloading CFGAS_FontMgr::LoadFont(). Created with: gclient setdep -r src/third_party/pdfium@a1c846c4cf3f The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I3d70f3fa56add897a127ac1777e9ae3584441e79 Reviewed-on: https://chromium-review.googlesource.com/c/1258408Reviewed-by:
-
Eugene Kim authored
This patch simplifies conditions around the code in ui/ It is much easier to write & read: if (base::ContainsValue(my_vector, my_search_value)) than: if (std::find(my_vector.begin(), my_vector.end(), my_search_value) != my_vector.end()) Bug: 561800 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I25733c6a308664b8215bd300a7b85baac90acd33 Reviewed-on: https://chromium-review.googlesource.com/c/1218804Reviewed-by: -
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2be958cd896f..9bebca3c7eec Created with: gclient setdep -r src-internal@9bebca3c7eec The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:891313 TBR=mmoss@chromium.org Change-Id: Ib56f92b26397e280f731d282a7b40e2aa464d1b9 Reviewed-on: https://chromium-review.googlesource.com/c/1258253Reviewed-by:
-
Miyoung Shin authored
This CL supports to write/read the multiple file names for dragging on Mac. BUG=878690 Rename the email self in AUTHORS Change-Id: I3bba2912ad5f89de7e8fb106c89c8f4eb6468935 Reviewed-on: https://chromium-review.googlesource.com/c/1256791Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@chromium.org> Cr-Commit-Position: refs/heads/master@{#596097}
-
Zhenyao Mo authored
With --underlay, we add a div on top of video to make sure video layer is an underlay. Note that without --underlay, the video could still be an underlay due to controls, ads, logo, etc. At the moment we don't have a way to force overlay mode. BUG=867155 TEST=manual R=kainino@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: If86f759b7f8bc13022b5f24a1031d7e0be3aef3a Reviewed-on: https://chromium-review.googlesource.com/c/1258315Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#596096}
-
Kouhei Ueno authored
Bug: 890180 Change-Id: I36d8b9b7d133104dc6dae34c465fa4dc08a7a26b Reviewed-on: https://chromium-review.googlesource.com/c/1253162 Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
-
Joel Hockey authored
FileNotFound is the correct error that should be thrown in this case, and is consistent with the handling in VolumeInfoImpl.prototype.resolveTeamDrivesRoot_. Bug: 891562 Change-Id: I41e663a47c6f51190bb2344969a8eca6df36b3a3 Reviewed-on: https://chromium-review.googlesource.com/c/1258662Reviewed-by:
Stuart Langley <slangley@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#596094}
-
rbpotter authored
Ensure that all is not reselected when an invalid input is cleared. Similar to scaling, achieve this by not resetting the backing pages value (or its validity) when an invalid input is cleared. This also saves a preview refresh. Also adding tests for some pages behaviors from this and prior CLs. Bug: 890670 Change-Id: I34285b311f7abd0c992557151f90867cd36cb375 Reviewed-on: https://chromium-review.googlesource.com/c/1256624Reviewed-by:
-
