- 02 Aug, 2018 40 commits
-
-
Nick Harper authored
Change-Id: I6863a2999525ac07cf942c26da5d6f8cf97eafa1 Reviewed-on: https://chromium-review.googlesource.com/1159352Reviewed-by:
Bence Béky <bnc@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#580230}
-
Evan Stade authored
This re-lands commit 1edc413f. Original change is ps1, fix is in latest patchset. Original change's description: > OopAsh: port/enable some more browser tests. > > Bug: 854704 > Change-Id: Ic3dcef42f108beb02a398302f3ecd70dd72c0f2d > Reviewed-on: https://chromium-review.googlesource.com/1153777 > Commit-Queue: Evan Stade <estade@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#579476} Bug: 854704 Change-Id: I0a264093a2d90b00bcdc5a0e2e71a9d391336fea Reviewed-on: https://chromium-review.googlesource.com/1159086 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#580229}
-
Demetrios Papadopoulos authored
These errors are causing all of the Settings tests to fail on CrOS. Fixing those in preparation of adding webui_polymer2_browser_tests test suite. Bug: 862472 Change-Id: Ica46f1fbef0f119c554d9003734544606c095c3c Reviewed-on: https://chromium-review.googlesource.com/1160864Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#580228}
-
Friedrich Horschig authored
This CL introduces impression and click metrics for all actions and suggestions and the accessory sheet in general. Bug: 853766 Change-Id: I47376dae669b99ae0e8701fb2e04efa292e8f673 Reviewed-on: https://chromium-review.googlesource.com/1157005Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#580227}
-
David Tseng authored
The capture state lives in ash, where ChromeVox sets the state (extension -> browser -> ash). This state gets delivered (ash -> browser) to the SpokenFeedbackEventRewriterDelegate. At that point, we should always allow the event to continue onto ChromeVox, and only re-inject if the key is captured. The previous logic was put into place when this code always sent the delegate all keys. Bug: 868573 Change-Id: I6bde8b021d093c52d4450682c4d037a7ef4938a0 Reviewed-on: https://chromium-review.googlesource.com/1159176Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#580226}
-
bsheedy authored
Adds a sleep (ew) after entering presentation in VR tests for testing that the Daydream controller's app buton exits presentation. This works around a VrCore issue when skipping the DON flow that causes the controller to briefly disconnect and reconnect when entering VR, eating any controller input that's sent during that time. Bug: 870031 Change-Id: Id888826907c9548120d36b0dde67e30271d4bc85 Reviewed-on: https://chromium-review.googlesource.com/1159398Reviewed-by:
Amirhossein Simjour <asimjour@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#580225}
-
Igor Eremeev authored
ZipFile does not implement Closeable interface prior to api19: https://developer.android.com/sdk/api_diff/19/changes/java.util.zip.ZipFile It was introduced as a fix for failed library extraction here: https://chromium-review.googlesource.com/c/chromium/src/+/930332 So, this code gets executed quite rare, but I can see some "java.lang.IncompatibleClassChangeError: interface not implemented" errors on our radars at Yandex, mostly Huawei 4.1.2, 4.2.* and 4.3.*. Since non-googlers don't have access to crash tickets, I can't check if Chrome has same issues, but I believe that you have. This CL adds a custom closeQuietly method for ZipFile, and rewrites a try-with-resources statement with it. Docs say that ZipFile.close() also closes all the streams, so I removed InputStream from try as well: https://developer.android.com/reference/java/util/zip/ZipFile.html#close(). R=agrieve@chromium.org,ranj@chromium.org Change-Id: I6b626bf87f01f5598ab61be3ac88759b4c7076e2 Reviewed-on: https://chromium-review.googlesource.com/1156397Reviewed-by:
-
Tarun Bansal authored
Bug: 869447 Change-Id: I64c205b5ffb2126382c04f5aeefe1cb88010744a Reviewed-on: https://chromium-review.googlesource.com/1156993Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#580223}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/174d7f61ba90..a31f4e51d559 git log 174d7f61ba90..a31f4e51d559 --date=short --no-merges --format='%ad %ae %s' 2018-08-02 egdaniel@google.com Make sure we check the version number of Vulkan Extensions. Created with: gclient setdep -r src/third_party/skia@a31f4e51d559 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@chromium.org Change-Id: I3fe8a2af61bd1ecc4dd6ee5939967da537d384b6 Reviewed-on: https://chromium-review.googlesource.com/1160784Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580222}
-
Tom McKee authored
Change-Id: I5c9b07a3252a6cc3c303c8da3ccd2252be72d242 Reviewed-on: https://chromium-review.googlesource.com/1158717 Commit-Queue: Tom McKee <tommckee@chromium.org> Reviewed-by:
-
Nicolas Pena authored
Bug: 649392 Change-Id: I1dcafd6ea561c3d4505c3e4507904a0872dadbac Reviewed-on: https://chromium-review.googlesource.com/1156986Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#580220}
-
Sky Malice authored
Previously the startMainActivityOnBlankPage() ca;; could result in a task being added to the stored task info list. This change fixes this by simply clearing the list of stored task infos. Bug: 868647 Change-Id: I0719613e697dd8c5f618db99d02490ce3313a2da Reviewed-on: https://chromium-review.googlesource.com/1155762 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#580219}
-
Xiaoqian Dai authored
When the drag ends, the source window might still be in bounds animation, thus we should compare the expected bounds to its target bounds. Bug: 869614, 823769 Change-Id: Ied81296fed19d16d3c833430860f9b20d2623431 Reviewed-on: https://chromium-review.googlesource.com/1159526Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#580218}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/9ac709a1b2a5..7110f0868455 git log 9ac709a1b2a5..7110f0868455 --date=short --no-merges --format='%ad %ae %s' 2018-08-02 sadrul@chromium.org rendering: Add pipeline:draw in the report. Created with: gclient setdep -r src/third_party/catapult@7110f0868455 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:855328 TBR=sullivan@chromium.org Change-Id: Iccfd9692ee21b9bf9e96cbdf4a44377c1c1e8918 Reviewed-on: https://chromium-review.googlesource.com/1160781Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580217}
-
Stephen White authored
Suppress failures for gpu_tests.pixel_integration_test.PixelIntegrationTest.Pixel_WebGLGreenTriangle_NoAA_Alpha gpu_tests.pixel_integration_test.PixelIntegrationTest.Pixel_WebGLGreenTriangle_NoAA_NoAlpha on Android FYI Release (Nexus 5). Bug: 870023 TBR: kbr@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I6de26ae7b418a54bafd9ecc8059a51e125b021f2 Reviewed-on: https://chromium-review.googlesource.com/1160596 Commit-Queue: Stephen White <senorblanco@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Stephen White <senorblanco@chromium.org> Cr-Commit-Position: refs/heads/master@{#580216}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6f812e132d25..5300616351f5 git log 6f812e132d25..5300616351f5 --date=short --no-merges --format='%ad %ae %s' 2018-08-02 jbudorick@chromium.org bot_update: expose patch_refs as an option to ensure_checkout. Created with: gclient setdep -r src/third_party/depot_tools@5300616351f5 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:865882 TBR=agable@chromium.org Change-Id: I8cd29238576f9f10b148c69ee961c911580c8b49 Reviewed-on: https://chromium-review.googlesource.com/1160783Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580215}
-
Daniel Murphy authored
R=mek@chromium.org Bug: 868578 Change-Id: I1c90f993f3e71d543b414c37a1b92bae5948b766 Reviewed-on: https://chromium-review.googlesource.com/1155483 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#580214}
-
Christopher Cameron authored
Instrument GLES2DecoderImpl::DoCommandsImpl to - record in a crash key all of the GL commands that have been flushed - flush at the end of every time that it is called This will severely regress performance. What we hope to learn: - There's a good chance this will make the bug vanish (egregious glFlush calls have been known to do this), in which case we'll learn nothing. - But maybe we can add less egregious glFlush calls to avoid the issue in Chrome 69 - If elevated crash rates persist, hopefully this will point to a particular call or sequence of calls that is causing the crash Bug: 863817 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I462fab8a6d86ee3896dcd9c0c3c4aa68f9de0a69 Reviewed-on: https://chromium-review.googlesource.com/1159831 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by: -
tzik authored
event_modules_factory.cc indirectly includes gamepad.mojom-blink.h, but there's no dependency between them. That causes a flaky build failure: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8939294599854040784/+/steps/compile/0/logs/raw_io.output_failure_summary_/0 Change-Id: I509f61c46957b3d3646c7c679113454148785df7 Reviewed-on: https://chromium-review.googlesource.com/1160825Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#580212}
-
Christos Froussios authored
It is flaky TBR=bradnelson@chromium.org Bug: 870309 Change-Id: I8a55fdaae7091b0dc32247527d50a35510e7a4bf Reviewed-on: https://chromium-review.googlesource.com/1160542Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#580211}
-
Mihai Sardarescu authored
For profiles with unified consent enabled, the sync state is completely ignored when deciding whether UKM is enabled. The decision whether UKM is allowed for a profile with user consent enabled is based only on the URL-keyed anonymized data collection enabled preference. This CL changes the UKM logic to check whether URL-keyed anonymized data collections is enabled for profiles where unified consent is enabled. This CL also updates the ProfileSyncServiceHarness to set/unset the state of the UnifiedConsentGiven flag when the state of sync everything changes. Bug: 861777 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I974a3eea2caa424efe44c1dd8b7c6f2bb24f156e Reviewed-on: https://chromium-review.googlesource.com/1152744Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#580210}
-
Elad Alon authored
In preparation of supporting compression of log files, introduce an interface named LogFileWriter, which will allow WebRtcEventLogManager to write either compressed or uncompressed log files. Bug: 775415 Change-Id: I4bc30fae88bba2e071d72aabfdf9fe05a5148af0 Reviewed-on: https://chromium-review.googlesource.com/1143472 Commit-Queue: Elad Alon <eladalon@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#580209}
-
Sergei Datsenko authored
If for some reason drivefs fails to start or crashes we want to do limited number of retries and then give up. BUG=chromium:845388 Change-Id: Ife550b76ba060adb2b3abc1a7674ae9b396e2677 Reviewed-on: https://chromium-review.googlesource.com/1158674Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Sergei Datsenko <dats@chromium.org> Cr-Commit-Position: refs/heads/master@{#580208}
-
Tommy Martino authored
ResetFirstAfterBootTest.RollbackUnavailable has been flaky. Disabling. TBR=xiyuan@chromium.org Bug: 870284 Change-Id: I7226ae73ca9c4cf440de3fbeae28886309d907d9 Reviewed-on: https://chromium-review.googlesource.com/1160866Reviewed-by:
Tommy Martino <tmartino@chromium.org> Commit-Queue: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#580207}
-
Ria Jiang authored
If host is already gone after we've found a target and is processing/ dispatching the event now, early return and drop the event. Bug: 814674 Change-Id: Ifa1b0aac45669413f954a843bf395aae229b969c Reviewed-on: https://chromium-review.googlesource.com/1129856Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Ria Jiang <riajiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#580206}
-
Mikel Astiz authored
This allows controllers to start datatypes in ephemeral mode, which is only supported by ModelTypeController. Bug: 866814 Change-Id: I20630c2ed52872baf0ecd23cccbd08f505e8835b Reviewed-on: https://chromium-review.googlesource.com/1151299 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#580205}
-
chcunningham authored
The (Fake)SigninManager should always be initialized before using. This is made more critical by upcoming changes* that will cause the test to fail if initialization is not performed. *https://chromium-review.googlesource.com/c/chromium/src/+/1154985 Bug: 806781 Change-Id: I06989a895f86b3ca9b1b84760b54ecafdaafdb03 Reviewed-on: https://chromium-review.googlesource.com/1160643 Commit-Queue: Chrome Cunningham (In Paris) <chcunningham@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#580204}
-
Gauthier Ambard authored
This is a reland of 1e910c7f. It is safe to reland as a fix for the test has landed downstream. Original change's description: > [iOS] Accessibility adjustments > > This CL adds a delay for the voice over announcement of the InProduct > Help tips. This delay is added to prevent the announcement to be > cancelled by the element being focused, when the tab is presented. > It also adds an accessibility label to the empty space where the omnibox > should be if the toolbar was visible. > > Bug: 866936 > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet > Change-Id: Ia75dd56772203e39b8d0bf1e94bef9cfacd87fdd > Reviewed-on: https://chromium-review.googlesource.com/1158236 > Commit-Queue: edchin <edchin@chromium.org> > Reviewed-by: edchin <edchin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#579886} TBR: edchin@chromium.org Bug: 866936 Change-Id: I0c96e39827d4fb8f815664b10414314cad42a20c Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/1160661 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#580203}
-
cathiechen authored
Like legacy layout, skip list marker while finding the first letter. Bug: 725277 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I467c766f8e362f7e12b8d9c7b0251fee02e1b0a2 Reviewed-on: https://chromium-review.googlesource.com/1156111 Commit-Queue: cathie chen <cathiechen@tencent.com> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#580202}
-
Jan Wilken Dörrie authored
This reverts commit d01b7c9e. Reason for revert: https://crrev.com/c/1159374 just landed, fixing the assertion error. Thus relanding the initial change. Original change's description: > Revert "[Bluetooth][WinRT] Implement Reading and Writing of Descriptors" > > This reverts commit f61df6f9. > > Reason for revert: Multiple BluetoothTestWinrt{,Only} tests failing on Win10 Tests bot after around this change. > > Sample builds: > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64%20%28dbg%29/2242 > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64%20%28dbg%29/2240 > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64%20%28dbg%29/2236 > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64%20%28dbg%29/2235 > > failures: > BluetoothTestWinrtOnly.GattServices_ObserversCalls/0 > BluetoothTestWinrt.GetPrimaryServices/1 > BluetoothRemoteGattServiceTestWinrt.SimulateGattServiceRemove/1 > BluetoothTestWinrt.GetPrimaryServicesByUUID/1 > BluetoothTestWinrtOnly.BluetoothGattConnection_DisconnectGatt_Cleanup/0 > BluetoothTestWinrt.GetGattServices_and_GetGattService/1 > BluetoothRemoteGattServiceTestWinrt.GetCharacteristicsByUUID/1 > BluetoothTestWinrtOnly.GattServicesDiscovered_Success/0 > > Original change's description: > > [Bluetooth][WinRT] Implement Reading and Writing of Descriptors > > > > This change implements reading and writing of Remote Gatt Descriptors > > for WinRT. Furthermore, it enables corresponding tests. > > > > Bug: 821766 > > Change-Id: I3ac07969c3fbf3806b71543ae79807c95efe78fe > > Reviewed-on: https://chromium-review.googlesource.com/1156703 > > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> > > Reviewed-by: Reilly Grant <reillyg@chromium.org> > > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#579838} > > TBR=reillyg@chromium.org,ortuno@chromium.org,jdoerrie@chromium.org > > Change-Id: Icb716ed05f9b8bec2a5b1bdd33692006314a99e7 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 821766 > Reviewed-on: https://chromium-review.googlesource.com/1159961 > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#580062} TBR=kinuko@chromium.org,reillyg@chromium.org,ortuno@chromium.org,jdoerrie@chromium.org Change-Id: I7c6455ea83413a3527ce59bf41fbf42f2bb80208 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 821766 Reviewed-on: https://chromium-review.googlesource.com/1160902Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#580201}
-
Jan Wilken Dörrie authored
This reverts commit 67ca5a07. Reason for revert: https://crrev.com/c/1159374 just landed, fixing the assertion error. Thus relanding the initial change. Original change's description: > Revert "[Bluetooth][WinRT] Implement Obtaining Gatt Descriptors" > > This reverts commit 20f64257. > > Reason for revert: Suspected of breaking device_unittests on Win10 Tests x64 (dbg) > > Original change's description: > > [Bluetooth][WinRT] Implement Obtaining Gatt Descriptors > > > > This change implements obtainining Remote Gatt Descriptors for WinRT by > > hooking up the appropriate logic into GattDiscovererWinrt. Furthermore, > > appropriate tests are enabled. > > > > Bug: 821766 > > Change-Id: I20475478367c2ab6b18940b4271de70ec138f676 > > Reviewed-on: https://chromium-review.googlesource.com/1156392 > > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> > > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > > Reviewed-by: Reilly Grant <reillyg@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#579830} > > TBR=reillyg@chromium.org,ortuno@chromium.org,jdoerrie@chromium.org > > Change-Id: If5128ebf0c9dd1f585bd98b9729a57340f4493a0 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 821766, 870208 > Reviewed-on: https://chromium-review.googlesource.com/1159943 > Reviewed-by: Christos Froussios <cfroussios@chromium.org> > Commit-Queue: Christos Froussios <cfroussios@chromium.org> > Cr-Commit-Position: refs/heads/master@{#580106} TBR=reillyg@chromium.org,ortuno@chromium.org,cfroussios@chromium.org,jdoerrie@chromium.org Change-Id: I8a4e456fe6d3b63c9d9b02c15ecdd35ac61a7fa7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 821766, 870208 Reviewed-on: https://chromium-review.googlesource.com/1160901Reviewed-by:
-
Kuo-Hsin Yang authored
Also remove unused indices in desktop_power_stories.json. Bug: chromium:810616 Change-Id: Id12e4ed6bf8433de5a7c1a08e5e86b3ad1b56bb0 Reviewed-on: https://chromium-review.googlesource.com/1160122Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Vovo Yang <vovoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#580199}
-
jdoerrie authored
BluetoothDevice::DeviceUUIDs::UpdateDeviceUUIDs() makes use of std::set_union in order to merge advertised uuids and service uuids. However, std::set_union requires sorted ranges as input, which wasn't necessarily guaranteed before this change. When using a std::unordered_set the order of elements is not specified and std::set_union is not guaranteed to work correctly. Using a base::flat_set for UUIDSet instead fixes this issue. In order to prevent future regressions this change also replaces the usage of std::set_union with base::STLSetUnion performing an explicit IsSorted() check in Debug builds. Bug: 821766, 870208 Change-Id: Id25711e6acf77ded9eebb6c80db5bcb2ed8a63e0 Reviewed-on: https://chromium-review.googlesource.com/1159374Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#580198}
-
Adam Langley authored
It broke because of the test that the response RP ID hash was actually the hash of the RP ID. (Which isn't true when using an AppID hash.) Obviously we were missing test coverage here, so add that now that it's easy to do with VirtualFidoDevice. (Confirmed that the test failed before the rest of these changes and passes now.) Change-Id: Ibd3b39339500e24f00c4f6c12ab4405ae0596107 Reviewed-on: https://chromium-review.googlesource.com/1159522Reviewed-by:
Jun Choi <hongjunchoi@chromium.org> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#580197}
-
Adam Rice authored
Make proxy.pac resolution for WebSockets work for Windows and Mac when the --winhttp-proxy-resolver flag is supplied. These platforms don't support passing WebSocket URLs to the proxy.pac file. Convert ws and wss URLs to http and https before passing them to proxy.pac. This matches the behaviour of the vendor browsers on these platforms. Add a WebSocket end-to-end test to verify that WebSockets can be accessed via a proxy specified in proxy.pac. Since preflighting proxy credentials makes the tests really complicated, add an extra mode to testserver.py for a vanilla proxy that doesn't require auth. BUG=862121 Change-Id: I63b318b7f6d3083a6c21f5811bb27966d17cb02a Reviewed-on: https://chromium-review.googlesource.com/1143093 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#580196}
-
Matt Menke authored
The only code outside of net/ / services/network that does direct proxy resolutions appears to be the two PPAPI consumers. This CL updates them both to use the new API. Bug: 810950 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I643605dfe2d8b67626ea8b84ee793b2c88b66e12 Reviewed-on: https://chromium-review.googlesource.com/1136875Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Reviewed-by:
-
chcunningham authored
Adds call to SigninManager::SignIn(...) as part of TestSuccessfulSignin helper method. This is needed to simulate real signin and becomes critical with upcoming changes* to FakeSigninManager. *https://chromium-review.googlesource.com/c/chromium/src/+/1154985 Bug: 806781 Change-Id: I973859ef52bcddd978429dbb4ce9d913224c7b0d Reviewed-on: https://chromium-review.googlesource.com/1160492 Commit-Queue: Chrome Cunningham (In Paris) <chcunningham@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#580194}
-
Eugene But authored
This integration tests now test TitleWasChanged, which is not navigation or load callback. Bug: None Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ic78b2758ac2ba92dece1034dc92328ce7b30cd1d Reviewed-on: https://chromium-review.googlesource.com/1159332Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#580193}
-
Eric Robinson authored
This CL adds tests to the AdTracker to verify that resources loaded by an ad script are marked properly ad ads during loaded. This does not work properly for images currently due to crbug.com/848916. Bug: 848916, 863446 Change-Id: I6643ec24c16ec7dceb9c60fd150046b86cb008ac Reviewed-on: https://chromium-review.googlesource.com/1140196Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Eric Robinson <ericrobinson@chromium.org> Cr-Commit-Position: refs/heads/master@{#580192}
-
Christos Froussios authored
It is flaky on mac_chromium_rel_ng Bug: 870259 No-try: True No-presubmit: True Change-Id: I73ac22cce3d7d03ce2f36c90d79e8a829fe28100 Reviewed-on: https://chromium-review.googlesource.com/1160543Reviewed-by:
-
