- 24 Oct, 2018 24 commits
-
-
Chromium WPT Sync authored
Using wpt-import in Chromium e7b0e89e. With Chromium commits locally applied on WPT: f79c6fe7 "Reimplementing getDatabaseNames() as databases() for indexeddb." 57cc1d42 "Added 304 CSP test and removed "content-*" prefix from headers to ignore on 304" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/26610 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: hongchan@chromium.org, rtoy@chromium.org: external/wpt/webaudio jsbell@chromium.org: external/wpt/resources NOAUTOREVERT=true TBR=markdittmer No-Export: true Change-Id: I909a0f2cc0420b1219bfbff68b9245a3447466c8 Reviewed-on: https://chromium-review.googlesource.com/c/1297188 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#602200}
-
Kyle Horimoto authored
Before this CL, the multi-device settings displayed Instant Tethering settings using exactly the same mechanism used by the network settings. However, this is undesirable because (1) it does not display the "prohibited" icon when a device administrator prohibits the feature and (2) it does not display the correct text as a label for the item. This CL changes the settings subpage to use the same infrastructure as the rest of the features. As a result, this also requires that TetherService be updated; previously, TetherService was responsible for changing the "enabled" user pref itself, but now it needs to support that mode as well as responding to changes of the "enabled" pref. Bug: 896324, 884830 Change-Id: I083a8e8e07725130058db35ee540dd6ad733d421 Reviewed-on: https://chromium-review.googlesource.com/c/1297594Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#602199}
-
Nico Weber authored
Bug: 897980,330260 Change-Id: I71bb304c6398484d5af5a981fdbc09314d69dd22 Reviewed-on: https://chromium-review.googlesource.com/c/1295272Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#602198}
-
Xi Cheng authored
Change-Id: I8b13dda1cef84337a0594c9b643da02d0426a3ee Reviewed-on: https://chromium-review.googlesource.com/c/1297584Reviewed-by:
Mike Wittman <wittman@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#602197}
-
Ted Choc authored
The reverse ordering introduced platform discrepancies between iOS and Android, which is not worth it for the initial launch. BUG=800033 Change-Id: Ib3f159404c7044e73ffca651e7bf60d59c77f142 Reviewed-on: https://chromium-review.googlesource.com/c/1297082 Commit-Queue: Ted Choc <tedchoc@chromium.org> Reviewed-by:
Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#602196}
-
Xianzhu Wang authored
After crrev.com/c/1277654, we no longer generate text result of many tests, thus these tests no longer need the text baselines. This CL removes all the extra baselines, including the extra text baselines after the above CL, and also other kind of extra baselines (e.g. extra -expected.png for reftests). Bug: 703899 Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Iadc647d0393e3f61a7d983bc3946042602de70c0 Reviewed-on: https://chromium-review.googlesource.com/c/1292599 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#602195}
-
Scott Chen authored
This CL touches up styling and strings for the full-bleed NUX views, including landing, sign-up, and email-interstitial. Bug: 874151 Change-Id: I29ee2ebea20136702aa0670eae54e5c486b32caa Reviewed-on: https://chromium-review.googlesource.com/c/1294306 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#602194}
-
Miguel Casas authored
This CL adds jpeg_encode_accelerator_unittests to the chromiumos_preflight target, so it gets compiled as part of the CQ (chromeos-amd64-generic-rel bot). Bug: 732531 Change-Id: I49e2db7d8259ee7746100cd858d1d19638384e87 Reviewed-on: https://chromium-review.googlesource.com/c/1297249Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
-
Kristi Park authored
Temporary fix for the 1px jitter that occurs when a custom link is hovered. Will be removed once the Blink library is fixed. Also fix a missing parentheses. Bug: 897006 Change-Id: Idea7a921d1933845fb3ab00ecaf649161b21b114 Reviewed-on: https://chromium-review.googlesource.com/c/1295170Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Commit-Queue: Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#602192}
-
Miguel Casas authored
crrev.com/c/1288609 changed the behaviour of the validation of GpuMemoryBufferHandle deserialization, which is used from mojos' CreateGpuMemoryBuffer(). Said CL changed the return path for Android to return false always (l.210, see [1]). Instead, we want to return the validity of the ScopedHardwareBufferHandle. ToT has a crash in e.g. https://codepen.io/miguelao/full/EReOgO, a lowLatency 2D Canvas context buffer. [1] crrev.com/c/1288609/3/ui/gfx/mojo/buffer_types_struct_traits.cc#210 Bug: 865957 Change-Id: Iccea7607163a6004d440b92197d44908d775e2f9 Reviewed-on: https://chromium-review.googlesource.com/c/1297469Reviewed-by:
Alexandr Ilin <alexilin@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#602191}
-
Justin Cohen authored
Bug: 826369 Change-Id: I5bf700ff19089ded0c276139282fceb9f8de72e9 Reviewed-on: https://chromium-review.googlesource.com/c/1297259 Commit-Queue: Justin Cohen <justincohen@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#602190}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/df56c1dae15e..c6a85907fbdd git log df56c1dae15e..c6a85907fbdd --date=short --no-merges --format='%ad %ae %s' 2018-10-23 chiniforooshan@chromium.org Telemetry: migrate the rest of smoothness metrics Created with: gclient setdep -r src/third_party/catapult@c6a85907fbdd The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:890757 TBR=sullivan@chromium.org Change-Id: Iddd7892c6226646ce5766c4faf1c6f9f624bcf9a Reviewed-on: https://chromium-review.googlesource.com/c/1297271Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#602189}
-
Katie D authored
Implements right-click, double-click, and no action; left-click was already implemented. Does not implement drag-and-drop. Adds unit tests for newly implemented click types. New strings share a screenshot hash because all strings could be captured in a single screenshot. See go/chromeos-dwell-design for more about autoclick and dwell control plans. Bug: 894907 Change-Id: If045ab1d3b9e2771d347963d5b17bdaf06362853 Reviewed-on: https://chromium-review.googlesource.com/c/1287191Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Oliver Chang <ochang@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#602188}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/8f7440e30ca2..ea62998cdf18 git log 8f7440e30ca2..ea62998cdf18 --date=short --no-merges --format='%ad %ae %s' 2018-10-23 primiano@google.com Merge "trace_processor: add memory events" Created with: gclient setdep -r src/third_party/perfetto@ea62998cdf18 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I4de4c531f0aca1089f2a3a677457c20f3cf335fe Reviewed-on: https://chromium-review.googlesource.com/c/1297117Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/437b09881705..ade44ef019d0 Created with: gclient setdep -r src-internal@ade44ef019d0 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I29b78880e01e2dee30ad10ab17e31dea0c5062aa Reviewed-on: https://chromium-review.googlesource.com/c/1297270Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#602186}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/03d6d1189692..879d5e3796bd git log 03d6d1189692..879d5e3796bd --date=short --no-merges --format='%ad %ae %s' 2018-10-23 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@879d5e3796bd The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I02b5d8877d128d26f2b5bb17f741a9cc3714195a Reviewed-on: https://chromium-review.googlesource.com/c/1296865Reviewed-by:
-
Xiaohan Wang authored
Currently VP9 profile 1 and 3 usage is super low, and hardware support is poor. To avoid the complexity of having to check which platform, device and/or decoder support them, with very little user benefit, we decided to disable VP9 profile 1 and 3 support wholesale at a higher level in EME implementation in Chromium. Bug: 898298 Test: Tests updated. Change-Id: Id3a4dc4fee050a7714f4e0e754d62a338433ad0b Reviewed-on: https://chromium-review.googlesource.com/c/1297295Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#602184}
-
Lukasz Anforowicz authored
Bug: 809261 Change-Id: I520ba33b5f314650370e7be7b50f809fc72de43d Reviewed-on: https://chromium-review.googlesource.com/c/1295185 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#602183}
-
John Rummell authored
The test needs to wait for the 'keystatuseschange' event to ensure the key statuses have been updated properly. BUG=896162 TEST=RemoveTemporarySession tests pass with the additional CL in the bug. Change-Id: I066743332a575b384db478829cdf4b87cc54606d Reviewed-on: https://chromium-review.googlesource.com/c/1287439Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#602182}
-
Tarun Bansal authored
Delay getting network service until the browser has completely started on Android. Bug: 898124 Change-Id: I80aed091912579e489263b58d9faf8aad85116dc Reviewed-on: https://chromium-review.googlesource.com/c/1297069 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Robert Kaplow (sloooow) <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#602181}
-
Peter Kotwicz authored
This CL: - Changes NewSplashWebApk.apk to launch the host browser in the same task as the ShellAPK. - Introduces TransparentSplashWebApkActivity. TransparentSplashWebApkActivity is identical to WebApkActivity except that it does not set android:documentLaunchMode. BUG=1253206 Change-Id: I827769b7fd8ccab762863a400873c20d34068300 Reviewed-on: https://chromium-review.googlesource.com/c/1263878 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#602180}
-
Kush Sinha authored
Add class level comments in |SystemWebDialogDelegate| and |InlineLoginHandlerDialogChromeOS| to explain why they are intentionally made movable. Additionally fix an include lint error in inline_login_handler_dialog_chromeos.h. Bug: 833797 Change-Id: I428472f885b204ef73aab06853614febbc1ccadd Reviewed-on: https://chromium-review.googlesource.com/c/1296608 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#602179}
-
Paul Wankadia authored
https://chromium.googlesource.com/external/github.com/google/re2.git/+log/6272edcb53d3..89528a380a7e $ git log 6272edcb5..89528a380 --date=short --no-merges --format='%ad %ae %s' 2018-10-23 junyer Dial down the fanout limits further. Created with: roll-dep src/third_party/re2/src R=mmoroz@chromium.org Bug: 897419 Change-Id: Ie0ebe8437e301b159aa18fd9a6ecd168511a9f8e Reviewed-on: https://chromium-review.googlesource.com/c/1296060Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Max Moroz <mmoroz@chromium.org> Cr-Commit-Position: refs/heads/master@{#602178}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/07055a3ee7ce..49353683320d git log 07055a3ee7ce..49353683320d --date=short --no-merges --format='%ad %ae %s' 2018-10-23 caryclark@skia.org remove vertical text from dox 2018-10-23 bsalomon@google.com GrOp: Only union bounds to head of chain after a merge. 2018-10-23 reed@google.com remove vert methods (no callers) 2018-10-23 caryclark@google.com add back deprecated methods 2018-10-23 halcanary@google.com SkFiddle sees SkFont.h Created with: gclient setdep -r src/third_party/skia@49353683320d The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=brianosman@chromium.org Change-Id: I25a8bde36ac531aa21de1df1b347da1fcd0cb5a7 Reviewed-on: https://chromium-review.googlesource.com/c/1297275Reviewed-by:
-
- 23 Oct, 2018 16 commits
-
-
Carlos Knippschild authored
based on the existing values in PrefetchItemErrorCode (prefetch_types.h). Change-Id: I4fbf832aac68cc80bb3c33ab4135a7e40853ed05 Reviewed-on: https://chromium-review.googlesource.com/c/1297296 Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Dan H <harringtond@google.com> Cr-Commit-Position: refs/heads/master@{#602176}
-
Joel Hockey authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/299607e8f0fa..c270bd3daa83 $ git log 299607e8f..c270bd3da --date=short --no-merges --format='%ad %ae %s' 2018-10-17 allenwebb session_manager: Add IsScreenLocked() dbus method. 2018-10-22 joelhockey system_api: seneschal: New storage_locations in seneschal .proto 2018-10-22 xiaochu system_api: add dlcservice d-bus constants&protobuf 2018-10-19 benchan system_api: shill: remove unused kConfigureWifiServiceFunction constant 2018-10-11 derat power: Delete old SetScreenBrightnessPercent method. Created with: roll-dep src/third_party/cros_system_api Bug: 878324 Change-Id: I95473cc6f9e4a2fa894168c5f6b6c893a745020d Reviewed-on: https://chromium-review.googlesource.com/c/1297210Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#602175}
-
Robert Liao authored
This simplifies lifetime handling for these comboboxes. BUG=897377 Change-Id: I19e8ed25f8e6b17012669ad7e810d33aa28d8ec8 Reviewed-on: https://chromium-review.googlesource.com/c/1295589Reviewed-by:
-
Andrey Kosyakov authored
TBR=dgozman Change-Id: Ie3e8cb8937806d8924699922b026df897401bbf4 Reviewed-on: https://chromium-review.googlesource.com/c/1297569Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#602173}
-
Nate Chapin authored
This reverts commit e7b0e89e. Bug: 655458 Change-Id: I98bf5657a41130098d7ad2f4bf8ad7c239547564 Reviewed-on: https://chromium-review.googlesource.com/c/1297054Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#602172}
-
Scott Violet authored
Which is used in some tests. BUG=889101 TEST=covered by tests Change-Id: I74e191dd1bb7576d382e57b10f119bb4f6d4457b Reviewed-on: https://chromium-review.googlesource.com/c/1297404Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#602171}
-
Tom Anderson authored
This fixes a double-free of SelectFileDialogImplGTK: ~SelectFileDialogImplGTK chrome/browser/ui/libgtkui/select_file_dialog_impl_gtk.cc:90:5 libgtkui::SelectFileDialogImplGTK::~SelectFileDialogImplGTK() chrome/browser/ui/libgtkui/select_file_dialog_impl_gtk.cc:88 DeleteInternal<ui::SelectFileDialog> base/memory/ref_counted.h:414:5 Destruct base/memory/ref_counted.h:369 Release base/memory/ref_counted.h:403 Release base/memory/scoped_refptr.h:284 ~scoped_refptr base/memory/scoped_refptr.h:208 libgtkui::SelectFileDialogImplGTK::OnFileChooserDestroy(_GtkWidget*) chrome/browser/ui/libgtkui/select_file_dialog_impl_gtk.cc:556 ~SelectFileDialogImplGTK chrome/browser/ui/libgtkui/select_file_dialog_impl_gtk.cc:90:5 libgtkui::SelectFileDialogImplGTK::~SelectFileDialogImplGTK() chrome/browser/ui/libgtkui/select_file_dialog_impl_gtk.cc:88 DeleteInternal<ui::SelectFileDialog> base/memory/ref_counted.h:414:5 BUG=897999,880073 R=sky Change-Id: If69e2d857e03e8bca472ebd396e9217af3fc74bb Reviewed-on: https://chromium-review.googlesource.com/c/1297080Reviewed-by:
-
Scott Violet authored
Specifically MouseLatencyBrowserTest.CoalescedMouseWheelsCorrectlyTerminated, which is now passing. PointerEvent was removed a while back, so the DCHECK is no longer hit. I'm not sure why it was being hit before... BUG=884342 TEST=none Change-Id: Ic0089e3b4acac600db0f7723dfdc93d54895b417 Reviewed-on: https://chromium-review.googlesource.com/c/1297572Reviewed-by:
-
Jaeyong Bae authored
This pacth means blink/renderer/platform/graphics/bitmap_image_test.cc loads images from blink/renderer/platform/testing/data. This will more cleanly separate the unit test and layout test data. Bug: 898155 Change-Id: I34f582f127df6fff8634aaff66893fb27abffaaa Reviewed-on: https://chromium-review.googlesource.com/c/1296870Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Jaeyong Bae <jdragon.bae@gmail.com> Cr-Commit-Position: refs/heads/master@{#602168}
-
Martin Kreichgauer authored
In 2c29863d, a change to sign_app.sh.in changed the value of is_development in the false case from "" to "0". Because the script tests with the -z/-n flags of the bash test command, this made is_development effectively always true. Bug: 897973 Change-Id: Ic1181413237a4d0b966d94bbbf5bcc7bdf29450b Reviewed-on: https://chromium-review.googlesource.com/c/1297402Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Commit-Queue: Greg Kerr <kerrnel@chromium.org> Cr-Commit-Position: refs/heads/master@{#602167}
-
Gabriel Charette authored
This is a reland of f7da13a2 (original change in PS1) The original change was missing acquire ordering in DisconnectFromParent(). This is necessary in order for the disconnecting thread to see all memory side-effects previously made by other threads (or some side-effects of message_loop_->ScheduleWork() could racily come in after ~MessageLoop()). Also removed the DCHECK that |operations_state_ == kDisconnectedBit| at the end of DisconnectFromParent() as it was incorrect. A racy BeforeOperation() call can make it 1->3 (and no-op) after DisconnectFromParent() made it 0->1. And lastly, added a scoped allowance to always allow the very fast wait instead of requiring callers to know about this implementation detail of MessageLoop (and reverted changes to //net). Original change's description: > [MessageLoop] Lock-free ScheduleWork() scheme > > The Lock is causing hangs because of priority inversion > mixed with priority boosting (ScheduleWork() tends to > boost the destination thread which may deschedule the > posting thread; if the posting thread is a background > thread this boost-induded-desched-while-holding-lock > can cause a livelock). See https://crbug.com/890978#c10 > for example crashes catching this. > > The Lock was only necessary for startup/shutdown and is > being replaced by a lock-free atomic scheme in this CL. > > MessagePump::ScheduleWork() itself was already thread-safe > (but the Android impl did unnecessarily check a non-atomic bool) > > This adds a WaitableEvent in ~MessageLoop(); hence the requirement > for a wait-allowance in net's EmbeddedTestServer. > > TBR=zhongyi@chromium.org (embedded_test_server.cc side-effects) > > Bug: 890978, 874237 > Change-Id: I0916e5a99035a935b0a23a770af256f334e78c43 > Reviewed-on: https://chromium-review.googlesource.com/c/1278631 > Commit-Queue: Gabriel Charette <gab@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Cr-Commit-Position: refs/heads/master@{#601600} Bug: 890978, 874237, 897925 Change-Id: I17c515f9a3169bbdfc303a4b259f34097e31730d Reviewed-on: https://chromium-review.googlesource.com/c/1297129Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#602166}
-
Xiaohan Wang authored
This partially reverts commit 251e255f. After mojo CDM was enabled by default, with the performance gain, we changed the audio buffer size back to the original value at 200ms, which is the same as the size as clear playback. Recently, we found cases where we still have performance issues for encrypted audio. Given the fact that users are super sensitive to audio glitches, and encrypted playback always has worse performance than clear playback, it makes sense to use a larger buffer size. This CL changes the audio buffer size back to 500ms. It may increase the start-to-play time slightly, but should help reduce rebuffers during playback. Bug: 718161,879970 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I41909d3fc3356df119b21fe720ebe8cafad206a5 Reviewed-on: https://chromium-review.googlesource.com/c/1297329Reviewed-by:
-
Daniel Cheng authored
The supplement is no longer useful; it was previously used as a way to bridge modules and web, but that split no longer exists. Since CheckIfAudioSinkExistsAndIsAuthorized isn't conceptually a 'controller' method, just have HTMLMediaElementAudioOutputDevice call it directly. Change-Id: I90a2450f8d0e984a5f124e5ac27c4dacb249487a Reviewed-on: https://chromium-review.googlesource.com/c/1296824Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#602164}
-
Klaus Weidner authored
This regressed in https://chromium-review.googlesource.com/c/1197225, the frame property updates were happening in the wrong code location. Revert to the original code ordering, and add comments explaining the order dependency. BUG=897525 Change-Id: If88575c15de7ca3b069771362d4388f1a95aca06 Reviewed-on: https://chromium-review.googlesource.com/c/1297473Reviewed-by:
Bill Orr <billorr@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#602163}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/42645509..130258cf Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If09e43487c01819cbed945ab2f9767bce633762d Reviewed-on: https://chromium-review.googlesource.com/c/1297088Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#602162}
-
Xianzhu Wang authored
Now for tests that don't call any dumpAsXXX methods, they by default generate pixel results only, and run_web_tests.py just check their pixel results against the corresponding pixel baselines only. Provide testRunner.dumpAsLayout() and dumpAsLayoutWithPixelResults() for tests that do need to dump the layout tree. We still dump layout tree when running such tests in content_shell --run-web-tests command line (instead of running from run_web_tests.py in protocol mode). Changes to layout tests and their expectations: - Use testRunner.dumpAsLayoutWithPixelResults() or dumpAsLayout() in some tests that still requires the layout dump: - editing/ tests need layout dump to show the caret position. - two printing/ tests need layout dump to show how the bug is fixed. In the future, we may just get rid of layout dumps if it's feasible. - Remove testRunner.dumpAsTextWithPixelResults() from some tests which used the function just to suppress layout output. They didn't actually want text output but we hadn't had a way to dump image only until we had the ImageFirst feature. - Previous platform-specific -expected.txt for tests under previous ImageFirst directories are removed and the common baselines are created because the baselines are no longer platform-specific without the layout dump. Extra -expected.txt baselines are not deleted in this CL. Will follow-up in https://chromium-review.googlesource.com/c/chromium/src/+/1286894. Bug: 703899 Cq-Include-Trybots: luci.chromium.try:linux-blink-gen-property-trees;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ifcf7fea90684e133b4222909ee508469d0c985e0 Reviewed-on: https://chromium-review.googlesource.com/c/1277654 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:Robert Ma <robertma@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#602161}
-
