- 22 Oct, 2018 40 commits
-
-
Bret Sepulveda authored
This patch removes unused code: * Deletes TabRendererData.app, which is never set. * Deletes experimental context menu items CommandSelectByDomain and CommandSelectByOpener, which are unused. * Deletes TabStripModel::WebContentsData.group_, which is unused. * Deletes several private methods of TabStripModel, which were unused as a result of the above changes. This patch also does some associated cleanup to comments and names. Change-Id: I2b43c5e549d240c39a73da60e47f583059e9d3c5 Reviewed-on: https://chromium-review.googlesource.com/c/1285512Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#601671}
-
Jingkui Wang authored
Capture capabilities and events Bug: 895553 Test: build/run events_unittests Change-Id: I9c09a8646017ad36b0f4c61c39f4ad20121b61aa Reviewed-on: https://chromium-review.googlesource.com/c/1290090Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#601670}
-
Shimi Zhang authored
Add basic support for SuggestionSpan.FLAG_AUTO_CORRESION flag, make it show underline for this type. Bug: 869261 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I6db973826ebf761902506905d31968ec4b78819a Reviewed-on: https://chromium-review.googlesource.com/c/1285312 Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#601669}
-
Stephen Martinis authored
My previous CL missed this line. TBR=nednguyen Bug: 896175 Change-Id: I2f37aca90820754caa1b4eb7186b654657d15ac9 Reviewed-on: https://chromium-review.googlesource.com/c/1294206Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#601668}
-
Mike Reed authored
to that skia api Bug: skia:8487 Change-Id: I00bce640b6c34736f0e89988421965ba86464689 Reviewed-on: https://chromium-review.googlesource.com/c/1291816Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Mike Reed <reed@chromium.org> Cr-Commit-Position: refs/heads/master@{#601667}
-
Kevin Marshall authored
Fix Netstack interface churn. The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org TBR=mmenke@chromium.org Change-Id: I0981c684165556a55715a55e9225f04ab0685d78 Reviewed-on: https://chromium-review.googlesource.com/c/1294208 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#601666}
-
Dianna Hu authored
This API is intended to remove discrepancies with Google3, and to comply with Chromium presubmits that suggest to use base::size() instead of arraysize (https://crbug.com/837308). This change borrows gladly from https://crrev.com/c/1288849, which introduced the analogous API for SPDY. This change also fixes some formatting to appease $ git cl lint. I will backport this change to Google3. Bug: 488484 Change-Id: I51be11a2ee62cc084291a4ebf959460d71f17374 Reviewed-on: https://chromium-review.googlesource.com/c/1292434 Commit-Queue: Dianna Hu <diannahu@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#601665}
-
Yi Gu authored
There are more tests failing on chrome_public_test_vr_apk. Add peconn@ to TBR because a similar patch was reviewed by Peter. See crrev.com/c/1292884 TBR=peconn@chromium.org NOTRY=true Bug: 894796 Change-Id: Icb52936f590ec42ccd382d129628e3497ff8cb38 Reviewed-on: https://chromium-review.googlesource.com/c/1294402Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#601664}
-
Geoff Lang authored
The target was validated that it was one of the TextureTarget types but not that the type was valid for the current context. This generated GL errors when querying the size of a 3D texture in an ES2 context. BUG=897453 BUG=892288 Change-Id: Ia6cafaf021751876148acdaf0ee96dc51353e98a Reviewed-on: https://chromium-review.googlesource.com/c/1293754Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#601663}
-
John Z Wu authored
Since there many be multiple objects interested in data changes, it's more natural to use an observer pattern instead. Change-Id: Ib7e291626bf3f3dce23a73ebc329f96bc8f9deb9 Reviewed-on: https://chromium-review.googlesource.com/c/1293990 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#601662}
-
Roger Tawa authored
Improve handling of google account to username mapping, taking into account that the email address of a google account can change. Bug: 894604, 885278 Change-Id: If0013e717819f3edaad0c2e485af9c124b11c787 Reviewed-on: https://chromium-review.googlesource.com/c/1284695 Commit-Queue: Roger Tawa <rogerta@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#601661}
-
Nico Weber authored
After https://chromium-review.googlesource.com/c/1293791, Deterministic Linux should stay green with -pie, and it makes that bot more like its dbg variant (.sos already use position-independent code and ASLR) and like the Windows deterministic bot. Bug: 870584 Change-Id: I730437f3d1160016d3cdf78921990cf2d4b9a40a Reviewed-on: https://chromium-review.googlesource.com/c/1294289Reviewed-by:
Hans Wennborg <hans@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#601660}
-
David Tseng authored
This was re-introduced by https://chromium-review.googlesource.com/c/1208450 was previously fixed by https://chromium-review.googlesource.com/1243283 Originally regressed/caused in https://chromium-review.googlesource.com/1100553 TBR=nektar,dmazzoni Change-Id: I1d698f2c102d6fe8b2cb1c5234ebca0d69455dc9 Reviewed-on: https://chromium-review.googlesource.com/c/1294291Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#601659}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/d7fce6c098ea..6ab9bc6fcb3d git log d7fce6c098ea..6ab9bc6fcb3d --date=short --no-merges --format='%ad %ae %s' 2018-10-22 eakuefner@chromium.org [Dashboard] Rewrite TODOs in add_histograms to mention bugs instead of me Created with: gclient setdep -r src/third_party/catapult@6ab9bc6fcb3d The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ia7c785a350cc50f4d13a48be6b72f20a5a6d7728 Reviewed-on: https://chromium-review.googlesource.com/c/1294211Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601658}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/af3d6cc8910f..8298d25cf3ac git log af3d6cc8910f..8298d25cf3ac --date=short --no-merges --format='%ad %ae %s' 2018-10-22 tsepez@chromium.org Speculative fix for bad FX_Free() under fuzzer. Created with: gclient setdep -r src/third_party/pdfium@8298d25cf3ac The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:897585 TBR=dsinclair@chromium.org Change-Id: Ibc89b68fa8df0a1ea3c93b90268bc1f11d89eecd Reviewed-on: https://chromium-review.googlesource.com/c/1294215Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601657}
-
Liquan(Max) Gu authored
Currently DidChangePerformanceTiming will be invoked twice if both largest- and last-image candidate are detected. This Cl removes one invocation by using a bool. Bug: 869924 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I8342b268d67b4371522370fc2fc45fc8021a6ed9 Reviewed-on: https://chromium-review.googlesource.com/c/1293762 Commit-Queue: Liquan (Max) Gǔ <maxlg@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#601656}
-
chrome://process-internalsAlex Moshchuk authored
chrome://process-internals calculates and displays each process's locked state by checking lock_url(). That won't give the correct result, since lock_url() is computed before we lock the process, and having it doesn't imply that the process will actually be locked in the future. Fix this to check the process's lock in ChildProcessSecurityPolicy, which should always given the correct result. Bug: 850087 Change-Id: Ibf5e37fc69919e6c1e6a7e67943942cf6c93242d Reviewed-on: https://chromium-review.googlesource.com/c/1287953Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#601655}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/7818a85c33d3..f38cb6d39af1 git log 7818a85c33d3..f38cb6d39af1 --date=short --no-merges --format='%ad %ae %s' 2018-10-22 jmadill@chromium.org StateManagerGL: Optimize state application. Created with: gclient setdep -r src/third_party/angle@f38cb6d39af1 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: I87a86fe35ba03fa53e2249fb44e1c34b22454a50 Reviewed-on: https://chromium-review.googlesource.com/c/1294210Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601654}
-
Wez authored
- Adds keyword-suggestions fields to omnibox_event.proto. - Renames is_asan_build to is_instrumented_build. Bug: 889105, 837395 Change-Id: Ic3264ff6052af46770ce63df2d7a189c5643ace3 Reviewed-on: https://chromium-review.googlesource.com/c/1292849Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Kevin Bailey <krb@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#601653}
-
Miguel Casas authored
Canvas.getContext() method is idempotent, i.e. successive calls return the same context over and over. When the context is lowLatency, however, we think it's an OffscreenCanvas context and fail. This CL fixes that and adds a LayoutTest to verify the new functionality. Bug: 895551 Change-Id: I1ae140080915a277eb45ac01486e6c7c1464aefa Reviewed-on: https://chromium-review.googlesource.com/c/1294090Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#601652}
-
Oksana Zhuravlova authored
Change-Id: I213af3504a7383f1c0130b1345b436216010c204 Reviewed-on: https://chromium-review.googlesource.com/c/1286637Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#601651}
-
Takuto Ikuta authored
This CL is part of https://chromium-review.googlesource.com/c/chromium/src/+/1286017 This CL was uploaded by git cl split. R=aleventhal@chromium.org Bug: 681136 Change-Id: I7961ce74b47e41b4818e4fed007df38e1060539d Reviewed-on: https://chromium-review.googlesource.com/c/1288338 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#601650}
-
Scott Violet authored
It's flaky. BUG=897801 TEST=test only change TBR=thestig@chromium.org Change-Id: Ieba62e4047a3fc240ac6b09b6e526ff87a0e29d3 Reviewed-on: https://chromium-review.googlesource.com/c/1294197Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#601649}
-
Fredrik Söderquist authored
Based on [1], it would seem that we should treat the case where we have no image candidate as representing nothing - this apparently also matches what other UAs do. Simplify the NoImageSourceSpecified helper function a bit. (IsNull implies IsEmpty and !hasAttribute.) [1] https://html.spec.whatwg.org/multipage/embedded-content.html#the-img-element:the-img-element-5 Bug: 897033 Change-Id: I37ecad8faea2b929e8cf35ce7c746313b2d3b915 Reviewed-on: https://chromium-review.googlesource.com/c/1293574Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#601648}
-
Nate Fischer authored
No change to production logic. This enables 2 tests which were previously disabled due to flakiness. The flakiness was fixed in http://crrev/c/1286031, and these appear safe to enable: * testFullscreenForNonVideoElementIsSupportedInSoftwareMode * testPowerSaveBlockerIsTransferredToFullscreen This also cleans up annotations on other disabled tests. It's sufficient to mark disabled tests as "@DisabledTest" without commenting out other annotations. It's helpful to actually leave these annotations uncommented, because it makes enabling the test a one-line change. Bug: 789306 Test: run_webview_instrumentation_test_apk \ Test: --gtest_filter=AwContentsClientFullScreenTest#* \ Test: --repeat=1000 Change-Id: I497718177d086c46e1553e1f365b23b27de760e4 Reviewed-on: https://chromium-review.googlesource.com/c/1290142Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#601647}
-
Shuhei Takahashi authored
BUG=chromium:894375 TEST=None Change-Id: I905b4dd02a40e515fdd7f47f3b3efb845953841e Reviewed-on: https://chromium-review.googlesource.com/c/1292650Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Shuhei Takahashi <nya@chromium.org> Cr-Commit-Position: refs/heads/master@{#601646}
-
Wez authored
This test often flakes on its first run in a batch, with each call expectation satisfied more than once. Bug: 897550, 879806 Change-Id: I2b7b130e5fd2fc8abf6aa15fbfd417041da0420f Reviewed-on: https://chromium-review.googlesource.com/c/1293178Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#601645}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. Remove the RecentModelFactory::SetForProfileAndUseForTest method as it pass a std::unique_ptr<> object to return from the factory which is difficult to adapt to the new API that requires a base::RepeatingCallback<>. Instead inline the implementation in the sole unit test that called this method and modify it to pass a factory returning a std::vector<std::unique_ptr<RecentModel>>. This converts uses in src//chrome/browser/chromeos/fileapi. This CL was uploaded by git cl split. R=slangley@chromium.org Bug: 809610 Change-Id: Idb8bae335e3defca5b2c6736d302586faf97d929 Reviewed-on: https://chromium-review.googlesource.com/c/1259014Reviewed-by:
Stuart Langley <slangley@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#601644}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/browsing_data. This CL was uploaded by git cl split. R=markusheintz@chromium.org Bug: 809610 Change-Id: Ie7a9a867b2214dd56e7c54fcf8328dc02cc0b4ea Reviewed-on: https://chromium-review.googlesource.com/c/1258361 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#601643}
-
Robert Ogden authored
Allows us to add an arm to the Holdback experiment where secure proxies are disabled for DRP. Bug: 768597 Change-Id: I66ecfa86f985de262e8f260a5a2d47c863beb0f8 Reviewed-on: https://chromium-review.googlesource.com/c/1292598 Commit-Queue: Robert Ogden <robertogden@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#601642}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/333c890004ba..a7f9ec980c66 Created with: gclient setdep -r src-internal@a7f9ec980c66 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ic5f468853e561485f1bb843738651b7e61b286b4 Reviewed-on: https://chromium-review.googlesource.com/c/1293716Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601641}
-
Wez authored
This test leaks process-global state, causing potentially causing later tests (e.g. WebGPUInProcessCommandBufferTest.Dummy) run in the same batch process to unexpectedly fail. Bug: 897456, 879806 Change-Id: Ied7facc983f7f62e6954e3d3ad28572010b09ae5 Reviewed-on: https://chromium-review.googlesource.com/c/1293030Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#601640}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e696a0e1..7bc77bb4 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1260f6aaa37641e63b44b56fcaea3f3b92864707 Reviewed-on: https://chromium-review.googlesource.com/c/1294009Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601639}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//extensions/browser/api/display_source. This CL was uploaded by git cl split. R=alexander.shalamov@intel.com Bug: 809610 Change-Id: I0296a88846eed33c92d7baa74217e845218f3bf5 Reviewed-on: https://chromium-review.googlesource.com/c/1257937Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#601638}
-
Theresa authored
BUG=897592,814528 Change-Id: I2c9adf2ff533446c10be19d12ec3c83a8b1e0323 Reviewed-on: https://chromium-review.googlesource.com/c/1294131Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#601637}
-
Reza.Zakerinasab authored
Bug: 897190 Change-Id: I1c2d24bc3db26d5c27a582a6fd5049a16cabd927 Reviewed-on: https://chromium-review.googlesource.com/c/1291769Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Cr-Commit-Position: refs/heads/master@{#601636}
-
Sylvain Defresne authored
TestingFactoryFunction is a simple function pointer. It is deprecated in favor of TestingFactory which is a Callback<>. Convert indirect uses by using base::BindRepeating() in all invocation of SetTestingFactory/AddTestingFactory. This converts uses in src//chrome/browser/themes. This CL was uploaded by git cl split. R=pkotwicz@chromium.org Bug: 809610 Change-Id: I66ee3e218e4333f6d704e64b58003f100f1364e9 Reviewed-on: https://chromium-review.googlesource.com/c/1258352Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#601635}
-
Theresa authored
There's a bunch of custom measure, draw and tint code that appears to be no longer needed. I suspect it was left over from our non-Modern design and from when Android support library didn't have tinting support built in. Also remove unused btn_new_tab_white* assets. BUG=897345 Change-Id: Ie3b67573371b58ecbef9f9f47518f704435e4180 Reviewed-on: https://chromium-review.googlesource.com/c/1292553 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#601634}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ff292f30d9a4..67b011d22c1b git log ff292f30d9a4..67b011d22c1b --date=short --no-merges --format='%ad %ae %s' 2018-10-22 nisse@webrtc.org Use BitrateAllocatorInterface in AudioSendStream and VideoSendStream Created with: gclient setdep -r src/third_party/webrtc@67b011d22c1b The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I4a7455ec6ae0cd3250334288640c3ecb62b89d02 Reviewed-on: https://chromium-review.googlesource.com/c/1293710Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#601633}
-
Daniel Cheng authored
Change-Id: Ib31144ffc4d0e18e9d583ee6fbdea2551ebf5b6a Reviewed-on: https://chromium-review.googlesource.com/c/1294195 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Ben Wagner <bungeman@chromium.org> Reviewed-by:
Ben Wagner <bungeman@chromium.org> Cr-Commit-Position: refs/heads/master@{#601632}
-