GitLab

BUG=234947
TBR=yoz@chromium.org

Review URL: https://codereview.chromium.org/14990002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198873 0039d316-1c4b-4281-b951-d872f2087c98

Changes:
- If the table is hidden, don;'t update the column widthes.
- Updates the table after normalizing the column.
- Redraw the volume list when back from the image viewer.

This patch fixes both the volume-list issue (http://crbug.com/237921) and the file-list issue (http://crbug.com/237921#c2).

BUG=237921
TEST=manual
R=mtomasz@chromium.org

Review URL: https://codereview.chromium.org/15029002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198872 0039d316-1c4b-4281-b951-d872f2087c98

This is an attempt to reland https://codereview.chromium.org/14780003/ which was reverted as https://codereview.chromium.org/15045002/.
Patch set 1 here is identical with p.s. 7 in https://codereview.chromium.org/14780003/. The failing buildbot was linux compile (dbg), so trying it here explicitly.

Original description:

The main one is coputing the Aho-Corasick tree size in advance.

Also contained are code clean-ups and minor optimisations, like removing HasEdge/GetEdge sequences, or adding const to aid compiler optimisations.

This was tested on a benchmark adding 20k+ patterns. It showed a reduction of the running time by 30%.

BUG=236368
TBR=battre

Review URL: https://codereview.chromium.org/15059003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198871 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
R=joi@chromium.org

Review URL: https://codereview.chromium.org/14746010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198870 0039d316-1c4b-4281-b951-d872f2087c98

Reason: Compile failure on Android.

> Gets the initial sync service status. In the next patch I'll make the syncfs-internals dashboard a sync_event_observer so it can also report changes in real time (as they come by notification).
> 
> BUG=226353
> TEST=open chrome://syncfs-internals. Service status should be running if signed in. Should be authentication_required if not signed in and any SyncFS app is run (i.e. calls requestFileSystem at least once).
> 
> Please not that the page has to be refreshed manually to get updated values for now.
> 
> R=arv@chromium.org, kinuko@chromium.org, tzik@chromium.org
> 
> Review URL: https://codereview.chromium.org/14765003

TBR=calvinlo@chromium.org

Review URL: https://codereview.chromium.org/14753008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198869 0039d316-1c4b-4281-b951-d872f2087c98

This CL demonstrates a browser_test runnning without Gmock for DBusThreadManager.

BUG=234084
TEST=trybots
R=nona@chromium.org

Review URL: https://codereview.chromium.org/14358034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198868 0039d316-1c4b-4281-b951-d872f2087c98

Gets the initial sync service status. In the next patch I'll make the syncfs-internals dashboard a sync_event_observer so it can also report changes in real time (as they come by notification).

BUG=226353
TEST=open chrome://syncfs-internals. Service status should be running if signed in. Should be authentication_required if not signed in and any SyncFS app is run (i.e. calls requestFileSystem at least once).

Please not that the page has to be refreshed manually to get updated values for now.

R=arv@chromium.org, kinuko@chromium.org, tzik@chromium.org

Review URL: https://codereview.chromium.org/14765003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198867 0039d316-1c4b-4281-b951-d872f2087c98

OneClickSigninSyncStarter now displays the post-signin confirmation bubble so
we can better integrate this with the rest of the signin UI (creating a new
profile, displaying the SAML dialog, etc).

BUG=174655,232339,236828,238173
R=rogerta@chromium.org

Review URL: https://codereview.chromium.org/14914003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198866 0039d316-1c4b-4281-b951-d872f2087c98

Chrome for Android doesn't use zoom controls, so it makes sense
to move all the related code into android_webview.

However, as visibility of zoom controls is controlled from the
internals of ContentView*, we are providing hooks through a new
delegate interface.

BUG=b/8296421
R=benm@chromium.org, joth@chromium.org

Review URL: https://codereview.chromium.org/14840011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198862 0039d316-1c4b-4281-b951-d872f2087c98

100 turned out to be too small for investigating an obscure issue like
crbug.com/237044.

BUG=238946
TEST=none
R=hidehiko@chromium.org

Review URL: https://codereview.chromium.org/14660018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198861 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198860 0039d316-1c4b-4281-b951-d872f2087c98

BUG=224487
TBR=dbeam

Review URL: https://codereview.chromium.org/15059002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198859 0039d316-1c4b-4281-b951-d872f2087c98

DriveFileSpecificInfo::is_hosted_document can replace DriveFileType.

BUG=None
TEST=build
R=estade@chromium.org, hidehiko@chromium.org, mpcomplete@chromium.org

Review URL: https://codereview.chromium.org/14884015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198858 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198857 0039d316-1c4b-4281-b951-d872f2087c98

BUG=224487
R=mmoss@google.com

Review URL: https://codereview.chromium.org/15030002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198856 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198852 0039d316-1c4b-4281-b951-d872f2087c98

BUG=238964
TBR=groby@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/14895011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198851 0039d316-1c4b-4281-b951-d872f2087c98

Broke both windows clobber and official builders' compile with this error:

771>Link:
771>     Creating library ..\..\..\build\Release\lib\gcp_portmon64.lib and
object ..\..\..\build\Release\lib\gcp_portmon64.exp
771>base.lib(path_service.obj) : fatalerror LNK1112: module machine type 'X86'
conflicts with target machine type 'x64'
771>
771>Build FAILED.

> Move FileEnumerator to its own file, do some refactoring.
> 
> It creates a class FileInfo to contain the details rather than using a platform-specific typedef. This allows the accessors GetName, GetSize, etc. to be moved directly to this class (previously they were static helpers on the FileEnumerator class) which makes a bunch of code much cleaner. It also gives reasonable getting and initialization which the previous version lacked.
> 
> BUG=175002
> R=rvargas@chromium.org
> 
> Review URL: https://codereview.chromium.org/13165005

TBR=brettw@chromium.org

Review URL: https://codereview.chromium.org/14824006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198850 0039d316-1c4b-4281-b951-d872f2087c98

Reverting revisions that rely on r198820 so to unbreak the build.

> Export FileInfo

TBR=brettw@chromium.org

Review URL: https://codereview.chromium.org/14824005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198849 0039d316-1c4b-4281-b951-d872f2087c98

Reverting revisions that rely on r198820 so to unbreak the build.

> Move sequenced_task_runner to base/task
> 
> BUG=
> R=akalin@chromium.org
> 
> Review URL: https://codereview.chromium.org/14927008

TBR=brettw@chromium.org

Review URL: https://codereview.chromium.org/14985007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198848 0039d316-1c4b-4281-b951-d872f2087c98

These script names were extracted from data/lang/en.txt in ICU.

BUG=
TBR=mpcomplete@chromium.org

Review URL: https://codereview.chromium.org/14660004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198845 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
R=akalin@chromium.org

Review URL: https://codereview.chromium.org/14927008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198844 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198842 0039d316-1c4b-4281-b951-d872f2087c98

R=simonjam@chromium.org

Review URL: https://codereview.chromium.org/15019009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198839 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jochen@chromium.org
BUG=238737

Review URL: https://codereview.chromium.org/14892006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198838 0039d316-1c4b-4281-b951-d872f2087c98

> Add chrome_split_dll gyp variable, and duplicate chrome_main_dll target
> 
> Currently contains chrome_browser_dll target. Removes some paths from browser->webcore
> via content that are there due to single process mode, and removes dependency of content
> on content_renderer.
> 
> Current remaining paths from chrome_browser_dll to webcore: http://i.imgur.com/7WWRvpA.jpg
> 
> R=cpu@chromium.org
> BUG=237249
> 
> Review URL: https://chromiumcodereview.appspot.com/14682014

TBR=scottmg@chromium.org

Review URL: https://codereview.chromium.org/14882004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198837 0039d316-1c4b-4281-b951-d872f2087c98

Currently contains chrome_browser_dll target. Removes some paths from browser->webcore
via content that are there due to single process mode, and removes dependency of content
on content_renderer.

Current remaining paths from chrome_browser_dll to webcore: http://i.imgur.com/7WWRvpA.jpg

R=cpu@chromium.org
BUG=237249

Review URL: https://chromiumcodereview.appspot.com/14682014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198834 0039d316-1c4b-4281-b951-d872f2087c98

This is a bit tricky scenario, but the current code may lead to
a mismatch of increment/decrement by calling Close(). See the bug
for how the mismatch happens.

BUG=238477

Review URL: https://chromiumcodereview.appspot.com/14820016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198829 0039d316-1c4b-4281-b951-d872f2087c98

* Remove duplicated comments.
* Rename main .cc/.c file to the name of the example.
* Remove _module.cc files

BUG=none
R=noelallen@chromium.org

Review URL: https://codereview.chromium.org/14607005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198828 0039d316-1c4b-4281-b951-d872f2087c98

BUG=237354

Review URL: https://chromiumcodereview.appspot.com/14670013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198827 0039d316-1c4b-4281-b951-d872f2087c98

This moves a clear per picture into a clear-to-background color
per picture pile. We need this to ensure that a solid color
page in low res is considered solid, since all the draws are
of the same color.

BUG=233622

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198272
"

TBR=reveman

Review URL: https://chromiumcodereview.appspot.com/14322017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198826 0039d316-1c4b-4281-b951-d872f2087c98

Updates an existing suppression (filed for bug 222876) to reflect
new function signature. (Part of PKS using BrowserContext now)

NOTRY=true
TBR=thestig@chromium.org,phajdan@chromium.org
BUG=222876

Review URL: https://chromiumcodereview.appspot.com/14823006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198825 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198824 0039d316-1c4b-4281-b951-d872f2087c98

The current code seems to generate '/\foo' for a given path '\foo'

BUG=238212
TEST=FileSystemUtilTest.GetNormalizedFilePath
TBR=grv@chromium.org

Review URL: https://codereview.chromium.org/14588006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198822 0039d316-1c4b-4281-b951-d872f2087c98

R=samarth@chromium.org
TBR=samarth@chromium.org
BUG=238863

Review URL: https://codereview.chromium.org/14819011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198821 0039d316-1c4b-4281-b951-d872f2087c98

It creates a class FileInfo to contain the details rather than using a platform-specific typedef. This allows the accessors GetName, GetSize, etc. to be moved directly to this class (previously they were static helpers on the FileEnumerator class) which makes a bunch of code much cleaner. It also gives reasonable getting and initialization which the previous version lacked.

BUG=175002
R=rvargas@chromium.org

Review URL: https://codereview.chromium.org/13165005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198820 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198819 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=tree

Review URL: https://codereview.chromium.org/14722016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198818 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jamesr, piman
BUG=179896

Review URL: https://codereview.chromium.org/15043004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198817 0039d316-1c4b-4281-b951-d872f2087c98

The documentation was out of date, as there is now no way to have default
versus specific bounds. Instead all supplied bounds are default. 

BUG=230606

Review URL: https://chromiumcodereview.appspot.com/14037005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198815 0039d316-1c4b-4281-b951-d872f2087c98