Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 14 May, 2018 9 commits
    • Timothy Loh's avatar
      Remove pinned Crostini apps on uninstall · 7c6293de
      Timothy Loh authored 
      This CL adds a LauncherCrostiniAppUpdater that ensures the Shelf knows
about app uninstallation so it can remove pinned Crostini apps.

TEST=Manually uninstalled an app and saw the pin disappear. Manually
uninstalled Crostini and saw pins disappear.

Bug: 839699
Change-Id: I81e6b60414ad8766ef159a9ea3969809beb5112c
Reviewed-on: https://chromium-review.googlesource.com/1046605Reviewed-by: default avatarStefan Kuhne <skuhne@chromium.org>
Commit-Queue: Timothy Loh <timloh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558175}
      7c6293de
    • Sergei Datsenko's avatar
      cros-disks: Don't set "default" mount options. · 1fadef3c
      Sergei Datsenko authored 
      Default parameters are determined by the CrosDisks, it's not up to
the client to decide which ones are the "default" so it ignores those
anyway.

BUG=chromium:831491

Change-Id: Ibb8cc66b318282b15bfcb361a6428e37028dcf37
Reviewed-on: https://chromium-review.googlesource.com/1053343
Commit-Queue: Sergei Datsenko <dats@chromium.org>
Reviewed-by: default avatarXiyuan Xia <xiyuan@chromium.org>
Reviewed-by: default avatarSam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558174}
      1fadef3c
    • Bence Béky's avatar
      Clean up some HTTP/2 push related SpdyNetworkTransactionTests. · e7023f8c
      Bence Béky authored 
      Remove SpdyNetworkTransactionTest.ServerPushBeforeHeaders, because this
case is covered by SpdyNetworkTransactionPushTest.*/0.

Remove SpdyNetworkTransactionTest.ServerPushInvalidCrossOrigin, because
this case is covered by
SpdyNetworkTransactionTest.ServerPushCrossOriginCorrectness.

Change ServerPushCrossOriginCorrectness into a parametrized subclass,
just like SpdyNetworkTransactionPushTest.  For clarity, rename
SpdyNetworkTransactionPushTest to SpdyNetworkTransactionPushHeaderTest,
ServerPushCrossOriginCorrectness to SpdyNetworkTransactionPushUrlTest,
and use PushHeaderTestParams and PushHeaderUrlParams as test data struct
name, respectively.

This will make it much easier to add tests for an upcoming histogram.

Bug: 831536
Change-Id: I298fbd9a2dd4b6567b8cb597fcb704b956819218
Reviewed-on: https://chromium-review.googlesource.com/1055751
Commit-Queue: Bence Béky <bnc@chromium.org>
Reviewed-by: default avatarRyan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558173}
      e7023f8c
    • chaopeng's avatar
      Only handle mouse left button for Scrollbar · 11b79e0f
      chaopeng authored 
      This issue is caused by:

1. Press on any mouse button will update the last_scrollbar_under_mouse_ in
   EventHandler. last_scrollbar_under_mouse_ will set to null and call
   Scrollbar::MouseExited() when mouse middle click out of scrollbar.
2. Release any mouse button will check last_scrollbar_under_mouse_ for cleanup
   the mouse press state on Scrollbar.

Because mouse middle button press happens before any mouse button release,
last_scrollbar_under_mouse_ is null then release mouse button will not clear
the scrollbar press state.

There is another related issue here. We can drag the scrollbar by pressing the
middle button.

The root cause of the bug is not checking for the left mouse button before
updating last_scrollbar_under_mouse_ and calling Scrollbar::MouseDown.

In this patch, we only handle mouse left button for Scrollbar.

Bug: 721303
Change-Id: I714eca2bbdd9dd1628e596dc6b9119bb5de85cc3
Reviewed-on: https://chromium-review.googlesource.com/1048389
Commit-Queue: Jianpeng Chao <chaopeng@chromium.org>
Reviewed-by: default avatarAvi Drissman <avi@chromium.org>
Reviewed-by: default avatarDavid Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558172}
      11b79e0f
    • Wez's avatar
      Do not tolerate null TaskRunner in IndexedDBBackingStore. · c655bcf2
      Wez authored 
      Allowances were added in thread checks, but these are no longer
required since the fake for this class now grabs the calling-thread's
TaskRunner.

Bug: 838386
Change-Id: I27bc5bc192067ac5fc6c1636108dad30e92190f0
Reviewed-on: https://chromium-review.googlesource.com/1056252
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: default avatarDaniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558171}
      c655bcf2
    • Owen Rodley's avatar
      Remove circular includes in arch_dependent_sizes_* · 369074b5
      Owen Rodley authored 
      The include flow is:

test_struct_sizes.c
arch_dependent_sizes_(32|64).h
test_struct_sizes.c again
arch_dependent_sizes_(32|64).h again

then we hit the include guard as we've included the header twice

test_struct_sizes.c is the only file that includes either of these
headers, so the #include of test_struct_sizes.c is redundant.

Change-Id: I95a4efe45a46dfe26b9b0e60b15af702d5546717
Reviewed-on: https://chromium-review.googlesource.com/1055009Reviewed-by: default avatarRaymes Khoury <raymes@chromium.org>
Commit-Queue: Owen Rodley <orodley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558170}
      369074b5
    • Sam McNally's avatar
      Add a MOUNT_TYPE_NETWORK_SOURCE to match MOUNT_SOURCE_NETWORK_SOURCE. · 785315a0
      Sam McNally authored 
      The cros-disks equivalent for MountType (MountSourceType) has a third
option (MOUNT_SOURCE_NETWORK_STORAGE) without a matching enumerator in
MountType; this value is now used for generic fuse mounts. VolumeManager
falls-through switches due to the unexpected value.

Add MOUNT_TYPE_NETWORK_SOURCE on the chrome side to avoid this problem.
Since this is currently a catch-all value for all generic fuse mount
types, VolumeManager isn't capable of handling their mounts reasonably.
Instead, ignore mount events with type MOUNT_TYPE_NETWORK_SOURCE in
VolumeManager; the mounters will handle their mount events individually.

Bug: 829274,832507
Change-Id: I18dc0b5b68120c94da2ebbe05ee863a6f471b81c
Reviewed-on: https://chromium-review.googlesource.com/1053621Reviewed-by: default avatarXiyuan Xia <xiyuan@chromium.org>
Reviewed-by: default avatarJoel Hockey <joelhockey@chromium.org>
Commit-Queue: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558169}
      785315a0
    • Noel Gordon's avatar
      Re-enable OpenAudioFiles/FileManagerBrowserTest · 738768f5
      Noel Gordon authored 
      Enabled in RELEASE, now re-enable this test in DEBUG/MSAN/ASAN.

Bug: 836254
Change-Id: Ie6ca28f923dcf70be407c8782985195874f47758
Reviewed-on: https://chromium-review.googlesource.com/1056748Reviewed-by: default avatarStuart Langley <slangley@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558168}
      738768f5
    • Noel Gordon's avatar
      Integration tests transfer.js: Remove TODO · 330d58ab
      Noel Gordon authored 
      Remove TODOs (found a better way to address this in future changes).

Comment only change.

No-Try: true
Bug: 836254
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ibfb73d564964afbaca95ac4b1125a084a7939691
Reviewed-on: https://chromium-review.googlesource.com/1056767Reviewed-by: default avatarStuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558167}
      330d58ab
  3. 13 May, 2018 20 commits
  5. 12 May, 2018 11 commits