- 22 Dec, 2017 40 commits
-
-
Robert Ma authored
And fix a typo in a test along the way. Bug: 732003, 796617 Change-Id: I9df6fb630139e1a2534c174c20804111a9189a31 Reviewed-on: https://chromium-review.googlesource.com/841264Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#525996}
-
Parastoo Geranmayeh authored
Right now, if we sign in and click on a previously added address and then click back instantly, we may have a crash. The crash could be for two reasons: 1. An async task (subkey request) is calling the EditorDialog.show(), while the activity is finishing. 2. The EditorDialog.onShow() is called, while the dialog is already dismissed. This fix, checks for these conditions before continuing. Bug: 786962, 794892 Change-Id: I973860fece013c33759c95e178a667d63020ae68 Reviewed-on: https://chromium-review.googlesource.com/841263Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Parastoo Geranmayeh <parastoog@google.com> Cr-Commit-Position: refs/heads/master@{#525995}
-
sebsg authored
Bug: 755727 Change-Id: I09f72dd24f24b2ce7362912ac43c198b7207dcf9 Reviewed-on: https://chromium-review.googlesource.com/841285Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Commit-Queue: Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#525994}
-
Elodie Banel authored
The isTrusted attribute indicates that the change came from the user. Use it to make sure we don't unset the autofill attributes when sending our own "input" event. Bug: 796224 Change-Id: I7502274ba3dbe7d323382af3d884ded005f79bf0 Reviewed-on: https://chromium-review.googlesource.com/840005Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Elodie Banel <lod@chromium.org> Cr-Commit-Position: refs/heads/master@{#525993}
-
Sheng-Hao Tsao authored
This CL adds 2 new MediaRecorder histograms, one for the errors HW encode encounters and one for whether HW encode is used. ChromeOS autotest (crrev.com/c/813974 and crrev.com/c/831318) will use them to determine if tests pass. BUG=616659 TEST=Verified with autotests that the histograms appear. Change-Id: Id7533e1df7d2105490085eadda061a117b466d59 Reviewed-on: https://chromium-review.googlesource.com/831773 Commit-Queue: Sheng-hao Tsao <shenghao@google.com> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#525992}
-
sebsg authored
Bug: 755727 Change-Id: I030c331a0ddff7353adaa70fb6c6f9d2bd0aaf8b Reviewed-on: https://chromium-review.googlesource.com/841268Reviewed-by:
-
Shivani Sharma authored
Introduces a new enterprise policy AdsSettingForIntrusiveAdsSites that maps to the content setting for Ads. The policy value is reflected in the content settings UI and the content settings Ads UI is not editable by the user. The setting can be changed without without restarting the browser and its new value will be reflected in the content settings UI and will take effect in any subsequently opened tab. DrivenByEnterprisePolicy TEST: browser_tests --gtest_filter=SubresourceFilterSettingsBrowserTest. Bug: 778373 Change-Id: I04e8b6ebf93193c66980e483e785a11dac94831f Reviewed-on: https://chromium-review.googlesource.com/737865 Commit-Queue: Shivani Sharma <shivanisha@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#525990}
-
Randy Smith authored
This CL includes the shift of one unit test over to CookieManager as well. The other can't be changed yet, because it targets the extensions URLRequestContext, which doesn't have a NetworkContext wrapper yet. Bug: 721395 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I87590f3d3fa8d98fdb90935ac5e9b1540e4d4359 Reviewed-on: https://chromium-review.googlesource.com/776017 Commit-Queue: Randy Smith <rdsmith@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#525989}
-
Michael Lippautz authored
Bug: chromium:757440 Change-Id: Ib3fc1e102c0e96b3c48c950ca9a439ffcc35edf3 Reviewed-on: https://chromium-review.googlesource.com/839740 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#525988}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/5c68dce7750a..8bc327bffb7a $ git log 5c68dce77..8bc327bff --date=short --no-merges --format='%ad %ae %s' 2017-12-21 rmistry Update isolate binaries and update isolate recipe Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=csmartdalton@chromium.org Change-Id: I19c5f4c7bd8b405091736807577a8708227afd56 Reviewed-on: https://chromium-review.googlesource.com/843042Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#525987}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/efc4a0847629..5626f3590eea $ git log efc4a0847..5626f3590 --date=short --no-merges --format='%ad %ae %s' 2017-12-20 perezju [Telemetry] Cleanup android_browser_backend._GetDevToolsClientConfig Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Idce107de7fcf93d16403386a6ce5b0fa09b22863 Reviewed-on: https://chromium-review.googlesource.com/843003 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#525986}
-
Michael Lippautz authored
Bug: chromium:757440 Change-Id: I422c7675097209596b99d5ede7e6980b7a431323 Reviewed-on: https://chromium-review.googlesource.com/833935 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
webrtc-autoroll@chromium.org authored
https://webrtc.googlesource.com/src.git/+log/fd7df98826e2..1e53f8ad040a $ git log fd7df9882..1e53f8ad0 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtcBUG=None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I0575febf57729c7f91a2c5e04ae61775e99d6c3f Reviewed-on: https://chromium-review.googlesource.com/843002 Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org> Reviewed-by:
WebRTC Roll Bot <webrtc-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#525984}
-
Olivier Robin authored
FindChildText, FindChildTextWithIgnoreList, InferLabelFromDivTableTest sometimes have behavior that don't match the documentation. Add some tests to capture these scenarios so they can be fixed in a future CL. Bug: 796918 Change-Id: I02ecb156149c8bd82470beaeff5ae2075710e380 Reviewed-on: https://chromium-review.googlesource.com/840020 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Gustav Sennton authored
Fix MinidumpUploaderImplTest#testCancelFailedUploadCausesReschedule by waiting for the minidump uploads worker thread to finish before ending the testCancelFailedUploadCausesReschedule test. BUG=786310 Change-Id: I2cd1cde84faf2f44bd69018ed17bbecaa09d6fb8 Reviewed-on: https://chromium-review.googlesource.com/840682Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Gustav Sennton <gsennton@chromium.org> Cr-Commit-Position: refs/heads/master@{#525982}
-
Sergey Poromov authored
Chrome OS should report to the server ID of the launched kiosk app for ARC Kiosk sessions, so it will be able to find out which app is active. In order to do it, it will populate AppStatus.app_id with package name of the Android app for both: - SessionStatusReportRequest.installed_apps - DeviceStatusReportRequest.running_kiosk_apps Note: previously it was populated with empty AppStatus. BUG=b/62446184 TEST=Add browser tests, run trybots. Change-Id: Ied7759cee40c75082814b0ddac40aaff81f1a538 Reviewed-on: https://chromium-review.googlesource.com/840743Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#525981}
-
Michael Lippautz authored
No-try: true Bug: chromium:757440 Change-Id: I9d1935b8aaa08313e2fd87bc88b4bff4b9051db7 Reviewed-on: https://chromium-review.googlesource.com/840242 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Ned Nguyen authored
NOTRY=true TBR=hablich@chromium.org Bug: 784025 Change-Id: Ia5e151c334493d5286fa0c3982e2c93d72c65da0 Reviewed-on: https://chromium-review.googlesource.com/842303Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#525979}
-
Michael Lippautz authored
The incremental marking write barrier depends on the fact the only non-heap objects are eagerly traced and the others are put on the marking stack. Harden these assumptions through tests. No-try: true Bug: chromium:757440 Change-Id: Iad7e9f46b3a9826d6eb90ae57f039613f4aa5ae8 Reviewed-on: https://chromium-review.googlesource.com/839777 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
webrtc-autoroll@chromium.org authored
https://webrtc.googlesource.com/src.git/+log/c0ed4db0ba63..fd7df98826e2 $ git log c0ed4db0b..fd7df9882 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I08d9853f454f0d6b84cb81bf4876d99cc1a3437e Reviewed-on: https://chromium-review.googlesource.com/842902Reviewed-by:
-
Hiroki Nakagawa authored
This CL moves a part of files in modules/fetch to core/fetch. Fetch is a primitive mechanism and should be available in core/. See the issue for a use case. Bug: 794837 Change-Id: I1b08dbbaf50513760b698d4542e774c0e906134b Reviewed-on: https://chromium-review.googlesource.com/841903 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#525976}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/cd1fd5940f68..efc4a0847629 $ git log cd1fd5940..efc4a0847 --date=short --no-merges --format='%ad %ae %s' 2017-12-20 perezju [Telemetry] Cleanup desktop_browser_backend._GetDevToolsClientConfig Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I95f2b9c57e17fb5aac5b0b281a062225e501df78 Reviewed-on: https://chromium-review.googlesource.com/842842 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#525975}
-
Michael Lippautz authored
The optimization in faf0c664 was unsound for containers as they can construct elements in place, even after the containing object was already marked black. This patch keeps the ability of doing initializing stores without write barrier while adding the barrier for HeapVector operations. Bug: chromium:757440 Change-Id: I8273edf45863daa7516580a2926883a69b8d8024 Reviewed-on: https://chromium-review.googlesource.com/819651 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Kouhei Ueno authored
This CL fixes a bug introduced in: https://chromium.googlesource.com/chromium/src.git/+/c0b78bc91021d1b83438807ad6c6f1edf748bce8 In the previous CL, the base URL of both {inline,external} classic scripts were set to "the document base URL of the containing document". However, the base URL of external classic scripts should be "the URL from which the script was obtained". This CL fixes the issue. Test: external/wpt/html/semantics/scripting-1/the-script-element/module/dynamic-import/string-compilation-base-url-external-classic.html Bug: 796034 Change-Id: I5674bf4139164606030b48cf66b48962c11d35f3 Reviewed-on: https://chromium-review.googlesource.com/842282Reviewed-by:
-
henrika authored
Also removes invalid (very old) comments. Goal is to match recent changes in third_party/webrtc/modules/audio_device/include/audio_device.h TBR=sergeyu, maxmorin Bug: webrtc:7306 Change-Id: I28d3a5f8926aa5625ef00d39905b70224ede4d65 Reviewed-on: https://chromium-review.googlesource.com/842645Reviewed-by:
Henrik Andreasson <henrika@chromium.org> Commit-Queue: Henrik Andreasson <henrika@chromium.org> Cr-Commit-Position: refs/heads/master@{#525972}
-
Yuta Kitamura authored
All the use sites were removed. New code must use namespace-level PostCrossThreadTask() function. Bug: 794845 Change-Id: I683696aebc1ebc04a301c61cf0e6a1436255c731 Reviewed-on: https://chromium-review.googlesource.com/842609Reviewed-by:
-
Felix Ekblom authored
It's of interest to some Chrome OS autotests to be able to detect what the primary display of the system is during enrollment / OOBE, or at least the name of the display. This CL add a custom accessor to the name of the primary display to an existing WebUIMessageHandler available during OOBE. For non-enrollment situtions an extension with access to chrome.system.display could have been used, but I've been unable to load an extension this early in the setup phase. Bug: 795722 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I3b248d123bab27bc758b074603e370f99537ce81 Reviewed-on: https://chromium-review.googlesource.com/832306Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Felix Ekblom <felixe@chromium.org> Cr-Commit-Position: refs/heads/master@{#525970}
-
Sylvain Defresne authored
Break the circular dependency between //ios/chrome/browser/tabs and //ios/chrome/browser/snapshots by using TabIdTabHelper to get the WebState unique identifier instead of using Tab. Extract tab_id_tab_helper.{h,mm} to a separate target //ios/chrome/browser/web:tab_id_tab_helper. Bug: none Change-Id: Ib8c194a8e80a58674e203aa7b48afb3a245709ef Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/839767Reviewed-by:Justin Cohen <justincohen@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#525969}
-
Boris Sazonov authored
This CL removes support for old generic signin promos from NTP. It also shortens method names that no longer need generic/personalized differentiation. Bug: 792430 Change-Id: I170f2fa0aeffeb12aa432b82512d002828d482c9 Reviewed-on: https://chromium-review.googlesource.com/834248Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#525968}
-
Makoto Shimazu authored
https://crrev.com/c/823862 has tweaked the idle timer for activation, but it still doesn't work if the worker doesn't have any inflight event but is streaming response to the browser. In that case, ServiceWorkerVersion needs to detect the end of streaming. This patch is adding the detection mechanism. We can say the worker is completely idle if 1. the worker has requested termination and 2. the worker has no streaming tasks and 3. the browser doesn't start any events after the termination request. This patch adds 2 and 3. Bug: 774374 Change-Id: If940f34f24749ec3c05bd6b04a08f303592f729e Reviewed-on: https://chromium-review.googlesource.com/838901 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
-
Takuto Ikuta authored
This reverts commit 6bdfe3b9. Reason for revert: Broke official win asan build crbug.com/797202 FAILED: obj/third_party/WebKit/Source/bindings/core/v8/bindings_core_impl.lib C:/b/depot_tools/win_tools-2_7_6_bin/python/bin/python.exe ../../build/toolchain/win/tool_wrapper.py link-wrapper environment.x86 False lib.exe /nologo /ignore:4221 /OUT:obj/third_party/WebKit/Source/bindings/core/v8/bindings_core_impl.lib @obj/third_party/WebKit/Source/bindings/core/v8/bindings_core_impl.lib.rsp LINK : MSIL .netmodule or module compiled with /GL found; restarting link with /LTCG; add /LTCG to the link command line to improve linker performance obj/third_party/WebKit/Source/bindings/core/v8/bindings_core_impl.lib : fatal error LNK1248: image size (1001D34E4) exceeds maximum allowable size (FFFFFFFF) Original change's description: > Use V8GeneratedCoreBindings only in jumbo build > > This is retry of > https://codereview.chromium.org/2318933002/ > > Current chromium/src can build all with is_official_build=true in windows. > This improves build parallelism on windows. > > Bug: 634231 > Change-Id: Ie16541b56d90718ab01a992b7f4cbc07caebcd22 > Reviewed-on: https://chromium-review.googlesource.com/836627 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> > Commit-Queue: Takuto Ikuta <tikuta@chromium.org> > Cr-Commit-Position: refs/heads/master@{#525565} TBR=peria@chromium.org,bashi@chromium.org,haraken@chromium.org,tikuta@google.com,tikuta@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 634231, 797202 Change-Id: I86c3a554a5121ab94c7950a97de7b9914b0a7b95 Reviewed-on: https://chromium-review.googlesource.com/842564 Commit-Queue: Shinya Kawanaka <shinyak@chromium.org> Reviewed-by:
Shinya Kawanaka <shinyak@chromium.org> Reviewed-by:
-
Sylvain Defresne authored
Add SnapshotTabHelper to owns the SnapshotGenerator; it is not created for pre-rendered tabs (instead it is created when the Tab is inserted to TabModel or when converted from pre-rendered). Convert all client code to use the SnapshotTabHelper instead of the Tab API wrapping SnapshotGenerator (and remove the obsolete API from Tab). Remove dependency on TabIdTabHelper by passing the WebState's snapshot session identifier to the tab helper constructor. Bug: 760556 Change-Id: I2d4ed7546dbb793448e71656de3e14d602f77bb5 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/833919 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
Elodie Banel authored
Bug: 720490 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I16836d978b6d096ac4143292bb3ed1a277a052a7 Reviewed-on: https://chromium-review.googlesource.com/839680 Commit-Queue: Elodie Banel <lod@chromium.org> Reviewed-by:
Eric Noyau <noyau@chromium.org> Cr-Commit-Position: refs/heads/master@{#525964}
-
Mostyn Bramley-Moore authored
BUG=773275 TBR=sadrul@chromium.org Change-Id: Ic62b5b68decea8a5605cceba77939da6a2e77d60 Reviewed-on: https://chromium-review.googlesource.com/842722 Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#525963}
-
Yuta Kitamura authored
This patch replaces use sites of WebTaskRunner::PostTask() for CrossThreadTask with a namespace-level function PostCrossThreadTask(). Both functions are identical, and there should be no behavior change. Bug: 794845 Change-Id: I85c501e443eaced484013a01749c36a1b13fdab2 Reviewed-on: https://chromium-review.googlesource.com/842385Reviewed-by:
-
James Forshaw authored
This is a reland of b8c94b96 Original change's description: > Added AppContainerProfile support to policy. > > This CL addeds the AppContainerProfile support to the sandbox policy code > so that new AppContainer processes can be created. > > Bug: 760977 > Change-Id: Ida8028ba6146df71defe0a4072ecaea29c04f246 > Reviewed-on: https://chromium-review.googlesource.com/804195 > Reviewed-by: Will Harris <wfh@chromium.org> > Commit-Queue: James Forshaw <forshaw@chromium.org> > Cr-Commit-Position: refs/heads/master@{#525657} Bug: 760977 Change-Id: I53fe426d76c24997b762135b88f6b5c84e32e9b8 Reviewed-on: https://chromium-review.googlesource.com/841082Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: James Forshaw <forshaw@chromium.org> Cr-Commit-Position: refs/heads/master@{#525961}
-
Colin Blundell authored
FakeWebHistoryService takes in signin-related classes in its constructor to pass them to the base class WebHistoryService constructor. However, these arguments are actually unnecessary: - WebHistoryService's only usage of these classes is to pass them to an internal RequestImpl class that makes access token requests. - The fake deliberately eschews usage of RequestImpl, replacing it with a FakeRequest class that makes no usage of //components/signin. TBR=jochen@chromium.org Bug: 796545 Change-Id: Ie82ec68f1e4d676d8dbcad1a3016d39b7999e06c Reviewed-on: https://chromium-review.googlesource.com/840029 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
-
Takashi Toyoshima authored
MidiScheduler is not used today in MidiManagerAndroid and MidiManagerUsb, but the header file is still included mistakenly. Bug: Change-Id: I99a2c65545d617d5b0a2c9980f322eba3eb3e521 Reviewed-on: https://chromium-review.googlesource.com/839482Reviewed-by:
-
Yuta Kitamura authored
This patch replaces use sites of WebTaskRunner::PostTask() for CrossThreadTask with a namespace-level function PostCrossThreadTask(). Both functions are identical, and there should be no behavior change. Bug: 794845 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ifcf6cbd35663c178bcccb49b3a30a35be130ebca Reviewed-on: https://chromium-review.googlesource.com/842442Reviewed-by:
-
Yuta Kitamura authored
This patch replaces use sites of WebTaskRunner::PostTask() for CrossThreadTask with a namespace-level function PostCrossThreadTask(). Both functions are identical, and there should be no behavior change. Bug: 794845 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I58647c581ae7eea8b81fe830b44011bb20bfdcdd Reviewed-on: https://chromium-review.googlesource.com/842386Reviewed-by:
-
