- 24 May, 2018 40 commits
-
-
Min Qin authored
This CL allows proto db to take a filter to filter out returned entries Test is also included. This will facilitate the in-progress download database work. BUG=842245 Change-Id: I63426527743811ab31560e74a8dc45f922333a00 Reviewed-on: https://chromium-review.googlesource.com/1067149 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#561590}
-
Allen Bauer authored
Bug: 845484 Change-Id: I154783db471a25436451490fe3ad93ddcc4222c5 Reviewed-on: https://chromium-review.googlesource.com/1069259 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#561589}
-
Philip Rogers authored
This patch removes the !RLS codepaths in CompositedLayerMapping (CLM) and background_image_geometry now that Root Layer Scrolling (RLS) has launched. Bug: 823365 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Id07239b22bb96fa7e4d0d3c41d82b61aa9eb5090 Reviewed-on: https://chromium-review.googlesource.com/1071871 Commit-Queue: Philip Rogers <pdr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#561588}
-
Pete Williamson authored
When the "Download Location" flag is set, we show a dialog allowing the user to pick which directory is used for downloads. Offline Pages should use the directory that the user picked. This change will get the directory from downloads, and use that when publishing downloaded offline pages. Bug: 758690 Change-Id: I74ba4a1fb2c99fb986ba2273fc4b11f8fad60ba9 Reviewed-on: https://chromium-review.googlesource.com/1069423Reviewed-by:
Yafei Duan <romax@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/master@{#561587}
-
Koji Ishii authored
This patch fixes 'vertical-align' values that need font metrics: vertical-align: sub vertical-align: super vertical-align: middle to use parent's font instead of the box that has 'vertical-align' applied. The CSS2 'vertical-align'[1] defines to use parent's font for the 'middle' value, and matches to our current code. It looks like no CSS2 test suites test this condition, but some tests in css-writing-modes do. Rebaselines look to be more correct. [1] https://drafts.csswg.org/css2/visudet.html#propdef-vertical-align Bug: 636993 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Iaaa7448687173a9ecf0c39b55914a0fad4834318 Reviewed-on: https://chromium-review.googlesource.com/1069955 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#561586}
-
Bence Béky authored
Do not send PRIORITY frames when SpdyStream priority changes because SpdyHttpStream or WebSocketHttp2HandshakeStream priority is changed. (Keep sending PRIORITY frames when the pushed stream is matched with a request of different priority.) This CL a stop-gap to avoid crashes until SpdyWriteQueue is augmented to properly handle priority changes. This CL partially reverts https://crrev.com/c/1045988. Bug: 841511 Change-Id: I871511306e96cfc2c1a3e62c8563003cdd4bb821 Reviewed-on: https://chromium-review.googlesource.com/1070655Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#561585}
-
Aaron Leventhal authored
When subscript or superscript styles or HTML tags are used, expose the accessibility semantics. In IA2, use the text-position text attribute. TBR=tsepez@chromium.org,spang@chromium.org,kinuko@chromium.org Bug: 843744 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ie0dd8ef801f11548d1284ac433c08605129817d0 Reviewed-on: https://chromium-review.googlesource.com/1068994 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#561584}
-
Brandon Wylie authored
This debugging reporter will cache metrics events that will be used for debugging purposes. The reporter is currently configured to cache 5 items (controlled by a static variable BUFFER_SIZE). Bug: 843251 Change-Id: I09a63200db01819df56474c831ad9260f75d9432 Reviewed-on: https://chromium-review.googlesource.com/1056413 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#561583}
-
fuchsia-sdk-chromium-autoroll authored
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I6f0403c2f3366a00d18b4bf8c64c7cfbad9cd85a Reviewed-on: https://chromium-review.googlesource.com/1072206Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#561582}
-
Greg Kraynov authored
Also its deps: SequencedTaskSource and LazyNow. Bug: 783309 Change-Id: Iee4c753beaa08f1373f5bac73bee31b78f338c10 Reviewed-on: https://chromium-review.googlesource.com/1061696Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Greg Kraynov <kraynov@chromium.org> Cr-Commit-Position: refs/heads/master@{#561581}
-
Thomas Anderson authored
This reverts commit 89d0b86d. Reason for revert: Suspected cause of Win x64 build failure: https://ci.chromium.org/buildbot/chromium/Win%20x64/22844 Original change's description: > Adjust gn and ifdefs to make Perfetto available > > Chrome has seven #ifdefs that decide whether Perfetto tracing is > available or not. This change consolidates those into two and then > enables Perfetto on Windows. > > This change also updates two .gn files to enable Perfetto. > > This change makes no difference unless the command-line option > --enable-features=TracingPerfettoBackend is specified. > > Note that this change will fail to run unless the Assert in Angle's > AddTraceEvent function in event_tracer.cpp is removed. This is > being investigated. > > Bug: 844421 > Change-Id: Ia978eb69bed77bda68202fdbec7a306fdb9886bc > Reviewed-on: https://chromium-review.googlesource.com/1064371 > Commit-Queue: oysteine <oysteine@chromium.org> > Reviewed-by: oysteine <oysteine@chromium.org> > Reviewed-by: Primiano Tucci <primiano@chromium.org> > Cr-Commit-Position: refs/heads/master@{#561556} TBR=primiano@chromium.org,oysteine@chromium.org,brucedawson@chromium.org Change-Id: Ia94b6d81d56af41dd010adcc436f11882887864f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 844421 Reviewed-on: https://chromium-review.googlesource.com/1072327Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#561580}
-
David Benjamin authored
https://boringssl.googlesource.com/boringssl/+log/69271b5d4fed328eb61b86b013937ce22549fee5..5601bdac1ae594169e56515fe34956ec89bbffbf This needed a fix to QUIC. BoringSSL is usually initialization-less, but Chromium is allergic to static initializers, so we build it in a mode where the caller is expected to call CRYPTO_library_init. (Chromium's EnsureOpenSSLInit is exactly the same as CRYPTO_library_init.) Code in net/third_party/quic previously wasn't initializing things, which meant tests were running with uninitialized BoringSSL. That snuck by until a change in this most recent roll tickled it. (I'm not super thrilled about this arrangement as it's rather obnoxious on consumers. We're sniffing at doing the call ourselves internally. In the meantime, Chromium has typically placed EnsureOpenSSLInit near where BoringSSL is used, so I've matched that here.) BUG=none Change-Id: I99c183c2ddb1fcf9c376de8d1d46d1f274bb9605 Reviewed-on: https://chromium-review.googlesource.com/1070648Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Steven Valdez <svaldez@chromium.org> Commit-Queue: Steven Valdez <svaldez@chromium.org> Cr-Commit-Position: refs/heads/master@{#561579}
-
Alexander Timin authored
Add behind-a-feature-flag functionality to throttle tasks on the worker thread to 1Hz. R=alexclarke@chromium.org BUG=776416 Change-Id: I1698aea8788f8688027e01af4d5e72405e2c1a23 Reviewed-on: https://chromium-review.googlesource.com/1070983Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#561578}
-
Kyle Horimoto authored
Additionally, add the ability for FakeMultiplexedChannel to run a callback in its destructor. Bug: 824568, 752273 Change-Id: I1dd571d79c3e73228481efb2b68b210dbeb041f1 Reviewed-on: https://chromium-review.googlesource.com/1072164Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#561577}
-
Adam Langley authored
This was requested as a follow-up in a previous review: https://chromium-review.googlesource.com/c/chromium/src/+/1033336/3/content/browser/webauth/authenticator_impl.cc#836 Change-Id: I672fa5ac74bed7c70c680a8cd1b88b4d0f059277 Reviewed-on: https://chromium-review.googlesource.com/1069707 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#561576}
-
spqchan authored
When BubbleDialogDelegateView::SizeToContents() is called, it doesn't take into account that the bounds from GetBubbleBounds() doesn't include the NSWindow's style. This causes the SizeToContents() to potentially set the bubble window's bounds to an incorrect value. Bug: 839709 Change-Id: I6e27ff4f30673b5f7c26b68459be1e1cdac51587 Reviewed-on: https://chromium-review.googlesource.com/1069541 Commit-Queue: Sarah Chan <spqchan@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#561575}
-
Pavel Feldman authored
Change-Id: Ibec20968f901353dd96b0273e06723a3fcbbda9e Reviewed-on: https://chromium-review.googlesource.com/1070712 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#561574}
-
Fernando Serboncini authored
Bug: 563816 Change-Id: I22d22fcd06d6bbb9de94dc891fb4b4f327720881 Reviewed-on: https://chromium-review.googlesource.com/1070210 Commit-Queue: Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Justin Novosad <junov@chromium.org> Cr-Commit-Position: refs/heads/master@{#561573}
-
Gabriel Charette authored
This reverts commit 27f8891c. Reason for revert: suspect for crbug.com/846417 Original change's description: > Migrate ContentHashFetcher to SimpleURLLoader > > This CL migrates ContentHashFetcher away from URLRequestFetcher to > SimpleURLLoader. > > In order to accomplish this, a few other related changes are also performed: > > 1) The regular flow of the code is ContentVerifier -> ContentHash -> > ContentHashFetcher. In ContentVerifier, for instance, UI, IO and > "File tasks" threads take place. > Previously, the URLRequestFetcher logic residing in ContentHashFetcher > executed in the "file tasks" thread. > > As part of the migration from URLRequestFetcher to SimpleURLLoader > machinery, this CL also changes the ContentHashFetcher logic to > execute to the IO thread. > Note that it could be possible to keep the new SimpleURLLoader logic > in the "file tasks" thread. However, this would impose a way bigger change, > and require unittests to be considerably rewritten as well (see for > patchsets 7, 8 and 9. > The issue is that mojo objects are not thread safe. We could create a new > URLLoaderFactory for the extensions thread, but then we'd need to create a > new one when the network service crashes (Something this SharedURLLoaderFactory > one, already bound to the IOThread, magically handles), but that would be > significantly more complicated. > > 2) content_verifier_hash_fetch_behavior_browsertest.cc was changed > to support running with the network service feature both enabled > and disabled. This is a pattern that is also present in various other > unittests. > > In summary, the migration to use SimpleURLLoader performed here includes > also a change in the thread that ContentHashFetcher runs on, but no > functionality change is expected from this CL. > > BUG=773295,844926 > > Change-Id: If570f69d01ff75ac59d8d043f8687621336dddcf > Reviewed-on: https://chromium-review.googlesource.com/1056587 > Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Reviewed-by: Matt Menke <mmenke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#561480} TBR=lazyboy@chromium.org,rdevlin.cronin@chromium.org,mmenke@chromium.org,tonikitoo@igalia.com Change-Id: I31235cf26cfff34aac0ff1e4047575ed2881722b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 773295, 844926, 846417 Reviewed-on: https://chromium-review.googlesource.com/1072110Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#561572}
-
Jimmy Hastings authored
Change-Id: I143904a7dec28ffbe506f29b88ef3ac83ce5e980 Reviewed-on: https://chromium-review.googlesource.com/1071112Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Jimmy Hastings <jhastings@chromium.org> Cr-Commit-Position: refs/heads/master@{#561571}
-
Qiang Xu authored
changes: - Add #enable-app-shortcut-search flag and develop behind it. - Chrome side framework to support searching app shortcuts. - Reuse GetAppShortcutItems mojo API. When specified |package_name| is empty, it is aimed on global query. Video demo: https://drive.google.com/file/d/14y70Bn0gFrZqmqJtsCS8xPLUEC0twFwh/view?usp=sharing https://drive.google.com/file/d/1LUyzoX0dLpy3rkAx420oqznZEO9Lyyww/view?usp=sharing Bug: 842947 Test: manual test with Android change Change-Id: I8d6f62f12d215d464815dd4ff6c31c1e6af9e2c5 Reviewed-on: https://chromium-review.googlesource.com/1058681 Commit-Queue: Qiang Xu <warx@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#561570}
-
Fabrice de Gans-Riberi authored
Some Posix-only instances were missed when disabling the OS_POSIX macro for the Fuchsia build. Bug: 836416 Change-Id: I291465a50813e984bdca223b1e533c2ad624062c Reviewed-on: https://chromium-review.googlesource.com/1070625Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#561569}
-
Chris Hamilton authored
This is the first in a multi-part cleanup, detailed in the bug. BUG=846374 Change-Id: I76331ceb7469f1262a2c934a956fdd96410c1a19 Reviewed-on: https://chromium-review.googlesource.com/1071884Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#561568}
-
Calder Kitagawa authored
This is an attempted fix for ToTWinCFI. Looks like sys.executable logic isn't working well on some Python configurations so directly using sys.executable. If this doesn't fix ToTCFI I'll revert the previous change until I can determine what is happening: https://chromium.googlesource.com/chromium/src/+/8e7c08d3d11c61d08ad05d3ebc283aa2d6bf7c91 Thanks to thakis@ for solution suggestion. Bug: 844826 Change-Id: Ie1cb36fe19401e954cb84bc905cd95c9eefa1622 Reviewed-on: https://chromium-review.googlesource.com/1072159 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#561567}
-
Aaron Leventhal authored
Extra events occur in unpredictable order, with the following text: EVENT_OBJECT_LOCATIONCHANGE on role=ROLE_SYSTEM_CLIENT name="Edit" Filter out these events in the output. Bug: 791268 Change-Id: If9096af8bd625a08b0cb7583d523c7cc93811947 Reviewed-on: https://chromium-review.googlesource.com/1071728 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#561566}
-
Krishna Govind authored
R=cmasso@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ic14dc4769b0bdeff4eead0ab6aafbbda4e66744b Reviewed-on: https://chromium-review.googlesource.com/1072203Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#561565}
-
Andre Goddard Rosa authored
- Makes implementation symmetric to program manager - DecUseCount() was not only doing what's named after - Also decreases binary size: text data bss dec hex filename before 6883184 193376 2012 7078572 6c02ac out/Release/libgles2.so after 6882668 193360 2012 7078040 6c0098 out/Release/libgles2.so R=piman@chromium.org Bug: 846385 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I51fc0b37ab1f59e4fc54fb11b43cc480209a0479 Reviewed-on: https://chromium-review.googlesource.com/1071009Reviewed-by:Zhenyao Mo <zmo@chromium.org> Commit-Queue: Andre Goddard Rosa <andre.rosa@lge.com> Cr-Commit-Position: refs/heads/master@{#561564}
-
Dmitry Skiba authored
LibraryLoader is a singleton, but to get its instance one has to pass LibraryProcessType value. However out of all LibraryLoader methods only two (initialize() and ensureInitialized()) actually use the process type value. Also, LibraryLoader.get(LibraryProcessType) stores process type on the first call (which creates the instance), and throws an exception if subsequent calls don't use the same value. This puts additional burden on callers, which have to handle ProcessInitException from get() even when they are calling non-initialization methods (e.g. preloadNow()). This CL moves LibraryProcessType argument from get() to initialization methods (initialize() and ensureInitialized()), and also renames get() to getInstance(). Bug: 841403 Change-Id: I74b311316f10831c23915a7f2189f38c660c4982 Reviewed-on: https://chromium-review.googlesource.com/1067847Reviewed-by:
Helen Li <xunjieli@chromium.org> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Dmitry Skiba <dskiba@chromium.org> Cr-Commit-Position: refs/heads/master@{#561563}
-
glevin authored
As per crbug.com/788019 Comments 1,5,7: - Width = 448px - Remove X (Close) button from upper right - Update title and body strings - Code cleanup - NOTE: Dialog has no buttons, is dismissed by any user action Bug: 788019 Test: Sit idle in Public Session (?), see if the Great Harmony will come and find you Change-Id: I160e93eb0fc9a788ef1c627b5459ca1e1d6c04de Reviewed-on: https://chromium-review.googlesource.com/1070713Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Greg Levin <glevin@chromium.org> Cr-Commit-Position: refs/heads/master@{#561562}
-
Kevin Marshall authored
PipelineIntegrationTest.TrackStatusChangesWhileSuspended times out frequently on the FYI bots, so filter it out for now. Bug: 836785 Change-Id: Id209d83a72e16a52cd7cc8b9281bf167a63cf636 Reviewed-on: https://chromium-review.googlesource.com/1068617Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#561561}
-
glevin authored
As per crbug.com/788025 and various other discussions: - Replace "Learn more" link with (?) button - Button has a11y text and is Tab stop - Update text to match crbug.com/721969 - Width = 448px - At present, NOT removing X (Close) button - Clean up code Bug: 788025 Test: Try to play HD content that requires device id / verification. Verify Harmoniousness of resultant dialog. Change-Id: Ibcc300a97b6f2edd49d822171467162500d9e859 Reviewed-on: https://chromium-review.googlesource.com/946907Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Greg Levin <glevin@chromium.org> Cr-Commit-Position: refs/heads/master@{#561560}
-
Sahel Sharifymoghaddam authored
This reverts commit 63049f46. Reason for revert: I missed the nit comments on the test, I will reland the issue after addressing them. Original change's description: > Touchpad fling bubbling doesn't generate extra GSB. > > With browser side touchpad fling, the fling controller processes a GFS > and schedules fling progress. On flingProgress the controller generates > wheel events which get queued in the mouse wheel event queue(MWEQ). > > When we start wheel scrolling on an out of process iframe while it is > already at its extent the wheel events get processed in the MWEQ of the > child view but the generated gesture scroll events including the GFS get > bubbled to the parent view. When the GFS gets processed by the parent > view, the generated wheel events get queued in the MWEQ of the parent. > The MWEQ will generate a GSB for the first wheel event generated from > processing the fling since it is not aware of the GSB that is bubbled to > this view and it causes hitting this DCHECK: > https://cs.chromium.org/chromium/src/content/browser/renderer_host/render_widget_host_impl.cc?q=render_widget_host_impl&dr=C&l=1256 > > This cl changes the MWEQ to ask for the state of wheel scrolling from > RWHI rather than keeping its own state, this change will be also useful > for enabling touchpad fling boosting. > > Bug: 249063 > Test: SitePerProcessBrowserTest.TouchpadGestureFlingStart > Change-Id: I0c6faa81faa7f009517393440d6e37c7e7e6a053 > Reviewed-on: https://chromium-review.googlesource.com/1064792 > Reviewed-by: Ken Buchanan <kenrb@chromium.org> > Reviewed-by: Timothy Dresser <tdresser@chromium.org> > Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#561550} TBR=kenrb@chromium.org,tdresser@chromium.org,nzolghadr@chromium.org,sahel@chromium.org Change-Id: I485b5a1dee759ba0760acc4a5210fedd34346f10 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 249063 Reviewed-on: https://chromium-review.googlesource.com/1072108Reviewed-by:
Sahel Sharifymoghaddam <sahel@chromium.org> Commit-Queue: Sahel Sharifymoghaddam <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#561559}
-
John Chen authored
Fixes two race conditions in ChromeDriver's websocket code (for connecting to DevTools): * If a connection is made after SyncWebSocketImpl::Core::Connect has timedout and returned, lower level code can access stack variables that have already gone out of scope. * If a connection is closed right after it was opened, ChromeDriver might try to read from a closed socket. Bug: chromedriver:2431 Change-Id: I6895856256f610615f63220bc33c34bacab2eeda Reviewed-on: https://chromium-review.googlesource.com/1070571 Commit-Queue: John Chen <johnchen@chromium.org> Reviewed-by:
Jonathon Kereliuk <kereliuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#561558}
-
Pavel Feldman authored
Change-Id: I1411429de9f3bb92eae22c6911a4caeb4a2932f7 TBR: eseckler Reviewed-on: https://chromium-review.googlesource.com/1071874 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#561557}
-
Oystein Eftevaag authored
Chrome has seven #ifdefs that decide whether Perfetto tracing is available or not. This change consolidates those into two and then enables Perfetto on Windows. This change also updates two .gn files to enable Perfetto. This change makes no difference unless the command-line option --enable-features=TracingPerfettoBackend is specified. Note that this change will fail to run unless the Assert in Angle's AddTraceEvent function in event_tracer.cpp is removed. This is being investigated. Bug: 844421 Change-Id: Ia978eb69bed77bda68202fdbec7a306fdb9886bc Reviewed-on: https://chromium-review.googlesource.com/1064371 Commit-Queue: oysteine <oysteine@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Cr-Commit-Position: refs/heads/master@{#561556}
-
Hiroshige Hayashizaki authored
No behavior changes. Bug: 842349 Change-Id: Iebd91d4d0f98441fd613d7bc98e26e06767915cf Reviewed-on: https://chromium-review.googlesource.com/1056415 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#561555}
-
John Chen authored
Cleaning up navigation tracker code intended to support old browsers. Change-Id: Ifd1f317574866c9c1a37b7be199e77fad7a06627 Reviewed-on: https://chromium-review.googlesource.com/1066785Reviewed-by:
Jonathon Kereliuk <kereliuk@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#561554}
-
Greg Thompson authored
Instrumentation added in r556859 revealed that some deletes are failing because the thing-to-be-deleted isn't there. This here CL attempts to plug all holes in the delete logic so that this is treated as a condition for success. BUG=599084 R=gab@chromium.org Change-Id: I04e2c22ac49bc0bd7b7850b2d17abc72f3e05e7b Reviewed-on: https://chromium-review.googlesource.com/1071656 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#561553}
-
David Trainor authored
Add support for a BatchedListObservable. This is an implementation of ListObservable that incorporates the Android support library's BatchListUpdateCallback. This class has the following behavior: - It batches up all calls to insert, remove, or change based on whether or not the changes occur to adjacent elements. - It automatically flushes the updates when a non-adjacent or different type of operation occurs. - It supports manual flushing for when the batch operation is done by the caller. BUG=842345 Change-Id: I87dcd03ad31952582308a690fb3a3dab3a4fc26b Reviewed-on: https://chromium-review.googlesource.com/1070885 Commit-Queue: David Trainor <dtrainor@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#561552}
-
Raymond Toy authored
The trybots can now run AudioContext with a fake audio device if no audio HW is available. Change the MediaElementAudioSource tests to use an AudioContext instead of an OfflineAudioContext. This is the first step in moving the factory methods from BaseAudioContext to AudioContext. Bug: 845913 Change-Id: Id4fe3d7d1b943db25cf023940c541dfab2a01aed Reviewed-on: https://chromium-review.googlesource.com/1070217Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#561551}
-