- 03 Sep, 2018 40 commits
-
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I38cd068df4007bcb0a40410491300e006d9aaccf Reviewed-on: https://chromium-review.googlesource.com/1201351Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#588338}
-
Joel Hockey authored
Added/moved signalling logic into fake clients: * FakeConciergeClient::StartTerminaVm sends OnTremplinStartedSignal. * FakeCiceroneClient::CreateLxdContainer sends OnLxdContainerCreatedSignal * FakeCiceroneClient::StartContainer sends OnContainerStartedSignal Bug: 878324 Change-Id: I7bc8caabc5f4811595d9d58c893e2beda88918dc Reviewed-on: https://chromium-review.googlesource.com/1193525Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#588337}
-
Rijubrata Bhaumik authored
TEST= run the demo in https://codepen.io/rijuB/pen/BPyWzp use slider to change focusDistance. Tested using a brio-stream-4k-hd-webcam, where we could change the focus distance in manual mode. command line: v4l2-ctl -d 1 --set-ctrl=focus_auto=0 v4l2-ctl -d 1 --set-ctrl=focus_absolute=100 GUI: guvcview --device=/dev/video1 BUG=732807 Intent to Implement and Ship discussions: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/oNxzXaFY9c8 Change-Id: I63143426ff89505c27026c4b97e54ac9afae4b0f Reviewed-on: https://chromium-review.googlesource.com/1135134Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Cr-Commit-Position: refs/heads/master@{#588336}
-
Anand K. Mistry authored
cros-disks was updated to return an error code, and two weeks have passed. This backwards compatibility code is no longer needed. BUG=288974 Change-Id: Ibc2691bc1d301b196648b32198a13349f8948e86 Reviewed-on: https://chromium-review.googlesource.com/1201505Reviewed-by:
-
Hiroshige Hayashizaki authored
Element::nonce() returns either the null or empty string if nonce is not set, when rare data exists or not, respectively. Also, nonce() is checked whether it's null (rather than whether it's empty) in Element::CloneAttributesFrom() and ContentSecurityPolicy::IsNonceableElement(). This CL make nonce() return null consistently if the nonce is not set. This will fix the very large CleanScriptElementWithNonce use count. Change-Id: If00e6006a68be89ab449402b0a5e631327712e5e Reviewed-on: https://chromium-review.googlesource.com/1180821Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#588334}
-
calamity authored
This reverts commit a886f31e. Reason for revert: Causing failures on Mac starting at https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.11%20Tests/28803 Other examples: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.13%20Tests/4934 https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/15151 Original change's description: > Add some more PPAPI TCP tests. > > In particular, add some tests for various errors and state transitions, > and make sure reading from a closed socket returns net::OK on the first > read. > > This CL also splits up the PPAPI TcpSocket browser test into multiple > tests to decrease the chance of the tests timing out. > > Bug: 848078 > Change-Id: I308cfa0ac60db63ada4a41dce8d93e68393600ff > Reviewed-on: https://chromium-review.googlesource.com/1197924 > Commit-Queue: Matt Menke <mmenke@chromium.org> > Reviewed-by: Bill Budge <bbudge@chromium.org> > Cr-Commit-Position: refs/heads/master@{#588092} TBR=bbudge@chromium.org,mmenke@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 848078 Change-Id: I3bdecc1e754da5d14cf184b5e285a6db3ec21362 Reviewed-on: https://chromium-review.googlesource.com/1201629Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#588333}
-
chrome://flags#app-window-cyclingTrent Apted authored
Mostly this is a revert of r876623. chrome://flags#app-window-cycling never worked right and was never enabled by default. Remove it, and the supporting code. In r585002 its test was disabled for unrelated reasons (NTP changes), but there's no point keeping this around. Window cycling will eventually be fixed properly as part of https://crbug.com/859152, and this will probably just get in the way. Bug: 278408, 484737, 876623 Change-Id: I6d1e453b1c5d258191913bce211785e818ee3247 Reviewed-on: https://chromium-review.googlesource.com/1198704Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#588332}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 7e647f51. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/23984 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I6892fb3792997c767a82c24bdca3616e94e2805c Reviewed-on: https://chromium-review.googlesource.com/1201347 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#588331}
-
Sam McNally authored
The file manager UI uses available_offline to determine whether an item is openable while offline so set it for hosted docs. Bug: 844291 Change-Id: I57c8135b24b0bdb069414000a0fb3fe73a1a23d6 Reviewed-on: https://chromium-review.googlesource.com/1201645Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#588330}
-
Heng-Ruey Hsu authored
GCA migration app will move all images and videos to Downloads/. BUG=b:73056417 TEST=click camera app icon launches migration app Change-Id: I3cb22ebbc09e609857f07367071e6816c7aeb5b7 Reviewed-on: https://chromium-review.googlesource.com/1187848 Commit-Queue: Heng-ruey Hsu <henryhsu@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#588329}
-
Hajime Hoshi authored
This is part of efforts to replace base::ThreadTaskRunnerHandle::Get() and SequencedTaskRunnerHandle::Get() with other appropriate task runners in the renderer. Bug: 786332 Change-Id: Ie0737135f42d7abba55080c007687a19d8c08897 Reviewed-on: https://chromium-review.googlesource.com/1198654Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#588328}
-
Alexandre Courbot authored
When creating output buffers, we were setting the number of planes to input_planes_count_ whereas it should be output_planes_count_. As it turns out, both members are currently always equal to 1, so the issue was not visible at runtime, but better fix it preemptively. BUG=None TEST=Checked that VDA unittest was passing on Kevin Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I7c6e37fcaf1e836afbb2c56220ea10dd42000fbc Reviewed-on: https://chromium-review.googlesource.com/1195183Reviewed-by:
Pawel Osciak <posciak@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#588327}
-
Sam McNally authored
For component platform apps, favicon, extension-icon, resources and theme hosts are whitelisted for the chrome scheme. However, in the network-service-enabled codepath, at most two of those hosts are passed in |allowed_webui_hosts|, leaving out the other two for component platform apps. Change the structure to more-closely match the non-network-service codepath, whitelisting the four hosts when appropriate. Bug: 837328 Change-Id: Ib10e8fa2dcca0cf77be565bab3ebf9dd87daf188 Reviewed-on: https://chromium-review.googlesource.com/1201510Reviewed-by:
Anand Mistry <amistry@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#588326}
-
Christopher Lam authored
This CL attempts to fix failing Mac builds by adding an AX mojom dependency to content/public/common:interfaces. TBR=jam@chromium.org BUG=879949 Change-Id: I0f004835ec33cde460961ec380bdb4325f12c1e7 Reviewed-on: https://chromium-review.googlesource.com/1201506Reviewed-by:
-
Raymes Khoury authored
The migration code for permission delegation is going to touch the midi sysex seting which is currently syncable. Migration code does not run well on syncable settings. To work around this for the time being, we're temporarily making midi sysex not syncable. Bug: 802945, 879954 Change-Id: I36fb0c83fbd823e6c4612a64dce84787080a8732 Reviewed-on: https://chromium-review.googlesource.com/1196283 Commit-Queue: Raymes Khoury <raymes@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#588324}
-
Eriko Kurimoto authored
The saved log would be like this: 15:08:31.981 SPEECH Speak (I) category=nav "Address and search bar" 15:08:31.981 SPEECH Speak (Q) category=nav "" 15:08:31.982 SPEECH Speak (Q) category=nav "Edit text, URL entry" 15:08:31.983 SPEECH Speak (Q) category=nav "New Tab - Google Chrome - hoge@example.com, window" 15:08:31.983 SPEECH Speak (Q) category=nav "Press up or down arrow for auto completions." 15:08:31.983 SPEECH Speak (Q) category=nav "Type to auto complete." 15:08:31.984 BRAILLE Braille "Address and search bar urled 8dot New Tab - Google Chrome - hoge@example.com, window" 15:08:31.991 EVENT EventType = focus, TargetName = Address and search bar, RootName = undefined, DocumentURL = undefined 15:08:31.995 EVENT EventType = childrenChanged, TargetName = Chrome - New Tab, RootName = undefined, DocumentURL = undefined Bug: 879449 Change-Id: Ibf3d3995b9f61ac69717e32e714ea0a1cd7fcf8d Reviewed-on: https://chromium-review.googlesource.com/1198645Reviewed-by:
Yuki Awano <yawano@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Eriko Kurimoto <elkurin@google.com> Cr-Commit-Position: refs/heads/master@{#588323}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9f511b4e..9c8d1a1e Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I6f0420d9b51b5c7882416c3bbf0ce3174f17bb48 Reviewed-on: https://chromium-review.googlesource.com/1201345Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#588322}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ca858b68c34b..2f53025e8bf1 git log ca858b68c34b..2f53025e8bf1 --date=short --no-merges --format='%ad %ae %s' 2018-09-03 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 37386b0205f4..ef3b9b463476 (1 commits) Created with: gclient setdep -r src/third_party/skia@2f53025e8bf1 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jvanverth@chromium.org Change-Id: I2112434c843b39d5e326f0a4731416da9d8d0dd1 Reviewed-on: https://chromium-review.googlesource.com/1201665Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#588321}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/37386b0205f4..9808d38c032a git log 37386b0205f4..9808d38c032a --date=short --no-merges --format='%ad %ae %s' 2018-09-03 jiajia.qin@intel.com Fix that image texture works incorrectly when loading from program 2018-09-02 jmadill@chromium.org Vulkan: Add ContextVk dirty bits. Created with: gclient setdep -r src/third_party/angle@9808d38c032a The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fjhenigman@chromium.org Change-Id: I5499251416726b1456115f8385dd7762dc809b05 Reviewed-on: https://chromium-review.googlesource.com/1201664Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#588320}
-
Matt Falkenhagen authored
This path is only for the non-S13nSW case because the URLRequestJob is a weak ptr. Refactoring only. Bug: 715640 Change-Id: I886b31f82173cb1bf9e22c950fc5bb0528c43b65 Reviewed-on: https://chromium-review.googlesource.com/1201509Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#588319}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: Icea0d0546f65d8cd32152620675c40fe42a5e9cb Reviewed-on: https://chromium-review.googlesource.com/1201406Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#588318}
-
Matt Falkenhagen authored
Remove calling FallbackToNetwork() twice. Refactoring only. Bug: 715640 Change-Id: Icc2b702bd19032d0c7d0cb082cbcdd7ed2559853 Reviewed-on: https://chromium-review.googlesource.com/1201624Reviewed-by:
-
Wang Qing authored
This CLs fixed the error of constexpr function call to non-constexpr function. Bug: 878202 Change-Id: I6ad217a687e62a9a384980d852743a56479de3a9 Reviewed-on: https://chromium-review.googlesource.com/1192467 Commit-Queue: 汪 清 <wangqing-hf@loongson.cn> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#588316}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8534723c7be1..ca858b68c34b git log 8534723c7be1..ca858b68c34b --date=short --no-merges --format='%ad %ae %s' 2018-09-02 fmalita@chromium.org [sksg] Switch containers from SkT(D)Array to std::vector 2018-09-02 fmalita@chromium.org [skottie] Enable skotte_tool on Mac builds 2018-09-02 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 88fc6da3e28c..37386b0205f4 (1 commits) Created with: gclient setdep -r src/third_party/skia@ca858b68c34b The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jvanverth@chromium.org Change-Id: I5316e8f624b67cf7d90d55771f3100b9ab4691c8 Reviewed-on: https://chromium-review.googlesource.com/1201663Reviewed-by:
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/c8323dce1f50..246eeff7e1d8 git log c8323dce1f50..246eeff7e1d8 --date=short --no-merges --format='%ad %ae %s' 2018-09-02 tikuta@chromium.org Reland "cros_chrome_sdk: Invoke compiler in relative form" Created with: gclient setdep -r src/third_party/chromite@246eeff7e1d8 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I4ca2ed7266d4d081e3a3cd2c4e3ce89af0351b53 Reviewed-on: https://chromium-review.googlesource.com/1201662Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#588314}
-
Chris Hall authored
Bug: 879943 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: If396300ba098c91628e8d956088ed0c1ada229f2 Reviewed-on: https://chromium-review.googlesource.com/1201622 Commit-Queue: Chris Hall <chrishall@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#588313}
-
Joel Hockey authored
Make key before looking up map and reuse it in all 3 places. Don't use std::move for owner_id and vm_name when making key since these fields may still be used in logging. Bug: 878324 Change-Id: Iae82b039523c1dd498501a1e823433d5e9040aec Reviewed-on: https://chromium-review.googlesource.com/1201503Reviewed-by:
-
Daniele Castagna authored
Starting from M68, we noticed some issues scanning out NV12 buffers coming from exo. This CL disables promoting exo NV12 buffers to HW overlays while we investigate the issue further. Bug: b/113362843 Change-Id: I8b3c5f7a5c8cc65a713f4791f461ebb760291c54 Reviewed-on: https://chromium-review.googlesource.com/1200944Reviewed-by:
-
xlou authored
For initial release, set margins to default value and disable the margins button when pagesPerSheet > 1. Put the pagesPerSheet settings section on top of the Margins settings section, in order to make it easier to understand that margins are disabled because of pages per sheet > 1. In printing, 2-up, 3-up, or more generally N-up refers to a page layout strategy in which multiple pages are composited onto a single page. Bug: 775999 Change-Id: I76aa4336507b17e41d6d4a42d5cfc7d35c5ea85e Reviewed-on: https://chromium-review.googlesource.com/1186115 Commit-Queue: Shirleen Lou <xlou@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#588310}
-
Jinsuk Kim authored
Tab doesn't have to keep the reference to DisplayCutoutController now that it is managed by UserDataHost, and can be obtained via |DisplayCutoutController#from(this)|. This CL removes the reference from Tab class. Bug: 877878 Change-Id: Ib7fa3b7e16d49e594324e632140d1864b4be996e Reviewed-on: https://chromium-review.googlesource.com/1195177Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#588309}
-
Kai Ninomiya authored
This reverts commit de9497de. Reason for revert: flake continued after revert, so this change wasn't responsible. Original change's description: > Revert "Use unverified sync tokens in PaintCanvasVideoRenderer" > > This reverts commit 228446ba. > > Reason for revert: Potentially causing flakes in virtual/android/fullscreen/video-fixed-background.html > > Bug: 876466 > > Original change's description: > > Use unverified sync tokens in PaintCanvasVideoRenderer > > > > PaintCanvasVideoRenderer::CopyVideoFrameTexturesToGLTexture > > unnecessarily used verified sync tokens to pass textures between > > Skia's context and WebGL's context. Verification isn't needed > > because these two clients are being used synchronously from the > > same process and thread. > > > > Changing these sync tokens to be unverified gives us a nice > > speedup - on a simple mp4-to-WebGL case on Linux, the texImage2D > > blocking time drops from ~1.25 ms to ~0.70ms (~80% speedup). > > > > Bug: 871417 > > Change-Id: I38c246fdb49588eccc87211fa06a2abf00e55c5c > > Reviewed-on: https://chromium-review.googlesource.com/1164163 > > Reviewed-by: Dan Sanders <sandersd@chromium.org> > > Commit-Queue: Kai Ninomiya <kainino@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#584840} > > TBR=sandersd@chromium.org,kainino@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 871417 > Change-Id: I51d3e5f9308eadf08babec4e1c99b1d51c4a3b90 > Reviewed-on: https://chromium-review.googlesource.com/1192129 > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > Commit-Queue: Kai Ninomiya <kainino@chromium.org> > Cr-Commit-Position: refs/heads/master@{#586500} TBR=sandersd@chromium.org,kainino@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 876466, 871417 Change-Id: Ic5c2206901239695b8289f0fa3e63f925094444d Reviewed-on: https://chromium-review.googlesource.com/1200487Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#588308}
-
Ned Nguyen authored
TBR=csharrison@chromium.org, nyquist@chromium.org Bug: 879922 Change-Id: I5237d1478aef9245fb6c30dc4b8e052f6d5a0edc Reviewed-on: https://chromium-review.googlesource.com/1201322Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#588307}
-
xlou authored
Added callback handling when pagesPerSheet > 1. Added more fields to print messages to support N-up printing. In printing, 2-up, 3-up, or more generally N-up refers to a page layout strategy in which multiple pages are composited onto a single page. Bug: 775999 Change-Id: Ic24fef1b49f21dd35fcbc334736b62128e7edd98 Reviewed-on: https://chromium-review.googlesource.com/1182615 Commit-Queue: Shirleen Lou <xlou@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#588306}
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: Icc74a0d64ebef7d6e9c19d09a5780a34c815142f Reviewed-on: https://chromium-review.googlesource.com/1201163 Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/88fc6da3e28c..37386b0205f4 git log 88fc6da3e28c..37386b0205f4 --date=short --no-merges --format='%ad %ae %s' 2018-09-02 jmadill@chromium.org Vulkan: Cache object pointers in ContextVk. Created with: gclient setdep -r src/third_party/angle@37386b0205f4 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fjhenigman@chromium.org Change-Id: I483261432b1205e95de1dee171a02af30e392bd4 Reviewed-on: https://chromium-review.googlesource.com/1201382Reviewed-by:
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e8e12e89c46b..8534723c7be1 git log e8e12e89c46b..8534723c7be1 --date=short --no-merges --format='%ad %ae %s' 2018-09-02 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version Created with: gclient setdep -r src/third_party/skia@8534723c7be1 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jvanverth@chromium.org Change-Id: Idb9e0b58888b339bc3ae6d74d67e8e37c2f2e13a Reviewed-on: https://chromium-review.googlesource.com/1201144Reviewed-by:
-
Kurt Horimoto authored
This CL updates the traits of the page control buttons to be selected for the selected page. Bug: 876868 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I466ae32f70768ddb0d8ffa23faba22fbf1456a32 Reviewed-on: https://chromium-review.googlesource.com/1200482Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#588302}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e0a58f83..9f511b4e Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8d84565a9d1b7c7ec40c1af1bf07332c904f3181 Reviewed-on: https://chromium-review.googlesource.com/1201162Reviewed-by:
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/c5ef97683754..c8323dce1f50 git log c5ef97683754..c8323dce1f50 --date=short --no-merges --format='%ad %ae %s' 2018-09-02 dgarrett@google.com gen_luci_scheduler: Update help messages. Created with: gclient setdep -r src/third_party/chromite@c8323dce1f50 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I708379e3aab91c8897be2ce6c0cfcff587df7735 Reviewed-on: https://chromium-review.googlesource.com/1201143Reviewed-by:
-
Rijubrata Bhaumik authored
This CL adds focusDistance to ImageCapture API. This was added to the spec in https://github.com/w3c/mediacapture-image/pull/175 Layout tests and mock tests are updated to support the same. Support for Android is added. TEST= run the demo in https://codepen.io/rijuB/pen/NzWpxG use slider to change focusDistance. BUG=732807 Intent to Implement and Ship discussions: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/oNxzXaFY9c8 Change-Id: I9b7cbf3c85fd35741a8c7ed229910a996e14ee8f Reviewed-on: https://chromium-review.googlesource.com/1124839Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Cr-Commit-Position: refs/heads/master@{#588299}
-
