GitLab

This CL updates the webrequest API documentation to state that requests that cannot be associated with a tab are labeled with "tabId = -1" instead of "tabId = null".

I chose to update the documentation rather than the code for two reasons:
- As 0 is a valid value for the tabId, we would need to distinguish between 0 and null.
- For the RequestFilter type, 'tabId' is an optional parameter. I.e. we would need to distinguish between 0, null and undefined.

BUG=93373
TEST=no


Review URL: http://codereview.chromium.org/7741014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98289 0039d316-1c4b-4281-b951-d872f2087c98

This static method branches the CreateSelfSigned code to create a self signed certificate that contains an X509v3 extension that indicates the ASCII weborigin that is bound to the generated certificate.

BUG=88782
TEST=


Review URL: http://codereview.chromium.org/7384002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98288 0039d316-1c4b-4281-b951-d872f2087c98

This yak needs shaving because chunks of gtk using code in chrome/ are being
moved to content/ to build the content_shell, but we can't depend on code in
chrome/. While I'm here, split gtk_util.h into a set of logical chunks: hig
constants, widget factory functions, etc instead of just moving the file.

BUG=93804
TEST=none; code move

Review URL: http://codereview.chromium.org/7737001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98287 0039d316-1c4b-4281-b951-d872f2087c98

Other places which spin a nested loop pin the containing object in
place in case something fires a window close.  There are crashes which
indicate that this is happening here.

BUG=92390
TEST=monitor crash server.


Review URL: http://codereview.chromium.org/7715019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98286 0039d316-1c4b-4281-b951-d872f2087c98

If the window is animating closed when a previously-posted
PerformLayout task is fired, the last reference to the controller may
be released while laying things out.  Pin the controller down until
the task is completed.

BUG=90773
TEST=Monitor crash server for continued zombies.


Review URL: http://codereview.chromium.org/7717027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98285 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=Verified basic functionality using views_examples.

Review URL: http://codereview.chromium.org/7669028
Patch from Daniel Nicoara <dnicoara@chromium.org>.

TBR=backer@chromium.org
Review URL: http://codereview.chromium.org/7741028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98284 0039d316-1c4b-4281-b951-d872f2087c98

Add missing entry for new content type 'auto-select-certificate' to kContentSettingsTypeGroupNames array of the content_settings_handler.

Fixes chrome crashing when opening an incognito window while the preferences tab is open.


BUG=81825
TEST=chrome not crashing


Review URL: http://codereview.chromium.org/7744007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98283 0039d316-1c4b-4281-b951-d872f2087c98

This is used in code that will be moved for use in content_shell.

BUG=93804
TEST=none; code move

Review URL: http://codereview.chromium.org/7740003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98282 0039d316-1c4b-4281-b951-d872f2087c98

Referenced by browser/bookmarks/bookmark_drop_info.cc, fixes link when in
component and incremental linking on Windows.


BUG=
TEST=Links in Component build mode


Review URL: http://codereview.chromium.org/7741017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98281 0039d316-1c4b-4281-b951-d872f2087c98

The GpuInfoCollector and CompositorGL exist on different threads in the browser process and both use the GL bindings. I've witnessed a race in the binding initialization where one thread thinks that the bindings have been initialized, but the initialization hasn't completed on the other thread, and a NULL function pointer gets dereferenced.

BUG=none
TEST=fixes segfault on TOUCH_UI build

Review URL: http://codereview.chromium.org/7724003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98280 0039d316-1c4b-4281-b951-d872f2087c98

for bug 84426.

But we will only use ssl_host_info_->state().certs if the cached info
extension is enabled.

Do not treat an empty ssl_host_info_->state().certs as failure because
it is normal for us to not have the server's certificates if we have
not visited the site before.

R=agl@chromium.org
BUG=84426
TEST=none

Review URL: http://codereview.chromium.org/7741007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98279 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=Verified basic functionality using views_examples.

Review URL: http://codereview.chromium.org/7669028
Patch from Daniel Nicoara <dnicoara@chromium.org>.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98278 0039d316-1c4b-4281-b951-d872f2087c98

is finished.

R=agl@chromium.org,mattm@chromium.org
BUG=88782
TEST=none

Review URL: http://codereview.chromium.org/7746010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98277 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jam@chromium.org

Review URL: http://codereview.chromium.org/7749014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98276 0039d316-1c4b-4281-b951-d872f2087c98

Temporarily don't link resource_disaptcher_host_unittest.cc in content_unittests on chromeos while a dependency is being removed.
Review URL: http://codereview.chromium.org/7748023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98275 0039d316-1c4b-4281-b951-d872f2087c98

This will make it easier to choose the right timeout.

BUG=none

Review URL: http://codereview.chromium.org/7744031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98273 0039d316-1c4b-4281-b951-d872f2087c98

R=asargent@chromium.org

Review URL: http://codereview.chromium.org/7741019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98272 0039d316-1c4b-4281-b951-d872f2087c98

Move resource_dispatcher_host_unittest.cc to content_unittests now that all its link time dependencies are in content.

BUG=90443
Review URL: http://codereview.chromium.org/7746008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98271 0039d316-1c4b-4281-b951-d872f2087c98

This code will be removed again once histograms have been collected (prior
to the M15 branchpoint).
R=cbentzel@chromium.org, dominich@chromium.org
Review URL: http://codereview.chromium.org/7741002

TBR=tburkard@chromium.org
Review URL: http://codereview.chromium.org/7740029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98270 0039d316-1c4b-4281-b951-d872f2087c98

BUG=94171
TEST=chromeos official builder dev channel goes green

Review URL: http://codereview.chromium.org/7747020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98267 0039d316-1c4b-4281-b951-d872f2087c98

This function should simplify some constructions.

Instead of:

if (!value->IsType(Value::TYPE_BINARY))
  return false;
  BinaryValue* binary_value = static_cast<BinaryValue*>(value);

You can do:

BinaryValue* binary_value = value->AsBinary();
if (!binary_value)
  return false;

BUG=None
TEST=base_unittests --gtest_filter=Values*

R=evan@chromium.org

Review URL: http://codereview.chromium.org/7748017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98266 0039d316-1c4b-4281-b951-d872f2087c98

BUG=76697
Review URL: http://codereview.chromium.org/7745024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98265 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: http://codereview.chromium.org/7743006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98263 0039d316-1c4b-4281-b951-d872f2087c98

Note: This was a TODO added by rogerta@chromium.org

BUG=None
TEST=None

R=sky@chromium.org

Review URL: http://codereview.chromium.org/7717028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98259 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98258 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98257 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98256 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=levin
Review URL: http://codereview.chromium.org/7748019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98255 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/7744028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98254 0039d316-1c4b-4281-b951-d872f2087c98

BUG=92415
TEST=Manual

Review URL: http://codereview.chromium.org/7714026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98253 0039d316-1c4b-4281-b951-d872f2087c98

BUG=22208

Review URL: http://codereview.chromium.org/7629003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98252 0039d316-1c4b-4281-b951-d872f2087c98

This code will be removed again once histograms have been collected (prior
to the M15 branchpoint).
R=cbentzel@chromium.org, dominich@chromium.org
Review URL: http://codereview.chromium.org/7741002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98250 0039d316-1c4b-4281-b951-d872f2087c98

As identified by http://crbug.com/90867, we sometimes leaked render view hosts by overwriting them in the swapped out map of the render view host manager.
 
This should not happen (two different hosts with the same instance id) and will eventually be fixed, but in the mean time this CL recovers from that problem and prevent the leak, and also the memory corruptions that were caused by it.

The memory corruption were caused by the fact that the leaked host would not be told when their delegate_ would die and might try to call them post-mortem.

BUG=90867
TEST=RenderViewHostManagerTest.LeakingRenderViewHosts

Review URL: http://codereview.chromium.org/7725005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98249 0039d316-1c4b-4281-b951-d872f2087c98

I'd apply these to all doc channels.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7744001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98248 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=Verified basic functionality using views_examples.

Review URL: http://codereview.chromium.org/7669028
Patch from Daniel Nicoara <dnicoara@chromium.org>.

TBR=backer@chromium.org
Review URL: http://codereview.chromium.org/7749007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98246 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98243 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98242 0039d316-1c4b-4281-b951-d872f2087c98

Get rid of all chrome includes from RenderWidgetHostViewWin. We'll want to move this to content so that the content browser can reuse all this code.
Review URL: http://codereview.chromium.org/7741006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98240 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98238 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=Verified basic functionality using views_examples.

Review URL: http://codereview.chromium.org/7669028
Patch from Daniel Nicoara <dnicoara@chromium.org>.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98236 0039d316-1c4b-4281-b951-d872f2087c98