GitLab

1.When we add new page or new folder after selecting some page bookmarked entry
in Bookmark manager, then new item should be added immediately below the
selected item.
2.when we add new page or new folder after selecting some folder bookmarked entry
in Bookmark manager, then new item should be added as last item inside selected
folder.
3.when we add new page or new folder without selecting any bookmarked entry
in Bookmark manager, then new item should be added in the last of already existing
bookmarked entries.

Added code in addPage() and newFolder() in main.js for getting the index of new node to be added so that it will be at proper location.

BUG=409816

Review URL: https://codereview.chromium.org/795483004

Cr-Commit-Position: refs/heads/master@{#310719}

BUG=447462

Review URL: https://codereview.chromium.org/838383002

Cr-Commit-Position: refs/heads/master@{#310718}

This patch adds a limit for number of opened files at once. The reason for that
is that provided file systems may not support multiple opened files per once due
to performance reasons. Enqueuing files is on the extension side is complicated
as extensions are event pages, and state may get lost after a suspend.

Note, that this CL only adds the C++ side. The opened_files_limit option is not
exposed via File System Provider API yet. This will be done separately.

Finally, the Queue class will be reused for enqueuing watcher events, which are
currently not safe (there are TODO about adding a queue). This will be also done
separately.

TEST=unit_tests: *FileSystemProviderQueue*, *FileSystemProviderThrottled*
BUG=445125

Review URL: https://codereview.chromium.org/829553002

Cr-Commit-Position: refs/heads/master@{#310717}

Revert of Add print and getSelectedText functions to the OOP PDF scripting API (patchset #3 id:40001 of https://codereview.chromium.org/843463002/)

Reason for revert:
Win7 Tests fail the test PDFExtensionTest.BasicPlugin.

API Test Error in testGetSelectedText

http://build.chromium.org/p/chromium.webkit/builders/Win7%20Tests/builds/7823/steps/browser_tests/logs/BasicPlugin

Original issue's description:
> Add print and getSelectedText functions to the OOP PDF scripting API
>
> These are needed by some internal users (see the bug for more details).
> A test is added for selectAll/getSelectedText.
>
> BUG=415858
>
> Committed: https://crrev.com/7b1df224a957da8376e0ae71ab2d53dabf658b0a
> Cr-Commit-Position: refs/heads/master@{#310663}

TBR=sammc@chromium.org,raymes@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=415858

Review URL: https://codereview.chromium.org/843923002

Cr-Commit-Position: refs/heads/master@{#310716}

Because some trybots such as linux chromeos ozone use old linux
header files, use this flag to workaround chromium:446088 issue
to skip those trybots. So we can re-submit
https://codereview.chromium.org/826663002/. After 446088 is
fixed, this CL should be reverted.

BUG=445016
TEST=build squawks with this flag

Review URL: https://codereview.chromium.org/799543005

Cr-Commit-Position: refs/heads/master@{#310715}

When we selected some text that spreads in multiple pages then content of
pages should be separated by new line as happening in the Adobe Reader.
code added for checking selection in newpage, then add a newline char.

BUG=84387

Review URL: https://codereview.chromium.org/824363002

Cr-Commit-Position: refs/heads/master@{#310714}

This CL fixes the logic for detecting if a file was correctly opened in the
fsp::FileStreamReader and fsp::FileStreamWriter classes.

TEST=browser_test: *FileSystemProvider*, unit_test: *FileSystemProvider*FileStream*
BUG=447448

Review URL: https://codereview.chromium.org/814113007

Cr-Commit-Position: refs/heads/master@{#310713}

These unused members were found by locally changing DISALLOW_COPY_AND_ASSIGN to use "= delete"
so that the compiler can be sure these members are not used in the copy ctor and operator=.

BUG=447445
TEST=build

Review URL: https://codereview.chromium.org/838203002

Cr-Commit-Position: refs/heads/master@{#310712}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/c38b182..81e4b76

TBR=jsbell@chromium.org,keishi@chromium.org

Review URL: https://codereview.chromium.org/840193002

Cr-Commit-Position: refs/heads/master@{#310711}

These were broken in https://codereview.chromium.org/786023002

BUG=303849

Review URL: https://codereview.chromium.org/832373003

Cr-Commit-Position: refs/heads/master@{#310710}

The condition for NOT_FOUND was wrong. It worked, because another error exists
in the reader (crbug.com/447448).

TEST=browser_tests: *FileSystemProvider*Evil*
BUG=None

Review URL: https://codereview.chromium.org/838373002

Cr-Commit-Position: refs/heads/master@{#310709}

When browser want to do update(defined in sepc as [[Soft Update]]), the
update should not stop a installing worker.

For example, a controlled page navigation will trigger update after 1
second, if it also register a new version before this update, the new
worker might become redundant.

BUG=443046,404111

Review URL: https://codereview.chromium.org/822293003

Cr-Commit-Position: refs/heads/master@{#310708}

BUG=447461
NOTRY=true
TBR=bnc@chromium.org

Review URL: https://codereview.chromium.org/816553004

Cr-Commit-Position: refs/heads/master@{#310707}

Right clicking outside of a selected area should deselect text and bring up the correct context menu.

on right clink selection was not getting cleared,due to that
wrong context menu is coming.
Changes done so that when right click on the selected area then
selection will stay and proper context menu will come.
And when right click have been done outside selection then
selection will clear and correct context menu will come.

BUG=92800

Review URL: https://codereview.chromium.org/689083002

Cr-Commit-Position: refs/heads/master@{#310706}

Set up a FieldTrial which could disable this flag (via finch).

When the flag is enabled, chrome sends TCID parameter in CHLO message.
It is set to 0.

Added ??ByteConnectionId unittests to end_to_end_test.cc (found while
comparing the chromium code with internal source tree).

R=rch@chromium.org

Review URL: https://codereview.chromium.org/804813010

Cr-Commit-Position: refs/heads/master@{#310705}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/cb23524..c38b182

TBR=jsbell@chromium.org,keishi@chromium.org

Review URL: https://codereview.chromium.org/821583003

Cr-Commit-Position: refs/heads/master@{#310704}

BUG=441448
TEST=run browser_tests

Review URL: https://codereview.chromium.org/831833003

Cr-Commit-Position: refs/heads/master@{#310703}

BUG=428729

Review URL: https://codereview.chromium.org/840033004

Cr-Commit-Position: refs/heads/master@{#310702}

Dynamic load v4l-utils related libraries in unittest.

BUG=405861
TEST=use video_encode_accelerator_unittest to make sure
v4l2_open and plugin_init is called. Related shared libraries are from
chromeos. When use_v4lplugin=0, unittest doesn't open v4l2 libraries.

Review URL: https://codereview.chromium.org/700383004

Cr-Commit-Position: refs/heads/master@{#310701}

BUG=413057

Review URL: https://codereview.chromium.org/814183002

Cr-Commit-Position: refs/heads/master@{#310700}

This is done by passing the android app object (which has the new GetProcesses,
GetProcess, and GetWebViews functions).

BUG=

Review URL: https://codereview.chromium.org/842963003

Cr-Commit-Position: refs/heads/master@{#310699}

This change refactors the bypass logic into a class and adds support for
a new group in the DataReductionProxyRemoveMissingViaHeaderOtherBypass
field trial. This new group relaxes the non-4xx response missing via
header bypass logic to only apply to the first response through the
proxy after a network change.

BUG=413035, 409466

Review URL: https://codereview.chromium.org/836583002

Cr-Commit-Position: refs/heads/master@{#310698}

This CL adds a new type of interstitial for SSL pages
broken by captive portals. When captive portal detection
is enabled, the new SSLErrorHandler class triggers a captive
portal check and fires a short lived (2 second) one shot timer.
If a captive portal is detected in this window, a custom
captive portal interstitial with "Connect" button is shown. If
a captive portal isn't detected, an SSL interstitial is shown.
Any captive portal result that arrives after the timer expires
is ignored.

Screenshot of the new interstitial: https://goo.gl/cnLIXQ

BUG=384667
TEST=ssl_error_handler_unittest.cc, CaptivePortalBrowserTest.*

Review URL: https://codereview.chromium.org/318213002

Cr-Commit-Position: refs/heads/master@{#310697}

BUG=skia:3294
TBR=bungeman@google.com
NOTRY=true

Review URL: https://codereview.chromium.org/791163003

Cr-Commit-Position: refs/heads/master@{#310696}

$ git log 119b0841b..c44f5725d --date=short --format='%ad %ae %s' | sed 's/@chromium\.org//'
2015-01-08 maruel Add signal handling to subprocess42 and make run_isolated use it.

R=vadimsh@chromium.org
BUG=

Review URL: https://codereview.chromium.org/840043005

Cr-Commit-Position: refs/heads/master@{#310695}

This moves it into gpu/blink/ along side WebGraphicsContext3DImpl,
consolidating more this code as we are in the process of removing
webkit/ glue directory altogether. This is one more step on this way.

BUG=338338
TEST=compositor_unittests, gpu_unittests, content_unittests
R=jamesr@chromium.org,piman@chromium.org
TBR=boliu@chromium.org

Review URL: https://codereview.chromium.org/841773006

Cr-Commit-Position: refs/heads/master@{#310694}

glBindBufferBase

BUG=429053
TEST=gpu bots

Review URL: https://codereview.chromium.org/802613003

Cr-Commit-Position: refs/heads/master@{#310693}

The HidDeviceInfo object for a device is passed around a lot, including
being copied every time enumeration of a device is requested. Since this
data is constant once a device is enumerated it is better to keep one
copy around for the device for as long as it is connected. This will
make it similar to the device::UsbDevice class.

I consider this a pre-requisite for storing more information in
HidDeviceInfo such as the raw report descriptor. Later patches will
revisit how this object is constructed and possibly reduce the number of
friend classes.

BUG=442818

Review URL: https://codereview.chromium.org/825523003

Cr-Commit-Position: refs/heads/master@{#310692}

This patch was automatically generated using a variation of
https://codereview.chromium.org/598073004

BUG=417463

Review URL: https://codereview.chromium.org/842063002

Cr-Commit-Position: refs/heads/master@{#310691}

BUG=444108

Review URL: https://codereview.chromium.org/843873002

Cr-Commit-Position: refs/heads/master@{#310690}

Previously Drive API uses constant boundary for multipart uploading.  This CL
let the API generate a random boundary and ensure the boundary is not included
in the content part.

BUG=269922
TEST=None

Review URL: https://codereview.chromium.org/805153006

Cr-Commit-Position: refs/heads/master@{#310689}

This should be a lightweight test suite that should allow a dev changing
something in skia/ext to test it much more quickly than having to build
all 'unit_tests' target just to run the tests from skia/ext.

It was reverted because it broke Mac GN with error like:
duplicate symbol __ZN3gfx27SkMatrixToCGAffineTransformERK8SkMatrix in:
    obj/skia/ext/skia_unittests.skia_utils_mac_unittest.o
        obj/skia/ext/skia.skia_utils_mac.o
        (and more similar issues).

BUG=444058
TEST=skia_unittests links and runs fine.
R=danakj@chromium.org,thakis@chromium.org,glider@chromium.org,sky@chromium.org
TBR=glider@chromium.org (already reviewed tools/valgrind - and no changes were made at that directory).

Review URL: https://codereview.chromium.org/837243002

Cr-Commit-Position: refs/heads/master@{#310688}

Add easyUnlockPrivate.getConnection API to allow querying for a Bluetooth connection's RSSI and TX power.

BUG=403419

Review URL: https://codereview.chromium.org/813303003

Cr-Commit-Position: refs/heads/master@{#310687}

Clamping the current time within Pipeline leads to a race
a race condition while using |renderer_ended_|.  The problem
that code was added for can mostly be fixed by instead clamping
the pause time in WebMediaPlayerImpl.

I've verified the HTMLMediaElement cleanup in another CL still
passes all tests: https://codereview.chromium.org/456343002/

BUG=446637
TEST=layout tests, unittests.

Review URL: https://codereview.chromium.org/843863002

Cr-Commit-Position: refs/heads/master@{#310686}

The CL moves lines of GalleryDataModel from gallery.js to gallery_data_model.js.
Also it adds a unittest for saving items.

BUG=439898
TEST=GalleryJsTest.GalleryDataModelTest

Review URL: https://codereview.chromium.org/838993002

Cr-Commit-Position: refs/heads/master@{#310685}

Added bypass rules so that Data Reduction Proxy bypasses local and unspecified addresses.

BUG=444601

Review URL: https://codereview.chromium.org/799233003

Cr-Commit-Position: refs/heads/master@{#310684}

Revert of Push API: Add temporary debug log to track down crash (patchset #2 id:20001 of https://codereview.chromium.org/846473003/)

Reason for revert:
Speculative revert for Android Tests unit_tests failures. 170 tests consistently crashing/failing with nothing printed in the log (ex: https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/17673/steps/unit_tests/logs/stdio

[ RUN      ] BrowsingDataRemoverTest.RemoveMultipleTypes
[ CRASHED      ]
)

Original issue's description:
> Push API: Add temporary debug log to track down crash
>
> Specifically, for https://goto.google.com/gcmdriver-already-instantiated
>
> Sample output:
> [FATAL:gcm_profile_service.cc(155)] An instance of GCMProfileService already exists! Old profile: 0x9e9d75c0 Default 0 0 1 13065207799278578, new profile: 0x9e9d75c0 Default 0 0 1 13065207799278578
>
> BUG=437827
>
> Committed: https://crrev.com/934554c3f369c9821b0af3ae8a09ed55f29eafc9
> Cr-Commit-Position: refs/heads/master@{#310593}

TBR=bauerb@chromium.org,jianli@chromium.org,johnme@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=437827

Review URL: https://codereview.chromium.org/839153005

Cr-Commit-Position: refs/heads/master@{#310683}

This fixes two related bugs, one in the classic and one in the
experimental launcher in right-to-left languages. The classic launcher
would display a blank page upon opening the window; the experimental
launcher would display the start page layered on top of the apps grid.

The root cause of both bugs is http://crbug.com/446407; this is a quick
fix for merging back to M40 where this regressed.

BUG=441962
BUG=446978

Review URL: https://codereview.chromium.org/844883002

Cr-Commit-Position: refs/heads/master@{#310682}

android-chrome revision is overwritten with TOT revision when we sync only
chromium revision. This causes inconsistency between android-chrome and chromium
revisions that we want to bisect. Therefore we pass android-chrome revision along with chromium
revision to make sure we are bisect chromium on proper android-chrome revision.

BUG=447348
NOTRY=true

Review URL: https://codereview.chromium.org/800143003

Cr-Commit-Position: refs/heads/master@{#310681}

cc.debug includes pictures, resources and other layers info.
a picture has skia data which is encoded by base64 format.
the skia data is too big to send via IPC. so we can not see
other tracing info. this patch is for separating the picture
data from cc.debug.

BUG=446425

Review URL: https://codereview.chromium.org/828703002

Cr-Commit-Position: refs/heads/master@{#310680}