GitLab

This simplifies base::MockTimer implementation using overridden task
runner. Also, this moves base::MockTimer to //base/test:test_support.

Tbr: khorimoto@chromium.org, chirantan@chromium.org, sky@chromium.org
Bug: 850247
Change-Id: Id233bfdff24fc258d45c5fb3e6ebe292fc973775
Reviewed-on: https://chromium-review.googlesource.com/1094852
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568356}

This make sure starting a new Picture-in-Picture session from the same
video doesn't crash in Chrome OS.

Bug: 852289
Change-Id: I7f4f5f3bed9999c08ee6576e9fe96e559e92009f
Reviewed-on: https://chromium-review.googlesource.com/1102469
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Reviewed-by: apacible <apacible@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568355}

Bug: 813477
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Ief0de1355199f9cc69e296f117d93adf4e771206
Reviewed-on: https://chromium-review.googlesource.com/1104620Reviewed-by: Alexey Baskakov <loyso@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568354}

Background:
Currently page load metrics tracks data usage when requests complete.
This misses canceled requests when the tab closes. The current codepath
will also deprecated due to the upcoming network servicification work.

This CL reports the continuous data use to page load metrics in renderer.
Response starts and completions are reported as well so that the observer
can keep track of data per resource. Subsequent CLs will send this to
browser process via the existing PageLoadMetrics mojo.

Bug: 836029
Change-Id: I023ea08b2b8f1974ea40586afeee3a27b9900782
Reviewed-on: https://chromium-review.googlesource.com/1042795
Commit-Queue: rajendrant <rajendrant@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568353}

This class creates one ConnectionAttempt per ConnectionAttemptDetails
requested; if more than one request shares the same
ConnectionAttemptDetails, a single ConnectionAttempt attempts a
connection for all associated requests.

If a ConnectionAttempt successfully creates a channel, this class
extracts client data from all requests to the same remote device and
alerts its delegate, deleting all associated ConnectionAttempts when it
is finished.

Bug: 824568, 752273
Change-Id: If9790549157919209e3e96f4a0b11d04fda2870c
Reviewed-on: https://chromium-review.googlesource.com/1103669
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568352}

To set the throttring network condition using DevTools, currently the special
HTTP header key "x-devtools-emulate-network-conditions-client-id" is used.

But having the special HTTP header is not good for design. The header value is
sometimes accidentally sent to the server (bug: 395966, 698905, 814568, 595229).
To avoid this issue and for code health, we should have a flag for it.

This CL introduces |throttling_profile_id| flag in:
 - network::ResourceRequest
And |devtools_token| flag in:
 - blink::ResourceRequest
 - content::NavigationRequestInfo

And creates a ScopedThrottlingToken when net::URLRequest is created in
network::URLLoader and ResourceDispatcherHostImpl to register the profile ID
with the NetLog source ID of the request to ThrottlingController.

And changes ThrottlingController to use the NetLog source ID to lookup the
ThrottlingNetworkInterceptor for the request.

The flag |devtools_token| and |throttling_profile_id| are passed through the
following flow:
For subresource requests:
  - InspectorNetworkAgent::WillSendRequest()
    InspectorNetworkAgent.devtools_token_ -> blink::ResourceRequest
  - WebURLLoaderImpl::Context::Start()
    blink::ResourceRequest -> (WebURLRequest) -> network::ResourceRequest
  * If NetworkService disabled
    - ResourceDispatcherHostImpl::ContinuePendingBeginRequest()
      network::ResourceRequest => ScopedThrottlingToken => ThrottlingController
  * If NetworkService enabled
    - network::URLLoader::URLLoader()
      network::ResourceRequest => ScopedThrottlingToken => ThrottlingController

For main resources (navigation):
  - NavigationRequest::OnStartChecksComplete()
    frame_tree_node_->devtools_frame_token() -> content::NavigationRequestInfo
  - NavigationURLLoaderImpl::NavigationURLLoaderImpl()
    content::NavigationRequestInfo -> network::ResourceRequest
  * If NetworkService disabled
    - ResourceDispatcherHostImpl::BeginNavigationRequest()
      network::ResourceRequest => ScopedThrottlingToken => ThrottlingController
  * If NetworkService enabled
    - network::URLLoader::URLLoader()
      network::ResourceRequest => ScopedThrottlingToken => ThrottlingController

ScopedThrottlingToken calls UnregisterNetLogSource() in the destructor.

Bug: 395966, 849966
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: Ic8b428cbea0a5b4fdca3f065f3884ca0e99344e1
Reviewed-on: https://chromium-review.googlesource.com/1086949
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568351}

BUG=762641
TBR=manucornet@google.com

Change-Id: I5308d1a51c04b26ab9b2be58347edaf0bbc3720d
Reviewed-on: https://chromium-review.googlesource.com/1105526Reviewed-by: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org>
Commit-Queue: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568350}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/a80d9730..dd5dd45d

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: I194202fe977fc5ac77f19ed9609cb66250c9fe03
Reviewed-on: https://chromium-review.googlesource.com/1105511Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#568349}

See https://www.mitel.com/support/security-advisories/mitel-product-security-advisory-17-0001

Bug=844069

Change-Id: I0c7597689981279b3a260f4c3c7d681529b22a01
Reviewed-on: https://chromium-review.googlesource.com/1103224
Commit-Queue: Andrew Whalley <awhalley@google.com>
Reviewed-by: Ryan Sleevi <rsleevi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568348}

Bug: None
Change-Id: I7c1fb0026eb6db686b79dac055d9d792a82ebf13
Reviewed-on: https://chromium-review.googlesource.com/1104473
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568347}

This reverts commit 0c91664f.

Reason for revert: Broke Linux Builder (dbg)(32)

Still missing libuuid:

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Builder%20%28dbg%29%2832%29/83697

[775/4337] ACTION //tools/v8_context_snapshot:generate_v8_context_snapshot(//build/toolchain/linux:clang_x86)
FAILED: v8_context_snapshot.bin 
python ../../build/gn_run_binary.py ./v8_context_snapshot_generator --output_file=v8_context_snapshot.bin
././v8_context_snapshot_generator: error while loading shared libraries: libuuid.so.1: cannot open shared object file: No such file or directory
./v8_context_snapshot_generator failed with exit code 127

Original change's description:
> Reland "Update fontconfig to 6cc99d6a"
> 
> This is a reland of e6db40d9
> 
> Reason for reland: All bots should now have libuuid1 installed (bug 853048).
> 
> Original change's description:
> > Update fontconfig to 6cc99d6a
> >
> > Changelog [1].  This is necessary to pick up [2] for fixing undefined-shift
> > UBSAN errors detected by clusterfuzz, [3] to allow removing a build workaround,
> > [4] to fix a bug and clean up some log spam, [5] to fix CFI builds, and [6] to
> > fix a use-after-free.
> >
> > Fontconfig also now requires libuuid as a dependency, so whitelist it as a
> > dependency since we statically link fontconfig.
> >
> > [1] https://chromium.googlesource.com/external/fontconfig/+log/b546940435ebfb0df575bc7a2350d1e913919c34..6cc99d6a82ad67d2f5eac887b28bca13c0dfddde
> > [2] https://chromium.googlesource.com/external/fontconfig/+/c60ed9ef66e59584f8b54323018e9e6c69925c7e
> > [3] https://chromium.googlesource.com/external/fontconfig/+/b8a225b3c3495942480377b7b3404710c70be914
> > [4] https://chromium.googlesource.com/external/fontconfig/+/7ad010e80bdf8e41303e322882ece908f5e04c74
> > [5] https://chromium.googlesource.com/external/fontconfig/+/096e8019be595c2224aaabf98da630ee917ee51c
> > [6] https://chromium.googlesource.com/external/fontconfig/+/6cc99d6a82ad67d2f5eac887b28bca13c0dfddde
> >
> > BUG=831146,822737,787020,829890,847323
> > TBR=thestig,dnicoara
> >
> > Change-Id: Ic2d1bd19af8ca131c960a30d09246827c115ccec
> > Reviewed-on: https://chromium-review.googlesource.com/1095538
> > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> > Reviewed-by: Lei Zhang <thestig@chromium.org>
> > Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#567445}
> 
> TBR=thestig,dnicoara
> 
> Bug: 831146, 822737, 787020, 829890, 847323, 853048
> Change-Id: Id42738aaf5841bd219dc0e9209680c87e88f4869
> Reviewed-on: https://chromium-review.googlesource.com/1104759
> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#568221}

TBR=thestig@chromium.org,robliao@chromium.org,dnicoara@chromium.org,thomasanderson@chromium.org

Change-Id: Icd39638df79083776546d4283675c3e172bbefe4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 831146, 822737, 787020, 829890, 847323, 853048
Reviewed-on: https://chromium-review.googlesource.com/1105539Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568346}

Bug: 844292
Change-Id: Ia88a69ae1eaf0598b5747d6ee57a537651a43c80
Reviewed-on: https://chromium-review.googlesource.com/1105209Reviewed-by: Sasha Morrissey <sashab@chromium.org>
Commit-Queue: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568345}

Redirects should have been already checked in the browser
beforehand and the right NavigationPolicy already determined.

Also cleanup unused DidReceiveServerRedirectForProvisionalLoad
callback.

Bug: 789577, 671276
Change-Id: I40421f36b57e85d731dc44914d8efe48e017fa91
Reviewed-on: https://chromium-review.googlesource.com/1103657Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568344}

MessageTransferOperation now uses the SecureChannelClient to request secure connections
to remote devices, instead of BleConnectionManager. This functionality is gated behind
the chromeos::features::kMultiDeviceApi.

This CL completely migrates Tether to the SecureChannel and DeviceSync services (besides
the feature flags gating their use, which will be removed in the next milestone).

Bug: 824568, 752273
Change-Id: I5689fd43e427a5140b6c05f5bbf659709fcb4139
Reviewed-on: https://chromium-review.googlesource.com/1105571
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568343}

https://skia.googlesource.com/skia.git/+log/63b3bfb711d7..5045e501d2ae


git log 63b3bfb711d7..5045e501d2ae --date=short --no-merges --format='%ad %ae %s'
2018-06-19 mtklein@google.com Revert "Change how vertex/instance attributes are handled in geometry processors."


Created with:
  gclient setdep -r src/third_party/skia@5045e501d2ae

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=kjlubick@chromium.org

Change-Id: I2dd1d66f0f2fd063b96db11b229effd067f5a949
Reviewed-on: https://chromium-review.googlesource.com/1105419Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#568342}

This patch starts creating execution contexts for iframes that didn't
commit initial successful loading. This is a common situation for
iframes which navigation was blocked due to mixed content.

R=dgozman
BUG=854051

Change-Id: Ia1c39af39c1c99f20e69abfae48579ac1bc09021
Reviewed-on: https://chromium-review.googlesource.com/1102154
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568341}

This method is unnecessary; if clients wish to disconnect a ClientChannel,
they simply need to delete the object.

Bug: 824568, 752273
Change-Id: I5ba7268743f8aabb208bc4add9ed849a982c7465
Reviewed-on: https://chromium-review.googlesource.com/1105609Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568340}

Bug: 848126
Change-Id: Ifd3cf1996fdb33f5d0d93f5c5cf721abd5440d29
Reviewed-on: https://chromium-review.googlesource.com/1102279Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568339}

TBR=alancutter@chromium.org
NOTRY=true

Bug: 854053
Change-Id: Ie4264d2c95790c028a3054a385975a8c49192ed0
Reviewed-on: https://chromium-review.googlesource.com/1105525Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568338}

We eventually want to get rid of the notion of content source ID in favor
of surface synchronization. In order to do this, we need to introduce an
explicit API to clear caches in cc.

This CL introduces LayerTreeHost::ClearCachesOnNextCommit API.

Bug: 672962
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ib78a5e7dde17f335c1e591032f7e01c1fa9213f9
Reviewed-on: https://chromium-review.googlesource.com/1105343Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568337}

Without this patch, shouldShowTeamDrives_ calls |callback| synchronously
when the --team-drives flag is disabled, and asynchronously if it is
enabled. The asynchronous call causes the navigation tree to updated
after the appropriate update methods are called, which causes undefined
behaviour.

This patch moves the check for Team Drives into an asynchronous function
called *after* the tree has been synchronously initialized, and simply
shows the element if the user has Team Drives (originally, it hid the
element, but this means the item may be visible for a split-second. To
fix this, it is added as a hidden element by default and then unhidden
after the check).

This also fixes the existing integration tests to work with the
--team-drives flag enabled.

Bug: 849497
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Ie8e174995ca8b16371f32e8ab780f45748fcc55e
Reviewed-on: https://chromium-review.googlesource.com/1103983
Commit-Queue: Sasha Morrissey <sashab@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568336}

Update the getDriveConnectionStatus() and getSizeStats()
implementations, the file manager EventRouter, and the test fake to
function correctly when only DriveFS is enabled. Also update the test
fakes to handle mount-relative absolute paths sent over mojo.

Bug: 844292, 848126
Change-Id: I6f98d6bb3d00a9fcc4b26cd1090c2fa06ecf33e3
Reviewed-on: https://chromium-review.googlesource.com/1102234Reviewed-by: Sasha Morrissey <sashab@chromium.org>
Commit-Queue: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568335}

After connecting to Cable authenticator using advertisement/scanning,
Cable protocol requires one more round trip of BLE control messages to
be sent to establish shared secret key for encryption. Add this
handshake protocol to FidoCableDiscovery.

Bug: 849307
Change-Id: I388fa43dae60e97e027dafa1f9f430a2569ca981
Reviewed-on: https://chromium-review.googlesource.com/1089794
Commit-Queue: Jun Choi <hongjunchoi@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568334}

Now also logging the offline_id.

TBR=johnchen@chromium.org

Bug: 852616
Change-Id: Ic28d9a59da5ff81b0da7b640044799fad4538b71
Reviewed-on: https://chromium-review.googlesource.com/1105566Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Commit-Queue: Carlos Knippschild <carlosk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568333}

With Declarative Net Request, there is no easy way for extensions to collapse
the DOM elements corresponding to the resources they blocked. This CL implements
the ability for the blocked <img> elements to be automatically collapsed in the
DOM. In subsequent CLs, similar function will be implemented for other DOM
elements.

To do this, following changes are made:
 - A new field called kCollapsedByClient is added to
   blink::ResourceRequestBlockedReason. Whenever an extension ruleset wants to
   collapse the DOM element corresponding to a network request, the
   extended_error_code is set to kCollapsedByClient, which is then used as a
   signal by the renderer to perform the collapsing.
 - Changes to blink::ResourceRequestBlockedReason also necessiate changes to the
   Devtools protocol. As a good side-effect, resources collapsed by extensions
   would be marked as "collapsed-by-client" by Devtools.
 - Changes are made to allow content embedders to set a
   blink::ResourceRequestBlockedReason for a request.

BUG=848842

Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I0bfd1a60bee79ef651741b7655fade6be4a7d419
Reviewed-on: https://chromium-review.googlesource.com/1088189
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568332}

Only the most recent notification will be shown.

Adding a few new components:
 - NotificationMenuController
   - Handles adding/removing the container MenuItemView to an app
     context menu, and passing notification data to
     NotificationMenuView.
 - NotificationMenuView
   - Handles showing NotificationItemViews, showing the proper
     notifications, and in the future showing the overflow area.
 - NotificationItemView
   - Shows basic notification data.
 - NotificationMenuHeaderView
   - Shows "Notifications" text and a counter showing the number
     of notifications.

Please see the design doc and spec, linked in the code review request.

Bug: 801015
Change-Id: I907794db5bcf90e5238773ca7cf9978d539b0855
Reviewed-on: https://chromium-review.googlesource.com/1095431
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568331}

This class declared its constructor and destructor but did not actually
implement them. This CL implements them.

Additionally, this CL adds a "destructor callback" as an optional
constructor parameter and invokes the callback in the destructor.

Bug: 824568, 752273
Change-Id: I0c60a0bc64ade3b55b926bc864c20c6ea4814d7b
Reviewed-on: https://chromium-review.googlesource.com/1105306
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568330}

Using OnceCallback+std::move would remove the necessity of
using base::ResetAndReturn.

Bug: None
Change-Id: I38a3d945f03ad5abc3d12f13b55c92b1b66d3860
Reviewed-on: https://chromium-review.googlesource.com/1105509Reviewed-by: Sam McNally <sammc@chromium.org>
Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568329}

Change ShortcutItem to set the 'label' attribute of an element, so that
the FolderShortcuts test can select these elements, with a TODO to
remove later. This is the fastest way to fix the integration tests to
work when team drives is enabled (and the IDs move around). This also
makes the tests robust against more directories being added to the top-
level tree.

Other approaches considered:

(1) Add a getIdForTreeElementWithName method to
    background/js/test_util.js. This doesn't work with waitForElement()
    since calling it beforehand fails immediately when the element
    doesn't exist. Adding a waitForElementInTreeWithName() could work,
    but you would need both methods, and adding waitFor*() methods is a
    bit tricky to write.
(2) Use :nth-child selectors. This doesn't work because shortcuts are
    added in alphabetical order, meaning new shortcuts added might
    invalidate previous selectors. So the selectors aren't static.
(3) Pass the expected index of the shortcut into each method call. This
    works for all methods except ones involving Drive, which use a
    slightly different selector. Also, for methods like
    removeShortcut(), it's impossible to tell whether the item has been
    removed (since all the elements shift up by 1, the shortcut at this
    index is now just the next shortcut in the list).
(4) Keep track of the shortcut state in the test, and predict the
    indexes based on that. This is harder to do, and requires a
    nontrivial test rewrite.

Bug: 849497
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Id26c559ea893491cf942b19a874fee29bde79534
Reviewed-on: https://chromium-review.googlesource.com/1103434Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Sasha Morrissey <sashab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568328}

This CL eliminates:
* disable-network-settings-config
* networkSettingsConfig
* NetworkConfigView and related unused classes

This also cleans up some stale comments and related interfaces.

Bug: 848090
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Id79b835f72b79694d7013cf19a17d553622f844b
Reviewed-on: https://chromium-review.googlesource.com/1102912
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568327}

* More consistent names
* Move initializers to .h
* Remove using directives

BUG=none
TEST=none

Change-Id: I52939db0418f50d3cef9c1ab92a04a79c326a9b9
Reviewed-on: https://chromium-review.googlesource.com/1094256Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568326}

This matches the behavior in ChromeNetworkDelegate.

Third party cookie handling has been moved from NetworkContext to
CookieManager.

Note: A lot of these files changed are removing the unnecessary
CookieOptions arg from a bunch of methods.


Bug: 789636, 789632
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I241cb396e588c433cf723c1effa8ea2c64f72266
Reviewed-on: https://chromium-review.googlesource.com/1100105
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568325}

We should explicitly close UnifiedSystemTray when the settings button is
clicked.

TEST=manual
BUG=853610

Change-Id: I029396b33a3bdde0d64e5b89a01c53ba38e72f96
Reviewed-on: https://chromium-review.googlesource.com/1103436Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568324}

We need to know the team_drive_id so that the FileChange observers can
add or remove team drive change list loaders.

Bug: 715355
Change-Id: Ie6185554c9a8b444913d1edb067530651b436a21
Reviewed-on: https://chromium-review.googlesource.com/1104625
Commit-Queue: Stuart Langley <slangley@chromium.org>
Reviewed-by: Sasha Morrissey <sashab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568323}

This is one step of "moving //device/geolocation into //services".

BUG=800659

Change-Id: I041329923b2cbedab1afd51cc865b278a6a1523a
Reviewed-on: https://chromium-review.googlesource.com/1100694Reviewed-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Ke He <ke.he@intel.com>
Cr-Commit-Position: refs/heads/master@{#568322}

Split the provider in order to support Vision Framework [1] which
recognizes barcode symbologies more than Core Image Framework.

Split original large CL[2] up in smaller subpatches including this CL.

[1] https://developer.apple.com/documentation/vision
[2] https://chromium-review.googlesource.com/c/chromium/src/+/1088466

BUG=848182

Change-Id: I1bc9f1d898e34a04d819db9f90bd88d725b3601e
Reviewed-on: https://chromium-review.googlesource.com/1088321Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Commit-Queue: Junwei Fu <junwei.fu@intel.com>
Cr-Commit-Position: refs/heads/master@{#568321}

This reverts commit 9a7643de.

Reason for revert: 

MediaRouterElementsBrowserTest.MediaRouterContainerFilterPart1 became
flaky in Mac10.11, 10.12, and 10.13 after this landed.

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=MediaRouterElementsBrowserTest.MediaRouterContainerFilterPart1

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/13846

[ RUN      ] MediaRouterElementsBrowserTest.MediaRouterContainerFilterPart1
[35158:6151:0618/184304.560701:WARNING:notification_platform_bridge_mac.mm(510)] AlertNotificationService: XPC connection invalidated.
[35158:775:0618/184305.696851:WARNING:CONSOLE(0)] "Styling master document from stylesheets defined in HTML Imports is deprecated. Please refer to https://goo.gl/EGXzpw for possible migration paths.", source:  (0)
[35158:775:0618/184306.249427:INFO:CONSOLE(1236)] "Running TestCase MediaRouterElementsBrowserTest.MAYBE_MediaRouterContainerFilterPart1", source: file:///b/s/w/ir/chrome/test/data/webui/test_api.js (1236)
[35158:775:0618/184306.545042:WARNING:CONSOLE(16)] "Invalid keyframe value for property marginBottom: 44", source: chrome://resources/polymer/v1_0/web-animations-js/web-animations-next-lite.min.js (16)
[35158:775:0618/184306.545170:WARNING:CONSOLE(16)] "Invalid keyframe value for property marginBottom: 44", source: chrome://resources/polymer/v1_0/web-animations-js/web-animations-next-lite.min.js (16)
[35158:775:0618/184306.602655:ERROR:CONSOLE(48)] "Mocha test failed: MediaRouterContainerFilterPart1 focus sink search input
Error: Script error. (:0)
", source: file:///b/s/w/ir/chrome/test/data/webui/mocha_adapter.js (48)
[35158:775:0618/184306.602796:ERROR:CONSOLE(206)] "Uncaught AssertionError: expected 'sink-list' to equal 'filter'", source: file:///b/s/w/ir/third_party/chaijs/chai.js (206)
[35158:775:0618/184306.688827:WARNING:CONSOLE(16)] "Invalid keyframe value for property marginBottom: 44", source: chrome://resources/polymer/v1_0/web-animations-js/web-animations-next-lite.min.js (16)
[35158:775:0618/184306.688978:WARNING:CONSOLE(16)] "Invalid keyframe value for property marginBottom: 44", source: chrome://resources/polymer/v1_0/web-animations-js/web-animations-next-lite.min.js (16)
[35158:775:0618/184306.878527:WARNING:CONSOLE(16)] "Invalid keyframe value for property marginBottom: 44", source: chrome://resources/polymer/v1_0/web-animations-js/web-animations-next-lite.min.js (16)
[35158:775:0618/184306.878646:WARNING:CONSOLE(16)] "Invalid keyframe value for property marginBottom: 44", source: chrome://resources/polymer/v1_0/web-animations-js/web-animations-next-lite.min.js (16)
[35158:775:0618/184307.420478:WARNING:CONSOLE(16)] "Invalid keyframe value for property marginBottom: 44", source: chrome://resources/polymer/v1_0/web-animations-js/web-animations-next-lite.min.js (16)
[35158:775:0618/184307.420605:WARNING:CONSOLE(16)] "Invalid keyframe value for property marginBottom: 44", source: chrome://resources/polymer/v1_0/web-animations-js/web-animations-next-lite.min.js (16)
[35158:775:0618/184308.705393:WARNING:CONSOLE(16)] "Invalid keyframe value for property marginBottom: 44", source: chrome://resources/polymer/v1_0/web-animations-js/web-animations-next-lite.min.js (16)
[35158:775:0618/184308.705526:WARNING:CONSOLE(16)] "Invalid keyframe value for property marginBottom: 44", source: chrome://resources/polymer/v1_0/web-animations-js/web-animations-next-lite.min.js (16)
[35158:775:0618/184308.710999:WARNING:CONSOLE(16)] "Invalid keyframe value for property marginBottom: 44", source: chrome://resources/polymer/v1_0/web-animations-js/web-animations-next-lite.min.js (16)
[35158:775:0618/184308.711145:WARNING:CONSOLE(16)] "Invalid keyframe value for property marginBottom: 44", source: chrome://resources/polymer/v1_0/web-animations-js/web-animations-next-lite.min.js (16)
[35158:775:0618/184308.845267:WARNING:CONSOLE(16)] "Invalid keyframe value for property marginBottom: 44", source: chrome://resources/polymer/v1_0/web-animations-js/web-animations-next-lite.min.js (16)
[35158:775:0618/184308.845353:WARNING:CONSOLE(16)] "Invalid keyframe value for property marginBottom: 44", source: chrome://resources/polymer/v1_0/web-animations-js/web-animations-next-lite.min.js (16)
[35158:775:0618/184308.850290:ERROR:web_ui_test_handler.cc(100)] Test Errors: 1/12 tests had failed assertions.

Original change's description:
> WebUI[MD-refresh]: replace most paper-input with cr-inputs
> 
> This CL replaces most paper-inputs with cr-inputs within the code-base.
> After this CL, the 3 places that still has paper-input remaining are:
> - chrome/browser/resources/chromeos/login/
> - chrome/browser/resources/pdf/
> - ui/file_manager/
> 
> There are planned follow-up CLs to replace paper-input in the above 3
> areas as well.
> 
> Bug: 832177
> Cq-Include-Trybots: luci.chromium.try:closure_compilation
> Change-Id: I7acc7e0a26a6bd3d40ec6828608717fd97bd0c73
> Reviewed-on: https://chromium-review.googlesource.com/1086357
> Commit-Queue: Scott Chen <scottchen@chromium.org>
> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#568241}

TBR=dpapad@chromium.org,scottchen@chromium.org

Change-Id: I1dd101893378c8354c48e72d9f56231ec1ee9850
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 832177
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Reviewed-on: https://chromium-review.googlesource.com/1105207Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568320}

This reverts commit 502b5a8a.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 568293 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzUwMmI1YThhM2I5YmNlOWYyYTVkY2E4M2NhMzRiMGM4YjExMTFlMDkM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/6372

Sample Failed Step: compile

Original change's description:
> [Fuchsia, ozone] Implement ScenicWindow
> 
> ScenicWindow now creates View and listens to input events (mouse and keyboard).
> 
> Bug: 829980
> Change-Id: If5d05bf1107fec553aecf2537fd197d177d2fbb1
> Reviewed-on: https://chromium-review.googlesource.com/1081609
> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
> Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: Wez <wez@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#568293}

Change-Id: I79c4bcd4615d058aa4080d01c9a3107ab8835bc3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 829980
Reviewed-on: https://chromium-review.googlesource.com/1105440
Cr-Commit-Position: refs/heads/master@{#568319}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=mmoss@chromium.org

Change-Id: I52a27cbd660bb0ee4dada66ffe1a7334911b5091
Reviewed-on: https://chromium-review.googlesource.com/1105521Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568318}

Bug: 838650
Change-Id: I9850ab16c61592bf46068c2948535ab9b95d843c
Reviewed-on: https://chromium-review.googlesource.com/1099566Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Andrew Luo <aluo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568317}