- 22 Sep, 2018 20 commits
-
-
Kevin Marshall authored
This addresses the current crashing bug that takes place whenever popup windows are spawned, due to the fact that no WindowParentingClient exists to handle the newly spawned ui::Window. With this solution, the child windows are never spawned in the first place. * Relocated 'content' overrides to FrameImpl's private declarations. * Misc. IWYU cleanups. Bug: 888131 Change-Id: I735565047bbe4c8ebab5154a57ad323f33ef8e48 Reviewed-on: https://chromium-review.googlesource.com/1239419 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#593402}
-
Tarun Bansal authored
The field trial is enabled for Android only. Change-Id: I6ddddf15369da72b91d1e90a9d02bc9d0d61eb27 Bug: 850624 Reviewed-on: https://chromium-review.googlesource.com/1239034Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#593401}
-
Philip Rogers authored
When working on another patch I noticed it is deadcode. Change-Id: I248b12e2f3a5e26af91d2cab89b5b8fd3ace8dd1 Reviewed-on: https://chromium-review.googlesource.com/1239539 Commit-Queue: Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#593400}
-
Pavel Feldman authored
Change-Id: Ie90437511d2eda4a5477abde80c083eeb6448db8 Reviewed-on: https://chromium-review.googlesource.com/1239248Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#593399}
-
Matt Menke authored
TCPBoundSocket now calls into TCPConnectedSocket's connect option, so that they can share connection establishment and socket configuration code. This increases code reuse and reduces code disting to TCPBoundSocket, which is also handy, as it's harder to test than TCPConnectedSocket. Also makes TCPBoundSocket take an AddressList instead of an IPEndPoint. Since it's now using TCPConnectedSocket's connect code, might as well reuse its ability to take a list of addresses to try. Bug: 848078 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I94059f08f649833db89676bde50ec8b11fbbb9b6 Reviewed-on: https://chromium-review.googlesource.com/1231740Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#593398}
-
Paul Miller authored
Fold AwFieldTrialCreator::DoSetUpFieldTrials into AwFieldTrialCreator::SetUpFieldTrials. The former is unnecessary since AwFieldTrialCreator no longer requires the client ID, so DoSetUpFieldTrials can no longer return early. BUG=866722 Change-Id: Ibcce988656cabe57ed142abb14efbb163e0b3fb6 Reviewed-on: https://chromium-review.googlesource.com/1238485Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Paul Miller <paulmiller@chromium.org> Cr-Commit-Position: refs/heads/master@{#593397}
-
Andrew Luo authored
Specifics: +674,152 bytes normalized apk size +3 zip entries file count +53,920 bytes main lib size +421,832 bytes main dex size InstallSize: +254,984 bytes APK size +1,959,185.28 bytes Estimated installed size InstallBreakdown (+1,958,241.28 bytes): +2,664 bytes unwind_cfi (dev and canary only) size +1,502 bytes Non-compiled Android resources size +53,920 bytes Native code size +178 bytes Package metadata size +1,885,301.28 bytes Java code size +14,676 bytes Compiled Android resources size Dex: +2,081 entries fields +2,853 entries methods +675 entries types +1,425 entries strings Diff Summary +674152 bytes Monochrome.apk_Specifics normalized apk size for range: b2ce31d0fc200fd29fe9ef96d7e15b10f95ece4b..d9d2b25c8c55dd48b53a78cd84006100a49d0d68 I 26177577 Enter supersize console via: tools/binary_size/supersize console out/binary-size-results/b2ce31d0fc200fd29fe9ef96d7e15b10f95ece4b/Monochrome.apk.size out/binary-size-results/d9d2b25c8c55dd48b53a78cd84006100a49d0d68/Monochrome.apk.size Change-Id: I3bf80e7bc3cab07a66d303af88cbd6060ffe8b18 Reviewed-on: https://chromium-review.googlesource.com/1238899 Commit-Queue: Andrew Luo <aluo@chromium.org> Reviewed-by:Gang Wu <gangwu@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#593396}
-
Ryan Sleevi authored
As captured in https://crbug.com/888133, the CNNIC CT Log has failed to meet the Chromium CT Log Policy requirements, and is disqualified effective 2018-09-18 00:00:00 UTC. Bug: 888133, 583208 Change-Id: I3b13b6df11eb27d1cd6835b95976d1a2fc450397 Reviewed-on: https://chromium-review.googlesource.com/1238786Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#593395}
-
rbpotter authored
Splitting out fixes for bugs from change to dropdown, in case we decide not to keep dropdown change. Addresses some focus issues, and removes use of auto-validate. Auto-validate does not work well for this section as some errors (e.g. out of range) cannot be caught by the auto validation. Having 2 different sets of logic for setting the input invalid (auto-validate + JS validation) causes some bugs. Bug: 887231, 886591, 886542, 885094, 886560 Change-Id: I053899718a735fa8bcc23df27d36b23d2c26e0b0 Reviewed-on: https://chromium-review.googlesource.com/1238868Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#593394}
-
Scott Violet authored
In order to support this the window-service gets Attach/UnattachFrameSinkId. BUG=881574 TEST=covered by tests Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I1bbf82170adf0e254eda8ffa7f1804d56495cb2a Reviewed-on: https://chromium-review.googlesource.com/1233174 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#593393}
-
Becky Zhou authored
Bug: 887614 Change-Id: I58bd8cf6ff9f6a59d52db2ef09fab9e0f0b48a66 Reviewed-on: https://chromium-review.googlesource.com/1239443 Commit-Queue: Becky Zhou <huayinz@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#593392}
-
Min Qin authored
If DownloadManagerService is launched without full browser, we need to call OnFullBrowserStarted() once full browser launches BUG=695115 Change-Id: Ibaabb72716305d674edadbd4659eb6a1bbb6cf63 Reviewed-on: https://chromium-review.googlesource.com/1185731Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#593391}
-
Xi Cheng authored
Bug: 886957 Change-Id: I4b0e5c25f5677c43c1818668bdd9aea6eb5b871e Reviewed-on: https://chromium-review.googlesource.com/1239414Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#593390}
-
Ted Meyer authored
There is a small number of crashes in m70 caused by video-only src= players being disabled when put in the background. The check for track count size in FFmpegDemuxer::OnSelectedVideoTrackChanged wasn't sufficient to ensure that the vector index lookup in SeekOnVideoTrackChange() would succede, as FindAndEnableProperTracks() can sometimes not find the tracks it's looking for. Bug: 887648 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I23f9457da5f67887f6e7b1a63699c9c7fa0107ed Reviewed-on: https://chromium-review.googlesource.com/1238994 Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#593389}
-
Bo Liu authored
Android may kill a service process before our setupConnection succeeds. This is unlikely but not impossible. Fix a few asserts and conditions that do not handle this correctly. Also add an integration test for this scenario. Change-Id: Ibc5c0155c31caf9b1f73aee169147516d2a0fffe Reviewed-on: https://chromium-review.googlesource.com/1237493 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Siddhartha S <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#593388}
-
Becky Zhou authored
Update search box on content changed because OnScrolled might not be called or the vertical offset might be be reliable. Bug: 887628 Change-Id: I429b817abd44f1a8e66b616dfad5f190f6fd8822 Reviewed-on: https://chromium-review.googlesource.com/1238619 Commit-Queue: Becky Zhou <huayinz@chromium.org> Reviewed-by:
-
Theresa authored
We're no longer experimenting with reverse scroll triggering, so remove support for: - reverse scroll triggering - slim peek - peek conditions (apart from delay, which we may use later) BUG=859292,876943,885331 Change-Id: Ibe962d6ece4340eb7b57784bbe078cc0847de728 Reviewed-on: https://chromium-review.googlesource.com/1236453Reviewed-by:
Becky Zhou <huayinz@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#593386}
-
Peter Kvitek authored
Change-Id: I24ab5f15756f8cd5ff9c15bab49daf1976426e13 Reviewed-on: https://chromium-review.googlesource.com/1237152 Commit-Queue: Peter Kvitek <kvitekp@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#593385}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/9d84ccbaf233..799da6d18c5a git log 9d84ccbaf233..799da6d18c5a --date=short --no-merges --format='%ad %ae %s' 2018-09-21 geofflang@chromium.org Revert "D3D11: Resolve multisampled EGL surfaces at eglSwapBuffers" Created with: gclient setdep -r src/third_party/angle@799da6d18c5a The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:887403 TBR=jmadill@chromium.org Change-Id: Id6dc114ffbf56dbe6d5937ef47bfe188011b51d7 Reviewed-on: https://chromium-review.googlesource.com/1239474Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#593384}
-
Chris Lu authored
Late addition to the docs: https://github.com/material-components/material-components-ios/tree/develop/components/AppBar#migration-guide-mdcappbar-to-mdcappbarviewcontroller Bug: 874471 Change-Id: Ic8605f56a60f5deeaf316a88a8291540364604c1 Reviewed-on: https://chromium-review.googlesource.com/1239445Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#593383}
-
- 21 Sep, 2018 20 commits
-
-
Manu Cornet authored
Bug: 864701 Change-Id: I32134d30e1592926bd812f51083ad959649d056d Reviewed-on: https://chromium-review.googlesource.com/1238074Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#593382}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fd14ee29e129..0d9c87bf4dc0 Created with: gclient setdep -r src-internal@0d9c87bf4dc0 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I7456e6a06f9c90e494e9bc9af74da2167f363031 Reviewed-on: https://chromium-review.googlesource.com/1239473Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#593381}
-
Brandon Wylie authored
Change-Id: Ic82b2f89b7b7e02566ca2b4e2605b52cd2adcb03 Reviewed-on: https://chromium-review.googlesource.com/1234774Reviewed-by:
-
Vladimir Levin authored
There's only one call site, so this patch inlines it so it's more clear which functions mark the parent chain. R=chrishtr@chromium.org, pdr@chromium.org, wangxianzhu@chromium.org Change-Id: I367f4ffd2dfaf07ddf98a03ea247fb69d6e387b4 Reviewed-on: https://chromium-review.googlesource.com/1239263 Commit-Queue: vmpstr <vmpstr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
-
Kyle Horimoto authored
The MultiDevice setup flow uses several HTML/JS resources to render the setup flow dialog. Previously, these files were added directly to the data source for chrome://multidevice-setup. Now that this UI is being shared between both chrome://multidevice-setup and chrome://oobe, the resources are moved to a shared location; namely, //ui/webui/resources/cr_components/chromeos/multidevice_setup. They are now served from chrome://resources/cr_components/chromeos/multidevice_setup/*. Bug: 884041 Change-Id: Ia69c27875a9d3600006c4220f498acc5a2aef7be Reviewed-on: https://chromium-review.googlesource.com/1232334 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#593378}
-
Martin Robinson authored
This currently requires an o(n) walk through the list of hyperlinks, but a future rework of AXHypertext can fix this issue. Since this change requires adding a C++ class member to AXAtkHyperlink, we give it a private section and initialize it with placement new. This also requires us to call the destructor manually during GObject finalization. Bug: 866337 Change-Id: Ib0902268ff8a9da3750649dc7f4de8782d5fd893 Reviewed-on: https://chromium-review.googlesource.com/1238500Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#593377}
-
chrome://resourcesKyle Horimoto authored
The MultiDevice setup flow utilizes four Mojo JS files: time.mojom.js, device_sync.mojom.js, multidevice_setup.mojom.js, and multidevice_setup_constants.mojom.js. Previously, these files were added directly to the data source for chrome://multidevice-setup. Now that this UI is being shared between both chrome://multidevice-setup and chrome://oobe, the resources are moved to a shared location; namely, chrome://resources/js/*. Bug: 884048 Change-Id: Iea5806dc526482bf7c8904ad71512267055d48c7 Reviewed-on: https://chromium-review.googlesource.com/1231920Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
-
Siddhartha authored
In the current profiler, if a single sample takes too long then the sampling tasks get crowded and stops the main thread from running for a long time. But usually the slowest part is the stack copying for which the main thread is paused anyway. So, it is ok to take next sample after the interval time after previous sample completes, instead of strictly sampling every interval. BUG=859260 Change-Id: Ib0671b1f465f5cf98caa01aeac615648b24a1cf4 Reviewed-on: https://chromium-review.googlesource.com/1234841 Commit-Queue: Siddhartha S <ssid@chromium.org> Reviewed-by:
Xi Cheng <chengx@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#593375}
-
Dale Curtis authored
This is another core component of media, we should have trace events to help diagnose issues in the field. This adds the following traces: - (Chunk|FFmpeg)Demuxer::Initialize - (Chunk|FFmpeg)Demuxer::Seek - (AudioBuffer|VideoFrame)Stream::(Decode|Read|ReadFromDemuxerStream) - VideoFrameStream::Prepare (for audio too, but never prepares) This also renames the DecoderStream<AUDIO>, DecoderStream<VIDEO> traces to use the normal names AudioBufferStream, VideoFrameStream. BUG=879970 TEST=none R=wolenetz, xhwang Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ie9ca7474bc5684117820b219012f0455d044eabc Reviewed-on: https://chromium-review.googlesource.com/1237573 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#593374}
-
Kai Ninomiya authored
The argument to run_gpu_integration_test_as_googletest.py --isolated-script-test-filter is in the format group.group.TEST1::group.group.TEST2 while the argument to run_gpu_integration_test.py --test-filter is a regex. run_gpu_integration_test_as_googletest.py generates a regex like this: (group.group.TEST1|group.group.TEST2) but we want it to generate (TEST1|TEST2) . Test: vpython testing/scripts/run_gpu_integration_test_as_googletest.py --isolated-script-test-output= --isolated-script-test-filter=gpu_tests.webgl_conformance_integration_test.WebGLConformanceIntegrationTest.WebglExtension_WEBGL_depth_texture::gpu_tests.webgl_conformance_integration_test.WebGLConformanceIntegrationTest.WebglExtension_WEBGL_draw_buffers content/test/gpu/run_gpu_integration_test.py webgl_conformance -l This should print: gpu_tests.webgl_conformance_integration_test.WebGLConformanceIntegrationTest.WebglExtension_WEBGL_depth_texture gpu_tests.webgl_conformance_integration_test.WebGLConformanceIntegrationTest.WebglExtension_WEBGL_draw_buffers rather than printing nothing. Bug: 883308 Change-Id: I5ab941705a540f431094ac97b023fee4151341b1 Reviewed-on: https://chromium-review.googlesource.com/1236292Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#593373}
-
Dan Harrington authored
On touch devices, it was impossible to tap the download button on the dino page after playing the dino game (without reloading the page). This is now fixed. Bug: 886603 Change-Id: I61d572850cd5cefa81e667369352c997c1fdac57 Reviewed-on: https://chromium-review.googlesource.com/1234018Reviewed-by:
Edward Jung <edwardjung@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#593372}
-
Min Qin authored
with https://chromium-review.googlesource.com/c/chromium/src/+/1204926, the global local state can now be constructed without BrowserProcessImpl. And it will be passed to BrowserProcessImpl when the latter is created. This CL changes the SystemNetworkContextManager to take a local state param in its ctor, so that it can be created without g_browser_process. BUG=866028 Change-Id: I3cc5260f45fffdf515f8fa3da6424bd6b39dacb8 Reviewed-on: https://chromium-review.googlesource.com/1235290 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#593371}
-
Lei Zhang authored
r589875 tried but failed due to a typo. BUG=882213 TBR=battre@chromium.org,rdevlin.cronin@chromium.org Change-Id: I9a9deb8e406edf32ec22ece3c74e6c1fa42dd0c1 Reviewed-on: https://chromium-review.googlesource.com/1239007Reviewed-by:
-
Vladimir Levin authored
This patch introduces the above function in an effort to do fewer invalidations if only a descendant needs an update instead of self. Fixes up two call sites: - Unnecessary selection rect on a layout replaced - Missing dirty bit on table section overflow changes This also cleans up SetNeedsPaintPropertyTreeUpdate a bit. R=pdr@chromium.org, chrishtr@chromium.org, wangxianzhu@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ib1bdd8b08bf21f69f9ae17a85d12592a689a6c11 Reviewed-on: https://chromium-review.googlesource.com/1237246 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#593369}
-
Dmitry Gozman authored
We don't need these anymore, since we handle initiator on the browser side already. Bug: none Change-Id: I22203de6b20319fa4bab11bbe3eda82013744fa7 Reviewed-on: https://chromium-review.googlesource.com/1239421Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/92df4e63abbe..0dc1fa046374 git log 92df4e63abbe..0dc1fa046374 --date=short --no-merges --format='%ad %ae %s' 2018-09-21 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@0dc1fa046374 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Ibe604e0221d5ba50ccf681d3688374f0d1b86a6d Reviewed-on: https://chromium-review.googlesource.com/1238864Reviewed-by:
-
Ella Ge authored
This CL turns on zoom-for-dsf on M71 And also fix a webview unittest that doesn't count dsf. And rebaseline pixel tests.(difference see: http://chromium-browser-gpu-tests.commondatastorage.googleapis.com/view_test_results.html?2082aa2352cae2409ea1f102c52d7daa53daa13a_android_marshmallow_arm64_rel_telemetry) Bug: 737777 TBR: avi@chromium.org (feature flag) Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I4f3c56101333a0bfdbcb353fe1841fa01a8e082a Reviewed-on: https://chromium-review.googlesource.com/1234014 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#593366}
-
James Cook authored
It's only used in ash code. It also has aura dependencies, which is unexpected for general-purpose views code (which supports non-aura Views on Mac). This makes it easier to find when we audit code in ash for mustash. Bug: 887780 Test: ash_unittests Change-Id: I0380d94f695ac747475f3e7527059d7f8e597041 Reviewed-on: https://chromium-review.googlesource.com/1238545Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
-
Min Qin authored
This CL adds implementation of OfflineItemModel. Some of the common functionalities between OfflineItemModel and DownloadItemModel are moved to DownloadUIModel. Bug: 881499 Change-Id: Ic2e4835f4eb16422f152d0ed641dba3e9646defb Reviewed-on: https://chromium-review.googlesource.com/1239334 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#593364}
-
Fady Samuel authored
Bug: none Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I76d7a947196be09cdffc45dc3fd86b9f5a5b17aa Reviewed-on: https://chromium-review.googlesource.com/1239415Reviewed-by:
Saman Sami <samans@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#593363}
-
