- 20 Sep, 2018 40 commits
-
-
Zach Helfinstein authored
Bug: 864796 Change-Id: Ic975c0b63742476415a995e74a351e746908468f Reviewed-on: https://chromium-review.googlesource.com/1231741Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Zach Helfinstein <zhelfins@chromium.org> Cr-Commit-Position: refs/heads/master@{#592988}
-
Wenzhao Zang authored
Works for both tabbing and reverse tabbing. Chromevox announces "Time's up" and "Come back at xxx" separately. Bug: 870459 Change-Id: Icdf76ba4a24ba3a2de48dfea7e2698ea7df4c114 Reviewed-on: https://chromium-review.googlesource.com/1228482 Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#592987}
-
Peter Kotwicz authored
This CL introduces NewSplashWebApk.apk The logic for displaying the splash screen earlier will be implemented in NewSplashWebApk.apk Once everything is ready we will switch the server over. This CL also refactors WebappSplashScreenController in order to share code with NewSplashWebApk.apk Design doc: https://docs.google.com/document/d/1ZvpZPAIxLl_ElyMWOkDybOhCFzYk0Di4WgpLVSJdEu8/edit?usp=sharing BUG=817263 Change-Id: Id0561eede51fa7c2d293b321cfdcae755f1e03cf Reviewed-on: https://chromium-review.googlesource.com/1201348 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#592986}
-
rbpotter authored
Default ripple size of 40px is 2px larger than the desired height for a print preview settings section/row of settings section. Reduce ripple size to match this limitation. For copies' collate box, remove unnecessary margin that caused the number input to shift when the checkbox appeared. Also reduce the default size for number inputs, since neither should exceed 3 digits, and ensure the inline margin is always large enough for the ripple regardless of font size. Bug: 885013, 885026, 886551 Change-Id: I29b8316b9f49e24ffcb020085ef9bc3cdb6e0ec9 Reviewed-on: https://chromium-review.googlesource.com/1235204Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#592985}
-
rbpotter authored
Bug: 887397, 886663, 886908 Change-Id: I904a9c647c676185ce98faecd16cf815bff10e5f Reviewed-on: https://chromium-review.googlesource.com/1236839Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#592984}
-
Chong Zhang authored
ChromeBrowserMainBrowserTest.VariationsServiceStartsRequestOnNetworkChange was renamed and started failing since: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mojo%20ChromiumOS/35102 TBR=jam@chromium.org Bug: 882610 Change-Id: I7caef8a59d7447d8d2420c6cff13f93e68311c1b Reviewed-on: https://chromium-review.googlesource.com/1236284Reviewed-by:
Chong Zhang <chongz@chromium.org> Commit-Queue: Chong Zhang <chongz@chromium.org> Cr-Commit-Position: refs/heads/master@{#592983}
-
Dirk Pranke authored
We don't actually have much (if any) documentation on how we do the proper generation of credits and display licenses in Chrome; this CL attempts to fill the gap. TBR=jbudorick@chromium.org Change-Id: I99c76055784475de436bef3628a0c4b191bc953a Reviewed-on: https://chromium-review.googlesource.com/1162964 Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#592982}
-
Xiyuan Xia authored
These seems to be flaky in content_browsertests in single process mash mode. Bug: 874089, 887711 Change-Id: Iee0aeb5ed0c502c692eade56dfd4ae8f3248137d Reviewed-on: https://chromium-review.googlesource.com/1237377Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#592981}
-
Tommy Steimel authored
This CL removes the doubletap handling logic out of the overlay play button and onto MediaControlsImpl. This allows us to shrink the overlay play button down to only be the clickable area for play/pause, simplifying the event handling logic and removing zoom calculations that were crashing. As a side effect, this CL also fixes an issue where the user couldn't doubletap to fast-forward/rewind without first showing the controls. Bug: 884770, 827535 Change-Id: Ic5ff2b911d631bb10d10ac60a3b2e199ac2c3b01 Reviewed-on: https://chromium-review.googlesource.com/1235326Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#592980}
-
rbpotter authored
Fixing 2 bugs: (1) When "More settings" is expanded, margin should be 16px (2) Make links actionable so hand pointer shows up Bug: 887071, 887228 Change-Id: Iccb185f7e75e6a6fd87eac45b9b0a9f21dae15ca Reviewed-on: https://chromium-review.googlesource.com/1236501Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#592979}
-
Manu Cornet authored
Delegate the decision to blur the shelf to the shelf layout manager, and do not blur it unless there is an active session (e.g. login screen). Cache whether the background is currently blurred to avoid unnecessary updates. Bug: 883558 Change-Id: I6bc881f8133a0363260f88efd4225fb072009fc0 Reviewed-on: https://chromium-review.googlesource.com/1227813Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#592978}
-
Dale Curtis authored
BUG=778245 TEST=none TBR=xhwang Change-Id: Ib27cef70fe4519678dfc4b0446ee4c734c31225a Reviewed-on: https://chromium-review.googlesource.com/1237265Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#592977}
-
Mathieu Perreault authored
Also, adding gogerald@ to components/payments OWNERS Bug: None Change-Id: Id20aa0198de1363d640ddddf2438155717a82eba Reviewed-on: https://chromium-review.googlesource.com/1236233Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#592976}
-
Benjamin Ackerman authored
The test passes locally and on the trybots now. Bug: 163097 Change-Id: I0d7207a2548a568c33241d30ed1bbd7ea2cb4d6a Reviewed-on: https://chromium-review.googlesource.com/1236922Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Benjamin Ackerman <ackermanb@chromium.org> Cr-Commit-Position: refs/heads/master@{#592975}
-
Yves Arrouye authored
Both emaxx@ and drcrash@ at this time ar the only people working on this code and familiar with it. Other owners have moved on or are not available, and we end up in reviews like for CL:1234373 where upstream owners declare themselves incompetent to review. BUG=None TEST=None Change-Id: I3913bc9692a2668bab599eb0f08fc11b8457adc6 Reviewed-on: https://chromium-review.googlesource.com/1237251Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yves Arrouye <drcrash@chromium.org> Cr-Commit-Position: refs/heads/master@{#592974}
-
Darren Shen authored
We move the recording of InputMethod.VirtualKeyboard.ContainerBehavior to the end of ShowKeyboard, so we get a sample every time a floating or docked keyboard is shown. We also account for users switching between the two modes, as switching requires hiding and showing the virtual keyboard. See the bug for more about why this is needed. Bug: 887248 Change-Id: Icd8b2fbf826a0dba7b32cabb6c7b9afcdde3fcdd Reviewed-on: https://chromium-review.googlesource.com/1235266Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#592973}
-
Jeffrey Kardatzke authored
BUG=chromium:849438 TEST=tast run vm.CrostiniStartEverything Change-Id: I51963c9f4fe7b5aa9fd42e2c040410a974376f58 Reviewed-on: https://chromium-review.googlesource.com/1235199Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Cr-Commit-Position: refs/heads/master@{#592972}
-
Paul Miller authored
It's been unused since commit a5febff9 and null since 6bd4db44. BUG=546754 Change-Id: Idbffc047f67d3c424a2d6557e50dac8be9d9cee4 Reviewed-on: https://chromium-review.googlesource.com/1236695Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Paul Miller <paulmiller@chromium.org> Cr-Commit-Position: refs/heads/master@{#592971}
-
Matt Falkenhagen authored
It was just not added earlier as an oversight. Shipping this feature would affect android webview. Bug: 881225 Change-Id: Ib101582496db28bbd23239ce71abd547faadcf22 Reviewed-on: https://chromium-review.googlesource.com/1235474Reviewed-by:
Robert Kaplow (sloooow) <rkaplow@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#592970}
-
Jacob Dufault authored
See the bug for more details. Bug: 887070 Change-Id: I4218ffc18f64462c79be31d453d5198003c5d540 Reviewed-on: https://chromium-review.googlesource.com/1235124Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#592969}
-
Dominic Mazzoni authored
This reverts commit 8cca7c63. Reason for revert: We deliberately added a browser crash, enabling us to catch an important bug. Revert this to eliminate the browser crash and re-enable code to reset the renderer when it gets in a bad state (now much less often). Original change's description: > Add crash logging for accessibility unserialization error > > TBR=dtseng@chromium.org > > Bug: 870661 > Change-Id: If82429da90259c3af73c4fa424d3bba5e6a09a00 > Reviewed-on: https://chromium-review.googlesource.com/1174862 > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#583175} TBR=dmazzoni@chromium.org,dtseng@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 870661, 884934 Change-Id: I5329cd8b306c705e85b26acb8a9b35fcdfbcd426 Reviewed-on: https://chromium-review.googlesource.com/1234261 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#592968}
-
Andrei Pascovici authored
Bug: 886594 Change-Id: Ief40291ee0d4ce308efeb887af36eae97f3df164 Reviewed-on: https://chromium-review.googlesource.com/1236929Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Andrei Pascovici <apascovici@chromium.org> Cr-Commit-Position: refs/heads/master@{#592967}
-
yiyix authored
Enabling FrameMetrics caused 5-20% regression on rendering. (ref: https://bugs.chromium.org/p/chromium/issues/detail?id=876709). The FrameMetrics reports back to Tracing for each CompositorFrame submission with the following data: https://docs.google.com/document/d/1P1OKg3s5V2TwE8nTxLay01rn6JmpLgKDY00myyDuINs/edit?usp=sharing Reporting stats summary for each frame is not very interesting, So I reduced the frequency of FrameMetrics reporting to each second. Bug: 881863, 880560 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I96ce7d5bed824aa8d86fa00311136362081df019 Reviewed-on: https://chromium-review.googlesource.com/1226012Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#592966}
-
CJ DiMeglio authored
Bug: 884589 Change-Id: Id7a1b04a2b533584637f0fee425144acb0b8d79a Reviewed-on: https://chromium-review.googlesource.com/1237236Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> Cr-Commit-Position: refs/heads/master@{#592965}
-
Kenneth Russell authored
https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/7ca87fb..6d2f3f4 Tbr: kainino@chromium.org Bug: 563816, 878545 Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_angle_rel_ng;luci.chromium.try:win_angle_rel_ng Change-Id: I8c8b57fef830f85f26b231a6a22576d8f9159e0f Reviewed-on: https://chromium-review.googlesource.com/1225605Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#592964}
-
Patrick Monette authored
This will simplify future refactoring where QuarantineFile() is moved to an OOP service but not IsFileQuarantined(). This CL includes no functional change. Bug: 870998 Change-Id: Ic30bf70b119e37de88baa374a4791678df80d393 Reviewed-on: https://chromium-review.googlesource.com/1228782Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#592963}
-
Ben Kelly authored
R=jsbell@chromium.org, rkaplow@chromium.org Bug: 886898 Change-Id: I7519c327419c81b5eeb9dd83ac17850114a3795f Reviewed-on: https://chromium-review.googlesource.com/1234636 Commit-Queue: Ben Kelly <wanderview@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
Robert Kaplow (sloooow) <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#592962}
-
Dave Gash authored
Update declarative_content.json docs for minor language and formatting Bug: none Change-Id: I254f52f83b42844559da1277070e53ba060153c0 Reviewed-on: https://chromium-review.googlesource.com/1225859Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Meggin Kearney <mkearney@chromium.org> Cr-Commit-Position: refs/heads/master@{#592961}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7b11354810a9..268707284dcd git log 7b11354810a9..268707284dcd --date=short --no-merges --format='%ad %ae %s' 2018-09-20 fmalita@chromium.org [skottie] GM exercising external font loading 2018-09-20 mtklein@google.com send SkPMColor::toPMColor() through Sk4f_toL32() 2018-09-20 robertphillips@google.com Disable LCD text when drawing SkPictureImageFilter content 2018-09-20 brianosman@google.com Always use portable fonts in image filter test 2018-09-20 mtklein@google.com add interp-in-premul case to GM 2018-09-20 jvanverth@google.com Add new PolyUtils benches 2018-09-20 halcanary@google.com SkDocument: Factories now located in SkPDFDocument.h and SkXPSDocument.h 2018-09-20 halcanary@google.com SkPDF: draw persepctive rectangles 2018-09-20 brianosman@google.com Some SkPM4f cleanup 2018-09-20 bungeman@google.com Remove SkAutoTCallIProc. 2018-09-20 mtklein@google.com have SkConvertPixels use SkColorSpaceXformSteps 2018-09-20 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 d511948b9f82..52ea49706fd7 (1 commits) 2018-09-20 brianosman@google.com Fix/simplify equal_pixels 2018-09-20 halcanary@google.com Document headers: IWYU 2018-09-20 jcgregorio@google.com Use new build targets in continuous build of skottie and debugger. 2018-09-20 brianosman@google.com Remove (unused) GrBlend.cpp, and some GrColor helpers Created with: gclient setdep -r src/third_party/skia@268707284dcd The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:878874,chromium:884150 TBR=reed@chromium.org Change-Id: Ic7fa8bc7070238dfbb1d7c014446989ed87ecfaa Reviewed-on: https://chromium-review.googlesource.com/1236881Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592960}
-
Alex Oldemeier authored
Add a user policy for Crostini usage logging which is disabled by default. If this policy is active, log a time window for the last app launch and the used Termina version in prefs. Report these in DeviceStatusCollector. Bug: 844468, 883634 Test: Run unit and browser tests. Change-Id: I90ba296c9284b987829f8907283873c8213fad9f Reviewed-on: https://chromium-review.googlesource.com/1221947 Commit-Queue: Alex Oldemeier <aoldemeier@chromium.org> Reviewed-by:
Bartosz Fabianowski <bartfab@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#592959}
-
mrefaat authored
The problem is we discard the last committed item, if the request was blocked, instead we should only discard that when the last item was not native view. Bug: 881690 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I3de1649da8a4d1c198c7f5386cfeb2ef3608033a Reviewed-on: https://chromium-review.googlesource.com/1234953 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#592958}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d8dcf93795bb..b20563f5defb Created with: gclient setdep -r src-internal@b20563f5defb The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Id355f77748012995e160a11e54d4a93a10657a4c Reviewed-on: https://chromium-review.googlesource.com/1236484Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592957}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/3d81f7cc222b..b0768af22643 git log 3d81f7cc222b..b0768af22643 --date=short --no-merges --format='%ad %ae %s' 2018-09-20 benjhayden@chromium.org Fix /api/report/template 2018-09-20 bsheedy@chromium.org Add force commit to SharedPrefs 2018-09-20 wangge@google.com Add function to run benchmark both locally and on swarming. Created with: gclient setdep -r src/third_party/catapult@b0768af22643 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:887579,chromium:863390 TBR=sullivan@chromium.org Change-Id: I0052555ff9d1cd652448e2b3af79e37681de72e0 Reviewed-on: https://chromium-review.googlesource.com/1236883Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#592956}
-
Gina Ko authored
Bug: internal b/115749837 Change-Id: I4f0b21097081415956f1b386f68916b50fd8de82 Reviewed-on: https://chromium-review.googlesource.com/1235289 Commit-Queue: Yi-Chun Gina Ko <yichunko@google.com> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#592955}
-
John Budorick authored
Bug: 794372 Change-Id: I6b6d81ab0c72fd1b781d03e242f78ddef24fef95 Reviewed-on: https://chromium-review.googlesource.com/1235015Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#592954}
-
Jun Mukai authored
LoginCursorTest.CursorHidden and OobeTest.Accelerator are still crashing even after the refactoring of UIControls and aura::Env. Actually, these tests do not require browser windows therefore UIControlsOzone is created with nullptr WindowTreeHost which is not expected. Thinking about that, such test cases actually do controls for the UI within Ash -- therefore AshUIControls should be used. Test: interactive_ui_tests with --enable-features=SingleProcessMash Bug: 883523 Change-Id: I3d6e1ecb569551a7eacfce979c4b543771f19fc6 Reviewed-on: https://chromium-review.googlesource.com/1236842Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#592953}
-
Christian Biesinger authored
Now that constraint spaces are stack allocated, there's no point in having the builder be separate from the constructor. We can avoid some duplication and just directly initialize the members from the builder. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I5470a1be7e0f6e82f93af3fa263cc642e1d8cfbe Reviewed-on: https://chromium-review.googlesource.com/1235216 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#592952}
-
Mark Pearson authored
I think this codifies the results of our discussion. Is this the right place to put this content? Do I need reminders of it elsewhere (i.e., in the status or owners sections)? Change-Id: Icfeb6551515727f02d0cb83450008ad77ed0275d Reviewed-on: https://chromium-review.googlesource.com/1232523Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#592951}
-
Gang Wu authored
Enable content and journal storage in FeedProcessScopeFactory.java. Also fix type mismatch issue in Journal bridge, and handle empty content mutation case. Bug: 887116 Change-Id: I9333beb9141aab7a96e87d90baa8bef788b0b5e4 Reviewed-on: https://chromium-review.googlesource.com/1234263Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#592950}
-
Lan Wei authored
Add NoHoverAfterLayoutChange to base::Feature, so that we can run finch experiment on this feature to see if there is any performance improvement. Bug: 877132 Change-Id: Id1048757f7f48bc1be68787347d5594644b9ac38 Reviewed-on: https://chromium-review.googlesource.com/1234036Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#592949}
-