GitLab

This CL updates a DCHECK to allow for the BrowserNonClientFrameView
getting recreated when the browser window frame is updated via
NonClientView::UpdateFrame().

This also fixes a UI bug where we don't initialise the content setting
icons properly for PWA windows resulting in uninitialised state after
toggling GTK themes.

Before: https://bugs.chromium.org/p/chromium/issues/attachment?aid=365396&signed_aid=Z-gwLwzrT9I5krg3sUoY7Q==&inline=1
After (ignore Linux screen glitching): https://bugs.chromium.org/p/chromium/issues/attachment?aid=365397&signed_aid=e_kvzb_AGaLLi5zzKY_o7w==&inline=1


Bug: 878639
Change-Id: I57bd1a6f7f94687a0f95557914f34eda737129ee
Reviewed-on: https://chromium-review.googlesource.com/c/1308960Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604452}

Bug: None
Change-Id: I2918bedb89b3f8682d7fa5d5fdfabab06f6d56bb
Reviewed-on: https://chromium-review.googlesource.com/c/1311873
Commit-Queue: Kyle Milka <kmilka@chromium.org>
Reviewed-by: Ramya Nagarajan <ramyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604451}

Previously, each the following was treated the same:
  Content-Length: 7
  Content-Length: ,7
  Content-Length: 7,
  Content-Length: , ,7, ,

And all condensed into a single header with a value of 7. There's
nothing in any spec that instructs us to do this. Moreover, the spec
explicitly states that the two lines:

  Content-Length: 7
  Content-Length:

Can be safely merged into:

  Content-Length: 7,

Without changing meaning, but in the former case, Chrome treats two
headers lines as if they were separate header lines, while in the
latter, as mentioned, it ignores the existence of the comma. Also,
the original header line could never be retrieved in this case,
since the extra information was just silently purged.

This CL treats both responses as having two separate Content-Length
headers (And this applies to all other non-coalescing headers as
well).  This behavior seems to match that of all other browsers, so
breakages should be minimal.

Bug: 896233
Change-Id: I1acb26a3face0eef8d47c1dbe727aab5ec7dd7bd
Reviewed-on: https://chromium-review.googlesource.com/c/1297251
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Asanka Herath <asanka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604450}

This changes SyntheticGestureTargetAura to have an aura::EventInjector
rather than constantly creating one. In mash, EventInjector sends
events to the window service for dispatch. EventInjector establishes the
connection as necessary, but as SyntheticGestureTargetAura continually
recreates EventInjector the connection must be brough up (and destroyed) for
each event. This is non-trivially and adds unnecessary latency to perf
tests.

BUG=none
TEST=none

Change-Id: I22cc6ffe37808586ccd8904b75637e14f2532aea
Reviewed-on: https://chromium-review.googlesource.com/c/1311536Reviewed-by: Jun Mukai <mukai@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604449}

Breaks out the use of GetColorWithMinimumContrast for bookmarks-bar
items to a separate function and makes sure all callers use that
instead of directly fetching COLOR_BOOKMARK_TEXT.

In practice this fixes the two items themes that don't specify good
contrasting colors for COLOR_BOOKMARK_TEXT. This also probably makes
the folder icon prettier on Mac in the same case as it uses a more
contrasting white.

Bug: None
Change-Id: Ief016b9bbd45991b2a357055c112704fc7f60097
Reviewed-on: https://chromium-review.googlesource.com/c/1311660Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604448}

This reverts commit 477fd905.

Reason for revert: I had already reverted that CLs that had caused flakiness to MSAN, it just takes a while for MSAN to pickup changes. It eventually picked up in this run:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20ChromiumOS%20MSan%20Tests/9366

Bug: 899664

Original change's description:
> Disable a few more FilesAppBrowserTest on MSan
> 
> Disable
>   CreateNewFolder/FilesAppBrowserTest.Test/selectCreateFolderDownloads_GuestMode
>   KeyboardOperations/FilesAppBrowserTest.Test/renameNewFolderDownloads_GuestMode
>   KeyboardOperations/FilesAppBrowserTest.Test/keyboardDeleteFolderDownloads_GuestMode
> due to flakiness under MSan.
> 
> TBR=lucmult@chromium.org
> 
> Bug: 899664
> Change-Id: Ic39f71f6b07999ca39a6d58f6674d32ab002739c
> Reviewed-on: https://chromium-review.googlesource.com/c/1310502
> Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#604332}

TBR=xiyuan@chromium.org,lucmult@chromium.org

Change-Id: I1bb7400826d3143641d97d8eaaf44b69ccd4e6b1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 899664
Reviewed-on: https://chromium-review.googlesource.com/c/1312013Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604447}

We failed to abstract away the types with capabilities, so
I am bringing the type back in preparation of removing
service/shadow workers shadow page target.

Bug: 882467
Change-Id: I480bb18b1cfa9cf79e83435d735d102711991562
Reviewed-on: https://chromium-review.googlesource.com/c/1310759Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604446}

TBR=sky@chromium.org
BUG=895574

Change-Id: I78f2afbc465d27d26f9c9f27cfdac597b43dd944
Reviewed-on: https://chromium-review.googlesource.com/c/1311693Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604445}

Bug: 900413
Change-Id: I58da79246fb029656af59877b43b9743e893d3d0
Reviewed-on: https://chromium-review.googlesource.com/c/1311654Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604444}

Change-Id: Ia8c8f5bda50d31f70101e4247dcb606b28da7676
Reviewed-on: https://chromium-review.googlesource.com/c/1310568Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: ssid <ssid@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604443}

gn gen on Windows requires double quotes around the arguments. This
fixes the instructions so that they can be successfully copied and
pasted on Windows.

Change-Id: Id9c06cf19cea32a53a8dc4fd567d4243847afd38
Reviewed-on: https://chromium-review.googlesource.com/c/1311933Reviewed-by: Jonathan Metzman <metzman@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604442}

As there are going to be multiple home screen tiles for media and remote control app.
We need to pass the session ID to android side so it could be used to retrieve target
device of a remote control app from remote control manager.

Bug: b/118458714

Test: cast_shell_junit_tests

Change-Id: I4f5372db96946c91cec3302d50fd837d26c91949
Reviewed-on: https://chromium-review.googlesource.com/c/1303236
Commit-Queue: Zhiheng(Vincent) Li <vincentli@google.com>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Reviewed-by: Simeon Anfinrud <sanfin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604441}

Allow for an AppShimHost to be created before the corresponding
AppShimHostBootstrap. Update OnAppLaunchComplete to save the launch
result and send it only once an AppShimHostBootstrap is attached.

Change ExtensionAppShimHandler profile paths to use the full path
(as is reported by the Profile object, as opposed to the shim's
message).

Change the method GetHostForBrowser to instead be
GetViewsBridgeFactoryHostForBrowser, because the ViewsBridgeFactory is
what all callers are after. Make this call trigger creation of an
AppShimHost if needed to provide a ViewsBridgeFactory. Keep this
guarded behind a flag for now.

Add tests for this functionality. In the tests, further decouple
the AppShimHostBootstrap from its AppShimHost.

Bug: 896917
Change-Id: Ib9e4ad6535ca87cd0e01303fbfc772b8892aec12
Reviewed-on: https://chromium-review.googlesource.com/c/1309307Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604440}

This reverts commit fea62cfd.

Reason for revert: Turns out this optimization was important for all the float tests.

Original change's description:
> [LayoutNG] Remove optimization that practically does nothing.
> 
> This was an over-otimization, which realistically probably never gets
> hit.
> 
> Bug: 635619
> Change-Id: Icac53b8605e56242b8455228d0767b2dafb66b5d
> Reviewed-on: https://chromium-review.googlesource.com/c/1305133
> Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
> Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#604211}

TBR=ikilpatrick@chromium.org,mstensho@chromium.org

Change-Id: Id842627640dec23519c0b3de88b07958667e54ea
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 635619
Reviewed-on: https://chromium-review.googlesource.com/c/1311794Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604439}

This is more complex than you might expect because NGLogicalSize and
NGPhysicalSize depend on each other, so I can't inline the Convert
functions in both headers. Instead, I made NGLogicalSize::ConvertToPhysical
a global function and renamed it ToNGPhysicalSize.

Change-Id: I8d781fa73d262f75cd8196509a58f67a6fb5ec54
Reviewed-on: https://chromium-review.googlesource.com/c/1311083
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604438}

Change-Id: I152eb8755d68470f176a5715bd2d3da4cfdcee70
Reviewed-on: https://chromium-review.googlesource.com/c/1309175Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Johannes Henkel <johannes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604437}

Test: local compile and manually test.
Change-Id: Ic1d6d6a7dc81a35f493d0c086bb5577b6a833116
Reviewed-on: https://chromium-review.googlesource.com/c/1306735
Commit-Queue: Meilin Wang <meilinw@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604436}

Bug: 894328
Change-Id: Ia12904740ef4f57643233d26710c704908cca1c8
Reviewed-on: https://chromium-review.googlesource.com/c/1309420Reviewed-by: Weidong Guo <weidongg@chromium.org>
Commit-Queue: Kevin Strohbehn <ginko@google.com>
Cr-Commit-Position: refs/heads/master@{#604435}

Change-Id: I55ce7bb115c6b1202f503f9c7ddeff3fb348c381
Reviewed-on: https://chromium-review.googlesource.com/c/1300676
Commit-Queue: Taylor Bergquist <tbergquist@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604434}

Standardize ordering of getters and setters, add const to getters, use
explicit with single parameter constructor, and use getter/setter
underscore naming convention.

Change-Id: I2cba0a3fa317527e1699f1544c7cb184b773f55e
Reviewed-on: https://chromium-review.googlesource.com/c/1310558Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Doug Arnett <dougarnett@chromium.org>
Commit-Queue: Jered Gray <jegray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604433}

In preparation for the VDs work, I noticed some code we
can simplify, or needed only for DCHECK, which turned out
we can remove completely.

BUG=866622

Change-Id: I676194493d263213c0fdd621134dda4efabc408d
Reviewed-on: https://chromium-review.googlesource.com/c/1303354
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604432}

A CHECK was added to disambiguate certain large IPC cases from others.
The gist is that BigBuffer fields attempt to use shared memory, but fall
back on inlined data when shared memory allocation fails. This can
result in oversized IPC messages being sent and causing intentional
crashes.

This CL removes the CHECK in favor of sending an invalid BigBuffer
(tagged with a special union field) in cases where shared memory
allocation fails and we think the message is too large to fall back
onto inline encoding. The deserialization traits for BigBuffer and
BigBufferView will always reject such invalid BigBuffer encodings,
resulting in an interface error.

Also updates RenderFrameImpl to tolerate its ClipboardHostPtr seeing
errors as a result of this validation failure mode.

Bug: 900113
Change-Id: Ia66e9cee00819f0d61e198051b53a35c5150b399
Reviewed-on: https://chromium-review.googlesource.com/c/1308095
Commit-Queue: Ken Rockot <rockot@google.com>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604431}

This reverts commit a9fdf9b7.

Reason for revert: due to null reference. I'll revert and land new one with fix to make merge easier.

Original change's description:
> Overview optimizations
> 
> * Pause occusion tracker during overview animation
> * Activate the text filter after animation
> * Don't animate backdrop window during overview animation.
> * Fix the bounds change issue in WindowGrid. It shouldn't change
> the parent window's bounds.
> 
>   in both clamshell and tabletmode.
>   The web contents should load after animations without backdrop animation.
>   No gap at the bottom of the screen after exiting overview mode.
> 
> Bug: 898077, 897387
> Test: no functional change. Manually tested visual change by entering/exiting overview mode
> Change-Id: I60c2709c5394a565bae6d0c4bfdd7006e2e76496
> Reviewed-on: https://chromium-review.googlesource.com/c/1304973
> Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
> Reviewed-by: Sammie Quon <sammiequon@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#604206}

TBR=oshima@chromium.org,sammiequon@chromium.org

Change-Id: Ied4ce4d12abc962bffead6e22bbd7e2a837ad544
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 898077, 897387
Reviewed-on: https://chromium-review.googlesource.com/c/1311793
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604430}

Hoist this button upward so that a user no longer needs to scroll down
to find it if the console is docked at the lower half of the Application
panel, providing convenience and less confusion to first-time users.

Bug: 825132
Change-Id: I6808695c1c3e00d92553e221169b9d76a2791b2e
Reviewed-on: https://chromium-review.googlesource.com/c/1306412
Commit-Queue: Haihong Li (Harley) <hhli@chromium.org>
Reviewed-by: Erik Luo <luoe@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604429}

Previous rebaseline-cl attempt in
https://chromium-review.googlesource.com/c/chromium/src/+/1309653
produced something that one Windows bot doesn't like (missing
expectations):
https://ci.chromium.org/p/chromium/builders/luci.chromium.try/win10-blink-rel/1873

TBR=atotic@chromium.org

Bug: 591500, 900469
Change-Id: I9159aecc9efc8a4b13d8956cadcbfa0d5fc9ab7f
Reviewed-on: https://chromium-review.googlesource.com/c/1310993Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Aleks Totic <atotic@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604428}

- AcceleratedStaticBitmapImage was misusing ThreadChecker by having its
own detach logic. Using proper DetachThread is simpler, cleaner and
correct.
- UnacceleratedStaticBitmapImage didn't destroy the SkImage in the
proper thread, leading to GrContext/SkSp problems.

Bug: 890576
Change-Id: Ic71e7f7322b0b851774628247aa5256664bc0723
Reviewed-on: https://chromium-review.googlesource.com/c/1307775Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604427}

This is a reland of 86259392

TBR=This is the same cl no changes

Original change's description:
> [Android] Remove most resource names in resources.arsc
>
> resource names are stored in the resources.arsc file to allow for
> getIdentifier with the string name of the resource to work. This cl
> obfuscates all of those resources to one name (and thus stored only
> once) for all resources that are not accessed via getIdentifier.
>
> This improves binary size by about 200KB.
>
> Bug: 894208
>
> Change-Id: I28c440c22b90cd045f53017073fdb88c7410d530
> Reviewed-on: https://chromium-review.googlesource.com/c/1265897
> Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
> Reviewed-by: Richard Coles <torne@chromium.org>
> Reviewed-by: agrieve <agrieve@chromium.org>
> Reviewed-by: Ted Choc <tedchoc@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#603229}

Bug: 894208
Change-Id: Id023518c91c0c98cf68f15efad286c4874b4976d
Reviewed-on: https://chromium-review.googlesource.com/c/1308991Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604426}

https://android.googlesource.com/platform/external/perfetto.git/+log/a3a8f1e2b37f..f3b8abe13293


git log a3a8f1e2b37f..f3b8abe13293 --date=short --no-merges --format='%ad %ae %s'
2018-10-31 fmayer@google.com Merge "profiling: Allow to shut down client."
2018-10-31 hjd@google.com perfetto-ui: A number of small fixes
2018-10-31 primiano@google.com Merge "UI: Add support for /proc/[pid]/status poller"
2018-10-31 hjd@google.com Merge "perfetto-ui: Add counter track"


Created with:
  gclient setdep -r src/third_party/perfetto@f3b8abe13293

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: I15c78f0c3be2c53a44b9e92036827c85afa15020
Reviewed-on: https://chromium-review.googlesource.com/c/1310593Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#604425}

Updating third_party/android_build_tools/aapt2 to version
3.3.0-beta01-5013011. This is because the current version has bug with
regards to webview resources package ids (see https://crbug.com/899656)

Bug: 894208, 899656
Change-Id: I0258c3b9ab0018a9fe01f23d5ab3b81faf3bd49c
Reviewed-on: https://chromium-review.googlesource.com/c/1307995Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604424}

This is a longstanding issue where termination checks were not made
properly for the SVG case, since they needed to be outside an enclosing
if-block. The code now matches what the pre-existing comments above say.

Bug: 898105
Change-Id: I55fbcb88fe46428190ff442ef5e98c912e445600
Reviewed-on: https://chromium-review.googlesource.com/c/1310570Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604423}

This change corrects some bugs in SharedImage refcounting:
- SharedImages now count against a MemoryTypeTracker for a channel that
  holds a ref. Previously they would keep the original creating channel's
  MemoryTypeTracker, which could lead to issues if that channel was
  destroyed but the SharedImage was exported / kept alive by a different
  channel.
- SharedImageBackings now manage ref counts internally, rather than in
  SharedImageManager. Allows a backing to know which trackers are keeping
  it alive.
- Consumers of SharedImageRepresentations now create them though a
  SharedImageRepresentationFactory, which bundles a MemoryTypeTracker and
  forwards it to SharedImageManager.
- The creating ref is now managed using a SharedImageRepresentationFactoryRef,
  rather than a special Register/Unregister pair. This normalizes tracking w/
  other representation-based methods.

Change-Id: Ia4585e589f96d0d64b00123bdc65ff126bbd32c1
Reviewed-on: https://chromium-review.googlesource.com/c/1298735
Commit-Queue: Eric Karl <ericrk@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604422}

This logic is pulled out and looked at by the popup_blocker.cc, since
we never want to block these types of popups even if we add additional
popup policy.

While we're at it, rename ShouldApplyStrongPopupBlocker to
ShouldApplyAbusivePopupBlocker, which is more precise.

Bug: None
Change-Id: Id9f31522f697b4ead95e8e23b89da325c0960f3e
Reviewed-on: https://chromium-review.googlesource.com/c/1311260Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604421}

When 'vertical-scroll' policy is disabled in a document, the contents
cannot be scrolled (will not be user-input scrollable and targeted
for gesture scroll). However, currently disabling 'vertical-scroll'
still leaves the vertical scrollbars behind; the bars position cannot
be changed however.

This CL fixes the issue by hiding the vertical scrollbars for
scrollable elements inside documents where the policy is enforced
(i.e., disabled).

Bug: 898151
Change-Id: If01925e27184a7370d5b12583dc73bc946f2c6e2
Reviewed-on: https://chromium-review.googlesource.com/c/1305878
Commit-Queue: Ehsan Karamad <ekaramad@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604420}

Add functionality for reordering custom links. Will initialize if
custom links has not been initialized yet.

Bug: 851335
Change-Id: I67710b4187f8f5a45d7f96814c17294f87d60b22
Reviewed-on: https://chromium-review.googlesource.com/c/1308899
Commit-Queue: Kristi Park <kristipark@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604419}

- The text field for File Share URL will now initialize to the most
  recently used share path.

Bug: chromium:887133
Test: end to end
Change-Id: Ic59f7d34332b25c0e28832c6109060b849e838f2
Reviewed-on: https://chromium-review.googlesource.com/c/1300797Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>
Commit-Queue: jimmy gong <jimmyxgong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604418}

Minor fixes in the code that allocates VMOs to pass images to scenic:
1. VMO handle is now dropped immediately after VMO is mapped.
2. Added check to verify that VMO is mapped successfully.
3. Read-only VMO handle is passed to Scenic.

Bug: 899348
Change-Id: Ie78261ffc00dd5c9b80cc2b93ad2006a47c5118d
Reviewed-on: https://chromium-review.googlesource.com/c/1309301
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604417}

This CL updates the md doc's mailing list to code-coverage@chromium.

Change-Id: Ifb620a543b4afb13239cf8736832448047787aba
Reviewed-on: https://chromium-review.googlesource.com/c/1311089Reviewed-by: Max Moroz <mmoroz@chromium.org>
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604416}

This change resets the SerialDeviceEnumeratorPtr held by this class
after enumeration is complete. This breaks the reference cycle between
these two objects, allowing them both to be freed.

Bug: 898177
Change-Id: I874c62f89f8bb59a2c41f8c40afd537404f4580b
Reviewed-on: https://chromium-review.googlesource.com/c/1311533Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604415}

It appears that AVC level 5.2 is supported by Chrome for both encrypted and
non-encrypted videos, so update MIME checking to indicate that it is
supported.

BUG=622873
TEST=browser_tests pass

Change-Id: I569c1ec64313905ff38ae540c6bf354884959924
Reviewed-on: https://chromium-review.googlesource.com/c/1299909Reviewed-by: Chrome Cunningham <chcunningham@chromium.org>
Commit-Queue: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604414}

https://chromium.googlesource.com/angle/angle.git/+log/5ca3e5a0b285..580baf379673


git log 5ca3e5a0b285..580baf379673 --date=short --no-merges --format='%ad %ae %s'
2018-10-31 brandon1.jones@intel.com Recompile D3D11 Blit Shaders
2018-10-31 jmadill@chromium.org Scale down a slow index buffer perf test.


Created with:
  gclient setdep -r src/third_party/angle@580baf379673

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=ynovikov@chromium.org

Change-Id: Ib72a547f0c9298e510eb330a2440f440fafdc8af
Reviewed-on: https://chromium-review.googlesource.com/c/1310602Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#604413}