- 19 Sep, 2017 21 commits
-
-
Alex Chu authored
layers. Change-Id: I22890aa54b375e4d40b9acbd9c5b47056be7432c Bug: 736726 Reviewed-on: https://chromium-review.googlesource.com/651752 Commit-Queue: Alex Chu <alexchu@google.com> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#502742}
-
Steven Bennetts authored
Bug: none Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I79847520659cac0b4598089b03dbd23e422fa68d Reviewed-on: https://chromium-review.googlesource.com/671461Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#502741}
-
Steven Bennetts authored
This removes an undesired (and problmenatic) <html> wrapper from the element and a font include that was causing problems across the Settings UI. It also fixes an assert on startup when the feature is enabled. Bug: 760751 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Icf647dab081c5edd51b1f1029fac22e4eaa0c303 Reviewed-on: https://chromium-review.googlesource.com/671464Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#502740}
-
Derek Cheng authored
When attempting to cast via the dialog, clear previous non-blocking issues. This ensures issues are cleared on a successful cast, or that the newest issue is displayed if otherwise. This patch also simplifies the MediaRouter API by replacing the various Issues-related API in MediaRouter with GetIssueManager(). GetIssueManager() is implemented in MediaRouterBase, making it also available on Android. Also combined the Issues and their auto-dismiss callbacks in IssueManager into an Entry maintained in a single container. Bug: 763432 Change-Id: Iaa79f991760fa31e28ec50d0e23cbf8b9f39a28a Reviewed-on: https://chromium-review.googlesource.com/663104 Commit-Queue: Derek Cheng <imcheng@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#502739}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/c5e4e7437af9..c86d0794ed37 $ git log c5e4e7437..c86d0794e --date=short --no-merges --format='%ad %ae %s' 2017-09-18 reed Revert "try to remove google3 flag" 2017-09-18 reed try to remove google3 flag 2017-09-18 fmalita Revert "Reland "Fix SkImageSource::filterBounds()"" 2017-09-18 angle-deps-roller Roll skia/third_party/externals/angle2/ f3d574545..10ce2d284 (1 commit) Created with: roll-dep src/third_party/skia BUG=None Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=fmalita@chromium.org Change-Id: I4672a53c8fff4ff212db54191ba63d8f1158f817 Reviewed-on: https://chromium-review.googlesource.com/671653Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#502738}
-
kelvinp@chromium.org authored
Tbr: nasko@chromium.org Bug: 766378 Change-Id: I3c0909c32f0ad64c96ce7a12b09602a0c279bc56 Reviewed-on: https://chromium-review.googlesource.com/671666Reviewed-by:
Kelvin Poon <kelvinp@chromium.org> Commit-Queue: Kelvin Poon <kelvinp@chromium.org> Cr-Commit-Position: refs/heads/master@{#502737}
-
Fady Samuel authored
When a parent first embeds a child, it picks a LocalSurfaceId for the child and embeds it. During that bootstrapping process, there is no fallback surface to provide because the child hasn't yet submitted a CompositorFrame to viz. Prior to this CL, if a primary surface isn't available and there is no fallback then SurfaceAggregator would report a warning, and the surface would simply be dropped. This CL addresses this bootstrapping problem. It introduces the notion of a "default background color" specified by the parent when the primary Surface is unavailable and there is no fallback yet. In that case, SurfaceAggregator will use the "default background color" to create a SolidColorDrawQuad in place of the primary Surface. This CL implements this color and plumbs it all the way from SurfaceLayer, to SurfaceLayerImpl, SurfaceDrawQuad, serialization/deserialization to SurfaceAggregator, ultimately where it decides whether or not to create a SolidColorDrawQuad in lieu of a surface or not. All unit tests along this plumbing have been updated accordingly. Bug: 766013 TBR: boliu@chromium.org Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I367f7eab7b0189d438926dea407076ef6007f0a4 Reviewed-on: https://chromium-review.googlesource.com/669444 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#502736}
-
Bret Sepulveda authored
This bubble was still passing margins to BubbleFrameView after that was handled by DialogClientView instead, which led to the margins being applied twice. Bug: 763137 Change-Id: Ifbdb5baa56cc6405b9434742602cdac6a9003f01 Reviewed-on: https://chromium-review.googlesource.com/671927Reviewed-by:
Jun Mukai <mukai@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#502735}
-
Ted Choc authored
Also fixes a javadoc to not make eclipse sad. BUG= Change-Id: I6196b08b96104a27dca2377303fb38322da0fae0 Reviewed-on: https://chromium-review.googlesource.com/671806Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#502734}
-
Raphael Kubo da Costa authored
Add the [LegacyUnenumerableNamedProperties] extended attribute to both IDL files so that they follow what the DOM and HTML specs mandate. Since the attribute is inherited, it also applies to both HTMLOptionsCollection and HTMLFormControlsCollection. Both HTMLAllCollection and HTMLCollection already implemented the required enumeration and query callbacks (in other words, they already implemented the specs' definitions of "supported property names" for each interface). The user-visible difference is that all named properties were previously enumerable, while with this CL they are not: they are no longer returned by Object.keys() or iterated by for-in loops, but Object.getOwnPropertyNames() and Object.getOwnPropertyDescriptors() still include them. The value of the "enumerable" property of the property descriptors returned is now false. WebKit did the same thing in r210667 from January 2017 (was already marking the properties as not enumerable before), and Gecko did the same in bug 1270349 in May 2016 (the properties were already not enumerable before that, as explained in the Intent to Implement email). Some tests in fast/dom were removed, as they only served to test the previous behavior and the new, expected behavior is coverted by web-platform-tests. Intent to Implement: https://groups.google.com/a/chromium.org/d/msg/blink-dev/YbsMn7DL1cg/rdkA-It1AgAJ Bug: 703990, 719703 Change-Id: Id6c899c1715f22a426f24c30f0ad3f527beb14d5 Reviewed-on: https://chromium-review.googlesource.com/654837Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#502733}
-
kelvinp@chromium.org authored
No-Try: true Tbr: dcheng@chromium.org Bug: 766404 Change-Id: Iead01f0b639a27ab11b077f7fa06dbbb2524b5df Reviewed-on: https://chromium-review.googlesource.com/671940Reviewed-by:
-
kylechar authored
Remove the deprecated function that uses default InitParams. Add the params in the remaining callsites and set |single_process| correctly for tests. video_decode_accelerator_unittest.cc sets |single_process| to false, as the test runs with Ozone DRM on CrOS devices. Bug: 620934, 700142 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Iaac92d25eba7c9e052c250e84fdef2f46ecea7ee Reviewed-on: https://chromium-review.googlesource.com/667720 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#502731}
-
Tao Bai authored
This patch add basic class for autofill test and a simple test. more tests will be added. But unfortunately, we will not have Android O trybot until 2018, This test will not be run in any trybot. Bug: 717658 Change-Id: I60672a318fc5a6c8a1e3ad1212cd0fe54f7fbb8c Reviewed-on: https://chromium-review.googlesource.com/655769Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Selim Gurun <sgurun@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#502730}
-
erikchen authored
Confirming leaks requires two synchronization steps. The browser process must flush all the allocations and ensure that the messages are sent to the profiling process. This is done by performing 68,000 flushing allocations, and was already implemented. The profiling process must finish processing all the messages it receives on the connection thread for the browser process. It typically has a large backlog of tasks posted onto the connection thread's task queue. DumpProcess() now hops onto the connection thread's task queue, and back onto the IO thread before dumping allocations to a file. This ensures that all previously posted tasks are processed first. Bug: 753218 Change-Id: I08e7f49f597fadc24617bcf3612ab147eb3a458c Reviewed-on: https://chromium-review.googlesource.com/671192 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Cr-Commit-Position: refs/heads/master@{#502729}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/1b94de3b819f..441164c72d1c $ git log 1b94de3b8..441164c72 --date=short --no-merges --format='%ad %ae %s' 2017-09-18 xunjieli [netlog-viewer] Point Polymer imports to Polymer 1.9.1 Created with: roll-dep src/third_party/catapult Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I2a7ceab5a2c04cfaffb8e14ce2578929e9327805 Reviewed-on: https://chromium-review.googlesource.com/671771 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#502728}
-
Frank Barchard authored
ninja -v -C out/Release libyuv Bug: 766322, libyuv:723 Test: gn gen out/Release "--args=is_debug=false is_clang=false target_os=\"android\" target_cpu=\"arm64\" libyuv_include_tests=true libyuv_use_gflags=false" Change-Id: Ib1fa9c4eaa3d7db2e089112f38dcf755a97d5ca4 Reviewed-on: https://chromium-review.googlesource.com/671208 Commit-Queue: Frank Barchard <fbarchard@google.com> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#502727}
-
Nick Carter authored
An earlier refactor of this code appears to have stripped out the DISABLED prefix when building into the |test_locations_| map, but when that map is queried, the DISABLED prefix was still present in the keys. This caused a crash, at least in Windows debug builds it did. TBR=seanmccullough@chromium.org Bug: 754441 Change-Id: Ie78294dfeb7369c3ad9573a2017a29e5e3787708 Reviewed-on: https://chromium-review.googlesource.com/611139Reviewed-by:
Nick Carter <nick@chromium.org> Commit-Queue: Nick Carter <nick@chromium.org> Cr-Commit-Position: refs/heads/master@{#502726}
-
Tom Anderson authored
BUG=764079 TBR=dgozman@chromium.org Change-Id: I7dd8dc4605011e0e1fa1392a6d15f39be5985167 Reviewed-on: https://chromium-review.googlesource.com/671539Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#502725}
-
Gregory Chatzinoff authored
Removes the BrowserCommands dependency from the PageInfoViewController so that it is easier to integrate into ios/clean. Bug: none Change-Id: I12508c86c767ddd0933226a316787eab7ce8a97e Reviewed-on: https://chromium-review.googlesource.com/669961Reviewed-by:
Rohit Rao (ping after 24h) <rohitrao@chromium.org> Commit-Queue: Gregory Chatzinoff <gchatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#502724}
-
Tao Bai authored
This reverts commit 7844944f. Reason for revert: it broke x86 builder https://build.chromium.org/p/chromium.android/builders/Android%20x86%20Builder%20%28dbg%29/builds/22715 Original change's description: > [Android] Allow __NR_process_vm_readv under Seccomp. > > Bug: 766245 > Change-Id: Ic494f526c1b8d15483ca7e9a97d9f044f276c26d > Reviewed-on: https://chromium-review.googlesource.com/671556 > Reviewed-by: Richard Coles <torne@chromium.org> > Commit-Queue: Robert Sesek <rsesek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#502714} TBR=torne@chromium.org,rsesek@chromium.org Change-Id: I31ab91b3572c1e109699ceabcdfbd06cc0c54e39 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 766245 Reviewed-on: https://chromium-review.googlesource.com/671658Reviewed-by:
Tao Bai <michaelbai@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#502723}
-
Victor Costan authored
Change-Id: Ice4f62c8a17310aa4757d03bc2c14d7d150690c7 Reviewed-on: https://chromium-review.googlesource.com/668197 Commit-Queue: Chris Mumford <cmumford@chromium.org> Reviewed-by:
Chris Mumford <cmumford@chromium.org> Cr-Commit-Position: refs/heads/master@{#502722}
-
- 18 Sep, 2017 19 commits
-
-
Gauri Manikpure authored
Bug: chromedriver:1887, chromedriver:2002 Change-Id: I327ba44051de581075b6c14132b63d1422556847 Reviewed-on: https://chromium-review.googlesource.com/578609 Commit-Queue: Gauri Manikpure <gmanikpure@chromium.org> Reviewed-by:
Shuotao Gao <stgao@chromium.org> Cr-Commit-Position: refs/heads/master@{#502721}
-
Alex Newcomer authored
Two small fixes: 1. The fling velocity threshold needs to be lowered to 6. 2. Dragging up on the launcher sometimes transitions to peeking, this is because we check that abs(drag_offset) > drag_threshold, but don't check the sign of the offset. Bug: 765845 Change-Id: I22270e4caea5b4aab22b347b1ce28e98a5df03fe Reviewed-on: https://chromium-review.googlesource.com/669944 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#502720}
-
Kelvin Poon authored
This reverts commit a5f2d27e. Reason for revert: <INSERT REASONING HERE> Original change's description: > Adds class level documentation to generated property APIs. > > Includes APIs for both properties and descriptors. Does not include > CSSPropertyAPIApplyAtRule or CSSPropertyAPIVariable which are not > properties or descriptors. > > Also cleans up make_css_property_api_headers a bit. > > Diff of generated files: > https://gist.github.com/49b9974fa1e6b5a5fc97c1582ebb495c/revisions > > Bug: 545324 > Change-Id: I6f1ddcbc02816595512fddf04cbfbfbbc36afe32 > Reviewed-on: https://chromium-review.googlesource.com/666363 > Commit-Queue: Bugs Nash <bugsnash@chromium.org> > Reviewed-by: Renée Wright <rjwright@chromium.org> > Reviewed-by: meade_UTC10 <meade@chromium.org> > Cr-Commit-Position: refs/heads/master@{#502708} TBR=rjwright@chromium.org,meade@chromium.org,bugsnash@chromium.org Change-Id: I25750855db88917f077e9fc1e0714c802bd6c94b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 545324 Reviewed-on: https://chromium-review.googlesource.com/671657Reviewed-by:
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/5278cebc468e..29b7891d920f $ git log 5278cebc4..29b7891d9 --date=short --no-merges --format='%ad %ae %s' 2017-09-08 art-snake Remove useless code. 2017-09-08 art-snake Use CPDF_ReadValidator to request linearized data. Created with: roll-dep src/third_party/pdfium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: I457c81e541cd74b479ee79d6ff7745a9e1ca4ca7 Reviewed-on: https://chromium-review.googlesource.com/671532 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#502718}
-
Sergey Ulanov authored
Updated local-sdk.py to call build-zircon.sh instead of build-magenta.sh . Change-Id: I2ae2000edf9c4c487ae2b4b8ece61764f1a2ba51 Bug: 765754 Reviewed-on: https://chromium-review.googlesource.com/671536 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#502717}
-
Rob Buis authored
Rename starAtom, nullAtom and emptyAtom in comments to the new names created after the great Blink rename. Bug: None Change-Id: Ibad34e8aa6316d6fb22863292ed35bfcec3d492a Reviewed-on: https://chromium-review.googlesource.com/671191Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Eric Noyau authored
Bug: None Change-Id: Ie8af629d902c0da861c6e826a867ab2e59339c64 Reviewed-on: https://chromium-review.googlesource.com/671232Reviewed-by:
Ramya Sharma <ramyasharma@chromium.org> Commit-Queue: Ramya Sharma <ramyasharma@chromium.org> Cr-Commit-Position: refs/heads/master@{#502715}
-
Robert Sesek authored
Bug: 766245 Change-Id: Ic494f526c1b8d15483ca7e9a97d9f044f276c26d Reviewed-on: https://chromium-review.googlesource.com/671556Reviewed-by:
-
Yafei Duan authored
Implemented the DeletePageTask which is responsible to delete offline pages along with their metadata entries in the database. This is part of the taskifying Offline Page Model effort and it depends on the AddPageTask for testing. Bug: 753595 Change-Id: I344f1da54f2c67dc72078351b8590766ae98476a Reviewed-on: https://chromium-review.googlesource.com/651390 Commit-Queue: Yafei Duan <romax@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#502713}
-
Wang Qing authored
Currently, seccomp_bpf is not supported on mips64el, and the build configuration sets use_seccomp_bpf=false on mips64el. This CL adds support for seccomp-bpf on mips64el, and resolves many compiler errors when compiling on mips64el. R= machenbach@chromium.org, brettw@chromium.org TBR=jorgelo Bug: 742738 Change-Id: I79c5d1800c0a198a70c1f19a818885b726cbcc4f Reviewed-on: https://chromium-review.googlesource.com/571385Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Brett Wilson <brettw@chromium.org> Commit-Queue: Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#502712}
-
Jayson Adams authored
In GetLoginItemForApp() we call LSSharedFileListItemResolve(). There are crashers because the function apparently can return a NULL CFURLRef even when the function itself returns noErr. This cl checks that the returned CFURLRef is non-NULL before proceeding. R=mark@chromium.org Bug: 760989 Change-Id: Ibb37ceae4b7ccb6765d10392fa786d3fea05eded Reviewed-on: https://chromium-review.googlesource.com/669879Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Jayson Adams <shrike@chromium.org> Cr-Commit-Position: refs/heads/master@{#502711}
-
Eric Stevenson authored
This CL adds a simple utility class with static methods for permitting StrictMode disk-reads and disk-writes. There is no behavior change, the convenience methods just make StrictMode white-listing more readable. Before: StrictMode.ThreadPolicy oldPolicy = StrictMode.allowThreadDiskReads(); try { return methodThatWritesToDisk(); } finally { StrictMode.setThreadPolicy(oldPolicy); } After: try (StrictModeContext unused = StrictModeContext.allowDiskReads()) { return methodThatWritesToDisk(); } Bug: 766228 Change-Id: If07525e95236d1533531275c7b1564e3ae9f3433 Reviewed-on: https://chromium-review.googlesource.com/671550 Commit-Queue: Eric Stevenson <estevenson@chromium.org> Reviewed-by:Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#502710}
-
Bhagirathi Satpathy authored
Rename RegisteredEventListener::listener() to callback() for clarity and to match the specification. https://dom.spec.whatwg.org/#concept-event-listener Bug: 766062 Change-Id: I9af2b09516ea6a7fd4fbfb5723e4280c5724793c Reviewed-on: https://chromium-review.googlesource.com/670906 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Bugs Nash authored
Includes APIs for both properties and descriptors. Does not include CSSPropertyAPIApplyAtRule or CSSPropertyAPIVariable which are not properties or descriptors. Also cleans up make_css_property_api_headers a bit. Diff of generated files: https://gist.github.com/49b9974fa1e6b5a5fc97c1582ebb495c/revisions Bug: 545324 Change-Id: I6f1ddcbc02816595512fddf04cbfbfbbc36afe32 Reviewed-on: https://chromium-review.googlesource.com/666363 Commit-Queue: Bugs Nash <bugsnash@chromium.org> Reviewed-by:
Renée Wright <rjwright@chromium.org> Reviewed-by:
meade_UTC10 <meade@chromium.org> Cr-Commit-Position: refs/heads/master@{#502708}
-
Alexei Svitkine authored
The problem was caused by ScopedFeatureList not resetting the FeatureList to null if it was that way prior to the scope. The FeatureList that stuck around had references to FieldTrial objects that were destroyed by a previous test and this caused a crash when FieldTrialListTest.TestCopyFieldTrialStateToFlags went to use them. As part of the fix, also adds a ScopedFeatureList to that test since it was previously relying on the left-over instance. Finally, a lot of tests that used feature params were implicitly relying on a FeatureList having been set (and leaked) by some earlier test in the same batch. To keep these tests working without modifying them all to have a ScopedFeatureList (when they're not actually trying to test param override values), this change updates FeatureList::GetFieldTrial() to have similar logic to IsEnabled() when the FeatureList instance was not initialized. With the new behavior, GetFieldTrial() - which is generally not invoked directly but queried by the implementation of base::GetFieldTrialParamValueByFeature() - will return a sane default when FeatureList is not initialized. This way, it's consistent with what we do for FeatureList::IsEnabled() - and in both cases, they will set a bool that is checked to ensure that once used that way, setting a FeatureList instance will be an error. BUG=757651 Change-Id: I79ce1ddcd000d1628c7396faee25ed848b1d8e1a Reviewed-on: https://chromium-review.googlesource.com/671290Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#502707}
-
Paweł Hajdan, Jr authored
This should be a no-op, and is part of a migration path away from hooks_os. It's also one of the smallest experiments with conditionals in chromium/src. Bug: 570091 Change-Id: I9d582a6703c64a4ab37bb063ebebe85a7b41b4b5 Reviewed-on: https://chromium-review.googlesource.com/671383Reviewed-by:
Michael Moss <mmoss@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Michael Moss <mmoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#502706}
-
oka@chromium.org authored
Bug: 760492 Test: try Change-Id: I77aabf9ded805cea1099bd1cfb7e6d91d92936a4 Reviewed-on: https://chromium-review.googlesource.com/650233Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Keigo Oka <oka@chromium.org> Cr-Commit-Position: refs/heads/master@{#502705}
-
kelvinp@chromium.org authored
Bug: 766357 Change-Id: I75db2dd95472dc79e5798ce0d34df42d64617d4f Tbr: sahel@chromium.org No-Try: true Reviewed-on: https://chromium-review.googlesource.com/671654Reviewed-by:
-
Brandon Jones authored
This adds the "vr" attribute but not the ability to return a valid device list. As long as the security checks pass an empty array will be returned by the promise every time. Bug: 670510 Change-Id: I7e5e21d0db92b0766a74b678beb6ca90e020ced9 Reviewed-on: https://chromium-review.googlesource.com/658260Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
-
