- 18 Oct, 2018 29 commits
-
-
Xiaohan Wang authored
This CL updates the EME requestMediaKeySystemAccess() stack to support AV1. For library CDMs, it needs to be signaled during CDM registration. In the next CL, ClearKeyCdm will be updated to actually support AV1 playback. TBR=sorin@chromium.org Windows. Bug: 884898 Test: Added new test cases. Also manually tested component installer on Change-Id: I0222136c76682db51bcf021c6bd5db3c467c271e Reviewed-on: https://chromium-review.googlesource.com/c/1241569 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#600638}
-
Victor Costan authored
The new release changes how ALTER TABLE RENAME is implemented, and requires an update to WebSQL's SQLite authorizer. This CL includes the update, and extends the LayoutTest for the authorizer to cover the newly implemented column renaming functionality. Bug: 892852 Change-Id: I58fdc2927cacb6ccc84a741d7fc519fb2e5b8721 Reviewed-on: https://chromium-review.googlesource.com/c/1266881Reviewed-by:
Chris Mumford <cmumford@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#600637}
-
Takuto Ikuta authored
`gn gen` failed due to missing pdb files. This is follwup of https://chromium-review.googlesource.com/c/1279380 TBR: wfh@chromium.org thestig@chromium.org Change-Id: I513d10d61a3868953c4afc025adf840e0f3c70c2 Reviewed-on: https://chromium-review.googlesource.com/c/1286108 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#600636}
-
rbpotter authored
Bug: 895733 Change-Id: Iee9b0deb1016d28c8d6b4c870cdd452c52feda71 Reviewed-on: https://chromium-review.googlesource.com/c/1285116Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#600635}
-
Ned Nguyen authored
Bug: 893618 Change-Id: Idbfa57949f173847d2985e528fe05bdf1a2e93a2 Reviewed-on: https://chromium-review.googlesource.com/c/1287033 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#600634}
-
Ned Nguyen authored
Bug: 893618 Change-Id: I56f6c0ccf0c7cecfa419d557ed9fc444f500cd2d Reviewed-on: https://chromium-review.googlesource.com/c/1287039Reviewed-by:
-
Alexander Alekseev authored
This Cl changes layout of PIN setup input/keyboard to match new specs. This changes behavior both in First Run and in Settings UI. Bug: 884667,890685 Change-Id: Ie0f94dfaa3ea22cdf99f478eb21ec1631de41bd5 Reviewed-on: https://chromium-review.googlesource.com/c/1286199Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#600632}
-
Giovanni Ortuño Urquidi authored
The implementation just forwards the call to BlueZ. Future iterations will support saving the new state into a user pref and concurrent calls. Bug: 870192 Change-Id: I1dc1ebec9a58378ed8a4b87f31027c76a2a03323 Reviewed-on: https://chromium-review.googlesource.com/c/1280066Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Doug Turner <dougt@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#600631}
-
Shakti Sahu authored
This CL fixes 1 - Paused downloads showing up as failed after browser restart 2 - Pending for network downloads showing up as failed Bug: 894159 Change-Id: Id4879c7e7a8e66413943c2a7732a72c558e11a49 Reviewed-on: https://chromium-review.googlesource.com/c/1284889 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#600630}
-
James Cook authored
Bug: none Change-Id: I9d5b73409d25cf667a5b1ac580a7c5d6ddd3ea1a Reviewed-on: https://chromium-review.googlesource.com/c/1286878Reviewed-by:
Stefan Kuhne <skuhne@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#600629}
-
Sergey Ulanov authored
swiftshader now supports arm64 Bug: 881334 Change-Id: I370fb7bdc361588ff69e47ac81af991ee2c02af1 Reviewed-on: https://chromium-review.googlesource.com/c/1287206Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#600628}
-
Findit authored
This reverts commit f24f12dd. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 600509 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZjI0ZjEyZGRhYzc2ZmRlZDRiYmJkMmI0NjMxOTUyYjlhY2QyOWNjMQw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-rel/14827 Sample Failed Step: viz_content_browsertests Sample Flaky Test: BrowserSideFlingBrowserTest.TouchscreenFlingBubblesFromOOPIF Original change's description: > Added Fling Bubbling browsertests. > > The tests were initially landed in the following cl: > https://chromium-review.googlesource.com/c/chromium/src/+/1278963 > > The logic of the cl is re-landed in a separate cl(r599781) to give it > more time to bake. This cl re-lands the browser tests after applying > the following changes: > > 1- Addressed renaming nit. > 2- Used MainThreadFrameObserver to make sure that compositor is synced > after scrolling on main thread. > > Bug: 894703 > Change-Id: I25d6dbf7f216bbedecb6673d6c2819dcd1d82d55 > Reviewed-on: https://chromium-review.googlesource.com/c/1286875 > Reviewed-by: Charlie Reis <creis@chromium.org> > Reviewed-by: Kevin McNee <mcnee@chromium.org> > Commit-Queue: Sahel Sharify <sahel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#600509} Change-Id: Ie617c2ccc9b0048d24804ab59cdb5753f99a3e32 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 894703, 894703 Reviewed-on: https://chromium-review.googlesource.com/c/1287077 Cr-Commit-Position: refs/heads/master@{#600627}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/3a482179dedb..25843dd65181 git log 3a482179dedb..25843dd65181 --date=short --no-merges --format='%ad %ae %s' 2018-10-18 ynovikov@chromium.org Align memory access in Copy32FixedTo32FVertexData 2018-10-17 jmadill@chromium.org perftests: Record trace events to JSON file. Created with: gclient setdep -r src/third_party/angle@25843dd65181 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Change-Id: I2013d8790c16cd8e11b2b34d9ff5c6973d32ec0a Reviewed-on: https://chromium-review.googlesource.com/c/1287412Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#600626}
-
Tom Finegan authored
Re-encoded for spec compliance. Previous versions omitted the Codec Private. BUG=879263 R=dalecurtis Change-Id: I466e15886bba2b975b4b8b93a15cefb604f93057 Reviewed-on: https://chromium-review.googlesource.com/c/1287091Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Tom Finegan <tomfinegan@chromium.org> Cr-Commit-Position: refs/heads/master@{#600625}
-
Sky Malice authored
Bug: 896468 Change-Id: I17754946715d84c0db9b8d1bda237553d171c4ac Reviewed-on: https://chromium-review.googlesource.com/c/1287292Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#600624}
-
Eugene But authored
Bug: 546191 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I870931443b05f0ea8767864346703ba954df63f0 Reviewed-on: https://chromium-review.googlesource.com/c/1287291Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#600623}
-
dpapad authored
The test was failing because it was asserting on a DOM subtree that was behind a <dom-if> that is false. In Polymer 2, a new optimization prevents those parts of the DOM to receive any updates. Bug: 896208 Change-Id: I268b6732ccf75f5544b3ce3011a73fbc8d11f55b Reviewed-on: https://chromium-review.googlesource.com/c/1287199Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#600622}
-
Carlos Knippschild authored
TBR=edwardjung@chromium.org Bug: 852872 Change-Id: I6a48dca2ccb00fcac5f4ad2420694478d93639b7 Reviewed-on: https://chromium-review.googlesource.com/c/1285693Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#600621}
-
Mike Dougherty authored
When a WKWebView is displaying a PDF, the first responder is not in the view hierarchy (but a class adhering to UIResponder). Bug: 882470 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I6f9e993e740541b7cf009b1d11e16183b409fdae Reviewed-on: https://chromium-review.googlesource.com/c/1284438 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#600620}
-
Michael Giuffrida authored
When localizing an extension, prioritize the user's preferred language over the application locale. Normally, these are the same. In some cases, they differ. For example, the user may choose to display Chrome in "en-CA" (the intl.app_locale pref), but because we don't have translations for that, the actual UI locale is "en-GB". This CL makes extensions try to use the user's preferred locale for i18n ("en_CA"), falling back to the UI locale ("en_GB") if no locale directory is found for the preferred locale. This change also updates the "current_locale" manifest key to reflect the user's preferred locale, or the UI locale if intl.app_locale is unset. Note: Like the application locale, the preferred locale is only set at startup (and in certain situations in CrOS). If the user changes their intl.app_locale pref, they have to restart Chrome before extensions are re-localized, just like before. Bug: 874225 Change-Id: I1aabe3c3680b77d6522193e764aec15a3d618d2d Reviewed-on: https://chromium-review.googlesource.com/c/1244666 Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:Scott Violet <sky@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#600619}
-
Rahul Chaturvedi authored
Add a new PSD to Feedback reports specifying the account type of the primary user logged in. R=afakhry@chromium.org Bug: 891113 Change-Id: I6b46d65b0fb32fec0ef651d89dd06afcc3c58b25 Reviewed-on: https://chromium-review.googlesource.com/c/1277990 Commit-Queue: Rahul Chaturvedi <rkc@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#600618}
-
jdoerrie authored
This change applies clang-tidy's modernize-use-auto [1] in /media/cast. This change does not rewrite new and cast expressions. Reproduction steps: - run clang-tidy's modernize-use-auto - run git cl format - manually remove unused typedefs due to -Wunused-local-typedef error [1] https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-auto.html This CL was uploaded by git cl split. R=miu@chromium.org Bug: 890902 Change-Id: I1f11e8871d5dab6298edd8829b852cd1907ee2b3 Reviewed-on: https://chromium-review.googlesource.com/c/1257904Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#600617}
-
Alexander Alekseev authored
This disables Welcome App on selected devices. Bug: 894095 Change-Id: I3a96e271f669eb2ac6d63d817d49be2838231170 Reviewed-on: https://chromium-review.googlesource.com/c/1287184 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by:
-
Min Qin authored
Once a download becomes active, it should be shown on shelf. BUG=895597 Change-Id: I307c64d2111a903ce0bc22b2bd0ae6ff1776c658 Reviewed-on: https://chromium-review.googlesource.com/c/1282023Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#600615}
-
Peter K. Lee authored
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I0651ad924a0cf050850cc5298b247c44abd355a4 Reviewed-on: https://chromium-review.googlesource.com/c/1287298Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#600614}
-
Ben Pastene authored
See the retries on something like: https://luci-milo.appspot.com/p/chromium/builders/luci.chromium.try/chromeos-amd64-generic-rel/110795 Failing due to the unknown args. This will just ignore them. Bug: 876587 Change-Id: Ibfe012d74af2dff8ee9b35c3dc921ba53c671b83 Reviewed-on: https://chromium-review.googlesource.com/c/1284443Reviewed-by:
-
Yuki Awano authored
- Touch event comes with coordinate where its origin is its root window host. Hardware. Confirm that ChromeVox works well on it, e.g. you can activate an element on the screen, etc. Bug: 887222 Test: Enable spoken feedback on touch controller of Hangout Meet Change-Id: I6bd6b50f13405c493659ad91f24d35974d5c72ce Reviewed-on: https://chromium-review.googlesource.com/c/1282688Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Yuki Awano <yawano@chromium.org> Cr-Commit-Position: refs/heads/master@{#600612}
-
Kevin Strohbehn authored
These events were being sent up to AppListView, then back to AppsGridView. In reality, these events can all be handled before letting them pass through, just based on the nearest tile. Bug: 893216 Change-Id: I9fee2bd9be03efb54a90b07d87bcf9f1a772d6f8 Reviewed-on: https://chromium-review.googlesource.com/c/1286129 Commit-Queue: Kevin Strohbehn <ginko@google.com> Reviewed-by:
Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#600611}
-
Eric Aleshire authored
I accidentally modify cmd (which is unused, but passed in due to inherited function definition), instead of recipe_cmd (which is used, and generated by this function). This is not caught by tests as we mock subprocess. Bug: 892381 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I8960fce63b98f68d2cf65792d4bd6e8bc971dcd0 Reviewed-on: https://chromium-review.googlesource.com/c/1287196Reviewed-by:
Sergey Berezin <sergeyberezin@chromium.org> Commit-Queue: ericale <ericale@chromium.org> Cr-Commit-Position: refs/heads/master@{#600610}
-
- 17 Oct, 2018 11 commits
-
-
Findit authored
This reverts commit ac77d3be. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 600408 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vYWM3N2QzYmU5ZGIyYWJhMWMxZWUxNGI3Y2VmYTQwMGI2YmZkYzBlMAw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/29624 Sample Failed Step: viz_browser_tests Sample Flaky Test: TopControlsSlideControllerTest.TestToggleChromeVox Original change's description: > top-chrome-slide: Disable the behavior when Chromevox is enabled. > > Users of Chromevox may need to touch explore the webpage, and for > things to remain consistent, we should disable hiding top-chrome > with gesture scrolls as long as Chromevox is enabled. > > BUG=857331 > TEST=Added a new browser test. > > Change-Id: Ic70ebcad475ea7885ea3b6bd826b9b1f08f03e1b > Reviewed-on: https://chromium-review.googlesource.com/c/1284289 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> > Cr-Commit-Position: refs/heads/master@{#600408} No-Presubmit: true No-Tree-Checks: true No-Try: true BUG=857331, 896514 Change-Id: If1640bcc475ecbf869dd26dc11b35e6f9bc4fc75 Reviewed-on: https://chromium-review.googlesource.com/c/1287429 Cr-Commit-Position: refs/heads/master@{#600609}
-
Krishna Govind authored
R=abdulsyed@chromium.org Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I68f34a70ebe0e044092cc1abd25d48e9cfb28bd4 Reviewed-on: https://chromium-review.googlesource.com/c/1286863Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#600608}
-
Christian Biesinger authored
Avoids a pointless virtual call R=eae@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Ie3048af3bc77c1f2dfea7293d823dd2fa5bbdde5 Reviewed-on: https://chromium-review.googlesource.com/c/1287203 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#600607}
-
Jun Mukai authored
The reason of OmniboxViewViews test failures are basically on touches, and that's because EventInjector is not used. This CL sets nullptr for EventGenerator to use EventInjector. BUG=883523 TEST=interactive_ui_tests Change-Id: I394b9b11d6efc6826a45da407b79cee328224dcf Reviewed-on: https://chromium-review.googlesource.com/c/1283929Reviewed-by:
-
Sam McNally authored
Bug: 870004 Tbr: nhiroki@chromium.org Change-Id: I49b60914dfe719e50941b18d7b96116d98ada86b Reviewed-on: https://chromium-review.googlesource.com/c/1282513 Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by:
Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#600605}
-
Mike Wasserman authored
These files are not mentioned in BUILD.gn files. The cc and mm files also mention headers that do not exist. Bug: None Change-Id: Ifb459ff2e515efa857e1e48748b3cfab9a4151c6 Reviewed-on: https://chromium-review.googlesource.com/c/1287301 Commit-Queue: Yuri Wiitala <miu@chromium.org> Reviewed-by:
-
Alan Cutter authored
This CL tidies up some verbose callsites to extensions::HostedAppBrowserController::IsForExperimentalHostedAppBrowser() by hiding it behind a BrowserView::IsBrowserTypeHostedApp() helper function. Bug: 895690 Change-Id: I0cbced2882e4be5dde9107961f3b5a443810869e Reviewed-on: https://chromium-review.googlesource.com/c/1286236 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#600603}
-
Noel Gordon authored
Add SelectFileDialogExtensionBrowserTests for the fix for issue 453634 using the new test API added in CL:1282623 which returns the extension dialog's CanResize() behavior. SelectFileDialogExtensionBrowserTest/CanResize - the dialog should be resizable. SelectFileDialogExtensionBrowserTest/CanResize_TabletMode - the dialog should not be resizable. Bug: 453634 Change-Id: I111462857193d337f5cb81715ed509321ae32293 Reviewed-on: https://chromium-review.googlesource.com/c/1286244Reviewed-by:James Cook <jamescook@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#600602}
-
Ken Rockot authored
Fixes the behavior of some of these tests with https://chromium-review.googlesource.com/c/chromium/src/+/1145692 applied. That CL changes how Mojo bindings dispatch messages, but only timing (not ordering) is changed. This can break subtle test expecations, as is the case here. This change replaces use of deprecated RunAllPendingInMessageLoop with either RunLoop usage or TestBrowserThreadBundle::RunIOThreadUntilIdle. In the latter case, in order to achieve synchronization parity with the code before this change, note that it is also necessary to have WAIT_FOR_DEVICE_TASKS wait for the UI thread to idle after the IO thread has idled, due to the way RunAllPendingInMessageLoop worked. Bug: 895693 Change-Id: I15552766245eda0bdce141c40643ee4b44cc90a8 Reviewed-on: https://chromium-review.googlesource.com/c/1286432 Commit-Queue: Yuri Wiitala <miu@chromium.org> Reviewed-by:
-
Rune Lillesveen authored
We do have a LayoutObject for the spinner which means we have a ComputedStyle already. Also added some documentation to EnsureComputedStyle for <area>. Bug: 895894 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ie0ee5c75fae0f699721a30f3072eec526c50083e Reviewed-on: https://chromium-review.googlesource.com/c/1286412 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#600600}
-
Nico Weber authored
/pdbsourcepath: before this change here was used to tell lld-link about the build directory. The setup was that the compiler can produce debug info with relative paths in its output (to make them build-dir independent, which helps goma cache obj files), and then at link time those relative paths were made absolute. In symbol_level=1 builds, the obj files don't contain any debug info, the linker just adds enough debug info at link time to get symbolized stacks (without line numbers). So we don't need to pass a real build directory in that case and can pass a fake fixed path. (sanitizer builds do pass -gline-tables-only and hence have some debug info in the obj files even with symbol_level=1, do don't do this there). After http://reviews.llvm.org/rL344061, /pdbsourcepath: is also used as the base path in all other places that contain absolute paths: - The "cwd" stored in the env block in the pdb is /pdbsourcepath: if present - The "exe" stored in the env block in the pdb is made absolute relative to /pdbsourcepath: instead of the cwd - The "pdb" stored in the env block in the pdb is made absolute relative to /pdbsourcepath: instead of the cwd - For making absolute paths to .obj files referenced from the pdb This makes PDBs independent of the build dir in symbol_level=1 builds, and since the hash of the PDB contents are copied as PDB UUID into the executable, it makes executables reproducibe in symbol_level=1 builds too. Bug: 330260 Change-Id: Iaf0bd9f8259b3c97b5c6cff497d31d6043faa807 Reviewed-on: https://chromium-review.googlesource.com/c/1273479Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#600599}
-
