GitLab

Test: build locally with upreved libassistant
Bug: None
Change-Id: I3db67f5a77824fcf0831447f353baba6167b0801
Reviewed-on: https://chromium-review.googlesource.com/1025268Reviewed-by: Muyuan Li <muyuanli@chromium.org>
Commit-Queue: Muyuan Li <muyuanli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552972}

This is a reland of 850001f3, which caused
a pre-submit deadlock for chrome/browser/notifications/OWNERS.

This is now safe to land as the following CL has been landed:
https://chromium-review.googlesource.com/c/chromium/src/+/1024633

Original change's description:
> Move notification_helper/ to chrome/notification_helper/
>
> ... plus all the necessary code migration. A follow-up CL will be used
> to update relevant comments.
>
> Bug: 734095
> Change-Id: I8516c750518e10a366bdc1496e75a3c2f4f0898b
> Reviewed-on: https://chromium-review.googlesource.com/1022957
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Commit-Queue: Xi Cheng <chengx@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#552762}

Bug: 734095
Change-Id: Id4e0818d7e3ea2b0ea7633e883bc5cea42705167
Reviewed-on: https://chromium-review.googlesource.com/1024744
Commit-Queue: Xi Cheng <chengx@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552971}

ASAN bits remain.

BUG=605605

Change-Id: I57252e03f569e8f605bdaa01e0aaf97455e5e761
Reviewed-on: https://chromium-review.googlesource.com/1014955Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552970}

The "Add Printer" button on the cups printers settings page will be
disabled if the enterprise printer policy is set so that users are not
allowed to configure their own native printers.

Bug: 827015
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Id501e2f667c435f6d7bd503ab7c343cccf4b3abd
Reviewed-on: https://chromium-review.googlesource.com/987626Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: David Valleau <valleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552969}

This reverts commit bcb0488a.

Reason for revert: Bug fixed

Original change's description:
> Revert "Reland "Only retry failed tests for layout tests""
> 
> This reverts commit c24c2363.
> 
> Reason for revert: https://chromium-review.googlesource.com/c/chromium/src/+/1018590 broke webkit
> 
> Original change's description:
> > Reland "Only retry failed tests for layout tests"
> > 
> > This reverts commit 23ea7f24.
> > 
> > Reason for revert: Issue fixed
> > 
> > Original change's description:
> > > Revert "Only retry failed tests for layout tests"
> > > 
> > > This reverts commit ecb97ada.
> > > 
> > > Reason for revert: https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_rel_ng/73246 looks invalid
> > > 
> > > Original change's description:
> > > > Only retry failed tests for layout tests
> > > > 
> > > > Recently layout tests have been fairly flaky; this is causing extra load
> > > > on the CQ. Every time layout tests fails, they are retried without patch
> > > > to determine if the failure is a flake or a failure at tip of tree. This
> > > > means that layout tests are running more than other test suites, and
> > > > since layout tests take a long time to run, we end up consuming more
> > > > capacity from our swarming pool than we should.
> > > > 
> > > > Isolated script tests don't have the ability to retry only the tests
> > > > that failed, which is what other test suites do. This CL changes that so
> > > > that layout tests, when re-run without the patch, retry on the tests that
> > > > fail, which should significantly reduce swarming load and cycle time for
> > > > running layout tests without patch.
> > > > 
> > > > Bug: 533481
> > > > Change-Id: I1f23f6e57bcfbc44f80f11a0a96ca74d84ae8423
> > > > Reviewed-on: https://chromium-review.googlesource.com/1015843
> > > > Commit-Queue: Stephen Martinis <martiniss@chromium.org>
> > > > Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> > > > Reviewed-by: John Budorick <jbudorick@chromium.org>
> > > > Cr-Commit-Position: refs/heads/master@{#551821}
> > > 
> > > TBR=dpranke@chromium.org,martiniss@chromium.org,jbudorick@chromium.org
> > > 
> > > Change-Id: Ia6092ae71aad64689cdac37e6cd6524d087ff428
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Bug: 533481
> > > Reviewed-on: https://chromium-review.googlesource.com/1018161
> > > Reviewed-by: Stephen Martinis <martiniss@chromium.org>
> > > Commit-Queue: Stephen Martinis <martiniss@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#551877}
> > 
> > TBR=dpranke@chromium.org,martiniss@chromium.org,jbudorick@chromium.org
> > 
> > # Not skipping CQ checks because original CL landed > 1 day ago.
> > 
> > Bug: 533481
> > Change-Id: If8c572258d9ed3abc020bc5bad56d1b06107ee0f
> > Reviewed-on: https://chromium-review.googlesource.com/1022552
> > Reviewed-by: Stephen Martinis <martiniss@chromium.org>
> > Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> > Commit-Queue: Stephen Martinis <martiniss@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#552482}
> 
> TBR=dpranke@chromium.org,martiniss@chromium.org,jbudorick@chromium.org
> 
> Change-Id: Ibd7819d1adb43895e33b74622438aa61517a036d
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 533481
> Reviewed-on: https://chromium-review.googlesource.com/1022558
> Reviewed-by: Stephen Martinis <martiniss@chromium.org>
> Commit-Queue: Stephen Martinis <martiniss@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#552484}

TBR=dpranke@chromium.org,martiniss@chromium.org,jbudorick@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 533481
Change-Id: I87279f430e6bee58068bad4f3bce71d1923e0834
Reviewed-on: https://chromium-review.googlesource.com/1024719Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552968}

This property is needed so that ash can bind to Mojo services specific
to a given user. This functionality will be used in a follow-up CL:
https://chromium-review.googlesource.com/c/chromium/src/+/1022470.

Change-Id: I734d6e1f42fb2832cfdbc959d4d733b0bdd59727
Reviewed-on: https://chromium-review.googlesource.com/1022834
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552967}

* Merge webkitpy into blinkpy except for add_blinkpy.py
* Rename webkitpy.layout_tests to blinkpy.web_tests

* path_finder.py:
 - Remove get_scripts_dir() and path_from_tools_scripts()
 - Change _webkit_base() to _blink_base()

* android.py, fuchsia.py:
 Use path_finder.py instead of sequences of '..'

* Move Tools/webkitpy/pylintrc to tools/blinkpy/

* Move Tools/apache_config to tools/
  blinkpy.web_tests.port depends on it.

* Move Tools/Scripts/webkitruby/PrettyPatch to tools/blinkruby
  blinkpy/common/prettypatch.py depends on it.

* Remove blinkpy.common.add_webkitpy

* Drop webkitpy from test-webkitpy targets


Bug: 829697
Change-Id: Idb5c25e62b906f763adddb11b6e876135ce3488f
Reviewed-on: https://chromium-review.googlesource.com/1023620
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552966}

AudioParam has a new attribute, automationRate, to allow the user to choose whether
the AudioParam is "a-rate" or "k-rate".  Add support for setting and getting
the attribute.

Update all AudioParams to support a-rate and k-rate when allowed.

Spec: https://webaudio.github.io/web-audio-api/#dom-audioparam-automationrate
Intent: https://groups.google.com/a/chromium.org/d/msg/blink-dev/extLjVzLw7s/9XUZvQqcBQAJ

Bug: 828947
Change-Id: Ibb9fe8bc0dedf3cfdcf33727734b5d66e5a7ca2f
Reviewed-on: https://chromium-review.googlesource.com/945076
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552965}

The spec issue is now fixed, and this CL follows the spec change[1].

1: https://github.com/whatwg/fetch/commit/14858d3e9402285a7ff3b5e47a22896ff3adc95d

Bug: 791324
Change-Id: Ic3e3955f43578b38fc44a5a6b2a1b43d56a2becb
Reviewed-on: https://chromium-review.googlesource.com/1023613Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552964}

The current threshold came from my local experiments and it wouldn't be
necessarily an appropriate value. Make the threshold configurable so
that we can run experiments in the real world.

Bug: 776665
Change-Id: I6ae896439eb50985221258b9109f6f06e3aea178
Reviewed-on: https://chromium-review.googlesource.com/1022410
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552963}

Removes API getWebContents/getContainerView from ContentViewCore.
ContentViewCore object is passed around in numerous cases just
to get WebContents/container view from it. Embedders already has
access to its container view (through Tab instance for Chrome,
AwContents for WebView). So passing WebContents instead is enough.

And content layer gets the active container view through
WebContents.getViewAndroidDelegate added by https://crrev.com/c/994500.

Bug: 598880
Change-Id: Ic3abd837a8751be6f1aacbe3364901e92db8b1cc
Reviewed-on: https://chromium-review.googlesource.com/1015457
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552962}

Fix LayerTreeHostFiltersPixelTest.BackgroundFilterBlurOutsets has 3474 pixel differences on Loongson.

Set percentage_pixels_large_error on Loongson.

BUG= 819110
R= fsamuel@chromium.org

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I680f9c5f2eb36f8387bf4e5edf5cfe19da2108e3
Reviewed-on: https://chromium-review.googlesource.com/1023710Reviewed-by: enne <enne@chromium.org>
Commit-Queue: 汪 清 <wangqing-hf@loongson.cn>
Cr-Commit-Position: refs/heads/master@{#552961}

Set percentage_pixels_large_error on Loongson.

BUG= 819075
R= fsamuel@chromium.org

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I684f2aa6c27e521212ca0f4faac3b966bb3064d9
Reviewed-on: https://chromium-review.googlesource.com/1023002Reviewed-by: enne <enne@chromium.org>
Commit-Queue: 汪 清 <wangqing-hf@loongson.cn>
Cr-Commit-Position: refs/heads/master@{#552960}

This patch removes a leftover "/*" from the copyright header of the file.

Notry: True
Change-Id: I2d44da15a07e9003756647dfc631a8e813259380
Reviewed-on: https://chromium-review.googlesource.com/1025180Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552959}

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ib5b868a0a581ad8e66bd49208b3262dc79251b4f
Reviewed-on: https://chromium-review.googlesource.com/1023157Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552958}

This reverts commit 70038d92.

Reason for revert: Flakiness may have been resolved with recent changes on tip of tree. No longer seems to repro on local build.

Original change's description:
> Reland "Disable WebRtcBrowserTest.NegotiateNonCryptoCall on Mac"
> 
> This reverts commit b909c213.
> 
> Reason for revert: Re-Disable the flaky test until a fix is found
> 
> Original change's description:
> > Revert "Disable WebRtcBrowserTest.NegotiateNonCryptoCall on Mac"
> > 
> > This reverts commit cfec3da6.
> > 
> > Reason for revert: Checking if flakiness is still happening on Mac ASAN bot
> > 
> > Original change's description:
> > > Disable WebRtcBrowserTest.NegotiateNonCryptoCall on Mac
> > >
> > > TBR=chfremer@chromium.org
> > >
> > > Bug: 810321
> > > Change-Id: Ia12ba855ab9fb8e66c9d48c8e66cf91f76f72e08
> > > Reviewed-on: https://chromium-review.googlesource.com/908461
> > > Reviewed-by: Olga Sharonova <olka@chromium.org>
> > > Commit-Queue: Olga Sharonova <olka@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#535381}
> > 
> > TBR=olka@chromium.org,chfremer@chromium.org
> > 
> > # Not skipping CQ checks because original CL landed > 1 day ago.
> > 
> > Bug: 810321
> > Change-Id: I6e021bca934428cf9c94a34d4f0e874c25868033
> > Reviewed-on: https://chromium-review.googlesource.com/1010842
> > Commit-Queue: Christian Fremerey <chfremer@chromium.org>
> > Reviewed-by: Christian Fremerey <chfremer@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#550380}
> 
> TBR=olka@chromium.org,chfremer@chromium.org
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug: 810321
> Change-Id: I68a7e09599e1511e8b4c547e7932e874689ab224
> Reviewed-on: https://chromium-review.googlesource.com/1013018
> Reviewed-by: Christian Fremerey <chfremer@chromium.org>
> Commit-Queue: Christian Fremerey <chfremer@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#550867}

TBR=olka@chromium.org,chfremer@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 810321
Change-Id: Ie796bb3b206c6855d9859d8f18ec008e7ac4892a
Reviewed-on: https://chromium-review.googlesource.com/1024746Reviewed-by: Christian Fremerey <chfremer@chromium.org>
Commit-Queue: Christian Fremerey <chfremer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552957}

We need support notification importance so we update the table.

And we also support "NONE" priority which is corresponding IMPORTANCE_NONE

Bug: b/78328208
Test: None

Change-Id: I249f5392adbc8e386b001f5f29e759b7172cadac
Reviewed-on: https://chromium-review.googlesource.com/1021005Reviewed-by: Eliot Courtney <edcourtney@chromium.org>
Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552956}

The GPU process is launched from the IO thread; so, it cannot
access BrowserMainLoop (should be accessed from the UI thread) to
get the status of startup tracing (crbug.com/828993).

This CL simplifies dealing with startup tracing flags by centralizing
the logic in TraceStartupConfig. Then, we can get information about
startup tracing through TraceStartupConfig, only.

Bug: 828993
Change-Id: Ia868fed264b534526ad054414ae2a1e12f5c0ac5
Reviewed-on: https://chromium-review.googlesource.com/1015647
Commit-Queue: Ehsan Chiniforooshan <chiniforooshan@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552955}

When navigating, make the old RHWVMac dump its ui::Compositor in
TakeFallbackContentFrom, and have the new RWHVMac pick it up.

Ensure that the ui::AcceleratedWidgetMac preserve its contents through
this transition.

This is not enough to completely eliminate all flashes, because the
NSViews in play aren't being atomically swapped.

Bug: 829523
Change-Id: Ica6eab8dcea7a7987e8b7f83dbfd24acb2c6f7c4
Reviewed-on: https://chromium-review.googlesource.com/1023653
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: Saman Sami <samans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552954}

Last user was old Extensions UI, which was recently removed.

Bug: 820187
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I50aeda59349f31b59965437200c6f4cc9eecfca3
Reviewed-on: https://chromium-review.googlesource.com/1025048Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552953}

According to UX spec, if a feature pod button is togglable and has a
detailed view, the icon click should toggle the feature and the label
click should show the detailed view.

This CL changes the behavior of Network feature pod button to follow
this rule.

This CL only supports toggling of WiFi. Supports of other network will
be added later.

TEST=manual
BUG=821671

Change-Id: I052be3b0db647ac88e5c37a9f0fda4fd0187fc39
Reviewed-on: https://chromium-review.googlesource.com/1018261Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552952}

This was broken by
https://chromium-review.googlesource.com/c/chromium/src/+/1016707.

It was exercising three URLLoader destruction paths, with that CL
landed:
* Mojo notification that the data pipe was closed.
* Mojo notification that the URLLoader pipe was closed.
* Noticing the data pipe was closed when trying to write to it.

The above CL made the first case fail with ERR_FAILED and the
other cases fail by just closing the pipe. This CL fixes that.

It also moves the URLLoader pipe closed case to another test,
and re-enables a new test I disabled pre-emptively when
disabling URLLoaderTest.CloseResponseBodyConsumerBeforeProducer,
which was not flaky.

Bug: 832600
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I788b8a4d2819d623fc2e46a7a8109f91c32d0fbc
Reviewed-on: https://chromium-review.googlesource.com/1017441Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552951}

Removing the "shell" capability allows packaged apps to load dynamic libraries
from the package. In addition, it prevents the app from using any
system-provided libraries, in favor of the package supplying all of its
data and dynamic library dependencies.

This CL includes the system libraries from the SDK's "dist" directory in
packages built using the package() GN template.


Bug: 823927
Change-Id: Ibc22913658f73d992e563e829a377be66f61f805
Reviewed-on: https://chromium-review.googlesource.com/1025046Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552950}

Bug: 835577, 835578
Change-Id: I4461cec21b31ee9945afe4e2b1df7c89d9905168
Reviewed-on: https://chromium-review.googlesource.com/1024401
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552949}

Bug: 831423
Test: None
Change-Id: If8e8a2e88d009dfea258b79f6b914444f28816ee
Reviewed-on: https://chromium-review.googlesource.com/1024735Reviewed-by: Dan Erat <derat@chromium.org>
Commit-Queue: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552948}

History expiration is very disk intensive. When the machine wakes from sleep, it
potentially also needs to read its memory from disk, thus causing heavy
contention.

Bug: 808031
Change-Id: If9a4cfac8a0b323489364fc5c9ad7d72bafb0333
Reviewed-on: https://chromium-review.googlesource.com/1024290
Commit-Queue: Erik Chen <erikchen@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552947}

https://webrtc.googlesource.com/src.git/+log/9b20677c4e71..e987f2b76567

$ git log 9b20677c4..e987f2b76 --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I6778b415d4a9f248847f3dd9c36fb9539c95e125
Reviewed-on: https://chromium-review.googlesource.com/1024636
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#552946}

The implementation is no longer going to be trivial, so renaming.

BUG=none
TEST=none
TBR=sadrul@chromium.org

Change-Id: Icad4e8d85d7b2d87e331223247d596d54732e1dc
Reviewed-on: https://chromium-review.googlesource.com/1024635Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552945}

Also, replace WebKit/WebCore in code and file names with "blink."

Bug: 829697
Change-Id: Ia2e9a0ad1748a7fbb0d7b4da7d4143bfbc1e5267
Reviewed-on: https://chromium-review.googlesource.com/1023627Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552944}

The Great Blink mv didn't rename them because they were referred by
generated code. This CL fixes the generator code,
make_instrumenting_probes.py, and rename the files.

Bug: 768828
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I6facdf7b6c0bc681c6883dd46dd68c93c6eed737
Reviewed-on: https://chromium-review.googlesource.com/1015458Reviewed-by: Alexei Filippov <alph@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552943}

Using whitespace breaks ExtensionUpdater query parameter generation.

Bug: 832728
Change-Id: I191d175d623803d4655d22caf422bf7127bdc57c
Reviewed-on: https://chromium-review.googlesource.com/1016138Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552942}

Change-Id: I651c9f0527565d7bab66e2e817f957249e28f131
Reviewed-on: https://chromium-review.googlesource.com/1024882Reviewed-by: Eric Lawrence <elawrence@chromium.org>
Commit-Queue: Nick Harper <nharper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552941}

The permission checking will be done using the extension's
permissions specified in its manifest data, similar to what
is being done in ShellExtensionHostDelegate.

Also moved media_capture_util code to extensions/browser for better
code sharing and add an API for checking media access permission
for a given extension.

Bug: b/78193883
Test: Build
Change-Id: I7bd9d9a771b5a6d8ca719b5480e42f4624a1bb69
Reviewed-on: https://chromium-review.googlesource.com/1022316
Commit-Queue: Peter Qiu <zqiu@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552940}

We also need to record the permission denied when asking for storage
permission before publishing an offline page for sharing in Download
Home.

Bug: 836011
Change-Id: Ief294b69a88054a7201ba6d0ecf8bc53d77b7bc7
Reviewed-on: https://chromium-review.googlesource.com/1024741Reviewed-by: Joy Ming <jming@chromium.org>
Commit-Queue: Yafei Duan <romax@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552939}

Only changed comments. Removed some outdated TODOs by bshe@ or
crbug.com/776464.

TBR=bshe@chromium.org

Bug: None
Change-Id: I3a857bd02c5fbf8b9c454d91b030dcb1ebd10eeb
Reviewed-on: https://chromium-review.googlesource.com/1024740Reviewed-by: Wenzhao (Colin) Zang <wzang@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552938}

Bug: None
Change-Id: I231cffdd854d5ef3876a170b5c4ec7b70cbbafc1
Reviewed-on: https://chromium-review.googlesource.com/1022509Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552937}

CL https://chromium-review.googlesource.com/c/chromium/src/+/1019885 added
another copy of GetUniqueDownloadId(), which causes jumbo builds to fail.
Let's move this duplicated code to download_utils.cc instead.

Change-Id: I39cbae92f33afc9733a47e376a4f67ce9b088c7b
Reviewed-on: https://chromium-review.googlesource.com/1025090Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552936}

As part of bug 800358 I moved loading ResourceBundle earlier
(specificaly to PreEarlyInitialization()). Unfortunately I missed that
OverrideLocaleWithUILanguageList() needs to be called before
this. This means the locales were not being picked up correctly for
Windows. This patch moves calling OverrideLocaleWithUILanguageList()
to before PreEarlyInitialization() so that locales are properly
loaded.

I tried adding a DCHECK that the locales are set before
GetLocaleOverrides() is called, but that appears to break things.

BUG=834372
TEST=see bug

Change-Id: Idb40ee30761034a6c67ac153da3f9cebc9f7de40
Reviewed-on: https://chromium-review.googlesource.com/1025070Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552935}

With Quad layers keeping the content quad high-res and crisp, we can
lower the buffer size of the rest of our UI which doesn't need to be as
high quality as the content quad.

The quality decrease is only barely noticeable on an A/B toggle, and
the performance win is huge (and necessary to get us back to 60fps on a
Pixel XL device).

Bug: 714304
Change-Id: I0f352f88789584e51815baafe0f25d69fb7e8780
Reviewed-on: https://chromium-review.googlesource.com/1024881Reviewed-by: Ian Vollick <vollick@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552934}

For Material Refresh, we want to place the default search provider's
favicon into the location bar while the user is typing search queries.

This CL adds some scaffolding necessary for OmniboxView to provide the
favicon. The actual favicon fetching must be asynchronous, so we need
this extra infrastructure.

I expect this CL to be Part 1/4 or so of the primary implementation.

Bug: 823535
Change-Id: Ia7d6979222fd18e4a34fd1473f00164ecc8a1c7b
Reviewed-on: https://chromium-review.googlesource.com/1022500
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552933}