- 29 Mar, 2017 40 commits
-
-
ericrk authored
Working set limit impacts how many images we will keep locked before going to at-raster. This is different from the cache limit, which impacts how many images we will keep around once unlocked. SW Image Decode Cache doesn't use cache limit, just working set, as it keeps all not-in-use images unlocked and effectively "free". BUG=706470 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2780843002 Cr-Commit-Position: refs/heads/master@{#460461}
-
mfoltz authored
Fix PresentationRequest_sandboxing_error.html. [Patched from https://codereview.chromium.org/2780583003] BUG=705170 Review-Url: https://codereview.chromium.org/2782663002 Cr-Commit-Position: refs/heads/master@{#460460}
-
dtrainor authored
Now that downloads is a foreground service with the summary, we need to manually clean up the summary in code, which means going through the notification service to do it. BUG=706094 Review-Url: https://codereview.chromium.org/2781873002 Cr-Commit-Position: refs/heads/master@{#460459}
-
wnwen authored
Java-side already has the ContextUtils#GetApplicationContext global and no longer needs native to hold the pointer and pass it through jni with every call that needs an application context. BUG=646094 Review-Url: https://codereview.chromium.org/2772343003 Cr-Commit-Position: refs/heads/master@{#460458}
-
Jeff Carpenter authored
Bug: Change-Id: I86774c4f6f9712748cc637f4862cce91ee544159 Reviewed-on: https://chromium-review.googlesource.com/462027Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Jeff Carpenter <jeffcarp@chromium.org> Cr-Commit-Position: refs/heads/master@{#460457}
-
Quinten Yearsley authored
In this CL: - Move files in csswg-test that we want to move - Remove non-test files that won't be present in wpt/css - Change all "csswg-test" to "wpt/css" in W3CImportExpectations Part of this CL overlaps with https://chromium-review.googlesource.com/c/461419/, they could be committed in either order. NOEXPORT=true Bug: 706118 Change-Id: I802ccffe95d29c4c1a7042a5c1671f074fc8c8ee Reviewed-on: https://chromium-review.googlesource.com/461728Reviewed-by:
Jeff Carpenter <jeffcarp@chromium.org> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#460456}
-
braveyao authored
During tab capture, if there is no mouse movement and no local preview, the passive refresh request will always succeed to refresh with the last cached frame, while the compositor update will most probably be dropped. To capture the updated content in time, when there is un-sampled compositor update event, we'll fail the next passive refresh request to enforce an active refresh request. BUG=704257 Review-Url: https://codereview.chromium.org/2770923003 Cr-Commit-Position: refs/heads/master@{#460455}
-
samuong authored
BUG= Review-Url: https://codereview.chromium.org/2767313002 Cr-Commit-Position: refs/heads/master@{#460454}
-
dpapad authored
BUG=706078 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2779873003 Cr-Commit-Position: refs/heads/master@{#460453}
-
bsheedy authored
The single tap sent during the VR screen tap tests wasn't always getting registered since device response can be a bit slow during the VR transition. For the Cardboard case, wait on Javascript to say it received another click event. For the Daydream case, wait on VrShell saying its parent has consumed the event before checking. BUG= Review-Url: https://codereview.chromium.org/2768583002 Cr-Commit-Position: refs/heads/master@{#460452}
-
johnchen authored
W3C spec on WebDriver uses alwaysMatch and firstMatch under capabilities to specify required and desired capabilities. (See https://w3c.github.io/webdriver/webdriver-spec.html#processing-capabilities for details.) This CL is the first step towards making ChromeDriver compliant to this spec. It adds support for capabilities.alwaysMatch, and removes the existing experimental chromeOptions.w3c flag. Support for capabilities.firstMatch will be added in the near future. BUG=chromedriver:1740 Review-Url: https://codereview.chromium.org/2776313003 Cr-Commit-Position: refs/heads/master@{#460451}
-
mustaq authored
Most of the uses of device_supports_touch have been removed already, and device_supports_mouse is already gone. This CL nukes this field w/o any change in existing behavior. BUG=441813 Review-Url: https://codereview.chromium.org/2773403003 Cr-Commit-Position: refs/heads/master@{#460450}
-
jonross authored
There is a Chrome crash caused by the following: - Menu opened - Submenu of the above opened, with only an empty menu item - Context menu nested above the empty menu item - A dragging right-click outside of the context menu, and within the empty menu item - Pressing ESC once the context menu has relaunched Empty menu items cannot be set as selection targets, and we do not allow arrow keys to select them. In a normal mouse over they are ignored. MenuController::OnMouseDragged however was not handling the result of GetMenuPart which signified an empty menu item. It would attempt to update the selection to an invalid state, and would hide the current menu. The subsequent OnMouseReleased would bring back the context menu, as the drag was only hiding the menu, not closing. The subsequent ESC key would then attempt to be processed by the invalid menu set in OnMouseDragged. This change update OnMouseDragged to properly ingore mouse targets of empty menu items. Bringing it inline with the behaviours of OnMouseMoved. TEST=MenuControllerTest.RepostEventToEmptyMenuItem BUG=704846 Review-Url: https://codereview.chromium.org/2778383002 Cr-Commit-Position: refs/heads/master@{#460449} -
esprehn authored
This function is just a glorified if statement over the enum value we pass into it. Inline the two loops into the call sites. We can also remove the check against SelectorQueryTrait::shouldOnlyMatchFirstElement inside the loops since the outer check ensures it's always false. This lets us remove the MatchTraverseRootState enum. It does make the findTraverseRootsAndExecute function bigger, but it removes a bunch of checks in the process. Future patches will simplify further and hopefully shrink the function. BUG=703900 Review-Url: https://codereview.chromium.org/2786493003 Cr-Commit-Position: refs/heads/master@{#460448}
-
fs authored
Some tests were using non-unique names, which triggers a harness error for "newer" versions of testharness.js. Twiddle the relevant names a bit so that they become unique. BUG=705626 Review-Url: https://codereview.chromium.org/2782583002 Cr-Commit-Position: refs/heads/master@{#460447}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/2f3db61fed9c..4a24e10a0b80 $ git log 2f3db61fe..4a24e10a0 --date=short --no-merges --format='%ad %ae %s' 2017-03-29 kjlubick Add skia_use_egl flag 2017-03-28 egdaniel Fix copy offset when uploading initial mip data in Vulkan Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=stephana@chromium.org Change-Id: I32dd8c9eb48cef6f369f99546511d407d7132830 Reviewed-on: https://chromium-review.googlesource.com/462315Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#460446}
-
khorimoto authored
Previously, it used a reference which had already been deleted. The single callback case correctly used the copy, but the list callback did not. BUG=672263 Review-Url: https://codereview.chromium.org/2777343006 Cr-Commit-Position: refs/heads/master@{#460445}
-
brettw authored
It should be clear that people can TBR certain types of updates to the bootstrap script. Review-Url: https://codereview.chromium.org/2776313004 Cr-Commit-Position: refs/heads/master@{#460444}
-
skyostil authored
Command line wrappers (e.g., --renderer-cmd-prefix) were previously split into individual arguments purely based on whitespace. This fails if the prefix has arguments with embedded whitespace (e.g., gdb -ex "set height 0"). This patch fixes the issue by tokenizing the prefix based on whitespace while using ' and " as quote characters. BUG=546953 Review-Url: https://codereview.chromium.org/2778173003 Cr-Commit-Position: refs/heads/master@{#460443}
-
sky authored
You can see what the old code was like here, specifically lines 393 and 395 https://chromium.googlesource.com/chromium/src/+/2c407ccc88aae08641fcb667277df2b08a2f251a/chrome/browser/ui/views/chrome_views_delegate.cc BUG=none TEST=none R=erg@chromium.org Review-Url: https://codereview.chromium.org/2780033003 Cr-Commit-Position: refs/heads/master@{#460442}
-
lfg authored
Linux. BUG=706148 TBR=scheib@chromium.org,stgao@chromium.org,alexmos@chromium.org Review-Url: https://codereview.chromium.org/2785553004 Cr-Commit-Position: refs/heads/master@{#460441}
-
jbudorick authored
The forwarder has been using a CommandLine object to run its `adb -s <serial> forward --remove <port>` command since October. CommandLine::AppendSwitchesAndArguments mangles that adb command into `adb -s --remove <serial> forward <port>` in its attempt to keep switches before arguments. That mangled command is not valid, and adb never unmaps the port as a result. The host forwarder recognized this as a failure, though not a fatal one, and removed the port from its serial->port map regardless of whether the unmap command succeeded. This patch adds a variant of base::GetAppOutputAndError that takes a vector<string> s.t. arguments are not reordered. (A similar variant already exists for base::GetAppOutput.) It also switches all uses of base::GetAppOutputWithExitCode to this new variant. BUG=691654 Review-Url: https://codereview.chromium.org/2736053003 Cr-Commit-Position: refs/heads/master@{#460440}
-
khorimoto authored
[CrOS Tether] Ensure that BleAdvertiser explicitly calls Unregister() on all advertisements after they are done being used. The previous implementation relied on the BluetoothAdvertisement's destructor calling Unregister(), but there are some situations in which the BLE framework holds onto references to the advertisements, resulting in their destructors not being called. This fix explicitly calls Unregister() on each advertisement. BUG=672263 Review-Url: https://codereview.chromium.org/2782743002 Cr-Commit-Position: refs/heads/master@{#460439}
-
rbpotter authored
BUG=432870 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2771823005 Cr-Commit-Position: refs/heads/master@{#460438}
-
wnwen authored
Chrome no longer updates the filter unless it is fixed positioned. BUG=701521 Review-Url: https://codereview.chromium.org/2775233003 Cr-Commit-Position: refs/heads/master@{#460437}
-
qinmin authored
This CL adds more UMA to record parallel download status, so that we can study how parallel requests will impact download. BUG=644352 Review-Url: https://codereview.chromium.org/2769933003 Cr-Commit-Position: refs/heads/master@{#460436}
-
thestig authored
Simplify code, remove dead code, fix nits. Review-Url: https://codereview.chromium.org/2742763002 Cr-Commit-Position: refs/heads/master@{#460435}
-
juliatuttle authored
Reporting is a spec for delivering out-of-band reports from various other parts of the browser. See http://wicg.github.io/reporting/ for the spec, or https://goo.gl/pygX5I for details of the planned implementation in Chromium. This implements the header parser, which parses Report-To headers and applies the correct updates to the Reporting cache. BUG=704259 Review-Url: https://codereview.chromium.org/2689953004 Cr-Commit-Position: refs/heads/master@{#460434}
-
Pawel Hajdan, Jr authored
BUG=none R=brettw@chromium.org Review-Url: https://codereview.chromium.org/2781063002 . Cr-Commit-Position: refs/heads/master@{#460433}
-
petewil authored
We had been using a 4 minute max timeout in ChromeBackgroundServcieWatier. However, the GCM NM docs state that we are only guaranteed 3 minutes. So, I'm backing off the 4 minute timeout to just under 3 minutes. Also, since I wrote the file, others have added a mechanism to restore tasks if Google Play Services (GPS) upgrades, I added a similar mechanism for OfflinePages. BUG=705584 Review-Url: https://codereview.chromium.org/2780643002 Cr-Commit-Position: refs/heads/master@{#460432}
-
ranj authored
Before users need to manually refresh the page to see new nearby urls. With this patch, new urls will be automatically appended to WebUI result. BUG=692111 Review-Url: https://codereview.chromium.org/2741823002 Cr-Commit-Position: refs/heads/master@{#460431}
-
robliao authored
This also adds support for COM STA Task Runner for TaskSchedulerImpl as well as ScopedTaskScheduler. BUG=662122 Review-Url: https://codereview.chromium.org/2768873007 Cr-Commit-Position: refs/heads/master@{#460430}
-
sammiequon authored
There is a flag which lets user choose if they want to force clamshell/touchView mode regardless of device orientation(s). This CL applys the functionality of that flag. TEST=ash_unittests --gtest_filter="MaximizeModeControllerTest.Force*" BUG=701135 Review-Url: https://codereview.chromium.org/2775683002 Cr-Commit-Position: refs/heads/master@{#460429}
-
fsamuel authored
If the bounds of a WindowTreeHost changes and the cc::LocalSurfaceId provided is valid, then plumb that cc::LocalSurfaceId to the ui::Compositor to be used to generate the next CompositorFrame. BUG=672962 Review-Url: https://codereview.chromium.org/2785703002 Cr-Commit-Position: refs/heads/master@{#460428}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c2373de0..b7dd32be Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2785533004 Cr-Commit-Position: refs/heads/master@{#460427}
-
olivierrobin authored
If page is distilled, show - Date of distillation in relative format (1 hour ago, 2 days ago). - The size of distillation files in human readable format. BUG=694451 Review-Url: https://codereview.chromium.org/2751833005 Cr-Commit-Position: refs/heads/master@{#460426}
-
xlai authored
TBR=zmo@chromium.org TBR_REASON=Updating test expectations after reference images are generated BUG=697582 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2777763005 Cr-Commit-Position: refs/heads/master@{#460425}
-
michaeldo authored
BUG=704946 Review-Url: https://codereview.chromium.org/2772503006 Cr-Commit-Position: refs/heads/master@{#460424}
-
weiliangc authored
Remove converting to layer id when animation is ticked with element id on LayerTreeHostImpl. Also avoids passing in LayerTreeImpl pointer to property trees. Opacity animation on scrollbar still uses layer id, this is due to scrollbars aren't guaranteed with element id. Work is needed in crbug.com/702832 to address this. BUG=702774 R=ajuma CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2762123004 Cr-Commit-Position: refs/heads/master@{#460423}
-
sebsg authored
BUG=705606 Review-Url: https://codereview.chromium.org/2779813003 Cr-Commit-Position: refs/heads/master@{#460422}
-