- 31 Mar, 2018 23 commits
-
-
Chromium WPT Sync authored
Using wpt-import in Chromium 6ac0ae59. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/14970 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/resources TBR=markdittmer No-Export: true Change-Id: Ia194aeadbaedae4235bc0c3d7c7168c04e3f3ede Reviewed-on: https://chromium-review.googlesource.com/988477 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#547349}
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/bb16e339ce72..62af4e40a8f4 $ git log bb16e339c..62af4e40a --date=short --no-merges --format='%ad %ae %s' 2018-03-30 ehmaldonado gclient setdep: Add support for more use cases 2018-03-30 amatyukhin [cipd] Do not rewrite ERRORLEVEL Created with: roll-dep src/third_party/depot_tools BUG=chromium:760633,chromium:none The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I0d76a0615d81b408fd825f0eb8f12a5fb065b09a Reviewed-on: https://chromium-review.googlesource.com/988690Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#547348}
-
Mike Wasserman authored
Refine existing MouseLeaveTest for more general mouse event testing. (renames, add click handlers, add basic test, cleanup helpers and html) Add a test that triggers click/double click handlers in html content. Remove IsX11SendEventTrue filtering to allow ui_controls double clicks. Originally added in https://chromiumcodereview.appspot.com/11761027 (I think to prevent reposted clicks from counting as double clicks) (crrev.com/c/980662's GetRepeatCount timestamp checks should suffice) TODO: try to enable more disabled tests, update cited bugs. Bug: 825695 Test: Automated; no double click when dismissing menus, no regressions. Change-Id: Iefcc2d313b36710a18e5c94079aa5dd75d8500bf Reviewed-on: https://chromium-review.googlesource.com/985904 Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#547347}
-
Peter Kasting authored
* Use in-declaration initializers * NULL -> nullptr * Deinline member functions in non-test class. This is mostly personal preference; it's easier to see which base class functions are being overridden and makes for better line wrapping. * Eliminate unnecessary destructor/DISALLOW_COPY declarations * Add comments * Simplify loop in InfoBarContainerView::Layout() by relying on child order (which it already does) * Remove unnecessary #include * Prefer type alias to typedef BUG=none TEST=none Change-Id: Ie3bd1c083c0a497d2137e437a75ca81f8c764b0a Reviewed-on: https://chromium-review.googlesource.com/987329 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#547346}
-
Christopher Cameron authored
The NOTREACHED() in InitAsFullscreen has failed appear in crashes, so I suspect that this has been dead code for a while now. Bug: 821651 Change-Id: Ia057b630b8ebb89bc570884979bbd855156e4bf1 Reviewed-on: https://chromium-review.googlesource.com/982580 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#547345}
-
Andrii Shyshkalov authored
R=jchinlee@chromium.org Bug: 790157 Change-Id: I0d85be5822c7add2625772c5b6b4f4dc82652fc7 No-Try: True Reviewed-on: https://chromium-review.googlesource.com/989217 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
Jao-ke Chin-Lee <jchinlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#547344}
-
Bailey Forrest authored
This CL just adds virtual interfaces around the existing classes for the BLE interfaces. No other code changes should be made. BUG=internal b/77282414 TEST=cast_bluetooth_unittests cast_internal_bluetooth_unittests Change-Id: I3891eebb61dd187709ec15bbaac32b962e4c2d9e Reviewed-on: https://chromium-review.googlesource.com/987374 Commit-Queue: Bailey Forrest <bcf@chromium.org> Reviewed-by:
Conley Owens <cco3@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Stephen Lanham <slan@chromium.org> Cr-Commit-Position: refs/heads/master@{#547343}
-
Dale Curtis authored
Experiments showed no benefits to this approach unfortunately. So turn down code and feature flags. Bug: 734813 Change-Id: Ied51da9854ca122b27ad4675bc15e19f22bc643c Reviewed-on: https://chromium-review.googlesource.com/988305Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#547342}
-
Dmitry Gozman authored
The logic of combining something into tracks goes to the model now. We do not glue threads between each other anymore, so cross-process navigation now shows two separate tracks. Bug: 820250 Change-Id: I752e4c40d5362b927e23df92d5a2442aab134c6c Reviewed-on: https://chromium-review.googlesource.com/985618 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#547341}
-
Eugene Ostroukhov authored
Bug: 827490 Change-Id: Id737a5a7d8d781c6e7ea329238ddaae7c2d60ff5 Reviewed-on: https://chromium-review.googlesource.com/988959 Commit-Queue: Eugene Ostroukhov <eostroukhov@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#547340}
-
erikchen authored
When closing a Window on MacViews, this logic would needlessly trigger relayouts for every tab close, causing massive jank. Bug: 826287 Change-Id: I30bac1e8c12eb16305be8c7630082adbeae54c6d Reviewed-on: https://chromium-review.googlesource.com/988853Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#547339}
-
Reilly Grant authored
This change adds logic to the WebUSB device chooser (on desktop) so that when the WebUSB guard permission is set to 'block' the chooser will be automatically dismissed as if the user had not selected any devices. This matches the behavior of the Web Bluetooth chooser and its guard permission. To test this change the WebUsbChooserService class has been refactored so that its shared logic can be reused by tests. A follow-up patch will make WebUsbChooserServiceAndroid also inherit from this class. Bug: 771703 Change-Id: I3f2cc6e96a9ebf039bc15d396d16eb4a0766007e Reviewed-on: https://chromium-review.googlesource.com/987327 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Jun Cai <juncai@chromium.org> Cr-Commit-Position: refs/heads/master@{#547338}
-
Matt Mueller authored
When the feature flag is enabled and the user has opted-in via the SBER2(Scout) pref, verifies certificates with both the platform verifier and the CertVerifyProcBuiltin, and reports if the results differ. Has no user-visible effect, the result from the platform verifier is used as soon as it is complete, and the trial verification is completed in the background. Currently, the trial is only supported on Mac and Linux. Design doc: https://docs.google.com/document/d/1AM1CD42bC6LHWjKg-Hkid_RLr2DH6OMzstH9-pGSi-g/edit Bug: 649026 Change-Id: If5b7e8841a072224aaa748f7bbd5609adb9170a0 Reviewed-on: https://chromium-review.googlesource.com/898388Reviewed-by:
Nathan Parker <nparker@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#547337}
-
Joshua Peraza authored
This CL implements crash/content/app/crashpad.h for linux but does not migrate any clients from breakpad to crashpad. Bug: crashpad:30 Change-Id: I00587795331d39d00c98f36949735c43d3e2e9a4 Reviewed-on: https://chromium-review.googlesource.com/972183 Commit-Queue: Joshua Peraza <jperaza@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#547336}
-
Shimi Zhang authored
Test is flaky on Android, see the flakiness dashboard in the crbug. TBR: ctzsm@chromium.org Bug: 827525 Change-Id: Ie5b099126dcd7cd8aa60c400ea0c3333e3a8e9a4 Reviewed-on: https://chromium-review.googlesource.com/989033Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#547335}
-
Xiaocheng Hu authored
This is a partial revert for r536969 Change TranslateHelper to use a TextContent-like text dump. r536969 is a workaround for a lifecycle violation bug that layout is still dirty after running layout update. It turns out that textContent is not a good text dump for TranslateHelper, as pages may hide arbitrary content (e.g., JSON) in invisible text nodes, which can't be reliably filtered without checking element style or layout. Since we don't always run CapturePageText() with dirty layout, there is no need to always dump textContent. Hence, this patch partially reverts r536969 that, we still dump innerText as long as layout is clean. We dump textContent only when layout is dirty, which is enough to get around the lifecycle violation bug. Bug: 826174 Change-Id: I63e97832caa9858e67992847fb9a22f6405183cb Reviewed-on: https://chromium-review.googlesource.com/984474Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Rachel Blum <groby@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#547334}
-
Eric Holk authored
Testing for a specific number is causing problems and determining the right number is problematic in general, as running out of memory is always a legitimate possiblity. See https://github.com/WebAssembly/design/issues/1167 for more discussion. In light of this, it's best to just remove the test. Bug: Change-Id: I66e248c8ab851bca0c54fa6fe13b6e93e55f1264 Reviewed-on: https://chromium-review.googlesource.com/851081 Commit-Queue: Brad Nelson <bradnelson@chromium.org> Reviewed-by:
Brad Nelson <bradnelson@chromium.org> Cr-Commit-Position: refs/heads/master@{#547333}
-
Siddhartha S authored
This reverts commit 0db71a0d. Reason for revert: Monochrome apk merge is failing because the unwind file for both apk has the same name. Original change's description: > Reland "Enable extracting unwind table on official builds without channel" > > This reverts commit a2474b64. > > Reason for revert: The failure was due to parent CL getting reverted > Relanded parent in: https://chromium-review.googlesource.com/c/chromium/src/+/984452 > > Original change's description: > > Revert "Enable extracting unwind table on official builds without channel" > > > > This reverts commit eb07cea1. > > > > Reason for revert: Windows tryjobs are failing. > > https://logs.chromium.org/v/?s=chromium%2Fbb%2Ftryserver.chromium.win%2Fwin-msvc-rel%2F81420%2F%2B%2Frecipes%2Fsteps%2Fanalyze%2F0%2Fstdout for an example. > > > > ERROR at //base/BUILD.gn:1802:33: Undefined identifier in string expansion. > > "CAN_UNWIND_WITH_CFI_TABLE=$can_unwind_with_cfi_table", > > ^------------------------ > > "can_unwind_with_cfi_table" is not currently in scope. > > See //BUILD.gn:65:5: which caused the file to be included. > > "//base:base_perftests", > > ^---------------------- > > GN gen failed: 1 > > > > Original change's description: > > > Enable extracting unwind table on official builds without channel > > > > > > This CL enables extraction of unwind tables for chrome when > > > is_official_build is set to true and when android_channel is not set to > > > a release channel. This affects build time only on official builds. > > > Also, Set legacy heap profiler to use unwinder for profiling. > > > > > > TBR=dpranke@chromium.org > > > BUG=819888 > > > > > > Change-Id: If9732b5ac1f9dff49c58e88e2ffb6cb387715244 > > > Reviewed-on: https://chromium-review.googlesource.com/976944 > > > Reviewed-by: Siddhartha S <ssid@chromium.org> > > > Reviewed-by: agrieve <agrieve@chromium.org> > > > Commit-Queue: Siddhartha S <ssid@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#546425} > > > > TBR=dpranke@chromium.org,ssid@chromium.org,agrieve@chromium.org > > > > Change-Id: Id033094871dfcf74248f631390f15f379d9cd3c7 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 819888 > > Reviewed-on: https://chromium-review.googlesource.com/983893 > > Reviewed-by: agrieve <agrieve@chromium.org> > > Commit-Queue: agrieve <agrieve@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#546478} > > TBR=dpranke@chromium.org,ssid@chromium.org,agrieve@chromium.org > > Change-Id: I100f540c8d5bc9f59b9631ea207c7f290dc42e96 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 819888 > Reviewed-on: https://chromium-review.googlesource.com/985112 > Commit-Queue: Siddhartha S <ssid@chromium.org> > Reviewed-by: Siddhartha S <ssid@chromium.org> > Cr-Commit-Position: refs/heads/master@{#547196} TBR=dpranke@chromium.org,ssid@chromium.org,agrieve@chromium.org Change-Id: Ifa59a5882b18c2634bcf96c2c1fc58b09d7f303f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 819888 Reviewed-on: https://chromium-review.googlesource.com/989153Reviewed-by:
Siddhartha S <ssid@chromium.org> Commit-Queue: Siddhartha S <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#547332}
-
Dale Curtis authored
Crash reporting shows that the following devices all experience crashes in the same place when testing resolutions: 0x1002 0x9850 26.22% Mullins [Radeon R3 Graphics] 0x1002 0x9830 23.78% Kabini [Radeon HD 8400 / R3 Series] 0x1002 0x9874 15.85% 0x1002 0x6821 12.80% Venus XT [Radeon HD 8870M / R9 M270X] 0x1002 0x9851 9.76% Mullins [Radeon R4/R5 Graphics] 0x1002 0x130f 4.88% Kaveri [Radeon R7 Graphics] 0x1002 0x983d 3.66% Temash [Radeon HD 8250/8280G] 0x1002 0x67b1 1.83% Hawaii PRO [Radeon R9 290] 0x1002 0x6798 0.61% Tahiti XT [Radeon HD 7970/8970 OEM / R9 280X] 0x1002 0x130a 0.61% Kaveri [Radeon R6 Graphics] So add them to the blacklist. Since the list is getting a little long, switch it to uint16_t, sort it, and switch to a binary search instead of a linear scan. BUG=822644 TEST=builds. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I10951afeb39a08f1fa465b6157017925fe69326b Reviewed-on: https://chromium-review.googlesource.com/988794Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#547331}
-
Marijn Kruisselbrink authored
Bug: 712693 Change-Id: I65a7fd3086fe2e2c2e0177462eb97b7b864c1c11 Reviewed-on: https://chromium-review.googlesource.com/988739Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#547330}
-
Andrii Shyshkalov authored
* mac_chromium_10.10 * mac_chromium_10.13_rel_ng Also, fix LUCI configs: * fix mac_chromium_10.10 name * add missing buildbot mac_chromium_10.13 in LUCI UI. R=jbudorick@chromium.org, shenghuazhang@chromium.org Bug: 807149, 764174 Change-Id: I38ec38630358000e70a9451f30fcbf363b8d7217 No-Try: True Reviewed-on: https://chromium-review.googlesource.com/989114Reviewed-by:
Shenghua Zhang <shenghuazhang@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Cr-Commit-Position: refs/heads/master@{#547329}
-
Thomas Anderson authored
This reverts commit 65582739. Reason for revert: Causes failure on Win x64 Builder: https://ci.chromium.org/buildbot/chromium.win/Win%20x64%20Builder%20(dbg)/64392 Original change's description: > Change AAGUID of AttestedCredentialData to array > > Since AAGUID always has fixed size(16), change |aaguid_| of > AttestedCredentialData from std::vector<uint8_t> to std::array<uint8_t, > 16>. > > Bug: 780078 > Change-Id: If30dd55b6e88e38f2a6ab53365a6724cf29892a5 > Reviewed-on: https://chromium-review.googlesource.com/981682 > Commit-Queue: Jun Choi <hongjunchoi@chromium.org> > Reviewed-by: Balazs Engedy <engedy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#547321} TBR=engedy@chromium.org,hongjunchoi@chromium.org Change-Id: Iab663a0617a364cb11c10beb1759f1543fb485fb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 780078 Reviewed-on: https://chromium-review.googlesource.com/989152Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#547328}
-
Bret Sepulveda authored
We're eventually going to launch pixel canvas on Windows and Linux, so the flag should be available on those platforms for testing. It will now should up in about:flags. Bug: 765723, 765724 Change-Id: Iba85b34b60f4a92075693cff27e1c59671594e6c Reviewed-on: https://chromium-review.googlesource.com/988836Reviewed-by:
Malay Keshav <malaykeshav@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#547327}
-
- 30 Mar, 2018 17 commits
-
-
Wenzhao Zang authored
Purely renaming. TBR=bshe@chromium.org Bug: None Change-Id: Ia4eae1c6cc69ecfef0522bb052e2c98a94ffe193 Reviewed-on: https://chromium-review.googlesource.com/988682Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#547326}
-
Tom Sepez authored
Coverage by fuzzers is lacking compared to coverage by unit test HTTPParsersTest.cpp Change-Id: I958c1217d26850621d1333072622eb0d3fb72e4d Reviewed-on: https://chromium-review.googlesource.com/988333 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Abhishek Arya <inferno@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#547325}
-
Candice Sy authored
Check flag when determining status text for a failed download attempt. When the flag is enabled, descriptive status texts should be used for downloads that failed due to an actionable error. Descriptive status texts still are TBD. When the flag is disabled, use generic "Download failed." Bug: 824931 Change-Id: I2d67a7c3213a3a57a39b72eeae7433a6b847283e Reviewed-on: https://chromium-review.googlesource.com/982520 Commit-Queue: Candice Sy <cmsy@google.com> Reviewed-by:
Cathy Li <chili@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Joy Ming <jming@chromium.org> Cr-Commit-Position: refs/heads/master@{#547324}
-
Devlin Cronin authored
Features can be restricted to a maximum manifest version. Remove all features restricted to manifest v1. In practice, this only includes the "background_page" manifest feature. Bug: 816677 Change-Id: I6ecea6c04f3afffc8c01848dc892683c0b63d29e Reviewed-on: https://chromium-review.googlesource.com/953174Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#547323}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/63114b0c..81094bec Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ib404190fb2f51cdc9c05e620a0cdece0965eb059 Reviewed-on: https://chromium-review.googlesource.com/988492Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#547322}
-
Jun Choi authored
Since AAGUID always has fixed size(16), change |aaguid_| of AttestedCredentialData from std::vector<uint8_t> to std::array<uint8_t, 16>. Bug: 780078 Change-Id: If30dd55b6e88e38f2a6ab53365a6724cf29892a5 Reviewed-on: https://chromium-review.googlesource.com/981682 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#547321}
-
Chris Harrelson authored
Any empty rect suffices to make it correct to return the empty rect when computing visual rects in graphics layer space. Bug:825125 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I332183a7b31e877fef01bab91fd9e835b828b9e5 Reviewed-on: https://chromium-review.googlesource.com/987401 Commit-Queue: Tien-Ren Chen <trchen@chromium.org> Reviewed-by:
Tien-Ren Chen <trchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#547320}
-
Mark Pearson authored
Corresponds to cr/189992450 Change-Id: I225f9d98fa8a32a72e77a774a85ba8387657c4d1 Reviewed-on: https://chromium-review.googlesource.com/974128Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#547319}
-
Kristian H. Kristensen authored
This reverts commit 7c475ee7. Reason for revert: We've fixed the issue where eglCreateImageKHR fails with ARGB+AFBC and reverted CL:985033 which enabled blending for the lowest order plane, which doesn't work everywhere. Original change's description: > Revert "Reland "ozone/drm: Render primary framebuffers as RGBA"" > > This reverts commit 292706da. > > Reason for revert: breaks RK3399, where we don't have ARGB+AFBC support yet: > > https://bugs.chromium.org/p/chromium/issues/detail?id=826973 > > once > > https://chrome-internal-review.googlesource.com/c/chromeos/vendor/mali-ddk/+/597023 > > lands we can reland. > > Original change's description: > > Reland "ozone/drm: Render primary framebuffers as RGBA" > > > > This is a reland of 48d1ecaf > > > > With CL:967415 and CL:964984, we've fixed the issues where RGBA > > framebuffers slipped through to KMS on devices without RGBA support. > > > > Original change's description: > > > ozone/drm: Render primary framebuffers as RGBA > > > > > > In preparation for hardware plane underlay support in ChromeOS, we > > > need to allow for RGBA primary framebuffers. When using an underlay, > > > we cut out a transparent rectangle in the primary framebuffer to allow > > > the underlay to show through, while still allowing for RGBA content on > > > top of the underlay (for example, video controls or annotations). > > > When not using an underlay, the primary framebuffer will be displayed > > > as RGBX (opaque) to avoid unnecessary blending in the display > > > controller. > > > > > > Bug: 789288 > > > Change-Id: I2fc94e524e250ec9b7e11cd6801e1c8308046a10 > > > Reviewed-on: https://chromium-review.googlesource.com/801974 > > > Reviewed-by: Alex Sakhartchouk <alexst@chromium.org> > > > Reviewed-by: Stéphane Marchesin <marcheu@chromium.org> > > > Reviewed-by: David Reveman <reveman@chromium.org> > > > Reviewed-by: danakj <danakj@chromium.org> > > > Reviewed-by: Antoine Labour <piman@chromium.org> > > > Reviewed-by: Daniele Castagna <dcastagna@chromium.org> > > > Commit-Queue: Kristian H. Kristensen <hoegsberg@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#542877} > > > > TBR: piman > > Bug: 789288 > > Change-Id: Ie1032615d8970c6a74f354ad78c30679706e40ed > > Reviewed-on: https://chromium-review.googlesource.com/975782 > > Commit-Queue: Daniele Castagna <dcastagna@chromium.org> > > Reviewed-by: Alex Sakhartchouk <alexst@chromium.org> > > Reviewed-by: Daniele Castagna <dcastagna@chromium.org> > > Reviewed-by: David Reveman <reveman@chromium.org> > > Reviewed-by: Stéphane Marchesin <marcheu@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#545503} > > TBR=avi@chromium.org,marcheu@chromium.org,reveman@chromium.org,sky@chromium.org,danakj@chromium.org,alexst@chromium.org,dcastagna@chromium.org,piman@chromium.org,hoegsberg@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 789288 > Change-Id: I980fb2dda940cf0b9bdfbdb8b88c2c519f5e9f85 > Reviewed-on: https://chromium-review.googlesource.com/985255 > Reviewed-by: Alexander Alekseev <alemate@chromium.org> > Commit-Queue: Daniele Castagna <dcastagna@chromium.org> > Cr-Commit-Position: refs/heads/master@{#546734} TBR=avi@chromium.org,marcheu@chromium.org,reveman@chromium.org,sky@chromium.org,danakj@chromium.org,alexst@chromium.org,alemate@chromium.org,dcastagna@chromium.org,piman@chromium.org,hoegsberg@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 789288 Change-Id: I8c98951eff5db24ed7066694b18eb00043b63c27 Reviewed-on: https://chromium-review.googlesource.com/988673Reviewed-by:
David Reveman <reveman@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#547318}
-
Scott Violet authored
In https://chromium-review.googlesource.com/c/chromium/src/+/985769 I changed VariationsServiceTest.RequestsInitiallyNotAllowed to call PerformPreMainMessageLoopStartup(). That turns out problematic for branded builds, because PerformPreMainMessageLoopStartup() calls to IsFetchingEnabled(), which returns true and results in doing more processing the test isn't expecting. This works in non-branded builds, because IsFetchingEnabled() returns false. The fix is to move Init()'ing the resource_request_allowed_notifier_ to a separate function that this test and PerformPreMainMessageLoopStartup() call. BUG=827607,826930 TEST=covered by test Change-Id: I89e31b3856cbf67c5ac74ebf85c1694256d8a740 Reviewed-on: https://chromium-review.googlesource.com/988952Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#547317}
-
Nick Carter authored
Rename SCHEME_WITHOUT_PORT to SCHEME_WITH_HOST. Rename SCHEME_WITH_PORT to SCHEME_WITH_HOST_PORT_AND_USER_INFORMATION. Add calls to url::Shutdown() in a few places, to reset the registration info. This is done in preparation for stripping "username:password@" from URLs with schemes that don't support it. TBR=rogerta@chromium.org,fukino@chromium.org,sdefresne@chromium.org Bug: 606001 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I0eeef29a19b1b6d842b946f705c0f1442ce2c17c Reviewed-on: https://chromium-review.googlesource.com/978450 Commit-Queue: Nick Carter <nick@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#547316}
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/63e216c6ef92..bb16e339ce72 $ git log 63e216c6e..bb16e339c --date=short --no-merges --format='%ad %ae %s' 2018-03-30 ehmaldonado gclient: Search also for URL + '.git' when looking for dependencies. Created with: roll-dep src/third_party/depot_tools BUG=chromium:643346 The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Ib8b3c1a93aa1f4b2f21a0047d6568c12c27a1587 Reviewed-on: https://chromium-review.googlesource.com/988872 Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#547315}
-
Andrii Shyshkalov authored
They specify respective 10.xx Mac dimension only on triggered isolated tests. R=jbudorick@chromium.org, shenghuazhang@chromium.org Bug: 826308,807149,826252,731360 Change-Id: I987cea13459d4014129ea3ec8e14303f0a4f4ddb Reviewed-on: https://chromium-review.googlesource.com/988677Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Shenghua Zhang <shenghuazhang@chromium.org> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Cr-Commit-Position: refs/heads/master@{#547314}
-
Wenzhao Zang authored
https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/6eff8cb7641c..388a231904b1 $ git log 6eff8cb76..388a23190 --date=short --no-merges --format='%ad %ae %s' 2018-03-27 wzang system_api: add SetRlzPingSent method name 2018-03-28 matthewmwang system_api: adding constants for FTEnabled support 2018-03-12 sonnysasaka bluetooth: Add newblued object manager service constants. Created with: roll-dep src/third_party/cros_system_api Bug: NONE Change-Id: Ifbb37a916030de7fe0a1a7b1e27fe5144b015692 Reviewed-on: https://chromium-review.googlesource.com/988812Reviewed-by:
Xiaoyin Hu <xiaoyinh@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#547313}
-
Joshua Peraza authored
Bug: crashpad:30 Change-Id: I07e2be079c95825c57481ac8b53cf6e790443be1 Reviewed-on: https://chromium-review.googlesource.com/986658 Commit-Queue: Joshua Peraza <jperaza@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#547312}
-
https://chromium.googlesource.com/catapult.git/+log/f10f4be830a9..36c8db92200b $ git log f10f4be83..36c8db922 --date=short --no-merges --format='%ad %ae %s' 2018-03-29 dtu [pinpoint] Add `server` parameter to the isolate service. 2018-03-29 dtu [pinpoint] Add `server` parameter to the swarming service. Created with: roll-dep src/third_party/catapult BUG=chromium:822008,chromium:822008 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: Ifb4518c0a47cc60721f7e4d089d3331f8a51d811 Reviewed-on: https://chromium-review.googlesource.com/988736Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#547311}
-
Jacob Dufault authored
Bug: 826773 Change-Id: I87d6b02a47f4acf628fb1e6184f70b7ef6a7615b Reviewed-on: https://chromium-review.googlesource.com/988656 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#547310}
-